- Devel - libvirt List Archives

[libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am
by Andrea Bolognani 12 Apr '19

12 Apr '19

Vim has trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help it out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Changes from [v1]: * drop emacs annotation; * switch from filetype=make to filetype=automake. [v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00867.html src/access/Makefile.inc.am | 2 ++ src/admin/Makefile.inc.am | 2 ++ src/bhyve/Makefile.inc.am | 2 ++ src/conf/Makefile.inc.am | 2 ++ src/cpu/Makefile.inc.am | 2 ++ src/cpu_map/Makefile.inc.am | 2 ++ src/esx/Makefile.inc.am | 2 ++ src/hyperv/Makefile.inc.am | 2 ++ src/interface/Makefile.inc.am | 2 ++ src/libxl/Makefile.inc.am | 2 ++ src/locking/Makefile.inc.am | 2 ++ src/logging/Makefile.inc.am | 2 ++ src/lxc/Makefile.inc.am | 2 ++ src/network/Makefile.inc.am | 2 ++ src/node_device/Makefile.inc.am | 2 ++ src/nwfilter/Makefile.inc.am | 2 ++ src/openvz/Makefile.inc.am | 2 ++ src/phyp/Makefile.inc.am | 2 ++ src/qemu/Makefile.inc.am | 2 ++ src/remote/Makefile.inc.am | 2 ++ src/rpc/Makefile.inc.am | 2 ++ src/secret/Makefile.inc.am | 2 ++ src/security/Makefile.inc.am | 2 ++ src/storage/Makefile.inc.am | 2 ++ src/test/Makefile.inc.am | 2 ++ src/util/Makefile.inc.am | 2 ++ src/vbox/Makefile.inc.am | 2 ++ src/vmware/Makefile.inc.am | 2 ++ src/vmx/Makefile.inc.am | 2 ++ src/vz/Makefile.inc.am | 2 ++ src/xenapi/Makefile.inc.am | 2 ++ src/xenconfig/Makefile.inc.am | 2 ++ 32 files changed, 64 insertions(+) diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am index 6d57ca1a1b..4dc742f4e5 100644 --- a/src/access/Makefile.inc.am +++ b/src/access/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ACCESS_DRIVER_GENERATED = \ access/viraccessapicheck.h \ access/viraccessapicheck.c \ diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index 19afb0e179..4cc588a47c 100644 --- a/src/admin/Makefile.inc.am +++ b/src/admin/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x ADMIN_PROTOCOL_GENERATED = \ diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index fba1b9ef30..36af5d7504 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.c \ bhyve/bhyve_capabilities.h \ diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am index 6eb64db9de..3e9fdd1aea 100644 --- a/src/conf/Makefile.inc.am +++ b/src/conf/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NETDEV_CONF_SOURCES = \ conf/netdev_bandwidth_conf.h \ conf/netdev_bandwidth_conf.c \ diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am index 5020d40583..0abeee87b6 100644 --- a/src/cpu/Makefile.inc.am +++ b/src/cpu/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + CPU_SOURCES = \ cpu/cpu.h \ cpu/cpu.c \ diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9d7cef15c5..5634dd9348 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + cpumapdir = $(pkgdatadir)/cpu_map cpumap_DATA = \ cpu_map/index.xml \ diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am index 152dd7b979..2d55c6573c 100644 --- a/src/esx/Makefile.inc.am +++ b/src/esx/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ESX_DRIVER_SOURCES = \ esx/esx_private.h \ esx/esx_driver.c \ diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am index a768272b72..51be8bcacc 100644 --- a/src/hyperv/Makefile.inc.am +++ b/src/hyperv/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + HYPERV_DRIVER_SOURCES = \ hyperv/hyperv_private.h \ hyperv/hyperv_driver.c \ diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 08b35d040d..339a92786b 100644 --- a/src/interface/Makefile.inc.am +++ b/src/interface/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + INTERFACE_DRIVER_SOURCES = \ interface/interface_driver.h \ interface/interface_driver.c \ diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 59c136bf4e..7f60b449d8 100644 --- a/src/libxl/Makefile.inc.am +++ b/src/libxl/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c \ libxl/libxl_conf.h \ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index 5d5e923769..da26fab91f 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + DRIVER_SOURCES += \ locking/lock_manager.c \ locking/lock_manager.h \ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 3f4a87d91a..f5eba2a4f7 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LOG_PROTOCOL_GENERATED = \ logging/log_protocol.h \ logging/log_protocol.c \ diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8dd2e9ea9e..f27827c1e9 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LXC_MONITOR_PROTOCOL_GENERATED = \ lxc/lxc_monitor_protocol.h \ lxc/lxc_monitor_protocol.c \ diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index cbaaa7ea68..3fed59c13b 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h \ network/bridge_driver.c \ diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am index 0c3ad51273..3e04651e8c 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NODE_DEVICE_DRIVER_SOURCES = \ node_device/node_device_driver.c \ node_device/node_device_driver.h \ diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am index 27aa801095..810ca54bcc 100644 --- a/src/nwfilter/Makefile.inc.am +++ b/src/nwfilter/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h \ nwfilter/nwfilter_driver.c \ diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am index baad737362..93bf3b9c96 100644 --- a/src/openvz/Makefile.inc.am +++ b/src/openvz/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + OPENVZ_DRIVER_SOURCES = \ openvz/openvz_conf.c \ openvz/openvz_conf.h \ diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am index 496ff25266..315f1c36ee 100644 --- a/src/phyp/Makefile.inc.am +++ b/src/phyp/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + PHYP_DRIVER_SOURCES = \ phyp/phyp_driver.c \ phyp/phyp_driver.h \ diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 8d10e1085a..fd32a90d56 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + QEMU_DRIVER_SOURCES = \ qemu/qemu_agent.c \ qemu/qemu_agent.h \ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 13a1f9f8f2..06714249b4 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + REMOTE_DRIVER_GENERATED = \ remote/remote_protocol.c \ remote/remote_protocol.h \ diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index 722ef64db1..68a4945198 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + EXTRA_DIST += \ rpc/gendispatch.pl \ rpc/genprotocol.pl \ diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index 79c2b2d74a..7a1c8f8e1a 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + SECRET_DRIVER_SOURCES = \ secret/secret_driver.h \ secret/secret_driver.c \ diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index b24cdfd083..7fb6d8cc4f 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \ $(DATATYPES_SOURCES) \ security/virt-aa-helper.c \ diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index b4400b556f..ea4681f70e 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + STORAGE_DRIVER_BACKEND_SOURCES = \ storage/storage_backend.h \ storage/storage_backend.c \ diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am index d52c281545..c20541a368 100644 --- a/src/test/Makefile.inc.am +++ b/src/test/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + TEST_DRIVER_SOURCES = \ test/test_driver.c \ test/test_driver.h \ diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index 58874cca3c..f44d3b3b2a 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 8c76f84e82..15f7b78416 100644 --- a/src/vbox/Makefile.inc.am +++ b/src/vbox/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VBOX_DRIVER_SOURCES = \ vbox/vbox_glue.c \ vbox/vbox_glue.h \ diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am index 0fbf866030..2c8c2d9884 100644 --- a/src/vmware/Makefile.inc.am +++ b/src/vmware/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VMWARE_DRIVER_SOURCES = \ vmware/vmware_driver.c \ vmware/vmware_driver.h \ diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am index b9bf6ef690..429bdfe51e 100644 --- a/src/vmx/Makefile.inc.am +++ b/src/vmx/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VMX_SOURCES = \ vmx/vmx.c \ vmx/vmx.h \ diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index cacdb38795..a3a146c627 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VZ_DRIVER_SOURCES = \ vz/vz_driver.h \ vz/vz_driver.c \ diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am index 4640e9943f..b6e4ed0bdb 100644 --- a/src/xenapi/Makefile.inc.am +++ b/src/xenapi/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c \ xenapi/xenapi_driver.h \ diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am index a87d69990f..cd751029d2 100644 --- a/src/xenconfig/Makefile.inc.am +++ b/src/xenconfig/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + XENCONFIG_SOURCES = \ xenconfig/xenxs_private.h \ xenconfig/xen_common.c \ -- 2.20.1

2 1

[libvirt] RFC: remove qemu commandline parsing?
by Cole Robinson 12 Apr '19

12 Apr '19

qemu/qemu_parse_command.c powers 'sudo virsh domxml-from-native qemu-argv', parsing a qemu command line and attempting to turn it into libvirt domain XML. Some history: RFE: https://www.redhat.com/archives/libvir-list/2009-April/msg00266.html Patches: https://www.redhat.com/archives/libvir-list/2009-May/msg00321.html danpb blog post about related qemu-attach: https://www.berrange.com/posts/2011/07/13/attaching-libvirt-to-an-externall… At the time it was added, the parser was pretty comprehensive WRT to what libvirt XML features were available at the time. However it's quite hopelessly out of date these days and has been for a long time. As an example, the only -device it knows to parse is virtio-balloon, and it doesn't know anything about -netdev. So the parser can really only handle typical old style qemu options. AFAICT The original motivation for adding this and qemu-attach was providing a more straightforward path for direct qemu users to switch to libvirt. Googling does provide some cases of users successfully converting very simple qemu invocations to libvirt XML. But at least from my experience I don't think these features every really moved the needle in this respect. If anything, it's been that managing qemu has only grown more complex over time, which has made libvirt and tools that use it all the more compelling over launching your own qemu command line (for end users, think manually setting up usb2 with qemu directly). But IMO all that is kind of beside the point. I don't think it's debatable that the code is largely unused, and it hasn't seen many material improvements in the last 5 years, with zero plans to improve it on the horizon. It's 2000+ lines of text processing code living in every libvirtd instance. Deleting it all and making the qemu_driver.c APIs just return errors seems like an easy win considering we are trying to make libvirtd more modular and have a smaller footprint to facilitate usecases like kubevirt Thoughts? - Cole

4 3

[libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am
by Andrea Bolognani 12 Apr '19

12 Apr '19

Both vim and emacs have trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help them out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/access/Makefile.inc.am | 3 +++ src/admin/Makefile.inc.am | 3 +++ src/bhyve/Makefile.inc.am | 3 +++ src/conf/Makefile.inc.am | 3 +++ src/cpu/Makefile.inc.am | 3 +++ src/cpu_map/Makefile.inc.am | 3 +++ src/esx/Makefile.inc.am | 3 +++ src/hyperv/Makefile.inc.am | 3 +++ src/interface/Makefile.inc.am | 3 +++ src/libxl/Makefile.inc.am | 3 +++ src/locking/Makefile.inc.am | 3 +++ src/logging/Makefile.inc.am | 3 +++ src/lxc/Makefile.inc.am | 3 +++ src/network/Makefile.inc.am | 3 +++ src/node_device/Makefile.inc.am | 3 +++ src/nwfilter/Makefile.inc.am | 3 +++ src/openvz/Makefile.inc.am | 3 +++ src/phyp/Makefile.inc.am | 3 +++ src/qemu/Makefile.inc.am | 3 +++ src/remote/Makefile.inc.am | 3 +++ src/rpc/Makefile.inc.am | 3 +++ src/secret/Makefile.inc.am | 3 +++ src/security/Makefile.inc.am | 3 +++ src/storage/Makefile.inc.am | 3 +++ src/test/Makefile.inc.am | 3 +++ src/util/Makefile.inc.am | 3 +++ src/vbox/Makefile.inc.am | 3 +++ src/vmware/Makefile.inc.am | 3 +++ src/vmx/Makefile.inc.am | 3 +++ src/vz/Makefile.inc.am | 3 +++ src/xenapi/Makefile.inc.am | 3 +++ src/xenconfig/Makefile.inc.am | 3 +++ 32 files changed, 96 insertions(+) diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am index 6d57ca1a1b..5233a6fc08 100644 --- a/src/access/Makefile.inc.am +++ b/src/access/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ACCESS_DRIVER_GENERATED = \ access/viraccessapicheck.h \ access/viraccessapicheck.c \ diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index 19afb0e179..d3300d57ff 100644 --- a/src/admin/Makefile.inc.am +++ b/src/admin/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x ADMIN_PROTOCOL_GENERATED = \ diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index fba1b9ef30..ebd576f334 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.c \ bhyve/bhyve_capabilities.h \ diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am index 6eb64db9de..2040220378 100644 --- a/src/conf/Makefile.inc.am +++ b/src/conf/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NETDEV_CONF_SOURCES = \ conf/netdev_bandwidth_conf.h \ conf/netdev_bandwidth_conf.c \ diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am index 5020d40583..3508158fab 100644 --- a/src/cpu/Makefile.inc.am +++ b/src/cpu/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + CPU_SOURCES = \ cpu/cpu.h \ cpu/cpu.c \ diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9d7cef15c5..39d98f8ce7 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + cpumapdir = $(pkgdatadir)/cpu_map cpumap_DATA = \ cpu_map/index.xml \ diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am index 152dd7b979..95846baea5 100644 --- a/src/esx/Makefile.inc.am +++ b/src/esx/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ESX_DRIVER_SOURCES = \ esx/esx_private.h \ esx/esx_driver.c \ diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am index a768272b72..e5cc06bab7 100644 --- a/src/hyperv/Makefile.inc.am +++ b/src/hyperv/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + HYPERV_DRIVER_SOURCES = \ hyperv/hyperv_private.h \ hyperv/hyperv_driver.c \ diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 08b35d040d..d1c59fa75b 100644 --- a/src/interface/Makefile.inc.am +++ b/src/interface/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + INTERFACE_DRIVER_SOURCES = \ interface/interface_driver.h \ interface/interface_driver.c \ diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 59c136bf4e..86dfb176ca 100644 --- a/src/libxl/Makefile.inc.am +++ b/src/libxl/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c \ libxl/libxl_conf.h \ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index 5d5e923769..1d75223106 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + DRIVER_SOURCES += \ locking/lock_manager.c \ locking/lock_manager.h \ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 3f4a87d91a..05ec5aa197 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LOG_PROTOCOL_GENERATED = \ logging/log_protocol.h \ logging/log_protocol.c \ diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8dd2e9ea9e..a5b00a830d 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LXC_MONITOR_PROTOCOL_GENERATED = \ lxc/lxc_monitor_protocol.h \ lxc/lxc_monitor_protocol.c \ diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index cbaaa7ea68..ae546be0c2 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h \ network/bridge_driver.c \ diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am index 0c3ad51273..c2255bd845 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NODE_DEVICE_DRIVER_SOURCES = \ node_device/node_device_driver.c \ node_device/node_device_driver.h \ diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am index 27aa801095..aabfccd654 100644 --- a/src/nwfilter/Makefile.inc.am +++ b/src/nwfilter/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h \ nwfilter/nwfilter_driver.c \ diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am index baad737362..f88660ee7b 100644 --- a/src/openvz/Makefile.inc.am +++ b/src/openvz/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + OPENVZ_DRIVER_SOURCES = \ openvz/openvz_conf.c \ openvz/openvz_conf.h \ diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am index 496ff25266..2e213413a3 100644 --- a/src/phyp/Makefile.inc.am +++ b/src/phyp/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + PHYP_DRIVER_SOURCES = \ phyp/phyp_driver.c \ phyp/phyp_driver.h \ diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 8d10e1085a..59b970c077 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + QEMU_DRIVER_SOURCES = \ qemu/qemu_agent.c \ qemu/qemu_agent.h \ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 13a1f9f8f2..26e2091434 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + REMOTE_DRIVER_GENERATED = \ remote/remote_protocol.c \ remote/remote_protocol.h \ diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index 722ef64db1..50bdde5d9f 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + EXTRA_DIST += \ rpc/gendispatch.pl \ rpc/genprotocol.pl \ diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index 79c2b2d74a..fa377578ea 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + SECRET_DRIVER_SOURCES = \ secret/secret_driver.h \ secret/secret_driver.c \ diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index b24cdfd083..6d1f749b49 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \ $(DATATYPES_SOURCES) \ security/virt-aa-helper.c \ diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index b4400b556f..a68e58f065 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + STORAGE_DRIVER_BACKEND_SOURCES = \ storage/storage_backend.h \ storage/storage_backend.c \ diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am index d52c281545..8d2201f352 100644 --- a/src/test/Makefile.inc.am +++ b/src/test/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + TEST_DRIVER_SOURCES = \ test/test_driver.c \ test/test_driver.h \ diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index 58874cca3c..ccdca2263f 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 8c76f84e82..2cabe96c1c 100644 --- a/src/vbox/Makefile.inc.am +++ b/src/vbox/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VBOX_DRIVER_SOURCES = \ vbox/vbox_glue.c \ vbox/vbox_glue.h \ diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am index 0fbf866030..6a1b565070 100644 --- a/src/vmware/Makefile.inc.am +++ b/src/vmware/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VMWARE_DRIVER_SOURCES = \ vmware/vmware_driver.c \ vmware/vmware_driver.h \ diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am index b9bf6ef690..b15fe37e62 100644 --- a/src/vmx/Makefile.inc.am +++ b/src/vmx/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VMX_SOURCES = \ vmx/vmx.c \ vmx/vmx.h \ diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index cacdb38795..8e53906cae 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VZ_DRIVER_SOURCES = \ vz/vz_driver.h \ vz/vz_driver.c \ diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am index 4640e9943f..2eee125ae2 100644 --- a/src/xenapi/Makefile.inc.am +++ b/src/xenapi/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c \ xenapi/xenapi_driver.h \ diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am index a87d69990f..861e1c69ce 100644 --- a/src/xenconfig/Makefile.inc.am +++ b/src/xenconfig/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + XENCONFIG_SOURCES = \ xenconfig/xenxs_private.h \ xenconfig/xen_common.c \ -- 2.20.1

2 3

[libvirt] [PATCH v2 0/7] readline: Drop obsolete code, add pkg-config support
by Andrea Bolognani 12 Apr '19

12 Apr '19

Changes from [v1]: * ensure macOS builds don't break by picking up libedit instead of readline. [v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00632.html Andrea Bolognani (7): tools: vsh: Drop obsolete readline compatibility code m4: readline: Fix indentation m4: readline: Comment rl_completion_quote_character() check m4: readline: Extract code setting -D_FUNCTION_DEF m4: readline: Drop extra_LIBS machinery m4: readline: Use pkg-config where possible m4: readline: Add gross kludge for include path m4/virt-readline.m4 | 85 +++++++++++++++++++++++++++------------------ tools/vsh.c | 17 --------- 2 files changed, 51 insertions(+), 51 deletions(-) -- 2.20.1

2 14

[libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails
by Michal Privoznik 12 Apr '19

12 Apr '19

Firstly, virCommandRun() does report an error on failure (which in most cases is more accurate than what we overwrite it with). Secondly, usually errno is not set (or gets overwritten in the cleanup code) which makes virReportSystemError() report useless error messages. Drop all virReportSystemError() calls in cases like this (I've found three occurrences). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I was under impression that I've sent this one earlier. Well, maybe I did not. src/storage/storage_backend_fs.c | 7 +------ src/util/virdnsmasq.c | 10 ++-------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 97148acebe..ae4e9a03a3 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -425,13 +425,8 @@ virStorageBackendExecuteMKFS(const char *device, virCommandAddArg(cmd, device); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, - _("Failed to make filesystem of " - "type '%s' on device '%s'"), - format, device); + if (virCommandRun(cmd, NULL) < 0) return -1; - } return 0; } diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 550f3179ae..42f62682c4 100644 --- a/src/util/virdnsmasq.c +++ b/src/util/virdnsmasq.c @@ -751,22 +751,16 @@ dnsmasqCapsRefreshInternal(dnsmasqCapsPtr caps, bool force) virCommandSetOutputBuffer(cmd, &version); virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, _("failed to run '%s --version': %s"), - caps->binaryPath, version); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } virCommandFree(cmd); cmd = virCommandNewArgList(caps->binaryPath, "--help", NULL); virCommandSetOutputBuffer(cmd, &help); virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, _("failed to run '%s --help': %s"), - caps->binaryPath, help); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } if (virAsprintf(&complete, "%s\n%s", version, help) < 0) goto cleanup; -- 2.21.0

2 1

[libvirt] [PATCH] conf: Fix typo enconding -> encoding
by Andrea Bolognani 12 Apr '19

12 Apr '19

Introduced-by: e0fae78ad550 Spotted-by: Lintian Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed-as: trivial src/conf/domain_audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index ce176f7940..de7386d4c6 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -420,7 +420,7 @@ virDomainAuditHostdev(virDomainObjPtr vm, virDomainHostdevDefPtr hostdev, break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: if (VIR_STRDUP_QUIET(address, mdevsrc->uuidstr) < 0) { - VIR_WARN("OOM while enconding audit message"); + VIR_WARN("OOM while encoding audit message"); goto cleanup; } break; -- 2.20.1

1 0

[libvirt] [PATCH 0/7] vbox: drop support for many old versions
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

Per this link: https://www.virtualbox.org/wiki/Download_Old_Builds VirtualBox 6.0 (active maintenance) VirtualBox 5.2 (active maintenance) VirtualBox 5.1 (no longer supported, support ended 2018/04) VirtualBox 5.0 (no longer supported, support ended 2017/05) VirtualBox 4.3 (no longer supported, support ended 2015/12) VirtualBox 4.2 (no longer supported, support ended 2015/12) VirtualBox 4.1 (no longer supported, support ended 2015/12) VirtualBox 4.0 (no longer supported, support ended 2015/12) We can certainly drop all the 4.x versions. The host OS those are officially supported on are very outdated: eg https://www.virtualbox.org/wiki/Download_Old_Builds_4_3 Linux Hosts: Ubuntu 13.04 ("Raring") / 13.10 ("Saucy") / 14.04 ("Trusty") / 14.10 ("Utopic") i386 | AMD64 Ubuntu 12.10 ("Quantal") i386 | AMD64 Ubuntu 12.04 ("Precise") i386 | AMD64 Ubuntu 10.04 LTS ("Lucid") i386 | AMD64 Debian 7 ("Wheezy") i386 | AMD64 Debian 6 ("Squeeze") i386 | AMD64 openSUSE 12.3 / 13.1 i386 | AMD64 openSUSE 11.4 / 12.1 / 12.2 i386 | AMD64 SUSE Linux Enterprise Server 11 (SLES11) i386 | AMD64 SUSE Linux Enterprise Server 10 (SLES10) i386 | AMD64 Fedora 18 ("Spherical Cow") / Fedora 19 ("Schrödingers Cat") i386 | AMD64 Fedora 17 ("Beefy Miracle") i386 | AMD64 Mandriva 2011.0 i386 | AMD64 Oracle Linux 6 ("OL6") / Red Hat Enterprise Linux 6 ("RHEL6") / CentOS 6 i386 | AMD64 Oracle Linux 5 ("OL5") / Red Hat Enterprise Linux 5 ("RHEL5") / CentOS 5 i386 | AMD64 All distributions i386 | AMD64 Although the catch all "All distributions" suggest it might work with newer distros, they are clearly a second tier from a support POV. All these explicitly targetted distros are outside libvirt's support policy. There is a question as to whether to delete 5.0 and 5.1 support from libvirt. There are no remainining #ifdef VBOX_API_VERSION conditionals in the vbox_tmpl.h file related to code differences between 5.0, 5.1 and 5.2, so keeping them is not a maint burden in code. The main burden is distributing the large vbox_CAPI_v5_0.h and vbox_CAPI_v5_1.h files which are ~1 MB in size (uncompressed) or ~85 kb (xz compressed). IOW versions 5.0 and 5.1 increase the release tarballs by a small amount, but nothing that is too unreasonable vs the overall size of 14 MB for libvirt source. Thus I have kept 5.0 and 5.1 support. VirtualBox 6.0 came out in Dec 2018 and given past practice it would not suprise me if that has API changes impacting libvirt. So some interested party might want to look at supporting that in libvirt. Daniel P. Berrangé (7): vbox: drop support for VirtualBox 4.x releases vbox: drop C API definition for release 4.0 vbox: drop C API definition for release 4.1 vbox: drop C API definition for release 4.2 vbox: drop C API definition for release 4.2.20 vbox: drop C API definition for release 4.3 vbox: drop C API definition for release 4.3.4 src/vbox/Makefile.inc.am | 6 - src/vbox/vbox_CAPI_v4_0.h | 7451 ----------------------- src/vbox/vbox_CAPI_v4_1.h | 7882 ------------------------ src/vbox/vbox_CAPI_v4_2.h | 8855 --------------------------- src/vbox/vbox_CAPI_v4_2_20.h | 9001 ---------------------------- src/vbox/vbox_CAPI_v4_3.h | 10210 ------------------------------- src/vbox/vbox_CAPI_v4_3_4.h | 10321 -------------------------------- src/vbox/vbox_V4_0.c | 37 - src/vbox/vbox_V4_1.c | 37 - src/vbox/vbox_V4_2.c | 13 - src/vbox/vbox_V4_2_20.c | 13 - src/vbox/vbox_V4_3.c | 13 - src/vbox/vbox_V4_3_4.c | 13 - src/vbox/vbox_common.h | 14 +- src/vbox/vbox_storage.c | 14 +- src/vbox/vbox_tmpl.c | 218 +- src/vbox/vbox_uniformed_api.h | 10 +- 17 files changed, 7 insertions(+), 54101 deletions(-) delete mode 100644 src/vbox/vbox_CAPI_v4_0.h delete mode 100644 src/vbox/vbox_CAPI_v4_1.h delete mode 100644 src/vbox/vbox_CAPI_v4_2.h delete mode 100644 src/vbox/vbox_CAPI_v4_2_20.h delete mode 100644 src/vbox/vbox_CAPI_v4_3.h delete mode 100644 src/vbox/vbox_CAPI_v4_3_4.h delete mode 100644 src/vbox/vbox_V4_0.c delete mode 100644 src/vbox/vbox_V4_1.c delete mode 100644 src/vbox/vbox_V4_2.c delete mode 100644 src/vbox/vbox_V4_2_20.c delete mode 100644 src/vbox/vbox_V4_3.c delete mode 100644 src/vbox/vbox_V4_3_4.c -- 2.20.1

1 8

[libvirt] [PATCH 0/2] Add capability-based mlock tests
by Ján Tomko 12 Apr '19

12 Apr '19

Ján Tomko (2): qemuxml2argvtest: add mlock tests for QEMU 3.0.0 qemuxml2argvtest: add mlock tests for latest QEMU .../mlock-off.x86_64-3.0.0.args | 32 +++++++++++++++++++ .../mlock-off.x86_64-latest.args | 32 +++++++++++++++++++ .../mlock-on.x86_64-3.0.0.args | 32 +++++++++++++++++++ .../mlock-on.x86_64-latest.args | 32 +++++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++ 5 files changed, 133 insertions(+) create mode 100644 tests/qemuxml2argvdata/mlock-off.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/mlock-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/mlock-on.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/mlock-on.x86_64-latest.args -- 2.19.2

2 5

[libvirt] [PATCH 0/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'
by Michal Privoznik 12 Apr '19

12 Apr '19

Patches available also at: https://github.com/zippy2/libvirt/tree/qemu_mlock Inspired by the following QEMU patch: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg01980.html Michal Prívozník (3): qemu: Always assume QEMU_CAPS_REALTIME_MLOCK qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock' src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_command.c | 10 ++++------ tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 +- tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 2 +- tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args | 1 + tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 1 + tests/qemuxml2argvdata/aarch64-cpu-passthrough.args | 1 + tests/qemuxml2argvdata/aarch64-gic-host.args | 1 + tests/qemuxml2argvdata/aarch64-gic-none-tcg.args | 1 + tests/qemuxml2argvdata/aarch64-gic-v2.args | 1 + tests/qemuxml2argvdata/aarch64-gic-v3.args | 1 + tests/qemuxml2argvdata/aarch64-kvm-32-on-64.args | 1 + tests/qemuxml2argvdata/aarch64-noacpi-nouefi.args | 1 + tests/qemuxml2argvdata/aarch64-noacpi-uefi.args | 1 + tests/qemuxml2argvdata/aarch64-pci-serial.args | 1 + tests/qemuxml2argvdata/aarch64-traditional-pci.args | 1 + .../aarch64-usb-controller-nec-xhci.args | 1 + .../aarch64-usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/aarch64-video-default.args | 1 + .../qemuxml2argvdata/aarch64-video-virtio-gpu-pci.args | 1 + .../aarch64-virt-2.6-virtio-pci-default.args | 1 + tests/qemuxml2argvdata/aarch64-virt-default-nic.args | 1 + tests/qemuxml2argvdata/aarch64-virt-virtio.args | 1 + tests/qemuxml2argvdata/aarch64-virtio-pci-default.args | 1 + .../aarch64-virtio-pci-manual-addresses.args | 1 + tests/qemuxml2argvdata/acpi-table.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-basic.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-nodevs.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-virtio.args | 1 + tests/qemuxml2argvdata/arm-virt-virtio.args | 1 + tests/qemuxml2argvdata/autoindex.args | 1 + tests/qemuxml2argvdata/balloon-ccw-deflate.args | 1 + tests/qemuxml2argvdata/balloon-device-auto.args | 1 + tests/qemuxml2argvdata/balloon-device-deflate-off.args | 1 + tests/qemuxml2argvdata/balloon-device-deflate.args | 1 + tests/qemuxml2argvdata/balloon-device-period.args | 1 + tests/qemuxml2argvdata/balloon-device.args | 1 + tests/qemuxml2argvdata/balloon-mmio-deflate.args | 1 + tests/qemuxml2argvdata/bios-nvram-secure.args | 1 + tests/qemuxml2argvdata/bios-nvram.args | 1 + tests/qemuxml2argvdata/bios.args | 1 + tests/qemuxml2argvdata/blkdeviotune-group-num.args | 1 + tests/qemuxml2argvdata/blkdeviotune-max-length.args | 1 + tests/qemuxml2argvdata/blkdeviotune-max.args | 1 + tests/qemuxml2argvdata/blkiotune-device.args | 1 + tests/qemuxml2argvdata/blkiotune.args | 1 + tests/qemuxml2argvdata/boot-cdrom.args | 1 + tests/qemuxml2argvdata/boot-complex.args | 1 + tests/qemuxml2argvdata/boot-floppy-q35.args | 1 + tests/qemuxml2argvdata/boot-floppy.args | 1 + tests/qemuxml2argvdata/boot-menu-disable-drive.args | 1 + tests/qemuxml2argvdata/boot-menu-disable.args | 1 + .../boot-menu-enable-with-timeout.args | 1 + tests/qemuxml2argvdata/boot-menu-enable.args | 1 + tests/qemuxml2argvdata/boot-multi.args | 1 + tests/qemuxml2argvdata/boot-network.args | 1 + tests/qemuxml2argvdata/boot-order.args | 1 + tests/qemuxml2argvdata/boot-strict.args | 1 + tests/qemuxml2argvdata/channel-guestfwd.args | 1 + tests/qemuxml2argvdata/channel-spicevmc.args | 1 + .../channel-unix-guestfwd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/channel-virtio-auto.args | 1 + tests/qemuxml2argvdata/channel-virtio-autoadd.args | 1 + tests/qemuxml2argvdata/channel-virtio-autoassign.args | 1 + tests/qemuxml2argvdata/channel-virtio-default.args | 1 + tests/qemuxml2argvdata/channel-virtio-state.args | 1 + tests/qemuxml2argvdata/channel-virtio-unix.args | 1 + tests/qemuxml2argvdata/channel-virtio.args | 1 + tests/qemuxml2argvdata/chardev-reconnect.args | 1 + tests/qemuxml2argvdata/clock-catchup.args | 1 + tests/qemuxml2argvdata/clock-france.args | 1 + tests/qemuxml2argvdata/clock-hpet-off.args | 1 + .../clock-localtime-basis-localtime.args | 1 + tests/qemuxml2argvdata/clock-localtime.args | 1 + tests/qemuxml2argvdata/clock-timer-hyperv-rtc.args | 1 + tests/qemuxml2argvdata/clock-utc.args | 1 + tests/qemuxml2argvdata/clock-variable.args | 1 + tests/qemuxml2argvdata/console-compat-auto.args | 1 + tests/qemuxml2argvdata/console-compat-chardev.args | 1 + tests/qemuxml2argvdata/console-compat.args | 1 + tests/qemuxml2argvdata/console-sclp.args | 1 + tests/qemuxml2argvdata/console-virtio-ccw.args | 1 + tests/qemuxml2argvdata/console-virtio-many.args | 1 + tests/qemuxml2argvdata/console-virtio-s390.args | 1 + .../console-virtio-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/console-virtio.args | 1 + tests/qemuxml2argvdata/controller-order.args | 1 + .../controller-virtio-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 1 + tests/qemuxml2argvdata/cpu-Haswell.args | 1 + tests/qemuxml2argvdata/cpu-Haswell2.args | 1 + tests/qemuxml2argvdata/cpu-Haswell3.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable2.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable3.args | 1 + tests/qemuxml2argvdata/cpu-cache-emulate-l3.args | 1 + tests/qemuxml2argvdata/cpu-cache-passthrough.args | 1 + tests/qemuxml2argvdata/cpu-cache-passthrough2.args | 1 + tests/qemuxml2argvdata/cpu-check-default-none.args | 1 + tests/qemuxml2argvdata/cpu-check-default-none2.args | 1 + tests/qemuxml2argvdata/cpu-check-default-partial.args | 1 + tests/qemuxml2argvdata/cpu-check-default-partial2.args | 1 + tests/qemuxml2argvdata/cpu-check-none.args | 1 + tests/qemuxml2argvdata/cpu-eoi-disabled.args | 1 + tests/qemuxml2argvdata/cpu-eoi-enabled.args | 1 + tests/qemuxml2argvdata/cpu-exact1.args | 1 + tests/qemuxml2argvdata/cpu-exact2-nofallback.args | 1 + tests/qemuxml2argvdata/cpu-exact2.args | 1 + tests/qemuxml2argvdata/cpu-fallback.args | 1 + tests/qemuxml2argvdata/cpu-host-kvmclock.args | 1 + tests/qemuxml2argvdata/cpu-host-model-cmt.args | 1 + tests/qemuxml2argvdata/cpu-host-model-fallback.args | 1 + tests/qemuxml2argvdata/cpu-host-model-vendor.args | 1 + tests/qemuxml2argvdata/cpu-host-model.args | 1 + .../cpu-host-passthrough-features.args | 1 + tests/qemuxml2argvdata/cpu-host-passthrough.args | 1 + tests/qemuxml2argvdata/cpu-hotplug-startup.args | 1 + tests/qemuxml2argvdata/cpu-kvmclock.args | 1 + tests/qemuxml2argvdata/cpu-minimum1.args | 1 + tests/qemuxml2argvdata/cpu-minimum2.args | 1 + tests/qemuxml2argvdata/cpu-numa-disjoint.args | 1 + tests/qemuxml2argvdata/cpu-numa-memshared.args | 1 + tests/qemuxml2argvdata/cpu-numa-no-memory-element.args | 1 + tests/qemuxml2argvdata/cpu-numa1.args | 1 + tests/qemuxml2argvdata/cpu-numa2.args | 1 + tests/qemuxml2argvdata/cpu-s390-features.args | 1 + tests/qemuxml2argvdata/cpu-s390-zEC12.args | 1 + tests/qemuxml2argvdata/cpu-strict1.args | 1 + tests/qemuxml2argvdata/cpu-topology1.args | 1 + tests/qemuxml2argvdata/cpu-topology2.args | 1 + tests/qemuxml2argvdata/cpu-topology3.args | 1 + tests/qemuxml2argvdata/cpu-tsc-frequency.args | 1 + tests/qemuxml2argvdata/cputune-numatune.args | 1 + tests/qemuxml2argvdata/cputune-zero-shares.args | 1 + tests/qemuxml2argvdata/cputune.args | 1 + tests/qemuxml2argvdata/debug-threads.args | 1 + tests/qemuxml2argvdata/default-kvm-host-arch.args | 1 + tests/qemuxml2argvdata/default-qemu-host-arch.args | 1 + tests/qemuxml2argvdata/disk-aio.args | 1 + tests/qemuxml2argvdata/disk-aio.x86_64-latest.args | 2 +- .../disk-backing-chains-noindex.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-blockio.args | 1 + tests/qemuxml2argvdata/disk-boot-cdrom.args | 1 + tests/qemuxml2argvdata/disk-boot-disk.args | 1 + tests/qemuxml2argvdata/disk-cache.x86_64-latest.args | 2 +- .../disk-cdrom-bus-other.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-network.args | 1 + .../disk-cdrom-network.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 1 + .../disk-cdrom-tray.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom.args | 1 + tests/qemuxml2argvdata/disk-cdrom.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 1 + .../disk-copy_on_read.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-detect-zeroes.args | 1 + .../disk-detect-zeroes.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-discard.args | 1 + tests/qemuxml2argvdata/disk-error-policy.args | 1 + .../disk-error-policy.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 1 + tests/qemuxml2argvdata/disk-floppy.args | 1 + tests/qemuxml2argvdata/disk-floppy.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-fmt-qcow.args | 1 + tests/qemuxml2argvdata/disk-geometry.args | 1 + .../disk-hostdev-scsi-virtio-iscsi-auth-AES.args | 1 + tests/qemuxml2argvdata/disk-ide-split.args | 1 + tests/qemuxml2argvdata/disk-ide-wwn.args | 1 + tests/qemuxml2argvdata/disk-ioeventfd.args | 1 + tests/qemuxml2argvdata/disk-iscsi.args | 1 + tests/qemuxml2argvdata/disk-network-gluster.args | 1 + .../disk-network-gluster.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-iscsi-modern.args | 1 + tests/qemuxml2argvdata/disk-network-iscsi.args | 1 + .../disk-network-iscsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-nbd.args | 1 + .../disk-network-nbd.x86_64-latest.args | 2 +- .../disk-network-rbd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-sheepdog.args | 1 + .../disk-network-sheepdog.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-source-auth.args | 1 + .../disk-network-source-auth.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-tlsx509.args | 1 + .../disk-network-tlsx509.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-vxhs.args | 1 + tests/qemuxml2argvdata/disk-no-boot.args | 1 + tests/qemuxml2argvdata/disk-order.args | 1 + tests/qemuxml2argvdata/disk-readonly-disk.args | 1 + .../disk-readonly-disk.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-sata-device.args | 1 + .../disk-scsi-device-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-scsi-disk-split.args | 1 + tests/qemuxml2argvdata/disk-scsi-disk-vpd.args | 1 + tests/qemuxml2argvdata/disk-scsi-disk-wwn.args | 1 + tests/qemuxml2argvdata/disk-scsi-lun-passthrough.args | 1 + tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-serial.args | 1 + tests/qemuxml2argvdata/disk-shared.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-snapshot.args | 1 + tests/qemuxml2argvdata/disk-source-pool-mode.args | 1 + tests/qemuxml2argvdata/disk-source-pool.args | 1 + tests/qemuxml2argvdata/disk-usb-device-removable.args | 1 + tests/qemuxml2argvdata/disk-usb-device.args | 1 + tests/qemuxml2argvdata/disk-virtio-ccw-many.args | 1 + tests/qemuxml2argvdata/disk-virtio-ccw.args | 1 + tests/qemuxml2argvdata/disk-virtio-queues.args | 1 + tests/qemuxml2argvdata/disk-virtio-s390-zpci.args | 1 + tests/qemuxml2argvdata/disk-virtio-s390.args | 1 + .../disk-virtio-scsi-reservations.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio.args | 1 + tests/qemuxml2argvdata/encrypted-disk-usage.args | 1 + tests/qemuxml2argvdata/encrypted-disk.args | 1 + tests/qemuxml2argvdata/eoi-disabled.args | 1 + tests/qemuxml2argvdata/eoi-enabled.args | 1 + tests/qemuxml2argvdata/event_idx.args | 1 + tests/qemuxml2argvdata/fd-memory-no-numa-topology.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology2.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology3.args | 1 + tests/qemuxml2argvdata/fips-enabled.args | 1 + tests/qemuxml2argvdata/floppy-drive-fat.args | 1 + .../floppy-drive-fat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/fs9p-ccw.args | 1 + tests/qemuxml2argvdata/fs9p.args | 1 + tests/qemuxml2argvdata/genid-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/genid.x86_64-latest.args | 2 +- ...graphics-egl-headless-rendernode.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-egl-headless.args | 1 + .../graphics-egl-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-sdl-fullscreen.args | 1 + tests/qemuxml2argvdata/graphics-sdl.args | 1 + .../graphics-spice-agent-file-xfer.args | 1 + tests/qemuxml2argvdata/graphics-spice-agentmouse.args | 1 + .../graphics-spice-auto-socket-cfg.args | 1 + tests/qemuxml2argvdata/graphics-spice-auto-socket.args | 1 + tests/qemuxml2argvdata/graphics-spice-compression.args | 1 + .../qemuxml2argvdata/graphics-spice-egl-headless.args | 1 + ...raphics-spice-gl-auto-rendernode.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-spice-no-args.args | 1 + tests/qemuxml2argvdata/graphics-spice-qxl-vga.args | 1 + tests/qemuxml2argvdata/graphics-spice-sasl.args | 1 + tests/qemuxml2argvdata/graphics-spice-socket.args | 1 + tests/qemuxml2argvdata/graphics-spice-timeout.args | 1 + tests/qemuxml2argvdata/graphics-spice-usb-redir.args | 1 + tests/qemuxml2argvdata/graphics-spice.args | 1 + .../qemuxml2argvdata/graphics-vnc-auto-socket-cfg.args | 1 + tests/qemuxml2argvdata/graphics-vnc-auto-socket.args | 1 + tests/qemuxml2argvdata/graphics-vnc-egl-headless.args | 1 + .../qemuxml2argvdata/graphics-vnc-no-listen-attr.args | 1 + tests/qemuxml2argvdata/graphics-vnc-none.args | 1 + tests/qemuxml2argvdata/graphics-vnc-policy.args | 1 + .../graphics-vnc-remove-generated-socket.args | 1 + tests/qemuxml2argvdata/graphics-vnc-sasl.args | 1 + .../graphics-vnc-socket-new-cmdline.args | 1 + tests/qemuxml2argvdata/graphics-vnc-socket.args | 1 + .../graphics-vnc-tls-secret.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 1 + .../graphics-vnc-tls.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-websocket.args | 1 + tests/qemuxml2argvdata/graphics-vnc.args | 1 + ...-mdev-display-spice-egl-headless.x86_64-latest.args | 2 +- ...ostdev-mdev-display-spice-opengl.x86_64-latest.args | 2 +- ...ev-mdev-display-vnc-egl-headless.x86_64-latest.args | 2 +- .../hostdev-mdev-display-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hostdev-mdev-precreated.args | 1 + tests/qemuxml2argvdata/hostdev-pci-address-device.args | 1 + tests/qemuxml2argvdata/hostdev-pci-address.args | 1 + .../qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-lsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-readonly.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-ccw.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-pci.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-pcie.args | 1 + .../hostdev-scsi-virtio-iscsi-auth.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.args | 1 + .../qemuxml2argvdata/hostdev-subsys-mdev-vfio-ccw.args | 1 + .../hostdev-usb-address-device-boot.args | 1 + tests/qemuxml2argvdata/hostdev-usb-address-device.args | 1 + tests/qemuxml2argvdata/hostdev-usb-address.args | 1 + tests/qemuxml2argvdata/hostdev-vfio-multidomain.args | 1 + .../hostdev-vfio-zpci-autogenerate.args | 1 + .../qemuxml2argvdata/hostdev-vfio-zpci-boundaries.args | 1 + .../hostdev-vfio-zpci-multidomain-many.args | 1 + tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 1 + tests/qemuxml2argvdata/hostdev-vfio.args | 1 + tests/qemuxml2argvdata/hotplug-base.args | 1 + tests/qemuxml2argvdata/hugepages-default-2M.args | 1 + .../hugepages-default-system-size.args | 1 + tests/qemuxml2argvdata/hugepages-default.args | 1 + tests/qemuxml2argvdata/hugepages-memaccess.args | 1 + tests/qemuxml2argvdata/hugepages-memaccess2.args | 1 + tests/qemuxml2argvdata/hugepages-nodeset.args | 1 + tests/qemuxml2argvdata/hugepages-numa-default-2M.args | 1 + .../qemuxml2argvdata/hugepages-numa-default-dimm.args | 1 + tests/qemuxml2argvdata/hugepages-numa-default.args | 1 + .../qemuxml2argvdata/hugepages-numa-nodeset-part.args | 1 + tests/qemuxml2argvdata/hugepages-numa-nodeset.args | 1 + .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-shared.args | 1 + tests/qemuxml2argvdata/hyperv-off.args | 1 + tests/qemuxml2argvdata/hyperv-panic.args | 1 + tests/qemuxml2argvdata/hyperv.args | 1 + tests/qemuxml2argvdata/input-usbmouse-addr.args | 1 + tests/qemuxml2argvdata/input-usbmouse.args | 1 + tests/qemuxml2argvdata/input-usbtablet.args | 1 + tests/qemuxml2argvdata/input-virtio-ccw.args | 1 + tests/qemuxml2argvdata/intel-iommu-caching-mode.args | 1 + tests/qemuxml2argvdata/intel-iommu-device-iotlb.args | 1 + tests/qemuxml2argvdata/intel-iommu-eim.args | 1 + tests/qemuxml2argvdata/intel-iommu-machine.args | 1 + tests/qemuxml2argvdata/intel-iommu.args | 1 + tests/qemuxml2argvdata/iothreads-disk-virtio-ccw.args | 1 + tests/qemuxml2argvdata/iothreads-disk.args | 1 + tests/qemuxml2argvdata/iothreads-ids-partial.args | 1 + tests/qemuxml2argvdata/iothreads-ids.args | 1 + .../iothreads-virtio-scsi-pci.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/iothreads.args | 1 + tests/qemuxml2argvdata/kvm-features-off.args | 1 + tests/qemuxml2argvdata/kvm-features.args | 1 + tests/qemuxml2argvdata/kvm-pit-delay.args | 1 + tests/qemuxml2argvdata/kvm-pit-discard.args | 1 + tests/qemuxml2argvdata/kvmclock+eoi-disabled.args | 1 + tests/qemuxml2argvdata/kvmclock.args | 1 + tests/qemuxml2argvdata/luks-disks-source-qcow2.args | 1 + tests/qemuxml2argvdata/luks-disks-source.args | 1 + tests/qemuxml2argvdata/luks-disks.args | 1 + tests/qemuxml2argvdata/mach-virt-console-virtio.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-native.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-pci.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-usb.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-off-cap.args | 1 + .../qemuxml2argvdata/machine-aeskeywrap-off-caps.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-on-cap.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-on-caps.args | 1 + tests/qemuxml2argvdata/machine-aliases1.args | 1 + tests/qemuxml2argvdata/machine-aliases2.args | 1 + tests/qemuxml2argvdata/machine-core-off.args | 1 + tests/qemuxml2argvdata/machine-core-on.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-off-cap.args | 1 + .../qemuxml2argvdata/machine-deakeywrap-off-caps.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-on-cap.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-on-caps.args | 1 + tests/qemuxml2argvdata/machine-keywrap-none-caps.args | 1 + tests/qemuxml2argvdata/machine-keywrap-none.args | 1 + .../machine-loadparm-multiple-disks-nets-s390.args | 1 + tests/qemuxml2argvdata/machine-loadparm-net-s390.args | 1 + tests/qemuxml2argvdata/machine-loadparm-s390.args | 1 + tests/qemuxml2argvdata/machine-smm-opt.args | 1 + tests/qemuxml2argvdata/machine-vmport-opt.args | 1 + tests/qemuxml2argvdata/master-key.args | 1 + .../memfd-memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memory-hotplug-dimm-addr.args | 1 + tests/qemuxml2argvdata/memory-hotplug-dimm.args | 1 + .../memory-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../qemuxml2argvdata/memory-hotplug-ppc64-nonuma.args | 1 + tests/qemuxml2argvdata/memory-hotplug.args | 1 + tests/qemuxml2argvdata/memtune-unlimited.args | 1 + tests/qemuxml2argvdata/memtune.args | 1 + tests/qemuxml2argvdata/migrate-numa-unaligned.args | 1 + tests/qemuxml2argvdata/migrate.args | 1 + tests/qemuxml2argvdata/minimal-msg-timestamp.args | 1 + tests/qemuxml2argvdata/minimal-sandbox.args | 1 + tests/qemuxml2argvdata/minimal.args | 1 + tests/qemuxml2argvdata/misc-acpi.args | 1 + tests/qemuxml2argvdata/misc-disable-s3.args | 1 + tests/qemuxml2argvdata/misc-disable-suspends.args | 1 + tests/qemuxml2argvdata/misc-enable-s4.args | 1 + tests/qemuxml2argvdata/misc-no-reboot.args | 1 + tests/qemuxml2argvdata/misc-uuid.args | 1 + tests/qemuxml2argvdata/mlock-off.args | 2 +- tests/qemuxml2argvdata/mlock-on.args | 2 +- tests/qemuxml2argvdata/mlock-unsupported.args | 1 + tests/qemuxml2argvdata/monitor-json.args | 1 + tests/qemuxml2argvdata/multifunction-pci-device.args | 1 + tests/qemuxml2argvdata/name-escape.args | 1 + tests/qemuxml2argvdata/net-client.args | 1 + tests/qemuxml2argvdata/net-eth-hostip.args | 1 + tests/qemuxml2argvdata/net-eth-ifname.args | 1 + tests/qemuxml2argvdata/net-eth-names.args | 1 + tests/qemuxml2argvdata/net-eth.args | 1 + tests/qemuxml2argvdata/net-hostdev-bootorder.args | 1 + tests/qemuxml2argvdata/net-hostdev-multidomain.args | 1 + .../qemuxml2argvdata/net-hostdev-vfio-multidomain.args | 1 + tests/qemuxml2argvdata/net-hostdev-vfio.args | 1 + tests/qemuxml2argvdata/net-hostdev.args | 1 + tests/qemuxml2argvdata/net-mcast.args | 1 + tests/qemuxml2argvdata/net-server.args | 1 + tests/qemuxml2argvdata/net-udp.args | 1 + tests/qemuxml2argvdata/net-user-addr.args | 1 + tests/qemuxml2argvdata/net-user.args | 1 + tests/qemuxml2argvdata/net-vhostuser-multiq.args | 1 + tests/qemuxml2argvdata/net-vhostuser.args | 1 + .../qemuxml2argvdata/net-vhostuser.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-virtio-ccw.args | 1 + tests/qemuxml2argvdata/net-virtio-device.args | 1 + .../qemuxml2argvdata/net-virtio-disable-offloads.args | 1 + tests/qemuxml2argvdata/net-virtio-netdev.args | 1 + tests/qemuxml2argvdata/net-virtio-rxtxqueuesize.args | 1 + tests/qemuxml2argvdata/net-virtio-s390.args | 1 + tests/qemuxml2argvdata/net-virtio.args | 1 + tests/qemuxml2argvdata/nosharepages.args | 1 + .../numad-auto-memory-vcpu-cpuset.args | 1 + ...numad-auto-memory-vcpu-no-cpuset-and-placement.args | 1 + .../numad-auto-vcpu-static-numatune.args | 1 + .../numad-static-memory-auto-vcpu.args | 1 + tests/qemuxml2argvdata/numad.args | 1 + .../numatune-auto-nodeset-invalid.args | 1 + tests/qemuxml2argvdata/numatune-auto-prefer.args | 1 + tests/qemuxml2argvdata/numatune-distances.args | 1 + tests/qemuxml2argvdata/numatune-memnode-no-memory.args | 1 + tests/qemuxml2argvdata/numatune-memnode.args | 1 + tests/qemuxml2argvdata/numatune-memory.args | 1 + .../os-firmware-bios.x86_64-latest.args | 2 +- .../os-firmware-efi-secboot.x86_64-latest.args | 2 +- .../os-firmware-efi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.args | 1 + tests/qemuxml2argvdata/pages-discard-hugepages.args | 1 + tests/qemuxml2argvdata/pages-discard.args | 1 + tests/qemuxml2argvdata/panic-double.args | 1 + tests/qemuxml2argvdata/panic-no-address.args | 1 + tests/qemuxml2argvdata/panic.args | 1 + tests/qemuxml2argvdata/parallel-parport-chardev.args | 1 + tests/qemuxml2argvdata/parallel-tcp-chardev.args | 1 + .../parallel-unix-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 1 + tests/qemuxml2argvdata/pci-autoadd-idx.args | 1 + tests/qemuxml2argvdata/pci-autofill-addr.args | 1 + tests/qemuxml2argvdata/pci-bridge-many-disks.args | 1 + tests/qemuxml2argvdata/pci-bridge.args | 1 + tests/qemuxml2argvdata/pci-expander-bus.args | 1 + tests/qemuxml2argvdata/pci-many.args | 1 + tests/qemuxml2argvdata/pci-rom-disabled.args | 1 + tests/qemuxml2argvdata/pci-rom.args | 1 + tests/qemuxml2argvdata/pci-serial-dev-chardev.args | 1 + tests/qemuxml2argvdata/pcie-expander-bus.args | 1 + .../qemuxml2argvdata/pcie-root-port-model-generic.args | 1 + .../qemuxml2argvdata/pcie-root-port-model-ioh3420.args | 1 + tests/qemuxml2argvdata/pcie-root-port.args | 1 + tests/qemuxml2argvdata/pcie-root.args | 1 + .../qemuxml2argvdata/pcie-switch-downstream-port.args | 1 + tests/qemuxml2argvdata/pcie-switch-upstream-port.args | 1 + tests/qemuxml2argvdata/pcihole64-q35.args | 1 + tests/qemuxml2argvdata/pcihole64.args | 1 + tests/qemuxml2argvdata/pmu-feature-off.args | 1 + tests/qemuxml2argvdata/pmu-feature.args | 1 + tests/qemuxml2argvdata/ppc-dtb.args | 1 + .../ppc64-pseries-graphics.ppc64-latest.args | 2 +- .../ppc64-pseries-headless.ppc64-latest.args | 2 +- .../qemuxml2argvdata/ppc64-usb-controller-legacy.args | 1 + .../ppc64-usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/ppc64-usb-controller.args | 1 + tests/qemuxml2argvdata/ppce500-serial.args | 1 + tests/qemuxml2argvdata/pseries-basic.args | 1 + tests/qemuxml2argvdata/pseries-console-virtio.args | 1 + tests/qemuxml2argvdata/pseries-cpu-compat-power9.args | 1 + tests/qemuxml2argvdata/pseries-cpu-compat.args | 1 + tests/qemuxml2argvdata/pseries-cpu-exact.args | 1 + tests/qemuxml2argvdata/pseries-cpu-le.args | 1 + tests/qemuxml2argvdata/pseries-features.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-1.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-2.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-3.args | 1 + .../pseries-machine-max-cpu-compat.args | 1 + tests/qemuxml2argvdata/pseries-many-buses-1.args | 1 + tests/qemuxml2argvdata/pseries-many-buses-2.args | 1 + tests/qemuxml2argvdata/pseries-many-devices.args | 1 + tests/qemuxml2argvdata/pseries-nvram.args | 1 + tests/qemuxml2argvdata/pseries-panic-missing.args | 1 + tests/qemuxml2argvdata/pseries-panic-no-address.args | 1 + .../qemuxml2argvdata/pseries-phb-default-missing.args | 1 + tests/qemuxml2argvdata/pseries-phb-numa-node.args | 1 + tests/qemuxml2argvdata/pseries-phb-simple.args | 1 + tests/qemuxml2argvdata/pseries-serial-native.args | 1 + tests/qemuxml2argvdata/pseries-serial-pci.args | 1 + tests/qemuxml2argvdata/pseries-serial-usb.args | 1 + tests/qemuxml2argvdata/pseries-usb-default.args | 1 + tests/qemuxml2argvdata/pseries-usb-kbd.args | 1 + tests/qemuxml2argvdata/pseries-usb-multi.args | 1 + tests/qemuxml2argvdata/pseries-vio-user-assigned.args | 1 + tests/qemuxml2argvdata/pseries-vio.args | 1 + tests/qemuxml2argvdata/pv-spinlock-disabled.args | 1 + tests/qemuxml2argvdata/pv-spinlock-enabled.args | 1 + tests/qemuxml2argvdata/q35-acpi-nouefi.args | 1 + tests/qemuxml2argvdata/q35-acpi-uefi.args | 1 + tests/qemuxml2argvdata/q35-default-devices-only.args | 1 + tests/qemuxml2argvdata/q35-multifunction.args | 1 + tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 1 + tests/qemuxml2argvdata/q35-pci-force-address.args | 1 + tests/qemuxml2argvdata/q35-pcie-autoadd.args | 1 + tests/qemuxml2argvdata/q35-pcie.args | 1 + tests/qemuxml2argvdata/q35-pm-disable-fallback.args | 1 + tests/qemuxml2argvdata/q35-pm-disable.args | 1 + tests/qemuxml2argvdata/q35-usb2-multi.args | 1 + tests/qemuxml2argvdata/q35-usb2-reorder.args | 1 + tests/qemuxml2argvdata/q35-usb2.args | 1 + tests/qemuxml2argvdata/q35-virt-manager-basic.args | 1 + tests/qemuxml2argvdata/q35-virtio-pci.args | 1 + tests/qemuxml2argvdata/q35.args | 1 + tests/qemuxml2argvdata/qemu-ns-alt.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline-ns1.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline.args | 1 + .../qemu-ns-domain-commandline-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-domain-commandline.args | 1 + tests/qemuxml2argvdata/qemu-ns-domain-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-no-env.args | 1 + tests/qemuxml2argvdata/qemu-ns.args | 1 + tests/qemuxml2argvdata/reboot-timeout-disabled.args | 1 + tests/qemuxml2argvdata/reboot-timeout-enabled.args | 1 + tests/qemuxml2argvdata/restore-v2-fd.args | 1 + tests/qemuxml2argvdata/restore-v2.args | 1 + .../riscv64-virt-headless.riscv64-latest.args | 2 +- tests/qemuxml2argvdata/riscv64-virt-pci.args | 1 + tests/qemuxml2argvdata/riscv64-virt.args | 1 + .../s390-allow-bogus-usb-controller.args | 1 + tests/qemuxml2argvdata/s390-allow-bogus-usb-none.args | 1 + tests/qemuxml2argvdata/s390-panic-missing.args | 1 + tests/qemuxml2argvdata/s390-panic-no-address.args | 1 + tests/qemuxml2argvdata/s390-serial-2.args | 1 + tests/qemuxml2argvdata/s390-serial-console.args | 1 + tests/qemuxml2argvdata/s390-serial.args | 1 + tests/qemuxml2argvdata/seclabel-dac-none.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-baselabel.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-labelskip.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-override.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-relabel.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic.args | 1 + tests/qemuxml2argvdata/seclabel-none.args | 1 + tests/qemuxml2argvdata/seclabel-static-labelskip.args | 1 + tests/qemuxml2argvdata/seclabel-static-relabel.args | 1 + tests/qemuxml2argvdata/seclabel-static.args | 1 + tests/qemuxml2argvdata/serial-dev-chardev-iobase.args | 1 + tests/qemuxml2argvdata/serial-dev-chardev.args | 1 + tests/qemuxml2argvdata/serial-file-chardev.args | 1 + tests/qemuxml2argvdata/serial-file-log.args | 1 + tests/qemuxml2argvdata/serial-many-chardev.args | 1 + tests/qemuxml2argvdata/serial-pty-chardev.args | 1 + tests/qemuxml2argvdata/serial-spiceport-nospice.args | 1 + tests/qemuxml2argvdata/serial-spiceport.args | 1 + tests/qemuxml2argvdata/serial-tcp-chardev.args | 1 + tests/qemuxml2argvdata/serial-tcp-telnet-chardev.args | 1 + .../serial-tcp-tlsx509-chardev-notls.args | 1 + .../serial-tcp-tlsx509-chardev-verify.args | 1 + tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.args | 1 + .../serial-tcp-tlsx509-secret-chardev.args | 1 + tests/qemuxml2argvdata/serial-udp-chardev.args | 1 + tests/qemuxml2argvdata/serial-unix-chardev.args | 1 + .../serial-unix-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 1 + tests/qemuxml2argvdata/shmem-plain-doorbell.args | 1 + tests/qemuxml2argvdata/shmem.args | 1 + tests/qemuxml2argvdata/smartcard-controller.args | 1 + .../smartcard-host-certificates-database.args | 1 + .../qemuxml2argvdata/smartcard-host-certificates.args | 1 + tests/qemuxml2argvdata/smartcard-host.args | 1 + .../smartcard-passthrough-spicevmc.args | 1 + tests/qemuxml2argvdata/smartcard-passthrough-tcp.args | 1 + .../smartcard-passthrough-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/smbios.args | 1 + tests/qemuxml2argvdata/smp.args | 1 + tests/qemuxml2argvdata/sound-device.args | 1 + tests/qemuxml2argvdata/sound.args | 1 + .../tpm-emulator-tpm2.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/tpm-emulator.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/tpm-passthrough-crb.args | 1 + tests/qemuxml2argvdata/tpm-passthrough.args | 1 + .../tseg-explicit-size.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/usb-controller-default-q35.args | 1 + .../qemuxml2argvdata/usb-controller-explicit-q35.args | 1 + tests/qemuxml2argvdata/usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/usb-controller-xhci.args | 1 + tests/qemuxml2argvdata/usb-controller.args | 1 + tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.args | 1 + tests/qemuxml2argvdata/usb-hub-autoadd.args | 1 + tests/qemuxml2argvdata/usb-hub.args | 1 + tests/qemuxml2argvdata/usb-ich9-autoassign.args | 1 + tests/qemuxml2argvdata/usb-ich9-companion.args | 1 + tests/qemuxml2argvdata/usb-ich9-ehci-addr.args | 1 + tests/qemuxml2argvdata/usb-long-port-path.args | 1 + tests/qemuxml2argvdata/usb-none.args | 1 + tests/qemuxml2argvdata/usb-piix3-controller.args | 1 + tests/qemuxml2argvdata/usb-port-autoassign.args | 1 + tests/qemuxml2argvdata/usb-port-missing.args | 1 + tests/qemuxml2argvdata/usb-ports.args | 1 + tests/qemuxml2argvdata/usb-redir-boot.args | 1 + tests/qemuxml2argvdata/usb-redir-filter-version.args | 1 + tests/qemuxml2argvdata/usb-redir-filter.args | 1 + .../qemuxml2argvdata/usb-redir-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/usb-redir.args | 1 + tests/qemuxml2argvdata/usb-xhci-autoassign.args | 1 + tests/qemuxml2argvdata/usb1-usb2.args | 1 + tests/qemuxml2argvdata/user-aliases-usb.args | 1 + tests/qemuxml2argvdata/user-aliases.args | 1 + tests/qemuxml2argvdata/vcpu-placement-static.args | 1 + .../vhost-vsock-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock.x86_64-latest.args | 2 +- .../qemuxml2argvdata/video-device-pciaddr-default.args | 1 + tests/qemuxml2argvdata/video-none-device.args | 1 + tests/qemuxml2argvdata/video-qxl-device-vgamem.args | 1 + .../video-qxl-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-device.args | 1 + tests/qemuxml2argvdata/video-qxl-heads.args | 1 + tests/qemuxml2argvdata/video-qxl-nodevice.args | 1 + tests/qemuxml2argvdata/video-qxl-noheads.args | 1 + .../qemuxml2argvdata/video-qxl-sec-device-vgamem.args | 1 + .../video-qxl-sec-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-sec-device.args | 1 + tests/qemuxml2argvdata/video-vga-device-vgamem.args | 1 + tests/qemuxml2argvdata/video-vga-device.args | 1 + tests/qemuxml2argvdata/video-vga-nodevice.args | 1 + tests/qemuxml2argvdata/video-vga-qxl-heads.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-ccw.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-device.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-secondary.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-spice-gl.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-virgl.args | 1 + tests/qemuxml2argvdata/video-virtio-vga.args | 1 + tests/qemuxml2argvdata/virtio-input-passthrough.args | 1 + tests/qemuxml2argvdata/virtio-input.args | 1 + tests/qemuxml2argvdata/virtio-lun.args | 1 + .../virtio-non-transitional.x86_64-3.1.0.args | 2 +- .../virtio-non-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-options.args | 1 + tests/qemuxml2argvdata/virtio-rng-ccw.args | 1 + tests/qemuxml2argvdata/virtio-rng-default.args | 1 + .../virtio-rng-egd-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-rng-egd.args | 1 + tests/qemuxml2argvdata/virtio-rng-multiple.args | 1 + tests/qemuxml2argvdata/virtio-rng-random.args | 1 + .../virtio-transitional.x86_64-3.1.0.args | 2 +- .../virtio-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vmcoreinfo.args | 1 + tests/qemuxml2argvdata/watchdog-device.args | 1 + tests/qemuxml2argvdata/watchdog-diag288.args | 1 + tests/qemuxml2argvdata/watchdog-dump.args | 1 + tests/qemuxml2argvdata/watchdog-injectnmi.args | 1 + tests/qemuxml2argvdata/watchdog.args | 1 + tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 1 + .../x86_64-pc-graphics.x86_64-latest.args | 2 +- .../x86_64-pc-headless.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 2 +- .../x86_64-q35-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 5 ++--- 688 files changed, 663 insertions(+), 126 deletions(-) -- 2.21.0

2 7

[libvirt] [jenkins-ci PATCH] guests: Remove SASL symlink kludge
by Andrea Bolognani 12 Apr '19

12 Apr '19

It's no longer needed as of libvirt commit ab6f29c6da12. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/kludges.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml index 9d4f232..708e7a4 100644 --- a/guests/playbooks/update/tasks/kludges.yml +++ b/guests/playbooks/update/tasks/kludges.yml @@ -9,9 +9,7 @@ force: yes with_items: - include/readline - - include/sasl - lib/libreadline.so - - lib/libsasl2.so when: - os_name == 'FreeBSD' -- 2.20.1

2 1