- Devel - libvirt List Archives

[libvirt] [PATCH] network: avoid including sys/sysctl.h on Linux
by Daniel P. Berrangé 26 Jun '19

26 Jun '19

The sys/sysctl.h header is only needed on BSD platforms to get the sysctlbyname() function declaration. On Linux we talk to procfs instead to change sysctls. Unfortunately a legacy sys/sysctl.h header does exist on Linux and including it has recently started triggering a deprecation warning from glibc. Protect its inclusion with a HAVE_SYSCTLBYNAME check instead so that it only gets used on platforms where we need that function declaration. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as build fix for Fedora rawhide src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 465487432e..19faf7d514 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -33,7 +33,7 @@ #include <sys/wait.h> #include <sys/ioctl.h> #include <net/if.h> -#if HAVE_SYS_SYSCTL_H +#ifdef HAVE_SYSCTLBYNAME # include <sys/sysctl.h> #endif -- 2.21.0

1 0

[libvirt] [PATCH v3 0/7] cgroups v2 fixes and improvements
by Pavel Hrdina 26 Jun '19

26 Jun '19

Pavel Hrdina (7): util: vircgroup: pass parent cgroup into virCgroupDetectControllersCB util: vircgroup: improve controller detection util: vircgroupv2: use any controller to create thread directory util: vircgroupv2: enable CPU controller only if it's available util: vircgroupv2: separate return values of virCgroupV2EnableController util: vircgroupv2: don't error out if enabling controller fails util: vircgroupv2: mark only requested controllers as available src/util/vircgroup.c | 32 +++++++++--------- src/util/vircgroupbackend.h | 3 +- src/util/vircgroupv1.c | 4 ++- src/util/vircgroupv2.c | 67 +++++++++++++++++++++++++++---------- 4 files changed, 71 insertions(+), 35 deletions(-) -- 2.21.0

2 14

[libvirt] [PATCH v2 0/4] qemu: Fix handling of 'dir' volumes with disk type='volume'
by Peter Krempa 26 Jun '19

26 Jun '19

Peter Krempa (4): util: storage: Fix virStorageSourceGetActualType if volume was not translated qemu: command: Use 'actualType' when deciding whether to use disk format qemu: domain: Allow 'VIR_STORAGE_TYPE_VOLUME' disks with 'fat' format qemu: Supply correct default type for 'dir' based VIR_STORAGE_TYPE_VOLUME src/qemu/qemu_command.c | 2 +- src/qemu/qemu_domain.c | 13 ++++++++++--- src/util/virstoragefile.c | 12 +++++++++++- tests/qemuxml2argvdata/disk-source-pool.args | 8 ++++++++ tests/qemuxml2argvdata/disk-source-pool.xml | 16 +++++++++++++++- tests/qemuxml2xmloutdata/disk-source-pool.xml | 14 ++++++++++++++ 6 files changed, 59 insertions(+), 6 deletions(-) -- 2.21.0

2 8

[libvirt] Live migration fails with "Migration without shared storage is unsafe" when using netapp storage on CentOS 7 and Libvirt 4.5.0
by Marko Todorić 26 Jun '19

26 Jun '19

Hello everyone, We've been using libvirt version 0.10.2 for a long time (on CentOS 6 OS) and now we have started creating new KVM cluster all based on CentOS 7 OS and libvirt version 4.5.0 (that came with CentOS repo). TLDR Version: - When we try to migrate using "virsh migrate test --live qemu+ssh://kvm_aquila-02/system" we get an error "error: Unsafe migration: Migration without shared storage is unsafe". - When we try to migrate using same method but adding "--unsafe" migration works. - When we try to migrate a VPS that is using QCOW image on a shared GFS2 image, mapped on both servers, migration is successful. We have two servers in a cluster so far, they are connected to NetApp storage and all luns that VPS server should be using are mapped to both servers. Long version with background: We have plenty CentOS 6 Servers which work perfectly fine with libvirt version up to 0.10.2. All connected also to a NetApp storage and all luns are mapped to all servers. LUN's (disks) are visible under /dev/mapper directory. When we create VPS, we point to raw disk to the same location, /dev/mapper. For example, VPS "test" would use "/dev/mapper/test" for disk with "cache=none" in xml file. If we issue "virsh migrate test --live qemu+ssh://kvm_server-0X/system", it will successfully migrate VPS to another hypervisor without errors, because disk already exists there. We also have a LUN mapped to each hypervisor and GFS2 established in a cluster between hypervisors where we keep qcow images. We can also migrate those machines without issues. On new CentOS 7 hypervisors, we have pretty much the exact same setup. NetApp storage connected to servers. All VPS LUN's mapped to all hypervisors. Clustered GFS2 volume. When we define VPS with approximately same XML, it will NOT migrate it and will issue out an error stated above. "--unsafe" parameter seems to work fine. BUT. We want to setup a proper libvirt/kvm cluster with pcs. I've defined a pcs resource for each VPS and live migration also doesn't work if i try "pcs resource move" command. It will not migrate it "live" as it should, and as it does with QCOW images, probably because of the same reason - because it's unable to perform live migrate via libvirt without "unsafe". If there would be any trick to add "--unsafe" parameter to pcs i would do it, but I'm not aware of it. Still, seems like a bug that libvirt would not realize that netapp storage is present in this configuration. Is this maybe corrected in later versions of libvirt? Unfortunately, 4.5.0 is latest in CentOS repo but i would try to compile it if needed. Any help would be greatly appreciated and if more info is needed i will be more than happy to provide. Thanks in advance, Marko Todoric

1 1

[libvirt] [PATCH 0/4] tests: Tweaks and updates to *-headless and *-graphics
by Andrea Bolognani 26 Jun '19

26 Jun '19

*** BLURBY MCBLURBFACE *** Andrea Bolognani (4): tests: Normalize quotes for *-graphics tests: Update *-headless and *-graphics tests: Add riscv64-virt-graphics tests: Enable *-headless and *-graphics in qemuxml2xml .../aarch64-virt-graphics.aarch64-latest.args | 6 +- .../aarch64-virt-graphics.xml | 52 ++++---- .../aarch64-virt-headless.aarch64-latest.args | 21 +-- .../aarch64-virt-headless.xml | 22 +++- .../ppc64-pseries-graphics.xml | 49 +++---- .../ppc64-pseries-headless.ppc64-latest.args | 8 +- .../ppc64-pseries-headless.xml | 18 ++- ...riscv64-virt-graphics.riscv64-latest.args} | 18 ++- .../riscv64-virt-graphics.xml | 45 +++++++ .../riscv64-virt-headless.riscv64-latest.args | 16 ++- .../riscv64-virt-headless.xml | 18 ++- .../s390x-ccw-graphics.s390x-latest.args | 6 +- tests/qemuxml2argvdata/s390x-ccw-graphics.xml | 49 +++---- .../s390x-ccw-headless.s390x-latest.args | 12 +- tests/qemuxml2argvdata/s390x-ccw-headless.xml | 21 ++- tests/qemuxml2argvdata/x86_64-pc-graphics.xml | 57 +++++---- .../x86_64-pc-headless.x86_64-latest.args | 23 ++-- tests/qemuxml2argvdata/x86_64-pc-headless.xml | 30 ++++- .../qemuxml2argvdata/x86_64-q35-graphics.xml | 57 +++++---- .../x86_64-q35-headless.x86_64-latest.args | 15 ++- .../qemuxml2argvdata/x86_64-q35-headless.xml | 30 ++++- tests/qemuxml2argvtest.c | 1 + .../aarch64-virt-graphics.aarch64-latest.xml | 115 +++++++++++++++++ .../aarch64-virt-headless.aarch64-latest.xml | 101 +++++++++++++++ .../ppc64-pseries-graphics.ppc64-latest.xml | 75 +++++++++++ .../ppc64-pseries-headless.ppc64-latest.xml | 66 ++++++++++ .../riscv64-virt-graphics.riscv64-latest.xml | 109 ++++++++++++++++ .../riscv64-virt-headless.riscv64-latest.xml | 95 ++++++++++++++ .../s390x-ccw-graphics.s390x-latest.xml | 66 ++++++++++ .../s390x-ccw-headless.s390x-latest.xml | 53 ++++++++ .../x86_64-pc-graphics.x86_64-latest.xml | 82 ++++++++++++ .../x86_64-pc-headless.x86_64-latest.xml | 74 +++++++++++ .../x86_64-q35-graphics.x86_64-latest.xml | 120 ++++++++++++++++++ .../x86_64-q35-headless.x86_64-latest.xml | 112 ++++++++++++++++ tests/qemuxml2xmltest.c | 16 +++ 35 files changed, 1448 insertions(+), 210 deletions(-) copy tests/qemuxml2argvdata/{aarch64-virt-graphics.aarch64-latest.args => riscv64-virt-graphics.riscv64-latest.args} (79%) create mode 100644 tests/qemuxml2argvdata/riscv64-virt-graphics.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-graphics.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/aarch64-virt-headless.aarch64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-pseries-graphics.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/ppc64-pseries-headless.ppc64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/riscv64-virt-graphics.riscv64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/riscv64-virt-headless.riscv64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/s390x-ccw-graphics.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/s390x-ccw-headless.s390x-latest.xml create mode 100644 tests/qemuxml2xmloutdata/x86_64-pc-graphics.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/x86_64-pc-headless.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/x86_64-q35-graphics.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/x86_64-q35-headless.x86_64-latest.xml -- 2.21.0

2 12

[libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace
by Sergei Turchanov 26 Jun '19

26 Jun '19

This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1 fdlist[i] erroneously was replaced by fdlist[1] which caused lxcOpenNamespace to return a list with identical elements. Signed-off-by: Sergei Turchanov <turchanov(a)farpost.com> --- libvirt-lxc-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c index 60c2e48..d7af154 100644 --- a/libvirt-lxc-override.c +++ b/libvirt-lxc-override.c @@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED, goto error; for (i = 0; i < c_retval; i++) - VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error); + VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error); cleanup: VIR_FREE(fdlist); -- 2.17.1

2 1

[libvirt] [PATCH v2] deprecate -mem-path fallback to anonymous RAM
by Igor Mammedov 26 Jun '19

26 Jun '19

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process. Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- v2: * improve text language (Markus Armbruster <armbru(a)redhat.com>) numa.c | 6 ++++-- qemu-deprecated.texi | 9 +++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 91a29138a2..c15e53e92d 100644 --- a/numa.c +++ b/numa.c @@ -494,8 +494,10 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, if (mem_prealloc) { exit(1); } - error_report("falling back to regular RAM allocation."); - + warn_report("falling back to regular RAM allocation"); + error_printf("This is deprecated. Make sure that -mem-path " + " specified path has sufficient resources to allocate" + " -m specified RAM amount or QEMU will fail to start"); /* Legacy behavior: if allocation failed, fall back to * regular RAM allocation. */ diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2fe9b72121..1b7f3b10dc 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -112,6 +112,15 @@ QEMU using implicit generic or board specific splitting rule. Use @option{memdev} with @var{memory-backend-ram} backend or @option{mem} (if it's supported by used machine type) to define mapping explictly instead. +@subsection -mem-path fallback to RAM (since 4.1) +Currently if guest RAM allocation from file pointed by @option{mem-path} +fails, QEMU falls back to allocating from RAM, which might result +in unpredictable behavior since the backing file specified by the user +is ignored. In the future, users will be responsible for making sure +the backing storage specified with @option{-mem-path} can actually provide +the guest RAM configured with @option{-m} and fail to start up if RAM allocation +is unsuccessful. + @section QEMU Machine Protocol (QMP) commands @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) -- 2.18.1

4 4

[libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace
by Sergei Turchanov 26 Jun '19

26 Jun '19

This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1 fdlist[i] erroneously was replaced by fdlist[1] which caused lxcOpenNamespace to return a list with identical elements. --- libvirt-lxc-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c index 60c2e48..d7af154 100644 --- a/libvirt-lxc-override.c +++ b/libvirt-lxc-override.c @@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED, goto error; for (i = 0; i < c_retval; i++) - VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error); + VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error); cleanup: VIR_FREE(fdlist); -- 2.17.1

2 3

[libvirt] [PATCH 00/10] qemu: Refactor disk hotplug code for better reuse with blockdev (blockdev-add saga)
by Peter Krempa 25 Jun '19

25 Jun '19

Move around few of the helpers which deal with disk addition and removal and fix a potential bug in the blockdev media change routine. The refactors will allow simplify a corner case of using blockdev such as if the disk frontend is unplugged the backends can be unplugged only after blockjobs terminate. This will allow simpler handling of the backing chain data in conjunction with blockjobs. To test the blockdev part you can use the new XML namespace element for qemu: <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> [...] <qemu:capabilities> <qemu:add capability='blockdev'/> </qemu:capabilities> if you have a recent enough qemu. Peter Krempa (10): qemu: block: Move and rename qemuHotplugRemoveStorageSourcePrepareData qemu: hotplug: Handle copy-on-read filter separate from rest of backing chain qemu: Introduce new set of helpers for attaching and detaching storage chains qemu: command: Use storage chain helpers in commandline generator qemu: command: Use VIR_AUTO infrastructure in qemuBuildDiskSourceCommandLine qemu: command: get rid of 'cleanup' in qemuBuildDiskSourceCommandLine qemu: hotplug: Use storage chain helpers in qemuDomainAttachDiskGeneric qemu: hotplug: Use storage chain helpers in qemuDomainRemoveDiskDevice qemu: hotplug: qemu: hotplug: Use storage chain helpers in qemuDomainChangeMediaBlockdev qemu: hotplug: Remove rest of source backend if hotplug fails src/qemu/qemu_block.c | 174 +++++++++++++++++++++ src/qemu/qemu_block.h | 33 ++++ src/qemu/qemu_command.c | 132 ++++++++++------ src/qemu/qemu_command.h | 11 ++ src/qemu/qemu_hotplug.c | 332 +++++++--------------------------------- 5 files changed, 361 insertions(+), 321 deletions(-) -- 2.21.0

2 21

[libvirt] [PATCH] conf: storage: also sanitize source dir
by Ján Tomko 25 Jun '19

25 Jun '19

Commit a7fb2258 added sanitization of storage pool target paths, however source dir paths were left unsanitized. A netfs pool with: <source> <host name='10.20.30.40'/> <dir path='/nfs/'/> </source> will not be correctly detected as mounted by virStorageBackendFileSystemIsMounted, because it shows up in the mount list without the trailing slash. Sanitize the source dir as well. https://bugzilla.redhat.com/show_bug.cgi?id=1723247 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/conf/storage_conf.c | 5 ++++- .../storagepoolxml2xmlin/pool-netfs-slash.xml | 20 +++++++++++++++++++ .../pool-netfs-slash.xml | 20 +++++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 4 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-slash.xml create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-slash.xml diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 29988c36c4..397bd66870 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -533,6 +533,7 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt, VIR_AUTOFREE(char *) port = NULL; VIR_AUTOFREE(char *) ver = NULL; VIR_AUTOFREE(xmlNodePtr *) nodeset = NULL; + VIR_AUTOFREE(char *) sourcedir = NULL; relnode = ctxt->node; ctxt->node = node; @@ -630,7 +631,9 @@ virStoragePoolDefParseSource(xmlXPathContextPtr ctxt, } - source->dir = virXPathString("string(./dir/@path)", ctxt); + sourcedir = virXPathString("string(./dir/@path)", ctxt); + if (sourcedir) + source->dir = virFileSanitizePath(sourcedir); /* In gluster, a missing dir defaults to "/" */ if (!source->dir && pool_type == VIR_STORAGE_POOL_GLUSTER && VIR_STRDUP(source->dir, "/") < 0) diff --git a/tests/storagepoolxml2xmlin/pool-netfs-slash.xml b/tests/storagepoolxml2xmlin/pool-netfs-slash.xml new file mode 100644 index 0000000000..63f5d401ba --- /dev/null +++ b/tests/storagepoolxml2xmlin/pool-netfs-slash.xml @@ -0,0 +1,20 @@ +<pool type='netfs'> + <name>nfsimages</name> + <uuid>7641d5a8-af11-f730-a34e-0a7dfcede71f</uuid> + <capacity>0</capacity> + <allocation>0</allocation> + <available>0</available> + <source> + <host name='localhost'/> + <dir path='/var/lib/libvirt/images/'/> + <format type='nfs'/> + </source> + <target> + <path>/mnt</path> + <permissions> + <mode>0700</mode> + <owner>0</owner> + <group>0</group> + </permissions> + </target> +</pool> diff --git a/tests/storagepoolxml2xmlout/pool-netfs-slash.xml b/tests/storagepoolxml2xmlout/pool-netfs-slash.xml new file mode 100644 index 0000000000..8a5f272137 --- /dev/null +++ b/tests/storagepoolxml2xmlout/pool-netfs-slash.xml @@ -0,0 +1,20 @@ +<pool type='netfs'> + <name>nfsimages</name> + <uuid>7641d5a8-af11-f730-a34e-0a7dfcede71f</uuid> + <capacity unit='bytes'>0</capacity> + <allocation unit='bytes'>0</allocation> + <available unit='bytes'>0</available> + <source> + <host name='localhost'/> + <dir path='/var/lib/libvirt/images'/> + <format type='nfs'/> + </source> + <target> + <path>/mnt</path> + <permissions> + <mode>0700</mode> + <owner>0</owner> + <group>0</group> + </permissions> + </target> +</pool> diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index b6f4cb4226..96dd04faec 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -73,6 +73,7 @@ mymain(void) DO_TEST("pool-iscsi"); DO_TEST("pool-iscsi-auth"); DO_TEST("pool-netfs"); + DO_TEST("pool-netfs-slash"); DO_TEST("pool-netfs-auto"); DO_TEST("pool-netfs-protocol-ver"); DO_TEST("pool-netfs-gluster"); -- 2.20.1

2 1