- Devel - libvirt List Archives

[libvirt] [PATCH] test_driver: implement virConnectCompareCPU
by Ilias Stamatis 15 Aug '19

15 Aug '19

Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- Probably we need to extend the host CPU's capabilities as well along with this patch. Currently virCPUx86Compare reports "unknown host CPU". src/test/test_driver.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c39eef2d4b..b1037f4eab 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1529,6 +1529,26 @@ static int testConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED, return 32; } + +static int +testConnectCompareCPU(virConnectPtr conn, + const char *xmlDesc, + unsigned int flags) +{ + testDriverPtr privconn = conn->privateData; + bool failIncompatible = !!(flags & VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE); + int ret = VIR_CPU_COMPARE_ERROR; + + virCheckFlags(VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE, + VIR_CPU_COMPARE_ERROR); + + ret = virCPUCompareXML(privconn->caps->host.arch, privconn->caps->host.cpu, + xmlDesc, failIncompatible); + + return ret; +} + + static char * testConnectBaselineCPU(virConnectPtr conn ATTRIBUTE_UNUSED, const char **xmlCPUs, @@ -9510,6 +9530,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainRevertToSnapshot = testDomainRevertToSnapshot, /* 1.1.4 */ .domainSnapshotDelete = testDomainSnapshotDelete, /* 1.1.4 */ + .connectCompareCPU = testConnectCompareCPU, /* 5.7.0 */ .connectBaselineCPU = testConnectBaselineCPU, /* 1.2.0 */ .domainCheckpointCreateXML = testDomainCheckpointCreateXML, /* 5.6.0 */ .domainCheckpointGetXMLDesc = testDomainCheckpointGetXMLDesc, /* 5.6.0 */ -- 2.22.0

1 0

[libvirt] [PATCH] docs: Make anchors in API html files clickable/linkable
by Peter Krempa 15 Aug '19

15 Aug '19

Use 'id' instead of 'name' for anchors which adds the hidden clickable headerlink helper so it's way simpler to link to a specific part of the docs. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/newapi.xsl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index c808fe5ff8..f9cbcb6323 100644 --- a/docs/newapi.xsl +++ b/docs/newapi.xsl @@ -308,7 +308,7 @@ <xsl:template match="typedef[@type = 'enum']"> <xsl:variable name="name" select="string(@name)"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <div class="api"> <pre> <span class="keyword">enum</span><xsl:text> </xsl:text> @@ -357,7 +357,7 @@ </xsl:template> <xsl:template match="struct"> - <h3><a name="{@name}"><code><xsl:value-of select="@name"/></code></a></h3> + <h3><a id="{@name}"><code><xsl:value-of select="@name"/></code></a></h3> <div class="api"> <pre> <span class="keyword">struct </span> @@ -447,7 +447,7 @@ <xsl:template match="macro"> <xsl:variable name="name" select="string(@name)"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <pre class="api"><span class="directive">#define</span><xsl:text> </xsl:text><xsl:value-of select="$name"/></pre> <div class="description"> <xsl:call-template name="formattext"> @@ -558,7 +558,7 @@ <xsl:variable name="nlen" select="string-length($name)"/> <xsl:variable name="tlen" select="string-length(return/@type)"/> <xsl:variable name="blen" select="(($nlen + 8) - (($nlen + 8) mod 8)) + (($tlen + 8) - (($tlen + 8) mod 8))"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <pre class="api"> <span class="keyword">typedef</span><xsl:text> </xsl:text> <span class="type"> @@ -636,7 +636,7 @@ <xsl:variable name="nlen" select="string-length($name)"/> <xsl:variable name="tlen" select="string-length(return/@type)"/> <xsl:variable name="blen" select="(($nlen + 8) - (($nlen + 8) mod 8)) + (($tlen + 8) - (($tlen + 8) mod 8))"/> - <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> + <h3><a id="{$name}"><code><xsl:value-of select="$name"/></code></a></h3> <pre class="api"> <span class="type"> <xsl:call-template name="dumptext"> -- 2.21.0

2 1

[libvirt] [PATCH 00/12] qemu: Add blockdev support for block copy (blockdev-add saga)
by Peter Krempa 15 Aug '19

15 Aug '19

Add support for running a block-copy with -blockdev. This requires us to format our own images, so this series also adds support for blockdev-create which allows to do such a thing with qemu directly. blockdev-create will also be used with snapshots. Peter Krempa (12): qemu: domain: Allow formatting top source only in qemuDomainObjPrivateXMLFormatBlockjobFormatChain qemu: Fix logic in qemuDomainBlockCopyCommonValidateUserMirrorBackingStore qemu: fix broken handling of shallow flag in qemuDomainBlockCopyCommon util: storage: Refactor logic for using virStorageFileGetBackendForSupportCheck util: storage: Allow checking whether virStorageFileCreate is supported qemu: blockjob: Remove qemuBlockJobDiskRegisterMirror qemu: domain: Add 'break' after formatting commit job status XML conf: domain: Parse backingStore with VIR_DOMAIN_DEF_PARSE_DISK_SOURCE qemu: blockjob: Copy non-detected chain fully in qemuBlockJobRewriteConfigDiskSource qemu: Introduce code for blockdev-create qemu: Add blockdev support for the block copy job qemu: driver: allow remote destinations for block copy src/conf/domain_conf.c | 6 +- src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 250 ++++++++++++++++++ src/qemu/qemu_block.h | 14 + src/qemu/qemu_blockjob.c | 202 ++++++++++++-- src/qemu/qemu_blockjob.h | 37 ++- src/qemu/qemu_domain.c | 83 ++++-- src/qemu/qemu_driver.c | 184 +++++++++---- src/util/virstoragefile.c | 59 +++-- src/util/virstoragefile.h | 1 + .../blockjob-blockdev-in.xml | 59 +++++ 11 files changed, 786 insertions(+), 110 deletions(-) -- 2.21.0

2 24

[libvirt] [PATCH] util: storage: Fix parsing of 'exportname' from legacy NBD strings
by Peter Krempa 15 Aug '19

15 Aug '19

If the nbd export name contains a colon, our parser would not parse it properly as we split the string by colons. Modify the code to look up the exportname and copy any trailing characters as the export name is supposed to be at the end of the string. https://bugzilla.redhat.com/show_bug.cgi?id=1733044 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virstoragefile.c | 6 ++++-- tests/virstoragetest.c | 8 ++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index a6de6a1e45..ffafeef9d8 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2928,6 +2928,7 @@ virStorageSourceParseNBDColonString(const char *nbdstr, virStorageSourcePtr src) { VIR_AUTOSTRINGLIST backing = NULL; + const char *exportname; if (!(backing = virStringSplit(nbdstr, ":", 0))) return -1; @@ -2975,8 +2976,9 @@ virStorageSourceParseNBDColonString(const char *nbdstr, return -1; } - if (backing[3] && STRPREFIX(backing[3], "exportname=")) { - if (VIR_STRDUP(src->path, backing[3] + strlen("exportname=")) < 0) + if ((exportname = strstr(nbdstr, "exportname="))) { + exportname += strlen("exportname="); + if (VIR_STRDUP(src->path, exportname) < 0) return -1; } diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index ef16b3c6e0..f558eea622 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -1262,6 +1262,14 @@ mymain(void) "<source protocol='nbd' name='blah'>\n" " <host name='example.org' port='6000'/>\n" "</source>\n"); + TEST_BACKING_PARSE("nbd:example.org:6000:exportname=:", + "<source protocol='nbd' name=':'>\n" + " <host name='example.org' port='6000'/>\n" + "</source>\n"); + TEST_BACKING_PARSE("nbd:example.org:6000:exportname=:test", + "<source protocol='nbd' name=':test'>\n" + " <host name='example.org' port='6000'/>\n" + "</source>\n"); TEST_BACKING_PARSE("nbd://example.org:1234", "<source protocol='nbd'>\n" " <host name='example.org' port='1234'/>\n" -- 2.21.0

2 2

[libvirt] [PATCH 0/5] util: open pci config read-only for querying
by Ján Tomko 15 Aug '19

15 Aug '19

A bunch of functions opened the PCI device config as read-write even though they only read from it. Ján Tomko (5): util: introduce virPCIDeviceConfigOpenInternal util: Introduce virPCIDeviceConfigOpenWrite util: introduce readonly attribute to virPCIDeviceConfigOpenInternal util: introduce virPCIDeviceConfigOpenTry util: default to read-only in virPCIDeviceConfigOpen src/util/virpci.c | 40 +++++++++++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 11 deletions(-) -- 2.20.1

4 8

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetLifecycleAction
by Ilias Stamatis 14 Aug '19

14 Aug '19

Ilias Stamatis (2): test_driver: handle different lifecycle actions in testDomainShutdownFlags test_driver: implement virDomainSetLifecycleAction src/test/test_driver.c | 135 +++++++++++++++++++++++++++++++---------- 1 file changed, 103 insertions(+), 32 deletions(-) -- 2.22.0

2 6

[libvirt] [PATCH 0/3] virNetDaemonCallInhibit: check for logind availability
by Ján Tomko 14 Aug '19

14 Aug '19

* get rid of a pointless error logged when system D-Bus is not available * do not send messages on systems without logind * remove four extra dbus calls on libvirtd startup when checking for logind availability Ján Tomko (3): util: introduce virSystemdHasLogind util: cache the result of whether logind is available rpc: make virNetDaemonCallInhibit a no-op with no logind src/libvirt_private.syms | 2 ++ src/rpc/virnetdaemon.c | 3 +++ src/util/virsystemd.c | 37 ++++++++++++++++++++++++++++++++----- src/util/virsystemd.h | 2 ++ src/util/virsystemdpriv.h | 1 + tests/virsystemdtest.c | 3 +++ 6 files changed, 43 insertions(+), 5 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH 0/3] quietly ignore missing pm-is-supported
by Ján Tomko 14 Aug '19

14 Aug '19

On systems with no logind or pm-is-supported binary, stop spamming the logs about a missing executable. Ján Tomko (3): util: use VIR_AUTOPTR virNodeSuspendSupportsTargetPMUtils util: do not repeat the pm-is-supported string util: be quiet when pm-is-supported is unavailable src/util/virnodesuspend.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) -- 2.19.2

2 7

[libvirt] [PATCH 0/3] qemu: Allow migration with disk cache on
by Jiri Denemark 13 Aug '19

13 Aug '19

QEMU 4.0.0 and newer automatically drops caches at the end of migration, which means we can safely allow migration even if disk/driver/@cache is not none nor directsync. Jiri Denemark (3): qemu: Clarify error message in qemuMigrationSrcIsSafe qemu: Check for drop-cache capability qemu: Allow migration with disk cache on src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_migration.c | 14 +++++++++++--- tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml | 1 + 10 files changed, 21 insertions(+), 3 deletions(-) -- 2.22.1

3 5

[libvirt] [PATCH] qemu: Fix crash on incoming migration
by Jiri Denemark 13 Aug '19

13 Aug '19

In the first stage of incoming migration (qemuMigrationDstPrepareAny) we call qemuMigrationEatCookie when there's no vm object created yet and thus we don't have any private data to pass. Broken by me in commit v5.6.0-109-gbf15b145ec. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_cookie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_cookie.c index da5bc8d05f..25d3fecd74 100644 --- a/src/qemu/qemu_migration_cookie.c +++ b/src/qemu/qemu_migration_cookie.c @@ -1507,7 +1507,7 @@ qemuMigrationEatCookie(virQEMUDriverPtr driver, if (cookiein && cookieinlen && qemuMigrationCookieXMLParseStr(mig, driver, - priv->qemuCaps, + priv ? priv->qemuCaps : NULL, cookiein, flags) < 0) goto error; -- 2.22.1

2 1