- Devel - libvirt List Archives

[libvirt] [PATCH] tests: make domaincapstest less anoying to debug
by Peter Krempa 25 Oct '19

25 Oct '19

Since 6a077cf2b3 domaincapstest does not run through all cases on failure but terminates right away. This makes it super annoying to debug or use in combination with VIR_TEST_REGNERATE_OUTPUT. Fix it by remembering failure and still running through all cases. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/domaincapstest.c | 36 +++++++++++++++++++++--------------- tests/testutilsqemu.c | 8 ++++---- 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index f77accdb76..e4e13c8bb3 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -313,6 +313,8 @@ doTestQemu(const char *inputDir G_GNUC_UNUSED, const char *suffix G_GNUC_UNUSED, void *opaque) { + int ret = 0; + if (STREQ(arch, "x86_64")) { /* For x86_64 we test three combinations: * @@ -321,13 +323,16 @@ doTestQemu(const char *inputDir G_GNUC_UNUSED, * - TCG with default machine */ if (doTestQemuInternal(version, NULL, arch, - VIR_DOMAIN_VIRT_KVM, opaque) < 0 || - doTestQemuInternal(version, "q35", arch, - VIR_DOMAIN_VIRT_KVM, opaque) < 0 || - doTestQemuInternal(version, NULL, arch, - VIR_DOMAIN_VIRT_QEMU, opaque) < 0) { - return -1; - } + VIR_DOMAIN_VIRT_KVM, opaque) < 0) + ret = -1; + + if (doTestQemuInternal(version, "q35", arch, + VIR_DOMAIN_VIRT_KVM, opaque) < 0) + ret = -1; + + if (doTestQemuInternal(version, NULL, arch, + VIR_DOMAIN_VIRT_QEMU, opaque) < 0) + ret = -1; } else if (STREQ(arch, "aarch64")) { /* For aarch64 we test two combinations: * @@ -335,21 +340,22 @@ doTestQemu(const char *inputDir G_GNUC_UNUSED, * - KVM with virt machine */ if (doTestQemuInternal(version, NULL, arch, - VIR_DOMAIN_VIRT_KVM, opaque) < 0 || - doTestQemuInternal(version, "virt", arch, - VIR_DOMAIN_VIRT_KVM, opaque) < 0) { - return -1; - } + VIR_DOMAIN_VIRT_KVM, opaque) < 0) + ret = -1; + + if (doTestQemuInternal(version, "virt", arch, + VIR_DOMAIN_VIRT_KVM, opaque) < 0) + ret = -1; } else if (STRPREFIX(arch, "riscv")) { /* Unfortunately we have to skip RISC-V at the moment */ return 0; } else { if (doTestQemuInternal(version, NULL, arch, VIR_DOMAIN_VIRT_KVM, opaque) < 0) - return -1; + ret = -1; } - return 0; + return ret; } #endif @@ -431,7 +437,7 @@ mymain(void) abs_srcdir "/qemufirmwaredata/home/user/.config/qemu/firmware"); if (testQemuCapsIterate(".xml", doTestQemu, cfg) < 0) - return EXIT_FAILURE; + ret = -1; /* * Run "tests/qemucapsprobe /path/to/qemu/binary >foo.replies" diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 54d6b1a0ac..34a6bd2653 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -902,6 +902,7 @@ testQemuCapsIterate(const char *suffix, DIR *dir = NULL; int rc; int ret = -1; + bool fail = false; if (!callback) return 0; @@ -949,12 +950,11 @@ testQemuCapsIterate(const char *suffix, * the callback. */ if (callback(TEST_QEMU_CAPS_PATH, "caps", version, - archName, suffix + 1, opaque) < 0) { - goto cleanup; - } + archName, suffix + 1, opaque) < 0) + fail = true; } - if (rc < 0) + if (rc < 0 || fail) goto cleanup; ret = 0; -- 2.21.0

2 1

Re: [libvirt] [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions
by Eduardo Habkost 25 Oct '19

25 Oct '19

CCing danpb, libvir-list, mskrivanek. On Fri, Oct 25, 2019 at 09:17:46AM +0200, David Hildenbrand wrote: > On 25.10.19 04:25, Eduardo Habkost wrote: > > We had introduced versioned CPU models in QEMU 4.1, including a > > method for querying for CPU model versions using > > Interesting, I was not aware of that. > > On s390x, we somewhat have versioned CPU models, but we decided against > giving them explicit names (e.g., z13-v1 or z13-4.1.0), because it didn't > really seem to be necessary. (and we often implement/add features for older > CPU models, there is a lot of fluctuation) Actually, you would have had to > add "z13-z/VM-x.x.x" or "z13-LPAR-x.x.x" or "z13-KVM-x.x.x" to model the > features you actually see in all the different virtual environments ("what a > CPU looks like"). Not to talk about QEMU versions in addition to that. So we > decided to always model what you would see under LPAR and are able to > specify for a KVM guest. So you can use "z13" in an up-to-date LPAR > environment, but not in a z/VM environment (you would have to disable > features). > > Each (!base) CPU model has a specific feature set per machine. Libvirt uses > query-cpu-model-expansion() to convert this model+machine to a > machine-independent representation. That representation is sufficient for > all use cases we were aware of (esp. "virsh domcapabilities", the host CPU > model, migration). > > While s390x has versioned CPU models, we have no explicit way of specifying > them for older machines, besides going over query-cpu-model-expansion and > using expanded "base model + features". > > I can see that this might make sense on x86-64, where you only have maybe 3 > versions of a CPU (e.g., the one Intel messed up first - Haswell, the one > Intel messed up next - Haswell-noTSX, and the one that Intel eventually did > right - Haswell-noTSX-IBRS) and you might want to specify "Haswell" vs. > "Haswell-IBRS" vs. "Haswell-noTSX-IBRS". But actually, you will always want > to go for "Haswell-noTSX-IBRS", because you can expect to run in updated > environments if I am not wrong, everything else are corner cases. > > Of course, versioned CPU model are neat to avoid "base model + list of > features", but at least for expanding the host model on s390x, it is not > really helpful. When migrating, the model expansion does the trick. > > I haven't looked into details of "how to specify or model versions". Maybe > IBM wants to look into creating versions for all the old models we had. But > again, not sure if that is of any help for s390x. CCing IBM. I'm not sure yet if there are the x86-specific goals and constraints that would make it difficult to follow the same approach followed by s390x. I have the impression we do, but I need to think more carefully about it. Let's discuss that during KVM Forum? The two main goals of versioned CPU models in x86 are: 1) Decoupling CPU model updates from machine-types (users should be able to update a CPU model definition without changing machine type). 2) Letting management software automate CPU model updates. Normally this is necessary when bare metal microcode or software updates add/remove features from CPUs. Sometimes the Virtual CPU model update needs to be performed before the host updates are applied (if features are being removed). The main constraint that makes it difficult to address the above without a new API is: A) Every CPU model in x86 except "host" is already expected to be migration-safe (I don't know how this compares to s390x). > > > query-cpu-definitions. This only has one problem: fetching CPU > > alias information for multiple machine types required restarting > > QEMU for each machine being queried. > > > > This series adds a new `machine` parameter to > > query-cpu-definitions, that can be used to query CPU model alias > > information for multiple machines without restarting QEMU. > > > > Eduardo Habkost (7): > > i386: Use g_autofree at x86_cpu_list_entry() > > i386: Add default_version parameter to CPU version functions > > i386: Don't use default_cpu_version at "-cpu help" > > machine: machine_find_class() function > > i386: Remove x86_cpu_set_default_version() function > > i386: Don't use default_cpu_version() inside query-cpu-definitions > > cpu: Add `machine` parameter to query-cpu-definitions > > > > qapi/machine-target.json | 14 +++- > > include/hw/boards.h | 1 + > > include/hw/i386/pc.h | 5 +- > > target/i386/cpu.h | 6 -- > > hw/core/machine.c | 16 ++++ > > hw/i386/pc.c | 3 - > > target/arm/helper.c | 4 +- > > target/i386/cpu.c | 93 +++++++++++++++------- > > target/mips/helper.c | 4 +- > > target/ppc/translate_init.inc.c | 4 +- > > target/s390x/cpu_models.c | 4 +- > > vl.c | 17 +--- > > tests/acceptance/x86_cpu_model_versions.py | 42 ++++++++++ > > 13 files changed, 154 insertions(+), 59 deletions(-) > > > > > -- > > Thanks, > > David / dhildenb -- Eduardo

2 1

Re: [libvirt] [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions
by Eduardo Habkost 25 Oct '19

25 Oct '19

CCing mskrivanek, danpb, libvir-list. On Fri, Oct 25, 2019 at 10:02:29AM +0200, David Hildenbrand wrote: > On 25.10.19 09:55, Christian Borntraeger wrote: > > > > > > On 25.10.19 09:17, David Hildenbrand wrote: > > > On 25.10.19 04:25, Eduardo Habkost wrote: > > > > We had introduced versioned CPU models in QEMU 4.1, including a > > > > method for querying for CPU model versions using > > > > > > Interesting, I was not aware of that. > > > > > > On s390x, we somewhat have versioned CPU models, but we decided against giving them explicit names (e.g., z13-v1 or z13-4.1.0), because it didn't really seem to be necessary. (and we often implement/add features for older CPU models, there is a lot of fluctuation) Actually, you would have had to add "z13-z/VM-x.x.x" or "z13-LPAR-x.x.x" or "z13-KVM-x.x.x" to model the features you actually see in all the different virtual environments ("what a CPU looks like"). Not to talk about QEMU versions in addition to that. So we decided to always model what you would see under LPAR and are able to specify for a KVM guest. So you can use "z13" in an up-to-date LPAR environment, but not in a z/VM environment (you would have to disable features). > > > > > > Each (!base) CPU model has a specific feature set per machine. Libvirt uses query-cpu-model-expansion() to convert this model+machine to a machine-independent representation. That representation is sufficient for all use cases we were aware of (esp. "virsh domcapabilities", the host CPU model, migration). > > > > > > While s390x has versioned CPU models, we have no explicit way of specifying them for older machines, besides going over query-cpu-model-expansion and using expanded "base model + features". > > > > > > I can see that this might make sense on x86-64, where you only have maybe 3 versions of a CPU (e.g., the one Intel messed up first - Haswell, the one Intel messed up next - Haswell-noTSX, and the one that Intel eventually did right - Haswell-noTSX-IBRS) and you might want to specify "Haswell" vs. "Haswell-IBRS" vs. "Haswell-noTSX-IBRS". But actually, you will always want to go for "Haswell-noTSX-IBRS", because you can expect to run in updated environments if I am not wrong, everything else are corner cases. > > > > > > Of course, versioned CPU model are neat to avoid "base model + list of features", but at least for expanding the host model on s390x, it is not really helpful. When migrating, the model expansion does the trick. > > > > > > I haven't looked into details of "how to specify or model versions". Maybe IBM wants to look into creating versions for all the old models we had. But again, not sure if that is of any help for s390x. CCing IBM. > > > > I agree that this does not look very helpful. > > Especially as several things depend on the kernel version a QEMU version is > > not sufficient to be guarantee construction success. > > So we would need something like z14-qemu4.0-kernel-5.2-suse-flavour-onLPAR > > > > Instead we do check if we can construct an equivalent model on the migration target. > > And that model is precise. We do even have versions. > > Right now with QEMU on s390 our models are versioned in a way that we fence of > > facilities for old machine versions. > > > > For example > > -machine s390-virtio-ccw-3.1 -cpu z14 will not have the multiple epoch facility > > and > > -machine s390-virtio-ccw-4.0 -cpu z14 will have the multiple epoch facility. > > As migration does always require the tuple of machine and cpu this is save. I fail > > to see what the benefit of an explicit z14-3.1 would be. > > > > AFAIKS the only real benefit of versioned CPU models is that you can add new > CPU model versions without new QEMU version. > > Then you can specify "-cpu z13-vX" or "-cpu z13 -cpuv X" (no idea how > versioned CPU model were implemented) on any QEMU machine. Which is the same > as telling your customer "please use z13,featX=on" in case you have a good > reason to not use the host model (along with baselining) but use an explicit > model. Exactly. oVirt, specifically, don't use host-model. > > If you can change the default model of QEMU machines, you can automate this > process. I am pretty sure this is a corner case, though (e.g., IBRS). > Usually you have a new QEMU machine and can simply enable the new feature > from that point on. When -noTSX happened, we thought it was a corner case. Then we had -IBRS & -IBPB. Then we had SSBD (with no new CPU models). Then we had MD_CLEAR (with no new CPU models). It's now very easy to get an insecure VM created if you are not using host-model. -- Eduardo

1 0

Re: [libvirt] [PATCH 7/7] cpu: Add `machine` parameter to query-cpu-definitions
by Eduardo Habkost 25 Oct '19

25 Oct '19

CCing libvir-list. On Fri, Oct 25, 2019 at 08:36:59AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabkost(a)redhat.com> writes: > > The new parameter can be used by management software to query for > > CPU model alias information for multiple machines without > > restarting QEMU. [...] > > @@ -317,9 +321,17 @@ > ## > # @query-cpu-definitions: > > # > > # Return a list of supported virtual CPU definitions > > # > > +# @machine: Name of machine type. The command returns some data > > +# that machine-specific. This overrides the machine type > > "that is machine-specific" > > > +# used to look up that information. This can be used, > > +# for example, to query machine-specific CPU model aliases > > +# without restarting QEMU (since 4.2) > > +# > > # Returns: a list of CpuDefInfo > > # > > # Since: 1.2.0 > > ## > > -{ 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'], > > +{ 'command': 'query-cpu-definitions', > > + 'data': { '*machine': 'str' }, > > + 'returns': ['CpuDefinitionInfo'], > > 'if': 'defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_I386) || defined(TARGET_S390X) || defined(TARGET_MIPS)' } > > I'm afraid the doc comment is less than clear. Before I can suggest > improvements, I have questions. > > Looks like @alias-of is the only part of the return value that changes > when I re-run query-cpu-definitions with another @machine argument. > Correct? Yes. > > How is this going to be used? Will management software run > query-cpu-definitions for each machine type returned by query-machines? > Or just for a few of them? I don't know. I'll let Jiri and other libvirt developers answer that. -- Eduardo

1 0

[libvirt] [RFC PATCH 00/19] Configurable policy for handling deprecated interfaces
by Markus Armbruster 24 Oct '19

24 Oct '19

This series is RFC because it's incomplete, and the warning idea in PATCH 18 is half-baked. I'm soliciting feed back from the management application crowd: is this going into a useful direction? The series adresses only deprecated commands and events. Good enough to demonstrate the ideas, I think. A complete solution should additionally cover arguments and return values. Feels feasible to me. New option -compat deprecated-input=<in-policy>,deprecated-output=out-policy configures the policy. Available input policies: * accept: Accept deprecated commands with a warning (default) * reject: Reject deprecated commands * crash: Crash on deprecated command Available output policies: * accept: Emit deprecated events (default) * hide: Suppress deprecated events See also last item of Subject: Minutes of KVM Forum BoF on deprecating stuff Date: Fri, 26 Oct 2018 16:03:51 +0200 Message-ID: <87mur0ls8o.fsf(a)dusky.pond.sub.org> https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg05828.html Markus Armbruster (19): tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers tests/test-qmp-cmds: Check responses more thoroughly tests/test-qmp-cmds: Simplify test data setup tests/test-qmp-event: Simplify test data setup tests/test-qmp-event: Use qobject_is_equal() tests/test-qmp-event: Check event is actually emitted qapi: Add feature flags to remaining definitions qapi: Consistently put @features parameter right after @ifcond qapi: Inline do_qmp_dispatch() into qmp_dispatch() qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP qapi: Simplify how qmp_dispatch() gets the request ID qapi: Replace qmp_dispatch()'s TODO comment by an explanation qapi: New special feature flag "deprecated" qemu-options: New -compat to set policy for "funny" interfaces qapi: Mark deprecated QMP commands with feature 'deprecated' qapi: Implement -compat deprecated-input=reject for commands qapi: Implement -compat deprecated-input=crash for commands qapi: Include a warning in the response to a deprecated command qapi: Implement -compat deprecated-output=hide for events docs/devel/qapi-code-gen.txt | 21 +- tests/qapi-schema/doc-good.texi | 32 ++- qapi/common.json | 48 ++++ qapi/introspect.json | 28 ++- qapi/machine.json | 24 +- qapi/migration.json | 36 ++- qapi/misc.json | 25 +- include/qapi/compat-policy.h | 20 ++ include/qapi/qmp/dispatch.h | 1 + qapi/qmp-dispatch.c | 140 +++++++----- tests/test-qmp-cmds.c | 216 +++++++++++------- tests/test-qmp-event.c | 181 ++++----------- vl.c | 17 ++ qemu-options.hx | 24 ++ scripts/qapi/commands.py | 16 +- scripts/qapi/doc.py | 16 +- scripts/qapi/events.py | 16 +- scripts/qapi/expr.py | 11 +- scripts/qapi/introspect.py | 41 ++-- scripts/qapi/schema.py | 138 ++++++----- scripts/qapi/types.py | 8 +- scripts/qapi/visit.py | 8 +- tests/Makefile.include | 1 + tests/qapi-schema/alternate-base.err | 2 +- tests/qapi-schema/doc-good.json | 18 +- tests/qapi-schema/doc-good.out | 20 +- .../qapi-schema/features-deprecated-type.err | 2 + .../qapi-schema/features-deprecated-type.json | 3 + .../qapi-schema/features-deprecated-type.out | 0 tests/qapi-schema/qapi-schema-test.json | 31 ++- tests/qapi-schema/qapi-schema-test.out | 29 ++- tests/qapi-schema/test-qapi.py | 19 +- 32 files changed, 731 insertions(+), 461 deletions(-) create mode 100644 include/qapi/compat-policy.h create mode 100644 tests/qapi-schema/features-deprecated-type.err create mode 100644 tests/qapi-schema/features-deprecated-type.json create mode 100644 tests/qapi-schema/features-deprecated-type.out -- 2.21.0

2 23

[libvirt] [PATCH] internal: Use g_strcmp0 in STR(N)EQ_NULLABLE
by Peter Krempa 24 Oct '19

24 Oct '19

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/internal.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/internal.h b/src/internal.h index 5b0a2335f5..0ff9f496ac 100644 --- a/src/internal.h +++ b/src/internal.h @@ -86,10 +86,8 @@ #define STRCASEPREFIX(a, b) (c_strncasecmp(a, b, strlen(b)) == 0) #define STRSKIP(a, b) (STRPREFIX(a, b) ? (a) + strlen(b) : NULL) -#define STREQ_NULLABLE(a, b) \ - ((a) ? (b) && STREQ((a), (b)) : !(b)) -#define STRNEQ_NULLABLE(a, b) \ - ((a) ? !(b) || STRNEQ((a), (b)) : !!(b)) +#define STREQ_NULLABLE(a, b) (g_strcmp0(a, b) == 0) +#define STRNEQ_NULLABLE(a, b) (g_strcmp0(a, b) != 0) #define NUL_TERMINATE(buf) do { (buf)[sizeof(buf)-1] = '\0'; } while (0) -- 2.21.0

5 6

[libvirt] [PATCH] tests: domaincaps: Fix build when WITH_QEMU is disabled
by Peter Krempa 24 Oct '19

24 Oct '19

doTestQemuInternal and doTestQemu are used only when WITH_QEMU is enabled. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/domaincapstest.c | 5 +++++ 1 file changed, 5 insertions(+) Pushed as a fix for broken build. diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 0197c61c8a..f77accdb76 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -266,6 +266,9 @@ test_virDomainCapsFormat(const void *opaque) return ret; } + +#if WITH_QEMU + static int doTestQemuInternal(const char *version, const char *machine, @@ -349,6 +352,8 @@ doTestQemu(const char *inputDir G_GNUC_UNUSED, return 0; } +#endif + static int mymain(void) { -- 2.21.0

1 0

[libvirt] [PATCH 00/75] Drop virAsprintf() in favor of g_strdup_printf()
by Michal Privoznik 24 Oct '19

24 Oct '19

You can find these also on my github: https://github.com/zippy2/libvirt/tree/virasprintf_void Good luck. Michal Prívozník (75): src: Don't rely on virAsprintf() returning string length qemu_command: Change logic in qemuVirCommandGet{FDSet,GetDevSet} access: Drop virAsprintf() and virAsprintfQuiet() retval checking bhyve: Drop virAsprintf() and virAsprintfQuiet() retval checking conf: Drop virAsprintf() and virAsprintfQuiet() retval checking cpu: Drop virAsprintf() and virAsprintfQuiet() retval checking esx: Drop virAsprintf() and virAsprintfQuiet() retval checking hyperv: Drop virAsprintf() and virAsprintfQuiet() retval checking interface: Drop virAsprintf() and virAsprintfQuiet() retval checking libxl: Drop virAsprintf() and virAsprintfQuiet() retval checking locking: Drop virAsprintf() and virAsprintfQuiet() retval checking logging: Drop virAsprintf() and virAsprintfQuiet() retval checking lxc: Drop virAsprintf() and virAsprintfQuiet() retval checking network: Drop virAsprintf() and virAsprintfQuiet() retval checking node_device: Drop virAsprintf() and virAsprintfQuiet() retval checking nwfilter: Drop virAsprintf() and virAsprintfQuiet() retval checking openvz: Drop virAsprintf() and virAsprintfQuiet() retval checking phyp: Drop virAsprintf() and virAsprintfQuiet() retval checking qemu: Drop virAsprintf() and virAsprintfQuiet() retval checking remote: Drop virAsprintf() and virAsprintfQuiet() retval checking rpc: Drop virAsprintf() and virAsprintfQuiet() retval checking security: Drop virAsprintf() and virAsprintfQuiet() retval checking storage: Drop virAsprintf() and virAsprintfQuiet() retval checking test: Drop virAsprintf() and virAsprintfQuiet() retval checking util: Drop virAsprintf() and virAsprintfQuiet() retval checking secret: Drop virAsprintf() and virAsprintfQuiet() retval checking vbox: Drop virAsprintf() and virAsprintfQuiet() retval checking vmware: Drop virAsprintf() and virAsprintfQuiet() retval checking vmx: Drop virAsprintf() and virAsprintfQuiet() retval checking vz: Drop virAsprintf() and virAsprintfQuiet() retval checking tests: Drop virAsprintf() and virAsprintfQuiet() retval checking tools: Drop virAsprintf() and virAsprintfQuiet() retval checking Drop virAsprintf() and virAsprintfQuiet() retval checking virstring: Make virAsprintf() return no value Rename virAsprintfQuiet() to virAsprintf() virstring: Drop virAsprintfQuiet() access: Use g_strdup_printf() instead of virAsprintf() bhyve: Use g_strdup_printf() instead of virAsprintf() conf: Use g_strdup_printf() instead of virAsprintf() cpu: Use g_strdup_printf() instead of virAsprintf() esx: Use g_strdup_printf() instead of virAsprintf() hyperv: Use g_strdup_printf() instead of virAsprintf() interface: Use g_strdup_printf() instead of virAsprintf() libxl: Use g_strdup_printf() instead of virAsprintf() locking: Use g_strdup_printf() instead of virAsprintf() logging: Use g_strdup_printf() instead of virAsprintf() lxc: Use g_strdup_printf() instead of virAsprintf() network: Use g_strdup_printf() instead of virAsprintf() node_device: Use g_strdup_printf() instead of virAsprintf() nwfilter: Use g_strdup_printf() instead of virAsprintf() openvz: Use g_strdup_printf() instead of virAsprintf() phyp: Use g_strdup_printf() instead of virAsprintf() qemu: Use g_strdup_printf() instead of virAsprintf() remote: Use g_strdup_printf() instead of virAsprintf() rpc: Use g_strdup_printf() instead of virAsprintf() secret: Use g_strdup_printf() instead of virAsprintf() security: Use g_strdup_printf() instead of virAsprintf() storage: Use g_strdup_printf() instead of virAsprintf() test: Use g_strdup_printf() instead of virAsprintf() util: Use g_strdup_printf() instead of virAsprintf() vbox: Use g_strdup_printf() instead of virAsprintf() vmware: Use g_strdup_printf() instead of virAsprintf() vmx: Use g_strdup_printf() instead of virAsprintf() vz: Use g_strdup_printf() instead of virAsprintf() tests: Use g_strdup_printf() instead of virAsprintf() tools: Use g_strdup_printf() instead of virAsprintf() Use g_strdup_printf instead of virAsprintf everywhere virpcimock: Make @fakerootdir static Drop virAsprintf() Rename virVasprintfQuiet() to virVasprintf() virstring: Drop virVasprintfQuiet() Drop virVasprintf() retval checking virstring: Make virVasprintf() return no value Use g_strdup_vprintf() instead of virVasprintf() everywhere Drop virVasprintf() build-aux/syntax-check.mk | 10 +- docs/hacking.html.in | 13 +- m4/virt-compile-warnings.m4 | 2 - src/access/viraccessdriverpolkit.c | 6 +- src/bhyve/bhyve_capabilities.c | 6 +- src/bhyve/bhyve_process.c | 16 +- src/conf/capabilities.c | 3 +- src/conf/domain_addr.c | 8 +- src/conf/domain_audit.c | 60 +++----- src/conf/domain_conf.c | 48 +++--- src/conf/moment_conf.c | 5 +- src/conf/network_conf.c | 2 +- src/conf/node_device_util.c | 3 +- src/conf/snapshot_conf.c | 5 +- src/conf/storage_conf.c | 6 +- src/conf/virchrdev.c | 7 +- src/conf/virnetworkobj.c | 8 +- src/conf/virnetworkportdef.c | 2 +- src/conf/virnwfilterbindingobj.c | 2 +- src/conf/virstorageobj.c | 3 +- src/cpu/cpu_ppc64.c | 30 ++-- src/cpu/cpu_x86.c | 27 ++-- src/driver.c | 6 +- src/esx/esx_driver.c | 54 +++---- src/esx/esx_storage_backend_vmfs.c | 67 +++----- src/esx/esx_stream.c | 11 +- src/esx/esx_vi.c | 31 ++-- src/hyperv/hyperv_driver.c | 11 +- src/hyperv/hyperv_wmi.c | 23 +-- src/interface/interface_backend_netcf.c | 7 +- src/interface/interface_backend_udev.c | 14 +- src/libvirt-admin.c | 12 +- src/libvirt_private.syms | 2 - src/libxl/libxl_conf.c | 34 ++--- src/libxl/libxl_domain.c | 34 ++--- src/libxl/libxl_domain.h | 2 +- src/libxl/libxl_driver.c | 19 +-- src/libxl/libxl_logger.c | 14 +- src/libxl/libxl_migration.c | 9 +- src/libxl/xen_common.c | 11 +- src/libxl/xen_xl.c | 18 +-- src/libxl/xen_xm.c | 6 +- src/locking/lock_daemon.c | 17 +-- src/locking/lock_daemon_config.c | 5 +- src/locking/lock_driver_lockd.c | 9 +- src/locking/lock_driver_sanlock.c | 12 +- src/locking/lock_manager.c | 4 +- src/logging/log_daemon.c | 26 +--- src/logging/log_daemon_config.c | 5 +- src/logging/log_manager.c | 5 +- src/lxc/lxc_container.c | 68 ++++----- src/lxc/lxc_controller.c | 79 ++++------ src/lxc/lxc_driver.c | 15 +- src/lxc/lxc_fuse.c | 10 +- src/lxc/lxc_monitor.c | 4 +- src/lxc/lxc_native.c | 11 +- src/lxc/lxc_process.c | 35 ++--- src/network/bridge_driver.c | 69 ++++----- src/network/leaseshelper.c | 6 +- src/node_device/node_device_driver.c | 3 +- src/node_device/node_device_hal.c | 7 +- src/node_device/node_device_udev.c | 11 +- src/nwfilter/nwfilter_dhcpsnoop.c | 16 +- src/openvz/openvz_conf.c | 18 +-- src/openvz/openvz_driver.c | 7 +- src/phyp/phyp_driver.c | 19 +-- src/qemu/qemu_agent.c | 9 +- src/qemu/qemu_alias.c | 114 +++++++------- src/qemu/qemu_block.c | 45 +++--- src/qemu/qemu_blockjob.c | 12 +- src/qemu/qemu_capabilities.c | 14 +- src/qemu/qemu_checkpoint.c | 11 +- src/qemu/qemu_command.c | 113 ++++++-------- src/qemu/qemu_conf.c | 141 ++++++----------- src/qemu/qemu_conf.h | 4 +- src/qemu/qemu_domain.c | 168 ++++++++------------- src/qemu/qemu_domain.h | 6 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_firmware.c | 3 +- src/qemu/qemu_hotplug.c | 80 ++++------ src/qemu/qemu_interface.c | 5 +- src/qemu/qemu_interop_config.c | 9 +- src/qemu/qemu_migration.c | 33 ++-- src/qemu/qemu_migration_cookie.c | 3 +- src/qemu/qemu_monitor.c | 33 ++-- src/qemu/qemu_monitor_json.c | 26 +--- src/qemu/qemu_monitor_text.c | 15 +- src/qemu/qemu_process.c | 74 +++------ src/qemu/qemu_slirp.c | 18 +-- src/qemu/qemu_tpm.c | 19 +-- src/qemu/qemu_vhost_user_gpu.c | 3 +- src/remote/remote_daemon.c | 37 ++--- src/remote/remote_daemon_config.c | 5 +- src/remote/remote_daemon_dispatch.c | 20 +-- src/remote/remote_driver.c | 20 +-- src/rpc/virnetclient.c | 23 +-- src/rpc/virnetlibsshsession.c | 17 +-- src/rpc/virnetsocket.c | 3 +- src/rpc/virnetsshsession.c | 19 +-- src/rpc/virnettlscontext.c | 39 ++--- src/secret/secret_driver.c | 14 +- src/security/security_apparmor.c | 38 ++--- src/security/security_dac.c | 30 ++-- src/security/security_selinux.c | 59 +++----- src/security/security_util.c | 14 +- src/security/virt-aa-helper.c | 73 ++------- src/storage/storage_backend_disk.c | 7 +- src/storage/storage_backend_gluster.c | 16 +- src/storage/storage_backend_iscsi.c | 13 +- src/storage/storage_backend_iscsi_direct.c | 25 ++- src/storage/storage_backend_logical.c | 16 +- src/storage/storage_backend_mpath.c | 9 +- src/storage/storage_backend_rbd.c | 16 +- src/storage/storage_backend_scsi.c | 11 +- src/storage/storage_backend_sheepdog.c | 7 +- src/storage/storage_backend_vstorage.c | 6 +- src/storage/storage_backend_zfs.c | 13 +- src/storage/storage_driver.c | 17 +-- src/storage/storage_file_gluster.c | 10 +- src/storage/storage_util.c | 87 ++++------- src/test/test_driver.c | 35 ++--- src/util/viraudit.c | 6 +- src/util/virauth.c | 17 +-- src/util/virauthconfig.c | 9 +- src/util/vircgroup.c | 39 ++--- src/util/vircgroupv1.c | 102 +++++-------- src/util/vircgroupv2.c | 97 ++++-------- src/util/vircommand.c | 12 +- src/util/virconf.c | 10 +- src/util/virdevmapper.c | 7 +- src/util/virdnsmasq.c | 39 ++--- src/util/virebtables.c | 5 +- src/util/virerror.c | 9 +- src/util/virfile.c | 77 +++------- src/util/virfirewall.c | 8 +- src/util/virhostcpu.c | 11 +- src/util/virhostdev.c | 3 +- src/util/virhostmem.c | 21 +-- src/util/viriptables.c | 20 +-- src/util/viriscsi.c | 6 +- src/util/virjson.c | 12 +- src/util/virkmod.c | 3 +- src/util/virlockspace.c | 2 +- src/util/virlog.c | 115 ++++++-------- src/util/virlog.h | 2 +- src/util/virmacmap.c | 2 +- src/util/virmdev.c | 11 +- src/util/virnetdev.c | 40 ++--- src/util/virnetdevbandwidth.c | 61 +++----- src/util/virnetdevbridge.c | 16 +- src/util/virnetdevip.c | 5 +- src/util/virnetdevmacvlan.c | 6 +- src/util/virnetdevopenvswitch.c | 18 +-- src/util/virnetdevtap.c | 6 +- src/util/virnetdevveth.c | 9 +- src/util/virnuma.c | 29 ++-- src/util/virpci.c | 85 ++++------- src/util/virpidfile.c | 9 +- src/util/virprocess.c | 24 ++- src/util/virqemu.c | 6 +- src/util/virrandom.c | 5 +- src/util/virresctrl.c | 21 +-- src/util/virrotatingfile.c | 12 +- src/util/virscsi.c | 31 ++-- src/util/virscsihost.c | 18 +-- src/util/virscsivhost.c | 4 +- src/util/virsocketaddr.c | 19 +-- src/util/virstoragefile.c | 14 +- src/util/virstring.c | 50 +----- src/util/virstring.h | 50 +----- src/util/virsystemd.c | 3 +- src/util/virtpm.c | 44 +++--- src/util/virtypedparam.c | 12 +- src/util/viruri.c | 3 +- src/util/virusb.c | 19 +-- src/util/virutil.c | 18 +-- src/util/virvhba.c | 52 +++---- src/vbox/vbox_MSCOMGlue.c | 4 +- src/vbox/vbox_XPCOMCGlue.c | 3 +- src/vbox/vbox_common.c | 62 ++++---- src/vbox/vbox_network.c | 13 +- src/vbox/vbox_snapshot_conf.c | 18 +-- src/vbox/vbox_storage.c | 5 +- src/vbox/vbox_tmpl.c | 32 ++-- src/vmware/vmware_conf.c | 31 ++-- src/vmware/vmware_conf.h | 4 +- src/vmx/vmx.c | 13 +- src/vz/vz_driver.c | 3 +- src/vz/vz_sdk.c | 46 ++---- tests/bhyveargv2xmltest.c | 10 +- tests/bhyvexml2argvtest.c | 18 +-- tests/bhyvexml2xmltest.c | 10 +- tests/commandtest.c | 27 ++-- tests/cputest.c | 95 +++++------- tests/domaincapstest.c | 26 ++-- tests/domainconftest.c | 5 +- tests/eventtest.c | 4 +- tests/fchosttest.c | 7 +- tests/fdstreamtest.c | 6 +- tests/genericxml2xmltest.c | 10 +- tests/interfacexml2xmltest.c | 5 +- tests/libxlxml2domconfigtest.c | 8 +- tests/lxcconf2xmltest.c | 20 +-- tests/lxcxml2xmltest.c | 10 +- tests/networkxml2conftest.c | 9 +- tests/networkxml2firewalltest.c | 16 +- tests/networkxml2xmltest.c | 9 +- tests/networkxml2xmlupdatetest.c | 15 +- tests/nodedevxml2xmltest.c | 5 +- tests/nssmock.c | 9 +- tests/nwfilterxml2firewalltest.c | 15 +- tests/nwfilterxml2xmltest.c | 9 +- tests/openvzutilstest.c | 6 +- tests/qemuagenttest.c | 4 +- tests/qemublocktest.c | 34 ++--- tests/qemucapabilitiestest.c | 20 +-- tests/qemucaps2xmltest.c | 15 +- tests/qemudomaincheckpointxml2xmltest.c | 5 +- tests/qemudomainsnapshotxml2xmltest.c | 5 +- tests/qemufirmwaretest.c | 4 +- tests/qemuhotplugtest.c | 29 ++-- tests/qemumemlocktest.c | 5 +- tests/qemumigparamstest.c | 23 ++- tests/qemumonitorjsontest.c | 56 +++---- tests/qemumonitortestutils.c | 42 ++---- tests/qemusecuritymock.c | 5 +- tests/qemusecuritytest.c | 3 +- tests/qemuvhostusertest.c | 4 +- tests/qemuxml2argvtest.c | 35 ++--- tests/qemuxml2xmltest.c | 41 ++--- tests/scsihosttest.c | 26 +--- tests/secretxml2xmltest.c | 14 +- tests/securityselinuxlabeltest.c | 23 +-- tests/storagebackendsheepdogtest.c | 11 +- tests/storagepoolcapstest.c | 6 +- tests/storagepoolxml2argvtest.c | 11 +- tests/storagepoolxml2xmltest.c | 9 +- tests/storagevolxml2argvtest.c | 35 ++--- tests/storagevolxml2xmltest.c | 13 +- tests/sysinfotest.c | 18 +-- tests/testutils.c | 17 +-- tests/testutils.h | 5 +- tests/testutilsqemu.c | 11 +- tests/vboxsnapshotxmltest.c | 5 +- tests/virbuftest.c | 7 +- tests/vircaps2xmltest.c | 15 +- tests/vircgroupmock.c | 11 +- tests/vircgrouptest.c | 5 +- tests/virconftest.c | 7 +- tests/virfilemock.c | 2 +- tests/virfiletest.c | 3 +- tests/virfilewrapper.c | 4 +- tests/virhostcputest.c | 38 ++--- tests/virjsontest.c | 27 ++-- tests/virmacmaptest.c | 12 +- tests/virnetdaemontest.c | 10 +- tests/virnetdevmock.c | 8 +- tests/virnetdevopenvswitchtest.c | 5 +- tests/virnetsockettest.c | 6 +- tests/virnetworkportxml2xmltest.c | 6 +- tests/virnumamock.c | 3 +- tests/virnwfilterbindingxml2xmltest.c | 7 +- tests/virpcimock.c | 103 +++++-------- tests/virpcitest.c | 16 +- tests/virrandommock.c | 5 +- tests/virresctrltest.c | 15 +- tests/virschematest.c | 19 +-- tests/virscsitest.c | 11 +- tests/virshtest.c | 5 +- tests/virstoragetest.c | 63 ++++---- tests/virtestmock.c | 8 +- tests/virusbmock.c | 9 +- tests/virusbtest.c | 6 +- tests/vmwarevertest.c | 4 +- tests/vmx2xmltest.c | 18 +-- tests/xlconfigtest.c | 8 +- tests/xmconfigtest.c | 8 +- tests/xml2vmxtest.c | 16 +- tools/virsh-completer-domain.c | 7 +- tools/virsh-completer-host.c | 13 +- tools/virsh-completer.c | 6 +- tools/virsh-domain-monitor.c | 21 ++- tools/virsh-domain.c | 34 ++--- tools/virsh-host.c | 3 +- tools/virsh-interface.c | 11 +- tools/virsh-network.c | 3 +- tools/virsh-pool.c | 15 +- tools/virsh-volume.c | 9 +- tools/virt-admin.c | 6 +- tools/virt-host-validate-common.c | 10 +- tools/vsh.c | 53 ++----- 291 files changed, 2096 insertions(+), 3822 deletions(-) -- 2.21.0

6 121

[libvirt] [PATCH 00/12] tests/domaincaps: Use testQemuCapsIterate()
by Andrea Bolognani 24 Oct '19

24 Oct '19

I finally got annoyed enough by the fact that this test program, unlike qemucapabilitiestest and qemucaps2xmltest, is not self-maintaining. The series, as posted to the list, is heavily snipped: grab the full version with $ git fetch https://gitlab.com/abologna/libvirt.git domaincapstest Andrea Bolognani (12): tests/qemucapabilities: Separate inputDir and outputDir tests: testQemuCapsIterate: Don't ignore malformed file names tests: testQemuCapsIterate: Validate suffix tests: testQemuCapsIterate: Pass inputDir to callback tests: testQemuCapsIterate: Pass suffix to callback tests: testQemuCapsIterate: Pass prefix and version to callback tests: Rename domaincapsschemadata/ -> domaincapsdata/ tests/domaincaps: Don't mess with test name tests/domaincaps: Move most of DO_TEST_QEMU() into a function tests/domaincaps: Don't require redundant information tests/domaincaps: Make test matrix programmatic tests/domaincaps: Use testQemuCapsIterate() tests/Makefile.am | 2 +- .../bhyve_basic.x86_64.xml | 0 .../bhyve_fbuf.x86_64.xml | 0 .../bhyve_uefi.x86_64.xml | 0 .../empty.xml | 0 .../libxl-xenfv.xml | 0 .../libxl-xenpv.xml | 0 .../qemu_1.5.3-q35.x86_64.xml} | 4 +- .../qemu_1.5.3-tcg.x86_64.xml} | 6 +- .../qemu_1.5.3.x86_64.xml} | 2 +- .../qemu_1.6.0-q35.x86_64.xml} | 4 +- .../qemu_1.6.0-tcg.x86_64.xml} | 6 +- .../qemu_1.6.0.x86_64.xml} | 2 +- .../qemu_1.7.0-q35.x86_64.xml} | 4 +- .../qemu_1.7.0-tcg.x86_64.xml} | 4 +- .../qemu_1.7.0.x86_64.xml | 0 .../qemu_2.1.1-q35.x86_64.xml} | 7 +- .../qemu_2.1.1-tcg.x86_64.xml} | 9 +- .../qemu_2.1.1.x86_64.xml} | 5 +- .../qemu_2.10.0-q35.x86_64.xml} | 21 +- .../qemu_2.10.0-tcg.x86_64.xml} | 3 +- .../qemu_2.10.0-virt.aarch64.xml} | 3 +- .../qemu_2.10.0.aarch64.xml} | 1 + .../qemu_2.10.0.ppc64.xml} | 2 +- .../qemu_2.10.0.s390x.xml} | 110 ++++----- .../qemu_2.10.0.x86_64.xml} | 21 +- .../qemu_2.11.0-q35.x86_64.xml} | 7 +- .../qemu_2.11.0-tcg.x86_64.xml} | 34 ++- .../qemu_2.11.0.s390x.xml} | 11 +- .../qemu_2.11.0.x86_64.xml} | 7 +- .../qemu_2.12.0-q35.x86_64.xml} | 6 +- .../qemu_2.12.0-tcg.x86_64.xml} | 50 ++-- .../qemu_2.12.0-virt.aarch64.xml | 0 .../qemu_2.12.0.aarch64.xml} | 5 +- .../qemu_2.12.0.ppc64.xml | 0 .../qemu_2.12.0.s390x.xml | 0 .../qemu_2.12.0.x86_64.xml | 0 .../qemu_2.4.0-q35.x86_64.xml} | 4 +- .../qemu_2.4.0-tcg.x86_64.xml} | 6 +- .../qemu_2.4.0.x86_64.xml} | 2 +- .../qemu_2.5.0-q35.x86_64.xml} | 4 +- .../qemu_2.5.0-tcg.x86_64.xml} | 6 +- .../qemu_2.5.0.x86_64.xml} | 2 +- .../qemu_2.6.0-q35.x86_64.xml} | 4 +- .../qemu_2.6.0-tcg.x86_64.xml} | 4 +- .../qemu_2.6.0-virt.aarch64.xml | 0 .../qemu_2.6.0.aarch64.xml | 0 .../qemu_2.6.0.ppc64.xml | 0 .../qemu_2.6.0.x86_64.xml | 0 .../qemu_2.7.0-q35.x86_64.xml} | 5 +- .../qemu_2.7.0-tcg.x86_64.xml} | 7 +- .../qemu_2.7.0.s390x.xml | 0 .../qemu_2.7.0.x86_64.xml} | 3 +- .../qemu_2.8.0-q35.x86_64.xml} | 6 +- .../qemu_2.8.0-tcg.x86_64.xml | 0 .../qemu_2.8.0.s390x.xml | 0 .../qemu_2.8.0.x86_64.xml | 0 .../qemu_2.9.0-q35.x86_64.xml | 0 .../qemu_2.9.0-tcg.x86_64.xml | 0 .../qemu_2.9.0.ppc64.xml} | 2 +- .../qemu_2.9.0.s390x.xml} | 7 +- .../qemu_2.9.0.x86_64.xml | 0 .../qemu_3.0.0-q35.x86_64.xml} | 11 +- .../qemu_3.0.0-tcg.x86_64.xml} | 52 +++-- .../qemu_3.0.0.ppc64.xml} | 3 +- .../qemu_3.0.0.s390x.xml | 0 .../qemu_3.0.0.x86_64.xml} | 7 +- .../qemu_3.1.0-q35.x86_64.xml} | 6 +- .../qemu_3.1.0-tcg.x86_64.xml} | 55 +++-- .../qemu_3.1.0.ppc64.xml} | 3 +- .../qemu_3.1.0.x86_64.xml | 0 .../qemu_4.0.0-q35.x86_64.xml} | 6 +- .../qemu_4.0.0-tcg.x86_64.xml} | 55 +++-- .../qemu_4.0.0-virt.aarch64.xml} | 16 +- .../qemu_4.0.0.aarch64.xml} | 2 +- .../qemu_4.0.0.ppc64.xml} | 2 +- .../qemu_4.0.0.s390x.xml | 0 .../qemu_4.0.0.x86_64.xml | 0 .../qemu_4.1.0-q35.x86_64.xml} | 6 +- .../qemu_4.1.0-tcg.x86_64.xml} | 59 +++-- .../qemu_4.1.0.x86_64.xml | 0 .../qemu_4.2.0-q35.x86_64.xml} | 6 +- .../qemu_4.2.0-tcg.x86_64.xml} | 59 +++-- .../qemu_4.2.0-virt.aarch64.xml} | 14 +- .../qemu_4.2.0.aarch64.xml | 0 .../qemu_4.2.0.ppc64.xml | 0 .../qemu_4.2.0.x86_64.xml | 0 tests/domaincapstest.c | 221 ++++++++---------- .../caps_1.5.3.x86_64.xml | 2 +- .../caps_1.6.0.x86_64.xml | 2 +- .../caps_1.7.0.x86_64.xml | 2 +- .../caps_2.1.1.x86_64.xml | 2 +- .../caps_2.10.0.aarch64.xml | 2 +- .../caps_2.10.0.ppc64.xml | 2 +- .../caps_2.10.0.s390x.xml | 2 +- .../caps_2.10.0.x86_64.xml | 2 +- .../caps_2.11.0.s390x.xml | 2 +- .../caps_2.11.0.x86_64.xml | 2 +- .../caps_2.12.0.aarch64.xml | 2 +- .../caps_2.12.0.ppc64.xml | 2 +- .../caps_2.12.0.s390x.xml | 2 +- .../caps_2.12.0.x86_64.xml | 2 +- .../caps_2.4.0.x86_64.xml | 2 +- .../caps_2.5.0.x86_64.xml | 2 +- .../caps_2.6.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 2 +- .../caps_2.6.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 +- .../caps_2.7.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 +- .../caps_2.8.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 +- .../caps_2.9.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 +- .../caps_3.0.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 +- .../caps_3.1.0.x86_64.xml | 2 +- .../caps_4.0.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2 +- .../caps_4.0.0.x86_64.xml | 2 +- .../caps_4.1.0.x86_64.xml | 2 +- .../caps_4.2.0.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 +- .../caps_4.2.0.x86_64.xml | 2 +- tests/qemucapabilitiestest.c | 40 ++-- tests/qemucaps2xmltest.c | 22 +- tests/testutilsqemu.c | 41 +++- tests/testutilsqemu.h | 5 +- tests/virschematest.c | 2 +- 132 files changed, 645 insertions(+), 524 deletions(-) rename tests/{domaincapsschemadata => domaincapsdata}/bhyve_basic.x86_64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/bhyve_fbuf.x86_64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/bhyve_uefi.x86_64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/empty.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/libxl-xenfv.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/libxl-xenpv.xml (100%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.5.3-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.5.3-tcg.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.5.3.x86_64.xml} (99%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.6.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.6.0-tcg.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.6.0.x86_64.xml} (99%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.7.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_1.7.0-tcg.x86_64.xml} (98%) copy tests/{domaincapsschemadata => domaincapsdata}/qemu_1.7.0.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_2.1.1-q35.x86_64.xml} (96%) copy tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_2.1.1-tcg.x86_64.xml} (95%) rename tests/{domaincapsschemadata/qemu_1.7.0.x86_64.xml => domaincapsdata/qemu_2.1.1.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml => domaincapsdata/qemu_2.10.0-q35.x86_64.xml} (87%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_2.10.0-tcg.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.6.0-virt.aarch64.xml => domaincapsdata/qemu_2.10.0-virt.aarch64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.6.0.aarch64.xml => domaincapsdata/qemu_2.10.0.aarch64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.12.0.ppc64.xml => domaincapsdata/qemu_2.10.0.ppc64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.12.0.s390x.xml => domaincapsdata/qemu_2.10.0.s390x.xml} (96%) copy tests/{domaincapsschemadata/qemu_2.9.0.x86_64.xml => domaincapsdata/qemu_2.10.0.x86_64.xml} (87%) copy tests/{domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml => domaincapsdata/qemu_2.11.0-q35.x86_64.xml} (95%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_2.11.0-tcg.x86_64.xml} (84%) copy tests/{domaincapsschemadata/qemu_2.12.0.s390x.xml => domaincapsdata/qemu_2.11.0.s390x.xml} (97%) copy tests/{domaincapsschemadata/qemu_2.9.0.x86_64.xml => domaincapsdata/qemu_2.11.0.x86_64.xml} (95%) copy tests/{domaincapsschemadata/qemu_2.12.0.x86_64.xml => domaincapsdata/qemu_2.12.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_2.12.0-tcg.x86_64.xml} (78%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.12.0-virt.aarch64.xml (100%) copy tests/{domaincapsschemadata/qemu_2.6.0.aarch64.xml => domaincapsdata/qemu_2.12.0.aarch64.xml} (95%) copy tests/{domaincapsschemadata => domaincapsdata}/qemu_2.12.0.ppc64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.12.0.s390x.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.12.0.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.4.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.4.0-tcg.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.4.0.x86_64.xml} (99%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.5.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.5.0-tcg.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.5.0.x86_64.xml} (99%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.6.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.6.0-tcg.x86_64.xml} (98%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.6.0-virt.aarch64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.6.0.aarch64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.6.0.ppc64.xml (100%) copy tests/{domaincapsschemadata => domaincapsdata}/qemu_2.6.0.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.7.0-q35.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.7.0-tcg.x86_64.xml} (96%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.7.0.s390x.xml (100%) rename tests/{domaincapsschemadata/qemu_2.6.0.x86_64.xml => domaincapsdata/qemu_2.7.0.x86_64.xml} (97%) copy tests/{domaincapsschemadata/qemu_2.8.0.x86_64.xml => domaincapsdata/qemu_2.8.0-q35.x86_64.xml} (98%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.8.0-tcg.x86_64.xml (100%) copy tests/{domaincapsschemadata => domaincapsdata}/qemu_2.8.0.s390x.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.8.0.x86_64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.9.0-q35.x86_64.xml (100%) copy tests/{domaincapsschemadata => domaincapsdata}/qemu_2.9.0-tcg.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_2.12.0.ppc64.xml => domaincapsdata/qemu_2.9.0.ppc64.xml} (98%) rename tests/{domaincapsschemadata/qemu_2.8.0.s390x.xml => domaincapsdata/qemu_2.9.0.s390x.xml} (97%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_2.9.0.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_4.0.0.x86_64.xml => domaincapsdata/qemu_3.0.0-q35.x86_64.xml} (95%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_3.0.0-tcg.x86_64.xml} (78%) rename tests/{domaincapsschemadata/qemu_2.12.0.ppc64.xml => domaincapsdata/qemu_3.0.0.ppc64.xml} (97%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_3.0.0.s390x.xml (100%) copy tests/{domaincapsschemadata/qemu_4.0.0.x86_64.xml => domaincapsdata/qemu_3.0.0.x86_64.xml} (95%) copy tests/{domaincapsschemadata/qemu_3.1.0.x86_64.xml => domaincapsdata/qemu_3.1.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_3.1.0-tcg.x86_64.xml} (77%) copy tests/{domaincapsschemadata/qemu_4.2.0.ppc64.xml => domaincapsdata/qemu_3.1.0.ppc64.xml} (97%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_3.1.0.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_4.0.0.x86_64.xml => domaincapsdata/qemu_4.0.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_4.0.0-tcg.x86_64.xml} (77%) copy tests/{domaincapsschemadata/qemu_4.2.0.aarch64.xml => domaincapsdata/qemu_4.0.0-virt.aarch64.xml} (95%) copy tests/{domaincapsschemadata/qemu_4.2.0.aarch64.xml => domaincapsdata/qemu_4.0.0.aarch64.xml} (100%) copy tests/{domaincapsschemadata/qemu_4.2.0.ppc64.xml => domaincapsdata/qemu_4.0.0.ppc64.xml} (98%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_4.0.0.s390x.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_4.0.0.x86_64.xml (100%) copy tests/{domaincapsschemadata/qemu_4.1.0.x86_64.xml => domaincapsdata/qemu_4.1.0-q35.x86_64.xml} (98%) copy tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_4.1.0-tcg.x86_64.xml} (75%) copy tests/{domaincapsschemadata => domaincapsdata}/qemu_4.1.0.x86_64.xml (100%) rename tests/{domaincapsschemadata/qemu_4.1.0.x86_64.xml => domaincapsdata/qemu_4.2.0-q35.x86_64.xml} (98%) rename tests/{domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml => domaincapsdata/qemu_4.2.0-tcg.x86_64.xml} (75%) copy tests/{domaincapsschemadata/qemu_4.2.0.aarch64.xml => domaincapsdata/qemu_4.2.0-virt.aarch64.xml} (95%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_4.2.0.aarch64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_4.2.0.ppc64.xml (100%) rename tests/{domaincapsschemadata => domaincapsdata}/qemu_4.2.0.x86_64.xml (100%) -- 2.21.0

2 14

[libvirt] [PATCH 00/19] util: buffer: Use glib's GString internally
by Peter Krempa 24 Oct '19

24 Oct '19

3 39