- Devel - libvirt List Archives

[libvirt] [PATCH] maint: Post-release version bump to 5.10.0
by Andrea Bolognani 06 Nov '19

06 Nov '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8b53b6ada9..233fbeaaf3 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [5.9.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [5.10.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index d770e88eb0..4dd8dd6dcc 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -42,6 +42,14 @@ --> <libvirt> + <release version="v5.10.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v5.9.0" date="2019-11-05"> <section title="Packaging changes"> <change> -- 2.21.0

1 0

Re: [libvirt] [PATCH v3 REBASE 2 00/12] hostdev: handle usb detach/attach on node
by Dave Allan 05 Nov '19

05 Nov '19

[ bah, cc'ing the list this time ] On Tue, Nov 05, 2019 at 03:21:04PM -0500, Dave Allan wrote: >On Fri, Nov 01, 2019 at 07:48:46AM +0000, Nikolay Shirokovskiy wrote: >> >> >>On 31.10.2019 19:50, Dave Allan wrote: >>>On Thu, Oct 31, 2019 at 10:40:42AM +0000, Nikolay Shirokovskiy wrote: >>>> >>>> >>>>On 30.10.2019 23:21, Dave Allan wrote: >>>>>On Tue, Oct 29, 2019 at 11:17:51AM +0300, Nikolay Shirokovskiy wrote: >>>>>>Diff to v2[1] version: >>>>>>- add 'replug' attribute for hostdev element to allow replug semantics >>>>>>- avoid accuiring domain lock in event loop thread on udev events as >>>>>> suggested by Peter >>>>>>- nit picks after review by Daniel Henrique Barboza >>>>>> >>>>>>* is used to mark patches that were 'Reviewed-by' by Daniel (sometimes >>>>>> with very minor changes to take into account new replug flag). >>>>> >>>>>I did some basic testing today, and I'm seeing the device appear and disappear in the guest, which is great and much nicer than my ugly udev rule hack. I did find what I think is a bug though: if the USB device is plugged in at domain start, unplugging it while the domain is running does not cause it to disappear, and subsqeuently replugging it into the host causes a second instance of the device to appear in the guest. >>>> >>>>Hi. >>>> >>>>Hmm. Looks like you're using startupPolicy=optional otherwise it is not >>>>possible to start domain without a device. But in this case the whole replug thing >>>>is disabled and further I don't understand how the second instance of the device can appear. >>>> >>>>If device is present at domain start then replug is in play. And I cannot reproduce the bug. >>> >>>I am using startupPolicy optional, and I'm seeing the device attached and detached 100% of the time. I can start the domain with or without the device attached to the host, plug and unplug it and it appears and disappears from the guest, which is exactly the behavior I want. My domain XML is attached. >> >>Hi, >> >>did you actually see your device in guest or just some usb device? Because if domain is started without a device present on host then >>libvirt inserts dummy device which is unusable actually. And this dummy device is kept until the end even if you plug device on node. > >Sorry to be slow responding, I wanted to confirm that I could talk to the device in the guest. Today I wasn't able to reproduce the duplicate device in the guest. Eerything worked as I would expect: if the device wasn't plugged into the host, it wasn't shown by lsusb in the guest. Plugging in the device to the host caused it to appear in the guest. If the device was shown by lsusb in the guest I was able to talk to it. > >>Nikolay >> >>> >>>I tested a few more times just now, and I saw the duplicate device appear in the guest the first time I tried, but I have not been able to reproduce it again after that. >>> >>>>Can you clarify on you use case? >>> >>>My usecase is that I'm flashing the USB device with a program running in the VM. I keep the VM running, and when I need to reflash, I connect the device, so having the startupPolicy optional is useful. >>> >>>>Nikolay >>>> >>>>> >>>>>>Can be applied on: >>>>>> >>>>>>commit bf0e7bdeeb790bc6ba5732623be0d9ff26a5961a >>>>>>Author: Peter Krempa <pkrempa(a)redhat.com> >>>>>>Date: Thu Oct 24 15:50:50 2019 +0200 >>>>>> >>>>>> util: xml: Make virXMLFormatElement void >>>>>>[1] https://www.redhat.com/archives/libvir-list/2019-September/msg00321.html >>>>>> >>>>>>Nikolay Shirokovskiy (12): >>>>>> conf: add replug option for usb hostdev >>>>>> qemu: track hostdev delete intention >>>>>> *qemu: support host usb device unplug >>>>>> *qemu: support usb hostdev plugging back >>>>>> qemu: handle host usb device add/del udev events >>>>>> *qemu: handle libvirtd restart after host usb device unplug >>>>>> *qemu: handle race on device deletion and usb host device plugging >>>>>> qemu: hotplug: update device list on device deleted event >>>>>> *qemu: handle host usb device plug/unplug when libvirtd is down >>>>>> *qemu: don't mess with non mandatory hostdevs on reattaching >>>>>> qemu: handle detaching of unplugged hostdev >>>>>> *conf: parse hostdev missing flag >>>>>> >>>>>>docs/formatdomain.html.in | 10 +- >>>>>>docs/schemas/domaincommon.rng | 5 + >>>>>>src/conf/domain_conf.c | 62 +++ >>>>>>src/conf/domain_conf.h | 17 + >>>>>>src/qemu/Makefile.inc.am | 2 + >>>>>>src/qemu/qemu_conf.h | 3 + >>>>>>src/qemu/qemu_domain.c | 2 + >>>>>>src/qemu/qemu_domain.h | 2 + >>>>>>src/qemu/qemu_driver.c | 404 +++++++++++++++++- >>>>>>src/qemu/qemu_hotplug.c | 104 ++++- >>>>>>src/qemu/qemu_hotplug.h | 3 +- >>>>>>src/qemu/qemu_process.c | 60 +++ >>>>>>src/util/virhostdev.c | 2 + >>>>>>tests/qemuhotplugtest.c | 2 +- >>>>>>tests/qemuxml2argvdata/hostdev-usb-replug.xml | 36 ++ >>>>>>.../qemuxml2xmloutdata/hostdev-usb-replug.xml | 40 ++ >>>>>>tests/qemuxml2xmltest.c | 1 + >>>>>>17 files changed, 733 insertions(+), 22 deletions(-) >>>>>>create mode 100644 tests/qemuxml2argvdata/hostdev-usb-replug.xml >>>>>>create mode 100644 tests/qemuxml2xmloutdata/hostdev-usb-replug.xml >>>>>> >>>>>>-- >>>>>>2.23.0 >>>>>> >>>>>>-- >>>>>>libvir-list mailing list >>>>>>libvir-list(a)redhat.com >>>>>>https://www.redhat.com/mailman/listinfo/libvir-list >>>>>> >>>>>> >>

1 0

[libvirt] [PATCH v3 REBASE 2 00/12] hostdev: handle usb detach/attach on node
by Nikolay Shirokovskiy 05 Nov '19

05 Nov '19

Diff to v2[1] version: - add 'replug' attribute for hostdev element to allow replug semantics - avoid accuiring domain lock in event loop thread on udev events as suggested by Peter - nit picks after review by Daniel Henrique Barboza * is used to mark patches that were 'Reviewed-by' by Daniel (sometimes with very minor changes to take into account new replug flag). Can be applied on: commit bf0e7bdeeb790bc6ba5732623be0d9ff26a5961a Author: Peter Krempa <pkrempa(a)redhat.com> Date: Thu Oct 24 15:50:50 2019 +0200 util: xml: Make virXMLFormatElement void [1] https://www.redhat.com/archives/libvir-list/2019-September/msg00321.html Nikolay Shirokovskiy (12): conf: add replug option for usb hostdev qemu: track hostdev delete intention *qemu: support host usb device unplug *qemu: support usb hostdev plugging back qemu: handle host usb device add/del udev events *qemu: handle libvirtd restart after host usb device unplug *qemu: handle race on device deletion and usb host device plugging qemu: hotplug: update device list on device deleted event *qemu: handle host usb device plug/unplug when libvirtd is down *qemu: don't mess with non mandatory hostdevs on reattaching qemu: handle detaching of unplugged hostdev *conf: parse hostdev missing flag docs/formatdomain.html.in | 10 +- docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 62 +++ src/conf/domain_conf.h | 17 + src/qemu/Makefile.inc.am | 2 + src/qemu/qemu_conf.h | 3 + src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 404 +++++++++++++++++- src/qemu/qemu_hotplug.c | 104 ++++- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_process.c | 60 +++ src/util/virhostdev.c | 2 + tests/qemuhotplugtest.c | 2 +- tests/qemuxml2argvdata/hostdev-usb-replug.xml | 36 ++ .../qemuxml2xmloutdata/hostdev-usb-replug.xml | 40 ++ tests/qemuxml2xmltest.c | 1 + 17 files changed, 733 insertions(+), 22 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-usb-replug.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-usb-replug.xml -- 2.23.0

4 17

[libvirt] [PATCH 0/9] support use of precreated tap devices from unprivileged libvirtd
by Laine Stump 05 Nov '19

05 Nov '19

This resolves https://bugzilla.redhat.com/1723367 It has become more popular to run libvirtd in an unprivileged environment (e.g. inside a container), but until now the only possible types of network connection for a qemu started by an unprivileged libvirtd were: 1) a usermode slirp connection 2) a tap device connection to a bridge handled by running qemu-bridge-helper (a suid-root utility distributed with qemu) 3) a host network card assigned to the guest using VFIO (this requires special setup by a privileged process though) This patch series remedies that by making it possible for libvirtd to use a tap device that has been pre-created (*and* properly setup) by some other process beforehand. In order to use this, you must have a standard tap, or macvtap device that has been set to be owned by the uid that will be running libvirtd, has its MAC address already set, and has been set online (IFF_UP). For example, here are the commands to create a standard tap device named "mytap0", attach it to the host bridge device "br0" and prepare it for use by a libvirtd that is running as user "laine": ip tuntap add mode tap user laine group laine name mytap0 ip link set mytap0 up ip link set mytap0 master br0 (You may want to set a specific MAC address for the tap device, but as long as it *doesn't* match the MAC address used by the guest emulated device, it really doesn't matter) You can now add the following <interface> to a domain definition: <interface type='ethernet'> <model type='virtio'/> <mac address='52:54:00:11:11:11'/> <target dev='mytap0' managed='no'/> </interface> and start up the guest. A similar set of commands to create a macvtap device named "mymacvtap0" with MAC addres 52:54:00:11:11:11 connected to the host device "en2" would be something like this: ip link add link en2 name mymacvtap0 address 52:54:00:11:11:11 \ type macvtap mode bridge ip link set mymacvtap0 up The XML would be identical, except the name of the device <interface type='ethernet'> <model type='virtio'/> <mac address='52:54:00:11:11:11'/> <target dev='mymacvtap0' managed='no'/> </interface> (Note that in the case of macvtap, the precreated device must *match* the MAC address of the emulated guest device). If libvirtd is given a precreated device, that device will *not* be explicitly deleted when qemu is finished with it - the caller must take care of that. Laine Stump (9): util: new function virNetDevMacVLanIsMacvtap() util: make a couple virNetDevMacVlan*() functions public qemu: reorganize qemuInterfaceEthernetConnect() conf: use virXMLFormatElement for interface <target> conf: new "managed" attribute for target dev of <interface type='ethernet'> qemu: support unmanaged target tap dev for <interface type='ethernet'> qemu: support unmanaged macvtap devices with <interface type='ethernet'> qemu: explicitly delete standard tap devices only on platforms that require it docs: update news file docs/formatdomain.html.in | 48 +++++++--- docs/news.xml | 13 +++ docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 55 +++++++++--- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 3 + src/qemu/qemu_interface.c | 89 ++++++++++++------- src/qemu/qemu_process.c | 6 +- src/util/virnetdev.h | 2 +- src/util/virnetdevmacvlan.c | 35 ++++++-- src/util/virnetdevmacvlan.h | 12 +++ .../net-eth-unmanaged-tap.args | 32 +++++++ .../net-eth-unmanaged-tap.xml | 35 ++++++++ tests/qemuxml2argvmock.c | 16 +++- tests/qemuxml2argvtest.c | 1 + .../net-eth-unmanaged-tap.xml | 40 +++++++++ tests/qemuxml2xmltest.c | 1 + 17 files changed, 329 insertions(+), 65 deletions(-) create mode 100644 tests/qemuxml2argvdata/net-eth-unmanaged-tap.args create mode 100644 tests/qemuxml2argvdata/net-eth-unmanaged-tap.xml create mode 100644 tests/qemuxml2xmloutdata/net-eth-unmanaged-tap.xml -- 2.21.0

4 22

[libvirt] [PATCH v2 0/2] gitdm: Update configuration
by Andrea Bolognani 05 Nov '19

05 Nov '19

Changes from [v1]: * added a few more addresses. [v1] https://www.redhat.com/archives/libvir-list/2019-October/msg01095.html Andrea Bolognani (2): gitdm: Fix sorting gitdm: Add missing entries docs/gitdm/companies/others | 4 +++- docs/gitdm/groups/opensource | 1 + docs/gitdm/groups/unaffiliated | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) -- 2.21.0

2 4

[libvirt] [PATCH v2 0/2] news: Update for 5.9.0 release
by Andrea Bolognani 04 Nov '19

04 Nov '19

You know the drill. Andrea Bolognani (2): news: Document more possible sections news: Update for 5.9.0 release docs/news.xml | 103 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 101 insertions(+), 2 deletions(-) -- 2.21.0

2 4

[libvirt] [PATCH] docs: Fix attribute names in filesystem/driver example
by Jim Fehlig 04 Nov '19

04 Nov '19

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 7619c88514..84257c1bb4 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3847,7 +3847,7 @@ <readonly/> </filesystem> <filesystem type='file' accessmode='passthrough'> - <driver name='loop' type='raw'/> + <driver type='loop' format='raw'/> <driver type='path' wrpolicy='immediate'/> <source file='/export/to/guest.img'/> <target dir='/import/from/host'/> -- 2.23.0

2 2

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3
by liushuyu＠aosc.io 01 Nov '19

01 Nov '19

From: liushuyu <liushuyu011(a)gmail.com> --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else: missing.add(el) - print "missing: %s, implemented: %s" % (len(missing), len(implemented)) - print "missing:" + print("missing: %s, implemented: %s" % (len(missing), len(implemented))) + print("missing:") for x in missing: - print x.attrib + print(x.attrib) #print "implemented:" #for x in implemented: # print x.attrib -- 2.23.0

1 0

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3
by liushuyu＠aosc.io 01 Nov '19

01 Nov '19

From: liushuyu <liushuyu011(a)gmail.com> --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else: missing.add(el) - print "missing: %s, implemented: %s" % (len(missing), len(implemented)) - print "missing:" + print("missing: %s, implemented: %s" % (len(missing), len(implemented))) + print("missing:") for x in missing: - print x.attrib + print(x.attrib) #print "implemented:" #for x in implemented: # print x.attrib -- 2.23.0

1 0

[libvirt] Entering freeze for libvirt 5.9.0
by Daniel Veillard 01 Nov '19

01 Nov '19

We are getting close to the end of the month, a lot of developers are at KVM Forum in Lyon, so starting the release process now looks a good idea. I have tagged the RC1 in git and pushed signed tarball and source rpm to the usual place: https://libvirt.org/sources/ Seems to work in my limited testing, the Ci is almost all green https://ci.centos.org/view/libvirt/ so things looks good in my perspective. Please give it a try, I will try to push RC2 on Wednesday, and based on feedback roll the release on Friday or during the week-end, thanks in advance, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 6