- Devel - libvirt List Archives

[PATCH] src: network_conf: propagate only bool to virNetworkDefParseString()
by Kristina Hanicova 10 Sep '21

10 Sep '21

We don't need to propagate all public flags, only the information about the presence of the validation one, which can differ from function to function. This patch makes it easier and more readable in case of a future additions of validation flags. This change was suggested by Daniel. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/conf/domain_conf.c | 2 +- src/conf/network_conf.c | 12 ++++++------ src/conf/network_conf.h | 2 +- src/esx/esx_network_driver.c | 2 +- src/network/bridge_driver.c | 5 +++-- src/qemu/qemu_process.c | 2 +- src/test/test_driver.c | 5 +++-- src/vbox/vbox_network.c | 3 ++- 8 files changed, 18 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cb9e7218ff..858f6f923a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30523,7 +30523,7 @@ virDomainNetResolveActualType(virDomainNetDef *iface) if (!(xml = virNetworkGetXMLDesc(net, 0))) goto cleanup; - if (!(def = virNetworkDefParseString(xml, NULL, 0))) + if (!(def = virNetworkDefParseString(xml, NULL, false))) goto cleanup; switch ((virNetworkForwardType) def->forward.type) { diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index f23599abac..7a0f6f02c3 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -318,7 +318,7 @@ virNetworkDefCopy(virNetworkDef *def, if (!(xml = virNetworkDefFormat(def, xmlopt, flags))) return NULL; - return virNetworkDefParseString(xml, xmlopt, 0); + return virNetworkDefParseString(xml, xmlopt, false); } @@ -2086,14 +2086,14 @@ static virNetworkDef * virNetworkDefParse(const char *xmlStr, const char *filename, virNetworkXMLOption *xmlopt, - unsigned int flags) + bool validate_flag) { g_autoptr(xmlDoc) xml = NULL; virNetworkDef *def = NULL; int keepBlanksDefault = xmlKeepBlanksDefault(0); if ((xml = virXMLParse(filename, xmlStr, _("(network_definition)"), - "network.rng", flags & VIR_NETWORK_DEFINE_VALIDATE))) + "network.rng", validate_flag))) def = virNetworkDefParseNode(xml, xmlDocGetRootElement(xml), xmlopt); xmlKeepBlanksDefault(keepBlanksDefault); @@ -2104,9 +2104,9 @@ virNetworkDefParse(const char *xmlStr, virNetworkDef * virNetworkDefParseString(const char *xmlStr, virNetworkXMLOption *xmlopt, - unsigned int flags) + bool validate_flag) { - return virNetworkDefParse(xmlStr, NULL, xmlopt, flags); + return virNetworkDefParse(xmlStr, NULL, xmlopt, validate_flag); } @@ -2114,7 +2114,7 @@ virNetworkDef * virNetworkDefParseFile(const char *filename, virNetworkXMLOption *xmlopt) { - return virNetworkDefParse(NULL, filename, xmlopt, 0); + return virNetworkDefParse(NULL, filename, xmlopt, false); } diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h index 30958eff64..1dda45b25c 100644 --- a/src/conf/network_conf.h +++ b/src/conf/network_conf.h @@ -329,7 +329,7 @@ virNetworkDefParseXML(xmlXPathContextPtr ctxt, virNetworkDef * virNetworkDefParseString(const char *xmlStr, virNetworkXMLOption *xmlopt, - unsigned int flags); + bool validate_flag); virNetworkDef * virNetworkDefParseFile(const char *filename, diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c index 673ed5421f..8acf7591cf 100644 --- a/src/esx/esx_network_driver.c +++ b/src/esx/esx_network_driver.c @@ -298,7 +298,7 @@ esxNetworkDefineXMLFlags(virConnectPtr conn, const char *xml, return NULL; /* Parse network XML */ - def = virNetworkDefParseString(xml, NULL, flags); + def = virNetworkDefParseString(xml, NULL, flags & VIR_NETWORK_DEFINE_VALIDATE); if (!def) return NULL; diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 06822fb3a0..4b6daf19a8 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3474,7 +3474,7 @@ networkCreateXML(virConnectPtr conn, virNetworkPtr net = NULL; virObjectEvent *event = NULL; - if (!(newDef = virNetworkDefParseString(xml, network_driver->xmlopt, 0))) + if (!(newDef = virNetworkDefParseString(xml, network_driver->xmlopt, false))) goto cleanup; if (virNetworkCreateXMLEnsureACL(conn, newDef) < 0) @@ -3529,7 +3529,8 @@ networkDefineXMLFlags(virConnectPtr conn, virCheckFlags(VIR_NETWORK_DEFINE_VALIDATE, NULL); - if (!(def = virNetworkDefParseString(xml, network_driver->xmlopt, flags))) + if (!(def = virNetworkDefParseString(xml, network_driver->xmlopt, + flags & VIR_NETWORK_DEFINE_VALIDATE))) goto cleanup; if (virNetworkDefineXMLFlagsEnsureACL(conn, def) < 0) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 207129a556..51d02e9fb6 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4778,7 +4778,7 @@ qemuProcessGetNetworkAddress(const char *netname, if (!xml) goto cleanup; - netdef = virNetworkDefParseString(xml, NULL, 0); + netdef = virNetworkDefParseString(xml, NULL, false); if (!netdef) goto cleanup; diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f19b7c520..33f611081c 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5581,7 +5581,7 @@ testNetworkCreateXML(virConnectPtr conn, const char *xml) virNetworkPtr net = NULL; virObjectEvent *event = NULL; - if ((newDef = virNetworkDefParseString(xml, NULL, 0)) == NULL) + if ((newDef = virNetworkDefParseString(xml, NULL, false)) == NULL) goto cleanup; if (!(obj = virNetworkObjAssignDef(privconn->networks, newDef, @@ -5620,7 +5620,8 @@ testNetworkDefineXMLFlags(virConnectPtr conn, virCheckFlags(VIR_NETWORK_DEFINE_VALIDATE, NULL); - if ((newDef = virNetworkDefParseString(xml, NULL, flags)) == NULL) + if (!(newDef = virNetworkDefParseString(xml, NULL, + flags & VIR_NETWORK_DEFINE_VALIDATE))) goto cleanup; if (!(obj = virNetworkObjAssignDef(privconn->networks, newDef, 0))) diff --git a/src/vbox/vbox_network.c b/src/vbox/vbox_network.c index c554b052c9..c0694d42d5 100644 --- a/src/vbox/vbox_network.c +++ b/src/vbox/vbox_network.c @@ -397,7 +397,8 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start, VBOX_IID_INITIALIZE(&vboxnetiid); - if (!(def = virNetworkDefParseString(xml, NULL, flags)) || + if (!(def = virNetworkDefParseString(xml, NULL, + flags & VIR_NETWORK_DEFINE_VALIDATE)) || (def->forward.type != VIR_NETWORK_FORWARD_NONE) || (def->nips == 0 || !def->ips)) goto cleanup; -- 2.31.1

2 1

[PATCH] qemuProcessQMPInit: Use long options for '-qmp' when probing qemu.
by Peter Krempa 10 Sep '21

10 Sep '21

'-qmp' in this case behaves the same as '-chardev' so it should have been converted the same way as others were in 43c9c0859f2d53321 since short options are deprecated. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 207129a556..df1f481433 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -9045,7 +9045,7 @@ qemuProcessQMPInit(qemuProcessQMP *proc) proc->monpath = g_strdup_printf("%s/%s", proc->uniqDir, "qmp.monitor"); - proc->monarg = g_strdup_printf("unix:%s,server,nowait", proc->monpath); + proc->monarg = g_strdup_printf("unix:%s,server=on,wait=off", proc->monpath); /* * Normally we'd use runDir for pid files, but because we're using -- 2.31.1

2 1

[libvirt PATCH 0/7] gitlab: convert to use the lcitool manifest feature
by Daniel P. Berrangé 10 Sep '21

10 Sep '21

This switches our CI rules to be largely auto-generated by the lcitool manifest command, so that they share a consistent design with all other projects and are simpler to modify in future. Daniel P. Berrangé (7): gitlab: move codestyle job to the sanity_checks stage gitlab: refresh containers / cirrus files with latest content gitlab: fold sanitizer jobs into regular ubuntu jobs gitlab: define a manifest file to express the CI config ci: re-generate containers/gitlab config from manifest ci: remove obsolete refresh documentation ci: remove obsolete logic for refreshing containers/cirrus .gitlab-ci.yml | 539 +--------------- ci/cirrus/freebsd-12.vars | 8 +- ci/cirrus/freebsd-13.vars | 8 +- ci/cirrus/freebsd-current.vars | 8 +- ci/cirrus/macos-11.vars | 4 +- ci/containers/README.rst | 36 -- ci/containers/centos-8.Dockerfile | 5 +- ci/containers/centos-stream-8.Dockerfile | 5 +- .../debian-10-cross-aarch64.Dockerfile | 8 +- .../debian-10-cross-armv6l.Dockerfile | 8 +- .../debian-10-cross-armv7l.Dockerfile | 8 +- ci/containers/debian-10-cross-i686.Dockerfile | 8 +- ci/containers/debian-10-cross-mips.Dockerfile | 8 +- .../debian-10-cross-mips64el.Dockerfile | 8 +- .../debian-10-cross-mipsel.Dockerfile | 8 +- .../debian-10-cross-ppc64le.Dockerfile | 8 +- .../debian-10-cross-s390x.Dockerfile | 8 +- ci/containers/debian-10.Dockerfile | 8 +- .../debian-sid-cross-aarch64.Dockerfile | 5 +- .../debian-sid-cross-armv6l.Dockerfile | 5 +- .../debian-sid-cross-armv7l.Dockerfile | 5 +- .../debian-sid-cross-i686.Dockerfile | 5 +- .../debian-sid-cross-mips64el.Dockerfile | 5 +- .../debian-sid-cross-mipsel.Dockerfile | 5 +- .../debian-sid-cross-ppc64le.Dockerfile | 5 +- .../debian-sid-cross-s390x.Dockerfile | 5 +- ci/containers/debian-sid.Dockerfile | 5 +- ci/containers/fedora-33.Dockerfile | 5 +- ci/containers/fedora-34.Dockerfile | 5 +- .../fedora-rawhide-cross-mingw32.Dockerfile | 4 +- .../fedora-rawhide-cross-mingw64.Dockerfile | 4 +- ci/containers/fedora-rawhide.Dockerfile | 5 +- ci/containers/opensuse-leap-152.Dockerfile | 5 +- ci/containers/opensuse-tumbleweed.Dockerfile | 5 +- ci/containers/ubuntu-1804.Dockerfile | 5 +- ci/containers/ubuntu-2004.Dockerfile | 5 +- ci/gitlab.yml | 602 ++++++++++++++++++ ci/helper | 121 +--- ci/manifest.yml | 153 +++++ ci/util.py | 32 +- 40 files changed, 871 insertions(+), 818 deletions(-) delete mode 100644 ci/containers/README.rst create mode 100644 ci/gitlab.yml create mode 100644 ci/manifest.yml -- 2.31.1

2 8

[PATCH] libvirt-domain.c: Fix typo in virDomainAttachDevice doc
by Michal Privoznik 10 Sep '21

10 Sep '21

In the documentation to virDomainAttachDevice() we refer to a non-existent virDomainUpdateDeviceFlag() function. The correct name is virDomainUpdateDeviceFlags(). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed as trivial. src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index a8a386e839..57baef6889 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8309,7 +8309,7 @@ virDomainGetMetadata(virDomainPtr domain, * * For compatibility, this method can also be used to change the media * in an existing CDROM/Floppy device, however, applications are - * recommended to use the virDomainUpdateDeviceFlag method instead. + * recommended to use the virDomainUpdateDeviceFlags method instead. * * Be aware that hotplug changes might not persist across a domain going * into S4 state (also known as hibernation) unless you also modify the -- 2.32.0

1 0

[PATCH] hw/misc: deprecate the 'sga' device
by Daniel P. Berrangé 10 Sep '21

10 Sep '21

This is obsolete since SeaBIOS 1.11.0 introduced native support for sending messages to the serial console. The new support can be activated using -machine graphics=off on x86 targets. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/about/deprecated.rst | 10 ++++++++++ hw/misc/sga.c | 2 ++ 2 files changed, 12 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 9ee355ec0b..cafca05826 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -280,6 +280,16 @@ full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. Note this also applies to ``-device virtio-blk-pci,scsi=on|off``, which is an alias. +``-device sga`` (since 6.2) +^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The ``sga`` device loads an option ROM for x86 targets which enables +SeaBIOS to send messages to the serial console. SeaBIOS 1.11.0 onwards +contains native support for this feature and thus use of the option +ROM approach is obsolete. The native SeaBIOS support can be activated +by using ``-machine graphics=off``. + + Block device options '''''''''''''''''''' diff --git a/hw/misc/sga.c b/hw/misc/sga.c index 4dbe6d78f9..1d04672b01 100644 --- a/hw/misc/sga.c +++ b/hw/misc/sga.c @@ -30,6 +30,7 @@ #include "hw/loader.h" #include "qemu/module.h" #include "qom/object.h" +#include "qemu/error-report.h" #define SGABIOS_FILENAME "sgabios.bin" @@ -42,6 +43,7 @@ struct ISASGAState { static void sga_realizefn(DeviceState *dev, Error **errp) { + warn_report("-device sga is deprecated, use -machine graphics=off"); rom_add_vga(SGABIOS_FILENAME); } -- 2.31.1

2 1

[PATCH 0/9] Fix image labels lost after migration with shared fs
by Peng Liang 10 Sep '21

10 Sep '21

When migrating using shared fs, the dst host will remember the image labels again before launching the VM and the src host will remove the image labels after migration. It leads to that the image labels lost after migration. Patch 7-9 are the real fix patches. Peng Liang (9): security: add virSecurityUpdateTimestampIfexists security: add virSecurityManagerUpdateImageLabel security: implement domainUpdateSecurityImageLabel for stack security: implement domainUpdateSecurityImageLabel for DAC qemu: add qemuSecurityUpdateImageLabel security: rename virSecurityDACSetImageLabelInternal to virSecurityDACSetImageLabelSingle migration: don't remember image labels when migrating with shared fs migration: don't remove image labels after migration migration: update image labels in dst after migration src/libvirt_private.syms | 1 + src/qemu/qemu_migration.c | 12 +++++++ src/qemu/qemu_process.c | 5 ++- src/qemu/qemu_security.c | 10 ++++++ src/qemu/qemu_security.h | 5 +++ src/security/security_dac.c | 58 +++++++++++++++++++++++++-------- src/security/security_driver.h | 5 +++ src/security/security_manager.c | 29 +++++++++++++++++ src/security/security_manager.h | 5 +++ src/security/security_stack.c | 20 ++++++++++++ src/security/security_util.c | 32 ++++++++++++++++++ src/security/security_util.h | 4 +++ 12 files changed, 172 insertions(+), 14 deletions(-) -- 2.31.1

2 18

[libvirt PATCH] docs: virtiofs: remove extra slash
by Ján Tomko 09 Sep '21

09 Sep '21

Reported-by: Richard W.M. Jones <rjones(a)redhat.com> Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. docs/kbase/virtiofs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index b89de0c57a..9123fc2316 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -81,7 +81,7 @@ control and need to be set by the application running virtiofsd. :: - <filesystem type='mount'/> + <filesystem type='mount'> <driver type='virtiofs' queue='1024'/> <source socket='/var/virtiofsd.sock'/> <target dir='tag'/> -- 2.31.1

1 0

[libvirt PATCH] docs: virtiofs: provide more context for elements
by Ján Tomko 09 Sep '21

09 Sep '21

Suggested-by: Richard W.M. Jones <rjones(a)redhat.com> Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. docs/kbase/virtiofs.rst | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index d728a1358c..b89de0c57a 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -62,11 +62,14 @@ More optional elements can be specified :: - <driver type='virtiofs' queue='1024'/> - <binary path='/usr/libexec/virtiofsd' xattr='on'> - <cache mode='always'/> - <lock posix='on' flock='on'/> - </binary> + <filesystem type='mount' accessmode='passthrough'> + <driver type='virtiofs' queue='1024'/> + ... + <binary path='/usr/libexec/virtiofsd' xattr='on'> + <cache mode='always'/> + <lock posix='on' flock='on'/> + </binary> + </filesystem> Externally-launched virtiofsd ============================= -- 2.31.1

1 0

[libvirt PATCH 00/24] tests: use g_auto more (glib chronicles)
by Ján Tomko 09 Sep '21

09 Sep '21

Ján Tomko (24): tests: virnetdaemontest: split variable declarations conf: add cleanup func for virNetworkXMLOption conf: add cleanup func for virMacMap tests: use g_autoptr instead of virObjectUnref tests: qemu: use g_autofree tests: network: use g_autofree tests: libxl: use g_autofree tests: nwfilter: use g_autofree tests: vmx: use g_autofree tests: vir: use g_autofree tests: use g_autofree tests: use g_autoptr instead of virJSONValueFree tests: use g_auto for virCPUDataFree tests: use g_auto instead of VIR_FORCE_FCLOSE tests: use VIR_AUTOCLOSE tests: use g_auto instead of vshTableFree tests: use g_auto instead of virDomainFree tests: qemu: remove pointless labels tests: vmx: remove pointless labels tests: libxl: remove pointless labels tests: nwfilter: remove pointless labels tests: vshtabletest: remove pointless labels tests: vir: remove pointless labels tests: remove pointless labels src/conf/network_conf.h | 1 + src/util/virmacmap.h | 2 + tests/cputest.c | 51 ++++------- tests/domaincapstest.c | 60 +++++-------- tests/domainconftest.c | 18 ++-- tests/eventtest.c | 3 +- tests/fchosttest.c | 70 +++++---------- tests/fdstreamtest.c | 24 ++--- tests/genericxml2xmltest.c | 6 +- tests/interfacexml2xmltest.c | 9 +- tests/libxlxml2domconfigtest.c | 18 ++-- tests/lxcconf2xmltest.c | 37 +++----- tests/lxcxml2xmltest.c | 6 +- tests/metadatatest.c | 37 +++----- tests/networkxml2conftest.c | 19 ++-- tests/networkxml2firewalltest.c | 9 +- tests/networkxml2xmltest.c | 13 +-- tests/networkxml2xmlupdatetest.c | 16 ++-- tests/nodedevxml2xmltest.c | 9 +- tests/nsstest.c | 4 +- tests/nwfilterebiptablestest.c | 84 ++++++----------- tests/nwfilterxml2firewalltest.c | 12 +-- tests/nwfilterxml2xmltest.c | 10 +-- tests/openvzutilstest.c | 23 ++--- tests/qemuagenttest.c | 31 ++----- tests/qemucapsprobemock.c | 12 +-- tests/qemucommandutiltest.c | 15 ++-- tests/qemumonitorjsontest.c | 116 +++++++++--------------- tests/qemumonitortestutils.c | 45 +++------- tests/qemuxml2argvtest.c | 24 ++--- tests/scsihosttest.c | 37 +++----- tests/secretxml2xmltest.c | 7 +- tests/securityselinuxlabeltest.c | 27 ++---- tests/sockettest.c | 4 +- tests/testutils.c | 8 +- tests/testutilslxc.c | 4 +- tests/vboxsnapshotxmltest.c | 12 +-- tests/vircapstest.c | 20 ++--- tests/vircgrouptest.c | 3 +- tests/virconftest.c | 44 ++++----- tests/vircryptotest.c | 35 +++----- tests/virfilecachetest.c | 3 +- tests/virfilemock.c | 3 +- tests/virfiletest.c | 61 +++++-------- tests/virhostcputest.c | 42 +++------ tests/viriscsitest.c | 18 ++-- tests/virkmodtest.c | 39 +++----- tests/virmacmaptest.c | 49 ++++------ tests/virnetdaemontest.c | 13 ++- tests/virnetsockettest.c | 6 +- tests/virnettlshelpers.c | 4 +- tests/virnetworkportxml2xmltest.c | 23 ++--- tests/virnumamock.c | 14 +-- tests/virnwfilterbindingxml2xmltest.c | 7 +- tests/virpcimock.c | 4 +- tests/virpcitest.c | 56 +++++------- tests/virresctrltest.c | 34 +++---- tests/virrotatingfiletest.c | 4 +- tests/virscsitest.c | 31 ++----- tests/virstringtest.c | 44 +++------ tests/virsystemdtest.c | 29 ++---- tests/virtestmock.c | 10 +-- tests/viruritest.c | 3 +- tests/virusbmock.c | 7 +- tests/virusbtest.c | 6 +- tests/vmwarevertest.c | 20 ++--- tests/vmx2xmltest.c | 35 +++----- tests/vshtabletest.c | 125 ++++++++++---------------- tests/xlconfigtest.c | 85 +++++++----------- tests/xmconfigtest.c | 62 +++++-------- tests/xml2vmxtest.c | 32 +++---- 71 files changed, 628 insertions(+), 1226 deletions(-) -- 2.31.1

2 32

[libvirt PATCH v3 0/7] Enable autostarting mediated devices
by Jonathon Jongsma 09 Sep '21

09 Sep '21

This first version of this series was reviewed quite a while ago and all patches were ACKed except the second one. I posted a second series with changes noted below but it was never ACKed and I dropped the ball for a little while. Subsequently there were questions about whether physical devices (e.g. pci, usb, etc) should return 'true' or 'false' for the GetAutostart()/IsPersistent() calls. I had initially marked them as persistent=true and autostart=true because they superficially act a bit like persistently-defined devices. But Boris convinced me that this is not a very accurate classification since if the physical device is unplugged, there will be no record of it left behind. So I've switched all non-mdev devices to be persistent=false and autostart=false. This is also imperfect, but it seems relatively harmless. Comments welcome. A reminder of what is included in this series: - new API consistent with existing libvirt objects: - virNodeDeviceGetAutostart() - virNodeDeviceSetAutostart() - virNodeDeviceIsPersistent() - virNodeDeviceIsActive - new virsh commands - nodedev-info - nodedev-autostart Changes in version 2: - Parse the autostart property from mdevctl output. Changes in version 3: - switch physical devices to autostart=false, persistent=false - rebase to upstream - update version numbers for new API, etc - fix accidental copy-paste error in virsh command descriptions Jonathon Jongsma (7): api: add virNodeDevice(Get|Set)Autostart() nodedev: implement virNodeDevice(Get|Set)Autostart() nodedev: Add tests for mdevctl autostart command virsh: add nodedev-autostart api: add virNodeDeviceIsPersistent()/IsActive() nodedev: Implement virNodeDeviceIsPersistent()/IsActive() virsh: add nodedev-info docs/manpages/virsh.rst | 27 +++ include/libvirt/libvirt-nodedev.h | 10 + src/conf/node_device_conf.h | 1 + src/conf/virnodedeviceobj.c | 16 ++ src/conf/virnodedeviceobj.h | 6 + src/driver-nodedev.h | 18 ++ src/libvirt-nodedev.c | 141 +++++++++++++ src/libvirt_private.syms | 2 + src/libvirt_public.syms | 4 + src/node_device/node_device_driver.c | 189 +++++++++++++++++- src/node_device/node_device_driver.h | 19 ++ src/node_device/node_device_udev.c | 22 +- src/remote/remote_driver.c | 6 +- src/remote/remote_protocol.x | 60 +++++- src/remote_protocol-structs | 26 +++ .../nodedevmdevctldata/mdevctl-autostart.argv | 8 + tests/nodedevmdevctltest.c | 55 +++++ tools/virsh-nodedev.c | 139 +++++++++++++ 18 files changed, 740 insertions(+), 9 deletions(-) create mode 100644 tests/nodedevmdevctldata/mdevctl-autostart.argv -- 2.31.1

2 9