- Devel - libvirt List Archives

[PATCH v2 0/2] virsh: domain: rework cmdMigrateSetMaxDowntime()
by Kristina Hanicova 25 Sep '21

25 Sep '21

This patch is partially v2 of: https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html Diff to v1: * split from previous big patch * split the fixing part and the refactoring part of the function into different patches Kristina Hanicova (2): virsh: domain: fix mistake in cmdMigrateSetMaxDowntime() virsh: domain: remove unnecessary variable and label in cmdMigrateSetMaxDowntime() tools/virsh-domain.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) -- 2.31.1

2 6

[PATCH v2 0/7] virsh: domain: small refactoring
by Kristina Hanicova 25 Sep '21

25 Sep '21

This is partially v2 of: https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html Diff to v1: * split changes into smaller patches Kristina Hanicova (7): virsh: domain: use early return in virshDomainDefine() virsh: domain: remove nested 'if' in cmdAttachDisk() virsh: domain: remove 'ret' variable and use direct return when possible virsh: domain: remove 'ret' variable, use early return when possible virsh: domain: use early return when possible virsh: domain: remove 'ret' variable and use 'count' instead virsh: domain: remove else branch tools/virsh-domain.c | 232 +++++++++++++++++-------------------------- 1 file changed, 92 insertions(+), 140 deletions(-) -- 2.31.1

2 8

[PATCH v3 0/3] remove sysconfig files
by Olaf Hering 24 Sep '21

24 Sep '21

rebased to 919f25d36ef0ea41c50bdb5afa0b83187ffb3c87 Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst | 10 +++ docs/daemons.rst | 20 +++++ docs/remote.html.in | 2 +- libvirt.spec.in | 100 ++++++++++++++++-------- src/ch/meson.build | 5 -- src/ch/virtchd.service.in | 1 + src/ch/virtchd.sysconf | 3 - src/interface/meson.build | 5 -- src/interface/virtinterfaced.service.in | 1 + src/interface/virtinterfaced.sysconf | 3 - src/libxl/meson.build | 5 -- src/libxl/virtxend.service.in | 1 + src/libxl/virtxend.sysconf | 3 - src/locking/meson.build | 5 -- src/locking/virtlockd.service.in | 1 + src/locking/virtlockd.sysconf | 3 - src/logging/meson.build | 5 -- src/logging/virtlogd.sysconf | 3 - src/lxc/meson.build | 5 -- src/lxc/virtlxcd.service.in | 1 + src/lxc/virtlxcd.sysconf | 3 - src/meson.build | 16 ---- src/network/meson.build | 5 -- src/network/virtnetworkd.service.in | 1 + src/network/virtnetworkd.sysconf | 3 - src/node_device/meson.build | 5 -- src/node_device/virtnodedevd.service.in | 1 + src/node_device/virtnodedevd.sysconf | 3 - src/nwfilter/meson.build | 5 -- src/nwfilter/virtnwfilterd.service.in | 1 + src/nwfilter/virtnwfilterd.sysconf | 3 - src/qemu/meson.build | 5 -- src/qemu/virtqemud.service.in | 7 ++ src/qemu/virtqemud.sysconf | 12 --- src/remote/libvirtd.service.in | 7 ++ src/remote/libvirtd.sysconf | 21 ----- src/remote/meson.build | 10 --- src/remote/virtproxyd.service.in | 1 + src/remote/virtproxyd.sysconf | 3 - src/secret/meson.build | 5 -- src/secret/virtsecretd.service.in | 1 + src/secret/virtsecretd.sysconf | 3 - src/storage/meson.build | 5 -- src/storage/virtstoraged.service.in | 1 + src/storage/virtstoraged.sysconf | 3 - src/vbox/meson.build | 5 -- src/vbox/virtvboxd.service.in | 1 + src/vbox/virtvboxd.sysconf | 3 - src/vz/meson.build | 5 -- src/vz/virtvzd.service.in | 1 + src/vz/virtvzd.sysconf | 3 - tools/libvirt-guests.sh.in | 40 ++++++++++ tools/libvirt-guests.sysconf | 50 ------------ tools/meson.build | 6 -- 54 files changed, 166 insertions(+), 260 deletions(-) delete mode 100644 src/ch/virtchd.sysconf delete mode 100644 src/interface/virtinterfaced.sysconf delete mode 100644 src/libxl/virtxend.sysconf delete mode 100644 src/locking/virtlockd.sysconf delete mode 100644 src/logging/virtlogd.sysconf delete mode 100644 src/lxc/virtlxcd.sysconf delete mode 100644 src/network/virtnetworkd.sysconf delete mode 100644 src/node_device/virtnodedevd.sysconf delete mode 100644 src/nwfilter/virtnwfilterd.sysconf delete mode 100644 src/qemu/virtqemud.sysconf delete mode 100644 src/remote/libvirtd.sysconf delete mode 100644 src/remote/virtproxyd.sysconf delete mode 100644 src/secret/virtsecretd.sysconf delete mode 100644 src/storage/virtstoraged.sysconf delete mode 100644 src/vbox/virtvboxd.sysconf delete mode 100644 src/vz/virtvzd.sysconf delete mode 100644 tools/libvirt-guests.sysconf

2 6

[PATCH] vsh: Don't check for OOM in vshGetTypedParamValue()
by Michal Privoznik 24 Sep '21

24 Sep '21

Both function description and function itself mention check for OOM which can't happen really. There was a bug in glib where g_strdup_*() might have not aborted on OOM, but we have our own implementation when dealing with broken glib (see vir_g_strdup_printf()). Therefore, checking for OOM is redundant and can never be true. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/vsh.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index e81369f224..189c452f73 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -1806,51 +1806,44 @@ vshCommandOptTimeoutToMs(vshControl *ctl, const vshCmd *cmd, int *timeout) * --------------- */ -/* Return a non-NULL string representation of a typed parameter; exit - * if we are out of memory. */ +/* Return a non-NULL string representation of a typed parameter; exit on + * unknown type. */ char * vshGetTypedParamValue(vshControl *ctl, virTypedParameterPtr item) { - char *str = NULL; - switch (item->type) { case VIR_TYPED_PARAM_INT: - str = g_strdup_printf("%d", item->value.i); + return g_strdup_printf("%d", item->value.i); break; case VIR_TYPED_PARAM_UINT: - str = g_strdup_printf("%u", item->value.ui); + return g_strdup_printf("%u", item->value.ui); break; case VIR_TYPED_PARAM_LLONG: - str = g_strdup_printf("%lld", item->value.l); + return g_strdup_printf("%lld", item->value.l); break; case VIR_TYPED_PARAM_ULLONG: - str = g_strdup_printf("%llu", item->value.ul); + return g_strdup_printf("%llu", item->value.ul); break; case VIR_TYPED_PARAM_DOUBLE: - str = g_strdup_printf("%f", item->value.d); + return g_strdup_printf("%f", item->value.d); break; case VIR_TYPED_PARAM_BOOLEAN: - str = g_strdup(item->value.b ? _("yes") : _("no")); + return g_strdup(item->value.b ? _("yes") : _("no")); break; case VIR_TYPED_PARAM_STRING: - str = g_strdup(item->value.s); + return g_strdup(item->value.s); break; default: vshError(ctl, _("unimplemented parameter type %d"), item->type); - } - - if (!str) { - vshError(ctl, "%s", _("Out of memory")); exit(EXIT_FAILURE); } - return str; } void -- 2.32.0

2 1

[PATCH v2 0/6] virsh: refactor some bigger functions
by Kristina Hanicova 24 Sep '21

24 Sep '21

This is v2 of patch: https://listman.redhat.com/archives/libvir-list/2021-September/msg00730.html Diff to v1: * split the previous patch into more smaller ones to make the code review easier * small code quality alternations I did not notice were possible before This series refactors a few bigger functions mainly trying to remove too deep indentation and make them more readable and more consistent with the rest of the files. Kristina Hanicova (6): virsh: domain: refactor cmdSchedinfo() virsh: domain: refactor virshCPUCountCollect() virsh: domain: refactor cmdLxcEnterNamespace() virsh: host: refactor cmdFreecell() virsh: host: refactor cmdNodeCpuStats() virsh: volume: refactor cmdVolInfo() tools/virsh-domain.c | 210 ++++++++++++++++++++----------------------- tools/virsh-host.c | 139 ++++++++++++++-------------- tools/virsh-volume.c | 52 +++++------ 3 files changed, 189 insertions(+), 212 deletions(-) -- 2.31.1

3 9

[libvirt PATCH] meson: Increase stack size limit for sanitizer builds
by Tim Wiederhake 24 Sep '21

24 Sep '21

When building with "CC=clang", "-Db_sanitize=address,undefined", and "-Dbuildtype=debug", the following error occurs: ../src/conf/nwfilter_conf.c:2190:1: error: stack frame size of 10616 bytes in function 'virNWFilterRuleDefFixup' [-Werror,-Wframe-larger-than=] virNWFilterRuleDefFixup(virNWFilterRuleDef *rule) ^ 1 error generated. Enforcing stack frame only makes sense on normal builds when stack usage is deterministic. Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 488490181f..be5a99a069 100644 --- a/meson.build +++ b/meson.build @@ -225,7 +225,7 @@ alloc_max = run_command( ) # sanitizer instrumentation may enlarge stack frames -stack_frame_size = get_option('b_sanitize') == 'none' ? 4096 : 8192 +stack_frame_size = get_option('b_sanitize') == 'none' ? 4096 : 32768 # array_bounds=2 check triggers false positive on some GCC # versions when using sanitizers. Seen on Fedora 34 with -- 2.31.1

2 2

[PATCH v2 0/4] virsh: refactor unnecessary variables and else branch
by Kristina Hanicova 24 Sep '21

24 Sep '21

This is partially v2 of: https://listman.redhat.com/archives/libvir-list/2021-September/msg00731.html Diff to v1: * split changes into smaller patches Kristina Hanicova (4): virsh: remove variable 'ret' and use early return if possible virsh: remove variable 'ret' in cmdVersion() virsh: remove variable 'ret' and 'inactive' virsh: util: remove 'else' branch after return tools/virsh-host.c | 25 +++++----------- tools/virsh-interface.c | 65 ++++++++++++++++++----------------------- tools/virsh-network.c | 47 +++++++++++++---------------- tools/virsh-nodedev.c | 32 ++++++++------------ tools/virsh-nwfilter.c | 15 +++++----- tools/virsh-util.c | 3 +- 6 files changed, 76 insertions(+), 111 deletions(-) -- 2.31.1

3 7

[PATCH 00/14] qemu: Some more 'query-command-line-options' originated cleanups
by Peter Krempa 23 Sep '21

23 Sep '21

There are a few more capabilities we can easily assume and stop trying to probe them and some more legacy code to delete. This time it's mainly about VNC including a modernization of qemuxml2argvtest cases for it. Peter Krempa (14): qemuxml2argvtest: Use real caps in "graphics-vnc-tls" case qemu: Always assume presence of QEMU_CAPS_OBJECT_TLS_CREDS_X509 qemu: capabilities: Retire QEMU_CAPS_OBJECT_TLS_CREDS_X509 qemuBuildTLSx509BackendProps: Remove unused 'qemuCaps' qemu: command: Simplify 'vnc' commandline generator qemu: command: Always assume QEMU_CAPS_VNC_OPTS qemu: capabilities: Retire QEMU_CAPS_VNC_OPTS qemuxml2argvtest: Replace vnc unix socket tests with pinned versions qemu: command: Always QEMU_CAPS_VNC_MULTI_SERVERS qemu: capabilities: Retire QEMU_CAPS_VNC_MULTI_SERVERS qemuxml2argvtest: Add DO_TEST_CAPS_LATEST for the vnc unix socket tests qemuxml2argvtest: Modernize the rest of 'graphics-vnc' tests qemu: validate: Always assume QEMU_CAPS_SPICE_FILE_XFER_DISABLE qemu: capabilities: Retire QEMU_CAPS_SPICE_FILE_XFER_DISABLE src/qemu/qemu_backup.c | 5 +- src/qemu/qemu_capabilities.c | 12 +- src/qemu/qemu_capabilities.h | 8 +- src/qemu/qemu_command.c | 108 ++++++------------ src/qemu/qemu_command.h | 10 +- src/qemu/qemu_domain.c | 4 - src/qemu/qemu_driver.c | 15 +-- src/qemu/qemu_hotplug.c | 13 +-- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_migration_params.c | 2 +- src/qemu/qemu_snapshot.c | 3 +- src/qemu/qemu_validate.c | 20 ---- .../caps_2.11.0.s390x.xml | 3 - .../caps_2.11.0.x86_64.xml | 4 - .../caps_2.12.0.aarch64.xml | 3 - .../caps_2.12.0.ppc64.xml | 3 - .../caps_2.12.0.s390x.xml | 3 - .../caps_2.12.0.x86_64.xml | 4 - .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 3 - .../caps_3.0.0.riscv32.xml | 3 - .../caps_3.0.0.riscv64.xml | 3 - .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 3 - .../caps_3.0.0.x86_64.xml | 4 - .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 3 - .../caps_3.1.0.x86_64.xml | 4 - .../caps_4.0.0.aarch64.xml | 3 - .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 3 - .../caps_4.0.0.riscv32.xml | 4 - .../caps_4.0.0.riscv64.xml | 4 - .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 3 - .../caps_4.0.0.x86_64.xml | 4 - .../caps_4.1.0.x86_64.xml | 4 - .../caps_4.2.0.aarch64.xml | 3 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 3 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 3 - .../caps_4.2.0.x86_64.xml | 4 - .../caps_5.0.0.aarch64.xml | 3 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 3 - .../caps_5.0.0.riscv64.xml | 4 - .../caps_5.0.0.x86_64.xml | 4 - .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 4 - .../caps_5.1.0.x86_64.xml | 4 - .../caps_5.2.0.aarch64.xml | 3 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 3 - .../caps_5.2.0.riscv64.xml | 4 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 3 - .../caps_5.2.0.x86_64.xml | 4 - .../caps_6.0.0.aarch64.xml | 3 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 3 - .../caps_6.0.0.x86_64.xml | 4 - .../caps_6.1.0.x86_64.xml | 4 - tests/qemuhotplugtest.c | 1 - ...cs-vnc-auto-socket-cfg.x86_64-2.11.0.args} | 7 +- ...ics-vnc-auto-socket-cfg.x86_64-latest.args | 36 ++++++ ...raphics-vnc-auto-socket.x86_64-2.11.0.args | 31 +++++ ...raphics-vnc-auto-socket.x86_64-latest.args | 33 ++++++ ...phics-vnc-egl-headless.x86_64-2.11.0.args} | 5 +- ...aphics-vnc-egl-headless.x86_64-latest.args | 37 ++++++ ...ics-vnc-no-listen-attr.x86_64-2.11.0.args} | 5 +- ...hics-vnc-no-listen-attr.x86_64-latest.args | 36 ++++++ ...s => graphics-vnc-none.x86_64-2.11.0.args} | 5 +- .../graphics-vnc-none.x86_64-latest.args | 33 ++++++ ...=> graphics-vnc-policy.x86_64-2.11.0.args} | 5 +- .../graphics-vnc-policy.x86_64-latest.args | 36 ++++++ ...emove-generated-socket.x86_64-2.11.0.args} | 5 +- ...remove-generated-socket.x86_64-latest.args | 36 ++++++ ...s => graphics-vnc-sasl.x86_64-2.11.0.args} | 7 +- .../graphics-vnc-sasl.x86_64-latest.args | 37 ++++++ ...vnc-socket-new-cmdline.x86_64-2.11.0.args} | 5 +- ...-vnc-socket-new-cmdline.x86_64-latest.args | 33 ++++++ .../qemuxml2argvdata/graphics-vnc-socket.args | 30 ----- ...=> graphics-vnc-socket.x86_64-2.11.0.args} | 7 +- .../graphics-vnc-socket.x86_64-latest.args | 33 ++++++ ...gs => graphics-vnc-tls.x86_64-2.11.0.args} | 8 +- ...graphics-vnc-websocket.x86_64-2.11.0.args} | 5 +- .../graphics-vnc-websocket.x86_64-latest.args | 33 ++++++ ...r.args => graphics-vnc.x86_64-2.11.0.args} | 5 +- .../graphics-vnc.x86_64-latest.args | 36 ++++++ tests/qemuxml2argvdata/name-escape.args | 2 +- tests/qemuxml2argvtest.c | 71 ++++++------ tests/qemuxml2xmltest.c | 4 +- 81 files changed, 586 insertions(+), 378 deletions(-) rename tests/qemuxml2argvdata/{graphics-vnc-auto-socket-cfg.args => graphics-vnc-auto-socket-cfg.x86_64-2.11.0.args} (79%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-auto-socket-cfg.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/graphics-vnc-auto-socket.x86_64-2.11.0.args create mode 100644 tests/qemuxml2argvdata/graphics-vnc-auto-socket.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-egl-headless.args => graphics-vnc-egl-headless.x86_64-2.11.0.args} (84%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-egl-headless.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc.args => graphics-vnc-no-listen-attr.x86_64-2.11.0.args} (83%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-no-listen-attr.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-none.args => graphics-vnc-none.x86_64-2.11.0.args} (81%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-none.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-policy.args => graphics-vnc-policy.x86_64-2.11.0.args} (84%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-policy.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-remove-generated-socket.args => graphics-vnc-remove-generated-socket.x86_64-2.11.0.args} (83%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-remove-generated-socket.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-sasl.args => graphics-vnc-sasl.x86_64-2.11.0.args} (82%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-sasl.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-socket-new-cmdline.args => graphics-vnc-socket-new-cmdline.x86_64-2.11.0.args} (81%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-socket-new-cmdline.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-vnc-socket.args rename tests/qemuxml2argvdata/{graphics-vnc-auto-socket.args => graphics-vnc-socket.x86_64-2.11.0.args} (78%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-socket.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-tls.args => graphics-vnc-tls.x86_64-2.11.0.args} (71%) rename tests/qemuxml2argvdata/{graphics-vnc-websocket.args => graphics-vnc-websocket.x86_64-2.11.0.args} (81%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc-websocket.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-vnc-no-listen-attr.args => graphics-vnc.x86_64-2.11.0.args} (83%) create mode 100644 tests/qemuxml2argvdata/graphics-vnc.x86_64-latest.args -- 2.31.1

2 18

[PATCH 0/5] virsh: small refactoring
by Kristina Hanicova 23 Sep '21

23 Sep '21

This series targets some alterations to make the code more readable and consistent. Kristina Hanicova (5): virsh: checkpoint & domain-monitor: small refactoring virsh: domain: refactoring of small functions virsh: domain: change the way functions return bool value virsh: domain, host & volume: refactor bigger functions virsh: refactor functions to not use 'ret' variable tools/virsh-checkpoint.c | 19 +- tools/virsh-domain-monitor.c | 314 +++++++++---------- tools/virsh-domain.c | 567 ++++++++++++++--------------------- tools/virsh-host.c | 166 +++++----- tools/virsh-interface.c | 65 ++-- tools/virsh-network.c | 47 ++- tools/virsh-nodedev.c | 32 +- tools/virsh-nwfilter.c | 15 +- tools/virsh-util.c | 3 +- tools/virsh-volume.c | 56 ++-- 10 files changed, 546 insertions(+), 738 deletions(-) -- 2.31.1

3 10

[PATCH RFC 0/8] blockdev-replace
by Vladimir Sementsov-Ogievskiy 23 Sep '21

23 Sep '21

Hi all! As a continuation of "Qemu block filter insertion/removal API" discussion, here is my proposal of blockdev-replace. The realization allows: - replace children of different parents: BDS, block devices, block exports - automatically replace all parents of specific BDS, excluding creating loops (like bdrv_replace_node()) - do several replacements in one transaction It's an untested draft, so you may go to patch 8, to look at QAPI addition. Vladimir Sementsov-Ogievskiy (8): block-backend: blk_root(): drop const specifier on return type block: add BlockParentClass class block: realize BlockParentClass for BlockDriverState block/export: realize BlockParentClass functionality qdev: improve find_device_state() to distinguish simple not found case qdev: realize BlockParentClass block: improve bdrv_replace_node_noperm() qapi: add blockdev-replace command qapi/block-core.json | 78 ++++++++++++++++ include/block/block-parent.h | 32 +++++++ include/sysemu/block-backend.h | 2 +- block.c | 158 ++++++++++++++++++++++++++++++++- block/block-backend.c | 2 +- block/block-parent.c | 66 ++++++++++++++ block/export/export.c | 44 +++++++++ softmmu/qdev-monitor.c | 90 +++++++++++++++---- block/meson.build | 1 + 9 files changed, 453 insertions(+), 20 deletions(-) create mode 100644 include/block/block-parent.h create mode 100644 block/block-parent.c -- 2.29.2

2 20