- Devel - libvirt List Archives

[Libvir] [PATCH] cleanup of virDeviceMode
by Daniel Veillard 18 Jul '07

18 Jul '07

Since this was raised yesterday about the purity of the libvirt API w.r.t. Xen specifics, we don't actually use the virDeviceMode nor have any possible use for them at the API level since basically this kind of informations is always rovided as part of an XML and never as an int/enum. So I propose to just remove them from the headers and API, I don't see how an application could use the enum but maybe I missed one, in which case please tell me :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 2

[Libvir] [PATCH 0/2] virDomainMigrate (for discussion only!)
by Richard W.M. Jones 17 Jul '07

17 Jul '07

This is a patch which adds virDomainMigrate. It is incomplete (only supports Xen, no remote support, no qemu support), but I hope you'll look at the proposed interface and discuss the parameters. More in the following two emails. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

6 40

[Libvir] Initial OpenVZ Support Patches
by Shuveb Hussain 17 Jul '07

17 Jul '07

Hi, Here are the OpenVZ support patches. The .c and .h files go into src/ This is being released in the spirit of releasing early. Only the basic stuff is done and development is continuing. What works: * Getting number of active/inactive domains * Listing active/inactive domains * Creating a domain that has been already defined (using OpenVZ tools) * Shutdown, start, reboot * configure.in has a new switch --with-openvz(on by default), use --without-openvz to switch it off. After I get feedback, I will work on it and add other features later on. There is no need for any OpenVZ tools code. Just the OpenVZ kernel and tools need to be installed. This code depends on the OpenVZ tool binaries. Differences from QEMU/Xen: * ID and name are same * Not possible to create temporary domains and do away with them. Creating a domain will involve untarring a template cache and bringing it up. * No readonly access. OpenVZ tools need root access. There are other design issues to be discussed. These issues spring from the fact that OpenVZ is very different from Xen/QEMU. I will discuss these issues in further mails. Here is a sample session transcript: shuveb@debian-openvz:~/libvirt$ sudo src/virsh -c openvz:///system Welcome to lt-virsh, the virtualization interactive terminal. Type: 'help' for help with commands 'quit' to quit virsh # list Id Name State ---------------------------------- 101 101 running 102 102 running 103 103 running virsh # shutdown 101 Domain 101 is being shutdown virsh # list Id Name State ---------------------------------- 102 102 running 103 103 running virsh # list --all Id Name State ---------------------------------- 102 102 running 103 103 running - 101 shut off virsh # start 101 Domain 101 started virsh # list Id Name State ---------------------------------- 101 101 running 102 102 running 103 103 running virsh # Thanks and Regards, -- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

3 5

[Libvir] PATCH: Specify BIOS clock offset for HVM
by Daniel P. Berrange 17 Jul '07

17 Jul '07

The attached patch introduces a new XML element for specifying information about the guest (BIOS) clock. For Xen HVM, and QEMU / KVM guests this is used to specifyc whether the guest clock should be in UTC, or localtime. The latter is useful for Windows which likes the BIOS to be localtime, while the former is useful for all other operating systems. The former is of course the default - so no change in existing semantics. The <clock> element currently takes a single attribute 'offset'. This is either 'utc' or 'localtime', but if we port to VMWare, it will also allow an arbitrary numeric offset as well as these special constants. <clock offset='utc'/> Or <clock offset='localtime'/> It may later also be desirable to add a 'sync=[yes|no]' attribute to specify whether the HV tries to keep the clock in sync with the HV while it is running. VMWare has this concept, and so does Xen paravirt - though Xen paravirt sets it via /proc/sys/xen/independant_wallclock inside the guest and AFAICT doesn't (yet) expose it to the guest config in Dom0. Anyway, my patch implements use of utc/localtime offsets for Xen, and QEMU drivers. I've tested to verify that -localtime gets passed to the QEMU process as appropriate. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 3

[Libvir] Regarding Libvirt & VirtManager
by Paulev 16 Jul '07

16 Jul '07

Hi All, I'm curious to know if LibVirt & VirtManager is being developed only by RedHat employees only. If not, what is the process for developers who wish to contribute to these projects. Also, I'd like to know how and by whom decisions are made for new features to be included in these projects. Thanks, Evan

2 1

[Libvir] OCaml binding 0.3.0.0 released
by Richard W.M. Jones 13 Jul '07

13 Jul '07

http://et.redhat.com/~rjones/ocaml-libvirt/ Adds: * virConnectGetHostname (as Libvirt.Connect.get_hostname) * virConnectGetURI (as Libvirt.Connect.get_uri) and full support for virterror, including all the internal fields. See: http://et.redhat.com/~rjones/ocaml-libvirt/html/Libvirt.Virterror.html Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 1

[Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface
by Masayuki Sunou 13 Jul '07

13 Jul '07

Hi Even if specified MAC address is invalid, network interface is attached to the guest. And attached network interface cannot communicate. This patch checks the format of MAC address, and virsh become error when it is invalid. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: include/libvirt/virterror.h =================================================================== RCS file: /data/cvs/libvirt/include/libvirt/virterror.h,v retrieving revision 1.26 diff -u -p -r1.26 virterror.h --- include/libvirt/virterror.h 6 Jul 2007 14:56:15 -0000 1.26 +++ include/libvirt/virterror.h 12 Jul 2007 02:00:54 -0000 @@ -127,6 +127,7 @@ typedef enum { VIR_WAR_NO_NETWORK, /* failed to start network */ VIR_ERR_NO_DOMAIN, /* domain not found or unexpectedly disappeared */ VIR_ERR_NO_NETWORK, /* network not found */ + VIR_ERR_INVALID_MAC, /* invalid MAC adress */ } virErrorNumber; /** Index: src/virterror.c =================================================================== RCS file: /data/cvs/libvirt/src/virterror.c,v retrieving revision 1.28 diff -u -p -r1.28 virterror.c --- src/virterror.c 6 Jul 2007 14:56:15 -0000 1.28 +++ src/virterror.c 12 Jul 2007 02:00:54 -0000 @@ -646,6 +646,12 @@ __virErrorMsg(virErrorNumber error, cons else errmsg = _("Network not found: %s"); break; + case VIR_ERR_INVALID_MAC: + if (info == NULL) + errmsg = _("invalid MAC adress"); + else + errmsg = _("invalid MAC adress: %s"); + break; } return (errmsg); } Index: src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.81 diff -u -p -r1.81 xml.c --- src/xml.c 11 Jul 2007 08:41:11 -0000 1.81 +++ src/xml.c 12 Jul 2007 02:00:55 -0000 @@ -934,8 +934,19 @@ virDomainParseXMLIfDesc(virConnectPtr co } virBufferAdd(buf, "(vif ", 5); - if (mac != NULL) + if (mac != NULL) { + unsigned int addr[12]; + int ret = sscanf((const char *)mac, "%01x%01x:%01x%01x:%01x%01x:%01x%01x:%01x%01x:%01x%01x", + (unsigned int*)&addr[0], (unsigned int*)&addr[1], (unsigned int*)&addr[2], + (unsigned int*)&addr[3], (unsigned int*)&addr[4], (unsigned int*)&addr[5], + (unsigned int*)&addr[6], (unsigned int*)&addr[7], (unsigned int*)&addr[8], + (unsigned int*)&addr[9], (unsigned int*)&addr[10], (unsigned int*)&addr[11]); + if (ret != 12 || strlen(mac) != 17) { + virXMLError(conn, VIR_ERR_INVALID_MAC, (const char *) mac, 0); + goto error; + } virBufferVSprintf(buf, "(mac '%s')", (const char *) mac); + } if (source != NULL) { if (typ == 0) virBufferVSprintf(buf, "(bridge '%s')", (const char *) source);

3 3

[Libvir] [PATCH] Fix strange message on virsh attach-device
by Masayuki Sunou 13 Jul '07

13 Jul '07

Hi Virsh attach-device outputs a strange message, when XML whose top element is not <device> or <interface>. ---------------------------------------------------------------------- libvir: Xen Daemon error : POST operation failed: (xend.err "object of type 'NoneType' has no len()") error: Failed to attach device from test.xml ---------------------------------------------------------------------- This patch fixes it by not calling Xen in this case. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: libvirt/src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.81 diff -u -p -r1.81 xml.c --- libvirt/src/xml.c 11 Jul 2007 08:41:11 -0000 1.81 +++ libvirt/src/xml.c 13 Jul 2007 02:48:04 -0000 @@ -1337,6 +1337,8 @@ virParseXMLDevice(virConnectPtr conn, ch else if (xmlStrEqual(node->name, BAD_CAST "interface")) { if (virDomainParseXMLIfDesc(conn, node, &buf, hvm, xendConfigVersion) != 0) goto error; + } else { + goto error; } cleanup: if (xml != NULL)

3 2

[Libvir] Small remote doc update and little checking script
by Daniel Veillard 12 Jul '07

12 Jul '07

Hi, I updated slightly the remote page (mostly adding an index at the top and updating a couple of things which changed prior to 0.3.0 release) http://libvirt.org/remote.html and added a small script to check the client/server setup on a given host, trying to pinpoint the problems I faced myself when trying to set the TLS certificates. This may help others, checked in docs/pki_check.sh and hence available at http://libvirt.org/pki_check.sh There is certainly many more check which can be done (like expiration date checking, or making sure certs and keys are properly matched), but it's a first step, an maybe it can help others testing the remote support. Feedback and patches are as usual welcome :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] PATCH: Report errors against virConnectPtr object
by Daniel P. Berrange 12 Jul '07

12 Jul '07

The QEMU driver is not passing in a virConnectPtr object for many of the places it calls virRaiseError. This means the errors aren't getting fed back to the client correctly - particularly when starting a VM / network. This patch passes around a virConnectPtr object so errors get reported correctly Instead of: $ ~/usr/bin/virsh --connect qemu://celery.virt.boston.redhat.com/system start demo error: Failed to start domain demo It now gives $ ~/usr/bin/virsh --connect qemu://celery.virt.boston.redhat.com/system start demo libvir: QEMU error : QEMU quit during console startup qemu: could not open hard disk image '/root/demo.img' error: Failed to start domain demo Dan -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4