- Devel - libvirt List Archives

[Libvir] Proposal: Check availability of driver calls (repost)
by Richard W.M. Jones 01 Aug '07

01 Aug '07

-- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 9

[Libvir] Exporting calls just to libvirtd
by Richard W.M. Jones 31 Jul '07

31 Jul '07

With the two patches[1][2] I recently posted, the remote driver has started to make calls more directly into the drivers. Calls like driver->domainMigratePrepare in [2] are exposed to the remote driver, but shouldn't be exported for public use. However because libvirtd links to regular libvirt.so, the calls actually do need to be exported, so we export them as __virDomainMigratePrepare (etc) with the double underscore and exclusion from <libvirt.h> indicating that users of the published libvirt API should not call them. It seems we could avoid exporting them entirely with one of these methods: (a) Link libvirtd to the static libvirt.a. -- Probably violates a load of distro policy and removes some supposed benefits of dynamic linking. (b) Build a separate shared library with a different dynamic symbol table. -- Also removes one benefit of dynamic linking, because the two libraries are different despite having the same code in them. Any ideas if some advanced feature of ELF offers a way out here? Rich. [1]https://www.redhat.com/archives/libvir-list/2007-July/msg00444.html [2]https://www.redhat.com/archives/libvir-list/2007-July/msg00357.html -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] PATCH: Check for bogus default architecture
by Daniel P. Berrange 31 Jul '07

31 Jul '07

There was a missing check in the QEMU driver for a bogus architecture in the XML which could cause a crash. This wasn't a problem except for the fact that another bug in my recent virt-install 0.200.0 release passed a bogus architecture on 32-bit platforms :-( Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] PATCH: Overhaul the test driver
by Daniel P. Berrange 31 Jul '07

31 Jul '07

The test driver has suffered from quite alot of bitrot. Its got all sorts of checks in the driver entry points already done by libvirt.c, its got private data, redundantly pointing to private data, it doesn't implement any of the networking APIs, is missing alot of the newer domain APIs. So I've given it a thorough overhaul to remove alot of redundant code, clean up more, and add entry points for all the APIs except for VCPU pinning ones. The addition of the networking APIs means we no longer get errors thrown when trying to run tests without the libvirt daemon running, and means apps can actually do tests for their networking capabilities. docs/testnetdef.xml | 12 docs/testnetpriv.xml | 11 docs/testnode.xml | 2 src/driver.h | 1 src/libvirt.c | 17 src/qemu_driver.c | 1 src/remote_internal.c | 1 src/test.c | 1892 +++++++++++++++++++++++++++++++------------------- tests/virshtest.c | 465 +++--------- 9 files changed, 1382 insertions(+), 1020 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] PATCH Fix a couple of mem leaks
by Daniel P. Berrange 31 Jul '07

31 Jul '07

I ran 'make valgrind' for the first time in too long and found a hanful of memory leaks in code exercised by the test suite. The attached patch fixes them all. I'm sure there are more lurking though - the test suite is mainly focused on exercising & validating correctness of parsing routines - its not really tried doing any validation of failure scenaarios. So I fear there's probably a number of error code paths where we don't cleanup properly, and/or don't reject invalid data. Its an area which should be addressed by someone with some copious free time ;-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] PATCH 0/2: Capabilities and features
by David Lutterkort 30 Jul '07

30 Jul '07

Hi, these two patches extend the features libvirt reports in the capabilities XML; in particular, features are now reported for the QEMU driver, and features for both Xen and QEMU include information on ACPI/APIC support. Tools that rely on feature reporting, in general, need to know whether a certain feature is on or off by default, and whether that can be toggled, because users will be asking for one of three things for their VM: * Feature X (e.g., ACPI) must be on/present in the VM * Feature X must not be on/present in the VM * It doesn't matter whether feature X is there or not For example, in QEMU, ACPI is on by default, but can be turned off. The APIC on the other hand, is always there and can't be turned off. That is now reported as <features> <acpi default="on" toggle="yes"/> <apic default="on" toggle="no"/> </features> It's unfortunate that the format for PAE (<pae/> vs. <nonpae/>) reporting doesn't fit into this scheme. I didn't want to start with having tags <X/> and <nonX/> for each feature; that means that parsers need to special case PAE. It's probably too late, but it would be nice if PAE was reported in a similar format, with <pae> correponding to <pae default="on" toggle="no"/>, <nonpae/> corresponding to <pae default="yes" toggle="no"/>, and having both together corresponding to <pae default="yes" toggle="yes"/>, but that's a separate discussion from these patches. David

4 12

[Libvir] [PATCH] virsh Range check in Credit Scheduler
by Atsushi SAKAI 30 Jul '07

30 Jul '07

Hi, Add Range check in Credit Scheduler. Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI

6 20

[Libvir] [PATCH] add a ttyconsole command
by Daniel Veillard 26 Jul '07

26 Jul '07

It was pointed out that we have a vncdisplay command but none for extracting the TTY console device: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239687 the trivial associated patch adds it as well as the doc in the man page Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

3 4

[Libvir] PATCH: Separate QEMU impl of nodeinfo API
by Daniel P. Berrange 25 Jul '07

25 Jul '07

While fixing the QEMU nodeinfo API to correctly deal with case where CPU sockets have sparse numbering (eg sockets 0 & 3 are populated), I realized that OpenVZ doesn't have a nodeinfo API, and its requirements are basically identical to the QEMU driver's. So this patch moves the impl of the nodeinfo API into a nodeinfo.c file, and makes both the QEMU and OpenVZ driver call out to this shared impl. I also put #ifdef __linux__ around the impl since code reading /proc/cpuinfo is never going to work on any non-Linux platform. For non linux I just return -1 which'll get treated as not-implemented. If QEMU driver is ported to work on Solaris, the nodeinfo.c file can be easily extended for their custom impl. Finally I'm adding a testcase with a bunch of example /proc/cpuinfo files to validate correctness Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] [PATCH] Python bindings: Use virDomain/NetworkGetConnect instead of storing connection in domain/network object
by Richard W.M. Jones 24 Jul '07

24 Jul '07

Previously[1] I patched libvirt to add the virDomainGetConnect and virNetworkGetConnect functions. The rationale for these is explained here[2]. The attached patch makes the Python bindings use these functions instead of storing the connection object explicitly. Rich. [1]https://www.redhat.com/archives/libvir-list/2007-June/msg00365.html [2]https://www.redhat.com/archives/libvir-list/2007-June/msg00352.html

3 8