- Devel - libvirt List Archives

[Libvir] [PATCH] qemu: reset migration source if restore fails
by Jim Paris 10 Oct '07

10 Oct '07

With the latest KVM I'm having some issues with save/restore, but I think it's a kvm issue and not libvirt. The problems did expose a libvirt bug, though; patch below. -jim --- A failed restore of a configured VM would leave the migration source set incorrectly, preventing the VM from being started normally. Always clear migration source, then deal with failures. src/qemu_driver.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 87b66ad..bff17b0 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2083,6 +2083,7 @@ static int qemudDomainRestore(virConnectPtr conn, struct qemud_vm_def *def; struct qemud_vm *vm; int fd; + int ret; char *xml; struct qemud_save_header header; @@ -2161,18 +2162,17 @@ static int qemudDomainRestore(virConnectPtr conn, /* Set the migration source and start it up. */ snprintf(vm->migrateFrom, sizeof(vm->migrateFrom), "stdio"); vm->stdin = fd; - - if (qemudStartVMDaemon(conn, driver, vm) < 0) { + ret = qemudStartVMDaemon(conn, driver, vm); + close(fd); + vm->migrateFrom[0] = '\0'; + vm->stdin = -1; + if (ret < 0) { qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, "failed to start VM"); if (!vm->configFile[0]) qemudRemoveInactiveVM(driver, vm); - close(fd); return -1; } - close(fd); - vm->migrateFrom[0] = '\0'; - vm->stdin = -1; /* If it was running before, resume it now. */ if (header.was_running) { -- 1.5.3.rc4

3 2

[Libvir] Win Pro 64 dies in second half of windows guest installation
by Lawrence Nitz 10 Oct '07

10 Oct '07

When I set up a guest VM using virtp-install on a Fedor a 7 system, the process gets as far as reading the raw device (/dev/scd0) for the install disk, writes the basic windows data onto the disk, and then reboots to complete the Windows installation. At this point the installation hangs, with a diagnostic that says the file cannot be found. The same error occurs whether the install is from the hard disk image or from the cd-rom. The install gets half done, and has nothing to read when the install program restarts itself. In the Virt manager the edit command allows me to edit the machine, but not to add back the cd drive, only add network cards and hard disk partitions. Any help by a more experienced virt-install user would be much appreciated. Larry Nitz.

1 0

[Libvir] Problems with defineXML in python..
by Mark Dehus 10 Oct '07

10 Oct '07

I am having some problems getting libvirt under python to work properly. I can setup new domains by using the createLinux() function, but when I attempt to use defineXML() it fails with no reason given other then "virDomainDefineXML() failed". I am using the same XML file for both functions. This is on a Ubuntu 7.04 server running python 2.5 & libvirt 0.1.8 (from the ubuntu universe repo). Here is my test code: import libvirt import sys import xml import random try: conn = libvirt.open(None) except Exception, e: print e if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) create = True if create: xmlfile = open('webserv.xml') xmldesc = xmlfile.read() xmlfile.close() try: # webserv = conn.createLinux(xmldesc, 0) webserv = conn.defineXML(xmldesc) except Exception, e: print 'Failed to create webserv: %s' % e sys.exit(1) if webserv is None: print 'whoops this shouldnt happen!' conn.create(webserv) try: print "Domain 0: id %d running %s" % (webserv.ID(), webserv.OSType()) print webserv.info() print webserv.XMLDesc(0) except Exception, e: print e #webserv.shutdown() And the XML file: <domain type='xen' > <name>webserv</name> <os> <type>linux</type> <kernel>/boot/vmlinuz-2.6.19-4-generic-amd64</kernel> <initrd>/boot/initrd.img-2.6.19-4-generic-amd64</initrd> <root>/dev/hda1</root> </os> <memory>1024</memory> <vcpu>1</vcpu> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <interface type='bridge'> <source bridge='xenbr0'/> <mac address='00:16:3e:24:27:a5'/> <script path='vif-bridge'/> </interface> <graphics type='vnc' port='5902'/> <disk type='file' device='disk'> <driver name='tap' type='aio'/> <source file='/virtual/images/webserv/webserv.img'/> <target dev='hda1'/> </disk> <console tty='/dev/pts/4'/> </devices> </domain> Am I missing something simple, or is there a bug? Thanks!

2 1

[Libvir] [PATCH] Topology fix for "no cpus"
by beth kon 08 Oct '07

08 Oct '07

Here is a resubmission of this patch, corrected. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] [PATCH] Found minor bug in topology code
by beth kon 05 Oct '07

05 Oct '07

I found a problem with an error path... I was cutting off incrementing of a value in the loop then checking if it was too big after the loop, so the way it was structured, it could never happen. Here is the fix. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] PATCH: Updated patches for PolicyKit support
by Daniel P. Berrange 03 Oct '07

03 Oct '07

A few weeks back I posted some prototype patches for PolicyKit support to allow the main libvirt daemon socket to be made world-accessible. PolicyKit then can do ACLs on incoming connections, allowing definition of rules which could for example, allow only the user who owns the active X login sesion http://www.redhat.com/archives/libvir-list/2007-August/msg00027.html This is an updated patch which takes account of a change in the PolicyKit XML file syntax between 0.4 and 0.5 releases. The configure.in scripts has been tweaked to automatically disable PolicyKit if pkg-config is not available instead of aborting. The code for getting UNIX socket credentials has been factored out into its own method. There is still only a Linux implementation. I was going to take the code for other OS from DBus, but DBus is currently under a GPL/Academic license options, which is not compatible with LGPL. Fortunately DBus is in middle of re-licensing to X11 style which is LGPL compatible, so in a week or so's time we'll be able to safely take their OS portability code for socket credentials. I short-circuit the logic to always allow root. This allows existing people running libvirt tools as root to continue use without any regressions. There is one small issue still that the default policy I provide only allows the use of read-only connections if the user is logged into to the desktop. This is a partial regression - the admin can edit /etc/PolicyKit/PolicyKit.conf and add a site-local rule allowing all users access, regardless of whether they're in a session. I've spoken with David Zeuthan and he's going to add ability to specify rules for non-session clients in the default policy config files, which will fix this minor regression. Once this is done the libvirt default policy will be identical to current file permission based policy (root == full access, non-root == read only). As I mentioned previously, with this change it is now possible to open a full read-write connection from virt-manager running as non-root. Depending on site policy it will optionally prompt for root password (su style equiv) or the user's password (sudo style equiv) without needing virt-manager itself to gain any elevated privileges. When compiling with PolicyKit support, the default file permissions for both the main & readonly UNIX sockets in the daemon switch to 0777, instead of the previous 0700 & 0777. It is possible to turn off PolicyKit auth in the daemon config file, even if it is compiled in - in which case the default permissions get set back to 0700 & 0777. Although in previous feedback Daniel suggested I leave the LIBVIRTD_AUTH_POLKIT constant compiled in all the time, I feel it is better to remove it when the policykit support is disabled in configure. This removes the need to have extra switch/case statements to explicitly reject LIBVIRTD_AUTH_POLKIT auth, since it will be handle by the 'default:' statement which already has code to reject connections. I've done more extensive testing with virt-manager since my previous patch, and its working very nicely with the new UI which allows multiple hypervisor connections. Instead of asking for the root password up-front at app start time, we now only need ask for it if the user connects to a local HV. If they only ever manage remote connections we don't need to do anything with the local root password. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] Release of libvirt-0.3.3
by Daniel Veillard 30 Sep '07

30 Sep '07

More than a month without a release ... it was clearly time to push the bits out. Available as usual from ftp://libvirt.org/libvirt/ A lot of new things in the last month: * New features: - Avahi mDNS daemon export (Daniel Berrange) - NUMA support (Beth Kan) * Documentation: - cleanups (Toth Istvan) - typos (Eduardo Pereira) * Bug fixes: - memory corruption on large dumps (Masayuki Sunou) - fix virsh vncdisplay command exit (Masayuki Sunou) - Fix network stats TX/RX result (Richard Jones) - warning on Xen 3.0.3 (Richard Jones) - missing buffer check in virDomainXMLDevID (Hugh Brock) - avoid zombies when using remote (Daniel Berrange) - xend connection error message (Richard Jones) - avoid ssh tty prompt (Daniel Berrange) - username handling for remote URIs (Fabian Deutsch) - fix potential crash on multiple input XML tags (Daniel Berrange) - Solaris Xen hypercalls fixup (Mark Johnson) * Improvements: - OpenVZ support (Shuveb Hussain and Anoop Cyriac) - CD-Rom reload on XEn (Hugh Brock) - PXE boot got QEmu/KVM (Daniel Berrange) - QEmu socket permissions customization (Daniel Berrange) - more QEmu support (Richard Jones) - better path detection for qemu and dnsmasq (Richard Jones) - QEmu flags are per-Domain (Daniel Berrange) - virsh freecell command - Solaris portability fixes (Mark Johnson) - default bootloader support (Daniel Berrange) - new virNodeGetFreeMemory API - vncpasswd extraction in configuration files if secure (Mark Johnson and Daniel Berrange) - Python bindings for block and interface statistics * Code cleanups: - virDrvOpenRemoteFlags definition (Richard Jones) - configure tests and output (Daniel Berrange) Thanks to everybody who helped with sugegstion, bug reports patches and more ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] PATCH: vncpasswd
by Mark Johnson 30 Sep '07

30 Sep '07

This adds support for handling vncpasswd.. MRJ vncpasswd support diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -1657,11 +1657,14 @@ xend_parse_sexp_desc(virConnectPtr conn, } else if (tmp && !strcmp(tmp, "vnc")) { int port = xenStoreDomainGetVNCPort(conn, domid); const char *listenAddr = sexpr_node(node, "device/vfb/vnclisten"); + const char *vncPasswd = sexpr_node(node, "device/vfb/vncpasswd"); const char *keymap = sexpr_node(node, "device/vfb/keymap"); virBufferVSprintf(&buf, " <input type='mouse' bus='%s'/>\n", hvm ? "ps2": "xen"); virBufferVSprintf(&buf, " <graphics type='vnc' port='%d'", port); if (listenAddr) virBufferVSprintf(&buf, " listen='%s'", listenAddr); + if (vncPasswd) + virBufferVSprintf(&buf, " passwd='%s'", vncPasswd); if (keymap) virBufferVSprintf(&buf, " keymap='%s'", keymap); virBufferAdd(&buf, "/>\n", 3); @@ -1723,6 +1726,7 @@ xend_parse_sexp_desc(virConnectPtr conn, if (tmp[0] == '1') { int port = xenStoreDomainGetVNCPort(conn, domid); const char *listenAddr = sexpr_fmt_node(root, "domain/image/%s/vnclisten", hvm ? "hvm" : "linux"); + const char *vncPasswd = sexpr_fmt_node(root, "domain/image/%s/vncpasswd", hvm ? "hvm" : "linux"); const char *keymap = sexpr_fmt_node(root, "domain/image/%s/keymap", hvm ? "hvm" : "linux"); /* For Xen >= 3.0.3, don't generate a fixed port mapping * because it will almost certainly be wrong ! Just leave @@ -1736,6 +1740,8 @@ xend_parse_sexp_desc(virConnectPtr conn, virBufferVSprintf(&buf, " <graphics type='vnc' port='%d'", port); if (listenAddr) virBufferVSprintf(&buf, " listen='%s'", listenAddr); + if (vncPasswd) + virBufferVSprintf(&buf, " passwd='%s'", vncPasswd); if (keymap) virBufferVSprintf(&buf, " keymap='%s'", keymap); virBufferAdd(&buf, "/>\n", 3);

2 2

[Libvir] PATCH: Allow emptry bootloader
by Daniel P. Berrange 30 Sep '07

30 Sep '07

Latest XenD allows for default bootloader to be used if one is not defined for a paravirt OS. libvirt doesn't currently cope with this (see Solaris thread), since it requires either a bootloader or kernel to always be present. The attached patch allows for an emptry bootloader element to indicate that the domain should use the default. <domain type='xen' id='-1'> <name>rhel5pv</name> <uuid>614d7eb0-c6b1-5235-ac39-361b20f6cd49</uuid> <bootloader/> <os> <type>linux</type> </os> ...snip... </domain> The current API for looking up nodes in the SEXPR did not allow for the scenario where you might want to lookup a node with no content, eg (bootloader ) This distinction is needed here, so I added an sexpr_has() method to check for this. Second, it fixes a long standing bug where we'd record an error about the missing kernel or bootloader, but then continue generating (malformed) XML anyway. With this patch, it will correctly fail if the empty bootloader field is missing from the SEXPR. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 4

[Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology
by beth kon 30 Sep '07

30 Sep '07

I have tested the patches on a NUMA and a non-NUMA configuration, and they fundamentally appear to work. The first patch is for accessing available memory on a per-node basis. The second patch is for accessing NUMA node topology. I've gotten some helpful suggestions about my string parsing code, introducing me to sscanf :-). I've become convinced that there are more elegant ways to do this which would have about the same level of error checking. However, I am out of time if Daniel wants to check this in this week. So I offer what I do have, which functions, but is not elegant. I have been playing with other ways to do this and am not far from finished. So, Daniel, you need to tell me if you want to take this code, and possibly upgrade to something more compact later, or if you'd like to wait for the next revision. One point to comment on for posterity is that the string returned from xend is not what might be expected. An example: printf("string is %s\n", tempstr); would return string is node0:0\n node1:1 So, this means that the '\n' sent by the xend python code is somehow translated to "\n". And the trailing '\n' that should be there isn't. Instead there is a '\0'. Looking at the xend code, it would appear this string should look like: "node0:0\n node1:1\n" where these are '\n'. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

4 11