- Devel - libvirt List Archives

[Libvir] OCaml bindings 0.4.0.1 released
by Richard W.M. Jones 08 Jan '08

08 Jan '08

I'm pleased to announce the latest release of the libvirt OCaml bindings and programs. http://libvirt.org/ocaml/ There's a large list of changes since the last release, so best thing is to refer to the Changelog itself: http://libvirt.org/ocaml/ChangeLog.txt Source code is available from here: http://libvirt.org/sources/ocaml/ Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] OCaml bindings - Windows installer
by Richard W.M. Jones 08 Jan '08

08 Jan '08

This is a Windows installer for the OCaml libvirt bindings and programs: http://libvirt.org/sources/ocaml/ocaml-libvirt-0.4.0.1.exe If someone has a 'virgin' Windows system and could test that the above installer works, particularly for Windows < Vista and for Windows which has not had any GTK/MinGW development tools installed. About 90% of the size of the installer is down to the GTK DLLs and configuration files which need to be carried along to support the GTK graphical program (Virt Control). It's possible that I haven't placed the GTK files in exactly the right place, so instead it is using my own GTK development environment. Screenshots showing the installer in action: http://annexia.org/tmp/wininstaller-1-desktop.png Desktop, nothing installed, showing the installer icon. http://annexia.org/tmp/wininstaller-2-packages.png List of required, recommended and optional subpackages. http://annexia.org/tmp/wininstaller-3-instpath.png Select the installation path. http://annexia.org/tmp/wininstaller-4-installdone.png Install complete. Notice the desktop icons, ... http://annexia.org/tmp/wininstaller-5-menu.png ... and the menu entries and uninstaller program. http://annexia.org/tmp/wininstaller-6-virtctrl.png Running Virt Control. http://annexia.org/tmp/wininstaller-7-uninstall.png After uninstall. Notice that the desktop icons have gone. The installer uses NSIS (the Nullsoft Scriptable Install System, http://nsis.sf.net/) and is reasonably well integrated into the autoconf / make build system. In particular if you are compiling under Windows and NSIS is installed, then a simple './configure --with-nsis; make wininstaller' will build a Windows installer. This is something to look at if libvirt wants/needs a Windows installer. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

Re: [Libvir] [patch 2/2] Enable stdout/stderr spew with --enable-debug
by Daniel Veillard 08 Jan '08

08 Jan '08

On Mon, Jan 07, 2008 at 06:12:38PM +0000, Mark McLoughlin wrote: > Change virExec() such that with --enable-debug, stdout > and stderr no longer go to /dev/null. > Looks fine to me, but I didn't see [1/2] numbering problem ? I didn't see any bounced mail in the list either, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1

[Libvir] [patch 2/2] Enable stdout/stderr spew with --enable-debug
by Mark McLoughlin 07 Jan '08

07 Jan '08

Change virExec() such that with --enable-debug, stdout and stderr no longer go to /dev/null. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/src/util.c =================================================================== --- libvirt.orig/src/util.c 2008-01-07 18:00:03.000000000 +0000 +++ libvirt.orig/src/util.c 2008-01-07 18:00:03.000000000 +0000 @@ -157,10 +157,17 @@ _virExec(virConnectPtr conn, if (dup2(infd >= 0 ? infd : null, STDIN_FILENO) < 0) _exit(1); +#ifndef ENABLE_DEBUG if (dup2(pipeout[1] > 0 ? pipeout[1] : null, STDOUT_FILENO) < 0) _exit(1); if (dup2(pipeerr[1] > 0 ? pipeerr[1] : null, STDERR_FILENO) < 0) _exit(1); +#else /* ENABLE_DEBUG */ + if (pipeout[1] > 0 && dup2(pipeout[1], STDOUT_FILENO) < 0) + _exit(1); + if (pipeerr[1] > 0 && dup2(pipeerr[1], STDERR_FILENO) < 0) + _exit(1); +#endif /* ENABLE_DEBUG */ close(null); if (pipeout[1] > 0) --

1 0

[Libvir] [patch 1/2] Do not try and delete built-in iptables chains
by Mark McLoughlin 07 Jan '08

07 Jan '08

Previously, when we supported adding our rules to chains with a custom prefix (e.g. libvirt-Fedora-POSTROUTING) we needed to be able to handle adding and deleting these custom chains. Now that we only use built-in iptables chains, we don't need to add or delete them - in fact, deleting them is not allowed. (Note: this was the only user of the iptablesSpawn(NO_ERRORS) stuff - we didn't want error spew when adding/deleting the chains failed as expected in most cases) Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/src/iptables.c =================================================================== --- libvirt.orig/src/iptables.c 2008-01-07 17:26:42.000000000 +0000 +++ libvirt.orig/src/iptables.c 2008-01-07 17:26:42.000000000 +0000 @@ -386,53 +386,6 @@ iptRulesNew(const char *table, return NULL; } -static int -iptablesAddRemoveChain(iptRules *rules, int action) -{ - char **argv; - int retval = ENOMEM; - int n, status; - - n = 1 + /* /sbin/iptables */ - 2 + /* --table foo */ - 2; /* --new-chain bar */ - - if (!(argv = calloc(n + 1, sizeof(*argv)))) - goto error; - - n = 0; - - if (!(argv[n++] = strdup(IPTABLES_PATH))) - goto error; - - if (!(argv[n++] = strdup("--table"))) - goto error; - - if (!(argv[n++] = strdup(rules->table))) - goto error; - - if (!(argv[n++] = strdup(action == ADD ? "--new-chain" : "--delete-chain"))) - goto error; - - if (!(argv[n++] = strdup(rules->chain))) - goto error; - - if (virRun(NULL, argv, &status) < 0) - retval = errno; - - retval = 0; - - error: - if (argv) { - n = 0; - while (argv[n]) - free(argv[n++]); - free(argv); - } - - return retval; -} - static char * argvToString(char **argv) { @@ -521,19 +474,11 @@ iptablesAddRemoveRule(iptRules *rules, i goto error; } - if (action == ADD && - (retval = iptablesAddRemoveChain(rules, action))) - goto error; - if (virRun(NULL, argv, NULL) < 0) { retval = errno; goto error; } - if (action == REMOVE && - (retval = iptablesAddRemoveChain(rules, action))) - goto error; - if (action == ADD) { retval = iptRulesAppend(rules, rule, argv, command_idx); rule = NULL; @@ -641,11 +586,6 @@ iptRulesReload(iptRules *rules) rule->argv[rule->command_idx] = orig; } - if ((retval = iptablesAddRemoveChain(rules, REMOVE)) || - (retval = iptablesAddRemoveChain(rules, ADD))) - qemudLog(QEMUD_WARN, "Failed to re-create chain '%s' in table '%s': %s", - rules->chain, rules->table, strerror(retval)); - for (i = 0; i < rules->nrules; i++) if (virRun(NULL, rules->rules[i].argv, NULL) < 0) qemudLog(QEMUD_WARN, "Failed to add iptables rule '%s' to chain '%s' in table '%s': %s", --

1 0

[Libvir] [patch 0/2] Couple more misc iptables related patches
by Mark McLoughlin 07 Jan '08

07 Jan '08

Hey, Dan's suggestion to enable debug spew from spawned processes with --enable-debug reminded me that the only reason I wanted the NO_ERRORS stuff in the iptables code was to avoid spewage when trying to add/delete builtin iptables chains. Cheers, Mark. --

1 0

Re: [Libvir] [patch 7/9] Add support for lokkit
by Daniel P. Berrange 07 Jan '08

07 Jan '08

On Fri, Jan 04, 2008 at 03:57:32PM +0000, Mark McLoughlin wrote: > Add support for integrating our iptables support with Fedora's > iptables configuration using the lokkit --custom-rules command. > > Basically, we write out our rules to /var/lib/libvirt/iptables > and run lokkit --custom-rules so that if e.g. iptables is > restarted or the user edits their firewall configuration, then > libvirt's rules get reloaded. Ahh, that's very nice to have. > +dnl > +dnl ensure that Fedora's system-config-firewall knows > +dnl about libvirt's iptables rules > +dnl > +AC_ARG_ENABLE(iptables-lokkit, > + AC_HELP_STRING([--enable-iptables-lokkit=no/yes], > + [enable registering libvirt's iptables rules with Fedora's lokkit]), > + [],[enable_iptables_lokkit=no]) > +if test x"$enable_iptables_lokkit" = x"yes"; then > + AC_DEFINE(ENABLE_IPTABLES_LOKKIT, [], [whether support for Fedora's lokkit is enabled]) > + AC_PATH_PROG(LOKKIT_PATH, lokkit, /usr/sbin/lokkit) > + AC_DEFINE_UNQUOTED(LOKKIT_PATH, "$LOKKIT_PATH", [path to lokkit binary]) > +fi > + Could we make the configure script a little more clever so that it is a tri-state and can auto-detect whether lokkit is available. - enable_iptables_lokkit=no - force disable - enable_iptables_lokkit=yes - check if it is supported, and error if not - enable_iptables_lokkit=check - check if it is supported and enable or disable as needed With 'check' being the default. This makes it 'do the right' thing by default, and lets the user have a strict override if neccessary. ACK to the rest of the patch Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

Re: [Libvir] [patch 5/9] Include the iptables command and chain name in the saved rules file
by Daniel P. Berrange 07 Jan '08

07 Jan '08

On Fri, Jan 04, 2008 at 03:57:30PM +0000, Mark McLoughlin wrote: > lokkit --custom-rules expects the passed file to include the > iptables command and chain name (e.g. "--inset INPUT") rather > than just the rest of the arguments. > > Add both of those to what will be saved to the rules file > and simplify the resulting code by splitting out a > argvToString() helper function. > > The one complication is that when we're removing a rule > we need to make sure we don't search for it using > "--delete" rather than "--insert". For that reason, > only change the argument to "--delete" once we've > constructed the string we use to search through the > existing rules. ACK. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

1 0

[Libvir] OCaml mlvirtmanager ported to Windows
by Richard W.M. Jones 05 Jan '08

05 Jan '08

(NB. This is _not_ the real virt-manager). Screenshots: http://www.annexia.org/tmp/mlvirtmanager-win-1.png http://www.annexia.org/tmp/mlvirtmanager-win-2.png http://www.annexia.org/tmp/mlvirtmanager-win-3.png The code is in the Mercurial repository, http://hg.et.redhat.com/virt/applications/virt-top--devel . You will need to install lablgtk2 binary from: http://wwwfun.kurims.kyoto-u.ac.jp/soft/olabl/lablgtk.html and Windows Gtk development binary from: http://gladewin32.sourceforge.net/ and then follow the installation instructions for lablgtk2 given here: http://wwwfun.kurims.kyoto-u.ac.jp/soft/olabl/install-win32.txt After that, ocaml-libvirt should automatically detect that you've got Gtk / lablgtk2 installed (you might need to restart the MSys shell so it gets the new $PATH), and will offer to compile mlvirtmanager. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] A few more Windows / MinGW fixups
by Richard W.M. Jones 05 Jan '08

05 Jan '08

A few fairly miscellaneous fixups for Windows (MinGW) which fix shared library builds and fix error handling for sockets. (1) XDR functions on MinGW come from a library called 'libxdr', not 'librpc'. (2) To build a DLL under MinGW we need to pass the -no-undefined flag to the linker. (3) Socket compatibility header file replaces <winsock2.h> inclusion. This just defines a portable 'socket_errno()' function which returns errno in the normal case, or WSAGetLastError() in the Windows case. (4) Use socket_errno() instead of errno in a few cases (but only when the code can be compiled under Windows, ie. only in the remote client case). Example -- a dynamically linked virsh.exe (linked to libvirt-0.dll) accessing a remote libvirtd: $ src/.libs/virsh.exe -c test+tcp://192.168.2.128/default list Id Name State ---------------------------------- 1 test running If you want to compile this under Windows, you will need: (a) MinGW & MSYS (select the "candidate" versions of MinGW tools if you are using Vista or W2K8, since otherwise nothing works because of a known bug). (b) Install gcc 4 experimental package from MinGW site. It's called gcc-sjlj for reasons which escape me. (c) Install GnuTLS binary from http://www.gnu.org/software/gnutls/download.html. I'm using GnuTLS Windows binary 1.6.3 and I had to hand-hack the *.la files in that distribution because they contain incorrect paths. (d) Compile and install latest libxml2 from http://xmlsoft.org/. I'm using 2.6.30. (e) Compile and install my XDR package for Windows (http://www.annexia.org/tmp/xdr-4.0-mingw5.tar.gz) (f) ./configure --without-xen --without-qemu --without-sasl --without-libvirtd (g) make Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 4