- Devel - libvirt List Archives

[PATCH v1] lcitool: remove obsolete RISC-V ports setup for Debian 13+
by 杨泽伟 11 Oct '25

11 Oct '25

From 1603e78297c32f241d7a55f510bae3b8ac16f154 Mon Sep 17 00:00:00 2001 From: yzewei <yangzewei(a)loongson.cn> Date: Fri, 10 Oct 2025 18:01:59 +0800 Subject: [PATCH] lcitool: remove obsolete RISC-V ports setup for Debian 13+ Debian 13 and later officially support riscv64, so the old debian-ports archive keyring and sources.list configuration are no longer necessary. This patch removes the legacy code that adds the debian-ports repositories and installs the debian-ports-archive-keyring package. Signed-off-by: yzewei <yangzewei(a)loongson.cn> --- lcitool/formatters.py | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/lcitool/formatters.py b/lcitool/formatters.py index c26cf22a..af171fae 100644 --- a/lcitool/formatters.py +++ b/lcitool/formatters.py @@ -456,21 +456,6 @@ class BuildEnvFormatter(Formatter): "dpkg --add-architecture {cross_arch_deb}", ] ) - if target.cross_arch == "riscv64": - cross_commands.extend( - [ - "{nosync}{packaging_command} install debian-ports-archive-keyring", - "{nosync}echo 'deb http://ftp.ports.debian.org/debian-ports/ sid main' > /etc/apt/sources.list.d/ports.list", - "{nosync}echo 'deb http://ftp.ports.debian.org/debian-ports/ unreleased main' >> /etc/apt/sources.list.d/ports.list", - ] - ) - cross_commands.extend( - [ - "{nosync}{packaging_command} update", - "{nosync}{packaging_command} dist-upgrade -y", - "{nosync}{packaging_command} install --no-install-recommends -y dpkg-dev", - ] - ) if varmap["cross_pkgs"]: cross_commands.extend( [ -- 2.43.0 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.

2 1

[PATCH v2 0/3] qemu: Implement support for multiple SMMUv3s
by Nathan Chen 11 Oct '25

11 Oct '25

Hi, This is a follow up to the first patchset [0] for supporting multiple vSMMU instances. This patchset implements support for specifying multiple <iommu> devices within the VM definition when smmuv3Dev IOMMU model is specified, and is tested with Shameer's recently accepted qemu series for user-creatable vSMMU devices [1] For instance, specifying the associated emulated device in a VM definition with multiple IOMMUs, configured to be routed to pcie-expander-bus or pcie-root controllers: <devices> <controller type='pci' index='0' model='pcie-root'/> <controller type='pci' index='1' model='pcie-expander-bus'> <model name='pxb-pcie'/> <target busNr='252'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </controller> <controller type='pci' index='2' model='pcie-root-port'> <model name='pcie-root-port'/> <target chassis='2' port='0x0'/> <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> </controller> ... <rng model='virtio'> <backend model='random'>/dev/urandom</backend> <address type='pci' domain='0x0000' bus='0x02' slot='0x00' function='0x0'/> </rng> <rng model='virtio'> <backend model='random'>/dev/urandom</backend> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </rng> <iommu model='smmuv3Dev'> <driver parentIdx='0'/> </iommu> <iommu model='smmuv3Dev'> <driver parentIdx='1'/> </iommu> </devices> This would get translated to a qemu command line with the arguments below. -device '{"driver":"pxb-pcie","bus_nr":252,"id":"pci.1","bus":"pcie.0","addr":"0x1"}' \ -device '{"driver":"pcie-root-port","port":0,"chassis":2,"id":"pci.2","bus":"pci.1","addr":"0x0"}' \ -device '{"driver":"arm-smmuv3","primary-bus":"pcie.0","id":"smmuv3.0"}' \ -device '{"driver":"arm-smmuv3","primary-bus":"pci.1","id":"smmuv3.1"}' \ ... -object '{"qom-type":"rng-random","id":"objrng0","filename":"/dev/urandom"}' \ -device '{"driver":"virtio-rng-pci","rng":"objrng0","id":"rng0","bus":"pci.2","addr":"0x0"}' \ -object '{"qom-type":"rng-random","id":"objrng1","filename":"/dev/urandom"}' \ -device '{"driver":"virtio-rng-pci","rng":"objrng1","id":"rng1","bus":"pcie.0","addr":"0x4"}' \ Changes from v1: - Moved parentIdx attribute under <driver> - Revised qemuxmlconfdata test cases to attach emulated devices This series is on Github: https://github.com/NathanChenNVIDIA/libvirt/tree/smmuv3Dev-no-accel-09-29-25 Thanks, Nathan [0] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/3PYS… [1] https://lore.kernel.org/qemu-devel/20250829082543.7680-1-skolothumtho@nvidi… Signed-off-by: Nathan Chen <nathanc(a)nvidia.com> Nathan Chen (4): qemu: add IOMMU model smmuv3Dev conf: Support multiple smmuv3Dev IOMMU devices tests: qemuxmlconfdata: provide smmuv3Dev sample XML and CLI args docs/formatdomain.rst | 9 +- src/conf/domain_conf.c | 101 +++++++-- src/conf/domain_conf.h | 11 +- src/conf/domain_validate.c | 58 +++-- src/conf/schemas/domaincommon.rng | 10 +- src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 15 +- src/qemu/qemu_command.c | 202 ++++++++++++------ src/qemu/qemu_domain_address.c | 33 +-- src/qemu/qemu_driver.c | 8 +- src/qemu/qemu_postparse.c | 11 +- src/qemu/qemu_validate.c | 18 +- .../iommu-smmuv3Dev.aarch64-latest.args | 41 ++++ .../iommu-smmuv3Dev.aarch64-latest.xml | 62 ++++++ tests/qemuxmlconfdata/iommu-smmuv3Dev.xml | 49 +++++ tests/qemuxmlconftest.c | 1 + 16 files changed, 499 insertions(+), 132 deletions(-) create mode 100644 tests/qemuxmlconfdata/iommu-smmuv3Dev.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/iommu-smmuv3Dev.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/iommu-smmuv3Dev.xml -- 2.43.0

4 10

AI coding policy question
by Cole Robinson 10 Oct '25

10 Oct '25

Hi all, I used claude code to generate (unsubmitted) patches, before I realized libvirt had a policy rejecting AI generated submissions. The patches add domaincapabilities sound model output. If you've looked at code in this area, you know it's largely boilerplate. I'd describe the changes as: + Add the generic domain_capabilities plumbing + Add more QEMU_CAPS flags for all sound devices, copying device names already identified in qemu_command.c + Map qemu caps to domcaps in qemu_capabilities.c + Use domcaps for validation in qemu_validate.c + regenerate testsuite output (and those are basically shorthand for the instructions I gave to the LLM). There does not appear to be a single novel line in the whole series. But OK, for legal safety sake libvirt will not accept these patches. That's fair. But in a copyright sense am I tainted by looking at the generated code? If I wanted to write the patches by hand they likely will end up looking identical, down to the character. Creates a weird scenario IMO. What to do? The patches are here, gaze not upon them lest ye too be corrupted: https://gitlab.com/crobinso/libvirt/-/tree/domcaps-sound Thanks, Cole

2 2

[PATCH 0/2] remove deprecated 'reconnect' options
by Vladimir Sementsov-Ogievskiy 10 Oct '25

10 Oct '25

They were deprecated in 9.2, now we can remove them. New options to use are reconnect-ms. v2: fixup docs and error messages Vladimir Sementsov-Ogievskiy (2): chardev: remove deprecated 'reconnect' option net/stream: remove deprecated 'reconnect' option chardev/char-socket.c | 24 +++++------------------- chardev/char.c | 3 --- docs/about/deprecated.rst | 15 --------------- docs/about/removed-features.rst | 22 ++++++++++++++++++++++ net/stream.c | 20 +++++--------------- qapi/char.json | 14 +------------- qapi/net.json | 13 +------------ 7 files changed, 34 insertions(+), 77 deletions(-) -- 2.48.1

6 13

[PATCH v2 0/7] tcg/mips: Remove support for 32-bit hosts
by Philippe Mathieu-Daudé 10 Oct '25

10 Oct '25

Since v1: - Removed N32/O32 ABIs (rth) - Do not remove tgen_qemu_ld2/st2 32-bit hosts are deprecated since v10.0. 2 releases later (as of v10.2) we can remove such code. Start with MIPS TCG backend. Remove related buildsys and testing. Philippe Mathieu-Daudé (7): docker: Remove 32-bit MIPS toolchain from debian-all-test image gitlab: Stop cross-testing for 32-bit MIPS hosts docker: Stop building 32-bit MIPS images tcg/mips: Remove support for O32 and N32 ABIs tcg/mips: Remove support for 32-bit hosts kvm/mips: Remove support for 32-bit hosts buildsys: Remove support for 32-bit MIPS hosts docs/about/deprecated.rst | 13 +- docs/about/removed-features.rst | 6 + configure | 9 - meson.build | 2 - tcg/mips/tcg-target-has.h | 2 - tcg/mips/tcg-target-reg-bits.h | 9 +- tcg/mips/tcg-target.c.inc | 292 +++--------------- .gitlab-ci.d/container-cross.yml | 6 - .gitlab-ci.d/crossbuilds.yml | 14 - common-user/host/mips/safe-syscall.inc.S | 35 --- tests/docker/Makefile.include | 2 +- .../dockerfiles/debian-all-test-cross.docker | 4 - .../dockerfiles/debian-mipsel-cross.docker | 187 ----------- tests/lcitool/refresh | 5 - 14 files changed, 56 insertions(+), 530 deletions(-) delete mode 100644 tests/docker/dockerfiles/debian-mipsel-cross.docker -- 2.51.0

3 13

Re: [PATCH RFC V6 03/24] hw/arm/virt: Clamp 'maxcpus' as-per machine's vCPU deferred online-capability
by Igor Mammedov 09 Oct '25

09 Oct '25

On Thu, 9 Oct 2025 12:32:15 +0000 Miguel Luis <miguel.luis(a)oracle.com> wrote: > Hi Salil, > > > On 1 Oct 2025, at 01:01, salil.mehta(a)opnsrc.net wrote: > > > > From: Salil Mehta <salil.mehta(a)huawei.com> > > > > To support a vCPU hot-add–like model on ARM, the virt machine may be setup with > > more CPUs than are active at boot. These additional CPUs are fully realized in > > KVM and listed in ACPI tables from the start, but begin in a disabled state. > > They can later be brought online or taken offline under host or platform policy > > control. The CPU topology is fixed at VM creation time and cannot change > > dynamically on ARM. Therefore, we must determine precisely the 'maxcpus' value > > that applies for the full lifetime of the VM. > > > > On ARM, this deferred online-capable model is only valid if: > > - The GIC version is 3 or higher, and > > - Each non-boot CPU’s GIC CPU Interface is marked “online-capable” in its > > ACPI GICC structure (UEFI ACPI Specification 6.5, §5.2.12.14, Table 5.37 > > “GICC CPU Interface Flags”), and > > - The chosen accelerator supports safe deferred CPU online: > > * TCG with multi-threaded TCG (MTTCG) enabled > > * KVM (on supported hosts) > > * Not HVF or QTest > > > > This patch sizes the machine’s max-possible CPUs during VM init: > > - If all conditions are satisfied, retain the full set of CPUs corresponding > > to (`-smp cpus` + `-smp disabledcpus`), allowing the additional (initially > > disabled) CPUs to participate in later policy-driven online. > > - Otherwise, clamp the max-possible CPUs to the boot-enabled count > > (`-smp disabledcpus=0` equivalent) to avoid advertising CPUs the guest can > > never use. > > > > A new MachineClass flag, `has_online_capable_cpus`, records whether the machine > > supports deferred vCPU online. This is usable by other machine types as well. > > > By the definition of > > * @has_hotpluggable_cpus: > * If true, board supports CPUs creation with -device/device_add. > > in include/hw/boards.h It should be fine to rename it to has_pluggable_cpus. But we should add support to arm/virt for -device/device_add cpu_foo, to avoid awkward -device-set and mangling of -smp. device_add in arm/virt case probably should be limited non hotplug usecase. > seems one could take advantage of MachineClass's has_hotpluggable_cpus variable > instead of creating a new has_online_capable_cpus one. > (Again, IMHO ‘online capable’ is ACPI nomenclature and doesn’t need to be brought > in MachineClass’s) the issue with has_hotpluggable_cpus might be QMP ABI, where libvirt migh use it to figure out if certain command are supported. CCing libvirt to check if that would break something. > > Variable which would be initialized in machvirt_init on an assignment based on > GIC version and/or wether there's inactive CPUs and proceed from there anyways, > making the default assignment in machine_virt_class_init superfluous. > > We're at hw/arm/virt and we know these CPUs are administratively power state > coordinated so admin_power_state_supported can still be set there in the > presence of inactive CPUs. > > Thanks > Miguel > > > > > Signed-off-by: Salil Mehta <salil.mehta(a)huawei.com> > > --- > > hw/arm/virt.c | 84 ++++++++++++++++++++++++++++++--------------- > > include/hw/boards.h | 1 + > > 2 files changed, 57 insertions(+), 28 deletions(-) > > > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > index ef6be3660f..76f21bd56a 100644 > > --- a/hw/arm/virt.c > > +++ b/hw/arm/virt.c > > @@ -2168,8 +2168,7 @@ static void machvirt_init(MachineState *machine) > > bool has_ged = !vmc->no_ged; > > unsigned int smp_cpus = machine->smp.cpus; > > unsigned int max_cpus = machine->smp.max_cpus; > > - > > - possible_cpus = mc->possible_cpu_arch_ids(machine); > > + DeviceClass *dc; > > > > /* > > * In accelerated mode, the memory map is computed earlier in kvm_type() > > @@ -2186,7 +2185,7 @@ static void machvirt_init(MachineState *machine) > > * we are about to deal with. Once this is done, get rid of > > * the object. > > */ > > - cpuobj = object_new(possible_cpus->cpus[0].type); > > + cpuobj = object_new(machine->cpu_type); > > armcpu = ARM_CPU(cpuobj); > > > > pa_bits = arm_pamax(armcpu); > > @@ -2201,6 +2200,57 @@ static void machvirt_init(MachineState *machine) > > */ > > finalize_gic_version(vms); > > > > + /* > > + * The maximum number of CPUs depends on the GIC version, or on how > > + * many redistributors we can fit into the memory map (which in turn > > + * depends on whether this is a GICv3 or v4). > > + */ > > + if (vms->gic_version == VIRT_GIC_VERSION_2) { > > + virt_max_cpus = GIC_NCPU; > > + } else { > > + virt_max_cpus = virt_redist_capacity(vms, VIRT_GIC_REDIST); > > + if (vms->highmem_redists) { > > + virt_max_cpus += virt_redist_capacity(vms, VIRT_HIGH_GIC_REDIST2); > > + } > > + } > > + > > + if ((tcg_enabled() && !qemu_tcg_mttcg_enabled()) || hvf_enabled() || > > + qtest_enabled() || vms->gic_version == VIRT_GIC_VERSION_2) { > > + max_cpus = machine->smp.max_cpus = smp_cpus; > > + if (mc->has_online_capable_cpus) { > > + if (vms->gic_version == VIRT_GIC_VERSION_2) { > > + warn_report("GICv2 does not support online-capable CPUs"); > > + } > > + mc->has_online_capable_cpus = false; > > + } > > + } > > + > > + if (mc->has_online_capable_cpus) { > > + max_cpus = smp_cpus + machine->smp.disabledcpus; > > + machine->smp.max_cpus = max_cpus; > > + } > > + > > + if (max_cpus > virt_max_cpus) { > > + error_report("Number of SMP CPUs requested (%d) exceeds max CPUs " > > + "supported by machine 'mach-virt' (%d)", > > + max_cpus, virt_max_cpus); > > + if (vms->gic_version != VIRT_GIC_VERSION_2 && !vms->highmem_redists) { > > + error_printf("Try 'highmem-redists=on' for more CPUs\n"); > > + } > > + > > + exit(1); > > + } > > + > > + dc = DEVICE_CLASS(object_class_by_name(machine->cpu_type)); > > + if (!dc) { > > + error_report("CPU type '%s' not registered", machine->cpu_type); > > + exit(1); > > + } > > + dc->admin_power_state_supported = mc->has_online_capable_cpus; > > + > > + /* uses smp.max_cpus to initialize all possible vCPUs */ > > + possible_cpus = mc->possible_cpu_arch_ids(machine); > > + > > if (vms->secure) { > > /* > > * The Secure view of the world is the same as the NonSecure, > > @@ -2235,31 +2285,6 @@ static void machvirt_init(MachineState *machine) > > vms->psci_conduit = QEMU_PSCI_CONDUIT_HVC; > > } > > > > - /* > > - * The maximum number of CPUs depends on the GIC version, or on how > > - * many redistributors we can fit into the memory map (which in turn > > - * depends on whether this is a GICv3 or v4). > > - */ > > - if (vms->gic_version == VIRT_GIC_VERSION_2) { > > - virt_max_cpus = GIC_NCPU; > > - } else { > > - virt_max_cpus = virt_redist_capacity(vms, VIRT_GIC_REDIST); > > - if (vms->highmem_redists) { > > - virt_max_cpus += virt_redist_capacity(vms, VIRT_HIGH_GIC_REDIST2); > > - } > > - } > > - > > - if (max_cpus > virt_max_cpus) { > > - error_report("Number of SMP CPUs requested (%d) exceeds max CPUs " > > - "supported by machine 'mach-virt' (%d)", > > - max_cpus, virt_max_cpus); > > - if (vms->gic_version != VIRT_GIC_VERSION_2 && !vms->highmem_redists) { > > - error_printf("Try 'highmem-redists=on' for more CPUs\n"); > > - } > > - > > - exit(1); > > - } > > - > > if (vms->secure && !tcg_enabled() && !qtest_enabled()) { > > error_report("mach-virt: %s does not support providing " > > "Security extensions (TrustZone) to the guest CPU", > > @@ -3245,6 +3270,9 @@ static void virt_machine_class_init(ObjectClass *oc, const void *data) > > hc->plug = virt_machine_device_plug_cb; > > hc->unplug_request = virt_machine_device_unplug_request_cb; > > hc->unplug = virt_machine_device_unplug_cb; > > + > > + mc->has_online_capable_cpus = true; > > + > > mc->nvdimm_supported = true; > > mc->smp_props.clusters_supported = true; > > mc->auto_enable_numa_with_memhp = true; > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index 2b182d7817..b27c2326a2 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -302,6 +302,7 @@ struct MachineClass { > > bool rom_file_has_mr; > > int minimum_page_bits; > > bool has_hotpluggable_cpus; > > + bool has_online_capable_cpus; > > bool ignore_memory_transaction_failures; > > int numa_mem_align_shift; > > const char * const *valid_cpu_types; > > -- > > 2.34.1 > > >

1 0

[PATCH] qemu: add support for dirty-sync-missed-zero-copy migration statistic
by Tejus GK 09 Oct '25

09 Oct '25

QEMU can report how many times a zerocopy send got deferred during a live migration with VIR_MIGRATE_ZEROCOPY enabled. Support the stat in libvirt as part of virDomainGetJobStats Signed-off-by: Tejus GK <tejus.gk(a)nutanix.com> --- include/libvirt/libvirt-domain.h | 9 +++++++++ src/qemu/qemu_domainjob.c | 6 ++++++ src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 2 ++ 4 files changed, 18 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 71bb49fe6c..2959f692bb 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -5842,6 +5842,15 @@ typedef enum { */ # define VIR_DOMAIN_JOB_VFIO_DATA_TRANSFERRED "vfio_data_transferred" +/** + * VIR_DOMAIN_JOB_MEMORY_MISSED_ZERO_COPY: + * virDomainGetJobStats field: number of times zerocopy send failed + * during a live migration, as VIR_TYPED_PARAM_ULLONG. + * + * Since: 11.9.0 + */ +# define VIR_DOMAIN_JOB_MEMORY_MISSED_ZERO_COPY "memory_missed_zero_copy" + /** * virConnectDomainEventGenericCallback: * @conn: the connection pointer diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index afea1ea57a..61441888e9 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -420,6 +420,12 @@ qemuDomainMigrationJobDataToParams(virDomainJobData *jobData, stats->vfio_data_transferred) < 0) goto error; + if (stats->ram_missed_zero_copy && + virTypedParamsAddULLong(&par, &npar, &maxpar, + VIR_DOMAIN_JOB_MEMORY_MISSED_ZERO_COPY, + stats->ram_missed_zero_copy) < 0) + goto error; + done: *type = virDomainJobStatusToType(jobData->status); *params = par; diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 8ef85ceb0a..90e6efaf09 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -838,6 +838,7 @@ struct _qemuMonitorMigrationStats { unsigned long long ram_page_size; unsigned long long ram_iteration; unsigned long long ram_postcopy_reqs; + unsigned long long ram_missed_zero_copy; unsigned long long disk_transferred; unsigned long long disk_remaining; diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 9caade7bc9..2b418d6cad 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3129,6 +3129,8 @@ qemuMonitorJSONGetMigrationStatsReply(virJSONValue *reply, &stats->ram_iteration)); ignore_value(virJSONValueObjectGetNumberUlong(ram, "postcopy-requests", &stats->ram_postcopy_reqs)); + ignore_value(virJSONValueObjectGetNumberUlong(ram, "dirty-sync-missed-zero-copy", + &stats->ram_missed_zero_copy)); } disk = virJSONValueObjectGetObject(ret, "disk"); -- 2.43.7

1 1

[PATCH 0/1] Refine the domain status saving logic
by yong.huang＠smartx.com 09 Oct '25

09 Oct '25

From: Hyman Huang <yong.huang(a)smartx.com> When saving the domain status in the path of the virDomainObjSave function, Libvirtd will omit the private data if the format interface is not provided. When the Libvirtd service is starting up and the driver has not yet been initialized, this behavior is justified. However, when the service is shutting down, the driver is being finalized and the interface is being released, a migration job or another job may call the qemuDomainSaveStatus and save the domain status at the same time. For the latter, this behavior causes the XML to be saved without private information (such as monitor path and qemuCaps), which is required for the Libvirtd service to manage a VM during startup. As a result, after restarting the Libvirtd service, a running VM that is being migrated previously might escape management. Thus, when formatting the status XML for a running virtual machine, we need to presume that the "privateData.format" interface is present. Add a thorough check in the virDomainObjSave path to make sure that private data in the status XML file always exists for the running VM so that we won't lose it after restart the Libvirtd service. Please review, thanks. Yong Hyman Huang (1): domain_conf: Do not omit private data when formatting the status XML src/conf/domain_conf.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) -- 2.27.0

3 11

[PATCH] qemuDomainGetStatsCpuProc: Use string constants for CPU stats
by Peter Krempa 08 Oct '25

08 Oct '25

From: Peter Krempa <pkrempa(a)redhat.com> Commit 947306957e9 added the constants and fixed other uses but didn't fix qemuDomainGetStatsCpuProc. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ac72ea5cb0..d26c8997bf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17054,9 +17054,9 @@ qemuDomainGetStatsCpuProc(virDomainObj *vm, return; } - virTypedParamListAddULLong(params, cpuTime, "cpu.time"); - virTypedParamListAddULLong(params, userTime, "cpu.user"); - virTypedParamListAddULLong(params, sysTime, "cpu.system"); + virTypedParamListAddULLong(params, cpuTime, VIR_DOMAIN_STATS_CPU_TIME); + virTypedParamListAddULLong(params, userTime, VIR_DOMAIN_STATS_CPU_USER); + virTypedParamListAddULLong(params, sysTime, VIR_DOMAIN_STATS_CPU_SYSTEM); } -- 2.51.0

2 1

[PATCH] network: pf: split flush and rules commands
by Roman Bogorodskiy 08 Oct '25

08 Oct '25

Current implementation uses a single command to flush the old rules and create new ones. This is not optimal because if flush fails for some non-critical reasons (e.g. because the anchor didn't previously exist), it will block rules creation and network start. Split this command into two: one for flush, and one for rules creation. Also, don't fail if the flush command fails. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/network/network_pf.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/network/network_pf.c b/src/network/network_pf.c index ce4461c999..a39eef5fa2 100644 --- a/src/network/network_pf.c +++ b/src/network/network_pf.c @@ -168,6 +168,7 @@ pfAddNatFirewallRules(virNetworkDef *def, g_autofree const char *forwardIf = g_strdup(virNetworkDefForwardIf(def, 0)); g_auto(virBuffer) pf_rules_buf = VIR_BUFFER_INITIALIZER; g_autoptr(virCommand) cmd = virCommandNew(PFCTL); + g_autoptr(virCommand) flush_cmd = virCommandNew(PFCTL); virPortRange *portRange = &def->forward.port; g_autofree char *portRangeStr = NULL; @@ -240,13 +241,25 @@ pfAddNatFirewallRules(virNetworkDef *def, "block on %s\n", def->bridge); - /* pfctl -a libvirt/default -F all -f - */ + /* pfctl -a libvirt/default -f - */ virCommandAddArg(cmd, "-a"); virCommandAddArgFormat(cmd, "libvirt/%s", def->name); - virCommandAddArgList(cmd, "-F", "all", "-f", "-", NULL); + virCommandAddArgList(cmd, "-f", "-", NULL); virCommandSetInputBuffer(cmd, virBufferContentAndReset(&pf_rules_buf)); + /* pfctl -a libvirt/default -F all */ + /* Flush rules as a separate command, so when it fails, e.g. because the + * anchor didn't exist, we still proceed with rules creation */ + virCommandAddArg(flush_cmd, "-a"); + virCommandAddArgFormat(flush_cmd, "libvirt/%s", def->name); + virCommandAddArgList(flush_cmd, "-F", "all", NULL); + + if (virCommandRun(flush_cmd, NULL) < 0) { + VIR_WARN("Failed to flush firewall rules for network %s", + def->name); + } + if (virCommandRun(cmd, NULL) < 0) { VIR_WARN("Failed to create firewall rules for network %s", def->name); -- 2.51.0

2 1