- Devel - libvirt List Archives

[PATCH v3 0/5] logging: add log cleanup for obsolete domains
by Oleg Vasilev 06 Feb '23

06 Feb '23

Presently, logs from deleted domains remain forever. Particular motivation comes from the case when libguestfs has repeatedly created transient VMs, which in turn created plenty of logs. This takes up space and lots of files troubles filesystem navigation. More motivation in [1]. Patch solving same problem in [2]. Changes in v3: codestyle cleanup, minor fixes Changes in v2: substantial rework according to Martin Kletzander's comments v1: https://www.mail-archive.com/libvir-list@redhat.com/msg233754.html v2: https://www.spinics.net/linux/fedora/libvir/msg236081.html [1]: https://listman.redhat.com/archives/libvir-list/2022-February/228149.html [2]: https://listman.redhat.com/archives/libvir-list/2022-February/msg00865.html CC: Martin Kletzander <mkletzan(a)redhat.com> Oleg Vasilev (5): logging: refactor to store config inside log handler logging: move virLogHandler to header logging: add configuration for future log cleaner logging: add log cleanup for obsolete domains logging: use the log cleaner po/POTFILES | 1 + src/logging/log_cleaner.c | 268 +++++++++++++++++++++++++++++++ src/logging/log_cleaner.h | 29 ++++ src/logging/log_daemon.c | 6 +- src/logging/log_daemon_config.c | 9 ++ src/logging/log_daemon_config.h | 3 + src/logging/log_handler.c | 64 +++----- src/logging/log_handler.h | 50 ++++-- src/logging/meson.build | 1 + src/logging/test_virtlogd.aug.in | 2 + src/logging/virtlogd.aug | 2 + src/logging/virtlogd.conf | 14 ++ 12 files changed, 391 insertions(+), 58 deletions(-) create mode 100644 src/logging/log_cleaner.c create mode 100644 src/logging/log_cleaner.h -- 2.39.1

3 10

[PATCH] .gitignore: Ignore cscope and other *tags files
by Martin Kletzander 06 Feb '23

06 Feb '23

Commit f7114e61dbc2 cleaned up way too much and now that I have cscope working again I noticed there are some files that ought to stay ignored. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- .gitignore | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 469539134280..61ea7779b02b 100644 --- a/.gitignore +++ b/.gitignore @@ -19,7 +19,17 @@ __pycache__/ # libvirt related ignores /build/ /ci/scratch/ -tags + +# *tags and cscope files +/GPATH +/GRTAGS +/GTAGS +/TAGS +/cscope.files +/cscope.in.out +/cscope.out +/cscope.po.out +/tags # clangd related ignores .clangd -- 2.39.1

5 6

[PATCH 0/3] qemu: Fix setting TPM state seclabels wrt save/restore
by Michal Privoznik 06 Feb '23

06 Feb '23

*** BLURB HERE *** Michal Prívozník (3): qemuProcessStop: Fix detection of outgoing migration for external devices qemuExtTPMStop: Restore TPM state label more often qemuProcessLaunch: Tighten rules for external devices wrt incoming migration src/qemu/qemu_process.c | 11 +++++++++-- src/qemu/qemu_tpm.c | 2 +- 2 files changed, 10 insertions(+), 3 deletions(-) -- 2.39.1

3 5

[libvirt PATCH v2 0/8] Extract the integration job commands to a shell script
by Erik Skultety 06 Feb '23

06 Feb '23

Using shell scripts rather than inlining shell commands to YAML feels more natural, more readable, and will keep all different variations of execution consistent. Essentially the only disadvantage is that we won't see each command listed one-by-one in gitlab's log output (unless we set -x that is), but given that shell would complain if something was wrong with the script, it's fairly easy to identify the problem. Here's a test pipeline after the change: https://gitlab.com/eskultety/libvirt/-/pipelines/759277200 Since v1: - 3/7 - reworded commit message as requested - 4/7 was dropped - point the SCRATCH_DIR to /var/tmp instead of /tmp to not be limited by the size of ramdisk mounted in there Erik Skultety (8): syntax-check: Drop the shell's 'check for minus' rule ci: Move the SCRATCH_DIR from /tmp ci: integration: Extract several hidden job definitions to a script ci: integration: Drop the 'install-deps' hidden job and reference ci: integration-template: Drop the '-lt Fedora 35' check ci: integration.sh: Add/Rewrite/Reformat commentaries ci: integration.sh: Replace 'test' with '[' operator ci: integration.sh: Define the SCRATCH_DIR variable for local execution build-aux/syntax-check.mk | 9 -------- ci/integration-template.yml | 44 +++-------------------------------- ci/integration.sh | 46 +++++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+), 50 deletions(-) create mode 100644 ci/integration.sh -- 2.39.1

1 9

[PATCH 0/5] Various (json related) cleanups
by Peter Krempa 06 Feb '23

06 Feb '23

Some more patches from old branches that I didn't get around finishing before. Peter Krempa (5): virbitmap: Allow NULL bitmap in functions returning index of a set/clear bit qemuMonitorJSONQueryStats: Simplify logic to construct 'provider_list' qemu_monitor_json: Replace simplify fetching Array from JSON object qemu: agent: Use virJSONValueObjectGetArray qemuDomainGetStatsVcpu: Refactor cleanup src/qemu/qemu_agent.c | 29 ++++--------------- src/qemu/qemu_driver.c | 22 ++++++--------- src/qemu/qemu_monitor_json.c | 54 ++++++++++++++---------------------- src/util/virbitmap.c | 9 ++++++ src/util/virbitmap.h | 9 ++---- 5 files changed, 46 insertions(+), 77 deletions(-) -- 2.39.1

2 6

Unable to use Routed (brouter) method with netmask 255.255.255.255 in both host and vm
by jose.r.r＠metztli.com 04 Feb '23

04 Feb '23

Hello- Assuming I have the host /etc/network/interfaces in Debian Bullseye as follows: ----------------------------------------------------- auto enpXYs0 iface eth0 inet static address mn.opq.rst.xy # Main IP netmask 255.255.255.255 pointopoint (Gateway IP) gateway (Gateway IP) auto virbr0 iface virbr0 inet static address mn.opq.rst.xy #Main IP netmask 255.255.255.255 bridge_ports none bridge_stp off bridge_fd 0 pre-up brctl addbr virbr0 # Additional IP for VM below: only mn.opq octets match main IP up ip route add mn.opq.uw.z/32 dev virbr0 down ip route del mn.opq.uw.z/32 dev virbr0 ---------------------------------------------------- Using the above configuration, ip addr shows the main host IP address as 'peer' with its gateway IP. Please, see: < https://docs.hetzner.com/robot/dedicated-server/network/net-config-debian-u… > What kind of /etc/libvirt/qemu/network/mytestnetwork.xml file should I create for a virtual machine installation connected via libvirtd? Please note that nftables are in use and possibly I should edit its configuration file to add the IP mn.opq.uw.z of the virtual machine and thus enable the VM to utilize the main host IP as a gateway. Currently I have mytestnetwork.xml which contains: <network> <name>mytestnetwork</name> <uuid>char-string</uuid> <forward mode='bridge'/> <bridge name='virbr0'/> </network> The VirtManager GUI advances the installation of the Debian OS in the VM but even if I have provided the main host IP as its gateway IP it cannot fetch the debian packages from its repository, i.e., there is no connection to the outside world. Any insight is appreciated. -- Best Professional Regards. -- Jose R R http://metztli.it --------------------------------------------------------------------------------------------- Download Metztli Reiser4: Debian Buster w/ Linux 5.16.20 AMD64 --------------------------------------------------------------------------------------------- feats ZSTD compression https://sf.net/projects/metztli-reiser4/ ------------------------------------------------------------------------------------------- Official current Reiser4 resources: https://reiser4.wiki.kernel.org/

1 0

[PATCH 0/2] conf: Turn virDomainDeviceDef->type into proper type
by Peter Krempa 03 Feb '23

03 Feb '23

Some more patch necromancy. Pipeline: https://gitlab.com/pipo.sk/libvirt/-/pipelines/765613613 Peter Krempa (2): virDomainDeviceDefParse: Separate code for parsing type conf: Use proper type for 'type' field of struct _virDomainDeviceDef src/conf/domain_conf.c | 43 ++++++---- src/conf/domain_conf.h | 2 +- src/hyperv/hyperv_driver.c | 28 ++++++- src/libxl/libxl_driver.c | 158 ++++++++++++++++++++++++++++++++++-- src/lxc/lxc_driver.c | 159 +++++++++++++++++++++++++++++++++++-- src/vz/vz_sdk.c | 81 ++++++++++++++++++- tests/qemuhotplugtest.c | 76 +++++++++++++++++- 7 files changed, 512 insertions(+), 35 deletions(-) -- 2.39.1

2 3

[PATCH 0/2] tools: A few small fixes for virt-qemu-sev-validate
by Jim Fehlig 03 Feb '23

03 Feb '23

See patches for details. Jim Fehlig (2): docs: Fix examples in virt-qemu-sev-validate man page tools: Fix detection of remote libvirt access in virt-qemu-sev-validate docs/manpages/virt-qemu-sev-validate.rst | 24 ++++++++++++------------ tools/virt-qemu-sev-validate | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) -- 2.38.1

2 3

[PATCH 0/7] Remove last instances of looped XML element lookup from domain_conf.c
by Peter Krempa 02 Feb '23

02 Feb '23

Had this around for a while but it needed some finishing touches. This ousts the last loop-based XML parser iterating over XML nodes and replaces it by something more modern, fixing a few bugs i the process and cleaning stuff up. There are a few of such parsers still around e.g in the network XML parsing part. Peter Krempa (7): virPCIDeviceAddressParseXML: Use virXMLNodeGetSubelement to find 'zpci' virNetDevVPortProfileParse: Use virXMLNodeGetSubelement to find '<parameters>' virNetworkDHCPRangeDefParseXML: Use virXMLNodeGetSubelement to find 'lease' virNetworkDHCPHostDefParseXML: Use virXMLNodeGetSubelement to find 'lease' virBitmapIsBitSet: Allow NULL bitmap qemustatusxml2xmltest: Add test data for testing '<origstates>' of PCI hostdev conf: Store 'origstates' of PCI hostdevs in a bitmap src/conf/device_conf.c | 16 +--- src/conf/domain_conf.c | 97 +++++++++++------------ src/conf/domain_conf.h | 31 +++----- src/conf/netdev_vport_profile_conf.c | 20 ++--- src/conf/network_conf.c | 28 ++----- src/conf/virconftypes.h | 2 - src/hypervisor/virhostdev.c | 25 +++--- src/util/virbitmap.c | 4 +- src/util/virbitmap.h | 2 +- tests/qemustatusxml2xmldata/modern-in.xml | 12 +++ 10 files changed, 107 insertions(+), 130 deletions(-) -- 2.39.1

3 11

[libvirt PATCH] tools: use g_autofree more
by Ján Tomko 01 Feb '23

01 Feb '23

Remove some obvious uses of VIR_FREE in favor of automatic cleanup. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- tools/virsh-domain-monitor.c | 5 +---- tools/virsh-domain.c | 37 +++++++++---------------------- tools/virsh-network.c | 6 ++--- tools/virsh-nwfilter.c | 3 +-- tools/virt-admin.c | 13 ++++------- tools/virt-host-validate-common.c | 6 ++--- 6 files changed, 20 insertions(+), 50 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index f89118f64f..c2134faba1 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -1213,7 +1213,6 @@ cmdDominfo(vshControl *ctl, const vshCmd *cmd) virDomainInfo info; g_autoptr(virshDomain) dom = NULL; virSecurityModel secmodel; - virSecurityLabelPtr seclabel; int persistent = 0; bool ret = true; int autostart; @@ -1301,6 +1300,7 @@ cmdDominfo(vshControl *ctl, const vshCmd *cmd) } else { /* Only print something if a security model is active */ if (secmodel.model[0] != '\0') { + g_autofree virSecurityLabelPtr seclabel = NULL; vshPrint(ctl, "%-15s %s\n", _("Security model:"), secmodel.model); vshPrint(ctl, "%-15s %s\n", _("Security DOI:"), secmodel.doi); @@ -1308,15 +1308,12 @@ cmdDominfo(vshControl *ctl, const vshCmd *cmd) seclabel = g_new0(virSecurityLabel, 1); if (virDomainGetSecurityLabel(dom, seclabel) == -1) { - VIR_FREE(seclabel); return false; } else { if (seclabel->label[0] != '\0') vshPrint(ctl, "%-15s %s (%s)\n", _("Security label:"), seclabel->label, seclabel->enforcing ? "enforcing" : "permissive"); } - - VIR_FREE(seclabel); } } diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 59b2b3ce60..a4abcb1b03 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -366,7 +366,7 @@ cmdAttachDevice(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshDomain) dom = NULL; const char *from = NULL; - char *buffer; + g_autofree char *buffer = NULL; int rv; unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; bool current = vshCommandOptBool(cmd, "current"); @@ -404,8 +404,6 @@ cmdAttachDevice(vshControl *ctl, const vshCmd *cmd) else rv = virDomainAttachDevice(dom, buffer); - VIR_FREE(buffer); - if (rv < 0) { vshError(ctl, _("Failed to attach device from %s"), from); return false; @@ -2364,7 +2362,7 @@ cmdBlockcopy(vshControl *ctl, const vshCmd *cmd) const char *path = NULL; int abort_flags = 0; const char *xml = NULL; - char *xmlstr = NULL; + g_autofree char *xmlstr = NULL; bool print_xml = vshCommandOptBool(cmd, "print-xml"); virTypedParameterPtr params = NULL; virshBlockJobWaitData *bjWait = NULL; @@ -2567,7 +2565,6 @@ cmdBlockcopy(vshControl *ctl, const vshCmd *cmd) ret = true; cleanup: - VIR_FREE(xmlstr); virTypedParamsFree(params, nparams); virshBlockJobWaitFree(bjWait); return ret; @@ -5624,7 +5621,7 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd) bool ret = false; bool created = false; bool generated = false; - char *mime = NULL; + g_autofree char *mime = NULL; virshControl *priv = ctl->privData; virshStreamCallbackData cbdata; @@ -5688,7 +5685,6 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd) unlink(file); if (generated) VIR_FREE(file); - VIR_FREE(mime); return ret; } @@ -7432,9 +7428,8 @@ cmdGuestvcpus(vshControl *ctl, const vshCmd *cmd) goto cleanup; for (i = 0; i < nparams; i++) { - char *str = vshGetTypedParamValue(ctl, &params[i]); + g_autofree char *str = vshGetTypedParamValue(ctl, &params[i]); vshPrint(ctl, "%-15s: %s\n", params[i].field, str); - VIR_FREE(str); } } @@ -8305,7 +8300,7 @@ cmdDefine(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshDomain) dom = NULL; const char *from = NULL; - char *buffer; + g_autofree char *buffer = NULL; unsigned int flags = 0; virshControl *priv = ctl->privData; @@ -8322,7 +8317,6 @@ cmdDefine(vshControl *ctl, const vshCmd *cmd) dom = virDomainDefineXMLFlags(priv->conn, buffer, flags); else dom = virDomainDefineXML(priv->conn, buffer); - VIR_FREE(buffer); if (!dom) { vshError(ctl, _("Failed to define domain from %s"), from); @@ -10340,7 +10334,7 @@ cmdQemuAgentCommand(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshDomain) dom = NULL; bool ret = false; - char *guest_agent_cmd = NULL; + g_autofree char *guest_agent_cmd = NULL; char *result = NULL; int timeout = VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT; int judge = 0; @@ -10405,7 +10399,6 @@ cmdQemuAgentCommand(vshControl *ctl, const vshCmd *cmd) cleanup: VIR_FREE(result); - VIR_FREE(guest_agent_cmd); return ret; } @@ -11185,7 +11178,7 @@ doMigrate(void *opaque) if (vshCommandOptStringReq(ctl, cmd, "migrate-disks", &opt) < 0) goto out; if (opt) { - char **val = NULL; + g_autofree char **val = NULL; val = g_strsplit(opt, ",", 0); @@ -11194,28 +11187,22 @@ doMigrate(void *opaque) &maxparams, VIR_MIGRATE_PARAM_MIGRATE_DISKS, (const char **)val) < 0) { - VIR_FREE(val); goto save_error; } - - VIR_FREE(val); } if (vshCommandOptStringReq(ctl, cmd, "comp-methods", &opt) < 0) goto out; if (opt) { - char **val = g_strsplit(opt, ",", 0); + g_autofree char **val = g_strsplit(opt, ",", 0); if (virTypedParamsAddStringList(&params, &nparams, &maxparams, VIR_MIGRATE_PARAM_COMPRESSION, (const char **)val) < 0) { - VIR_FREE(val); goto save_error; } - - VIR_FREE(val); } if ((rv = vshCommandOptInt(ctl, cmd, "comp-mt-level", &intOpt)) < 0) { @@ -11257,7 +11244,7 @@ doMigrate(void *opaque) if (vshCommandOptStringReq(ctl, cmd, "xml", &opt) < 0) goto out; if (opt) { - char *xml; + g_autofree char *xml = NULL; if (virFileReadAll(opt, VSH_MAX_XML_FILE, &xml) < 0) { vshError(ctl, _("cannot read file '%s'"), opt); @@ -11266,16 +11253,14 @@ doMigrate(void *opaque) if (virTypedParamsAddString(&params, &nparams, &maxparams, VIR_MIGRATE_PARAM_DEST_XML, xml) < 0) { - VIR_FREE(xml); goto save_error; } - VIR_FREE(xml); } if (vshCommandOptStringReq(ctl, cmd, "persistent-xml", &opt) < 0) goto out; if (opt) { - char *xml; + g_autofree char *xml = NULL; if (virFileReadAll(opt, VSH_MAX_XML_FILE, &xml) < 0) { vshError(ctl, _("cannot read file '%s'"), opt); @@ -11284,10 +11269,8 @@ doMigrate(void *opaque) if (virTypedParamsAddString(&params, &nparams, &maxparams, VIR_MIGRATE_PARAM_PERSIST_XML, xml) < 0) { - VIR_FREE(xml); goto save_error; } - VIR_FREE(xml); } if ((rv = vshCommandOptInt(ctl, cmd, "auto-converge-initial", &intOpt)) < 0) { diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 004719dad6..13f2e729eb 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -412,7 +412,7 @@ cmdNetworkInfo(vshControl *ctl, const vshCmd *cmd) int autostart; int persistent = -1; int active = -1; - char *bridge = NULL; + g_autofree char *bridge = NULL; if (!(network = virshCommandOptNetwork(ctl, cmd, NULL))) return false; @@ -441,7 +441,6 @@ cmdNetworkInfo(vshControl *ctl, const vshCmd *cmd) if (bridge) vshPrint(ctl, "%-15s %s\n", _("Bridge:"), bridge); - VIR_FREE(bridge); return true; } @@ -1500,7 +1499,7 @@ cmdNetworkPortCreate(vshControl *ctl, const vshCmd *cmd) virNetworkPortPtr port = NULL; const char *from = NULL; bool ret = false; - char *buffer = NULL; + g_autofree char *buffer = NULL; g_autoptr(virshNetwork) network = NULL; unsigned int flags = 0; @@ -1533,7 +1532,6 @@ cmdNetworkPortCreate(vshControl *ctl, const vshCmd *cmd) ret = true; cleanup: - VIR_FREE(buffer); if (port) virNetworkPortFree(port); return ret; diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index d4112c8620..98380b452d 100644 --- a/tools/virsh-nwfilter.c +++ b/tools/virsh-nwfilter.c @@ -516,7 +516,7 @@ cmdNWFilterBindingCreate(vshControl *ctl, const vshCmd *cmd) { virNWFilterBindingPtr binding; const char *from = NULL; - char *buffer; + g_autofree char *buffer = NULL; unsigned int flags = 0; virshControl *priv = ctl->privData; @@ -530,7 +530,6 @@ cmdNWFilterBindingCreate(vshControl *ctl, const vshCmd *cmd) return false; binding = virNWFilterBindingCreateXML(priv->conn, buffer, flags); - VIR_FREE(buffer); if (!binding) { vshError(ctl, _("Failed to create network filter from %s"), from); diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 85b010b95f..8baf9636d3 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -73,7 +73,7 @@ vshAdmCatchDisconnect(virAdmConnectPtr conn G_GNUC_UNUSED, vshControl *ctl = opaque; const char *str = "unknown reason"; virErrorPtr error; - char *uri = NULL; + g_autofree char *uri = NULL; if (reason == VIR_CONNECT_CLOSE_REASON_CLIENT) return; @@ -97,8 +97,6 @@ vshAdmCatchDisconnect(virAdmConnectPtr conn G_GNUC_UNUSED, } vshError(ctl, _(str), NULLSTR(uri)); - VIR_FREE(uri); - virErrorRestore(&error); } @@ -183,7 +181,7 @@ static const vshCmdInfo info_uri[] = { static bool cmdURI(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED) { - char *uri; + g_autofree char *uri = NULL; vshAdmControl *priv = ctl->privData; uri = virAdmConnectGetURI(priv->conn); @@ -193,7 +191,6 @@ cmdURI(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED) } vshPrint(ctl, "%s\n", uri); - VIR_FREE(uri); return true; } @@ -328,7 +325,7 @@ cmdSrvList(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED) int nsrvs = 0; size_t i; bool ret = false; - char *uri = NULL; + g_autofree char *uri = NULL; virAdmServerPtr *srvs = NULL; vshAdmControl *priv = ctl->privData; g_autoptr(vshTable) table = NULL; @@ -365,7 +362,6 @@ cmdSrvList(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED) virAdmServerFree(srvs[i]); VIR_FREE(srvs); } - VIR_FREE(uri); return ret; } @@ -702,9 +698,8 @@ cmdClientInfo(vshControl *ctl, const vshCmd *cmd) vshAdmClientTransportToString(virAdmClientGetTransport(clnt))); for (i = 0; i < nparams; i++) { - char *str = vshGetTypedParamValue(ctl, &params[i]); + g_autofree char *str = vshGetTypedParamValue(ctl, &params[i]); vshPrint(ctl, "%-15s: %s\n", params[i].field, str); - VIR_FREE(str); } ret = true; diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 2ac96d1e19..a41bb346d2 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -56,7 +56,7 @@ void virHostMsgCheck(const char *prefix, ...) { va_list args; - char *msg; + g_autofree char *msg = NULL; if (quiet) return; @@ -66,7 +66,6 @@ void virHostMsgCheck(const char *prefix, va_end(args); fprintf(stdout, _("%6s: Checking %-60s: "), prefix, msg); - VIR_FREE(msg); } static bool virHostMsgWantEscape(void) @@ -114,7 +113,7 @@ void virHostMsgFail(virHostValidateLevel level, ...) { va_list args; - char *msg; + g_autofree char *msg = NULL; if (quiet) return; @@ -129,7 +128,6 @@ void virHostMsgFail(virHostValidateLevel level, else fprintf(stdout, "%s (%s)\n", _(failMessages[level]), msg); - VIR_FREE(msg); } -- 2.39.0

2 1