- Devel - libvirt List Archives

[RFC PATCH 0/3] qemu: Add support for control of persistent reservation migration
by Peter Krempa 15 Jan '26

15 Jan '26

Add support for migration of persistent reservations. Depends on RFC qemu patches: https://mail.gnu.org/archive/html/qemu-block/2026-01/msg00159.html Applies on top of my patches for new capabilities. Caps dump in 1/3 is based on a local build and thus will be replaced once I'll be doing an official update. Peter Krempa (3): DO_NOT_PUSH: qemucapabilitiestest: Regenerate with 'migrate-pr' patches qemu: capabilities: Introduce QEMU_CAPS_DEVICE_SCSI_BLOCK_MIGRATE_PR qemu: Implement support for persistent reservation migration control docs/formatdomain.rst | 3 +++ src/conf/domain_conf.c | 21 +++++++++++++++++++ src/conf/schemas/storagecommon.rng | 5 +++++ src/conf/storage_source_conf.c | 10 +++++++++ src/conf/storage_source_conf.h | 2 ++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 4 ++++ src/qemu/qemu_validate.c | 16 ++++++++++++++ .../caps_11.0.0_x86_64.replies | 8 ++++++- .../caps_11.0.0_x86_64.xml | 3 ++- ...irtio-scsi-reservations.x86_64-latest.args | 2 +- .../disk-virtio-scsi-reservations.xml | 2 +- 13 files changed, 75 insertions(+), 4 deletions(-) -- 2.52.0

1 3

[PATCH v2] domain_logcontext: Don't assume remote driver is always available
by Michal Privoznik 15 Jan '26

15 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> Some functions inside of domain_logcontext.c call virLogManager APIs. But that one is available only when remote driver is enabled. Therefore, make domain_logcontext.c conditional, just like log_manager.c is: if config.has('WITH_REMOTE'). Resolves: https://gitlab.com/libvirt/libvirt/-/issues/842 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/7HSM… diff to v1: - Instead of #ifdef-ing virLogManager APIs, just make the whole domain_logcontext.c compiled conditionally. src/hypervisor/meson.build | 7 ++++++- src/libvirt_logging.syms | 7 +++++++ src/libvirt_private.syms | 7 ------- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/hypervisor/meson.build b/src/hypervisor/meson.build index c32703af88..91eaefbebc 100644 --- a/src/hypervisor/meson.build +++ b/src/hypervisor/meson.build @@ -2,11 +2,16 @@ hypervisor_sources = [ 'domain_cgroup.c', 'domain_driver.c', 'domain_interface.c', - 'domain_logcontext.c', 'virclosecallbacks.c', 'virhostdev.c', ] +if conf.has('WITH_REMOTE') + hypervisor_sources += [ + 'domain_logcontext.c' + ] +endif + stateful_driver_source_files += files(hypervisor_sources) hypervisor_lib = static_library( diff --git a/src/libvirt_logging.syms b/src/libvirt_logging.syms index e2a1a7109f..5e867703cb 100644 --- a/src/libvirt_logging.syms +++ b/src/libvirt_logging.syms @@ -3,6 +3,13 @@ # +# hypervisor/domain_logcontext.h +domainLogContextGetWriteFD; +domainLogContextMarkPosition; +domainLogContextNew; +domainLogContextReadFiltered; +domainLogContextWrite; + # logging/log_manager.h virLogManagerDomainAppendMessage; virLogManagerDomainGetLogFilePosition; diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4e57e4a8f6..51f4d6db24 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1695,13 +1695,6 @@ virDomainInterfaceStopDevice; virDomainInterfaceStopDevices; virDomainInterfaceVportRemove; -# hypervisor/domain_logcontext.h -domainLogContextGetWriteFD; -domainLogContextMarkPosition; -domainLogContextNew; -domainLogContextReadFiltered; -domainLogContextWrite; - # hypervisor/virclosecallbacks.h virCloseCallbacksDomainAdd; virCloseCallbacksDomainAlloc; -- 2.52.0

2 1

[PATCH] domain_logcontext: Don't assume remote driver is always available
by Michal Privoznik 15 Jan '26

15 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> Some functions inside of domain_logcontext call virLogManager APIs. But that one is available only when remote driver is enabled (from src/logging/meson.build): if conf.has('WITH_REMOTE') log_driver_lib = static_library( 'virt_log_driver', [ log_driver_sources, log_protocol_generated, ], ... Guard calls to virLogManager APIs with #ifdef WITH_REMOTE. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/842 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/hypervisor/domain_logcontext.c | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/src/hypervisor/domain_logcontext.c b/src/hypervisor/domain_logcontext.c index 41d1bbdf64..92f942eb81 100644 --- a/src/hypervisor/domain_logcontext.c +++ b/src/hypervisor/domain_logcontext.c @@ -71,7 +71,9 @@ domainLogContextFinalize(GObject *object) domainLogContext *ctxt = DOMAIN_LOG_CONTEXT(object); VIR_DEBUG("ctxt=%p", ctxt); +#ifdef WITH_REMOTE virLogManagerFree(ctxt->manager); +#endif VIR_FREE(ctxt->path); VIR_FORCE_CLOSE(ctxt->writefd); VIR_FORCE_CLOSE(ctxt->readfd); @@ -82,8 +84,8 @@ domainLogContextFinalize(GObject *object) domainLogContext * domainLogContextNew(bool stdioLogD, char *logDir, - const char *driver_name, - virDomainObj *vm, + const char *driver_name G_GNUC_UNUSED, + virDomainObj *vm G_GNUC_UNUSED, bool privileged, const char *basename) { @@ -96,6 +98,7 @@ domainLogContextNew(bool stdioLogD, ctxt->path = g_strdup_printf("%s/%s.log", logDir, basename); if (stdioLogD) { +#ifdef WITH_REMOTE ctxt->manager = virLogManagerNew(privileged); if (!ctxt->manager) goto error; @@ -110,6 +113,11 @@ domainLogContextNew(bool stdioLogD, &ctxt->pos); if (ctxt->writefd < 0) goto error; +#else /* !WITH_REMOTE */ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("logd stdio handler is not supported")); + goto error; +#endif /* !WITH_REMOTE */ } else { if ((ctxt->writefd = open(ctxt->path, O_WRONLY | O_CREAT | O_APPEND, S_IRUSR | S_IWUSR)) < 0) { virReportSystemError(errno, _("failed to create logfile %1$s"), @@ -202,6 +210,7 @@ domainLogContextRead(domainLogContext *ctxt, (unsigned long long)ctxt->pos); if (ctxt->manager) { +#ifdef WITH_REMOTE buf = virLogManagerDomainReadLogFile(ctxt->manager, ctxt->path, ctxt->inode, @@ -211,6 +220,11 @@ domainLogContextRead(domainLogContext *ctxt, if (!buf) return -1; buflen = strlen(buf); +#else /* !WITH_REMOTE */ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("logd stdio handler is not supported")); + return -1; +#endif /* !WITH_REMOTE */ } else { ssize_t got; @@ -315,14 +329,17 @@ domainLogContextGetWriteFD(domainLogContext *ctxt) void domainLogContextMarkPosition(domainLogContext *ctxt) { - if (ctxt->manager) + if (ctxt->manager) { +#ifdef WITH_REMOTE virLogManagerDomainGetLogFilePosition(ctxt->manager, ctxt->path, 0, &ctxt->inode, &ctxt->pos); - else +#endif /* WITH_REMOTE */ + } else { ctxt->pos = lseek(ctxt->writefd, 0, SEEK_END); + } } -- 2.52.0

3 2

Questions about device attach/detach semantics
by pascal.scholz＠cyberus-technology.de 15 Jan '26

15 Jan '26

Hi all, I'm part of Cyberus Technology and currently working on the Cloud Hypervisor driver backend of libvirt. We are currently implementing a feature to fix device bus addresses in the domain definitions for PCI devices, guaranteeing that devices remain available at the same address even after live migration and restarts, and across libvirt versions. In doing so, some questions came up about the intended semantics of the `--persistent` and `--live` flags in virsh commands and the synchronization between runtime and persistent configuration. So we wanted to ask you these questions. Our first question revolves around `virsh mirgate --persistent`. The documentation says `leaves the domain persistent on the destination host physical machine`, but what domain definition is used from the source side to migrate the VM? Is it that the live definition is sent, then migrated, and persisted on the receiver side? Or is the source's persistent XML sent to the receiver, and the receiver’s live definition created from the persistent definition received? The second question is about synchronization between live and persistent configuration. To achieve the goal of keeping the same device at the same PCI bus address across restarts and live migrations, to our understanding, we have to ensure that one device is written to both domain definitions with the same PCI bus address. Is this right, or do we miss something? The next questions are about attaching/detaching devices (live). With respect to our intention to implement fixed PCI bus addresses for devices, what would be the right semantics for the following cases? Are they even valid? The source code of the qemu driver leaves those questions open: 1) We attach a device `A` with `--persistent`and remove it with `--live`. If we now attach `B`, either via `--persistent` and `--live`, we expect that the PCI bus address formerly assigned to `A` is not reused for `B`. Is this correct? 2) If we attach a device `A` with `--live` and a second device `B` with `--persistent`, then `A` will not be present in the persistent domain XML. Still, we expect that `B` is added to both live and persistent definitions, using the same PCI bus address. By doing so, we would expect the attachment routines for the persistent definition not to assign the address handed out by the attachment routines of the live configuration for device `A`. In other words, even if `A` is not present in the persistent configuration, we would expect the address of `A` not be reused when attaching `B` to the persistent definition. Are those semantics correct? The last question is about target names for network devices (`ifname`). libvirt does generate names for such devices in certain situations. Whenever a device definition is parsed that contains an `ifname` that matches libvirt's generation rules, e.g. vnet*, it is blanked out (see `virDomainNetDefParseXML`, in domain_conf.c). When writing code that tries to identify network devices by their `ifname`s, we found that this would be impossible because devices with an autogenerated name will have a blank `ifname` in the definition. What is the expected semantics around fixed PCI bus addresses for such devices? Would it be right to assign a custom `ifname` to them in this case? Thanks in advance! Pascal

3 4

Resolving issue 135 (Qemu under AppArmor can't access volume-type disks)
by Erik Huelsmann 15 Jan '26

15 Jan '26

Hi, Several months ago, I ran into issue #135 which says that Qemu under AppArmor can't access LVM volume disks. I have been studying the code and the invocation of virt-aa-helper. I'm using 11.3.0 and 10.0.0 -- I'm working to compile and run a development version, but have my progress to share in the mean time. So far, I'm finding that if I create a volume-based disk XML entry in my domain definition: <disk type='volume' device='disk'> <driver name='qemu' type='qcow2'/> <source pool='default' volume='cirros.img'/> <target dev='sda' bus='scsi'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> with this, there is *no* XML (at all) on standard input in the virt-aa-helper command, whereas when using effectively the same definition, resolving the file manually, like this: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/cirros.img'/> <target dev='sda' bus='scsi'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> I get full XML on standard input for virt-aa-helper, with this being the snippet for the disk definition: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/cirros.img' index='1'/> <backingStore/> <target dev='sda' bus='scsi'/> <alias name='scsi0-0-0-0'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> I'm not asking for a fix, but would like to know if anybody has any "Ah hah!" moments about this - and if not, if there are some hints on how to test this, hopefully without needing to restart a VM over-and-over. Thanks in advance for any hints you may be able to provide! -- Bye, Erik. http://efficito.com -- Hosted accounting and ERP. Robust and Flexible. No vendor lock-in.

3 7

[PATCH 0/3] qemu: capabilities: Fetch properties of 'scsi-block' and 'scsi-generic' and add caps_10.2.0_aarch64 test data
by Peter Krempa 15 Jan '26

15 Jan '26

Peter Krempa (3): qemu: capabilities: Probe properties of 'scsi-block' and 'scsi-generic' devices qemucapabilitiesdata: Regenerate 'caps_10.2.0_x86_64' replies qemucapabilitestest: Add 'caps_10.2.0_aarch64' test data src/qemu/qemu_capabilities.c | 12 + .../qemu_10.2.0-virt.aarch64.xml | 251 + tests/domaincapsdata/qemu_10.2.0.aarch64.xml | 251 + .../caps_10.0.0_aarch64.replies | 76 +- .../caps_10.0.0_ppc64.replies | 60 +- .../caps_10.0.0_s390x.replies | 64 +- .../caps_10.0.0_x86_64+amdsev.replies | 84 +- .../caps_10.0.0_x86_64.replies | 84 +- .../caps_10.1.0_s390x.replies | 64 +- .../caps_10.1.0_x86_64+inteltdx.replies | 88 +- .../caps_10.1.0_x86_64.replies | 88 +- .../caps_10.2.0_aarch64.replies | 39259 ++++++++++++++++ .../caps_10.2.0_aarch64.xml | 530 + .../caps_10.2.0_x86_64+mshv.replies | 88 +- .../caps_10.2.0_x86_64.replies | 186 +- .../caps_6.2.0_ppc64.replies | 60 +- .../caps_6.2.0_x86_64.replies | 84 +- .../caps_7.0.0_ppc64.replies | 60 +- .../caps_7.0.0_x86_64.replies | 84 +- .../caps_7.1.0_ppc64.replies | 60 +- .../caps_7.1.0_x86_64.replies | 84 +- .../caps_7.2.0_ppc.replies | 56 +- .../caps_7.2.0_x86_64+hvf.replies | 84 +- .../caps_7.2.0_x86_64.replies | 84 +- .../caps_8.0.0_x86_64.replies | 84 +- .../caps_8.1.0_s390x.replies | 60 +- .../caps_8.1.0_x86_64.replies | 84 +- .../caps_8.2.0_aarch64.replies | 76 +- .../caps_8.2.0_armv7l.replies | 76 +- .../caps_8.2.0_loongarch64.replies | 64 +- .../caps_8.2.0_s390x.replies | 60 +- .../caps_8.2.0_x86_64.replies | 84 +- .../caps_9.0.0_sparc.replies | 52 +- .../caps_9.0.0_x86_64.replies | 84 +- .../caps_9.1.0_riscv64.replies | 64 +- .../caps_9.1.0_s390x.replies | 64 +- .../caps_9.1.0_x86_64.replies | 84 +- .../caps_9.2.0_aarch64+hvf.replies | 72 +- .../caps_9.2.0_s390x.replies | 64 +- .../caps_9.2.0_x86_64+amdsev.replies | 84 +- .../caps_9.2.0_x86_64.replies | 84 +- ...arch64-cpu-passthrough.aarch64-latest.args | 2 +- ...aarch64-cpu-passthrough.aarch64-latest.xml | 2 +- ...ault-cpu-kvm-virt-10.0.aarch64-latest.args | 2 +- ...fault-cpu-kvm-virt-10.0.aarch64-latest.xml | 2 +- ...ault-cpu-tcg-virt-10.0.aarch64-latest.args | 1 - ...fault-cpu-tcg-virt-10.0.aarch64-latest.xml | 3 - ...aarch64-features-pauth.aarch64-latest.args | 2 +- .../aarch64-features-pauth.aarch64-latest.xml | 2 +- .../aarch64-features-sve.aarch64-latest.args | 2 +- .../aarch64-features-sve.aarch64-latest.xml | 2 +- .../aarch64-features-wrong.aarch64-latest.xml | 2 +- .../aarch64-gic-default.aarch64-latest.args | 2 +- .../aarch64-gic-default.aarch64-latest.xml | 2 +- .../aarch64-gic-none.aarch64-latest.args | 2 +- .../aarch64-gic-none.aarch64-latest.xml | 2 +- .../aarch64-kvm-32-on-64.aarch64-latest.args | 2 +- .../aarch64-kvm-32-on-64.aarch64-latest.xml | 2 +- .../aarch64-pci-serial.aarch64-latest.args | 1 - .../aarch64-pci-serial.aarch64-latest.xml | 3 - ...arch64-traditional-pci.aarch64-latest.args | 1 - ...aarch64-traditional-pci.aarch64-latest.xml | 3 - ...aarch64-usb-controller.aarch64-latest.args | 1 - .../aarch64-usb-controller.aarch64-latest.xml | 3 - ...ault-models.aarch64-latest.abi-update.args | 1 - ...fault-models.aarch64-latest.abi-update.xml | 3 - ...64-virt-default-models.aarch64-latest.args | 1 - ...h64-virt-default-models.aarch64-latest.xml | 3 - .../aarch64-virt-graphics.aarch64-latest.args | 1 - .../aarch64-virt-graphics.aarch64-latest.xml | 3 - ...h64-virt-headless-mmio.aarch64-latest.args | 1 - ...ch64-virt-headless-mmio.aarch64-latest.xml | 3 - .../aarch64-virt-headless.aarch64-latest.args | 1 - .../aarch64-virt-headless.aarch64-latest.xml | 3 - ...irt-minimal.aarch64-latest.abi-update.args | 1 - ...virt-minimal.aarch64-latest.abi-update.xml | 3 - .../aarch64-virt-minimal.aarch64-latest.args | 1 - .../aarch64-virt-minimal.aarch64-latest.xml | 3 - .../arm-vexpressa9-basic.aarch64-latest.args | 1 + .../arm-vexpressa9-basic.aarch64-latest.xml | 3 + .../arm-vexpressa9-nodevs.aarch64-latest.args | 1 + .../arm-vexpressa9-nodevs.aarch64-latest.xml | 3 + .../arm-vexpressa9-virtio.aarch64-latest.args | 1 + .../arm-vexpressa9-virtio.aarch64-latest.xml | 3 + .../cpu-topology5.aarch64-latest.args | 1 - .../cpu-topology5.aarch64-latest.xml | 3 +- ...ult-video-type-aarch64.aarch64-latest.args | 2 +- ...ault-video-type-aarch64.aarch64-latest.xml | 2 +- .../disk-arm-virtio-sd.aarch64-latest.args | 1 + .../disk-arm-virtio-sd.aarch64-latest.xml | 3 + ...efi-aarch64.aarch64-latest.abi-update.args | 1 - ...-efi-aarch64.aarch64-latest.abi-update.xml | 3 - ...mware-auto-efi-aarch64.aarch64-latest.args | 1 - ...rmware-auto-efi-aarch64.aarch64-latest.xml | 3 - ...-loader-raw.aarch64-latest.abi-update.args | 1 - ...t-loader-raw.aarch64-latest.abi-update.xml | 3 - ...-efi-format-loader-raw.aarch64-latest.args | 1 - ...o-efi-format-loader-raw.aarch64-latest.xml | 3 - ...i-aarch64-legacy-paths.aarch64-latest.args | 1 - ...fi-aarch64-legacy-paths.aarch64-latest.xml | 3 - ...anual-efi-acpi-aarch64.aarch64-latest.args | 1 - ...manual-efi-acpi-aarch64.aarch64-latest.xml | 3 - ...ual-efi-noacpi-aarch64.aarch64-latest.args | 1 - ...nual-efi-noacpi-aarch64.aarch64-latest.xml | 3 - ...l-noefi-noacpi-aarch64.aarch64-latest.args | 1 - ...al-noefi-noacpi-aarch64.aarch64-latest.xml | 3 - ...-smmuv3-pci-bus-single.aarch64-latest.args | 1 - ...u-smmuv3-pci-bus-single.aarch64-latest.xml | 3 - .../iommu-smmuv3-pci-bus.aarch64-latest.args | 1 - .../iommu-smmuv3-pci-bus.aarch64-latest.xml | 3 - .../iommu-smmuv3.aarch64-latest.args | 1 - .../iommu-smmuv3.aarch64-latest.xml | 3 - ...ch-virt-console-native.aarch64-latest.args | 1 - ...ach-virt-console-native.aarch64-latest.xml | 3 - ...ch-virt-console-virtio.aarch64-latest.args | 1 - ...ach-virt-console-virtio.aarch64-latest.xml | 3 - ...-serial+console-native.aarch64-latest.args | 1 - ...t-serial+console-native.aarch64-latest.xml | 3 - ...ach-virt-serial-compat.aarch64-latest.args | 1 - ...mach-virt-serial-compat.aarch64-latest.xml | 3 - ...ach-virt-serial-native.aarch64-latest.args | 1 - ...mach-virt-serial-native.aarch64-latest.xml | 3 - .../mach-virt-serial-pci.aarch64-latest.args | 1 - .../mach-virt-serial-pci.aarch64-latest.xml | 3 - .../mach-virt-serial-usb.aarch64-latest.args | 1 - .../mach-virt-serial-usb.aarch64-latest.xml | 3 - ...e-expander-bus-aarch64.aarch64-latest.args | 1 - ...ie-expander-bus-aarch64.aarch64-latest.xml | 3 - .../pcihole64-virt.aarch64-latest.args | 1 - .../pcihole64-virt.aarch64-latest.xml | 3 - .../pvpanic-pci-aarch64.aarch64-latest.args | 1 - .../pvpanic-pci-aarch64.aarch64-latest.xml | 3 - ...pci-no-address-aarch64.aarch64-latest.args | 1 - ...-pci-no-address-aarch64.aarch64-latest.xml | 3 - ...automatic-virt-aarch64.aarch64-latest.args | 1 - ...-automatic-virt-aarch64.aarch64-latest.xml | 3 - ...-fallback-virt-aarch64.aarch64-latest.args | 1 - ...t-fallback-virt-aarch64.aarch64-latest.xml | 3 - ...r-default-virt-aarch64.aarch64-latest.args | 1 - ...er-default-virt-aarch64.aarch64-latest.xml | 3 - .../virtio-iommu-aarch64.aarch64-latest.args | 1 - .../virtio-iommu-aarch64.aarch64-latest.xml | 3 - 142 files changed, 42351 insertions(+), 932 deletions(-) create mode 100644 tests/domaincapsdata/qemu_10.2.0-virt.aarch64.xml create mode 100644 tests/domaincapsdata/qemu_10.2.0.aarch64.xml create mode 100644 tests/qemucapabilitiesdata/caps_10.2.0_aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml -- 2.52.0

2 4

[PATCH] qemuSecurityMoveImageMetadata: Move seclabels only to virStorageSource of same type
by Peter Krempa 15 Jan '26

15 Jan '26

From: Peter Krempa <pkrempa(a)redhat.com> The concept of moving a seclabel is used e.g. when a new image is introduced to the backing chain (or one of the existing ones becomes active during block commit). What it does is that it moves the metedata remembering the original seclabel to the new image. That idea works reasonably well if both the original and new image are of same type e.g. a file, where they have comparable seclabel. It breaks down though when you e.g. create a snapshot stored in a 'file' on top of a disk originally backed by a 'block' storage source, since the seclabels differ quite siginificantly. This patch restricts the seclabel move in qemuSecurityMoveImageMetadata to happen only if the storage sources are of same type to avoid the issue. This means that the seclabels will not be remebered and will be restored to the default but it's better than to transfer wrong labels. Resolves: https://issues.redhat.com/browse/RHEL-114412 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_security.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_security.c b/src/qemu/qemu_security.c index 6bb0f9170d..84cb981a96 100644 --- a/src/qemu/qemu_security.c +++ b/src/qemu/qemu_security.c @@ -201,6 +201,16 @@ qemuSecurityMoveImageMetadata(virQEMUDriver *driver, if (qemuDomainNamespaceEnabled(vm, QEMU_DOMAIN_NS_MOUNT)) pid = vm->pid; + /* Moving seclabel metadata makes sense only when 'src' and 'dst' are of + * the same type. Otherwise 'dst' could end up with a seclabel that doesn't + * make sense for it (e.g. a seclabel originating from a block device /dev + * node moved to a file), once the seclabels are restored for it */ + if (src && dst && src->type != dst->type) { + VIR_DEBUG("dropping security label metadata instead of moving it from '%s' to '%s' due to type mismatch", + NULLSTR(src->path), NULLSTR(dst->path)); + dst = NULL; + } + return virSecurityManagerMoveImageMetadata(driver->securityManager, cfg->sharedFilesystems, pid, src, dst); -- 2.52.0

2 1

Release of libvirt-12.0.0
by Jiri Denemark 15 Jan '26

15 Jan '26

The 12.0.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * bhyve: SLIRP networking support Domain XMLs now can use SLIRP user-mode networking:: <interface type='user'> <model type='virtio'/> </interface> * bhyve: virtio-scsi support Domain XMLs now can use ``virtio-scsi`` devices:: <disk type='ctl'> <source dev='/dev/cam/ctl'/> <target dev='sda' bus='scsi'/> </disk> * bhyve: initial ARM64 support The bhyve driver now supports booting ARM64 domains on ARM64 hosts. This support is still in early stage of development and has some limitations. For example, it requires using ``<clock offset='localtime'/>`` in domain XMLs, and bootrom autofill is not implemented. * Improvements * qemu: Improvements and fixes to firmware selection Firmware selection now works more reliably and predictably in many scenarios. Notably, issues that were preventing the use of firmware designed for confidential VMs on aarch64 have been addressed. * network: Introduce port for DNS forwarder In the ``<dns/>`` section of network configuration users can set up forwarding of DNS requests to custom DNS servers. These are specified using ``addr`` attribute. But configuring port wasn't possible, until now. New ``port`` attribute is introduced, which allows overriding the default DNS port for given address. * Bug fixes * qemu: Fix startup of VMs with more than ~25 external snapshots After switch to json-c VMs with too deeply nested image chains would fail to start due to nesting depth limit in json-c, which is now increased to once again support backing chains up to 200 images deep. * qemu: TPM: Properly handle migration when storage resides on NFS The VM now can be properly migrated in scenarios where TPM data is stored on a shared filesystem on the destination but on the source it's either on a different NFS or unshared completely. * qemu: Treat memory device source nodemask as strict NUMA policy Until now, the NUMA policy for ``<memory/>`` devices was taken either from the guest NUMA node or ``<numatune/>``. But this may lead to discrepancies, where the memory device is configured to bind to a set of host NUMA nodes, but the guest NUMA node is to bind to a disjoint set of host NUMA nodes. To resolve this, specifying ``<nodemask/>`` for a memory device implies ``strict`` policy. * qemu: Relax validation of some hyperv features Since 11.9.0 release, libvirt performs dependency checks for hyperv features, for instance ``stimer`` requires ``synic``. But as it turned out, for some ancient machine types (e.g. 'pc-i440fx-3.0' or 'pc-q35-3.0') some dependencies are not true. Corresponding checks were removed. * esx: URI encode inventory objects twice Formatting domain XML for domains on an ESX server might fail if corresponding datacenter or datastore contained special characters (e.g. '+'). This is now fixed. * Fix race when checking whether a path is on a shared file system Finding an existing parent of a given path and checking whether it's on a shared file system was not atomic and thus the path could have been misinterpreted as non-shared if it was removed between these two operations. This could cause migration with an emulated TPM device stored on a shared file system to fail with the following bogus error:: Operation not supported: the running swtpm does not support migration with shared storage Enjoy. Jirka

1 0

[PATCH] NEWS: Mention shared FS detection race
by Jiri Denemark 14 Jan '26

14 Jan '26

From: Jiri Denemark <jdenemar(a)redhat.com> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- NEWS.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9fff3173ec..958ce71375 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -96,6 +96,16 @@ v12.0.0 (unreleased) corresponding datacenter or datastore contained special characters (e.g. '+'). This is now fixed. + * Fix race when checking whether a path is on a shared file system + + Finding an existing parent of a given path and checking whether it's on a + shared file system was not atomic and thus the path could have been + misinterpreted as non-shared if it was removed between these two + operations. This could cause migration with an emulated TPM device stored + on a shared file system to fail with the following bogus error:: + + Operation not supported: the running swtpm does not support migration with shared storage + v11.10.0 (2025-12-01) ===================== -- 2.52.0

2 1

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 14 Jan '26

14 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ce55445695..9fff3173ec 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -52,6 +52,14 @@ v12.0.0 (unreleased) Notably, issues that were preventing the use of firmware designed for confidential VMs on aarch64 have been addressed. + * network: Introduce port for DNS forwarder + + In the ``<dns/>`` section of network configuration users can set up + forwarding of DNS requests to custom DNS servers. These are specified using + ``addr`` attribute. But configuring port wasn't possible, until now. New + ``port`` attribute is introduced, which allows overriding the default DNS + port for given address. + * **Bug fixes** * qemu: Fix startup of VMs with more than ~25 external snapshots @@ -66,6 +74,28 @@ v12.0.0 (unreleased) on a shared filesystem on the destination but on the source it's either on a different NFS or unshared completely. + * qemu: Treat memory device source nodemask as strict NUMA policy + + Until now, the NUMA policy for ``<memory/>`` devices was taken either from + the guest NUMA node or ``<numatune/>``. But this may lead to discrepancies, + where the memory device is configured to bind to a set of host NUMA nodes, + but the guest NUMA node is to bind to a disjoint set of host NUMA nodes. To + resolve this, specifying ``<nodemask/>`` for a memory device implies + ``strict`` policy. + + * qemu: Relax validation of some hyperv features + + Since 11.9.0 release, libvirt performs dependency checks for hyperv + features, for instance ``stimer`` requires ``synic``. But as it turned out, + for some ancient machine types (e.g. 'pc-i440fx-3.0' or 'pc-q35-3.0') some + dependencies are not true. Corresponding checks were removed. + + * esx: URI encode inventory objects twice + + Formatting domain XML for domains on an ESX server might fail if + corresponding datacenter or datastore contained special characters (e.g. + '+'). This is now fixed. + v11.10.0 (2025-12-01) ===================== -- 2.52.0

2 1