- Devel - libvirt List Archives

[libvirt] [PATCH] tools: Fix typo generating adapter_wwpn field
by John Ferlan 20 Jul '18

20 Jul '18

https://bugzilla.redhat.com/show_bug.cgi?id=1601377 Fix typo from commit id d45bee449 for the parent_wwpn field resulting in parent_wwnn being printed twice. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/virsh-pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index cc49a5b96d..6faff781b2 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -371,7 +371,7 @@ virshBuildPoolXML(vshControl *ctl, if (adapterParent) virBufferAsprintf(&buf, " parent='%s'", adapterParent); else if (adapterParentWwnn && adapterParentWwpn) - virBufferAsprintf(&buf, " parent_wwnn='%s' parent_wwnn='%s'", + virBufferAsprintf(&buf, " parent_wwnn='%s' parent_wwpn='%s'", adapterParentWwnn, adapterParentWwpn); else if (adapterParentFabricWwn) virBufferAsprintf(&buf, " parent_fabric_wwn='%s'", -- 2.17.1

2 1

[libvirt] [PATCH v2] util: set OOM in virCopyLastError if error is not set
by Nikolay Shirokovskiy 20 Jul '18

20 Jul '18

virCopyLastError is intended to be used after last error is set. However due to virLastErrorObject failures (very unlikely through as thread local error is allocated on first use) we can have zero fields in a copy as a result. In particular code field can be set to VIR_ERR_OK. In some places (qemu monitor, qemu agent and qemu migaration code for example) we use copy result as a flag and this leads to bugs. Let's set OOM-like error in copy in case of virLastErrorObject failures. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- Changes from v1: - check @to - set OMM error instead of using virErrorGenericFailure src/util/virerror.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index f198f27..737ea92 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -366,19 +366,25 @@ virSetError(virErrorPtr newerr) * * One will need to free the result with virResetError() * - * Returns 0 if no error was found and the error code otherwise and -1 in case - * of parameter error. + * Returns error code or -1 in case of parameter error. */ int virCopyLastError(virErrorPtr to) { virErrorPtr err = virLastErrorObject(); + + if (!to) + return -1; + /* We can't guarantee caller has initialized it to zero */ memset(to, 0, sizeof(*to)); - if (err) + if (err) { virCopyError(err, to); - else - virResetError(to); + } else { + to->code = VIR_ERR_NO_MEMORY; + to->domain = VIR_FROM_NONE; + to->level = VIR_ERR_ERROR; + } return to->code; } -- 1.8.3.1

2 6

[libvirt] [PATCH] build: Fix accidental revert of .gnulib update
by John Ferlan 19 Jul '18

19 Jul '18

Commit id 1bff5bbe25eb7a7e7a4e0067c4ca7cbc1cb34999 accidentally reverted .gnulib back to d6397dde2e127e246e3eeb5254a21f42cac783c8 which was two updates ago. Update to the latest 68df637b5f1b5c10370f6981d2a43a5cf74368df which includes three changes since the previous fetch of cdbf3d385a32ff904c96f20c26f3470bd8345248. > autoupdate > hard-locale: simplify by removing hard-locale.m4 > gnulib-tool: limit line length for git send-email Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushing under this I know fixes some previous build breaking issue and of course it's a .gnulib maint, so that's reason #2. .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index d6397dde2e..68df637b5f 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit d6397dde2e127e246e3eeb5254a21f42cac783c8 +Subproject commit 68df637b5f1b5c10370f6981d2a43a5cf74368df -- 2.17.1

1 0

[libvirt] [PATCH] virt-xml-validate: Add schema for nwfilterbinding
by Han Han 19 Jul '18

19 Jul '18

Add nwfilterbinding schema in virt-xml-validate for autoprobing. Add document of nwfilterbinding schema in tools/virt-xml-validate.pod. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600330 Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virt-xml-validate.in | 3 +++ tools/virt-xml-validate.pod | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in index 81fde4d832..7513413189 100644 --- a/tools/virt-xml-validate.in +++ b/tools/virt-xml-validate.in @@ -77,6 +77,9 @@ if [ -z "$TYPE" ]; then *device*) TYPE="nodedev" ;; + *filterbinding*) + TYPE="nwfilterbinding" + ;; *filter*) TYPE="nwfilter" ;; diff --git a/tools/virt-xml-validate.pod b/tools/virt-xml-validate.pod index f8e67503fd..a51a57002a 100644 --- a/tools/virt-xml-validate.pod +++ b/tools/virt-xml-validate.pod @@ -52,6 +52,10 @@ The schema for the XML format used to declare driver capabilities The schema for the XML format used by network traffic filters +=item C<nwfilterbinding> + +The schema for XML format used by network filter bindings. + =item C<secret> The schema for the XML format used by secrets descriptions -- 2.17.1

2 1

[libvirt] [java PATCH 0/1] *** Add support for sendng Qemu Guest Agent Commands ***
by Wido den Hollander 19 Jul '18

19 Jul '18

*** BLURB HERE *** Wido den Hollander (1): Add support for Qemu Guest Agent commands src/main/java/org/libvirt/Domain.java | 34 ++++++ src/main/java/org/libvirt/Library.java | 3 + .../java/org/libvirt/jna/LibvirtQemu.java | 16 +++ .../java/org/libvirt/qemu/QemuCommand.java | 106 ++++++++++++++++++ .../org/libvirt/qemu/TestQemuCommand.java | 24 ++++ 5 files changed, 183 insertions(+) create mode 100644 src/main/java/org/libvirt/jna/LibvirtQemu.java create mode 100644 src/main/java/org/libvirt/qemu/QemuCommand.java create mode 100644 src/test/java/org/libvirt/qemu/TestQemuCommand.java -- 2.17.1

1 1

[libvirt] [dockerfiles PATCH] Refresh after switch from yajl to jansson
by Andrea Bolognani 19 Jul '18

19 Jul '18

The corresponding libvirt-jenkins-ci commit is d2bbe1eee61a. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. buildenv-centos-7.Dockerfile | 4 ++-- buildenv-debian-8.Dockerfile | 2 +- buildenv-debian-9.Dockerfile | 2 +- buildenv-debian-sid.Dockerfile | 2 +- buildenv-fedora-27.Dockerfile | 2 +- buildenv-fedora-28.Dockerfile | 2 +- buildenv-fedora-rawhide.Dockerfile | 2 +- buildenv-ubuntu-16.Dockerfile | 2 +- buildenv-ubuntu-18.Dockerfile | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/buildenv-centos-7.Dockerfile b/buildenv-centos-7.Dockerfile index 5d92bfa..2c4c26d 100644 --- a/buildenv-centos-7.Dockerfile +++ b/buildenv-centos-7.Dockerfile @@ -23,6 +23,7 @@ ENV PACKAGES audit-libs-devel \ gnutls-devel \ iproute \ iscsi-initiator-utils \ + jansson-devel \ libacl-devel \ libattr-devel \ libblkid-devel \ @@ -63,8 +64,7 @@ ENV PACKAGES audit-libs-devel \ scrub \ sudo \ systemtap-sdt-devel \ - vim \ - yajl-devel + vim RUN yum install -y ${PACKAGES} && \ yum autoremove -y && \ yum clean all -y diff --git a/buildenv-debian-8.Dockerfile b/buildenv-debian-8.Dockerfile index 0766cc9..8a8c3b0 100644 --- a/buildenv-debian-8.Dockerfile +++ b/buildenv-debian-8.Dockerfile @@ -29,6 +29,7 @@ ENV PACKAGES augeas-tools \ libdevmapper-dev \ libfuse-dev \ libgnutls28-dev \ + libjansson-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ @@ -50,7 +51,6 @@ ENV PACKAGES augeas-tools \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ lvm2 \ make \ nfs-common \ diff --git a/buildenv-debian-9.Dockerfile b/buildenv-debian-9.Dockerfile index e106574..c3af421 100644 --- a/buildenv-debian-9.Dockerfile +++ b/buildenv-debian-9.Dockerfile @@ -29,6 +29,7 @@ ENV PACKAGES augeas-tools \ libdevmapper-dev \ libfuse-dev \ libgnutls28-dev \ + libjansson-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ @@ -50,7 +51,6 @@ ENV PACKAGES augeas-tools \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ lvm2 \ make \ nfs-common \ diff --git a/buildenv-debian-sid.Dockerfile b/buildenv-debian-sid.Dockerfile index c3a18be..a922457 100644 --- a/buildenv-debian-sid.Dockerfile +++ b/buildenv-debian-sid.Dockerfile @@ -29,6 +29,7 @@ ENV PACKAGES augeas-tools \ libdevmapper-dev \ libfuse-dev \ libgnutls28-dev \ + libjansson-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ @@ -50,7 +51,6 @@ ENV PACKAGES augeas-tools \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ lvm2 \ make \ nfs-common \ diff --git a/buildenv-fedora-27.Dockerfile b/buildenv-fedora-27.Dockerfile index 4e5173f..2f35a2e 100644 --- a/buildenv-fedora-27.Dockerfile +++ b/buildenv-fedora-27.Dockerfile @@ -27,6 +27,7 @@ ENV PACKAGES audit-libs-devel \ iproute \ iproute-tc \ iscsi-initiator-utils \ + jansson-devel \ libacl-devel \ libattr-devel \ libblkid-devel \ @@ -71,7 +72,6 @@ ENV PACKAGES audit-libs-devel \ vim \ wireshark-devel \ xen-devel \ - yajl-devel \ zfs-fuse RUN yum install -y ${PACKAGES} && \ yum autoremove -y && \ diff --git a/buildenv-fedora-28.Dockerfile b/buildenv-fedora-28.Dockerfile index d051d65..f4f7198 100644 --- a/buildenv-fedora-28.Dockerfile +++ b/buildenv-fedora-28.Dockerfile @@ -26,6 +26,7 @@ ENV PACKAGES audit-libs-devel \ iproute \ iproute-tc \ iscsi-initiator-utils \ + jansson-devel \ libacl-devel \ libattr-devel \ libblkid-devel \ @@ -71,7 +72,6 @@ ENV PACKAGES audit-libs-devel \ vim \ wireshark-devel \ xen-devel \ - yajl-devel \ zfs-fuse RUN yum install -y ${PACKAGES} && \ yum autoremove -y && \ diff --git a/buildenv-fedora-rawhide.Dockerfile b/buildenv-fedora-rawhide.Dockerfile index 56d59a1..189ea59 100644 --- a/buildenv-fedora-rawhide.Dockerfile +++ b/buildenv-fedora-rawhide.Dockerfile @@ -26,6 +26,7 @@ ENV PACKAGES audit-libs-devel \ iproute \ iproute-tc \ iscsi-initiator-utils \ + jansson-devel \ libacl-devel \ libattr-devel \ libblkid-devel \ @@ -95,7 +96,6 @@ ENV PACKAGES audit-libs-devel \ vim \ wireshark-devel \ xen-devel \ - yajl-devel \ zfs-fuse RUN yum install -y ${PACKAGES} && \ yum autoremove -y && \ diff --git a/buildenv-ubuntu-16.Dockerfile b/buildenv-ubuntu-16.Dockerfile index d2ece05..bc387a1 100644 --- a/buildenv-ubuntu-16.Dockerfile +++ b/buildenv-ubuntu-16.Dockerfile @@ -29,6 +29,7 @@ ENV PACKAGES augeas-tools \ libdevmapper-dev \ libfuse-dev \ libgnutls28-dev \ + libjansson-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ @@ -51,7 +52,6 @@ ENV PACKAGES augeas-tools \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ lvm2 \ make \ nfs-common \ diff --git a/buildenv-ubuntu-18.Dockerfile b/buildenv-ubuntu-18.Dockerfile index fdf97eb..2a15f14 100644 --- a/buildenv-ubuntu-18.Dockerfile +++ b/buildenv-ubuntu-18.Dockerfile @@ -29,6 +29,7 @@ ENV PACKAGES augeas-tools \ libdevmapper-dev \ libfuse-dev \ libgnutls28-dev \ + libjansson-dev \ libnetcf-dev \ libnl-3-dev \ libnl-route-3-dev \ @@ -51,7 +52,6 @@ ENV PACKAGES augeas-tools \ libxen-dev \ libxml2-dev \ libxml2-utils \ - libyajl-dev \ lvm2 \ make \ nfs-common \ -- 2.17.1

1 0

[libvirt] [jenkins-ci PATCH 0/4] guests: Replace yajl with jansson
by Andrea Bolognani 19 Jul '18

19 Jul '18

Andrea Bolognani (4): guests: Install jansson for libvirt guests: Don't install yajl for libvirt guests: Remove yajl mapping guests: Remove yajl kludge guests/tasks/kludges.yml | 2 -- guests/vars/mappings.yml | 10 +++++----- guests/vars/projects/libvirt.yml | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) -- 2.17.1

2 5

[libvirt] [PATCH v4] qemu: fix broken autostart symlink after renaming domain.
by Julio Faracco 19 Jul '18

19 Jul '18

If a domain is configured to start on boot, it has a symlink to the domain definition inside the autostart directory. If you rename this domain, the definition is renamed too. The symlink need to be pointed to this renamed file. This commit recreates the symlink after renaming the XML file. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1594985 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/qemu/qemu_driver.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 25170f6f26..09af231dfc 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20917,6 +20917,8 @@ qemuDomainRenameCallback(virDomainObjPtr vm, char *old_dom_name = NULL; char *new_dom_cfg_file = NULL; char *old_dom_cfg_file = NULL; + char *new_dom_autostart_link = NULL; + char *old_dom_autostart_link = NULL; virCheckFlags(0, ret); @@ -20937,6 +20939,14 @@ qemuDomainRenameCallback(virDomainObjPtr vm, vm->def->name))) goto cleanup; + if (vm->autostart) { + if (!(new_dom_autostart_link = virDomainConfigFile(cfg->autostartDir, + new_dom_name)) || + !(old_dom_autostart_link = virDomainConfigFile(cfg->autostartDir, + vm->def->name))) + goto cleanup; + } + event_old = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_UNDEFINED, VIR_DOMAIN_EVENT_UNDEFINED_RENAMED); @@ -20949,6 +20959,23 @@ qemuDomainRenameCallback(virDomainObjPtr vm, if (virDomainSaveConfig(cfg->configDir, driver->caps, vm->def) < 0) goto rollback; + if (vm->autostart) { + if (virFileIsLink(old_dom_autostart_link) && + unlink(old_dom_autostart_link) < 0) { + virReportSystemError(errno, + _("Failed to delete symlink '%s'"), + old_dom_autostart_link); + goto rollback; + } + + if (symlink(new_dom_cfg_file, new_dom_autostart_link) < 0) { + virReportSystemError(errno, + _("Failed to create symlink '%s to '%s'"), + new_dom_autostart_link, new_dom_cfg_file); + goto rollback; + } + } + if (virFileExists(old_dom_cfg_file) && unlink(old_dom_cfg_file) < 0) { virReportSystemError(errno, @@ -20963,6 +20990,8 @@ qemuDomainRenameCallback(virDomainObjPtr vm, ret = 0; cleanup: + VIR_FREE(old_dom_autostart_link); + VIR_FREE(new_dom_autostart_link); VIR_FREE(old_dom_cfg_file); VIR_FREE(new_dom_cfg_file); VIR_FREE(old_dom_name); @@ -20982,6 +21011,11 @@ qemuDomainRenameCallback(virDomainObjPtr vm, if (virFileExists(new_dom_cfg_file)) unlink(new_dom_cfg_file); + if (vm->autostart) { + if (virFileExists(new_dom_autostart_link)) + unlink(new_dom_autostart_link); + } + goto cleanup; } -- 2.17.1

2 1

[libvirt] [dockerfiles PATCH] refresh: Add refresh script
by Andrea Bolognani 19 Jul '18

19 Jul '18

This calls lcitool, part of the libvirt-jenkins-ci project, to refresh the Dockerfiles so that they contain up to date information about build requirements. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- refresh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100755 refresh diff --git a/refresh b/refresh new file mode 100755 index 0000000..7aa2151 --- /dev/null +++ b/refresh @@ -0,0 +1,30 @@ +#!/bin/sh + +die() { + test "$1" && echo "$1" >&2 + exit 1 +} + +me="$0" +here=$(pwd) + +ci_repo="$1" + +cd "$ci_repo/guests/" >/dev/null 2>&1 || { + die "Usage: $me path/to/libvirt-jenkins-ci.git" +} + +for host in $(./lcitool -a hosts) +do + projects="libvirt" + dockerfile="$here/buildenv-${host#libvirt-}.Dockerfile" + + case "$host" in + libvirt-fedora-rawhide) projects="libvirt,libvirt+mingw" ;; + libvirt-freebsd-*) continue ;; + esac + + ./lcitool -a dockerfile -h "$host" -p "$projects" >"$dockerfile" || { + die "$me: Failed to refresh Dockerfile for $host" + } +done -- 2.17.1

2 1

[libvirt] CPU Support
by Hetz Ben Hamo 19 Jul '18

19 Jul '18

Hi, I've been looking at the CPU list and although I see lots of CPU's, I cannot find 2 CPU families: * AMD Ryzen * AMD Threadripper Although EPYC has been added recently. Are there any missing details which preventing adding those CPU's to the list? Thanks

5 4