- Devel - libvirt List Archives

[libvirt] [libvirt PATCH v4] news: Update for 4.8.0 release
by Fabiano Fidêncio 01 Oct '18

01 Oct '18

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging this one. Changes since v1: - Actually run make-check in order to be sure the changes are fine. Changes since v2: - Fixed and reworded some parts according to John's and Erik's suggestions. - Added, according to Erik's suggestion: - util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds - virsh: Implement vsh-table in virsh and virsh-admin Changes since v3: - Dropped: - util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds (by Peter's suggestion) - utils: Introduce resource monitor capability interface (by John's suggestion as this work is still a on-going work) - libxl: Add support to set shadow memory for any guest type (after a face-to-face discussion with Peter and Erik) -- docs/news.xml | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3ed6ff8aeb..166e641811 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -55,6 +55,15 @@ Drop support for these older versions and require Xen >= 4.6. </description> </change> + <change> + <summary> + nwfilter: Disallow binding creation in session mode + </summary> + <description> + Ensure that a filter binding creation is not attempted in session + mode and generates a proper error message. + </description> + </change> </section> <section title="Improvements"> <change> @@ -68,8 +77,46 @@ Guest Agent. </description> </change> + <change> + <summary> + virsh: Implement vsh-table in virsh and virsh-admin + </summary> + <description> + The new API fixes problems with table-alignment, making the tables + more readable and deals with unicode. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + storage: Allow inputvol to be encrypted + </summary> + <description> + When creating a storage volume based on another volume, the base + input volume is allowed to be encrypted. + </description> + </change> + <change> + <summary> + virsh: Require explicit --domain for domxml-to-native + </summary> + <description> + The --domain option for domxml-to-native virsh command has always + been documented as required, but commit v4.3.0-127-gd86531daf2 + accidentally made it optional. + </description> + </change> + <change> + <summary> + lxc_monitor: Avoid AB / BA lock race + </summary> + <description> + A deadlock situation could occur when autostarting a LXC domain + 'guest' due to two threads attempting to take opposing locks while + holding opposing locks (AB BA problem). + </description> + </change> </section> </release> <release version="v4.7.0" date="2018-09-03"> -- 2.19.0

2 1

[libvirt] [PATCH] security: dac: also label listen UNIX sockets
by Ján Tomko 01 Oct '18

01 Oct '18

We switched to opening mode='bind' sockets ourselves: commit 30fb2276d88b275dc2aad6ddd28c100d944b59a5 qemu: support passing pre-opened UNIX socket listen FD in v4.5.0-rc1~251 Then fixed qemuBuildChrChardevStr to change libvirtd's label while creating the socket: commit b0c6300fc42bbc3e5eb0b236392f7344581c5810 qemu: ensure FDs passed to QEMU for chardevs have correct SELinux labels v4.5.0-rc1~52 Also add labeling of these sockets to the DAC driver. Instead of trying to figure out which one was created by libvirt, label it if it exists. https://bugzilla.redhat.com/show_bug.cgi?id=1633389 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/security/security_dac.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 62442745dd..da4a6c72fe 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -1308,7 +1308,12 @@ virSecurityDACSetChardevLabel(virSecurityManagerPtr mgr, break; case VIR_DOMAIN_CHR_TYPE_UNIX: - if (!dev_source->data.nix.listen) { + if (!dev_source->data.nix.listen || + (dev_source->data.nix.path && + virFileExists(dev_source->data.nix.path))) { + /* Also label mode='bind' sockets if they exist, + * e.g. because they were created by libvirt + * and passed via FD */ if (virSecurityDACSetOwnership(mgr, NULL, dev_source->data.nix.path, user, group) < 0) -- 2.16.4

3 5

[libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release
by Fabiano Fidêncio 01 Oct '18

01 Oct '18

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging this one. Changes since v1: - Actually run make-check in order to be sure the changes are fine. Changes since v2: - Fixed and reworded some parts according to John's and Erik's suggestions. - Added, according to Erik's suggestion: - util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds - virsh: Implement vsh-table in virsh and virsh-admin --- docs/news.xml | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3ed6ff8aeb..36692ba456 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,18 @@ and virDomainPMWakeup APIs. </description> </change> + <change> + <summary> + utils: Introduce monitor capability interface + </summary> + <description> + The resource monitor has been introduced and it creates the interface + for getting the host capability of the resource monitor from the system + resource control. + The resource monitor takes the role of RDT monitoring groups and could + be used to monitor the resource consumption information. + </description> + </change> </section> <section title="Removed features"> <change> @@ -55,6 +67,15 @@ Drop support for these older versions and require Xen >= 4.6. </description> </change> + <change> + <summary> + nwfilter: Disallow binding creation in session mode + </summary> + <description> + Ensure that a filter binding creation is not attempted in session + mode and generates a proper error message. + </description> + </change> </section> <section title="Improvements"> <change> @@ -68,8 +89,64 @@ Guest Agent. </description> </change> + <change> + <summary> + storage: Allow to use any format as input volume for encryption + </summary> + <description> + Libvirt has supported 'raw' input volumes for encryption since 4.5.0. + Now, it's not going to limit the usage to 'raw' only anymore. + </description> + </change> + <change> + <summary> + libxl: Add support to set shadow memory for any guest type + </summary> + <description> + PVH guests now can take advantage of using shadow memory. + </description> + </change> + <change> + <summary> + util: Introduce VIR_AUTOCLOSE macro to automatically close files' fds + </summary> + <description> + The Macro automatically force closes the fds by calling + <code>virForceCloseHelper</code> when the fd goes out of scope and is + used to eliminate <code>VIR_FORCE_CLOSE</code> in cleanup sections. + </description> + </change> + <change> + <summary> + virsh: Implement vsh-table in virsh and virsh-admin + </summary> + <description> + The new API fixes problems with table-alignment, making the tables + more readable and deals with unicode. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + virsh: Require explicit --domain for domxml-to-native + </summary> + <description> + The --domain option for domxml-to-native virsh command has always + been documented as required, but commit v4.3.0-127-gd86531daf2 + accidentally made it optional. + </description> + </change> + <change> + <summary> + lxc_monitor: Avoid AB / BA lock race + </summary> + <description> + A deadlock situation could occur when autostarting a LXC domain + 'guest' due to two threads attempting to take opposing locks while + holding opposing locks (AB BA problem). + </description> + </change> </section> </release> <release version="v4.7.0" date="2018-09-03"> -- 2.19.0

3 3

[libvirt] [PATCH v2] news: Update for 4.8.0 release
by Fabiano Fidêncio 01 Oct '18

01 Oct '18

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging this one. Changes since v1: - Actually run make-check in order to be sure the changes are fine. --- docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3ed6ff8aeb..62148d28af 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,26 @@ and virDomainPMWakeup APIs. </description> </change> + <change> + <summary> + utils: Introduce monitor capability interface + </summary> + <description> + The resource monitor has been introduces and it creates the interface + for getting the host capability of the resource monitor from the system + resource control. + The resource monitor takes the role of RDT monitoring groups and could + be used to monitor the resource consumption information. + </description> + </change> + <change> + <summary> + conf: Introduce RDT monitor host capability + </summary> + <description> + Introduce cache monitor (CMT) and memory bandwidth monitor (MBM). + </description> + </change> </section> <section title="Removed features"> <change> @@ -55,6 +75,15 @@ Drop support for these older versions and require Xen >= 4.6. </description> </change> + <change> + <summary> + nwfilter: Disallow binding creation in session mode + </summary> + <description> + Ensure that a filter binding creation is not attempted in session + mode and generate the proper error message. + </description> + </change> </section> <section title="Improvements"> <change> @@ -68,8 +97,48 @@ Guest Agent. </description> </change> + <change> + <summary> + storage: Allow to use any format as input volume for encryption + </summary> + <description> + Since v4.5.0 libvirt has support to use a 'raw' input volume for + encryption. From now on, let's not limit this to 'raw' only. + </description> + </change> + <change> + <summary> + libxl: Add support to set shadow memory for any guest type + </summary> + <description> + PVH guests now can take advantage of using shadow memory. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + virsh: Require explicit --domain for domxml-to-native + </summary> + <description> + The domxml-to-native virsh command accepts either --xml or --domain + option followed by a file or domain name respectively, The --domain + option is documented as required, which means an argument with no + option is treated as --xml. Commit v4.3.0-127-gd86531daf2 broke this + by making --domain optional and thus an argument with no option was + treated as --domain. + </description> + </change> + <change> + <summary> + lxc_monitor: Avoid AB / BA lock race + </summary> + <description> + A dealock situation could occur when autostarting a LXC domain 'guest' + due to two threads attempting to take opposing locks while holding + opposing locks (AB BA problem). + </description> + </change> </section> </release> <release version="v4.7.0" date="2018-09-03"> -- 2.19.0

4 3

[libvirt] [PATCH] uml: Fix weird logic inside umlConnectOpen() function.
by Julio Faracco 01 Oct '18

01 Oct '18

The pointer related to uml_driver needs to be checked before its usage inside the function. Some attributes of the driver are being accessed while the pointer is NULL considering the current logic. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/uml/uml_driver.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index fcd468243e..d1c71d8521 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -1193,6 +1193,13 @@ static virDrvOpenStatus umlConnectOpen(virConnectPtr conn, { virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); + /* URI was good, but driver isn't active */ + if (uml_driver == NULL) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("uml state driver is not active")); + return VIR_DRV_OPEN_ERROR; + } + /* Check path and tell them correct path if they made a mistake */ if (uml_driver->privileged) { if (STRNEQ(conn->uri->path, "/system") && @@ -1211,13 +1218,6 @@ static virDrvOpenStatus umlConnectOpen(virConnectPtr conn, } } - /* URI was good, but driver isn't active */ - if (uml_driver == NULL) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("uml state driver is not active")); - return VIR_DRV_OPEN_ERROR; - } - if (virConnectOpenEnsureACL(conn) < 0) return VIR_DRV_OPEN_ERROR; -- 2.17.1

3 2

[libvirt] [libvirt PATCH] news: Update for 4.8.0 release
by Fabiano Fidêncio 01 Oct '18

01 Oct '18

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging this one. --- docs/news.xml | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 3ed6ff8aeb..29b12cb04d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,50 @@ and virDomainPMWakeup APIs. </description> </change> + <change> + utils: Introduce monitor capability interface + </change> + <description> + The resource monitor has been introduced and it creates the interface + for getting the host capability of the resource monitor from the system + resource control. + The resource monitor takes the role of RDT monitoring groups and could + be used to monitor the resource consumption information. + </description> + <change> + conf: Introduce RDT monitor host capability + </change> + <description> + Introduce cache monitor (CMT) and memory bandwidth monitor (MBM). + For the former (CMT), the host capability is shown like: + <host> + ... + <cache> + <bank id='0' level='3' type='both' size='15' unit='MiB' cpus='0-5'> + <control granularity='768' min='1536' unit='KiB' type='both' maxAllocs='4'/> + </bank> + <monitor level='3' 'reuseThreshold'='270336' maxMonitors='176'> + <feature name='llc_occupancy'/> + </monitor> + </cache> + ... + </host> + + For the latter (MBM), the capability is shown like this: + <host> + ... + <memory_bandwidth> + <node id='1' cpus='6-11'> + <control granularity='10' min ='10' maxAllocs='4'/> + </node> + <monitor maxMonitors='176'> + <feature name='mbm_total_bytes'/> + <feature name='mbm_local_bytes'/> + </monitor> + </memory_bandwidth> + ... + </host> + </description> </section> <section title="Removed features"> <change> @@ -55,6 +99,15 @@ Drop support for these older versions and require Xen >= 4.6. </description> </change> + <change> + <summary> + nwfilter: Disallow binding creation in session mode + </summary> + <description> + Ensure that a filter binding creation is not attempted in session + mode and generate the proper error message. + </description> + </change> </section> <section title="Improvements"> <change> @@ -68,8 +121,43 @@ Guest Agent. </description> </change> + <change> + storage: Allow to use any format as input volume for encryption + </change> + <description> + Since v4.5.0 libvirt has support to use a 'raw' input volume for + encryption. From now on, let's not limit this to 'raw' only. + </description> + <change> + libxl: Add support to set shadow memory for any guest type, not only + HVM + </change> + <description> + PVH guests now can take advantage of using shadow memory. + </description> </section> <section title="Bug fixes"> + <change> + <summary> + virsh: Require explicit --domain for domxml-to-native + </summary> + <description> + The domxml-to-native virsh command accepts either --xml or --domain + option followed by a file or domain name respectively, The --domain + option is documented as required, which means an argument with no + option is treated as --xml. Commit v4.3.0-127-gd86531daf2 broke this + by making --domain optional and thus an argument with no option was + treated as --domain. + </description> + </change> + <change> + lxc_monitor: Avoid AB / BA lock race + </change> + <description> + A dealock situation could occur when autostarting a LXC domain 'guest' + due to two threads attempting to take opposing locks while holding + opposing locks (AB BA problem). + </description> </section> </release> <release version="v4.7.0" date="2018-09-03"> -- 2.19.0

1 1

[libvirt] [PATCH 0/7] Various Coverity based concerns
by John Ferlan 01 Oct '18

01 Oct '18

I'm sure it'll be felt one or two could just be false positives, but I have 35-40 of true false positives and it seems at least these go above just noise on the channel. Perhaps the most difficult one to immediately see was the libxl refcnt patch. That involves a little bit of theory and has been in my noise pile for a while until I noted that the @args is being added in a loop to a callback function that just Unref's it when done. So if there was more than 1 IP Address, then all sorts of fun things could happen. Without any change, the Alloc is matched by the Unref, but with the change we add a Ref to match each Unref in the I/O loop and we just ensure the Unref is done for the path that put @args into the I/O callback. I also think the nwfilter patch was "interesting" insomuch as it has my "favorite" 'if (int-value) {' condition. IOW, if not zero, then do something. What became "interesting" is that the virNWFilterIPAddrMapDelIPAddr could return -1 if the virHashLookup on @req->binding->portdevname returned NULL, so when "shrinking" the code to only call the instantiation for/when there was an IP Address found resolves a couple of issues in the code. John Ferlan (7): lxc: Only check @nparams in lxcDomainBlockStatsFlags libxl: Fix possible object refcnt issue tests: Inline a sysconf call for linuxCPUStatsToBuf util: Data overrun may lead to divide by zero tests: Alter logic in testCompareXMLToDomConfig tests: Use STRNEQ_NULLABLE nwfilter: Alter virNWFilterSnoopReqLeaseDel logic src/libxl/libxl_migration.c | 4 ++-- src/lxc/lxc_driver.c | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 9 ++++----- src/util/virutil.c | 11 +++++------ tests/commandtest.c | 4 ++-- tests/libxlxml2domconfigtest.c | 11 +++++------ tests/virhostcputest.c | 12 ++++++++++-- 7 files changed, 29 insertions(+), 24 deletions(-) -- 2.17.1

2 8

[libvirt] [PATCH RFC] lxc: Include support to lxc version 3.0 and higher.
by Julio Faracco 01 Oct '18

01 Oct '18

This patch introduce the new settings for LXC 3.0 and higher. The older versions keep the compatibility to deprecated settings for LXC, but after release 3.0, the compatibility was removed. This commit adds the support to the refactored settings. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/lxc/lxc_native.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index cbdec723dd..c0f70ebb7d 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -200,7 +200,9 @@ lxcSetRootfs(virDomainDefPtr def, int type = VIR_DOMAIN_FS_TYPE_MOUNT; VIR_AUTOFREE(char *) value = NULL; - if (virConfGetValueString(properties, "lxc.rootfs", &value) <= 0) + if (virConfGetValueString(properties, "lxc.rootfs", &value) <= 0 && + /* Legacy config keys were removed after release 3.0. */ + virConfGetValueString(properties, "lxc.rootfs.path", &value) <= 0) return -1; if (STRPREFIX(value, "/dev/")) @@ -1041,7 +1043,9 @@ lxcParseConfigString(const char *config, if (VIR_STRDUP(vmdef->os.init, "/sbin/init") < 0) goto error; - if (virConfGetValueString(properties, "lxc.utsname", &value) <= 0 || + if ((virConfGetValueString(properties, "lxc.utsname", &value) <= 0 && + /* Legacy config keys were removed after release 3.0. */ + virConfGetValueString(properties, "lxc.uts.name", &value) <= 0) || VIR_STRDUP(vmdef->name, value) < 0) goto error; if (!vmdef->name && (VIR_STRDUP(vmdef->name, "unnamed") < 0)) @@ -1051,7 +1055,9 @@ lxcParseConfigString(const char *config, goto error; /* Look for fstab: we shouldn't have it */ - if (virConfGetValue(properties, "lxc.mount")) { + if (virConfGetValue(properties, "lxc.mount") || + /* Legacy config keys were removed after release 3.0. */ + virConfGetValue(properties, "lxc.mount.fstab")) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", _("lxc.mount found, use lxc.mount.entry lines instead")); goto error; -- 2.17.1

2 3

[libvirt] [PATCHv4 00/18] Introduce x86 Cache Monitoring Technology (CMT)
by Wang Huaqiang 01 Oct '18

01 Oct '18

This series of patches and the series already been merged introduce the x86 Cache Monitoring Technology (CMT) to libvirt by interacting with kernel resource control (resctrl) interface. CMT is one of the Intel(R) x86 CPU feature which belongs to the Resource Director Technology (RDT). CMT reports the occupancy of the last level cache, which is shared by all CPU cores. In the v1 series, an original and complete feature for CMT was introduced The v2 and v3 patches address the feature for the host capability of CMT. v4 is addressing the feature for monitoring VM vcpu thread set cache occupancy and reporting it through a virsh command. We have serval discussion about the enabling of CMT, please refer to following links for the RFCs. RFCv3 https://www.redhat.com/archives/libvir-list/2018-August/msg01213.html RFCv2 https://www.redhat.com/archives/libvir-list/2018-July/msg00409.html https://www.redhat.com/archives/libvir-list/2018-July/msg01241.html RFCv1 https://www.redhat.com/archives/libvir-list/2018-June/msg00674.html And the merged commits are list as below, for host capability of CMT. 6af8417415508c31f8ce71234b573b4999f35980 8f6887998bf63594ae26e3db18d4d5896c5f2cb4 58fcee6f3a2b7e89c21c1fb4ec21429c31a0c5b8 12093f1feaf8f5023dcd9d65dff111022842183d a5d293c18831dcf69ec6195798387fbb70c9f461 1. About reason why CMT is necessary in libvirt? The perf events of 'CMT, MBML, MBMT' have been phased out since Linux kernel commit c39a0e2c8850f08249383f2425dbd8dbe4baad69, in libvirt the perf based cmt,mbm will not work with the latest linux kernel. These patches add CMT feature to libvirt through kernel resctrlfs interface. 2 Create cache monitoring group (cache monitor). The main interface for creating monitoring group is through XML file. The proposed configuration is like: <cputune> <cachetune vcpus='1'> <cache id='0' level='3' type='code' size='7680' unit='KiB'/> <cache id='1' level='3' type='data' size='3840' unit='KiB'/> + <monitor level='3' vcpus='1'/> </cachetune> <cachetune vcpus='4-7'> + <monitor level='3' vcpus='4-6'/> </cachetune> </cputune> In above XML, created 2 cache resctrl allocation groups and 2 resctrl monitoring groups. The changes of cache monitor will be effective in next booting of VM. 2 Show CMT result through command 'domstats' Adding the interface in qemu to report this information for resource monitor group through command 'virsh domstats --cpu-total'. Below is a typical output: # virsh domstats 1 --cpu-total Domain: 'ubuntu16.04-base' ... cpu.cache.monitor.count=2 cpu.cache.0.name=vcpus_1 cpu.cache.0.vcpus=1 cpu.cache.0.bank.count=2 cpu.cache.0.bank.0.id=0 cpu.cache.0.bank.0.bytes=4505600 cpu.cache.0.bank.1.id=1 cpu.cache.0.bank.1.bytes=5586944 cpu.cache.1.name=vcpus_4-6 cpu.cache.1.vcpus=4,5,6 cpu.cache.1.bank.count=2 cpu.cache.1.bank.0.id=0 cpu.cache.1.bank.0.bytes=17571840 cpu.cache.1.bank.1.id=1 cpu.cache.1.bank.1.bytes=29106176 Changes in v4: v4 is addressing the feature for monitoring VM vcpu thread set cache occupancy and reporting it through a virsh command. - Introduced resctrl default allocation - Introduced resctrl monitor and default monitor Changes in v3: - Addressed John Ferlan's review. - Typo fixed. - Removed VIR_ENUM_DECL(virMonitor); Changes in v2: - Introduced MBM capability. - Capability layout changed * Moved <monitor> from cahe <bank> to <cache> * Renamed <Threshold> to <reuseThreshold> - Document for 'reuseThreshold' changed. - Introduced API virResctrlInfoGetMonitorPrefix - Added more tests, covering standalone CMT, fake new feature. - Creating CMT resource control group will be subsequent job. Wang Huaqiang (18): docs: Refactor schemas to support default allocation util: Introduce resctrl monitor for CMT util: Refactor code for adding PID to the resource group util: Add interface for adding PID to monitor util: Refactor code for determining allocation path util: Add monitor interface to determine path util: Refactor code for creating resctrl group util: Add interface for creating monitor group util: Add more interfaces for resctrl monitor util: Introduce default monitor conf: Refactor code for matching existing resctrls conf: Refactor virDomainResctrlAppend conf: Add resctrl monitor configuration Util: Add function for checking if monitor is running qemu: enable resctrl monitor in qemu conf: Add a 'id' to virDomainResctrlDef qemu: refactor qemuDomainGetStatsCpu qemu: Report cache occupancy (CMT) with domstats docs/schemas/domaincommon.rng | 14 +- src/conf/domain_conf.c | 327 ++++++++++-- src/conf/domain_conf.h | 12 + src/libvirt_private.syms | 12 + src/qemu/qemu_driver.c | 272 +++++++++- src/qemu/qemu_process.c | 41 +- src/util/virresctrl.c | 555 +++++++++++++++++++-- src/util/virresctrl.h | 49 ++ tests/genericxml2xmlindata/cachetune-cdp.xml | 3 + .../cachetune-colliding-monitor.xml | 30 ++ tests/genericxml2xmlindata/cachetune-small.xml | 7 + tests/genericxml2xmltest.c | 2 + 12 files changed, 1224 insertions(+), 100 deletions(-) create mode 100644 tests/genericxml2xmlindata/cachetune-colliding-monitor.xml -- 2.7.4

1 18

[libvirt] [PATCH v2 0/8] libxl: PVHv2 support
by Marek Marczykowski-Górecki 29 Sep '18

29 Sep '18

This is a respin of my old PVHv1 patch[1], converted to PVHv2. Should the code use "PVH" name (as libxl does internally), or "PVHv2" as in many places in Xen documentation? I've chosen the former, but want to confirm it. Also, not sure about VIR_DOMAIN_OSTYPE_XENPVH (as discussed on PVHv1 patch) - while it will be messy in many cases, there is libxl_domain_build_info.u.{hvm,pv,pvh} which would be good to not mess up. Also, PVHv2 needs different kernel features than PV (CONFIG_XEN_PVH vs CONFIG_XEN_PV), so keeping the same VIR_DOMAIN_OSTYPE_XEN could be confusing. On the other hand, libxl_domain_build_info.u.pv is used in very few places (one section of libxlMakeDomBuildInfo), so guarding u.hvm access with VIR_DOMAIN_OSTYPE_HVM may be enough. For now I've reused VIR_DOMAIN_OSTYPE_XEN - in the driver itself, most of the code is the same as for PV. Since PVHv2 relies on features in newer Xen versions, I needed to convert also some older code. For example b_info->u.hvm.nested_hvm was deprecated in favor of b_info->nested_hvm. While the code do handle both old and new versions (obviously refusing PVHv2 if Xen is too old), this isn't the case for tests. How it should be handled, if at all? First few preparatory patches can be applied independently. [1] https://www.redhat.com/archives/libvir-list/2016-August/msg00376.html Changes in v2: - drop "docs: don't refer to deprecated 'linux' ostype in example" patch - migrating further away from "linux" os type is offtopic to this series and apparently is a controversial thing - drop "docs: update domain schema for machine attribute" patch - already applied - apply review comments from Jim - rebase on master Marek Marczykowski-Górecki (8): docs: add documentation of arch element of capabilities.xml libxl: set shadow memory for any guest type, not only HVM libxl: prefer new location of nested_hvm in libxl_domain_build_info libxl: reorder libxlMakeDomBuildInfo for upcoming PVH support libxl: add support for PVH tests: add basic Xen PVH test xenconfig: add support for parsing type= xl config entry xenconfig: add support for type="pvh" docs/formatcaps.html.in | 22 ++++- docs/formatdomain.html.in | 11 +- docs/schemas/domaincommon.rng | 1 +- src/libxl/libxl_capabilities.c | 33 ++++++- src/libxl/libxl_conf.c | 81 ++++++++++++----- src/libxl/libxl_driver.c | 6 +- src/xenconfig/xen_common.c | 27 +++++- src/xenconfig/xen_xl.c | 5 +- tests/libxlxml2domconfigdata/basic-pv.json | 1 +- tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++++++++++- tests/libxlxml2domconfigdata/basic-pvh.xml | 28 ++++++- tests/libxlxml2domconfigdata/fullvirt-cpuid.json | 2 +- tests/libxlxml2domconfigdata/multiple-ip.json | 1 +- tests/libxlxml2domconfigdata/vnuma-hvm.json | 2 +- tests/libxlxml2domconfigtest.c | 1 +- tests/testutilsxen.c | 3 +- tests/xlconfigdata/test-fullvirt-type.cfg | 21 ++++- tests/xlconfigdata/test-fullvirt-type.xml | 27 ++++++- tests/xlconfigdata/test-paravirt-type.cfg | 13 +++- tests/xlconfigdata/test-paravirt-type.xml | 25 +++++- tests/xlconfigdata/test-pvh-type.cfg | 13 +++- tests/xlconfigdata/test-pvh-type.xml | 25 +++++- tests/xlconfigtest.c | 3 +- 23 files changed, 359 insertions(+), 41 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/basic-pvh.json create mode 100644 tests/libxlxml2domconfigdata/basic-pvh.xml create mode 100644 tests/xlconfigdata/test-fullvirt-type.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-type.xml create mode 100644 tests/xlconfigdata/test-paravirt-type.cfg create mode 100644 tests/xlconfigdata/test-paravirt-type.xml create mode 100644 tests/xlconfigdata/test-pvh-type.cfg create mode 100644 tests/xlconfigdata/test-pvh-type.xml base-commit: 16858439deaec0832de61c5ddb93d8e80adccf6c -- git-series 0.9.1

2 12