- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/6] Add authorization support to all network services
by Daniel P. Berrangé 15 Nov '18

15 Nov '18

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html This series builds on the core authorization framework: v5: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01613.html enabling its use with the VNC, chardev, NBD and migration network servers. In combination with TLS x509 client certificates, this allows these services to whitelist specific clients, which avoids the need to setup restricted child certificate authorities. In VNC it also allows whitelisting based on SASL user names. Changed in v3: - Rebased to latest git master Changed in v2: - Document that authz objects are resolved at time of use, not time of network service activation - Improve docs for tls-authz parameters on services - Fix 2.13 -> 3.0 version tags - Remove redundant conditionals around g_strdup - Fix arg syntax for qemu-nbd s/-/--/ - Remove QAPI (optional) annotation - Fix some outdated usage example Based-on: <20181009130442.26296-1-berrange(a)redhat.com> Daniel P. Berrangé (6): qemu-nbd: add support for authorization of TLS clients nbd: allow authorization with nbd-server-start QMP command migration: add support for a "tls-authz" migration parameter chardev: add support for authorization for TLS clients vnc: allow specifying a custom authorization object name monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove blockdev-nbd.c | 11 +++++--- chardev/char-socket.c | 11 +++++++- chardev/char.c | 3 +++ hmp.c | 11 +++++++- include/block/nbd.h | 4 +-- migration/migration.c | 8 ++++++ migration/tls.c | 2 +- monitor.c | 23 +++++++++++++++++ nbd/server.c | 10 ++++---- qapi/block.json | 8 +++++- qapi/char.json | 6 +++++ qapi/migration.json | 14 ++++++++++- qemu-deprecated.texi | 11 ++++++++ qemu-nbd.c | 13 +++++++++- qemu-nbd.texi | 4 +++ qemu-options.hx | 44 +++++++++++++++++++++++--------- ui/vnc.c | 58 ++++++++++++++++++++++++++++++++++++------- 17 files changed, 204 insertions(+), 37 deletions(-) -- 2.17.1

3 15

[libvirt] [libvirt-perl PATCH] Add daemon to list of shutdown reasons
by John Ferlan 15 Nov '18

15 Nov '18

Add the support to work with libvirt commit 66a85cb13. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Although it's a build breaker and this does fix the problem - I'll wait to push just to make sure the text used for the message passes muster. Changes | 2 +- lib/Sys/Virt.xs | 1 + lib/Sys/Virt/Domain.pm | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index b85ac91..11eb906 100644 --- a/Changes +++ b/Changes @@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt 4.10.0 2018-00-00 - - XXX + - Add new domain shutdown reason 4.8.0 2018-10-05 diff --git a/lib/Sys/Virt.xs b/lib/Sys/Virt.xs index d27dd74..3398971 100644 --- a/lib/Sys/Virt.xs +++ b/lib/Sys/Virt.xs @@ -8717,6 +8717,7 @@ BOOT: REGISTER_CONSTANT(VIR_DOMAIN_SHUTOFF_SAVED, STATE_SHUTOFF_SAVED); REGISTER_CONSTANT(VIR_DOMAIN_SHUTOFF_FAILED, STATE_SHUTOFF_FAILED); REGISTER_CONSTANT(VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, STATE_SHUTOFF_FROM_SNAPSHOT); + REGISTER_CONSTANT(VIR_DOMAIN_SHUTOFF_DAEMON, STATE_SHUTOFF_DAEMON); REGISTER_CONSTANT(VIR_DOMAIN_CRASHED_UNKNOWN, STATE_CRASHED_UNKNOWN); REGISTER_CONSTANT(VIR_DOMAIN_CRASHED_PANICKED, STATE_CRASHED_PANICKED); diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 481b4b5..afaf71c 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -438,6 +438,10 @@ The guest is shutdown due to admin request The guest is shutoff after a crash +=item Sys::Virt::Domain::STATE_SHUTOFF_DAEMON + +The guest is shutoff during restart after reconnect due to daemon issue + =item Sys::Virt::Domain::STATE_SHUTOFF_DESTROYED The guest is shutoff after being destroyed -- 2.17.2

2 1

[libvirt] [libvirt-go PATCH] build: Fix the go build caused by a missing commentary end sequence
by Erik Skultety 15 Nov '18

15 Nov '18

Commit 20ab0c4d added a new constant to reflect recent libvirt upstream changes. However, it also introduced a tiny typo which caused the build to fail. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed both under trivial and build-breaker rules. domain_compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/domain_compat.h b/domain_compat.h index 5069ea2..371bcc4 100644 --- a/domain_compat.h +++ b/domain_compat.h @@ -911,7 +911,7 @@ struct _virDomainInterface { #define VIR_DOMAIN_MEMORY_STAT_DISK_CACHES 10 #endif -/* 4.10.0 +/* 4.10.0 */ #ifndef VIR_DOMAIN_SHUTOFF_DAEMON #define VIR_DOMAIN_SHUTOFF_DAEMON 8 -- 2.19.1

2 1

[libvirt] [PATCH RFC 0/3] Add mechanisms to force QEMU capabilities refetches
by John Ferlan 15 Nov '18

15 Nov '18

Sending as an RFC primarily because I'm looking for whether either or both mechanisms in the series is more or less desired. Likewise, if it's felt that the current process of telling customers to just delete the cache is acceptible, then so be it. If there's other ideas I'm willing to give them a go too. I did consider adding a virsh option to "virsh capabilities" (still possible) and/or a virt-admin option to force the refresh. These just were "easier" and didn't require an API adjustment to implement. Patch1 is essentially a means to determine if the kernel config was changed to allow nested virtualization and to force a refresh of the capabilities in that case. Without doing so the CPU settings for a guest may not add the vmx=on depending on configuration and for the user that doesn't make sense. There is a private bz on this so I won't bother posting it. Patch2 and Patch3 make use of the 'service libvirtd reload' function in order to invalidate all the entries in the internal QEMU capabilities hash table and then to force a reread. This perhaps has downsides related to guest usage and previous means to use reload and not refresh if a guest was running. On the other hand, we tell people to just clear the QEMU capabilities cache (e.g. rm /var/cache/libvirt/qemu/capabilities/*.xml) and restart libvirtd, so in essence, the same result. It's not clear how frequently this is used (it's essentially a SIGHUP to libvirtd). BTW: I did try deleting the files in the cache in one iteration, but for some reason (and I didn't investigate too long), the files wouldn't be recreated even though the cache was repopulated. They were recreated after a libvirt restart... John Ferlan (3): qemu: Add check for whether nesting was enabled util: Introduce virFileCacheForEach qemu: Add ability to invalidate the capabilities cache src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 78 ++++++++++++++++++++++++++++++++++++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_capspriv.h | 2 + src/qemu/qemu_driver.c | 4 +- src/util/virfilecache.c | 24 +++++++++++ src/util/virfilecache.h | 5 +++ tests/qemucapabilitiestest.c | 3 ++ 8 files changed, 118 insertions(+), 1 deletion(-) -- 2.17.2

3 7

[libvirt] [PATCH v3 0/6] conf: qemu: support new Hyper-V enlightenments in QEMU 3.1
by Vitaly Kuznetsov 15 Nov '18

15 Nov '18

The upcoming QEMU 3.1 release will bring us two new Hyper-V enlightenments: hv_ipi and hv_evmcs. Support these in libvirt. Changes since v2: - Separate docs/news.xml hunks in their own PATCH6, squash both changes together [Andrea Bolognani] - s/Qemu/QEMU/g + 'whitespate' typo [Andrea Bolognani] Vitaly Kuznetsov (6): docs: remove extra whitespace from Hyper-V enlightenments options conf: add support for Hyper-V PV IPIs qemu: add support for Hyper-V PV IPIs conf: add support for Hyper-V Enlightened VMCS qemu: add support for Hyper-V Enlightened VMCS news: mention Hyper-V PV IPI and Enlightened VMCS support docs/formatdomain.html.in | 32 ++++++++++++++++++------- docs/news.xml | 9 +++++++ docs/schemas/domaincommon.rng | 10 ++++++++ src/conf/domain_conf.c | 11 ++++++++- src/conf/domain_conf.h | 2 ++ src/cpu/cpu_x86.c | 6 +++++ src/cpu/cpu_x86_data.h | 2 ++ src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_parse_command.c | 2 ++ src/qemu/qemu_process.c | 2 ++ tests/qemuxml2argvdata/hyperv-off.xml | 2 ++ tests/qemuxml2argvdata/hyperv.args | 2 +- tests/qemuxml2argvdata/hyperv.xml | 2 ++ tests/qemuxml2xmloutdata/hyperv-off.xml | 2 ++ tests/qemuxml2xmloutdata/hyperv.xml | 2 ++ 15 files changed, 77 insertions(+), 11 deletions(-) -- 2.17.2

2 7

[libvirt] [PATCH v2 0/5] conf: qemu: support new Hyper-V enlightenments in Qemu 3.1
by Vitaly Kuznetsov 14 Nov '18

14 Nov '18

The upcoming Qemu-3.1 release will bring us two new Hyper-V enlightenments: hv_ipi and hv_evmcs. Support these in libvirt. Changes since v1: - Split patches into 'conf' and 'qemu' [John Ferlan] - Add entries to docs/news.xml [Andrea Bolognani] - Add a cleanup PATCH1 removing extra whitespaces from docs/formatdomain.html.in [Andrea Bolognani] - Minor tweaks [Andrea Bolognani] Vitaly Kuznetsov (5): docs: remove extra whitespate from Hyper-V enlightenments options conf: add support for Hyper-V PV IPIs qemu: add support for Hyper-V PV IPIs conf: add support for Hyper-V Enlightened VMCS qemu: add support for Hyper-V Enlightened VMCS docs/formatdomain.html.in | 32 ++++++++++++++++++------- docs/news.xml | 18 ++++++++++++++ docs/schemas/domaincommon.rng | 10 ++++++++ src/conf/domain_conf.c | 11 ++++++++- src/conf/domain_conf.h | 2 ++ src/cpu/cpu_x86.c | 6 +++++ src/cpu/cpu_x86_data.h | 2 ++ src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_parse_command.c | 2 ++ src/qemu/qemu_process.c | 2 ++ tests/qemuxml2argvdata/hyperv-off.xml | 2 ++ tests/qemuxml2argvdata/hyperv.args | 2 +- tests/qemuxml2argvdata/hyperv.xml | 2 ++ tests/qemuxml2xmloutdata/hyperv-off.xml | 2 ++ tests/qemuxml2xmloutdata/hyperv.xml | 2 ++ 15 files changed, 86 insertions(+), 11 deletions(-) -- 2.17.2

2 11

[libvirt] [PATCH] rpc: Remove duplicate check from filter function return.
by Julio Faracco 14 Nov '18

14 Nov '18

This is a simple removal of a duplicated check of the return of the filter function. There is a nested conditional checking exactly the same thing. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/rpc/virnetserverclient.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 97cf126f56..778cd1afc0 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -1288,8 +1288,7 @@ static virNetMessagePtr virNetServerClientDispatchRead(virNetServerClientPtr cli if (ret < 0) { virNetMessageFree(msg); msg = NULL; - if (ret < 0) - client->wantClose = true; + client->wantClose = true; break; } if (ret > 0) { -- 2.19.1

2 1

[libvirt] [PATCH] qemu: Using virStringListFreeCount instead VIR_FREE to free tmpPaths.
by Julio Faracco 14 Nov '18

14 Nov '18

The function qemuDomainGetHostdevPath() is using VIR_FREE to free the paths stored in tmpPaths. Both syntax analyzer are reporting a warning about this. Replacing the old method to function virStringListFreeCount() fixes the warnings/errors. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/qemu/qemu_domain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 37926850b2..c374219aab 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11132,9 +11132,7 @@ qemuDomainGetHostdevPath(virDomainDefPtr def, } ret = 0; cleanup: - for (i = 0; i < tmpNpaths; i++) - VIR_FREE(tmpPaths[i]); - VIR_FREE(tmpPaths); + virStringListFreeCount(tmpPaths, tmpNpaths); VIR_FREE(tmpPerms); virPCIDeviceFree(pci); virUSBDeviceFree(usb); -- 2.19.1

2 1

[libvirt] [PATCH v4 0/2] Adding partial support for LXC 3.0 rebased configs.
by Julio Faracco 14 Nov '18

14 Nov '18

This series adds enhacements for LXC to cover rebased config settings for version 3.0 without remove legacy ones. This serie includes some test cases to cover new config files too. The title mentions the word "partial" because there is a huge change with network settings which this commit does not cover. History: v1-v2: Michal's suggestions to handle differences between versions. v2-v3: Adding suggestions from Pino and John too. v3-v4: Appluing tests for LXC v3. Julio Faracco (2): lxc: Include support to lxc version 3.0 or higher. tests: Adding tests cases to cover rebased settings for LXC 3.0. src/lxc/lxc_native.c | 52 ++++++++++++++----- .../lxcconf2xml-blkiotune-v3.config | 11 ++++ .../lxcconf2xml-cpusettune-v3.config | 6 +++ .../lxcconf2xml-cputune-v3.config | 7 +++ .../lxcconf2xml-ethernet-v3.config | 44 ++++++++++++++++ .../lxcconf2xml-fstab-v3.config | 37 +++++++++++++ .../lxcconf2xml-idmap-v3.config | 5 ++ .../lxcconf2xml-macvlannetwork-v3.config | 13 +++++ .../lxcconf2xml-memtune-v3.config | 10 ++++ .../lxcconf2xml-nonenetwork-v3.config | 4 ++ .../lxcconf2xml-nonetwork-v3.config | 3 ++ .../lxcconf2xml-physnetwork-v3.config | 11 ++++ .../lxcconf2xml-simple-v3.config | 45 ++++++++++++++++ .../lxcconf2xml-vlannetwork-v3.config | 12 +++++ tests/lxcconf2xmltest.c | 51 +++++++++++++++++- 15 files changed, 295 insertions(+), 16 deletions(-) create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-blkiotune-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cpusettune-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cputune-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-ethernet-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-fstab-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-idmap-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-memtune-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonenetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-physnetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-simple-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-vlannetwork-v3.config -- 2.19.1

2 4

[libvirt] [PATCH] util: Fix memory leak in virResctrlMonitorGetStats
by John Ferlan 14 Nov '18

14 Nov '18

Missed during review and surprisingly my run through Coverity also didn't see this. I only noticed it when reading the code while fixing the build breaker for commit 36780a86a. With all those continues we would leak @stats. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushing under trivial rule. src/util/virresctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index ef5c668921..7aeca9d287 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -2684,9 +2684,6 @@ virResctrlMonitorGetStats(virResctrlMonitorPtr monitor, while (virDirRead(dirp, &ent, datapath) > 0) { char *node_id = NULL; - if (VIR_ALLOC(stat) < 0) - goto cleanup; - /* Looking for directory that contains resource utilization * information file. The directory name is arranged in format * "mon_<node_name>_<node_id>". For example, "mon_L3_00" and @@ -2709,6 +2706,9 @@ virResctrlMonitorGetStats(virResctrlMonitorPtr monitor, if (!(node_id = STRSKIP(node_id, "_"))) continue; + if (VIR_ALLOC(stat) < 0) + goto cleanup; + /* The node ID number should be here, parsing it. */ if (virStrToLong_uip(node_id, NULL, 0, &stat->id) < 0) goto cleanup; -- 2.17.2

1 0