- Devel - libvirt List Archives

[libvirt] [dbus PATCH] util: fix virtDBusUtilDecodeUUID
by Pavel Hrdina 08 Jan '19

08 Jan '19

This function is supposed to convert ASCII character into its hex representation, however the current implementation was wrong because the first comparison would be false for all printable characters. In most cases it worked but for example '$' which is 0x24 in HEX would be incorrectly converted to 0x2[ which is obviously wrong. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1647823 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util.c b/src/util.c index 9e11285..103bb29 100644 --- a/src/util.c +++ b/src/util.c @@ -182,11 +182,12 @@ virtDBusUtilDecodeUUID(const gchar *uuid) } static guchar -virtDBusUtilNumToHexchar(const guchar c) +virtDBusUtilNumToHexchar(const guchar n) { + guchar c = n & 0x0f; if (c < 10) return '0' + c; - return 'a' + (c & 0x0f) - 10; + return 'a' + c - 10; } static guchar -- 2.20.1

2 1

[libvirt] [PATCH] maint: Fix build with older automake
by Eric Blake 08 Jan '19

08 Jan '19

In a VPATH build, <config.h> is in the builddir, but it includes <config-post.h> from the top source directory; hence, we need to keep the -I(top_srcdir) directive that was accidentally removed from commit 7a879323 (the problem is not visible in an in-tree build). Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing as a build-breaker fix. gnulib/lib/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnulib/lib/Makefile.am b/gnulib/lib/Makefile.am index 601f74073c..5669551afb 100644 --- a/gnulib/lib/Makefile.am +++ b/gnulib/lib/Makefile.am @@ -26,3 +26,5 @@ SUFFIXES = noinst_LTLIBRARIES = include gnulib.mk + +AM_CPPFLAGS = -I$(top_srcdir) -- 2.20.1

1 0

[libvirt] [PATCH 0/3] Makefile.am cleanups
by Eric Blake 07 Jan '19

07 Jan '19

I noticed from IRC that Travis has been failing builds since our Jan 1 update of gnulib. I'm not sure what changed in the gnulib files to trip up clang, and I'm not really set up to test that this fixes the problem seen by Travis (it works locally for me using gcc - but gcc wasn't seeing the failure), but the ideas in the patch make sense. So, unless there is an easy way to make Travis run on candidate patches, I'll wait for a review rather than pushing this as a build-breaker. Eric Blake (3): maint: Drop unused GETTEXT_CPPFLAGS variable maint: Prefer AM_CPPFLAGS over INCLUDES maint: Avoid -Ignulib on standalone examples examples/Makefile.am | 8 +++++++- gnulib/lib/Makefile.am | 2 -- gnulib/tests/Makefile.am | 2 -- src/Makefile.am | 6 +++--- tests/Makefile.am | 6 +++--- tools/Makefile.am | 4 ++-- 6 files changed, 15 insertions(+), 13 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH] util: Fix the default log output to 'journald' when running under systemd
by Erik Skultety 07 Jan '19

07 Jan '19

Essentially, bring back the old behaviour as of commit eba36a38 which was later changed by commit ae06048bf5d. Even though all the stderr messages will eventually end up in the journal, we're not making use of the fields journald provides. https://bugzilla.redhat.com/show_bug.cgi?id=1592644 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/util/virlog.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index cb6901d9bf..3ee58c5db6 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -223,11 +223,17 @@ virLogSetDefaultOutputToFile(const char *filename, bool privileged) int virLogSetDefaultOutput(const char *filename, bool godaemon, bool privileged) { - if (!godaemon) + bool have_journald = access("/run/systemd/journal/socket", W_OK) >= 0; + + if (godaemon) { + if (have_journald) + return virLogSetDefaultOutputToJournald(); + } else { + if (!isatty(STDIN_FILENO) && have_journald) + return virLogSetDefaultOutputToJournald(); + return virLogSetDefaultOutputToStderr(); - - if (access("/run/systemd/journal/socket", W_OK) >= 0) - return virLogSetDefaultOutputToJournald(); + } return virLogSetDefaultOutputToFile(filename, privileged); } -- 2.20.1

2 1

[libvirt] [PATCH 00/19] implement cgroups v2 devices support
by Pavel Hrdina 07 Jan '19

07 Jan '19

In cgroups v2 there is no devices controller, BPF should be used instead. Patches 3 - 12 will be squashed into single commit and they need to be compiled together, I've separated them to make review easier. Pavel Hrdina (19): util: introduce virbpf helpers vircgroup: introduce virCgroupV2DevicesAvailable vircgroup: introduce virCgroupV2DeviceLoadProg vircgroup: introduce virCgroupV2DeviceAttachProg vircgroup: introduce virCgroupV2DeviceDetectProg vircgroup: introduce virCgroupV2DeviceCreateProg vircgroup: introduce virCgroupV2DeviceReallocMap vircgroup: introduce virCgroupV2DevicePrepareProg vircgroup: introduce virCgroupV2DeviceRemoveProg vircgroup: introduce virCgroupV2DeviceGetPerms vircgroup: introduce virCgroupV2DeviceGetKey vircgroup: introduce virCgroupV2AllowDevice vircgroup: introduce virCgroupV2DenyDevice vircgroup: introduce virCgroupV2AllowAllDevices vircgroup: introduce virCgroupV2DenyAllDevices vircgroup: workaround devices in hybrid mode vircgroupv2: detech BPF program before removing cgroup vircgroupv2: use dummy process to workaround kernel bug with systemd vircgroupmock: mock virBPFQueryProg include/libvirt/virterror.h | 1 + src/Makefile.am | 1 + src/libvirt_private.syms | 17 + src/lxc/lxc_cgroup.c | 1 + src/qemu/qemu_cgroup.c | 6 +- src/util/Makefile.inc.am | 2 + src/util/virbpf.c | 263 ++++++++++++ src/util/virbpf.h | 249 ++++++++++++ src/util/vircgroup.c | 18 +- src/util/vircgroup.h | 1 + src/util/vircgroupbackend.h | 3 +- src/util/vircgrouppriv.h | 12 + src/util/vircgroupv1.c | 9 +- src/util/vircgroupv2.c | 638 +++++++++++++++++++++++++++++- src/util/virerror.c | 1 + src/util/virsystemd.c | 2 +- src/util/virsystemd.h | 2 + tests/vircgroupdata/hybrid.parsed | 2 +- tests/vircgroupmock.c | 11 + tests/vircgrouptest.c | 4 +- 20 files changed, 1233 insertions(+), 10 deletions(-) create mode 100644 src/util/virbpf.c create mode 100644 src/util/virbpf.h -- 2.20.1

2 20

[libvirt] [PATCH 0/3] Rebase LXC network definition to support version 3.0
by Julio Faracco 07 Jan '19

07 Jan '19

The series propose a new way to define NICs inside LXC native. It is needed because LXC version 3.X uses indexes to define NICs and the current algorithm is not able to support them. At least, if you consider settings defined using a random logic. Julio Faracco (3): lxc: refactoring LXC network definition with a sparse array. tests: Change legacy network configs to version 3.0 with indexes. tests: Include a random network testcase to test indexes. src/lxc/lxc_native.c | 191 ++++++++++++------ .../lxcconf2xml-ethernet-v3.config | 16 +- .../lxcconf2xml-fstab-v3.config | 10 +- .../lxcconf2xml-macvlannetwork-v3.config | 10 +- .../lxcconf2xml-miscnetwork-v3.config | 38 ++-- .../lxcconf2xml-physnetwork-v3.config | 14 +- .../lxcconf2xml-randomnetwork-v3.config | 21 ++ .../lxcconf2xml-randomnetwork.xml | 45 +++++ .../lxcconf2xml-simple-v3.config | 18 +- .../lxcconf2xml-vlannetwork-v3.config | 10 +- tests/lxcconf2xmltest.c | 1 + 11 files changed, 249 insertions(+), 125 deletions(-) create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-randomnetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-randomnetwork.xml -- 2.19.1

2 4

[libvirt] [PATCH 0/2] News update for libvirt-5.0
by Han Han 07 Jan '19

07 Jan '19

Han Han (2): news: Add support for "stibp" x86_64 feature news: Add support for postcopy-requests migration statistics docs/news.xml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) -- 2.20.1

2 3

[libvirt] [jenkins-ci PATCH 0/2] Stop building Go projects on CentOS 7
by Andrea Bolognani 07 Jan '19

07 Jan '19

Found while creating a new CentOS 7 guest from scratch using lcitool. See the commit messages for more details. Andrea Bolognani (2): Stop building Go projects on CentOS 7 guests: Don't prepare CentOS 7 for Go projects guests/host_vars/libvirt-centos-7/main.yml | 2 -- guests/playbooks/build/projects/libvirt-go-xml.yml | 13 ++++++++++++- guests/playbooks/build/projects/libvirt-go.yml | 13 ++++++++++++- projects/libvirt-go-xml.yaml | 9 ++++++++- projects/libvirt-go.yaml | 9 ++++++++- 5 files changed, 40 insertions(+), 6 deletions(-) -- 2.19.2

3 5

[libvirt] [PATCH] lxc: allow empty path in URI for historical compatibility
by Daniel P. Berrangé 07 Jan '19

07 Jan '19

The use of 'lxc://' was mistakenly broken in: commit 4c8574c85c554e68de0d8bf9b85727954a5bea91 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Mar 28 12:49:29 2018 +0100 driver: ensure NULL URI isn't passed to drivers with whitelisted URIs Allow it again for historical compatibility. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/lxc/lxc_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index de045c80bb..df15a0da50 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -140,7 +140,8 @@ static virDrvOpenStatus lxcConnectOpen(virConnectPtr conn, virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); /* If path isn't '/' then they typoed, tell them correct path */ - if (STRNEQ(conn->uri->path, "/") && + if (STRNEQ(conn->uri->path, "") && + STRNEQ(conn->uri->path, "/") && STRNEQ(conn->uri->path, "/system")) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unexpected LXC URI path '%s', try lxc:///system"), -- 2.19.2

2 1

[libvirt] [GSoC] Update ideas page
by Michal Prívozník 07 Jan '19

07 Jan '19

Dear list, Google announced another round of GSoC [1]. The organization applications can be filled mid January next year (~1.5 month to go). Please update our Ideas page [2] if you have any idea for student projects (you do not have to mentor it if you don't feel like it). Similarly, if you want to mentor certain idea and there is no mentor assigned yet, do not hesitate to add yourself there. Michal 1: https://developers.google.com/open-source/gsoc/timeline 2: https://wiki.libvirt.org/page/Google_Summer_of_Code_Ideas

2 1