- Devel - libvirt List Archives

[libvirt] [PATCH 00/10] qemu: Probe events from 'query-qmp-schema'
by Peter Krempa 07 Feb '19

07 Feb '19

This applies on top of: [libvirt] [PATCH v2 00/32] qemu: add support for 'device_id' of SCSI disks (blockdev-add saga) https://www.redhat.com/archives/libvir-list/2019-February/msg00098.html The last patch does _not_ fix the numbering, please see the commit message of 10/10. Peter Krempa (10): qemu: caps: Always assume QEMU_CAPS_BALLOON_EVENT qemu: Clean up usage of qemuDomainUpdateCurrentMemorySize qemu: caps: Always assume QEMU_CAPS_SEAMLESS_MIGRATION tests: qemuhotplug: Remove unused test macro DO_TEST_DETACH_EVENT tests: qemuhotplug: Use DEVICE_DELETED event in all hotunplug tests tests: qemuhotplug: Remove leftovers for non-event testing qemu: caps: Always assume QEMU_CAPS_DEVICE_DEL_EVENT qemu: caps: Always assume QEMU_CAPS_DEVICE_TRAY_MOVED qemu: caps: Probe events from 'query-qmp-schema' rather than 'query-events' qemu: caps: Don't call 'query-events' when we probe them from QMP schema src/qemu/qemu_capabilities.c | 16 +- src/qemu/qemu_capabilities.h | 8 +- src/qemu/qemu_command.c | 10 +- src/qemu/qemu_domain.c | 57 +------- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 23 +-- src/qemu/qemu_hotplug.c | 15 +- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_process.c | 3 - .../caps_1.5.3.x86_64.xml | 4 - .../caps_1.6.0.x86_64.xml | 4 - .../caps_1.7.0.x86_64.xml | 4 - .../caps_2.1.1.x86_64.xml | 4 - .../caps_2.10.0.aarch64.replies | 122 ---------------- .../caps_2.10.0.aarch64.xml | 4 - .../caps_2.10.0.ppc64.replies | 122 ---------------- .../caps_2.10.0.ppc64.xml | 4 - .../caps_2.10.0.s390x.replies | 122 ---------------- .../caps_2.10.0.s390x.xml | 4 - .../caps_2.10.0.x86_64.replies | 122 ---------------- .../caps_2.10.0.x86_64.xml | 4 - .../caps_2.11.0.s390x.replies | 122 ---------------- .../caps_2.11.0.s390x.xml | 4 - .../caps_2.11.0.x86_64.replies | 122 ---------------- .../caps_2.11.0.x86_64.xml | 4 - .../caps_2.12.0.aarch64.replies | 128 ---------------- .../caps_2.12.0.aarch64.xml | 4 - .../caps_2.12.0.ppc64.replies | 128 ---------------- .../caps_2.12.0.ppc64.xml | 4 - .../caps_2.12.0.s390x.replies | 128 ---------------- .../caps_2.12.0.s390x.xml | 4 - .../caps_2.12.0.x86_64.replies | 128 ---------------- .../caps_2.12.0.x86_64.xml | 4 - .../caps_2.4.0.x86_64.xml | 4 - .../caps_2.5.0.x86_64.replies | 116 --------------- .../caps_2.5.0.x86_64.xml | 4 - .../caps_2.6.0.aarch64.replies | 122 ---------------- .../caps_2.6.0.aarch64.xml | 4 - .../caps_2.6.0.ppc64.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 4 - .../caps_2.6.0.x86_64.replies | 122 ---------------- .../caps_2.6.0.x86_64.xml | 4 - .../caps_2.7.0.s390x.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 4 - .../caps_2.7.0.x86_64.replies | 122 ---------------- .../caps_2.7.0.x86_64.xml | 4 - .../caps_2.8.0.s390x.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 4 - .../caps_2.8.0.x86_64.replies | 122 ---------------- .../caps_2.8.0.x86_64.xml | 4 - .../caps_2.9.0.ppc64.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 4 - .../caps_2.9.0.s390x.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 4 - .../caps_2.9.0.x86_64.replies | 122 ---------------- .../caps_2.9.0.x86_64.xml | 4 - .../caps_3.0.0.ppc64.replies | 131 ----------------- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 4 - .../caps_3.0.0.riscv32.replies | 134 ----------------- .../caps_3.0.0.riscv32.xml | 4 - .../caps_3.0.0.riscv64.replies | 134 ----------------- .../caps_3.0.0.riscv64.xml | 4 - .../caps_3.0.0.s390x.replies | 134 ----------------- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 4 - .../caps_3.0.0.x86_64.replies | 134 ----------------- .../caps_3.0.0.x86_64.xml | 4 - .../caps_3.1.0.ppc64.replies | 137 ------------------ .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 4 - .../caps_3.1.0.x86_64.replies | 137 ------------------ .../caps_3.1.0.x86_64.xml | 4 - .../caps_4.0.0.riscv32.replies | 137 ------------------ .../caps_4.0.0.riscv32.xml | 4 - .../caps_4.0.0.riscv64.replies | 137 ------------------ .../caps_4.0.0.riscv64.xml | 4 - .../caps_4.0.0.x86_64.replies | 137 ------------------ .../caps_4.0.0.x86_64.xml | 4 - tests/qemuhotplugtest.c | 79 +++------- tests/qemuxml2argvdata/channel-spicevmc.args | 2 +- tests/qemuxml2argvdata/controller-order.args | 3 +- .../graphics-spice-agent-file-xfer.args | 3 +- .../graphics-spice-agentmouse.args | 2 +- .../graphics-spice-auto-socket-cfg.args | 3 +- .../graphics-spice-auto-socket.args | 3 +- .../graphics-spice-compression.args | 3 +- .../graphics-spice-egl-headless.args | 2 +- .../graphics-spice-no-args.args | 2 +- .../graphics-spice-qxl-vga.args | 2 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 2 +- .../graphics-spice-socket.args | 2 +- .../graphics-spice-timeout.args | 2 +- .../graphics-spice-usb-redir.args | 2 +- tests/qemuxml2argvdata/graphics-spice.args | 2 +- tests/qemuxml2argvdata/name-escape.args | 2 +- .../q35-virt-manager-basic.args | 2 +- tests/qemuxml2argvdata/serial-spiceport.args | 3 +- .../video-virtio-gpu-spice-gl.args | 2 +- 96 files changed, 80 insertions(+), 4257 deletions(-) -- 2.20.1

3 23

[libvirt] [PATCH v1 1/1] qemu_process.c: add CAP_IPC_LOCK when using libcap-ng
by Daniel Henrique Barboza 07 Feb '19

07 Feb '19

QEMU virtual machines with PCI passthrough of certain devices, such as the NVIDIA Tesla V100 GPU, requires allocation of an amount of memory pages that can break KVM limits. When that happens, the KVM module checks if the process is IPC_LOCK capable and, in case it doesn't, it refuses to allocate the mem pages, causing the guest to misbehave. When Libvirt is compiled to use libcap-ng support, the resulting QEMU guest Libvirt creates does not have CAP_IPC_LOCK, hurting guests that are doing PCI passthrough and that requires extra memory to work. This patch addresses this issue by checking whether we're running with libcap-ng support (WITH_CAPNG) and if the guest is using PCI passthrough with the VFIO driver. If those conditions are met, allow CAP_IPC_LOCK capability to the QEMU process. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/libvirt_private.syms | 1 + src/qemu/qemu_process.c | 34 ++++++++++++++++++++++++++++++++++ src/util/virhostdev.c | 2 +- src/util/virhostdev.h | 4 ++++ 4 files changed, 40 insertions(+), 1 deletion(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6b401aa5e0..b7384a67a8 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1992,6 +1992,7 @@ virHostCPUStatsAssign; # util/virhostdev.h virHostdevFindUSBDevice; +virHostdevGetPCIHostDeviceList; virHostdevIsMdevDevice; virHostdevIsSCSIDevice; virHostdevManagerGetDefault; diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0583eb03f2..24aef5904f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4997,6 +4997,38 @@ qemuProcessSetupRawIO(virQEMUDriverPtr driver, } +static void +qemuProcessSetupVFIOCaps(virDomainObjPtr vm ATTRIBUTE_UNUSED, + virCommandPtr cmd ATTRIBUTE_UNUSED) +{ +#if WITH_CAPNG + virPCIDeviceListPtr pcidevs = NULL; + bool has_vfio = false; + size_t i; + + pcidevs = virHostdevGetPCIHostDeviceList(vm->def->hostdevs, + vm->def->nhostdevs); + if (!pcidevs) + return; + + for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) { + virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i); + if (virPCIDeviceGetStubDriver(pci) == VIR_PCI_STUB_DRIVER_VFIO) { + has_vfio = true; + break; + } + } + + if (has_vfio) { + VIR_DEBUG("Adding CAP_IPC_LOCK to QEMU process"); + virCommandAllowCap(cmd, CAP_IPC_LOCK); + } + + virObjectUnref(pcidevs); +#endif +} + + static int qemuProcessSetupBalloon(virQEMUDriverPtr driver, virDomainObjPtr vm, @@ -6569,6 +6601,8 @@ qemuProcessLaunch(virConnectPtr conn, if (qemuProcessSetupRawIO(driver, vm, cmd) < 0) goto cleanup; + qemuProcessSetupVFIOCaps(vm, cmd); + virCommandSetPreExecHook(cmd, qemuProcessHook, &hookData); virCommandSetMaxProcesses(cmd, cfg->maxProcesses); virCommandSetMaxFiles(cmd, cfg->maxFiles); diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 6be395cdda..ee389a1729 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -218,7 +218,7 @@ virHostdevManagerGetDefault(void) return virObjectRef(manager); } -static virPCIDeviceListPtr +virPCIDeviceListPtr virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, int nhostdevs) { virPCIDeviceListPtr pcidevs; diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h index 7263f320a2..9235581242 100644 --- a/src/util/virhostdev.h +++ b/src/util/virhostdev.h @@ -57,6 +57,10 @@ struct _virHostdevManager { }; virHostdevManagerPtr virHostdevManagerGetDefault(void); +virPCIDeviceListPtr +virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, + int nhostdevs) + ATTRIBUTE_NONNULL(1); int virHostdevPreparePCIDevices(virHostdevManagerPtr hostdev_mgr, const char *drv_name, -- 2.20.1

3 5

[libvirt] [PATCH 0/3] bhyve: implement MSRs ignore unknown writes feature
by Roman Bogorodskiy 07 Feb '19

07 Feb '19

Roman Bogorodskiy (3): conf: introduce 'msrs' feature bhyve: implement MSRs ignore unknown writes feature news: document bhyve msrs feature docs/drvbhyve.html.in | 16 +++++++++ docs/formatdomain.html.in | 1 + docs/news.xml | 11 ++++++ docs/schemas/domaincommon.rng | 14 ++++++++ src/bhyve/bhyve_command.c | 4 +++ src/conf/domain_conf.c | 33 +++++++++++++++++ src/conf/domain_conf.h | 8 +++++ src/qemu/qemu_domain.c | 1 + .../bhyvexml2argvdata/bhyvexml2argv-msrs.args | 10 ++++++ .../bhyvexml2argv-msrs.ldargs | 3 ++ .../bhyvexml2argvdata/bhyvexml2argv-msrs.xml | 26 ++++++++++++++ tests/bhyvexml2argvtest.c | 1 + .../bhyvexml2xmlout-msrs.xml | 36 +++++++++++++++++++ tests/bhyvexml2xmltest.c | 1 + 14 files changed, 165 insertions(+) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-msrs.xml -- 2.20.1

3 8

[libvirt] [PATCH] virinitctl: Provide a stub list of init fifos for non-Linux
by Michal Privoznik 07 Feb '19

07 Feb '19

The virInitctlFifos list is exported, but lacks definition for non-Linux and/or non-BSD case. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build breaker rule. src/util/virinitctl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/util/virinitctl.c b/src/util/virinitctl.c index bbcbbb483d..6966e8a3e9 100644 --- a/src/util/virinitctl.c +++ b/src/util/virinitctl.c @@ -184,6 +184,11 @@ virInitctlSetRunLevel(const char *fifo, return ret; } #else +/* On non-Linux and non-BSD there are no known inits */ +const char *virInitctlFifos[] = { + NULL +}; + int virInitctlSetRunLevel(const char *fifo ATTRIBUTE_UNUSED, virInitctlRunLevel level ATTRIBUTE_UNUSED) { -- 2.19.2

1 0

[libvirt] [PATCH 0/4] qemu: clean up qemuDomainBlockJobAbort/Pivot (blockdev-add saga)
by Peter Krempa 07 Feb '19

07 Feb '19

Peter Krempa (4): qemu: Always save status XML in qemuDomainBlockJobAbort qemu: Move shareable disk check for block copy qemu: Remove unused 'cfg' qemuDomainBlockPivot qemu: Use data in qemuBlockJobDataPtr instead of re-generating job name src/qemu/qemu_driver.c | 46 +++++++++++++++--------------------------- 1 file changed, 16 insertions(+), 30 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH 0/5] Couple of LXC fixes
by Michal Privoznik 07 Feb '19

07 Feb '19

*** BLURB HERE *** Michal Prívozník (5): lxc: Use correct job type for destroying a domain vircgroup: Try harder to kill cgroup lxc: Restore seclabels after the container is killed virinitctl: Expose fifo paths and allow caller to chose one lxc: Don't reboot host on virDomainReboot src/libvirt_private.syms | 1 + src/lxc/lxc_domain.c | 77 ++++++++++++++++++++++++++++++++++++++++ src/lxc/lxc_domain.h | 4 +++ src/lxc/lxc_driver.c | 19 ++-------- src/lxc/lxc_process.c | 22 ++++++------ src/util/vircgroup.c | 15 ++++---- src/util/virinitctl.c | 66 +++++++++++++++++++++------------- src/util/virinitctl.h | 6 +++- 8 files changed, 152 insertions(+), 58 deletions(-) -- 2.19.2

3 12

[libvirt] [PATCH] conf: Remove iothreads restriction in virDomainDefCheckABIStabilityFlags
by Jie Wang 06 Feb '19

06 Feb '19

The number of iothreads is not part of the vm state sent during migration, nor exposed to the guest ABI, so this restriction is a mistaken in libvirt. Let's remove that bit of code. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/conf/domain_conf.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ae8fb5a501..ac4eeaec5e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22927,14 +22927,6 @@ virDomainDefCheckABIStabilityFlags(virDomainDefPtr src, if (!virDomainDefVcpuCheckAbiStability(src, dst)) goto error; - if (src->niothreadids != dst->niothreadids) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain iothreads count %zu does not " - "match source %zu"), - dst->niothreadids, src->niothreadids); - goto error; - } - if (src->os.type != dst->os.type) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target domain OS type %s does not match source %s"), -- 2.16.2.windows.1

2 1

[libvirt] [PATCH] storage: fix volume perms when it is not specified.
by Julio Faracco 06 Feb '19

06 Feb '19

This commit adds permissions inheritance to volume from main pool when it is not explicitly added by command or XML definition. It permissions are defined into XML, they should be respected. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=677242 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/storage/storage_driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 4a13e90481..5961d35f26 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1850,6 +1850,16 @@ storageVolCreateXML(virStoragePoolPtr pool, goto cleanup; } + /* Inherit perms and mode from pool when they are not defined. */ + if (voldef->target.perms->uid == (uid_t)-1) + voldef->target.perms->uid = def->target.perms.uid; + + if (voldef->target.perms->gid == (gid_t)-1) + voldef->target.perms->gid = def->target.perms.gid; + + if (voldef->target.perms->mode == (mode_t)-1) + voldef->target.perms->mode = def->target.perms.mode; + if (virStorageVolCreateXMLEnsureACL(pool->conn, def, voldef) < 0) goto cleanup; -- 2.19.1

3 2

[libvirt] [libvirt-glib] gconfig: Add gvir_config_storage_vol_target_set_features
by Christophe Fergeau 06 Feb '19

06 Feb '19

Only one feature is supported at the moment, 'lazy refcount' Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com> --- .../libvirt-gconfig-storage-vol-target.c | 14 ++++++++++++++ .../libvirt-gconfig-storage-vol-target.h | 6 ++++++ libvirt-gconfig/libvirt-gconfig.sym | 6 ++++++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 27 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c index 751c950c..300d3927 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c @@ -109,3 +109,17 @@ void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *targe gvir_config_object_set_node_content(GVIR_CONFIG_OBJECT(target), "compat", compat); } + +void gvir_config_storage_vol_target_set_features(GVirConfigStorageVolTarget *target, + guint64 features) +{ + g_return_if_fail(GVIR_CONFIG_IS_STORAGE_VOL_TARGET(target)); + g_return_if_fail((features & ~GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT) == 0); + + if ((features & GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT) != 0) { + GVirConfigObject *features_node; + features_node = gvir_config_object_replace_child(GVIR_CONFIG_OBJECT(target), "features"); + gvir_config_object_set_node_content(features_node, "lazy_refcount", ""); + g_object_unref(features_node); + } +} diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h index 2030e734..f1b50035 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h @@ -69,6 +69,12 @@ void gvir_config_storage_vol_target_set_format(GVirConfigStorageVolTarget *targe const char *format); void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget *target, GVirConfigStoragePermissions *perms); +typedef enum { + GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT = 1 << 0 +} GVirConfigStorageVolTargetFeatures; + +void gvir_config_storage_vol_target_set_features(GVirConfigStorageVolTarget *target, + guint64 features); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index ee5bf8ad..2d7486ea 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -779,4 +779,10 @@ global: gvir_config_domain_set_custom_xml_ns_children; } LIBVIRT_GCONFIG_0.2.4; +LIBVIRT_GCONFIG_2.0.1 { +global: + gvir_config_storage_vol_target_features_get_type; + gvir_config_storage_vol_target_set_features; +} LIBVIRT_GCONFIG_2.0.0; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 79c242f4..f8fd6d51 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++ b/libvirt-gconfig/tests/test-domain-create.c @@ -498,6 +498,7 @@ int main(int argc, char **argv) gvir_config_storage_vol_target_set_format(vol_target, "qcow2"); gvir_config_storage_vol_target_set_permissions(vol_target, perms); gvir_config_storage_vol_target_set_compat(vol_target, "1.1"); + gvir_config_storage_vol_target_set_features(vol_target, GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT); g_object_unref(G_OBJECT(perms)); gvir_config_storage_vol_set_target(vol, vol_target); g_object_unref(G_OBJECT(vol_target)); -- 2.20.1

2 1

[libvirt] [PATCH 00/18] qemu: virtio-{non-}transitional support
by Cole Robinson 06 Feb '19

06 Feb '19

This series adds support for virtio-transitional and virtio-non-transitional qemu devices. qemu patches, queued for qemu 4.0.0: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg00923.html Previous libvirt discussion around this: https://www.redhat.com/archives/libvir-list/2018-August/msg01073.html Previous incomplete RFC here: https://www.redhat.com/archives/libvir-list/2019-January/msg00346.html Long story short we need to expose these options so apps have a usable way to support rhel6 + virtio + q35. This series exposes the new devices as model= values. This required adding new model= attributes for several devices. Here's the breakdown. 'standard names' here means the model names virtio, virtio-transitional, and virtio-non-transitional * Simply extended: virtio-rng: extend existing <rng model=X> to handle standard names vhost-vsock: extend existing <vsock model=X> to handle standard names virtio-memballoon: extend existings <memballoon model=X> to handle standard names virtio-net: extend existing qemu <model type=X> handling to support standard names * Extended with caveats: virtio-serial: extend <controller type='virtio-serial'> to handle existing model=X attribute, with standard names virtio-scsi: extend <controller type='scsi' model=X> to handle the additional names virtio-transitional and virtio-non-transitional. model= already supports virtio-scsi here which is a departure from just model='virtio' which most others use, but I chose to not extend that pattern and stick with the names the other devices are using vhost-scsi: extend <hostdev model=X> handling for the protocol=vhost case, to accept standard names. I stuck with standard names over using vhost-transitional or similar, for consistency with other devices. * New XML elements virtio-blk: add new <disk model=X/> attribute with standard names virtio-fs: add new <filesystem model=X> attribute with standard names virtio-input-host: add new <input model=X> attribute with standard names At the end is an extension to domaincapabilities to report the disk bus model values. Until domaincapabilities is fully fleshed out with support for all the above devices, apps can use that disk model check to assume transitional devices are available for all of the above. Cole Robinson (18): tests: Add capabilities data for QEMU 4.0.0 x86_64 conf: Add <disk model='virtio-{non-}transitional'/> qemu: Support disk model=virtio-{non-}transitional conf: Add virDomainNetHasVirtioModel qemu: Support interface model=virtio-{non-}transitional conf: Add <hostdev model='virtio-{non-}transitional'/> qemu: Support hostdev model=virtio-{non-}transitional qemu: Support rng model=virtio-{non-}transitional conf: Add <filesystem model='virtio-{non-}transitional'/> qemu: Support filesystem model=virtio-{non-}transitional qemu: Move memballoon validation out of command.c qemu: Support memballoon model=virtio-{non-}transitional qemu: Support vsock model=virtio-{non-}transitional conf: Add <input model='virtio-{non-}transitional'/> qemu: Support input model=virtio-{non-}transitional qemu: Support scsi controller model=virtio-{non-}transitional qemu: Support virtio-serial controller model=virtio-{non-}transitional qemu: domcaps: Report disk <enum name="model"> docs/formatdomain.html.in | 39 +- docs/schemas/domaincommon.rng | 60 +- src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 216 +- src/conf/domain_conf.h | 68 +- src/libvirt_private.syms | 5 + src/libxl/libxl_conf.c | 2 + src/qemu/qemu_capabilities.c | 55 + src/qemu/qemu_capabilities.h | 28 + src/qemu/qemu_command.c | 219 +- src/qemu/qemu_domain.c | 47 +- src/qemu/qemu_domain_address.c | 69 +- src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_interface.c | 8 +- src/qemu/qemu_process.c | 3 +- src/security/virt-aa-helper.c | 2 +- src/vbox/vbox_common.c | 2 + src/vmx/vmx.c | 4 +- .../bhyve_basic.x86_64.xml | 1 + .../bhyve_fbuf.x86_64.xml | 1 + .../bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 6 + .../domaincapsschemadata/libxl-xenfv-usb.xml | 1 + .../domaincapsschemadata/libxl-xenpv-usb.xml | 1 + .../qemu_1.7.0.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + .../qemu_2.12.0.ppc64.xml | 1 + .../qemu_2.12.0.s390x.xml | 1 + .../qemu_2.12.0.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + .../qemu_2.6.0.aarch64.xml | 1 + .../domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + .../qemu_2.6.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + .../qemu_2.8.0-tcg.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + .../qemu_2.8.0.x86_64.xml | 1 + .../qemu_2.9.0-q35.x86_64.xml | 1 + .../qemu_2.9.0-tcg.x86_64.xml | 1 + .../qemu_2.9.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_3.0.0.s390x.xml | 1 + .../qemu_4.0.0.x86_64.xml | 153 + tests/domaincapstest.c | 4 + .../caps_4.0.0.x86_64.replies | 23180 ++++++++++++++++ .../caps_4.0.0.x86_64.xml | 1404 + tests/qemucapabilitiestest.c | 1 + .../virtio-non-transitional.x86_64-3.1.0.args | 63 + ...virtio-non-transitional.x86_64-latest.args | 62 + .../virtio-non-transitional.xml | 40 + .../virtio-transitional.x86_64-3.1.0.args | 50 + .../virtio-transitional.x86_64-latest.args | 52 + .../qemuxml2argvdata/virtio-transitional.xml | 40 + tests/qemuxml2argvmock.c | 2 +- tests/qemuxml2argvtest.c | 6 + .../virtio-non-transitional.xml | 121 + .../virtio-transitional.xml | 80 + tests/qemuxml2xmltest.c | 17 + 59 files changed, 26031 insertions(+), 112 deletions(-) create mode 100644 tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies create mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml create mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.x86_64-3.1.0.args create mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.xml create mode 100644 tests/qemuxml2argvdata/virtio-transitional.x86_64-3.1.0.args create mode 100644 tests/qemuxml2argvdata/virtio-transitional.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-transitional.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-non-transitional.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-transitional.xml -- 2.20.1

4 80