- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/4] PPC64 support for NVIDIA V100 GPU with NVLink2 passthrough
by Daniel Henrique Barboza 12 Mar '19

12 Mar '19

This series includes Libvirt support for a new QEMU feature for the spapr (PPC64) machine, NVIDIA V100 + P9 passthrough. Refer to [1] for the version 3 of this feature (same version used as a reference for this series). Changes in v3: - added a new patch (patch 2) that isolates the PPC64 exclusive code to calculate the memLockLimit (suggested by Erik Skultety) - fixed 'make syntax-check' errors across all patches - v2 can be found at [2] [1] https://patchwork.kernel.org/cover/10831413/ [2] https://www.redhat.com/archives/libvir-list/2019-March/msg00059.html Daniel Henrique Barboza (4): qemu_domain: simplify non-VFIO memLockLimit calc for PPC64 qemu_domain: add a PPC64 memLockLimit helper qemu_domain: NVLink2 device tree functions for PPC64 PPC64 support for NVIDIA V100 GPU with NVLink2 passthrough src/qemu/qemu_domain.c | 402 ++++++++++++++++++++++++++++++++--------- 1 file changed, 321 insertions(+), 81 deletions(-) -- 2.20.1

4 19

[libvirt] [dockerfiles PATCH] Fix name for ppc64le architecture
by Andrea Bolognani 12 Mar '19

12 Mar '19

lcitool expects libvirt architecture names, which means the correct value for little-endian 64-bit PowerPC is ppc64le (VIR_ARCH_PPC64LE). Note that, while "ppc64el" is not an architecture name libvirt would recognize, mips64el (VIR_ARCH_MIPS64EL) and mipsel (VIR_ARCH_MIPSEL) are indeed correct. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- ...c64el.Dockerfile => buildenv-debian-9-cross-ppc64le.Dockerfile | 0 ...4el.Dockerfile => buildenv-debian-sid-cross-ppc64le.Dockerfile | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename buildenv-debian-9-cross-ppc64el.Dockerfile => buildenv-debian-9-cross-ppc64le.Dockerfile (100%) rename buildenv-debian-sid-cross-ppc64el.Dockerfile => buildenv-debian-sid-cross-ppc64le.Dockerfile (100%) diff --git a/buildenv-debian-9-cross-ppc64el.Dockerfile b/buildenv-debian-9-cross-ppc64le.Dockerfile similarity index 100% rename from buildenv-debian-9-cross-ppc64el.Dockerfile rename to buildenv-debian-9-cross-ppc64le.Dockerfile diff --git a/buildenv-debian-sid-cross-ppc64el.Dockerfile b/buildenv-debian-sid-cross-ppc64le.Dockerfile similarity index 100% rename from buildenv-debian-sid-cross-ppc64el.Dockerfile rename to buildenv-debian-sid-cross-ppc64le.Dockerfile -- 2.20.1

1 1

[libvirt] [jenkins-ci PATCH] lcitool: Raise Error instead of Exception
by Andrea Bolognani 12 Mar '19

12 Mar '19

This results in $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt FROM debian:9 ./lcitool: Unsupported architecture ppc64el being printed on error, instead of the much nastier $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt FROM debian:9 Traceback (most recent call last): File "./lcitool", line 704, in <module> Application().run() File "./lcitool", line 699, in run args.func(args) File "./lcitool", line 643, in _action_dockerfile deb_arch = Util.native_arch_to_deb_arch(args.cross_arch) File "./lcitool", line 126, in native_arch_to_deb_arch raise Exception("Unsupported architecture {}".format(native_arch)) Exception: Unsupported architecture foo Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/lcitool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index d6c8105..1119aaf 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -105,7 +105,7 @@ class Util: "x86_64": "x86_64-linux-gnu", } if native_arch not in archmap: - raise Exception("Unsupported architecture {}".format(native_arch)) + raise Error("Unsupported architecture {}".format(native_arch)) return archmap[native_arch] @staticmethod @@ -123,7 +123,7 @@ class Util: "x86_64": "amd64", } if native_arch not in archmap: - raise Exception("Unsupported architecture {}".format(native_arch)) + raise Error("Unsupported architecture {}".format(native_arch)) return archmap[native_arch] -- 2.20.1

3 5

[libvirt] [PATCH] resctrl: Fix testing line
by Martin Kletzander 12 Mar '19

12 Mar '19

Forgot to remove this before pushing. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial. src/util/virresctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index ab977b995c4d..9e477fc064ed 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -2166,10 +2166,8 @@ virResctrlAllocCopyMemBW(virResctrlAllocPtr dst, return -1; for (i = 0; i < src_bw->nbandwidths; i++) { - if (dst_bw->bandwidths[i]) { - *dst_bw->bandwidths[i] = 123; + if (dst_bw->bandwidths[i]) continue; - } if (VIR_ALLOC(dst_bw->bandwidths[i]) < 0) return -1; *dst_bw->bandwidths[i] = *src_bw->bandwidths[i]; -- 2.21.0

1 0

[libvirt] [PATCH 0/2] Add function for XML yes|no string handling
by Shotaro Gotanda 12 Mar '19

12 Mar '19

These patches are based on a bite-sized task proposed in https://wiki.libvirt.org/page/BiteSizedTasks and the mentor of this bite-sized task is Cole Robinson <crobinso(a)redhat.com> (Do I need to put the mentor in cc, in this case?) The function virStringParseYesNo() convert the string "yes" into bool true and "no" into false, and error if we receive anything other than those values. To be honest, I'm not confident on the error handling in libvirt. So, please check that point. Regards, Shotaro Shotaro Gotanda (2): util: add virStringParseYesNo() conf: Use virStringParseYesNo() src/conf/domain_conf.c | 30 +++++------------------------- src/conf/secret_conf.c | 12 ++---------- src/util/virstring.c | 32 ++++++++++++++++++++++++++++++++ src/util/virstring.h | 3 +++ 4 files changed, 42 insertions(+), 35 deletions(-) -- 2.19.1

4 9

[libvirt] [PATCH python v2] Fix handling of optional params in blockCopy()
by Nir Soffer 12 Mar '19

12 Mar '19

Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) changed the way the optional params argument is treated. If libvirt.virDomain.blockCopy() is called without specifying params, params is None, and the call will fail with: TypeError: block params must be a dictionary This is wrong as params is defined as kwarg, breaking existing libvirt users like oVirt. Add a check for Py_None, so we accept either a dict or None and fail with TypeError with anything else. Resolves: https://bugzilla.redhat.com/1687114 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- libvirt-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index 857c018..c5e2908 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -8835,11 +8835,11 @@ libvirt_virDomainBlockCopy(PyObject *self ATTRIBUTE_UNUSED, if (virPyDictToTypedParams(pyobj_dict, &params, &nparams, virPyDomainBlockCopyParams, VIR_N_ELEMENTS(virPyDomainBlockCopyParams)) < 0) { return NULL; } - } else { + } else if (pyobj_dict != Py_None) { PyErr_Format(PyExc_TypeError, "block params must be a dictionary"); return NULL; } dom = (virDomainPtr) PyvirDomain_Get(pyobj_dom); -- 2.17.2

3 2

[libvirt] [jenkins-ci PATCH] lcitool: Fix name for ppc64le architecture
by Andrea Bolognani 11 Mar '19

11 Mar '19

We're only exposing libvirt architecture names externally, which means the correct value for little-endian 64-bit PowerPC is ppc64le (VIR_ARCH_PPC64LE). Note that, while "ppc64el" is not an architecture name libvirt would recognize, mips64el (VIR_ARCH_MIPS64EL) and mipsel (VIR_ARCH_MIPSEL) are indeed correct. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/lcitool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 1d17c04..d6c8105 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -100,7 +100,7 @@ class Util: "mips": "mips-linux-gnu", "mipsel": "mipsel-linux-gnu", "mips64el": "mips64el-linux-gnuabi64", - "ppc64el": "powerpc64le-linux-gnu", + "ppc64le": "powerpc64le-linux-gnu", "s390x": "s390x-linux-gnu", "x86_64": "x86_64-linux-gnu", } @@ -118,7 +118,7 @@ class Util: "mips": "mips", "mipsel": "mipsel", "mips64el": "mips64el", - "ppc64el": "ppc64el", + "ppc64le": "ppc64el", "s390x": "s390x", "x86_64": "amd64", } -- 2.20.1

2 2

[libvirt] [PATCH 0/2] rbd: improvements to actual disk-usage calculation
by jdillama＠redhat.com 11 Mar '19

11 Mar '19

From: Jason Dillaman <dillaman(a)redhat.com> The RBD fast-diff feature can vastly reduce the amount of time needed to calculate actual disk usage of volumes, but it might still be a slow operation for large RBD pools or pools with large RBD images. Therefore, this feature should be able to be optionally disabled if needed. Additionally, the fast-diff feature can only be used if the fast-diff map isn't flagged as invalid. Otherwise, librbd will silently perform a costly block-by-block scan to calculate the disk usage. Jason Dillaman (2): rbd: do not attempt to use fast-diff if it's marked invalid rbd: optionally disable actual disk-usage during pool/volume refresh docs/formatstorage.html.in | 13 ++++- src/storage/storage_backend_rbd.c | 80 ++++++++++++++++++++++++++++--- 2 files changed, 84 insertions(+), 9 deletions(-) -- 2.20.1

3 4

[libvirt] [dockerfiles PATCH 0/4] Add cross-compilation Dockerfiles
by Andrea Bolognani 11 Mar '19

11 Mar '19

lcitool supports generating Dockerfiles targeting cross-compilation of libvirt, so all that's left to do is teach the refresh script how to pass the necessary information to lcitool. Andrea Bolognani (4): refresh: Drop shell implementation refresh: Add Python implementation refresh: Add support for cross-compilation Dockerfiles Add cross-compilation Dockerfiles buildenv-debian-9-cross-aarch64.Dockerfile | 95 +++++++++++ buildenv-debian-9-cross-armv6l.Dockerfile | 93 +++++++++++ buildenv-debian-9-cross-armv7l.Dockerfile | 94 +++++++++++ buildenv-debian-9-cross-mips.Dockerfile | 94 +++++++++++ buildenv-debian-9-cross-mips64el.Dockerfile | 94 +++++++++++ buildenv-debian-9-cross-mipsel.Dockerfile | 94 +++++++++++ buildenv-debian-9-cross-ppc64el.Dockerfile | 94 +++++++++++ buildenv-debian-9-cross-s390x.Dockerfile | 94 +++++++++++ buildenv-debian-sid-cross-aarch64.Dockerfile | 94 +++++++++++ buildenv-debian-sid-cross-armv6l.Dockerfile | 92 ++++++++++ buildenv-debian-sid-cross-armv7l.Dockerfile | 93 +++++++++++ buildenv-debian-sid-cross-mips.Dockerfile | 93 +++++++++++ buildenv-debian-sid-cross-mips64el.Dockerfile | 93 +++++++++++ buildenv-debian-sid-cross-mipsel.Dockerfile | 93 +++++++++++ buildenv-debian-sid-cross-ppc64el.Dockerfile | 93 +++++++++++ buildenv-debian-sid-cross-s390x.Dockerfile | 93 +++++++++++ refresh | 158 +++++++++++++++--- 17 files changed, 1631 insertions(+), 23 deletions(-) create mode 100644 buildenv-debian-9-cross-aarch64.Dockerfile create mode 100644 buildenv-debian-9-cross-armv6l.Dockerfile create mode 100644 buildenv-debian-9-cross-armv7l.Dockerfile create mode 100644 buildenv-debian-9-cross-mips.Dockerfile create mode 100644 buildenv-debian-9-cross-mips64el.Dockerfile create mode 100644 buildenv-debian-9-cross-mipsel.Dockerfile create mode 100644 buildenv-debian-9-cross-ppc64el.Dockerfile create mode 100644 buildenv-debian-9-cross-s390x.Dockerfile create mode 100644 buildenv-debian-sid-cross-aarch64.Dockerfile create mode 100644 buildenv-debian-sid-cross-armv6l.Dockerfile create mode 100644 buildenv-debian-sid-cross-armv7l.Dockerfile create mode 100644 buildenv-debian-sid-cross-mips.Dockerfile create mode 100644 buildenv-debian-sid-cross-mips64el.Dockerfile create mode 100644 buildenv-debian-sid-cross-mipsel.Dockerfile create mode 100644 buildenv-debian-sid-cross-ppc64el.Dockerfile create mode 100644 buildenv-debian-sid-cross-s390x.Dockerfile -- 2.20.1

2 6

[libvirt] [PATCH 0/1] Fix valgrind.supp path in Makefile.am
by Shotaro Gotanda 11 Mar '19

11 Mar '19

Hello, I'm Shotaro Gotanda from the University of Tokyo. I'm currently working toward GSOC'19, and creating several pathes for a bite-sized task. In that process, I encountered a problem in valgrind test. In detail, "make -C tests valgrind" failed with several cases even in master branch(commit 7a05c739c26decb8ff0eef4f6c75ce3ef729532d). I found a lot of error message like following in test-suite.log ==25680== FATAL: can't open suppressions file "./.valgrind.supp" This problem occurs in several environment; Lubuntu18.10(native), Ubuntu18.04(VM), Ubuntu16.04(VM). Though I have little idea about why this problem occured, the test succeeded with this patch. P.S. Because this is my first contribution to libvirt, I'm not familiar with reporting bugs, sending patches, and so on. So, I'll be so glad if you give me any feedback :) Shotaro Gotanda (1): tests: fix valgrind.supp path in Makefile tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.1

2 2