- Devel - libvirt List Archives

[PATCH v2 00/27] CI/build-sys fixes to enable Rust more widely
by marcandre.lureau＠redhat.com 02 Oct '25

02 Oct '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series fixes a number of issues with the build system and CI and enable Rust for many of our jobs, getting us closer to enable Rust by default. emscripten is difficult to enable, help welcome. v2: - add a rust-to-clang-target-test.sh configure script - drop "RFC: configure: use the same machine as the host triple" - replace "tests: move mips to debian-legacy-test-cross" with "RFC: build-sys: deprecate mips host" - start tackling emscripten - fix mis-placed submodule update - other minor changes, commit message tweaks, bz links - add r-b tags Marc-André Lureau (27): build-sys: require -lrt when no shm_open() in std libs gitlab-ci: fix 'needs' property type must be array scripts/archive-source: speed up downloading subprojects scripts/archive-source: silence subprojects downloads scripts/archive-source: use a bash array configure: fix rust meson configuration configure: set the bindgen cross target tests/docker/common: print errors to stderr tests/docker: use fully qualified image name for emsdk tests/docker/common: print meson log on configure failure build-sys: cfi_debug and safe_stack are not compatible lcitool: update, switch to f41 lcitool/qemu: include libclang-rt for TSAN lcitool/alpine: workaround bindgen issue tests/lcitool: add missing rust-std dep tests/lcitool: update to debian13 tests/docker: add ENABLE_RUST environment tests/lcitool: enable rust & refresh configure: set the meson executable suffix/ext tests/freebsd: enable Rust meson: rust-bindgen limit allowlist-file to srcdir/include RFC: tests/docker: add rust to debian-legacy-test-cross WIP: gitlab-ci: enable rust for msys2-64bit WIP: cirrus/macos: enable Rust RFC: build-sys: deprecate mips host build-sys: pass -fvisibility=default for wasm bindgen WIP: enable rust for wasm/emscripten docs/about/build-platforms.rst | 2 - docs/about/deprecated.rst | 9 +-- configure | 27 +++++++- meson.build | 34 +++++++--- .gitlab-ci.d/buildtest-template.yml | 2 +- .gitlab-ci.d/buildtest.yml | 66 +++++++++---------- .gitlab-ci.d/cirrus.yml | 4 +- .gitlab-ci.d/crossbuilds.yml | 46 ++++++------- .gitlab-ci.d/static_checks.yml | 6 +- .gitlab-ci.d/windows.yml | 8 ++- rust/bql/meson.build | 1 + rust/chardev/meson.build | 1 + rust/hw/char/pl011/meson.build | 1 + rust/hw/core/meson.build | 1 + rust/migration/meson.build | 3 +- rust/qom/meson.build | 1 + rust/system/meson.build | 1 + rust/util/meson.build | 1 + scripts/archive-source.sh | 33 +++++++--- .../ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 5 +- .../ci/setup/ubuntu/ubuntu-2204-s390x.yaml | 5 +- scripts/rust-to-clang-target-test.sh | 43 ++++++++++++ scripts/rust-to-clang-target.sh | 62 +++++++++++++++++ tests/docker/common.rc | 11 +++- tests/docker/dockerfiles/alpine.docker | 6 +- tests/docker/dockerfiles/centos9.docker | 4 ++ .../dockerfiles/debian-amd64-cross.docker | 18 +++-- .../dockerfiles/debian-arm64-cross.docker | 18 +++-- .../dockerfiles/debian-armhf-cross.docker | 21 +++--- .../dockerfiles/debian-i686-cross.docker | 20 ++++-- .../debian-legacy-test-cross.docker | 9 ++- .../dockerfiles/debian-mips64el-cross.docker | 9 ++- .../dockerfiles/debian-mipsel-cross.docker | 9 ++- .../dockerfiles/debian-ppc64el-cross.docker | 18 +++-- .../dockerfiles/debian-riscv64-cross.docker | 10 ++- .../dockerfiles/debian-s390x-cross.docker | 18 +++-- tests/docker/dockerfiles/debian.docker | 18 +++-- .../dockerfiles/emsdk-wasm32-cross.docker | 29 +++++++- .../dockerfiles/fedora-rust-nightly.docker | 18 +++-- .../dockerfiles/fedora-win64-cross.docker | 15 +++-- tests/docker/dockerfiles/fedora.docker | 18 +++-- tests/docker/dockerfiles/opensuse-leap.docker | 7 +- tests/docker/dockerfiles/ubuntu2204.docker | 7 +- tests/docker/test-wasm | 12 ++++ tests/lcitool/libvirt-ci | 2 +- tests/lcitool/projects/qemu.yml | 3 +- tests/lcitool/refresh | 48 +++++++++----- tests/vm/freebsd | 4 +- 48 files changed, 531 insertions(+), 183 deletions(-) create mode 100755 scripts/rust-to-clang-target-test.sh create mode 100644 scripts/rust-to-clang-target.sh create mode 100755 tests/docker/test-wasm -- 2.51.0

9 51

[PATCH] virt-login-shell: check for NULL from virGetLastError()
by gerben＠altlinux.org 01 Oct '25

01 Oct '25

From: Denis Rastyogin <gerben(a)altlinux.org> virGetLastError() may return NULL in case of OOM. Without a check this could lead to a NULL pointer dereference when accessing its fields. The result of virGetLastError() is usually checked in other places, so add the missing check here as well. Found by Linux Verification Center (linuxtesting.org) with SVACE. Reported-by: Pavel Nekrasov <p.nekrasov(a)fobos-nt.ru> Signed-off-by: Denis Rastyogin <gerben(a)altlinux.org> --- tools/virt-login-shell-helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helper.c index cb59b5dec0..9282ca481e 100644 --- a/tools/virt-login-shell-helper.c +++ b/tools/virt-login-shell-helper.c @@ -282,6 +282,10 @@ main(int argc, char **argv) if (!virDomainIsActive(dom) && virDomainCreate(dom) < 0) { virErrorPtr last_error; last_error = virGetLastError(); + + if (!last_error) + goto cleanup; + if (last_error->code != VIR_ERR_OPERATION_INVALID) { virReportSystemError(last_error->code, _("Can't create %1$s container: %2$s"), -- 2.42.2

3 3

Release of libvirt-11.8.0
by Jiri Denemark 01 Oct '25

01 Oct '25

The 11.8.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * ch: Disk hotplug Support Users can now attach and detach disks of Cloud Hypervisor domains at runtime. * qemu: Add support for NUMA affinity of PCI devices To support NVIDIA Multi-Instance GPU (MIG) configurations, libvirt now handles QEMU's acpi-generic-initiator device internally. MIG enables partitioning a physical GPU into multiple isolated instances, each associated with one or more virtual NUMA nodes. On the XML side, the existing ``<acpi>`` element has been extended with a ``nodeset`` attribute to specify the NUMA node affinity of a PCI device. * Improvements * ch: Events emitting The CH driver not only emits more domain lifecycle events but also implements ``virConnectDomainEventRegister()`` and ``virConnectDomainEventDeregister()`` APIs for management applications to listen on those events. * Bug fixes * qemu: Fix selection of stateless/combined firmware A stateless firmware will now be correctly chosen when appropriate, e.g. for domains configured to use SEV-SNP. * ch: Make sure the cloud-hypervisor process is killed in ``virCHProcessStop()`` Due to wrong assumptions in the CH driver, calling ``virDomainDestroy()`` did not kill the corresponding cloud-hypervisor process. Domains can be now destroyed reliably. Enjoy. Jirka

1 0

[PULL 00/23] Rust ci patches
by marcandre.lureau＠redhat.com 30 Sep '25

30 Sep '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> The following changes since commit 85a3fd1c4cb3ba7a9eb291c1e222f935e922d1f7: Merge tag 'pull-aspeed-20250929' of https://github.com/legoater/qemu into staging (2025-09-29 10:52:48 -0700) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.git tags/rust-ci-pull-request for you to fetch changes up to 582a39beea414c092dbd8c178f3eff3a718eee77: build-sys: pass -fvisibility=default for wasm bindgen (2025-09-30 19:33:25 +0400) ---------------------------------------------------------------- CI/build-sys fixes for Rust Collect CI/build-sys patches related to Rust. ---------------------------------------------------------------- Marc-André Lureau (23): build-sys: require -lrt when no shm_open() in std libs gitlab-ci: fix 'needs' property type must be array scripts/archive-source: speed up downloading subprojects scripts/archive-source: silence subprojects downloads scripts/archive-source: use a bash array configure: fix rust meson configuration configure: set the bindgen cross target tests/docker/common: print errors to stderr tests/docker: use fully qualified image name for emsdk tests/docker/common: print meson log on configure failure build-sys: cfi_debug and safe_stack are not compatible lcitool: update, switch to f41 lcitool/qemu: include libclang-rt for TSAN lcitool/alpine: workaround bindgen issue tests/lcitool: add missing rust-std dep tests/lcitool: update to debian13 tests/docker: add ENABLE_RUST environment tests/lcitool: enable rust & refresh configure: set the meson executable suffix/ext tests/freebsd: enable Rust meson: rust-bindgen limit allowlist-file to srcdir/include build-sys: deprecate mips host build-sys: pass -fvisibility=default for wasm bindgen docs/about/build-platforms.rst | 2 - docs/about/deprecated.rst | 9 +- configure | 23 +++- meson.build | 34 +++-- .gitlab-ci.d/buildtest.yml | 62 +++++----- .gitlab-ci.d/cirrus.yml | 2 +- .gitlab-ci.d/crossbuilds.yml | 46 +++---- .gitlab-ci.d/static_checks.yml | 6 +- rust/bql/meson.build | 1 + rust/chardev/meson.build | 1 + rust/hw/char/pl011/meson.build | 1 + rust/hw/core/meson.build | 1 + rust/migration/meson.build | 3 +- rust/qom/meson.build | 1 + rust/system/meson.build | 1 + rust/util/meson.build | 1 + scripts/archive-source.sh | 34 +++-- .../ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 5 +- .../ci/setup/ubuntu/ubuntu-2204-s390x.yaml | 5 +- scripts/rust-to-clang-target-test.sh | 43 +++++++ scripts/rust-to-clang-target.sh | 60 +++++++++ tests/docker/common.rc | 13 +- tests/docker/dockerfiles/alpine.docker | 6 +- tests/docker/dockerfiles/centos9.docker | 4 + .../dockerfiles/debian-amd64-cross.docker | 18 ++- .../dockerfiles/debian-arm64-cross.docker | 18 ++- .../dockerfiles/debian-armhf-cross.docker | 21 ++-- .../dockerfiles/debian-i686-cross.docker | 20 +-- .../dockerfiles/debian-mips64el-cross.docker | 9 +- .../dockerfiles/debian-mipsel-cross.docker | 9 +- .../dockerfiles/debian-ppc64el-cross.docker | 18 ++- .../dockerfiles/debian-riscv64-cross.docker | 116 +++++++++++++++++- .../dockerfiles/debian-s390x-cross.docker | 18 ++- tests/docker/dockerfiles/debian.docker | 18 ++- .../dockerfiles/emsdk-wasm32-cross.docker | 2 +- .../dockerfiles/fedora-rust-nightly.docker | 18 ++- .../dockerfiles/fedora-win64-cross.docker | 15 ++- tests/docker/dockerfiles/fedora.docker | 18 ++- tests/docker/dockerfiles/opensuse-leap.docker | 7 +- tests/docker/dockerfiles/ubuntu2204.docker | 7 +- tests/lcitool/libvirt-ci | 2 +- tests/lcitool/projects/qemu.yml | 3 +- tests/lcitool/refresh | 49 +++++--- tests/vm/freebsd | 4 +- 44 files changed, 574 insertions(+), 180 deletions(-) create mode 100755 scripts/rust-to-clang-target-test.sh create mode 100644 scripts/rust-to-clang-target.sh -- 2.51.0

1 23

[PATCH] libvirt-secret: handle empty value in virSecretSetValue()
by gerben＠altlinux.org 29 Sep '25

29 Sep '25

From: Denis Rastyogin <gerben(a)altlinux.org> virSecretSetValue() previously checked for NULL `value`, but did not handle the case where `value_size` is 0. This could lead to `new_value = g_new0(unsigned char, value_size)` returning NULL and subsequent `memcpy(new_value, value, value_size)` dereferencing a NULL pointer. Adding a check prevents this possible issue. Found by Linux Verification Center (linuxtesting.org) with SVACE. Reported-by: Vadim Urtaev <v.urtaev(a)fobos-nt.ru> Signed-off-by: Denis Rastyogin <gerben(a)altlinux.org> --- src/libvirt-secret.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c index 4d0c88745d..e4391d1841 100644 --- a/src/libvirt-secret.c +++ b/src/libvirt-secret.c @@ -569,6 +569,7 @@ virSecretSetValue(virSecretPtr secret, const unsigned char *value, virCheckReadOnlyGoto(conn->flags, error); virCheckNonNullArgGoto(value, error); + virCheckNonZeroArgGoto(value_size, error); if (conn->secretDriver != NULL && conn->secretDriver->secretSetValue != NULL) { int ret; -- 2.42.2

1 0

Entering freeze for libvirt-11.8.0
by Jiri Denemark 29 Sep '25

29 Sep '25

I have just tagged v11.8.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Jirka

1 1

[PATCH] NEWS: Fix format of XML elements/attributes in v11.8.0 section
by Michal Privoznik 29 Sep '25

29 Sep '25

From: Michal Privoznik <mprivozn(a)redhat.com> It's a good practice to use a different style of formatting for literal values like XML element/attribute names, functions, etc. In this specific case, the 'acpi' and 'nodeset' names should be formatted using two single quotes instead of double quote. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index d49e8f75c4..7fd9e92d4e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -29,8 +29,8 @@ v11.8.0 (unreleased) partitioning a physical GPU into multiple isolated instances, each associated with one or more virtual NUMA nodes. - On the XML side, the existing <acpi> element has been extended with a - "nodeset" attribute to specify the NUMA node affinity of a PCI device. + On the XML side, the existing ``<acpi>`` element has been extended with a + ``nodeset`` attribute to specify the NUMA node affinity of a PCI device. * **Improvements** -- 2.49.1

2 1

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 29 Sep '25

29 Sep '25

From: Michal Privoznik <mprivozn(a)redhat.com> There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 847dcb390b..d49e8f75c4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -34,6 +34,13 @@ v11.8.0 (unreleased) * **Improvements** + * ch: Events emitting + + The CH driver not only emits more domain lifecycle events but also + implements ``virConnectDomainEventRegister()`` and + ``virConnectDomainEventDeregister()`` APIs for management applications to + listen on those events. + * **Bug fixes** * qemu: Fix selection of stateless/combined firmware @@ -41,6 +48,12 @@ v11.8.0 (unreleased) A stateless firmware will now be correctly chosen when appropriate, e.g. for domains configured to use SEV-SNP. + * ch: Make sure the cloud-hypervisor process is killed in ``virCHProcessStop()`` + + Due to wrong assumptions in the CH driver, calling ``virDomainDestroy()`` + did not kill the corresponding cloud-hypervisor process. Domains can be now + destroyed reliably. + v11.7.0 (2025-09-01) ==================== -- 2.49.1

2 1

[PATCH] conf.c: use hwuuid for guest ABI stability check if present
by Mark Cave-Ayland 29 Sep '25

29 Sep '25

With the introduction of the hwuuid element it is possible to pass a separate hardware UUID from the domain UUID for use by the guest. In the case where the hwuuid element is present, it is the hardware UUID that is visible to the guest and not the domain UUID so adjust the check in virDomainDefCheckABIStabilityFlags() accordingly. Signed-off-by: Mark Cave-Ayland <mark.caveayland(a)nutanix.com> --- src/conf/domain_conf.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 281846dfbe..de0181f62b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22226,15 +22226,28 @@ virDomainDefCheckABIStabilityFlags(virDomainDef *src, goto error; } - if (memcmp(src->uuid, dst->uuid, VIR_UUID_BUFLEN) != 0) { - char uuidsrc[VIR_UUID_STRING_BUFLEN]; - char uuiddst[VIR_UUID_STRING_BUFLEN]; - virUUIDFormat(src->uuid, uuidsrc); - virUUIDFormat(dst->uuid, uuiddst); - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain uuid %1$s does not match source %2$s"), - uuiddst, uuidsrc); - goto error; + if (virUUIDIsValid(src->hw_uuid) && virUUIDIsValid(dst->hw_uuid)) { + if (memcmp(src->hw_uuid, dst->hw_uuid, VIR_UUID_BUFLEN) != 0) { + char uuidsrc[VIR_UUID_STRING_BUFLEN]; + char uuiddst[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(src->hw_uuid, uuidsrc); + virUUIDFormat(dst->hw_uuid, uuiddst); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target domain hwuuid %1$s does not match source %2$s"), + uuiddst, uuidsrc); + goto error; + } + } else { + if (memcmp(src->uuid, dst->uuid, VIR_UUID_BUFLEN) != 0) { + char uuidsrc[VIR_UUID_STRING_BUFLEN]; + char uuiddst[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(src->uuid, uuidsrc); + virUUIDFormat(dst->uuid, uuiddst); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target domain uuid %1$s does not match source %2$s"), + uuiddst, uuidsrc); + goto error; + } } if (src->genidRequested != dst->genidRequested) { -- 2.43.0

2 1

[PATCH] bhyve: hooks: improve process start error handling
by Roman Bogorodskiy 26 Sep '25

26 Sep '25

When the virBhyveProcessStart() fails early, make sure to execute the "stopped" and "release" hooks. Spotted while running TCK hooks tests against the bhyve driver. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/bhyve/bhyve_process.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 4bfd511bae..4fb7e642e1 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -413,18 +413,24 @@ virBhyveProcessStart(bhyveConn *driver, { /* Run an early hook to setup missing devices. */ if (bhyveProcessStartHook(driver, vm, VIR_HOOK_BHYVE_OP_PREPARE) < 0) - return -1; + goto cleanup; if (flags & VIR_BHYVE_PROCESS_START_AUTODESTROY) virCloseCallbacksDomainAdd(vm, conn, bhyveProcessAutoDestroy); if (bhyveProcessPrepareDomain(driver, vm, flags) < 0) - return -1; + goto cleanup; if (bhyveProcessPrepareHost(driver, vm->def, flags) < 0) - return -1; + goto cleanup; return virBhyveProcessStartImpl(driver, vm, reason); + + cleanup: + bhyveProcessStopHook(driver, vm, VIR_HOOK_BHYVE_OP_STOPPED); + bhyveProcessStopHook(driver, vm, VIR_HOOK_BHYVE_OP_RELEASE); + + return -1; } static void -- 2.51.0

2 1