- Devel - libvirt List Archives

[PATCH v2] qemu: Fix crash in qemuProcessStop due to NULL eventThread
by Pritam Srichandan Sahoo 09 Sep '26

09 Sep '26

When a VM shuts down, the monitor EOF event is queued to the worker thread pool. If another thread enters qemuProcessStop() first and frees priv->eventThread via g_steal_pointer(), the second call from the EOF event worker thread hits a NULL dereference when calling virEventThreadStop(priv->eventThread). The existing 'if (priv->eventThread)' guard is insufficient because the VM object is unlocked between the check and the call to virEventThreadStop(), allowing a concurrent thread to clear the pointer in the meantime. Fix this by taking a GObject reference to eventThread before unlocking the VM. This ensures the pointer remains valid for virEventThreadStop() even if another thread clears priv->eventThread concurrently. Crash backtrace: #0 virEventThreadStop (evt=0x0) #1 qemuProcessStop (reason=VIR_DOMAIN_SHUTOFF_SHUTDOWN, asyncJob=VIR_ASYNC_JOB_NONE) #2 processMonitorEOFEvent (driver=..., vm=...) #3 qemuProcessEventHandler (data=..., opaque=...) #4 virThreadPoolWorker (opaque=...) Signed-off-by: Pritam Srichandan Sahoo <PritamSrichandan.Sahoo(a)windriver.com> --- v2: Resend as an inline plain-text patch. The v1 posting was delivered as an email attachment which is harder to review; no code changes from v1. src/qemu/qemu_process.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0d9b8bcb93..642e18eeb1 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8850,13 +8850,15 @@ void qemuProcessStop(virQEMUDriver *driver, * the global domain object list code depends on it (and it can't actually * check 'priv->beingDestroyed as that's private). */ if (priv->eventThread) { + virEventThread *eventThread = g_object_ref(priv->eventThread); /* Explicitly set priv->beingDestroyed. While it's done in * qemuProcessBeginStopJob(), qemuProcessStop() is called from places * where stop job is not acquired. */ priv->beingDestroyed = true; virObjectUnlock(vm); - virEventThreadStop(priv->eventThread); + virEventThreadStop(eventThread); virObjectLock(vm); + g_object_unref(eventThread); } if (priv->agent) { -- 2.53.0

1 0

[PATCH] src: stop using deprecated syntax for hv-crash argument
by Daniel P. Berrangé 08 Sep '26

08 Sep '26

From: Daniel P. Berrangé <berrange(a)redhat.com> QEMU historically accepted bare keywords as a short-cut for turning on a boolean option. This was deprecated quite a long time ago and most usage would trigger a warning from QEMU, but the -cpu arg is special and doesn't warn. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_command.c | 2 +- tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/panic-double.x86_64-latest.args | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a07b915f4d..bcddb9c922 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6748,7 +6748,7 @@ qemuBuildCpuCommandLine(virCommand *cmd, for (i = 0; i < def->npanics; i++) { if (def->panics[i]->model == VIR_DOMAIN_PANIC_MODEL_HYPERV) { - virBufferAddLit(&buf, ",hv-crash"); + virBufferAddLit(&buf, ",hv-crash=on"); break; } } diff --git a/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args b/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args index ee0f8551c2..0182cc8e18 100644 --- a/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args +++ b/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=on \ -accel tcg \ --cpu qemu64,hv-crash \ +-cpu qemu64,hv-crash=on \ -m size=219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ -overcommit mem-lock=off \ diff --git a/tests/qemuxmlconfdata/panic-double.x86_64-latest.args b/tests/qemuxmlconfdata/panic-double.x86_64-latest.args index 9c5b3a7694..21ecaf4d84 100644 --- a/tests/qemuxmlconfdata/panic-double.x86_64-latest.args +++ b/tests/qemuxmlconfdata/panic-double.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=on \ -accel tcg \ --cpu qemu64,hv-crash \ +-cpu qemu64,hv-crash=on \ -m size=219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ -overcommit mem-lock=off \ -- 2.55.0

2 3

[PATCH 0/2] virnetdevbridge: support VLAN configuration on FreeBSD
by Roman Bogorodskiy 08 Sep '26

08 Sep '26

This series implements VLAN networking on FreeBSD. Specifically, it implements controlling bridge's VLAN filtering via the `macTableManager='libvirt'` in the network XML. And various configurations specified by domain's <vlan> element. I have documented my testing of these configurations here: https://gist.github.com/novel/e26e90f031f965920587bf126899356e I'd definitely appreciate a second pair of eyes on this to make sure the documented behavior matches the XML intent. Roman Bogorodskiy (2): virnetdevbridge: support VLAN filtering setting on FreeBSD virnetdevbridge: support VLAN configuration on FreeBSD src/util/virnetdevbridge.c | 110 +++++++++++++++++++++++++++++++++++-- 1 file changed, 105 insertions(+), 5 deletions(-) -- 2.55.0

2 3

[PULL v3 00/12] Misc fixes patches
by Daniel P. Berrangé 07 Sep '26

07 Sep '26

The following changes since commit ff1d2d19d7e24893e2012d879f8e73077e17b9bd: Merge tag 'pull-11.1-check-tcg-meson-040926-2' of https://gitlab.com/stsquad/qemu into staging (2026-09-04 16:52:58 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/misc-fixes-pull-request for you to fetch changes up to 0766e83d2f94285338e6c642b4b003ffafb142f4: docs/system/security: exclude uninitialized stack variables as bugs (2026-09-07 11:31:03 +0100) ---------------------------------------------------------------- Merge crypto, I/O and misc fixes * Deprecated the AF_ALG crypto backend * Improve checkpatch output in CI jobs * Document security policy for uninitialized stack variables * Fix multiple denial of service flaws in websockets * Fix error handling in some x509 APIs ---------------------------------------------------------------- Daniel P. Berrangé (3): crypto: deprecate the AF_ALG crypto backend gitlab: use --emacs --quiet for checkpatch.pl instead of --terse docs/system/security: exclude uninitialized stack variables as bugs Denis V. Lunev (6): io/channel-socket: do not treat a zero length write as an error io/channel-websock: send an HTTP 400 when the greeting has no space io/channel-websock: handle a blocked write during the handshake tests/unit: add websock handshake test io/channel-websock: do not lose QIO_CHANNEL_ERR_BLOCK while reading tests/unit: cover blocked IO during the websock handshake Evgeny Kolmakov (1): crypto: Use g_autofree Marc-André Lureau (2): crypto/x509-utils: don't double set errp crypto/x509-utils: propagate the error .gitlab-ci.d/check-patch.py | 6 +- crypto/block.c | 17 +- crypto/hmac-gcrypt.c | 12 +- crypto/hmac-glib.c | 10 +- crypto/ivgen-essiv.c | 15 +- crypto/ivgen.c | 6 +- crypto/secret_keyring.c | 5 +- crypto/x509-utils.c | 4 +- docs/about/deprecated.rst | 21 +++ docs/system/security.rst | 10 ++ io/channel-socket.c | 2 +- io/channel-websock.c | 10 +- meson.build | 6 + tests/unit/meson.build | 1 + tests/unit/test-io-channel-websock.c | 249 +++++++++++++++++++++++++++ 15 files changed, 326 insertions(+), 48 deletions(-) create mode 100644 tests/unit/test-io-channel-websock.c -- 2.55.0

2 13

[PULL v2 00/13] Misc fixes patches
by Daniel P. Berrangé 07 Sep '26

07 Sep '26

The following changes since commit 99e54ab5e7a6efc945af6d5661842155d1f3fc7a: Merge tag 'hw-misc-20260903' of https://github.com/philmd/qemu into staging (2026-09-03 16:43:24 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/misc-fixes-pull-request for you to fetch changes up to 39dfe7cf8e87d6de975bae6c10c3712f4df56ee6: docs/system/security: exclude uninitialized stack variables as bugs (2026-09-04 14:29:16 +0100) ---------------------------------------------------------------- Merge crypto, I/O and misc fixes * Deprecated the AF_ALG crypto backend * Improve checkpatch output in CI jobs * Fix --disable-containers arg handling in configure * Document security policy for uninitialized stack variables * Fix multiple denial of service flaws in websockets * Fix error handling in some x509 APIs ---------------------------------------------------------------- Daniel P. Berrangé (4): crypto: deprecate the AF_ALG crypto backend gitlab: use --emacs --quiet for checkpatch.pl instead of --terse configure: correctly honour --disable-containers docs/system/security: exclude uninitialized stack variables as bugs Denis V. Lunev (6): io/channel-socket: do not treat a zero length write as an error io/channel-websock: send an HTTP 400 when the greeting has no space io/channel-websock: handle a blocked write during the handshake tests/unit: add websock handshake test io/channel-websock: do not lose QIO_CHANNEL_ERR_BLOCK while reading tests/unit: cover blocked IO during the websock handshake Evgeny Kolmakov (1): crypto: Use g_autofree Marc-André Lureau (2): crypto/x509-utils: don't double set errp crypto/x509-utils: propagate the error .gitlab-ci.d/check-patch.py | 6 +- configure | 1 + crypto/block.c | 17 +- crypto/hmac-gcrypt.c | 12 +- crypto/hmac-glib.c | 10 +- crypto/ivgen-essiv.c | 15 +- crypto/ivgen.c | 6 +- crypto/secret_keyring.c | 5 +- crypto/x509-utils.c | 4 +- docs/about/deprecated.rst | 21 +++ docs/system/security.rst | 10 ++ io/channel-socket.c | 2 +- io/channel-websock.c | 10 +- meson.build | 6 + tests/unit/meson.build | 1 + tests/unit/test-io-channel-websock.c | 249 +++++++++++++++++++++++++++ 16 files changed, 327 insertions(+), 48 deletions(-) create mode 100644 tests/unit/test-io-channel-websock.c -- 2.55.0

2 15

[PATCH v2 0/2] ch: support NUMA and cpu topology configuration
by Thomas Prescher 04 Sep '26

04 Sep '26

This patch set adds NUMA cell configuration and cpu topology support to the cloud-hyervisor driver. The first patch adds NUMA awareness so users can map guest NUMA nodes to host NUMA nodes. The second patch allows the user to define a concrete vCPU topology that is presented to the guest. Stefan Kober (2): ch: support for numa awareness ch: support CPU topology configuration src/ch/ch_monitor.c | 173 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 171 insertions(+), 2 deletions(-) -- 2.53.0

3 4

[PATCH 0/2] qemu: Fix hot plugged host CPUs not being used
by Ilya Leoshkevich 04 Sep '26

04 Sep '26

Hi, This series fixes hot plugged host CPUs not being used to schedule guest virtual CPUs. Patch 1 is the fix, patch 2 is the test. If the fix is acceptable and the test needs changes, it would be great to have the fix committed separately. Best regards, Ilya Boris Fiuczynski (1): tests: add qemuprocesstest for qemuProcessGetAllCpuAffinity Ilya Leoshkevich (1): qemu: Fix hot plugged host CPUs not being used src/qemu/qemu_process.c | 26 ++++++-- src/qemu/qemu_process.h | 2 + src/util/virhostcpu.h | 6 +- tests/meson.build | 1 + tests/qemuprocessmock.c | 65 ++++++++++++++++++ tests/qemuprocesstest.c | 144 ++++++++++++++++++++++++++++++++++++++++ tests/qemuprocesstest.h | 25 +++++++ 7 files changed, 261 insertions(+), 8 deletions(-) create mode 100644 tests/qemuprocessmock.c create mode 100644 tests/qemuprocesstest.c create mode 100644 tests/qemuprocesstest.h -- 2.55.0

3 5

[PATCH 0/2] ch: Fix validation and add persistent domain support
by shotor＠shotor.com 04 Sep '26

04 Sep '26

From: shotor <shotor(a)shotor.com> The first patch fixes the validation flag used by chDomainDefineXMLFlags(). The second patch adds persistent domain support to the Cloud Hypervisor driver, including saving and loading domain definitions and reporting their persistence state. shotor (2): ch: Fix define validation flag ch: Add persistent domain support src/ch/ch_conf.c | 13 +++++++--- src/ch/ch_conf.h | 1 + src/ch/ch_driver.c | 65 ++++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 70 insertions(+), 9 deletions(-) -- 2.55.0

4 11

[PATCH v2 0/8] various fixes for 11.2 (gitlab, tests, char-fe, fdc, mailmap, deprecations) pre-PR
by Alex Bennée 04 Sep '26

04 Sep '26

This is a rather random selection of fixes that didn't quite make it to 11.1 although we have some qemu-stable material in here. The CFLAGS tweak allow another target to be built and tested on MacOS. There are also riscv64 compilers which could be enabled via brew but I don't have time to look at those. The CFLAGS changes are also subsumed into Pierrick's check-tcg meson updates which might hit first. The char-fe clean-up removes a code smell of device models reaching into qemu_chr_fe_get_driver which is poor practice. The fdc fix resolves one of the many security reports for those that still care about floppy controllers in VMs. In my brief excursion into our confidential bugs I did look at fixing virtio-crypto but found it needs some serious love. Therefor I'm taking the other option of deprecating the module. Finally I'm experimenting with using b4's patch series handling so forgive any finger trouble on this series. I'll roll the PR on Wednesday. Alex. Signed-off-by: Alex Bennée <alex.bennee(a)linaro.org> --- Changes in v2: - added mailmap patch - added fcd test case at review request (AI-used-for trailer) - tweaked virtio-crypto deprecation and commit message - Link to v1: https://lore.kernel.org/qemu-devel/20260819-fixes-for-11-2-v1-0-b7981c2cc37… To: qemu-devel(a)nongnu.org Cc: Philippe Mathieu-Daudé <philmd(a)mailo.com> Cc: Alex Bennée <alex.bennee(a)linaro.org> Cc: Pierrick Bouvier <pierrick.bouvier(a)oss.qualcomm.com> Cc: Peter Maydell <peter.maydell(a)linaro.org> Cc: qemu-arm(a)nongnu.org Cc: "Michael S. Tsirkin" <mst(a)redhat.com> Cc: Stefano Garzarella <sgarzare(a)redhat.com> Cc: "Gonglei (Arei)" <arei.gonglei(a)huawei.com> Cc: zhenwei pi <zhenwei.pi(a)linux.dev> Cc: Laurent Vivier <lvivier(a)redhat.com> Cc: Amit Shah <amit(a)kernel.org> Cc: Marc-André Lureau <marcandre.lureau(a)redhat.com> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: John Snow <jsnow(a)redhat.com> Cc: Kevin Wolf <kwolf(a)redhat.com> Cc: Hanna Reitz <hreitz(a)redhat.com> Cc: qemu-block(a)nongnu.org Cc: Fabiano Rosas <farosas(a)suse.de> Cc: devel(a)lists.libvirt.org --- Alex Bennée (7): gitlab: use .base_meson_job_template for macOS jobs tests/arm: add explicit CFLAGS for system build gitlab: add arm-softmmu tests to the macOS build char-fe: implement qemu_chr_fe_backend_name hw/block: validate the fdc sector position fits within bounds tests/qtest: add test case for fdc sector overflow docs: deprecate virtio-crypto Denis V. Lunev (1): mailmap: map the last From-munged author back to a real identity docs/about/deprecated.rst | 18 +++ hw/block/fdc-internal.h | 1 + include/chardev/char-fe.h | 13 +- backends/cryptodev-vhost-user.c | 8 +- backends/rng-egd.c | 8 +- backends/vhost-user.c | 8 +- hw/block/fdc.c | 30 ++++- hw/char/imx_serial.c | 4 +- tests/qtest/fdc-test.c | 246 +++++++++++++++++++++++++++++++++- .gitlab-ci.d/macos.yml | 7 +- .mailmap | 1 + tests/tcg/arm/Makefile.softmmu-target | 2 +- 12 files changed, 307 insertions(+), 39 deletions(-) --- base-commit: 3375621e78660838b862d411c43f90e905d0b985 change-id: 20260819-fixes-for-11-2-f98744b82c12 Best regards, -- Alex Bennée <alex.bennee(a)linaro.org>

4 13

[PATCH v2 0/2] qemu: fix and clean up resctrl monitor domstats
by Jedrzej Wasiukiewicz 04 Sep '26

04 Sep '26

Fix two independent inconsistencies in resctrl monitor domstats reporting. The first patch reports the actual resctrl monitor group name instead of its internal ID. The second avoids reporting a zero cache monitor count when no cache monitor data is available, matching the memory bandwidth and energy collectors. These patches were previously posted as part of the whole-process resctrl series: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QFXZ… Changes since v1: - Split the independent fixes from the whole-process feature series. - Rebased onto current master. - Added Christopher's Reviewed-by. - Limited the domstats cleanup to the independent cache monitor fix. whole-process vCPU reporting remains in the feature series. Jedrzej Wasiukiewicz (2): qemu: fix resctrl monitor stats reporting the wrong group name qemu: omit empty cache monitor domstats src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 5 ++++- src/util/virresctrl.c | 10 ++++++++++ src/util/virresctrl.h | 3 +++ 4 files changed, 18 insertions(+), 1 deletion(-) -- 2.43.0 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

2 3