- Devel - libvirt List Archives

[Libvir] new ruby error handling
by Vadim Zaliva 14 Apr '08

14 Apr '08

I have a dumb question about new error handling. What is the rationale for using 'libvirt_message' instead of 'message' in new Libvirt Ruby error classes? Here is an example of code I am writing: rescue SystemCallError process($!.message) ... rescue Libvirt::Error process($!.libvirt_message) ... instead of, shorter: rescue Libvirt::Error, SystemCallError process($!.message) ... In reality, my rescue classes are bit longer, so the code gets hairy. Wouldn't it be better to use standard 'message' attribute instead? Sincerely, Vadim -- "La perfection est atteinte non quand il ne reste rien a ajouter, mais quand il ne reste rien a enlever." (Antoine de Saint-Exupery)

3 4

[Libvir] Documentation for virConnectOpenAuth
by Richard W.M. Jones 13 Apr '08

13 Apr '08

Documentation for virConnectOpenAuth is a bit light at the moment. I found: http://libvirt.org/html/libvirt-libvirt.html#virConnectOpenAuth http://libvirt.org/auth.html This is the most serious omission from the documentation: http://libvirt.org/html/libvirt-libvirt.html#virConnectAuthCallbackPtr virConnectAuthPtrDefault is a default implementation of the callback that you should use for command-line tools. It's used in virsh.c. It's not documented at all, but the source for it (in libvirt.c) does give a little bit of guidance. Anyway, as long as there isn't some font of documentation for this call which I've missed, I'll have a go at writing some while I write the OCaml binding. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 1

[Libvir] Relative paths in domain XML
by Richard W.M. Jones 13 Apr '08

13 Apr '08

What would be really useful is to allow paths (eg. to file-backed block devices) to be relative in a useful way. This would let you have the domain XML configuration file & the block device files sit next to each other to give a machine description: mydomain.hda.img mydomain.xml # refers to <source file="mydomain.hda.img"> This isn't possible at the moment as far as I can tell, which means you need to know which directory the files are located in, and you can't move them around. [As an aside, at present the QEMU driver makes no attempt to check that the source file is an absolute path, it just passes whatever it finds to the '-hdc' argument to qemu.] For the command: virsh define mydomain.xml One implementation would be to have virsh rewriting paths, but that requires special knowledge of the XML format in virsh so I don't think it's a workable idea. Another would be to allow virsh to supply a 'base URI' (basically, the current directory) to the virDomainDefineXML call. Any thoughts? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

2 1

[Libvir] API confusion...
by Spencer Parker 11 Apr '08

11 Apr '08

Since I am kind of an idiot and don't know what I am doing...I am having trouble with getting network stats to work in Python. I have everything correct...but I am just not sure exactly what it is looking for. I get this error: libvir: Xen error : invalid argument in xenHypervisorDomainInterfaceStats: invalid path, should be vif<domid>.<n>. I guess I just need some kind of example to work from on this. -- Spencer Parker _______________________________________________________ "if you can't go to heaven, may you at least die in Ireland." _______________________________________________________

2 3

[Libvir] ANNOUNCE: Ruby bindings for libvirt, version 0.0.6
by David Lutterkort 10 Apr '08

10 Apr '08

I'm pleased to announce version 0.0.6 of the Ruby bindings for libvirt. The most notable addition is support for the libvirt storage API. From the NEWS file: * Explicit free methods for various objects (based on a patch by Vadim Zaliva) * Make the FLAGS argument for various calls optional, and default it to 0. (Chris Lalancette) * More finegrained exceptions on errors, containing libvirt error message (Mohammed Morsi) * Bindings for the libvirt storage API (requires libvirt 0.4.1) * Suppress some bindings if the underlying libvirt doesn't support it * Bindings for virDomainSetMemory, virDomainPinVcpu, and virDomainSetVcpus (Vadim Zaliva) The main site for ruby-libvirt is http://libvirt.org/ruby API docs can be found at http://libvirt.org/ruby/api/index.html Please send all your patches (and comments/questions) to this list. David

1 0

[Libvir] XVDA
by Spencer Parker 10 Apr '08

10 Apr '08

I have on question...when I go to grab blockStats...why do I have use XVDA vs. HDA? Just wondering if there was something I was missing. I have all of my Xen Domu's set up to use HDA is there some compelling reason to change over? -- Spencer Parker _______________________________________________________ "if you can't go to heaven, may you at least die in Ireland." _______________________________________________________

2 1

[Libvir] [PATCH] Very minor patch to remove unused uid field in virsh structure
by Richard W.M. Jones 10 Apr '08

10 Apr '08

Since we removed the test for uid==0 in virsh, the uid field in the control structure is no longer needed or used. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 1

[Libvir] [PATCH 4/4] HACKING: begin to describe contributor/coding guidelines
by Jim Meyering 10 Apr '08

10 Apr '08

This is the name many projects already use for their code-contribution guidelines, but if people here prefer something different, it's trivial to change. For now, it's not included in the tarball (and I think that's appropriate), but adding it there is fine, too. Of course, this is just one small part. Dan Berrange posted a preliminary list a few months ago, describing some aspects of existing practice, and those belong here, too. Jim ----------------------- HACKING: New file: begin to describe contributor/coding guidelines. diff --git a/HACKING b/HACKING new file mode 100644 index 0000000..a90addc --- /dev/null +++ b/HACKING @@ -0,0 +1,45 @@ +Libvirt contributor guidelines +============================== + + +Code indentation +================ +Libvirt's C source code generally adheres to some basic code-formatting +conventions. The existing code base is not totally consistent on this +front, but we do prefer that contributed code be formatted similarly. +In short, use spaces-not-TABs for indentation, use 4 spaces for each +indentation level, and other than that, follow the K&R style. + +If you use Emacs, add the following to one of one of your start-up files +(e.g., ~/.emacs), to help ensure that you get indentation right: + + ;;; When editing C sources in libvirt, use this style. + (defun libvirt-c-mode () + "C mode with adjusted defaults for use with libvirt." + (interactive) + (c-set-style "K&R") + (setq indent-tabs-mode nil) ; indent using spaces, not TABs + (setq c-indent-level 4) + (setq c-basic-offset 4)) + (add-hook 'c-mode-hook + '(lambda () (if (string-match "/libvirt" (buffer-file-name)) + (libvirt-c-mode)))) + +Code formatting (especially for new code) +========================================= +With new code, we can be even more strict. +Please apply the following function (using GNU indent) to any new code. +Note that this also gives you an idea of the type of spacing we prefer +around operators and keywords: + + indent-libvirt() + { + indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l75 -lc75 \ + -sbi4 -psl -saf -sai -saw -sbi4 -ss -sc -cdw -cli4 -npcs -nbc \ + --no-tabs "$@" + } + +Note that sometimes you'll have to postprocess that output further, by +piping it through "expand -i", since some leading TABs can get through. +Usually they're in macro definitions or strings, and should be converted +anyhow. -- 1.5.5.24.g3cff

3 3

[Libvir] [PATCH 3/4] Ensure that no C source file uses TABs for indentation
by Jim Meyering 10 Apr '08

10 Apr '08

Ensure that no C source file uses TABs for indentation. * Makefile.maint (sc_TAB_in_indentation): New rule. diff --git a/Makefile.maint b/Makefile.maint index a357d74..4e41134 100644 --- a/Makefile.maint +++ b/Makefile.maint @@ -287,6 +287,17 @@ sc_trailing_blank: { echo '$(ME): found trailing blank(s)' \ 1>&2; exit 1; } || : +# Ensure that no C source file uses TABs for indentation. +# Also match *.h.in files, to get libvirt.h.in. +# Exclude files in gnulib, since they're imported. +sc_TAB_in_indentation: + @grep -lE '^ * ' /dev/null \ + $$($(VC_LIST_EXCEPT) \ + | grep -E '\.[ch](\.in)?$$' \ + | grep -v '^gnulib/') && \ + { echo '$(ME): found TAB(s) use for indentation; use spaces' \ + 1>&2; exit 1; } || : + # Match lines like the following, but where there is only one space # between the options and the description: # -D, --all-repeated[=delimit-method] print all duplicate lines\n -- 1.5.5.24.g3cff

3 3

[Libvir] [PATCH 2/4] Convert TAB-based indentation in .[ch] files to spaces
by Jim Meyering 10 Apr '08

10 Apr '08

3 2