September 2026 - Devel - libvirt List Archives

[PATCH] virBitmapNewCopy: skip copying zero-sized bitmaps
by Roman Bogorodskiy 21 Sep '26

21 Sep '26

The Ubuntu clang CI build currently fails on genericxml2xmltest with: ../src/util/virbitmap.c:590:12: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:48:28: note: nonnull attribute specified here Which is happening on memcpy() in virBitmapNewCopy(). This happens when copying a zero-sized bitmap. Fix by calling memcpy() only when the source and destination bitmaps are not zero-sized. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/util/virbitmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 78545501b7..b75ba61a99 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -587,7 +587,8 @@ virBitmapNewCopy(virBitmap *src) { virBitmap *dst = virBitmapNew(src->nbits); - memcpy(dst->map, src->map, dst->map_len * sizeof(src->map[0])); + if (dst->map && src->map) + memcpy(dst->map, src->map, dst->map_len * sizeof(src->map[0])); return dst; } -- 2.55.0

2 1

[PATCH v2 0/2] qemu: Support backup and fsync optional attributes in SWTPM
by Arun Menon 19 Sep '26

19 Sep '26

In the upcoming release of swtpm, 2 new options, backup and fsync will be added to the directory backend [1] and [2]. This allows the user to backup and fsync the state file and its parent directory. It lowers the probability of TPM state file corruption in case of a power loss. Although this has not been added to the stable swtpm release yet, Libvirt will require some changes to incorporate these options in the XML config. Following is the sample xml configuration snip to enable backup and fsync: <tpm model='tpm-crb'> <backend type='emulator' version='2.0' backup='yes' fsync='yes'/> </tpm> Tested with swtpm commit #8ecf2c1 and libtpms commit #18e42c8d: $ ps aux | grep swtpm arun 33881 0.0 0.0 24080 10188 ? S 00:09 0:00 /usr/local/bin/swtpm socket --ctrl type=unixio,path=/run/user/1000/libvirt/qemu/run/swtpm/5-guest-vm-swtpm.sock,mode=0600 --tpmstate dir=/home/arun/.config/libvirt/qemu/swtpm/0a64239e-6311-4e53-8903-d1d49608a751/tpm2,mode=0600,lock,backup,fsync --log file=/home/arun/.cache/libvirt/qemu/log/guest-vm-swtpm.log --terminate --tpm2 $ ls -lrt $HOME/.config/libvirt/qemu/swtpm/0a64239e-6311-4e53-8903-d1d49608a751/tpm2 total 16 -rw-------. 1 arun arun 6807 Sep 7 00:14 tpm2-00.permall.bak -rw-------. 1 arun arun 6807 Sep 7 01:02 tpm2-00.permall [1] https://github.com/stefanberger/swtpm/commit/186f72a3a995fc68957ffc0b1438bb… [2] https://github.com/stefanberger/swtpm/commit/795c1973c913da59925fa6c2d688c5… Changes since v1: - Use TriStateBool type for both backup and sync in virDomainTPMDefParseXML() - Refactor qemuTPMVirCommandSwtpmAddTPMState() to use virBuffer API and return errors on failure. Arun Menon (2): conf: Add backup and fsync optional swtpm attributes qemu: tpm: Add backup and fsync options to the swtpm command docs/formatdomain.rst | 15 +++++ src/conf/domain_conf.c | 22 ++++++++ src/conf/domain_conf.h | 2 + src/conf/schemas/domaincommon.rng | 10 ++++ src/qemu/qemu_tpm.c | 55 ++++++++++++++----- src/util/virtpm.c | 2 + src/util/virtpm.h | 2 + .../qemuxmlconfdata/tpm-emulator-tpm2-enc.xml | 2 +- 8 files changed, 96 insertions(+), 14 deletions(-) -- 2.54.0

1 2

Plans for 12.8.0 release (freeze on 2026-09-24)
by Jiri Denemark 18 Sep '26

18 Sep '26

We are getting close to 12.8.0 release of libvirt. To aim for the release on Thursday 01 Oct I suggest entering the freeze on Thursday 24 Sep and tagging RC2 on Tuesday 29 Sep. I hope this works for everyone. Jirka

1 0

[PATCH] vsh: Remove 'disconnected' set-only global variable
by Peter Krempa 18 Sep '26

18 Sep '26

From: Peter Krempa <pkrempa(a)redhat.com> The instance of the 'disconnected' global variable in vsh.c is written-only, so can be removed. Caught by new clang: clang -Itools/libvirt_shell.a.p -Itools -I../tools -Iinclude -I../include -Isrc -I../src -Isrc/util -I../src/util -I. -I.. -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -O2 -g @/builds/libvirt/libvirt/build/c-warnings.txt -fPIC -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -D_FUNCTION_DEF -pthread -DWITH_GZFILEOP -MD -MQ tools/libvirt_shell.a.p/vsh.c.o -MF tools/libvirt_shell.a.p/vsh.c.o.d -o tools/libvirt_shell.a.p/vsh.c.o -c ../tools/vsh.c ../tools/vsh.c:242:12: error: variable 'disconnected' set but not used [-Werror,-Wunused-but-set-global] 242 | static int disconnected; /* we may have been disconnected */ | ^ 1 error generated. This instance exists since the 'vsh' module was split (834c5720e44). 'virsh' contains it's own instance. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tools/vsh.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 667cc1a0d2..d1540810ee 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -236,12 +236,6 @@ vshReportError(vshControl *ctl) vshResetLibvirtError(); } -/* - * Detection of disconnections and automatic reconnection support - */ -static int disconnected; /* we may have been disconnected */ - - /* vshCmddefSearch: * @cmdname: name of command to find * @@ -1392,16 +1386,6 @@ vshCommandRun(vshControl *ctl, after = g_get_real_time(); - /* try to automatically catch disconnections */ - if (ret != EXIT_SUCCESS && - ((last_error != NULL) && - (((last_error->code == VIR_ERR_SYSTEM_ERROR) && - (last_error->domain == VIR_FROM_REMOTE)) || - (last_error->code == VIR_ERR_RPC) || - (last_error->code == VIR_ERR_NO_CONNECT) || - (last_error->code == VIR_ERR_INVALID_CONN)))) - disconnected++; - if (ret != EXIT_SUCCESS) vshReportError(ctl); -- 2.55.0

2 1

[PATCH] qemu: allow large VMs without IOMMU for x86
by Anton Gerasimov 17 Sep '26

17 Sep '26

Extended Destination ID is an alternative to interrupt remapping in IOMMU enabled in QEMU by default when kernel-irqchip=split is used. Signed-off-by: Anton Gerasimov <agerasimov(a)nebius.com> --- src/qemu/qemu_validate.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index e946f55351..c8af25828b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -954,10 +954,12 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps) QEMU_MAX_VCPUS_WITHOUT_X2APIC); return -1; } - if (!def->iommus || (def->iommus[0]->eim != VIR_TRISTATE_SWITCH_ON && - def->iommus[0]->xtsup != VIR_TRISTATE_SWITCH_ON)) { + if ((def->features[VIR_DOMAIN_FEATURE_IOAPIC] != VIR_DOMAIN_IOAPIC_QEMU) && + (!def->iommus || + (def->iommus[0]->eim != VIR_TRISTATE_SWITCH_ON && + def->iommus[0]->xtsup != VIR_TRISTATE_SWITCH_ON))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("more than %1$d vCPUs require EIM or XTSup mode enabled on the iommu device"), + _("more than %1$d vCPUs require either IOAPIC in QEMU or an iommu device with EIM or XTSup mode enabled"), QEMU_MAX_VCPUS_WITHOUT_X2APIC); return -1; } -- 2.43.0

1 0

[PATCH] bhyve: remove transient domains on shutdown
by Roman Bogorodskiy 17 Sep '26

17 Sep '26

Currently, transient domains are removed when destroyed. But the shutdown event ends up handled by the monitor which does not remove the domain. Update bhyveMonitorIO() to remove the domain if it's transient and not active. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/922 Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- Related TCK change: https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/94 src/bhyve/bhyve_monitor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bhyve/bhyve_monitor.c b/src/bhyve/bhyve_monitor.c index 379e588070..dab07ff95f 100644 --- a/src/bhyve/bhyve_monitor.c +++ b/src/bhyve/bhyve_monitor.c @@ -186,6 +186,9 @@ bhyveMonitorIO(int watch, int kq, int events G_GNUC_UNUSED, void *opaque) } } + if (!virDomainObjIsActive(vm) && !vm->persistent) + virDomainObjListRemove(driver->domains, vm); + cleanup: virObjectUnlock(vm); } -- 2.55.0

2 1

[PATCH 0/2] esxConnectListInterfaces: Fix array bounds checking and refactor counting
by Peter Krempa 16 Sep '26

16 Sep '26

Peter Krempa (2): esxConnectListInterfaces: Actually check bounds of 'names' array esxConnectListInterfaces: Reuse also in 'esxConnectNumOfInterfaces' src/esx/esx_interface_driver.c | 42 ++++++++++++---------------------- 1 file changed, 15 insertions(+), 27 deletions(-) -- 2.55.0

2 3

[PATCH] qemu: add process_exit_wait configuration setting
by Jim Fehlig 15 Sep '26

15 Sep '26

From: Jim Fehlig <jfehlig(a)suse.com> When shutting down a VM, libvirt sends the associated QEMU process SIGTERM, waits 10 seconds for it to disappear, optionally sends SIGKILL, then waits up to another 30 seconds for the process to exit before reporting and returning an error. Commit be2ca04447 added 2 seconds per assigned host device to the total time libvirt waits for a QEMU process to terminate. Other scenarios than the one described in be2ca04447 could delay the clean exit of QEMU, e.g. reclaiming memory of VMs with large memory allocations backed by 4k pages on the host. Instead of trying to cover all such scenarios based on VM configuration, introduce a 'process_exit_wait' setting in qemu.conf to control how much additional time (in seconds) libvirt will wait for a QEMU process to terminate before reporting an error. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf.in | 12 ++++++++++++ src/qemu/qemu_conf.c | 3 +++ src/qemu/qemu_conf.h | 1 + src/qemu/qemu_process.c | 13 ++++++++++--- src/qemu/test_libvirtd_qemu.aug.in | 1 + 6 files changed, 28 insertions(+), 3 deletions(-) diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index 311992e441..dc3d6d61df 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -132,6 +132,7 @@ module Libvirtd_qemu = | bool_entry "dump_guest_core" | str_entry "stdio_handler" | int_entry "max_threads_per_process" + | int_entry "process_exit_wait" | str_entry "sched_core" let device_entry = bool_entry "mac_filter" diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 97b0141cf6..2f24059053 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -844,6 +844,18 @@ #max_threads_per_process = 0 +# When shutting down a VM, libvirt will wait up to 40 seconds for +# the associated QEMU process to exit before reporting an error. +# For some VM configurations, QEMU might require more time to +# cleanup and exit, e.g. VMs with very large memory allocations. +# +# If process_exit_wait is set to a positive interger, libvirt +# will use the value as additional time to wait for the QEMU +# process to exit before reporting it cannot be terminated. +# +#process_exit_wait = 0 + + # If max_core is set to a non-zero integer, then QEMU will be # permitted to create core dumps when it crashes, provided its # RAM size is smaller than the limit set. diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index e30b146634..adcba137cc 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -934,6 +934,9 @@ virQEMUDriverConfigLoadProcessEntry(virQEMUDriverConfig *cfg, cfg->schedCore = val; } + if (virConfGetValueUInt(conf, "process_exit_wait", &cfg->processExitWait) < 0) + return -1; + return 0; } diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 1d29f35c5d..bc78982123 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -211,6 +211,7 @@ struct _virQEMUDriverConfig { unsigned int maxProcesses; unsigned int maxFiles; unsigned int maxThreadsPerProc; + unsigned int processExitWait; unsigned long long maxCore; bool dumpGuestCore; diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index b2506edce0..5042ffe339 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -9218,6 +9218,9 @@ qemuProcessInShutdownStartMonitor(virDomainObj *vm) int qemuProcessKill(virDomainObj *vm, unsigned int flags) { + qemuDomainObjPrivate *priv = vm->privateData; + g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(priv->driver); + unsigned int delay = cfg->processExitWait; int ret = -1; VIR_DEBUG("vm=%p name=%s pid=%lld flags=0x%x", @@ -9238,11 +9241,15 @@ qemuProcessKill(virDomainObj *vm, unsigned int flags) return 0; } - /* Request an extra delay of two seconds per current nhostdevs - * to be safe against stalls by the kernel freeing up the resources */ + /* If the administrator has not requested an explicit shutdown wait period, + * add an extra delay of two seconds per current nhostdevs to be safe against + * stalls by the kernel freeing up the resources */ + if (delay == 0) + delay = vm->def->nhostdevs * 2; + ret = virProcessKillPainfullyDelay(vm->pid, !!(flags & VIR_QEMU_PROCESS_KILL_FORCE), - vm->def->nhostdevs * 2, + delay, false); if (ret < 0 && (flags & VIR_QEMU_PROCESS_KILL_MONITOR_ON_ERROR)) { diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index c4cf9cf634..fb6cb1a1d4 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -97,6 +97,7 @@ module Test_libvirtd_qemu = { "max_processes" = "0" } { "max_files" = "0" } { "max_threads_per_process" = "0" } +{ "process_exit_wait" = "0" } { "max_core" = "unlimited" } { "dump_guest_core" = "1" } { "mac_filter" = "1" } -- 2.51.0

4 13

Re: [PATCH v2 0/4] resctrl: support whole-process allocations and monitoring
by Wasiukiewicz, Jedrzej 15 Sep '26

15 Sep '26

A little more context on why whole-process scope is needed: A QEMU domain's resource consumption is not limited to its vCPU threads. IOThreads, the emulator thread, and worker threads all perform work on behalf of the guest and consume energy. Monitoring only vCPU threads therefore leaves part of the VM's energy consumption unattributed, preventing reliable whole-VM energy accounting. Cache and memory-bandwidth monitoring and allocation have the same gap. Managing these threads individually is not robust because some are created dynamically. Assigning QEMU to the resctrl group before thread creation uses the kernel's inheritance mechanism to cover all current and future threads. This is needed for an active customer deployment where the VM is the unit of energy accounting. The existing per-vCPU behavior remains unchanged when the vcpus attribute is specified. @Michal Prívozník<mailto:mprivozn@redhat.com>, since you reviewed the related resctrl fixes, would you be able to take a look at this series or suggest the right reviewer? The main question is whether whole-process scope, represented by an omitted vcpus attribute, is the right interface. Thanks, Jedrzej --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

1 0

[PATCH] rpc: Remove write-only 'sigErrors' and 'sigLastErrno' global variables
by Peter Krempa 14 Sep '26

14 Sep '26

From: Peter Krempa <pkrempa(a)redhat.com> Both 'sigErrors' and 'sigLastErrno' are only written to since their inception in commit 4e00b1da8a85401652031e0125477d72bfad3502. This was caught by clang on Fedora Rawhide: clang -Isrc/rpc/libvirt_net_rpc_server.a.p -Isrc/rpc -I../src/rpc -Isrc/util -I../src/util -Iinclude -I../include -Isrc -I../src -I. -I.. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libxml2 -I/usr/include/tirpc -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -O2 -g @/builds/libvirt/libvirt/build/c-warnings.txt -fPIC -DWITH_GZFILEOP -pthread -MD -MQ src/rpc/libvirt_net_rpc_server.a.p/virnetdaemon.c.o -MF src/rpc/libvirt_net_rpc_server.a.p/virnetdaemon.c.o.d -o src/rpc/libvirt_net_rpc_server.a.p/virnetdaemon.c.o -c ../src/rpc/virnetdaemon.c ../src/rpc/virnetdaemon.c:552:21: error: variable 'sigErrors' set but not used [-Werror,-Wunused-but-set-global] 552 | static sig_atomic_t sigErrors; | ^ ../src/rpc/virnetdaemon.c:553:12: error: variable 'sigLastErrno' set but not used [-Werror,-Wunused-but-set-global] 553 | static int sigLastErrno; | ^ 2 errors generated. Remove the variables and code which guarded the writes to them. Fixes: 4e00b1da8a85401652031e0125477d72bfad3502 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/rpc/virnetdaemon.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index 944a832ea8..7edaa897db 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -549,8 +549,6 @@ virNetDaemonRemoveShutdownInhibition(virNetDaemon *dmn) #ifndef WIN32 -static sig_atomic_t sigErrors; -static int sigLastErrno; static int sigWrite = -1; static void @@ -558,7 +556,6 @@ virNetDaemonSignalHandler(int sig, siginfo_t * siginfo, void* context G_GNUC_UNUSED) { int origerrno; - int r; siginfo_t tmp = { 0 }; if (SA_SIGINFO) @@ -568,11 +565,7 @@ virNetDaemonSignalHandler(int sig, siginfo_t * siginfo, tmp.si_signo = sig; origerrno = errno; - r = safewrite(sigWrite, &tmp, sizeof(tmp)); - if (r == -1) { - sigErrors++; - sigLastErrno = errno; - } + ignore_value(safewrite(sigWrite, &tmp, sizeof(tmp))); errno = origerrno; } -- 2.55.0

2 1