June 2026 - Devel - libvirt List Archives

[PATCH v2 00/35] monitor: turn QMP and HMP into QOM objects
by Daniel P. Berrangé 18 Jun '26

18 Jun '26

Conceptually -object and object_add/object_del should be sufficient for essentially all QEMU configuration....if only we ported all our internal custom backends/devices/etc to QOM. That is of course a big job which is why it hasn't happened. This series started with the premise that the monitor is one of the easier areas to convert since we have no more than three classes, a common base, and QMP and HMP subclasses[1]. So why not give it a go and thus unlock the ability to dynamically create/delete monitors in QMP/HMP. This series does the conversion in a great many small steps to better understand the implications at each stage. The high level outcome of this series is * HMP and QMP monitors are QOM objects, 'monitor-hmp' and 'monitor-qmp' respectively * Both can be cold plugged and hot plugged. QMP only, can also be hot unplugged. * '-mon' is obsolete, deprecated and replaced by '-object', but -monitor, -qmp and kept as high level syntax sugar * QMP gains a concept of "close-action" which makes it possible to mark a monitor for auto-delete. The monitor hot-unplug code and the qtest and functional testing code is heavily derived from a series sent by Christian Brauner which proposed new monitor_add/monitor_del commands: https://lists.nongnu.org/archive/html/qemu-devel/2026-04/msg01349.html I left Christian's authorship & SoB on the patches which were derived from his code, though the code has been refactored quite a bit in places, so bugs are quite possibly my own. Christian, if you prefer any changes in attribution here let me know. Note that Christian's series allowed the use of "monitor_del" commands against the current monitor session. ie a client could delete the very monitor it was using. This is an awkward concept as it needs special casing to delay the deletion to happen in the background, such that that the QMP response to 'monitor_del' could still be sent back. This also left the chardev was orphaned as there's no way to run 'chardev_dev' in that usage pattern. To provide an alternative mechanism to address the same use case, this series introduces the 'close-action' concept mentioned above, that allows hotplugging a monitor to service a specific task, with the monitor being purged when the script closes its connection. This avoids the special casing that an explicit "self deletion" paradigm required. While supporting hotplug of HMP was trivial, I didn't do any work to think about hotunplug of HMP, since IMHO it is of limited value given HMP's typical use cases. While -mon is deprecated in favour of -object, given '-mon' is such a significant CLI option, it is likely wise to not remove it as quickly as our deprecation policy would otherwise allow given the disruption that's liable to cause. It isn't a big burden to keep it around for a long time. [1] ~~~ we did all this not because it was easy, but because we thought it would be easy ~~~ Christian Brauner (6): monitor: convert from oneshot BH to persistent BH monitor: reject attempts to delete the current monitor monitor: protect qemu_chr_fe_accept_input with monitor lock monitor: implement support for deleting QMP objects tests/qtest: add tests for dynamic monitor add/remove tests/functional: add e2e test for dynamic QMP monitor hotplug Daniel P. Berrangé (29): qom: replace 'can_be_deleted' with 'prepare_delete' monitor: replace 'common' with 'parent_obj' in MonitorHMP monitor: replace 'common' with 'parent_obj' in MonitorQMP monitor: rename monitor_init* to monitor_new* monitor: minimal conversion of monitors to QOM monitor: add 'chardev' property to Monitor base class monitor: add 'readline' property to HMP Monitor class monitor: add 'pretty' property to QMP Monitor class monitor: remove 'skip_flush' field monitor: move monitor_data_(init|destroy) into QOM init/finalize monitor: use class methods for monitor_vprintf monitor: use class methods for monitor_qapi_event_emit monitor: use class methods for monitor_accept_input monitor: use class method for I/O thread request monitor: use dynamic cast in monitor_qmp_requests_pop_any_with_lock util: use dynamic cast in error vreport monitor: drop unused monitor_cur_is_qmp monitor: use dynamic cast in QMP commands monitor: use dynamic cast in monitor_is_hmp_non_interactive monitor: drop unused monitor_is_qmp method monitor: eliminate monitor_is_hmp_non_interactive method monitor: implement "user creatable" interface for adding monitors qemu-options: document new monitor-hmp and monitor-qmp objects tests/functional: add a stress test for monitor hot unplug qom: add method for getting the "id" of a QOM object qom: add trace events for user creatable create/delete APIs monitor: add support for auto-deleting monitors upon close tests: switch from -mon to -object monitor-qmp docs: mark '-mon' as deprecated in favour of -object MAINTAINERS | 1 + backends/cryptodev.c | 10 +- backends/hostmem.c | 5 +- backends/iommufd.c | 10 +- block/throttle-groups.c | 10 +- chardev/char.c | 3 +- docs/about/deprecated.rst | 10 + docs/devel/writing-monitor-commands.rst | 4 +- docs/system/arm/xenpvh.rst | 4 +- docs/system/i386/xen.rst | 3 +- docs/system/i386/xenpvh.rst | 4 +- event-loop-base.c | 8 +- gdbstub/system.c | 4 +- include/monitor/monitor.h | 23 +- include/qom/object.h | 10 + include/qom/object_interfaces.h | 26 +- include/system/event-loop-base.h | 2 +- migration/migration-hmp-cmds.c | 5 +- monitor/hmp-cmds.c | 7 +- monitor/hmp.c | 181 +++++++++-- monitor/monitor-internal.h | 74 +++-- monitor/monitor.c | 261 +++++++-------- monitor/qmp-cmds-control.c | 12 +- monitor/qmp-cmds.c | 14 +- monitor/qmp.c | 301 +++++++++++++++--- net/can/can_core.c | 5 +- python/qemu/machine/machine.py | 4 +- qapi/qom.json | 62 ++++ qemu-options.hx | 53 ++- qom/object.c | 17 + qom/object_interfaces.c | 20 +- qom/trace-events | 5 + storage-daemon/qemu-storage-daemon.c | 2 +- stubs/monitor-core.c | 5 - stubs/monitor-internal.c | 3 +- system/vl.c | 12 +- tests/functional/generic/meson.build | 1 + .../generic/test_monitor_hotplug.py | 275 ++++++++++++++++ tests/qemu-iotests/245 | 4 +- tests/qtest/libqtest.c | 2 +- tests/qtest/qmp-test.c | 174 ++++++++++ tests/unit/test-util-sockets.c | 1 - tools/qemu-vnc/stubs.c | 5 - ui/ui-hmp-cmds.c | 2 +- util/error-report.c | 13 +- util/main-loop.c | 5 +- 46 files changed, 1335 insertions(+), 327 deletions(-) create mode 100755 tests/functional/generic/test_monitor_hotplug.py -- 2.54.0

2 76

[PATCH 0/3] lxc: Misc cleanups
by Michal Privoznik 18 Jun '26

18 Jun '26

While reviewing Radoslaw's patched [1] I've noticed some opportunities for improvement. 1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/2HH7… Michal Prívozník (3): lxc: Drop pointless g_free() from virLXCProcessStart() lxc: Don't leak @veth in lxcDomainAttachDeviceNetLive() lxc: Rework cleanup section in lxcDomainAttachDeviceNetLive() src/lxc/lxc_driver.c | 30 ++++++++++++++---------------- src/lxc/lxc_process.c | 1 - 2 files changed, 14 insertions(+), 17 deletions(-) -- 2.53.0

2 4

[PATCH] virsh: Make --type argument of detach-interface optional
by Michal Privoznik 18 Jun '26

18 Jun '26

From: Michal Privoznik <mprivozn(a)redhat.com> The detach-interface virsh command requires domain (obviously) and --type to identify <interface/>. Optionally, --mac can be provided to chose from multiple interfaces. Well, that renders --type argument redundant. I mean, if there are but unique MACs within domain XML, then interface type is implied. If there are duplicate MACs then --type can help to differentiate, though at that point detach-device seems like a better fit. Long story short, make --type optional. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/manpages/virsh.rst | 2 +- tools/virsh-domain.c | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 39d91d8375..2992495ecb 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -5586,7 +5586,7 @@ detach-interface :: - detach-interface domain type [--mac mac] + detach-interface domain [--type type] [--mac mac] [[[--live] [--config] | [--current]] | [--persistent]] [--print-xml] Detach a network interface from a domain. diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f9de3b42a9..8a6f868e34 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12782,7 +12782,6 @@ static const vshCmdOptDef opts_detach_interface[] = { {.name = "type", .type = VSH_OT_STRING, .positional = true, - .required = true, .help = N_("network interface type") }, {.name = "mac", @@ -12816,7 +12815,7 @@ virshDomainDetachInterface(char *doc, g_autoptr(xmlDoc) xml = NULL; g_autoptr(xmlXPathContext) ctxt = NULL; g_autofree char *detach_xml = NULL; - g_autofree char *xpath = g_strdup_printf("/domain/devices/interface[@type='%s']", type); + g_autofree char *xpath = NULL; g_autofree xmlNodePtr *nodes = NULL; ssize_t nnodes; xmlNodePtr matchNode = NULL; @@ -12827,8 +12826,16 @@ virshDomainDetachInterface(char *doc, return false; } + if (type) + xpath = g_strdup_printf("/domain/devices/interface[@type='%s']", type); + else + xpath = g_strdup("/domain/devices/interface"); + if ((nnodes = virXPathNodeSet(xpath, ctxt, &nodes)) <= 0) { - vshError(ctl, _("No interface found whose type is %1$s"), type); + if (type) + vshError(ctl, _("No interface found whose type is %1$s"), type); + else + vshError(ctl, "%s", _("Domain has no interfaces")); return false; } -- 2.53.0

2 1

Plans for 12.5.0 release (freeze on 2026-06-25)
by Jiri Denemark 18 Jun '26

18 Jun '26

We are getting close to 12.5.0 release of libvirt. To aim for the release on Wednesday 01 Jul I suggest entering the freeze on Thursday 25 Jun and tagging RC2 on Monday 29 Jun. I hope this works for everyone. Jirka

1 0

[PATCH v2 0/2] lxc: Assign aliases to filesystem and network devices
by rsmigiel＠redhat.com 17 Jun '26

17 Jun '26

From: Radoslaw Smigielski <rsmigiel(a)redhat.com> This series adds device alias assignment for filesystem and network interface devices in LXC domains, make them working the same way like console devices. This is needed as a prerequisite for fixing bug #63 (loop device path length limitation), where device aliases will be used to compose synthetic lo_file_name references in the format "libvirt-$UUID-$DEVALIAS". It split this patch into two separate commits, filesystem and network related. -- 2.54.0

2 4

[PATCH] docs/uri.rst: document ext transport argv parameter
by Mark Cave-Ayland 17 Jun '26

17 Jun '26

This new parameter was added as part of commit ee06a78790 ("remote: allow passing argv to the ext transport"). Signed-off-by: Mark Cave-Ayland <mark.caveayland(a)nutanix.com> --- docs/uri.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/uri.rst b/docs/uri.rst index cc970001f4..48eda49308 100644 --- a/docs/uri.rst +++ b/docs/uri.rst @@ -1,3 +1,5 @@ +.. role:: since + =============== Connection URIs =============== @@ -326,6 +328,9 @@ Supported extra parameters: ``command`` The external command launched to tunnel the data to the destination. + ``argv`` :since:`(since 12.5.0)` + An optional parameter to be passed to the external command. ``argv`` may be + specified multiple times to pass multiple arguments. ``tcp`` transport ^^^^^^^^^^^^^^^^^ -- 2.43.0

2 1

[PATCH] ci: refresh with 'lcitool manifest'
by Michal Privoznik 17 Jun '26

17 Jun '26

From: Michal Privoznik <mprivozn(a)redhat.com> Switch from openSUSE Leap 15.5 to 16.0. Not just CI build job, but also codestyle_job which runs on Leap too. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/2607661514 .gitlab-ci.yml | 6 +++--- .../{opensuse-leap-15.sh => opensuse-leap-16.sh} | 11 +++-------- ...p-15.Dockerfile => opensuse-leap-16.Dockerfile} | 14 ++++---------- ci/gitlab/builds.yml | 9 ++++----- ci/gitlab/containers.yml | 4 ++-- ci/manifest.yml | 4 +--- 6 files changed, 17 insertions(+), 31 deletions(-) rename ci/buildenv/{opensuse-leap-15.sh => opensuse-leap-16.sh} (88%) rename ci/containers/{opensuse-leap-15.Dockerfile => opensuse-leap-16.Dockerfile} (86%) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6de867e1f2..e79da09443 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -108,14 +108,14 @@ codestyle_job: stage: sanity_checks extends: .gitlab_native_build_job needs: - - job: x86_64-opensuse-leap-15-container + - job: x86_64-opensuse-leap-16-container optional: true script: - source ci/jobs.sh - run_codestyle variables: - NAME: opensuse-leap-15 - TARGET_BASE_IMAGE: registry.opensuse.org/opensuse/leap:15.5 + NAME: opensuse-leap-16 + TARGET_BASE_IMAGE: registry.opensuse.org/opensuse/leap:16.0 # This artifact published by this job is downloaded to push to Weblate # for translation usage: diff --git a/ci/buildenv/opensuse-leap-15.sh b/ci/buildenv/opensuse-leap-16.sh similarity index 88% rename from ci/buildenv/opensuse-leap-15.sh rename to ci/buildenv/opensuse-leap-16.sh index 55d9fe5974..be9aca1aa2 100644 --- a/ci/buildenv/opensuse-leap-15.sh +++ b/ci/buildenv/opensuse-leap-16.sh @@ -6,7 +6,6 @@ function install_buildenv() { zypper update -y - zypper addrepo -fc https://download.opensuse.org/update/leap/15.6/backports/openSUSE:Backports… zypper install -y --allow-downgrade \ audit-devel \ augeas \ @@ -18,7 +17,6 @@ function install_buildenv() { clang-devel \ codespell \ cpp \ - cppi \ cyrus-sasl-devel \ device-mapper-devel \ diffutils \ @@ -64,19 +62,17 @@ function install_buildenv() { perl-base \ pkgconfig \ python3-base \ + python3-black \ python3-docutils \ python3-flake8 \ - python3-pip \ python3-pytest \ - python3-setuptools \ - python3-wheel \ qemu-tools \ readline-devel \ rpm-build \ - sanlock-devel \ sed \ systemd-rpm-macros \ - systemtap-sdt-devel \ + systemtap-dtrace \ + systemtap-headers \ wireshark-devel \ xen-devel rm -f /usr/lib*/python3*/EXTERNALLY-MANAGED @@ -85,7 +81,6 @@ function install_buildenv() { ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/cc ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/clang ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc - /usr/bin/pip3 install black } export CCACHE_WRAPPERSDIR="/usr/libexec/ccache-wrappers" diff --git a/ci/containers/opensuse-leap-15.Dockerfile b/ci/containers/opensuse-leap-16.Dockerfile similarity index 86% rename from ci/containers/opensuse-leap-15.Dockerfile rename to ci/containers/opensuse-leap-16.Dockerfile index 8857f35ce0..7d1680f464 100644 --- a/ci/containers/opensuse-leap-15.Dockerfile +++ b/ci/containers/opensuse-leap-16.Dockerfile @@ -4,10 +4,9 @@ # # https://gitlab.com/libvirt/libvirt-ci -FROM registry.opensuse.org/opensuse/leap:15.6 +FROM registry.opensuse.org/opensuse/leap:16.0 RUN zypper update -y && \ - zypper addrepo -fc https://download.opensuse.org/update/leap/15.6/backports/openSUSE:Backports… && \ zypper install -y --allow-downgrade \ audit-devel \ augeas \ @@ -19,7 +18,6 @@ RUN zypper update -y && \ clang-devel \ codespell \ cpp \ - cppi \ cyrus-sasl-devel \ device-mapper-devel \ diffutils \ @@ -65,19 +63,17 @@ RUN zypper update -y && \ perl-base \ pkgconfig \ python3-base \ + python3-black \ python3-docutils \ python3-flake8 \ - python3-pip \ python3-pytest \ - python3-setuptools \ - python3-wheel \ qemu-tools \ readline-devel \ rpm-build \ - sanlock-devel \ sed \ systemd-rpm-macros \ - systemtap-sdt-devel \ + systemtap-dtrace \ + systemtap-headers \ wireshark-devel \ xen-devel && \ zypper clean --all && \ @@ -88,8 +84,6 @@ RUN zypper update -y && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/clang && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc -RUN /usr/bin/pip3 install black - ENV CCACHE_WRAPPERSDIR="/usr/libexec/ccache-wrappers" ENV LANG="en_US.UTF-8" ENV MAKE="/usr/bin/make" diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index c11c834f60..65bec6d0f8 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -198,17 +198,16 @@ x86_64-fedora-rawhide-clang: TARGET_BASE_IMAGE: registry.fedoraproject.org/fedora:rawhide -x86_64-opensuse-leap-15: +x86_64-opensuse-leap-16: extends: .native_build_job needs: - - job: x86_64-opensuse-leap-15-container + - job: x86_64-opensuse-leap-16-container optional: true allow_failure: false variables: - CFLAGS: -Wno-missing-include-dirs - NAME: opensuse-leap-15 + NAME: opensuse-leap-16 RPM: skip - TARGET_BASE_IMAGE: registry.opensuse.org/opensuse/leap:15.6 + TARGET_BASE_IMAGE: registry.opensuse.org/opensuse/leap:16.0 x86_64-opensuse-tumbleweed: diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml index a4b9a5f03b..0c62956277 100644 --- a/ci/gitlab/containers.yml +++ b/ci/gitlab/containers.yml @@ -84,11 +84,11 @@ x86_64-fedora-rawhide-container: NAME: fedora-rawhide -x86_64-opensuse-leap-15-container: +x86_64-opensuse-leap-16-container: extends: .container_job allow_failure: false variables: - NAME: opensuse-leap-15 + NAME: opensuse-leap-16 x86_64-opensuse-tumbleweed-container: diff --git a/ci/manifest.yml b/ci/manifest.yml index 67a53bb3d2..0bf6d93798 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -161,13 +161,11 @@ targets: allow-failure: true builds: false - opensuse-leap-15: + opensuse-leap-16: jobs: - arch: x86_64 variables: RPM: skip - # Keep until fix for: https://bugzilla.opensuse.org/show_bug.cgi?id=1216862 - CFLAGS: -Wno-missing-include-dirs opensuse-tumbleweed: jobs: -- 2.53.0

2 1

[PATCH 00/20] qemu: Fix virtio video devcice frontend selection logic for migrations
by Peter Krempa 16 Jun '26

16 Jun '26

TL;DR: We've historically made selection of the specific virtio frontend device based on qemu capabilities but didn't record the choice. Migrations break if your qemu deployment differs. For more in-depth analysis see 16/20. This series conists of: -- refactor of removing detected qemu capabilities via config or the QMEU namespace -- fix to capability detection if host has no qemu -- addition of testing covering various possibilities for the virtio video devices which show specifics -- addition of XML infra for the new property holding the data -- refactors of the virtio selection code -- selecting the model in post parse callbacks -- fixing of validation code -- fixing of commandline generator Peter Krempa (20): qemu: capabilities: Apply 'capability_filters' configration option on all capabilities qemu: capabilities: Export 'virQEMUCapsNewCopy' outside of 'qemu_capspriv' qemu: Allow reuse of 'qemuProcessStartUpdateCustomCaps' qemu: validate: Validate VM config with qemuCaps influenced by <qemu:capabilities> qemu: postparse: Process VM config with qemuCaps influenced by <qemu:capabilities> virQEMUCapsCacheLookupDefault: Fix error message when no emulators are installed qemuxmlconfdata: un-symlink 'video-virtio-vga-gpu-gl' output qemuxmlconftest: Add 'video-virtio-vga' invocation with QEMU_CAPS_DEVICE_VIRTIO_VGA disabled qemuxmlconftest: Add test cases for configs asking for 'virtio-gpu-gl' or 'virtio-vga-gl' without the capability qemuxmlconftest: Add invocation of 'video-virtio-vga-gpu-gl' with missing caps and VIR_DOMAIN_DEF_PARSE_ABI_UPDATE qemustatusxml2xml: Add test case capturing virtio video device virDomainVideoDefFormat: Use 'virXMLFormatElement' instead of custom formatter conf: Add fields for recording actually-selected virtio video device qemuxmlconftest: Add test case for specifying 'virtio-gpu' where 'virtio-vga' would be picked qemuDeviceVideoGetModel: Directly return picked model qemu: postparse: Fill in selected virtio video frondend device in the XML qemuValidateDomainDeviceDefVideo: Fix checks of virtio video devices qemuDeviceVideoGetModel: Remove logic for selecting 'virtio' devices qemuDeviceVideoGetModel: Simplify by relying on checks from 'qemuValidateDomainDeviceDefVideo' qemu: Remove 'qemuDomainSupportsVideoVga' docs/formatdomain.rst | 8 + src/conf/domain_conf.c | 114 +++-- src/conf/domain_conf.h | 15 + src/conf/schemas/domaincommon.rng | 18 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 26 +- src/qemu/qemu_capabilities.h | 5 +- src/qemu/qemu_capspriv.h | 5 +- src/qemu/qemu_command.c | 163 +++--- src/qemu/qemu_domain.c | 96 +++- src/qemu/qemu_domain.h | 9 +- src/qemu/qemu_driver.c | 23 +- src/qemu/qemu_postparse.c | 108 +++- src/qemu/qemu_process.c | 55 +-- src/qemu/qemu_validate.c | 110 +++-- tests/qemucapsprobe.c | 3 +- .../virtio-vga-upgrade-in.xml | 466 ++++++++++++++++++ .../virtio-vga-upgrade-missing-in.xml | 464 +++++++++++++++++ .../virtio-vga-upgrade-missing-out.xml | 457 +++++++++++++++++ .../virtio-vga-upgrade-out.xml | 459 +++++++++++++++++ tests/qemuxmlactivetest.c | 6 + .../aarch64-video-default.aarch64-latest.xml | 2 +- ...64-video-virtio-gpu-pci.aarch64-latest.xml | 2 +- ...fault-models.aarch64-latest.abi-update.xml | 2 +- ...h64-virt-default-models.aarch64-latest.xml | 2 +- .../aarch64-virt-graphics.aarch64-latest.xml | 2 +- ...ault-video-type-aarch64.aarch64-latest.xml | 2 +- ...eo-type-loongarch64.loongarch64-latest.xml | 2 +- ...ault-video-type-riscv64.riscv64-latest.xml | 2 +- .../default-video-type-s390x.s390x-latest.xml | 2 +- ...t-models.loongarch64-latest.abi-update.xml | 2 +- ...virt-default-models.loongarch64-latest.xml | 2 +- ...rch64-virt-graphics.loongarch64-latest.xml | 2 +- .../q35-pcie-autoadd.x86_64-latest.xml | 2 +- .../q35-pcie.x86_64-latest.xml | 2 +- ...fault-models.riscv64-latest.abi-update.xml | 2 +- ...v64-virt-default-models.riscv64-latest.xml | 2 +- .../riscv64-virt-graphics.riscv64-latest.xml | 2 +- ...default-models.s390x-latest.abi-update.xml | 2 +- .../s390x-ccw-default-models.s390x-latest.xml | 2 +- .../s390x-ccw-graphics.s390x-latest.xml | 2 +- ...vhost-user-gpu-secondary.x86_64-latest.xml | 4 +- .../vhost-user-vga.x86_64-latest.xml | 2 +- .../video-virtio-blob-off.x86_64-latest.xml | 4 +- .../video-virtio-blob-on.x86_64-latest.xml | 4 +- .../video-virtio-edid-none.x86_64-latest.xml | 2 +- .../video-virtio-edid-off.x86_64-latest.xml | 2 +- .../video-virtio-edid-on.x86_64-latest.xml | 2 +- ...video-virtio-gpu-ccw-auto.s390x-latest.xml | 2 +- .../video-virtio-gpu-ccw.s390x-latest.xml | 4 +- .../video-virtio-gpu-device.x86_64-latest.xml | 2 +- .../video-virtio-gpu-sdl-gl.x86_64-latest.xml | 2 +- ...deo-virtio-gpu-secondary.x86_64-latest.xml | 4 +- ...ideo-virtio-gpu-spice-gl.x86_64-latest.xml | 2 +- .../video-virtio-gpu-virgl.x86_64-latest.xml | 2 +- ...io-vga-device-downgrade.x86_64-latest.args | 37 ++ ...tio-vga-device-downgrade.x86_64-latest.xml | 44 ++ .../video-virtio-vga-device-downgrade.xml | 33 ++ ..._VIRTIO_GPU_GL_PCI-disabled-ABI_UPDATE.err | 1 + ....QEMU_CAPS_VIRTIO_GPU_GL_PCI-disabled.args | 35 ++ ...t.QEMU_CAPS_VIRTIO_GPU_GL_PCI-disabled.xml | 46 ++ ...APS_VIRTIO_VGA_GL-disabled-ABI_UPDATE.args | 35 ++ ...CAPS_VIRTIO_VGA_GL-disabled-ABI_UPDATE.xml | 46 ++ ...test.QEMU_CAPS_VIRTIO_VGA_GL-disabled.args | 35 ++ ...atest.QEMU_CAPS_VIRTIO_VGA_GL-disabled.xml | 46 ++ .../video-virtio-vga-gpu-gl.x86_64-latest.xml | 47 +- ....QEMU_CAPS_DEVICE_VIRTIO_VGA-disabled.args | 37 ++ ...t.QEMU_CAPS_DEVICE_VIRTIO_VGA-disabled.xml | 44 ++ .../video-virtio-vga.x86_64-latest.xml | 2 +- ...virtio-options-video-ats.x86_64-latest.xml | 4 +- ...rtio-options-video-iommu.x86_64-latest.xml | 4 +- ...tio-options-video-packed.x86_64-latest.xml | 4 +- tests/qemuxmlconfdata/virtio-options.xml | 2 +- tests/qemuxmlconftest.c | 29 ++ tests/testutilsqemu.c | 3 +- 75 files changed, 2908 insertions(+), 315 deletions(-) create mode 100644 tests/qemustatusxml2xmldata/virtio-vga-upgrade-in.xml create mode 100644 tests/qemustatusxml2xmldata/virtio-vga-upgrade-missing-in.xml create mode 100644 tests/qemustatusxml2xmldata/virtio-vga-upgrade-missing-out.xml create mode 100644 tests/qemustatusxml2xmldata/virtio-vga-upgrade-out.xml create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-device-downgrade.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-device-downgrade.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-device-downgrade.xml create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_GPU_GL_PCI-disabled-ABI_UPDATE.err create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_GPU_GL_PCI-disabled.args create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_GPU_GL_PCI-disabled.xml create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_VGA_GL-disabled-ABI_UPDATE.args create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_VGA_GL-disabled-ABI_UPDATE.xml create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_VGA_GL-disabled.args create mode 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.QEMU_CAPS_VIRTIO_VGA_GL-disabled.xml mode change 120000 => 100644 tests/qemuxmlconfdata/video-virtio-vga-gpu-gl.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/video-virtio-vga.x86_64-latest.QEMU_CAPS_DEVICE_VIRTIO_VGA-disabled.args create mode 100644 tests/qemuxmlconfdata/video-virtio-vga.x86_64-latest.QEMU_CAPS_DEVICE_VIRTIO_VGA-disabled.xml -- 2.54.0

2 21

[PATCH] bhyve: implement reboot using agent
by Roman Bogorodskiy 16 Jun '26

16 Jun '26

Implement domain reboot using the guest agent. Implementation is very similar to the domain shutdown added earlier. Also, change the VIR_DOMAIN_REBOOT_ACPI_POWER_BTN flag to VIR_DOMAIN_REBOOT_SIGNAL. Even though bhyve emulates the ACPI button, it's triggered by sending a signal to the bhyve process, so VIR_DOMAIN_REBOOT_SIGNAL looks like a more accurate description of communication between libvirt and bhyve. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/bhyve/bhyve_driver.c | 38 +++++++++++++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 4b28c698e7..45e8aad5b5 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1085,6 +1085,12 @@ bhyveDomainShutdownFlagsAgent(virDomainObj *vm, return ret; } +static int +bhyveDomainRebootAgent(virDomainObj *vm, bool isReboot, bool reportError) +{ + return bhyveDomainShutdownFlagsAgent(vm, isReboot, reportError); +} + static int bhyveDomainShutdownFlags(virDomainPtr dom, unsigned int flags) { @@ -1160,10 +1166,15 @@ bhyveDomainReboot(virDomainPtr dom, unsigned int flags) { virConnectPtr conn = dom->conn; virDomainObj *vm; - bool isReboot = true; + bhyveDomainObjPrivate *priv; int ret = -1; + bool isReboot = true; + bool useAgent = false; + bool agentRequested, signalRequested; + bool agentForced; - virCheckFlags(VIR_DOMAIN_REBOOT_ACPI_POWER_BTN, -1); + virCheckFlags(VIR_DOMAIN_REBOOT_SIGNAL | + VIR_DOMAIN_REBOOT_GUEST_AGENT, -1); if (!(vm = bhyveDomObjFromDomain(dom))) goto cleanup; @@ -1174,13 +1185,34 @@ bhyveDomainReboot(virDomainPtr dom, unsigned int flags) VIR_INFO("Domain on_reboot setting overridden, shutting down"); } + priv = vm->privateData; + agentRequested = flags & VIR_DOMAIN_REBOOT_GUEST_AGENT; + signalRequested = flags & VIR_DOMAIN_REBOOT_SIGNAL; + + /* Prefer agent unless we were requested to not to. */ + if (agentRequested || !flags) + useAgent = true; + if (virDomainRebootEnsureACL(conn, vm->def, flags) < 0) goto cleanup; if (virDomainObjCheckActive(vm) < 0) goto cleanup; - ret = bhyveDomainShutdownSignal(vm, isReboot); + agentForced = agentRequested && !signalRequested; + if (useAgent) { + ret = bhyveDomainRebootAgent(vm, isReboot, agentForced); + if (((ret < 0) || (priv->agent != NULL)) && agentForced) + goto cleanup; + } + + /* If we are not enforced to use just an agent, try signal + * reboot as well in case agent did not succeed. + */ + if (!useAgent || (((ret < 0) || + (priv->agent != NULL)) && (signalRequested || !flags))) { + ret = bhyveDomainShutdownSignal(vm, isReboot); + } cleanup: virDomainObjEndAPI(&vm); -- 2.52.0

2 5

[PATCH 1/1] qemu: allow read-only HMP info monitor commands
by Siddhi Katage 15 Jun '26

15 Jun '26

Read-only connections currently cannot use qemu-monitor-command even for HMP "info" commands, which only query QEMU state. Allow HMP commands whose first token is exactly "info" on read-only connections. Keep QMP commands, file descriptor passing, and all other HMP commands restricted to read-write connections. Signed-off-by: Siddhi Katage <siddhi.katage(a)oracle.com> --- src/libvirt-qemu.c | 13 +++++++++++-- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 21 +++++++++++++++++++-- src/util/virqemu.c | 21 +++++++++++++++++++++ src/util/virqemu.h | 2 ++ 5 files changed, 54 insertions(+), 4 deletions(-) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index 2898b71983..d38b747b44 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -25,6 +25,7 @@ #include "virlog.h" #include "viruuid.h" #include "datatypes.h" +#include "virqemu.h" #define VIR_FROM_THIS VIR_FROM_NONE @@ -77,8 +78,12 @@ virDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd, virCheckDomainReturn(domain, -1); conn = domain->conn; + virCheckNonNullArgGoto(cmd, error); virCheckNonNullArgGoto(result, error); - virCheckReadOnlyGoto(conn->flags, error); + + if (!(flags & VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP) || + !virQEMUHMPCommandIsInfo(cmd)) + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->domainQemuMonitorCommand) { int ret; @@ -170,7 +175,11 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domain, } virCheckNonNullArgGoto(result, error); - virCheckReadOnlyGoto(conn->flags, error); + + if (ninfiles > 0 || outfiles || + !(flags & VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP) || + !virQEMUHMPCommandIsInfo(cmd)) + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->domainQemuMonitorCommandWithFiles) { int ret; diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 30c4564456..6f7505ecde 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -3351,6 +3351,7 @@ virQEMUBuildBufferEscapeComma; virQEMUBuildCommandLineJSON; virQEMUBuildCommandLineJSONArrayNumbered; virQEMUBuildCommandLineJSONArrayObjectsStr; +virQEMUHMPCommandIsInfo; # util/virrandom.h diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 544955ecf9..2f542e0b8a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -100,6 +100,7 @@ #include "vircgroup.h" #include "virperf.h" #include "virnuma.h" +#include "virqemu.h" #include "netdev_bandwidth_conf.h" #include "virdomainsnapshotobjlist.h" #include "virenum.h" @@ -13752,6 +13753,14 @@ qemuDomainBackupGetXMLDesc(virDomainPtr domain, #define QEMU_DOMAIN_MONITOR_COMMAND_FLAGS \ VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP +static int +qemuMonitorDomainGetInfo(virConnectPtr conn, + virDomainDef *def) +{ + return virDomainGetInfoEnsureACL(conn, def); +} + + static int qemuDomainQemuMonitorCommandWithFiles(virDomainPtr domain, const char *cmd, @@ -13789,8 +13798,16 @@ qemuDomainQemuMonitorCommandWithFiles(virDomainPtr domain, if (!(vm = qemuDomainObjFromDomain(domain))) goto cleanup; - if (virDomainQemuMonitorCommandWithFilesEnsureACL(domain->conn, vm->def) < 0) - goto cleanup; + /* HMP "info" commands only query QEMU state, so read access is enough. */ + if (ninfds == 0 && !outfds && + (flags & VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP) && + virQEMUHMPCommandIsInfo(cmd)) { + if (qemuMonitorDomainGetInfo(domain->conn, vm->def) < 0) + goto cleanup; + } else { + if (virDomainQemuMonitorCommandWithFilesEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + } if (virDomainObjBeginJob(vm, VIR_JOB_QUERY) < 0) goto cleanup; diff --git a/src/util/virqemu.c b/src/util/virqemu.c index d2a69026c8..74f3729b67 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@ -32,6 +32,27 @@ VIR_LOG_INIT("util.qemu"); + +bool +virQEMUHMPCommandIsInfo(const char *cmd) +{ + g_autofree char *trimmed = g_strdup(cmd); + const char *args; + + if (!trimmed) + return false; + + g_strstrip(trimmed); + + if (!STRPREFIX(trimmed, "info")) + return false; + + args = trimmed + strlen("info"); + + return *args == '\0' || g_ascii_isspace(*args); +} + + struct virQEMUCommandLineJSONIteratorData { const char *prefix; virBuffer *buf; diff --git a/src/util/virqemu.h b/src/util/virqemu.h index e5d36b95c4..b9e79fb9b6 100644 --- a/src/util/virqemu.h +++ b/src/util/virqemu.h @@ -42,3 +42,5 @@ int virQEMUBuildCommandLineJSON(virJSONValue *value, virQEMUBuildCommandLineJSONArrayFormatFunc array); void virQEMUBuildBufferEscapeComma(virBuffer *buf, const char *str); + +bool virQEMUHMPCommandIsInfo(const char *cmd); -- 2.47.3

3 2