March 2026 - Devel - libvirt List Archives

[PATCH] util: json: fix memory leak in virJSONValueFromJsonC()
by Elizaveta Tereshkina 06 Mar '26

06 Mar '26

In the 'json_type_array' case, the error path uses 'g_free()', which doesn't release other nested memory allocations. Replace it with 'virJSONValueFree()' to properly free the entire 'virJSONValue' structure. Fixes: da66bf53b0 (util: json: check return value of virJSONValueFromJsonC) Signed-off-by: Elizaveta Tereshkina <teryoshkina.ea(a)gmail.com> --- src/util/virjson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 454bd657be..5780dbb094 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1438,7 +1438,7 @@ virJSONValueFromJsonC(json_object *jobj) cur = virJSONValueFromJsonC(val); if (!cur) { - g_free(ret); + virJSONValue(ret); return NULL; } -- 2.39.2

1 1

[PATCH 0/3] Add 'scalable_mode' and 'first_stage' attributes to intel IOMMU
by Zhenzhong Duan 06 Mar '26

06 Mar '26

Hi, This adds 'scalable_mode' and 'first_stage' attributes to intel IOMMU so that emulated device can run with first stage translation. This is based on Nathan Chen's iommufd series v2[1], so for passthrough device, nested tranlation is enabled automatically with below config: <iommu model='intel'> <driver caching_mode='on' iotlb='on' scalable_mode='on' first_stage='on'/> </iommu> Tests: Basic net card passthrough libvirt selftest Thanks Zhenzhong [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/KFYU… Zhenzhong Duan (3): qemu: Introduce scalable_mode and first_stage capabilities conf: add support for 'scalable_mode' and 'first_stage' attributes to intel IOMMU qemu: Add command line support for scalable mode and first stage of virtual vtd docs/formatdomain.rst | 8 +++++ src/conf/domain_conf.c | 35 ++++++++++++++++++- src/conf/domain_conf.h | 2 ++ src/conf/domain_validate.c | 6 ++++ src/conf/schemas/domaincommon.rng | 10 ++++++ src/qemu/qemu_capabilities.c | 4 +++ src/qemu/qemu_capabilities.h | 2 ++ src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_validate.c | 12 +++++++ .../caps_10.0.0_x86_64+amdsev.xml | 2 ++ .../caps_10.0.0_x86_64.xml | 2 ++ .../caps_10.1.0_x86_64+inteltdx.xml | 2 ++ .../caps_10.1.0_x86_64.xml | 2 ++ .../caps_10.2.0_x86_64.xml | 2 ++ .../caps_6.2.0_x86_64.xml | 1 + .../caps_7.0.0_x86_64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../caps_9.0.0_x86_64.xml | 1 + .../caps_9.1.0_x86_64.xml | 1 + .../caps_9.2.0_x86_64+amdsev.xml | 1 + .../caps_9.2.0_x86_64.xml | 1 + 26 files changed, 102 insertions(+), 1 deletion(-) -- 2.47.3

3 6

[PATCH] hw/riscv: Remove deprecated 'riscv,delegate' device-tree property
by Philippe Mathieu-Daudé 05 Mar '26

05 Mar '26

The "riscv,delegate" DT property was added in QEMU 7.0 as part of the AIA APLIC support. The property changed name during the review process in Linux and the correct name ended up being "riscv,delegation". The incorrect name was added as alias, and deprecated in v9.1 (commit 38facfa8432), so can be removed for v11.0. Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> --- Binary file pc-bios/opensbi-riscv32-generic-fw_dynamic.bin matches Binary file pc-bios/opensbi-riscv64-generic-fw_dynamic.bin matches --- docs/about/deprecated.rst | 11 ----------- docs/about/removed-features.rst | 11 +++++++++++ hw/riscv/virt.c | 9 --------- 3 files changed, 11 insertions(+), 20 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 1d5c4f3707c..cc5502e5394 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -494,17 +494,6 @@ versions, aliases will point to newer CPU model versions depending on the machine type, so management software must resolve CPU model aliases before starting a virtual machine. -RISC-V "virt" board "riscv,delegate" DT property (since 9.1) -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' - -The "riscv,delegate" DT property was added in QEMU 7.0 as part of -the AIA APLIC support. The property changed name during the review -process in Linux and the correct name ended up being -"riscv,delegation". Changing the DT property name will break all -available firmwares that are using the current (wrong) name. The -property is kept as is in 9.1, together with "riscv,delegation", to -give more time for firmware developers to change their code. - x86 "isapc" board use of modern x86 CPUs (since 10.2) ''''''''''''''''''''''''''''''''''''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 41bec8b8e38..0a62e87ee35 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -1232,6 +1232,17 @@ converting to using TCG plugins they should contact the qemu-devel mailing list. +Firmware, ACPI, Device Tree +--------------------------- + +RISC-V "virt" board "riscv,delegate" DT property (removed in 11.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +The "riscv,delegate" DT property was added in QEMU 7.0 as part of +the AIA APLIC support. The property changed name during the review +process in Linux and the correct name ended up being "riscv,delegation". + + System emulator devices ----------------------- diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index bbce2fb6671..a1c323e66df 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -666,15 +666,6 @@ static void create_fdt_one_aplic(RISCVVirtState *s, int socket, qemu_fdt_setprop_cells(ms->fdt, aplic_name, "riscv,delegation", aplic_child_phandle, 0x1, VIRT_IRQCHIP_NUM_SOURCES); - /* - * DEPRECATED_9.1: Compat property kept temporarily - * to allow old firmwares to work with AIA. Do *not* - * use 'riscv,delegate' in new code: use - * 'riscv,delegation' instead. - */ - qemu_fdt_setprop_cells(ms->fdt, aplic_name, "riscv,delegate", - aplic_child_phandle, 0x1, - VIRT_IRQCHIP_NUM_SOURCES); } riscv_socket_fdt_write_id(ms, aplic_name, socket); -- 2.52.0

4 4

[PATCH 1/2] hyperv: improve error message when redefining domain
by Jonathon Jongsma 04 Mar '26

04 Mar '26

The current error message results in something like the following when running `virsh define` for an existing domain: `domain Domain already exists with UUID '$UUID' exists already` Improve the error message and make it behave like the esx driver and indicate that we do not yet support redefining existing domains in hyperv. Also avoid using the public LookupByUUID() API to check for existance, which requires unnecessarily allocating and de-allocating a virDomainPtr object. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/hyperv/hyperv_driver.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index b01b4919fe..6e9917f92a 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -2933,6 +2933,8 @@ hypervDomainDefineXML(virConnectPtr conn, const char *xml) virDomainPtr domain = NULL; g_autoptr(hypervInvokeParamsList) params = NULL; g_autoptr(GHashTable) defineSystemParam = NULL; + g_autoptr(Msvm_ComputerSystem) existing = NULL; + char uuid_string[VIR_UUID_STRING_BUFLEN]; size_t i = 0; /* parse xml */ @@ -2943,13 +2945,10 @@ hypervDomainDefineXML(virConnectPtr conn, const char *xml) goto error; /* abort if a domain with this UUID already exists */ - if ((domain = hypervDomainLookupByUUID(conn, def->uuid))) { - char uuid_string[VIR_UUID_STRING_BUFLEN]; - virUUIDFormat(domain->uuid, uuid_string); - virReportError(VIR_ERR_DOM_EXIST, _("Domain already exists with UUID '%1$s'"), uuid_string); - - // Don't use the 'exit' label, since we don't want to delete the existing domain. - virObjectUnref(domain); + virUUIDFormat(def->uuid, uuid_string); + if (hypervMsvmComputerSystemFromUUID(priv, uuid_string, &existing) == 0 && existing != NULL) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("Domain already exists, editing existing domains is not supported yet")); return NULL; } -- 2.53.0

3 4

[libvirt PATCH 0/3] qemu: IOMMUFD security label fix
by Pavel Hrdina 03 Mar '26

03 Mar '26

Pavel Hrdina (3): security_apparmor: Use g_auto* in AppArmorSetSecurityHostdevLabel security: Cleanup hostdev label error logic qemu: Fix IOMMUFD and VFIO security labels src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_process.c | 16 +++-- src/qemu/qemu_process.h | 3 +- src/security/security_apparmor.c | 76 +++++++++-------------- src/security/security_dac.c | 102 ++++++++++++++----------------- src/security/security_selinux.c | 90 ++++++++++++--------------- 6 files changed, 130 insertions(+), 159 deletions(-) -- 2.53.0

3 7

[RFC 0/2] Fix build with libvirtd disabled
by Jim Fehlig 03 Mar '26

03 Mar '26

I'm considering dropping the monolithic libvirtd in future versions of SUSE distros, which got me to checking the usability of -Ddriver_libvirtd=disabled. I found it's not very usable :-). This series if an RFC attempt to rectify the situation. I'm not sure if we should build the various "common" components unconditionally as this change does, or only if the monolithic libvirtd and/or one or more modular daemons are also being built. Thanks for any comments! Jim Fehlig (2): build: Fix build with libvirtd disabled spec: Add option to enable/disable libvirtd docs/manpages/meson.build | 10 +- libvirt.spec.in | 25 +++- meson.build | 209 +++++++++++++--------------- meson_options.txt | 14 +- src/access/meson.build | 3 - src/locking/meson.build | 281 +++++++++++++++++++------------------- src/logging/meson.build | 104 +++++++------- src/meson.build | 200 +++++++++++++-------------- src/remote/meson.build | 174 +++++++++++------------ src/security/meson.build | 2 +- src/util/meson.build | 24 ++-- tools/meson.build | 26 ++-- 12 files changed, 526 insertions(+), 546 deletions(-) -- 2.51.0

3 5

[PATCH] secret: install service file only if init_script is 'systemd'
by Roman Bogorodskiy 03 Mar '26

03 Mar '26

Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/secret/meson.build | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/secret/meson.build b/src/secret/meson.build index cfcc861f4f..32105dad9f 100644 --- a/src/secret/meson.build +++ b/src/secret/meson.build @@ -54,13 +54,15 @@ if conf.has('WITH_SECRETS') virt_secret_init_encryption_conf.set('localstatedir', localstatedir) - configure_file( - input: 'virt-secret-init-encryption.service.in', - output: '@0@.service'.format('virt-secret-init-encryption'), - configuration: virt_secret_init_encryption_conf, - install: true, - install_dir: unitdir, - ) + if init_script == 'systemd' + configure_file( + input: 'virt-secret-init-encryption.service.in', + output: '@0@.service'.format('virt-secret-init-encryption'), + configuration: virt_secret_init_encryption_conf, + install: true, + install_dir: unitdir, + ) + endif virt_daemon_units += { 'service': 'virtsecretd', -- 2.52.0

2 1

Release of libvirt-12.1.0
by Jiri Denemark 02 Mar '26

02 Mar '26

The 12.1.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: Advertise firmware features in domain capabilities XML The contents of the ``<firmwareFeatures/>`` element can be used to determine ahead of time whether a firmware matching certain characteristics, for example Secure Boot support, is available for the selected architecture and machine type. * qemu: Add support for uefi-vars device and firmware builds using it This is particularly noteworthy for people running aarch64 VMs with the 'virt' machine type, as it makes it finally possible to use Secure Boot with that combination. In most cases, no special steps are needed to take advantage of this: assuming that you have installed a recent version of QEMU, as well as a build of edk2 that includes the necessary binaries, you can just `enable Secure Boot <kbase/secureboot.html>`__ as you normally would. To explicitly request that the uefi-vars device is used even for scenarios where that would normally not be the case, it's enough to add an empty ``<varstore/>`` element in the domain XML. More details are available in the `guest firmware configuration <formatdomain.html#guest-firmware>`__ section of the documentation. * hyperv: improve API coverage for the hyperv driver The `virDomainInterfaceAddresses()` and `virDomainGetBlockInfo()` APIs are now supported by the hyperv driver. In addition, the domain xml for hyperv domains will indicate via firmware features whether secure boot is enabled. It also honors these firmware features when creating new domains. * bhyve: Add support for vCPU pinning configuration Bhyve guests can now have vCPU pinning configured:: <cputune> <vcpupin vcpu="0" cpuset="1,2,3"/> </cputune> Additionally, the ``domainGetVcpuPinInfo`` API is implemented for querying vCPU pinning information. * qemu: Support block operation latency histograms Libvirt now allows configuring qemu's block latency histogram collection as well as returns them via the bulk stats API. * Improvements * Introduce granule attribute for virtio-iommu In case when guest page size doesn't match the host page size (typically aarch64) the ``virtio-iommu`` needs to know the guest page size so it can allocate memory aligned to guest page size. * Parse hyperv features even for host-model Two releases ago, in v11.9.0 new ``host-model`` mode for Hyper-V enlightenments was introduced. Starting with this release, users can additionally override the defaults that are picked when domain is started and features are expanded. * bhyve: Improve loader configuration for arm64 guests If loader is not explicitly configured, use the loader from the ``sysutils/u-boot-bhyve-arm64`` port/package for the arm64 guests. * Bug fixes * Fix build with remote driver disabled Some parts of code were wrongly annotated as depended on remote driver. But they were used even from client side drivers. This is now fixed and libvirt builds properly even with remote driver disabled. * Various fixes to libvirt-guests.sh Firstly, the exit code of various commands was ignored (which may lead the script to wrongly determine persistent/transient domain state, for instance). Secondly, due to logical error, the script might have incorrectly asses state a domain is in. * AppArmor: Ask for no deny rule for readonly disk elements For read only disks, libvirt created an AppArmor profile which disallowed any future write rules. But when doing a blockcommit, libvirt needs to allow hypervisor to write to even readonly disks. The rule in the profile was changed so that future write rules can be added, temporarily. * esx: Allow connecting to IPv6 server Due to a bug in our code, if an IPv6 address was provided in connection URI, libvirt would fail to connect to VMWare server. This is now fixed. * qemu: Use device alias if interface has no name The ``virDomainInterfaceAddresses()`` API (or ``virsh domifaddr``) returns an array interfaces among with their addresses. But some interface names might be unknown, for instance if the API is told to parse host's ARP table then PCI assigned NICs or slirp/passt lack interface name. If that's the case, let the API return domain's ``<interface/>`` alias. * bhyve: hyperv: Various memory leak fixes * qemu: Fix failures when restoring save/managed-save images with upcoming qemu versions Current git version of qemu would return an error when attempting to load an existing (managed) save image as we relied on deprecated features that were now removed. Enjoy. Jirka

1 0

[PATCH] news: Mention latency histogram support and (managed) save fixes
by Peter Krempa 02 Mar '26

02 Mar '26

From: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8597febe28..800c4acb59 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -59,6 +59,11 @@ v12.1.0 (unreleased) Additionally, the ``domainGetVcpuPinInfo`` API is implemented for querying vCPU pinning information. + * qemu: Support block operation latency histograms + + Libvirt now allows configuring qemu's block latency histogram collection + as well as returns them via the bulk stats API. + * **Improvements** * Introduce granule attribute for virtio-iommu @@ -117,6 +122,12 @@ v12.1.0 (unreleased) * bhyve: hyperv: Various memory leak fixes + * qemu: Fix failures when restoring save/managed-save images with upcoming qemu versions + + Current git version of qemu would return an error when attempting to load + an existing (managed) save image as we relied on deprecated features that + were now removed. + v12.0.0 (2026-01-15) ==================== -- 2.53.0

2 1