September 2025 - Devel - libvirt List Archives

[PATCH 0/2] datatypes: Add missing check to virGetStream and refactor cleanup paths of helpers
by Peter Krempa 08 Sep '25

08 Sep '25

Peter Krempa (2): datatypes: virGetStream: Add missing 'virCheckConnectReturn' check datatypes: Refactor rest of 'virGet*' helpers src/datatypes.c | 175 +++++++++++++----------------------------------- 1 file changed, 45 insertions(+), 130 deletions(-) -- 2.51.0

2 3

[PATCH] esx: Satisfy curl type checks
by Michal Privoznik 08 Sep '25

08 Sep '25

From: Michal Privoznik <mprivozn(a)redhat.com> Since its commit [1] curl now performs type checks on curl_easy_setopt(). Some options expect long but we're passing an int. The fix consists mostly of specifying type of numbers passed to the function. Except for two cases: proxy_type and proxy_port which are stored in a structure of ours (_esxUtil_ParsedUri). These have their types switched from int to long and unsigned long, respectively. 1: https://github.com/curl/curl/commit/79b4e56b3f30dc1ac28a81128a07d27338e5219e Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/esx/esx_stream.c | 2 +- src/esx/esx_util.c | 4 ++-- src/esx/esx_util.h | 4 ++-- src/esx/esx_vi.c | 18 +++++++++--------- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c index 1439940330..4f3ca09379 100644 --- a/src/esx/esx_stream.c +++ b/src/esx/esx_stream.c @@ -411,7 +411,7 @@ esxStreamOpen(virStreamPtr stream, esxPrivate *priv, const char *url, curl_easy_setopt(streamPriv->curl->handle, CURLOPT_READDATA, streamPriv); } else { curl_easy_setopt(streamPriv->curl->handle, CURLOPT_UPLOAD, 0); - curl_easy_setopt(streamPriv->curl->handle, CURLOPT_HTTPGET, 1); + curl_easy_setopt(streamPriv->curl->handle, CURLOPT_HTTPGET, 1L); curl_easy_setopt(streamPriv->curl->handle, CURLOPT_WRITEFUNCTION, esxVI_CURL_WriteStream); curl_easy_setopt(streamPriv->curl->handle, CURLOPT_WRITEDATA, streamPriv); diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index 7ee0e5f7c0..8e725ed04f 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -125,8 +125,8 @@ esxUtil_ParseUri(esxUtil_ParsedUri **parsedUri, virURI *uri) *tmp++ = '\0'; - if (virStrToLong_i(tmp, NULL, 10, - &(*parsedUri)->proxy_port) < 0 || + if (virStrToLong_ul(tmp, NULL, 10, + &(*parsedUri)->proxy_port) < 0 || (*parsedUri)->proxy_port < 1 || (*parsedUri)->proxy_port > 65535) { virReportError(VIR_ERR_INVALID_ARG, diff --git a/src/esx/esx_util.h b/src/esx/esx_util.h index 58bc44e744..51f1151eb7 100644 --- a/src/esx/esx_util.h +++ b/src/esx/esx_util.h @@ -40,9 +40,9 @@ struct _esxUtil_ParsedUri { bool noVerify; bool autoAnswer; bool proxy; - int proxy_type; + long proxy_type; char *proxy_hostname; - int proxy_port; + unsigned long proxy_port; char *path; char *cacert; }; diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index d25f819bc5..65e19e179e 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -315,13 +315,13 @@ esxVI_CURL_Connect(esxVI_CURL *curl, esxUtil_ParsedUri *parsedUri) } curl_easy_setopt(curl->handle, CURLOPT_USERAGENT, "libvirt-esx"); - curl_easy_setopt(curl->handle, CURLOPT_NOSIGNAL, 1); - curl_easy_setopt(curl->handle, CURLOPT_HEADER, 0); - curl_easy_setopt(curl->handle, CURLOPT_FOLLOWLOCATION, 0); + curl_easy_setopt(curl->handle, CURLOPT_NOSIGNAL, 1L); + curl_easy_setopt(curl->handle, CURLOPT_HEADER, 0L); + curl_easy_setopt(curl->handle, CURLOPT_FOLLOWLOCATION, 0L); curl_easy_setopt(curl->handle, CURLOPT_SSL_VERIFYPEER, - parsedUri->noVerify ? 0 : 1); + parsedUri->noVerify ? 0L : 1L); curl_easy_setopt(curl->handle, CURLOPT_SSL_VERIFYHOST, - parsedUri->noVerify ? 0 : 2); + parsedUri->noVerify ? 0L : 2L); curl_easy_setopt(curl->handle, CURLOPT_COOKIEFILE, ""); curl_easy_setopt(curl->handle, CURLOPT_HTTPHEADER, curl->headers); curl_easy_setopt(curl->handle, CURLOPT_READFUNCTION, @@ -386,8 +386,8 @@ esxVI_CURL_Download(esxVI_CURL *curl, const char *url, char **content, curl_easy_setopt(curl->handle, CURLOPT_URL, url); curl_easy_setopt(curl->handle, CURLOPT_RANGE, range); curl_easy_setopt(curl->handle, CURLOPT_WRITEDATA, &buffer); - curl_easy_setopt(curl->handle, CURLOPT_UPLOAD, 0); - curl_easy_setopt(curl->handle, CURLOPT_HTTPGET, 1); + curl_easy_setopt(curl->handle, CURLOPT_UPLOAD, 0L); + curl_easy_setopt(curl->handle, CURLOPT_HTTPGET, 1L); responseCode = esxVI_CURL_Perform(curl, url); } @@ -426,7 +426,7 @@ esxVI_CURL_Upload(esxVI_CURL *curl, const char *url, const char *content) curl_easy_setopt(curl->handle, CURLOPT_URL, url); curl_easy_setopt(curl->handle, CURLOPT_RANGE, NULL); curl_easy_setopt(curl->handle, CURLOPT_READDATA, &content); - curl_easy_setopt(curl->handle, CURLOPT_UPLOAD, 1); + curl_easy_setopt(curl->handle, CURLOPT_UPLOAD, 1L); curl_easy_setopt(curl->handle, CURLOPT_INFILESIZE, strlen(content)); responseCode = esxVI_CURL_Perform(curl, url); @@ -1223,7 +1223,7 @@ esxVI_Context_Execute(esxVI_Context *ctx, const char *methodName, curl_easy_setopt(ctx->curl->handle, CURLOPT_URL, ctx->url); curl_easy_setopt(ctx->curl->handle, CURLOPT_RANGE, NULL); curl_easy_setopt(ctx->curl->handle, CURLOPT_WRITEDATA, &buffer); - curl_easy_setopt(ctx->curl->handle, CURLOPT_UPLOAD, 0); + curl_easy_setopt(ctx->curl->handle, CURLOPT_UPLOAD, 0L); curl_easy_setopt(ctx->curl->handle, CURLOPT_POSTFIELDS, request); curl_easy_setopt(ctx->curl->handle, CURLOPT_POSTFIELDSIZE, strlen(request)); -- 2.49.1

2 1

[PATCH] qemu: block: Always enable discard forwarding for 'throttle' filter layer
by Peter Krempa 08 Sep '25

08 Sep '25

From: Peter Krempa <pkrempa(a)redhat.com> Discards ought to be forwarded to the protocol nodes where we control if discard actually happens. Unconditionally enable discard='unmap' for the intermediate layer. Closes: https://gitlab.com/libvirt/libvirt/-/issues/810 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_block.c | 1 + .../qemuxmlconfdata/throttlefilter.x86_64-latest.args | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index daefeb2f45..194f8407e3 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -2751,6 +2751,7 @@ qemuBlockThrottleFilterGetProps(virDomainThrottleFilterDef *filter, "s:node-name", qemuBlockThrottleFilterGetNodename(filter), "s:throttle-group", prefixed_group_name, "s:file", parentNodeName, + "s:discard", "unmap", NULL) < 0) return NULL; diff --git a/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args b/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args index 6a37f5835a..95914ef5ce 100644 --- a/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args +++ b/tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args @@ -34,18 +34,18 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-8-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-8-format","read-only":false,"cache":{"direct":true,"no-flush":false},"driver":"qcow2","file":"libvirt-8-storage"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-9-filter","throttle-group":"throttle-limit0","file":"libvirt-8-format"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-9-filter","throttle-group":"throttle-limit0","file":"libvirt-8-format","discard":"unmap"}' \ -device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x4","drive":"libvirt-9-filter","id":"virtio-disk0","bootindex":1,"write-cache":"on"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest2","node-name":"libvirt-5-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-5-format","read-only":false,"cache":{"direct":true,"no-flush":false},"driver":"qcow2","file":"libvirt-5-storage"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-6-filter","throttle-group":"throttle-limit1","file":"libvirt-5-format"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-7-filter","throttle-group":"throttle-limit12","file":"libvirt-6-filter"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-6-filter","throttle-group":"throttle-limit1","file":"libvirt-5-format","discard":"unmap"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-7-filter","throttle-group":"throttle-limit12","file":"libvirt-6-filter","discard":"unmap"}' \ -device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x5","drive":"libvirt-7-filter","id":"virtio-disk1","write-cache":"on"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest3","node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-2-format","read-only":false,"cache":{"direct":true,"no-flush":false},"driver":"qcow2","file":"libvirt-2-storage"}' \ -blockdev '{"driver":"copy-on-read","node-name":"libvirt-CoR-vdc","file":"libvirt-2-format","discard":"unmap"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-3-filter","throttle-group":"throttle-limit2","file":"libvirt-CoR-vdc"}' \ --blockdev '{"driver":"throttle","node-name":"libvirt-4-filter","throttle-group":"throttle-limit12","file":"libvirt-3-filter"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-3-filter","throttle-group":"throttle-limit2","file":"libvirt-CoR-vdc","discard":"unmap"}' \ +-blockdev '{"driver":"throttle","node-name":"libvirt-4-filter","throttle-group":"throttle-limit12","file":"libvirt-3-filter","discard":"unmap"}' \ -device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x6","drive":"libvirt-4-filter","id":"virtio-disk2","write-cache":"on"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest4","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ -blockdev '{"node-name":"libvirt-1-format","read-only":false,"cache":{"direct":true,"no-flush":false},"driver":"qcow2","file":"libvirt-1-storage"}' \ -- 2.51.0

2 1

[PATCH 00/14] qemu: Optimize guest CPU probing
by Jiri Denemark 08 Sep '25

08 Sep '25

When a domain starts we need to check what CPU features were enabled and if any of the features we asked for were disabled. Currently this requires more than 470 QMP commands (and the number is growing everytime QEMU adds a new feature or other property to the CPU object). Thanks to a new qom-list-get QMP command introduced by QEMU 7.1 we can replace all those commands with just a single one. On my host using a minimal domain with no devices the startup time went down to about 200 ms from 400 ms before this series. Jiri Denemark (14): qemu: Drop legacy probing of CPU features tests: Add a test for qemuMonitorJSONGetGuestCPU tests: Test qemuMonitorJSONGetGuestCPU with empty unavailable-features qemu: Generalize filtering in qemuMonitorJSONParsePropsList qemu: Move feature filtering to qemuMonitorJSONGetCPUProperties qemu: Parse properties list from any JSON array qemu: Use qom-list-get for checking enabled CPU features tests: Test qemuMonitorJSONGetGuestCPU with qom-get-list qemu: Add qemuMonitorJSONCPUDataAddFeatures helper qemu: Merge qemuMonitorJSONGetCPUData in qemuMonitorJSONGetGuestCPU qemu: Always fetch disabled features in qemuMonitorJSONGetGuestCPU qemu: Merge qemuMonitorJSONGetCPUDataDisabled in qemuMonitorJSONGetGuestCPU qemu: Let qemuMonitorJSONGetCPUProperties also return disabled features qemu: Don't query unavailable-features if qom-list-get is supported src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_monitor.c | 43 +- src/qemu/qemu_monitor.h | 6 +- src/qemu/qemu_monitor_json.c | 383 +- src/qemu/qemu_monitor_json.h | 7 +- src/qemu/qemu_process.c | 20 +- .../caps_10.1.0_x86_64.xml | 1 + .../caps_10.2.0_x86_64.xml | 1 + .../get-guest-cpu-SierraForest-disabled.xml | 7 + .../get-guest-cpu-SierraForest-enabled.xml | 9 + .../get-guest-cpu-SierraForest-legacy.json | 8680 +++++++++++++++++ .../get-guest-cpu-SierraForest.json | 2962 ++++++ .../get-guest-cpu-SkylakeClient-disabled.xml | 2 + ...> get-guest-cpu-SkylakeClient-enabled.xml} | 10 +- .../get-guest-cpu-SkylakeClient-legacy.json | 8671 ++++++++++++++++ .../get-guest-cpu-SkylakeClient.json | 2953 ++++++ .../qemumonitorjson-getcpu-ecx.json | 57 - .../qemumonitorjson-getcpu-full.data | 5 - .../qemumonitorjson-getcpu-full.json | 46 - .../qemumonitorjson-getcpu-host.data | 6 - .../qemumonitorjson-getcpu-host.json | 45 - tests/qemumonitorjsontest.c | 191 +- 23 files changed, 23532 insertions(+), 576 deletions(-) create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SierraForest-disabled.xml create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SierraForest-enabled.xml create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SierraForest-legacy.json create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SierraForest.json create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SkylakeClient-disabled.xml rename tests/qemumonitorjsondata/{qemumonitorjson-getcpu-ecx.data => get-guest-cpu-SkylakeClient-enabled.xml} (53%) create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SkylakeClient-legacy.json create mode 100644 tests/qemumonitorjsondata/get-guest-cpu-SkylakeClient.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-ecx.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-full.data delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-full.json delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-host.data delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-getcpu-host.json -- 2.51.0

3 30

Archives for Google Summer of Code -2020
by Prakhar Bansal 07 Sep '25

07 Sep '25

Hi Team, I contributed to Libvirt in Google Summer of Code 2020 for the Libvirt Driver for Jailhouse. https://summerofcode.withgoogle.com/archive/2020/projects/5436033845428224 I am trying to access my submitted patches in the archive, but am unable to find them here https://listman.redhat.com/archives/libvir-list/2020-August/msg01144.html Could you please help me with the new archive where I can find my Patches I contributed to the Google Summer of Code '20? Thanks, Prakhar

2 1

[PATCH v5 0/6] qemu: acpi-generic-initiator support
by Andrea Righi 06 Sep '25

06 Sep '25

= Overview = This patch set introduces support for acpi-generic-initiator devices, supported by QEMU [1]. The acpi-generic-initiator object is required to support Multi-Instance GPU (MIG) configurations on NVIDIA GPUs [2]. MIG enables partitioning of GPU resources into multiple isolated instances, each requiring a dedicated NUMA node definition. = Implementation = This patch set implements the libvirt counterpart to the QEMU feature, enabling users to configure acpi-generic-initiator objects within libvirt domain XML. This includes: - adding XML syntax to define acpi-generic-initiator objects, - resolving the acpi-generic-initiator definitions into the proper QEMU command-line arguments, - ensuring compatibility with existing NUMA configuration. = Example = - Domain XML: ``` ... <cpu mode='host-passthrough' check='none'> <numa> <cell id='0' cpus='0-15' memory='8388608' unit='KiB'/> <cell id='1' memory='0' unit='KiB'/> <cell id='2' memory='0' unit='KiB'/> <cell id='3' memory='0' unit='KiB'/> <cell id='4' memory='0' unit='KiB'/> <cell id='5' memory='0' unit='KiB'/> <cell id='6' memory='0' unit='KiB'/> <cell id='7' memory='0' unit='KiB'/> <cell id='8' memory='0' unit='KiB'/> </numa> </cpu> ... <devices> ... <hostdev mode='subsystem' type='pci' managed='no'> <source> <address domain='0x0009' bus='0x01' slot='0x00' function='0x0'/> </source> <address type='pci' domain='0x0000' bus='0x03' slot='0x00' function='0x0'/> </hostdev> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>1</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>2</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>3</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>4</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>5</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>6</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>7</numa-node> </acpi-generic-initiator> <acpi-generic-initiator> <pci-dev>hostdev0</pci-dev> <numa-node>8</numa-node> </acpi-generic-initiator> </devices> ``` - Generated QEMU command line options: ``` ... /usr/bin/qemu-system-aarch64 \ ... -object '{"qom-type":"memory-backend-ram","id":"ram-node0","size":8589934592}' \ -numa node,nodeid=0,cpus=0-15,memdev=ram-node0 \ -numa node,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ -numa node,nodeid=4 \ -numa node,nodeid=5 \ -numa node,nodeid=6 \ -numa node,nodeid=7 \ -numa node,nodeid=8 \ ... -device '{"driver":"vfio-pci","host":"0009:01:00.0","id":"hostdev0","bus":"pci.3","addr":"0x0"}' ... -object acpi-generic-initiator,id=gi0,pci-dev=hostdev0,node=1 \ -object acpi-generic-initiator,id=gi1,pci-dev=hostdev0,node=2 \ -object acpi-generic-initiator,id=gi2,pci-dev=hostdev0,node=3 \ -object acpi-generic-initiator,id=gi3,pci-dev=hostdev0,node=4 \ -object acpi-generic-initiator,id=gi4,pci-dev=hostdev0,node=5 \ -object acpi-generic-initiator,id=gi5,pci-dev=hostdev0,node=6 \ -object acpi-generic-initiator,id=gi6,pci-dev=hostdev0,node=7 \ -object acpi-generic-initiator,id=gi7,pci-dev=hostdev0,node=8 ``` = References = [1] https://lore.kernel.org/all/20231225045603.7654-2-ankita@nvidia.com/ [2] https://www.nvidia.com/en-in/technologies/multi-instance-gpu/ ChangeLog v4 -> v5: - Integrate suggestions and changes from Michal's review - Update qemu capabilities - Rebase to v11.6.0 ChangeLog v3 -> v4: - add acpi-generic-initiator documentation - refactor virDomainAcpiInitiatorDef to use info->alias and drop the name attribute - auto-generate alias for the acpi-generic-initiator devices via qemuAssignDeviceAliases() - use g_autoptr() when possible - add a new entry to NEWS.rst ChangeLog v2 -> v3: - replaced <text/> with proper types in the XML schema - avoid mixing g_free() and VIR_FREE() - use virXMLPropString() instead of looping all XML nodes - report proper errors with virReportError() - use virBufferEscapeString() to process strings passed by the user - fix broken formatting of function headers - misc coding style fixes ChangeLog v1 -> v2: - split parser and driver changes in separate patches - introduce a new qemu capability flag - introduce test in qemuxmlconftest Andrea Righi (5): conf: Introduce acpi-generic-initiator device qemu: Allow to define NUMA nodes without memory or CPUs assigned qemu: capabilies: Introduce QEMU_CAPS_ACPI_GENERIC_INITIATOR qemu: Support acpi-generic-initiator NEWS: Mention new acpi-generic-initiator device Michal Prívozník (1): qemu_validate: Validate acpi-generic-initiator NEWS.rst | 8 ++ docs/formatdomain.rst | 36 ++++++ src/ch/ch_domain.c | 1 + src/conf/domain_conf.c | 138 +++++++++++++++++++++ src/conf/domain_conf.h | 14 +++ src/conf/domain_postparse.c | 1 + src/conf/domain_validate.c | 37 ++++++ src/conf/numa_conf.c | 3 + src/conf/schemas/domaincommon.rng | 14 +++ src/conf/virconftypes.h | 2 + src/hyperv/hyperv_driver.c | 1 + src/libxl/libxl_driver.c | 6 + src/lxc/lxc_driver.c | 6 + src/qemu/qemu_alias.c | 11 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 50 ++++++-- src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain_address.c | 4 + src/qemu/qemu_driver.c | 3 + src/qemu/qemu_hotplug.c | 5 + src/qemu/qemu_postparse.c | 1 + src/qemu/qemu_validate.c | 18 +++ src/test/test_driver.c | 4 + tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml | 1 + .../caps_10.0.0_x86_64+amdsev.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 1 + .../caps_10.1.0_x86_64+inteltdx.xml | 1 + tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml | 1 + .../caps_9.2.0_aarch64+hvf.xml | 1 + .../caps_9.2.0_x86_64+amdsev.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 1 + .../acpi-generic-initiator.x86_64-latest.args | 55 ++++++++ .../acpi-generic-initiator.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/acpi-generic-initiator.xml | 94 ++++++++++++++ tests/qemuxmlconftest.c | 1 + 39 files changed, 523 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxmlconfdata/acpi-generic-initiator.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/acpi-generic-initiator.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/acpi-generic-initiator.xml

2 8

[PATCH] libvirt-host: VIR_NODE_CPU_STATS_GUEST: clarify "guest" time
by Claudio Fontana 05 Sep '25

05 Sep '25

clarify that "guest" time is time spent running VCPUs specifically. Signed-off-by: Claudio Fontana <cfontana(a)suse.de> --- include/libvirt/libvirt-host.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 2b899144d3..398b40c35a 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -270,7 +270,7 @@ typedef enum { /** * VIR_NODE_CPU_STATS_GUEST: * - * The cumulative CPU time spent running guests, + * The cumulative CPU time spent running guest virtual CPUs, * since the node booting up (in nanoseconds). * * Since: 11.8.0 -- 2.35.3

2 1

[PATCH] util: virHostCPUGetStatsLinux: support VIR_NODE_CPU_STATS_GUEST
by Claudio Fontana 05 Sep '25

05 Sep '25

it is very useful for platforms to know how much time a node is spending running guests. Signed-off-by: Claudio Fontana <cfontana(a)suse.de> --- include/libvirt/libvirt-host.h | 10 ++++++++ src/test/test_driver.c | 9 +++++-- src/util/virhostcpu.c | 5 +++- tests/virhostcpudata/linux-cpustat-24cpu.out | 25 ++++++++++++++++++++ tools/virsh-host.c | 3 +++ 5 files changed, 49 insertions(+), 3 deletions(-) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 8922d00e0c..2b899144d3 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -267,6 +267,16 @@ typedef enum { */ # define VIR_NODE_CPU_STATS_INTR "intr" +/** + * VIR_NODE_CPU_STATS_GUEST: + * + * The cumulative CPU time spent running guests, + * since the node booting up (in nanoseconds). + * + * Since: 11.8.0 + */ +# define VIR_NODE_CPU_STATS_GUEST "guest" + /** * VIR_NODE_CPU_STATS_UTILIZATION: * diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 25335d9002..1165689de7 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4435,7 +4435,7 @@ static int testNodeGetCellsFreeMemory(virConnectPtr conn, return ret; } -#define TEST_NB_CPU_STATS 4 +#define TEST_NB_CPU_STATS 5 static int testNodeGetCPUStats(virConnectPtr conn G_GNUC_UNUSED, @@ -4453,7 +4453,7 @@ testNodeGetCPUStats(virConnectPtr conn G_GNUC_UNUSED, return 0; } - for (i = 0; i < *nparams && i < 4; i++) { + for (i = 0; i < *nparams && i < 5; i++) { switch (i) { case 0: if (virHostCPUStatsAssign(&params[i], @@ -4475,6 +4475,11 @@ testNodeGetCPUStats(virConnectPtr conn G_GNUC_UNUSED, VIR_NODE_CPU_STATS_IOWAIT, 763600000) < 0) return -1; break; + case 4: + if (virHostCPUStatsAssign(&params[i], + VIR_NODE_CPU_STATS_GUEST, 1797400000) < 0) + return -1; + break; } } diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 5dbcc8987c..c3b4f87de1 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -182,7 +182,7 @@ virHostCPUGetStatsFreeBSD(int cpuNum, # define CPUINFO_PATH "/proc/cpuinfo" # define PROCSTAT_PATH "/proc/stat" -# define LINUX_NB_CPU_STATS 4 +# define LINUX_NB_CPU_STATS 5 int virHostCPUGetSocket(unsigned int cpu, unsigned int *socket) @@ -855,6 +855,9 @@ virHostCPUGetStatsLinux(FILE *procstat, iowait * TICK_TO_NSEC) < 0) return -1; + if (virHostCPUStatsAssign(&params[4], VIR_NODE_CPU_STATS_GUEST, + guest * TICK_TO_NSEC) < 0) + return -1; return 0; } } diff --git a/tests/virhostcpudata/linux-cpustat-24cpu.out b/tests/virhostcpudata/linux-cpustat-24cpu.out index 0a1a5bcd9a..f3183f5c41 100644 --- a/tests/virhostcpudata/linux-cpustat-24cpu.out +++ b/tests/virhostcpudata/linux-cpustat-24cpu.out @@ -3,148 +3,173 @@ kernel: 8751170 user: 14128079 idle: 1816344522 iowait: 81323 +guest: 5880634 cpu0: kernel: 447603 user: 749021 idle: 75399242 iowait: 5295 +guest: 331814 cpu1: kernel: 167215 user: 337326 idle: 76178612 iowait: 1121 +guest: 166726 cpu2: kernel: 308930 user: 666889 idle: 75649696 iowait: 4298 +guest: 272094 cpu3: kernel: 227674 user: 328464 idle: 76131634 iowait: 1219 +guest: 115551 cpu4: kernel: 299514 user: 583915 idle: 75746383 iowait: 3997 +guest: 253387 cpu5: kernel: 112287 user: 231867 idle: 76336319 iowait: 798 +guest: 118465 cpu6: kernel: 546590 user: 896252 idle: 75132665 iowait: 7210 +guest: 410328 cpu7: kernel: 177715 user: 342337 idle: 76154889 iowait: 1933 +guest: 204523 cpu8: kernel: 452773 user: 772479 idle: 75359327 iowait: 5845 +guest: 347169 cpu9: kernel: 1050230 user: 1079258 idle: 74532776 iowait: 3340 +guest: 150374 cpu10: kernel: 535495 user: 847295 idle: 75202362 iowait: 4038 +guest: 370309 cpu11: kernel: 171635 user: 323891 idle: 76181622 iowait: 993 +guest: 199566 cpu12: kernel: 331031 user: 683257 idle: 75587176 iowait: 5174 +guest: 293663 cpu13: kernel: 112686 user: 230633 idle: 76345295 iowait: 1367 +guest: 103907 cpu14: kernel: 251393 user: 547599 idle: 75824554 iowait: 5195 +guest: 207464 cpu15: kernel: 199044 user: 260673 idle: 76230586 iowait: 1379 +guest: 76655 cpu16: kernel: 244158 user: 463357 idle: 75923993 iowait: 6211 +guest: 184943 cpu17: kernel: 88571 user: 189253 idle: 76411610 iowait: 1388 +guest: 85456 cpu18: kernel: 546539 user: 875655 idle: 75096896 iowait: 5756 +guest: 408446 cpu19: kernel: 186366 user: 348768 idle: 76137323 iowait: 1299 +guest: 208604 cpu20: kernel: 449460 user: 765202 idle: 75348938 iowait: 4389 +guest: 353323 cpu21: kernel: 1045076 user: 1116075 idle: 74500557 iowait: 2411 +guest: 162678 cpu22: kernel: 534125 user: 847779 idle: 75178185 iowait: 5632 +guest: 376150 cpu23: kernel: 265029 user: 640815 idle: 75753872 iowait: 1026 +guest: 479032 diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 51b71b512c..e918cfa4ca 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -743,6 +743,7 @@ typedef enum { VIRSH_CPU_IDLE, VIRSH_CPU_IOWAIT, VIRSH_CPU_INTR, + VIRSH_CPU_GUEST, VIRSH_CPU_USAGE, VIRSH_CPU_LAST } virshCPUStats; @@ -755,6 +756,7 @@ VIR_ENUM_IMPL(virshCPUStats, VIR_NODE_CPU_STATS_IDLE, VIR_NODE_CPU_STATS_IOWAIT, VIR_NODE_CPU_STATS_INTR, + VIR_NODE_CPU_STATS_GUEST, VIR_NODE_CPU_STATS_UTILIZATION); const char *virshCPUOutput[] = { @@ -763,6 +765,7 @@ const char *virshCPUOutput[] = { N_("idle:"), N_("iowait:"), N_("intr:"), + N_("guest:"), N_("usage:") }; -- 2.35.3

3 3

[PATCH] tests: Drop unused vm variable in testQemuMonitorCPUInfo
by Jiri Denemark 04 Sep '25

04 Sep '25

From: Jiri Denemark <jdenemar(a)redhat.com> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- tests/qemumonitorjsontest.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 38779a20d0..65b14ca318 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2360,7 +2360,6 @@ static int testQemuMonitorCPUInfo(const void *opaque) { const struct testCPUInfoData *data = opaque; - virDomainObj *vm = NULL; g_autofree char *queryCpusFile = NULL; g_autofree char *queryHotpluggableFile = NULL; g_autofree char *dataFile = NULL; @@ -2395,10 +2394,6 @@ testQemuMonitorCPUInfo(const void *opaque) if (qemuMonitorTestAddItem(test, "query-cpus-fast", queryCpusStr) < 0) goto cleanup; - vm = qemuMonitorTestGetDomainObj(test); - if (!vm) - goto cleanup; - rc = qemuMonitorGetCPUInfo(qemuMonitorTestGetMonitor(test), &vcpus, data->maxvcpus, true); -- 2.51.0

2 1

[PATCH 00/13] CH: Add disk hotplug support to Cloud Hypervisor domains
by Stefan Kober 03 Sep '25

03 Sep '25

This patchset adds the necessary functionality to support disk hotplugging in the CH driver. Some alias handling that can be extended to other device types is added, in order to allow detaching the devices via the Cloud Hypervisor API. Stefan Kober (13): ch: add DomainAttachDevice skeletons ch: add DomainDetachDevice skeletons ch: add ch_hotplug.{h,c} files to CH build ch: call into ch_hotplug implementation ch: pass disk alias to CHV ch: add ch_alias.{c,h} for device alias handling ch: add virCHMonitorPut function ch: use MonitorPut in MonitorPutNoContent ch: add disk attach functionality ch: assign aliases in ProcessPrepareDomain ch: Add virCHMonitorRemoveDevice function ch: implement disk device hot removal NEWS: announce disk hotplug support for ch NEWS.rst | 5 + po/POTFILES | 1 + src/ch/ch_alias.c | 59 ++++++++ src/ch/ch_alias.h | 27 ++++ src/ch/ch_driver.c | 86 ++++++++++++ src/ch/ch_hotplug.c | 333 ++++++++++++++++++++++++++++++++++++++++++++ src/ch/ch_hotplug.h | 33 +++++ src/ch/ch_monitor.c | 81 +++++++++-- src/ch/ch_monitor.h | 7 + src/ch/ch_process.c | 4 + src/ch/meson.build | 4 + 11 files changed, 630 insertions(+), 10 deletions(-) create mode 100644 src/ch/ch_alias.c create mode 100644 src/ch/ch_alias.h create mode 100644 src/ch/ch_hotplug.c create mode 100644 src/ch/ch_hotplug.h -- 2.50.1

4 20