September 2025 - Devel - libvirt List Archives

[PATCH v4 3/3] NEWS: ch: announce riscv-aia feature for RISC-V KVM
by BillXiang 27 Oct '25

27 Oct '25

From: xiangwencheng <xiangwencheng(a)lanxincomputing.com> Signed-off-by: xiangwencheng <xiangwencheng(a)lanxincomputing.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1b8e188f5e..db98d9e7c2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,6 +32,13 @@ v11.8.0 (unreleased) On the XML side, the existing <acpi> element has been extended with a "nodeset" attribute to specify the NUMA node affinity of a PCI device. + * qemu: Add ``riscv-aia`` attribute for RISC-V KVM + + This attribute was introduced in qemu-8.2 to specify the KVM AIA mode. + 1) "riscv-aia=emul": IMSIC is emulated by hypervisor + 2) "riscv-aia=hwaccel": use hardware guest IMSIC + 3) "riscv-aia=auto": use the hardware guest IMSICs whenever available otherwise we fallback to software emulation. + * **Improvements** * **Bug fixes** -- 2.34.1

2 1

[PATCH v4 2/3] qemu: Add XML tests for kvm riscv-aia feature
by BillXiang 27 Oct '25

27 Oct '25

From: xiangwencheng <xiangwencheng(a)lanxincomputing.com> Signed-off-by: BillXiang <xiangwencheng(a)lanxincomputing.com> --- .../caps_9.1.0_riscv64.replies | 4 +++ .../caps_9.1.0_riscv64.xml | 3 ++ ...atures-aia-aplic-imsic.riscv64-latest.args | 31 +++++++++++++++++++ ...eatures-aia-aplic-imsic.riscv64-latest.xml | 1 + .../riscv64-virt-features-aia-aplic-imsic.xml | 30 ++++++++++++++++++ tests/qemuxmlconftest.c | 1 + 6 files changed, 70 insertions(+) create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.args create mode 120000 tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.xml create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.xml diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.replies b/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.replies index 51896936cc..b394d68d00 100644 --- a/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.replies +++ b/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.replies @@ -24238,6 +24238,10 @@ "name": "tcg-accel", "parent": "accel" }, + { + "name": "kvm-accel", + "parent": "accel" + }, { "name": "ES1370", "parent": "pci-device" diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml b/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml index 9ceefed89f..6fbe05aa8d 100644 --- a/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml @@ -3,6 +3,7 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> + <flag name='kvm'/> <flag name='sdl'/> <flag name='spice'/> <flag name='hda-duplex'/> @@ -180,10 +181,12 @@ <cpu type='tcg' name='thead-c906' typename='thead-c906-riscv-cpu'/> <cpu type='tcg' name='sifive-u54' typename='sifive-u54-riscv-cpu'/> <cpu type='tcg' name='veyron-v1' typename='veyron-v1-riscv-cpu'/> + <cpu type='kvm' name='rv64' typename='rv64-riscv-cpu'/> <machine type='tcg' name='virt' maxCpus='512' defaultCPU='rv64-riscv-cpu' numaMemSupported='yes' defaultRAMid='riscv_virt_board.ram' acpi='yes'/> <machine type='tcg' name='spike' maxCpus='8' default='yes' defaultCPU='rv64-riscv-cpu' numaMemSupported='yes' defaultRAMid='riscv.spike.ram' acpi='no'/> <machine type='tcg' name='microchip-icicle-kit' maxCpus='5' defaultRAMid='microchip.icicle.kit.ram' acpi='no'/> <machine type='tcg' name='sifive_u' maxCpus='5' defaultCPU='sifive-u54-riscv-cpu' defaultRAMid='riscv.sifive.u.ram' acpi='no'/> <machine type='tcg' name='shakti_c' maxCpus='1' defaultCPU='shakti-c-riscv-cpu' defaultRAMid='riscv.shakti.c.ram' acpi='no'/> <machine type='tcg' name='sifive_e' maxCpus='1' defaultCPU='sifive-e51-riscv-cpu' defaultRAMid='riscv.sifive.e.ram' acpi='no'/> + <machine type='kvm' name='virt' maxCpus='512' defaultCPU='rv64-riscv-cpu' numaMemSupported='yes' defaultRAMid='riscv_virt_board.ram' acpi='yes'/> </qemuCaps> diff --git a/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.args b/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.args new file mode 100644 index 0000000000..3dadcdcd7c --- /dev/null +++ b/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.args @@ -0,0 +1,31 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/var/lib/libvirt/qemu/domain--1-guest \ +USER=test \ +LOGNAME=test \ +XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-guest/.local/share \ +XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-guest/.cache \ +XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-guest/.config \ +/usr/bin/qemu-system-riscv64 \ +-name guest=guest,debug-threads=on \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ +-machine virt,usb=off,aia=aplic-imsic,dump-guest-core=off,memory-backend=riscv_virt_board.ram,acpi=off \ +-accel kvm,riscv-aia=auto \ +-cpu rv64 \ +-m size=4194304k \ +-object '{"qom-type":"memory-backend-ram","id":"riscv_virt_board.ram","size":4294967296}' \ +-overcommit mem-lock=off \ +-smp 4,sockets=4,cores=1,threads=1 \ +-uuid 1ccfd97d-5eb4-478a-bbe6-88d254c16db7 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \ +-mon chardev=charmonitor,id=monitor,mode=control \ +-rtc base=utc \ +-no-shutdown \ +-boot strict=on \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ +-msg timestamp=on diff --git a/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.xml b/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.xml new file mode 120000 index 0000000000..73a864a8c2 --- /dev/null +++ b/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.riscv64-latest.xml @@ -0,0 +1 @@ +riscv64-virt-features-aia-aplic-imsic.xml \ No newline at end of file diff --git a/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.xml b/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.xml new file mode 100644 index 0000000000..31d4f30401 --- /dev/null +++ b/tests/qemuxmlconfdata/riscv64-virt-features-aia-aplic-imsic.xml @@ -0,0 +1,30 @@ +<domain type='kvm'> + <name>guest</name> + <uuid>1ccfd97d-5eb4-478a-bbe6-88d254c16db7</uuid> + <memory unit='KiB'>4194304</memory> + <currentMemory unit='KiB'>4194304</currentMemory> + <vcpu placement='static'>4</vcpu> + <os> + <type arch='riscv64' machine='virt'>hvm</type> + <boot dev='hd'/> + </os> + <features> + <kvm> + <riscv-aia state='on' mode='auto'/> + </kvm> + <aia value='aplic-imsic'/> + </features> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>rv64</model> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-riscv64</emulator> + <controller type='pci' index='0' model='pcie-root'/> + <audio id='1' type='none'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 171a6f1c78..5a2a14f7a6 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -2999,6 +2999,7 @@ mymain(void) DO_TEST_CAPS_ARCH_LATEST("x86_64-default-cpu-tcg-features", "x86_64"); DO_TEST_CAPS_ARCH_LATEST("riscv64-virt-features-aia", "riscv64"); + DO_TEST_CAPS_ARCH_LATEST("riscv64-virt-features-aia-aplic-imsic", "riscv64"); DO_TEST_CAPS_LATEST("virtio-9p-multidevs"); DO_TEST_CAPS_LATEST("virtio-9p-createmode"); -- 2.34.1

2 1

[PATCH v3 0/8] Enable mshv support for Qemu domains
by Praveen K Paladugu 17 Oct '25

17 Oct '25

"[PATCH v3 00/26] Implementing a MSHV (Microsoft Hypervisor) accelerator" patchset in qemu-devel mailing list introduces MSHV support within Qemu. With above patchset, Qemu guests can be started with `-accel mshv` option to use Microsoft Hypervisor (/dev/mshv) as the hypervisor. Retaining Libvirt's naming convention, this translates to `hyperv` domains. Below is an excerpt of the xml to use with this patchset: ``` <domain type='hyperv'> <name>qemu_msh_testv</name> <cpu mode='host-model'/> <os> <type machine='q35'>hvm</type> </os> ... ``` This patch set introduces the necessary changes within libvirt to support Qemu guest with hyperv (mshv) hypervisor. Chages in v3: - Addressed review comments on v2. - fixed qemucapabilitiestest case - Added a case to qemuxmlconftest Changes in v2: - Addressed review comments on v1. - Added a test to verify mshv capabilities. Praveen K Paladugu (8): qemu: introduce mshv capabilities qemu: use mshv accel for hyperv domains qemu: add /dev/mshv to default cgroup acl qemu: probe mshv capabilities conf: update capability schema tests: Add mshv variant for qemucapabilitiestest tests: Add domaincaps and qemucaps case for mshv tests: add mshv test to qemuxmlconftest src/conf/schemas/capability.rng | 1 + src/qemu/qemu.conf.in | 2 +- src/qemu/qemu_capabilities.c | 61 +- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 2 +- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_monitor.c | 12 + src/qemu/qemu_monitor.h | 12 +- src/qemu/qemu_monitor_json.c | 32 +- src/qemu/qemu_monitor_json.h | 13 +- src/qemu/test_libvirtd_qemu.aug.in | 3 +- .../qemu_10.1.0-q35.x86_64+mshv.xml | 222 + .../qemu_10.1.0-tcg.x86_64+mshv.xml | 1810 + .../qemu_10.1.0.x86_64+mshv.xml | 222 + tests/qemucapabilitiesdata/README.rst | 5 + .../caps_10.1.0_x86_64+mshv.replies | 46912 ++++++++++++++++ .../caps_10.1.0_x86_64+mshv.xml | 4996 ++ .../qemucaps2xmloutdata/caps.x86_64+mshv.xml | 29 + ...86_64-q35-headless.x86_64-latest+mshv.args | 48 + ...x86_64-q35-headless.x86_64-latest+mshv.xml | 87 + ...mshv-x86_64-q35-headless.x86_64-latest.err | 1 + .../mshv-x86_64-q35-headless.xml | 35 + tests/qemuxmlconftest.c | 5 + 23 files changed, 54495 insertions(+), 20 deletions(-) create mode 100644 tests/domaincapsdata/qemu_10.1.0-q35.x86_64+mshv.xml create mode 100644 tests/domaincapsdata/qemu_10.1.0-tcg.x86_64+mshv.xml create mode 100644 tests/domaincapsdata/qemu_10.1.0.x86_64+mshv.xml create mode 100644 tests/qemucapabilitiesdata/caps_10.1.0_x86_64+mshv.replies create mode 100644 tests/qemucapabilitiesdata/caps_10.1.0_x86_64+mshv.xml create mode 100644 tests/qemucaps2xmloutdata/caps.x86_64+mshv.xml create mode 100644 tests/qemuxmlconfdata/mshv-x86_64-q35-headless.x86_64-latest+mshv.args create mode 100644 tests/qemuxmlconfdata/mshv-x86_64-q35-headless.x86_64-latest+mshv.xml create mode 100644 tests/qemuxmlconfdata/mshv-x86_64-q35-headless.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/mshv-x86_64-q35-headless.xml -- 2.50.1

2 20

[PATCH v3] qapi: net/tap: deprecate vhostforce option
by Vladimir Sementsov-Ogievskiy 15 Oct '25

15 Oct '25

This option doesn't make sense since long ago (10 years!) commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). Prior 1e7398a140f7a6, to enable vhost for some specific kind of guests (that don't have MSI-X support), you should have set vhostforce=on (with vhost=on or unset). Since 1e7398a140f7a6, guest type doesn't matter, all guests are equal for vhost-enabling options logic. The current logic is: vhost=on / vhost=off : vhostforce ignored, doesn't make sense vhost unset : vhostforce counts, enabling vhost Currently you may enable vhost several ways: - vhost=on - vhostforce=on - vhost=on + vhostforce=on - and even vhost=on + vhostforce=off - they are all equal. Let's finally deprecate the extra option. Also, fix @vhostforce documentation. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov(a)yandex-team.ru> Reviewed-by: Markus Armbruster <armbru(a)redhat.com> --- v3: - two spaces between sentences for vhostforce description - add r-b by Markus docs/about/deprecated.rst | 7 +++++++ qapi/net.json | 11 +++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index d50645a071..b17a5a41aa 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -516,6 +516,13 @@ Stream ``reconnect`` (since 9.2) The ``reconnect`` option only allows specifying second granularity timeouts, which is not enough for all types of use cases, use ``reconnect-ms`` instead. +TAP ``vhostforce`` (since 10.2) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The ``vhostforce`` option is redundant with the ``vhost`` option. +If they conflict, ``vhost`` takes precedence. Just use ``vhost``. + + VFIO device options ''''''''''''''''''' diff --git a/qapi/net.json b/qapi/net.json index 78bcc9871e..bab26e0c5d 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -346,13 +346,20 @@ # @vhostfds: file descriptors of multiple already opened vhost net # devices # -# @vhostforce: vhost on for non-MSIX virtio guests +# @vhostforce: enable vhost-net network accelerator. Ignored when +# @vhost is set. # # @queues: number of queues to be created for multiqueue capable tap # # @poll-us: maximum number of microseconds that could be spent on busy # polling for tap (since 2.7) # +# Features: +# +# @deprecated: Member @vhostforce is deprecated. The @vhostforce +# option is redundant with the @vhost option. If they conflict, +# @vhost takes precedence. Just use @vhost. +# # Since: 1.2 ## { 'struct': 'NetdevTapOptions', @@ -369,7 +376,7 @@ '*vhost': 'bool', '*vhostfd': 'str', '*vhostfds': 'str', - '*vhostforce': 'bool', + '*vhostforce': { 'type': 'bool', 'features': [ 'deprecated' ] }, '*queues': 'uint32', '*poll-us': 'uint32'} } -- 2.48.1

2 3

[RFC PATCH v4 0/5] Added virtio-net RSS with eBPF support.
by Andrew Melnychenko 14 Oct '25

14 Oct '25

This series of rfc patches adds support for loading the RSS eBPF program and passing it to the QEMU. Comments and suggestions would be useful. QEMU with vhost may work with RSS through eBPF. To load eBPF, the capabilities required that Libvirt may provide. eBPF program and maps may be unique for particular QEMU and Libvirt retrieves eBPF through qapi. For now, there is only "RSS" eBPF object in QEMU, in the future, there may be another one(g.e. network filters). That's why in Libvirt added logic to load and store any eBPF object that QEMU provides using qapi schema. One of the reasons why this series of patches is in RFC are tests. To this series of patches, the tests were added. For now, the tests are synthetic, the proper "reply" file should be generated with a new "caps" file. Currently, there are changes in caps-9.0.0* and caps-9.1.0 files. There was added support for ebpf_rss_fds feature, and request-ebpf command. So, overall, the tests are required for review, comment, and discussion how we want them to be implemented in the future. For virtio-net RSS, the document has not changed. ``` <interface type="network"> <model type="virtio"/> <driver queues="4" rss="on" rss_hash_report="off"/> <interface type="network"> ``` Simplified routine for RSS: * Libvirt retrieves eBPF "RSS" and load it. * Libvirt passes file descriptors to virtio-net with property "ebpf_rss_fds" ("rss" property should be "on" too). * if fds was provided - QEMU using eBPF RSS implementation. * if fds was not provided - QEMU tries to load eBPF RSS in own context and use it. * if eBPF RSS was not loaded - QEMU uses "in-qemu" RSS(vhost not supported). Changes since RFC v3: * changed tests a bit * refactored and rebased * removed "allowEBPF" from qemu config(now env is used for tests) Changes since RFC v2: * refactored and rebased. * applied changes according to the Qemu. * added basic test. Changes since RFC v1: * changed eBPF format saved in the XML cache. * refactored and checked with syntax test. * refactored patch hunks. Andrew Melnychenko (5): qemu_monitor: Added QEMU's "request-ebpf" support. qemu_capabilities: Added logic for retrieving eBPF objects from QEMU. qemu_interface: Added routine for loading the eBPF objects. qemu_command: Added "ebpf_rss_fds" support for virtio-net. tests: Added tests for eBPF blob loading. libvirt.spec.in | 3 + meson.build | 7 + meson_options.txt | 1 + src/qemu/meson.build | 1 + src/qemu/qemu_capabilities.c | 132 ++++++++++++ src/qemu/qemu_capabilities.h | 5 + src/qemu/qemu_command.c | 60 ++++++ src/qemu/qemu_domain.c | 4 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_interface.c | 87 ++++++++ src/qemu/qemu_interface.h | 7 + src/qemu/qemu_monitor.c | 9 + src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 27 +++ src/qemu/qemu_monitor_json.h | 4 + .../caps_9.0.0_sparc.replies | 95 +++++---- .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 3 + .../caps_9.0.0_x86_64.replies | 199 ++++++++++-------- .../caps_9.0.0_x86_64.xml | 4 + .../caps_9.1.0_x86_64.replies | 199 ++++++++++-------- .../caps_9.1.0_x86_64.xml | 4 + tests/qemuxml2argvmock.c | 24 +++ .../net-virtio-rss-bpf.x86_64-latest.args | 37 ++++ .../net-virtio-rss-bpf.x86_64-latest.xml | 46 ++++ tests/qemuxmlconfdata/net-virtio-rss-bpf.xml | 46 ++++ tests/qemuxmlconftest.c | 5 + 26 files changed, 792 insertions(+), 224 deletions(-) create mode 100644 tests/qemuxmlconfdata/net-virtio-rss-bpf.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/net-virtio-rss-bpf.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/net-virtio-rss-bpf.xml -- 2.45.2

3 7

[PATCH 0/2] remove deprecated 'reconnect' options
by Vladimir Sementsov-Ogievskiy 10 Oct '25

10 Oct '25

They were deprecated in 9.2, now we can remove them. New options to use are reconnect-ms. v2: fixup docs and error messages Vladimir Sementsov-Ogievskiy (2): chardev: remove deprecated 'reconnect' option net/stream: remove deprecated 'reconnect' option chardev/char-socket.c | 24 +++++------------------- chardev/char.c | 3 --- docs/about/deprecated.rst | 15 --------------- docs/about/removed-features.rst | 22 ++++++++++++++++++++++ net/stream.c | 20 +++++--------------- qapi/char.json | 14 +------------- qapi/net.json | 13 +------------ 7 files changed, 34 insertions(+), 77 deletions(-) -- 2.48.1

6 13

[PATCH 0/1] Refine the domain status saving logic
by yong.huang＠smartx.com 08 Oct '25

08 Oct '25

From: Hyman Huang <yong.huang(a)smartx.com> When saving the domain status in the path of the virDomainObjSave function, Libvirtd will omit the private data if the format interface is not provided. When the Libvirtd service is starting up and the driver has not yet been initialized, this behavior is justified. However, when the service is shutting down, the driver is being finalized and the interface is being released, a migration job or another job may call the qemuDomainSaveStatus and save the domain status at the same time. For the latter, this behavior causes the XML to be saved without private information (such as monitor path and qemuCaps), which is required for the Libvirtd service to manage a VM during startup. As a result, after restarting the Libvirtd service, a running VM that is being migrated previously might escape management. Thus, when formatting the status XML for a running virtual machine, we need to presume that the "privateData.format" interface is present. Add a thorough check in the virDomainObjSave path to make sure that private data in the status XML file always exists for the running VM so that we won't lose it after restart the Libvirtd service. Please review, thanks. Yong Hyman Huang (1): domain_conf: Do not omit private data when formatting the status XML src/conf/domain_conf.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) -- 2.27.0

3 11

[PATCH v2 00/38] qemu: Improve handling of architecture-specific defaults (USB and PCI)
by Andrea Bolognani 06 Oct '25

06 Oct '25

Changes from [v1]: * overhaul/fix validation of USB controllers. Previously the check was based around whether the controller had a PCI address assigned to it, but that was incorrect and insufficient. The new check is based on the controller model instead; * split functional changes in the last stretch of the series into smaller chunks and justify each one separately; * avoid use of nec-xhci for RISC-V and LoongArch; * add test suite coverage and special handling for microvm; * address other review comments. [v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/D7VF… Andrea Bolognani (38): tests: Fix typo in usb-controller-nec-xhci-autoassign tests: Drop coverage for versatilepb on aarch64 tests: Don't use memballoon=none for minimal tests tests: Don't set PCI address in usb-controller-default tests tests: Minimize usb-controller tests tests: Rename usb-controller-implicit-* tests: Expand coverage for automatic/default USB controllers tests: Fix some usb-controller-*-unavailable cases qemu: Check for pci-ohci availability tests: Use realview-eb instead of realview-pbx-a9 qemu: Fix PCI/USB handling for Arm realview boards tests: Add coverage for PCI use with isapc and microvm qemu: Don't add memballoon to isapc qemu: Don't add PCI, USB or memballoon to microvm qemu: Introduce qemuDomainNetIsPCI() qemu: Prevent use of PCI devices when PCI is not supported qemu: Validate presence of PCI support qemu: Update qemuDomainSupportsPCI() qemu: Add sanity checks for auto-added PCI and USB controllers qemu: Always default to no USB controller on s390x qemu: Don't generate alias for model=none USB controllers qemu: Drop skip for USB controllers on s390x qemu: Fold check into qemuBuildSkipController() qemu: Rename function argument qemu: Validate PCI support for USB controllers qemu: Skip USB controller validation when model=none qemu: Validate USB controllers earlier qemu: Add qemuDomainDefaultUSBControllerModel() qemu: Add qemuDomainDefaultUSBControllerModelAutoAdded() qemu: Clean up qemuDomainDefaultUSBControllerModel() qemu: Clean up qemuDomainDefaultUSBControllerModelAutoAdded() qemu: Use qemu-xhci with no fallback on loongarch64 qemu: Use qemu-xhci with no fallback on RISC-V qemu: Unify USB controllers across Arm architectures qemu: Don't special-case realview/versatilebp for USB qemu: Remove fallback to piix3-uhci for Arm virt guests qemu: Remove use of piix3-uhci for non-x86 news: Update for USB controller model selection improvements NEWS.rst | 6 + src/qemu/qemu_alias.c | 3 + src/qemu/qemu_command.c | 86 +-------- src/qemu/qemu_domain.c | 164 +++++++++++++++++- src/qemu/qemu_domain.h | 5 + src/qemu/qemu_domain_address.c | 77 ++++++-- src/qemu/qemu_postparse.c | 128 +++++--------- src/qemu/qemu_validate.c | 119 ++++++++++++- .../qemuhotplug-base-ccw-live+ccw-virtio.xml | 7 +- ...with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 7 +- ...otplug-base-ccw-live-with-2-ccw-virtio.xml | 7 +- ...-with-ccw-virtio+ccw-virtio-2-explicit.xml | 7 +- ...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 7 +- ...uhotplug-base-ccw-live-with-ccw-virtio.xml | 7 +- .../qemuhotplug-base-ccw-live.xml | 7 +- ...ousb-minimal.aarch64-latest.abi-update.xml | 1 - .../aarch64-nousb-minimal.aarch64-latest.xml | 1 - .../qemuxmlconfdata/aarch64-nousb-minimal.xml | 1 - ...iew-minimal.aarch64-latest.abi-update.args | 4 +- ...view-minimal.aarch64-latest.abi-update.xml | 8 +- ...rch64-realview-minimal.aarch64-latest.args | 4 +- ...arch64-realview-minimal.aarch64-latest.xml | 8 +- .../aarch64-realview-minimal.xml | 3 +- ...epb-minimal.aarch64-latest.abi-update.args | 32 ---- ...lepb-minimal.aarch64-latest.abi-update.xml | 25 --- ...64-versatilepb-minimal.aarch64-latest.args | 32 ---- ...h64-versatilepb-minimal.aarch64-latest.xml | 25 --- ...lepb-minimal.armv7l-latest.abi-update.args | 2 +- ...ilepb-minimal.armv7l-latest.abi-update.xml | 3 +- ...v7l-versatilepb-minimal.armv7l-latest.args | 2 +- ...mv7l-versatilepb-minimal.armv7l-latest.xml | 3 +- .../armv7l-versatilepb-minimal.xml | 1 - .../isapc-pci.x86_64-latest.err | 1 + ...roller-default-isapc.xml => isapc-pci.xml} | 7 +- .../microvm-pci.x86_64-latest.err | 1 + ...ller-default-isapc.xml => microvm-pci.xml} | 9 +- tests/qemuxmlconfdata/ppc-dtb.ppc-latest.args | 2 +- tests/qemuxmlconfdata/ppc-dtb.ppc-latest.xml | 2 +- ...c-mac99-minimal.ppc-latest.abi-update.args | 2 +- ...pc-mac99-minimal.ppc-latest.abi-update.xml | 2 +- .../ppc-mac99-minimal.ppc-latest.args | 2 +- .../ppc-mac99-minimal.ppc-latest.xml | 2 +- .../ppce500-serial.ppc-latest.args | 2 +- .../ppce500-serial.ppc-latest.xml | 2 +- ...ault-models.riscv64-latest.abi-update.args | 15 +- ...fault-models.riscv64-latest.abi-update.xml | 26 ++- ...64-virt-default-models.riscv64-latest.args | 15 +- ...v64-virt-default-models.riscv64-latest.xml | 26 ++- .../s390-usb-address.s390x-latest.xml | 6 +- ...oller-automatic-i440fx.x86_64-latest.args} | 0 ...roller-automatic-i440fx.x86_64-latest.xml} | 0 ...ml => usb-controller-automatic-i440fx.xml} | 2 - ...roller-automatic-isapc.x86_64-latest.args} | 0 ...troller-automatic-isapc.x86_64-latest.xml} | 0 ...xml => usb-controller-automatic-isapc.xml} | 2 - ...ller-automatic-microvm.x86_64-latest.args} | 6 +- ...oller-automatic-microvm.x86_64-latest.xml} | 12 +- ...l => usb-controller-automatic-microvm.xml} | 4 +- ...atic-pseries.ppc64-latest.abi-update.args} | 1 - ...matic-pseries.ppc64-latest.abi-update.xml} | 13 +- ...oller-automatic-pseries.ppc64-latest.args} | 1 - ...roller-automatic-pseries.ppc64-latest.xml} | 11 +- ...l => usb-controller-automatic-pseries.xml} | 8 +- ...ntroller-automatic-q35.x86_64-latest.args} | 0 ...ontroller-automatic-q35.x86_64-latest.xml} | 0 ...5.xml => usb-controller-automatic-q35.xml} | 2 - ...er-automatic-realview.aarch64-latest.args} | 4 +- ...ler-automatic-realview.aarch64-latest.xml} | 4 +- ... => usb-controller-automatic-realview.xml} | 2 +- ...troller-automatic-s390x.s390x-latest.args} | 11 +- ...ntroller-automatic-s390x.s390x-latest.xml} | 15 +- .../usb-controller-automatic-s390x.xml | 13 ++ ...lable-pseries.ppc64-latest.abi-update.err} | 0 ...atic-unavailable-pseries.ppc64-latest.err} | 0 ...ntroller-automatic-unavailable-pseries.xml | 1 + ...utomatic-unavailable-q35.x86_64-latest.xml | 2 +- ...b-controller-automatic-unavailable-q35.xml | 7 - ...c-unavailable-realview.aarch64-latest.err} | 0 ...troller-automatic-unavailable-realview.xml | 1 + ...unavailable-versatilepb.armv7l-latest.err} | 0 ...ller-automatic-unavailable-versatilepb.xml | 1 + ...-automatic-versatilepb.armv7l-latest.args} | 2 +- ...r-automatic-versatilepb.armv7l-latest.xml} | 4 +- ... usb-controller-automatic-versatilepb.xml} | 0 ...utomatic-virt-aarch64.aarch64-latest.args} | 20 +-- ...automatic-virt-aarch64.aarch64-latest.xml} | 15 +- .../usb-controller-automatic-virt-aarch64.xml | 12 ++ ...-virt-loongarch64.loongarch64-latest.args} | 20 +-- ...c-virt-loongarch64.loongarch64-latest.xml} | 12 +- ...-controller-automatic-virt-loongarch64.xml | 12 ++ ...utomatic-virt-riscv64.riscv64-latest.args} | 20 +-- ...automatic-virt-riscv64.riscv64-latest.xml} | 11 +- ...usb-controller-automatic-virt-riscv64.xml} | 8 +- ...default-fallback-g3beige.ppc64-latest.args | 1 - ...-default-fallback-g3beige.ppc64-latest.xml | 11 +- ...r-default-fallback-mac99.ppc64-latest.args | 1 - ...er-default-fallback-mac99.ppc64-latest.xml | 11 +- ...-default-fallback-mac99ppc.ppc-latest.args | 1 - ...r-default-fallback-mac99ppc.ppc-latest.xml | 11 +- ...default-fallback-nousb.aarch64-latest.args | 32 ---- ...-default-fallback-nousb.aarch64-latest.xml | 23 --- .../usb-controller-default-fallback-nousb.xml | 1 - ...efault-fallback-powernv9.ppc64-latest.args | 1 - ...default-fallback-powernv9.ppc64-latest.xml | 11 +- ...ault-fallback-realview.aarch64-latest.args | 4 +- ...fault-fallback-realview.aarch64-latest.xml | 6 +- ...ck-versatilepb-aarch64.aarch64-latest.args | 32 ---- ...ack-versatilepb-aarch64.aarch64-latest.xml | 25 --- ...r-default-fallback-versatilepb-aarch64.xml | 1 - ...er-default-fallback-versatilepb-armv7l.xml | 1 - ...t-fallback-versatilepb.armv7l-latest.args} | 0 ...lt-fallback-versatilepb.armv7l-latest.xml} | 0 ...ontroller-default-fallback-versatilepb.xml | 1 + ...fallback-virt-aarch64.aarch64-latest.args} | 28 ++- ...-fallback-virt-aarch64.aarch64-latest.xml} | 30 ++-- ...ntroller-default-fallback-virt-aarch64.xml | 1 + ...ntroller-default-g3beige.ppc64-latest.args | 1 - ...ontroller-default-g3beige.ppc64-latest.xml | 11 +- .../usb-controller-default-g3beige.xml | 11 +- ...ntroller-default-i440fx.x86_64-latest.args | 1 - ...ontroller-default-i440fx.x86_64-latest.xml | 4 +- .../usb-controller-default-i440fx.xml | 8 +- ...controller-default-isapc.x86_64-latest.err | 2 +- .../usb-controller-default-isapc.xml | 2 - ...controller-default-mac99.ppc64-latest.args | 1 - ...-controller-default-mac99.ppc64-latest.xml | 11 +- .../usb-controller-default-mac99.xml | 11 +- ...ontroller-default-mac99ppc.ppc-latest.args | 3 +- ...controller-default-mac99ppc.ppc-latest.xml | 13 +- .../usb-controller-default-mac99ppc.xml | 11 +- ...ntroller-default-microvm.x86_64-latest.err | 1 + ...xml => usb-controller-default-microvm.xml} | 4 +- ...fault-nousb.aarch64-latest.abi-update.err} | 0 ...ntroller-default-nousb.aarch64-latest.args | 32 ---- ...ontroller-default-nousb.aarch64-latest.err | 1 + ...ontroller-default-nousb.aarch64-latest.xml | 23 --- .../usb-controller-default-nousb.xml | 1 - ...troller-default-powernv9.ppc64-latest.args | 1 - ...ntroller-default-powernv9.ppc64-latest.xml | 11 +- .../usb-controller-default-powernv9.xml | 11 +- ...fault-pseries.ppc64-latest.abi-update.args | 1 - ...efault-pseries.ppc64-latest.abi-update.xml | 11 +- ...ntroller-default-pseries.ppc64-latest.args | 1 - ...ontroller-default-pseries.ppc64-latest.xml | 11 +- .../usb-controller-default-pseries.xml | 18 +- ...-controller-default-q35.x86_64-latest.args | 5 +- ...b-controller-default-q35.x86_64-latest.xml | 18 +- .../usb-controller-default-q35.xml | 11 +- ...oller-default-realview.aarch64-latest.args | 4 +- ...roller-default-realview.aarch64-latest.xml | 6 +- .../usb-controller-default-realview.xml | 3 +- ...ontroller-default-s390x.s390x-latest.args} | 11 +- ...controller-default-s390x.s390x-latest.xml} | 16 +- .../usb-controller-default-s390x.xml | 14 ++ ...fault-unavailable-g3beige.ppc64-latest.xml | 34 ---- ...default-unavailable-mac99.ppc64-latest.xml | 34 ---- ...efault-unavailable-mac99ppc.ppc-latest.xml | 31 ---- ...ault-unavailable-nousb.aarch64-latest.args | 32 ---- ...fault-unavailable-nousb.aarch64-latest.xml | 23 --- ...b-controller-default-unavailable-nousb.xml | 1 - ...ault-unavailable-powernv9.ppc64-latest.xml | 34 ---- ...-default-unavailable-q35.x86_64-latest.xml | 33 ---- ...t-unavailable-realview.aarch64-latest.args | 31 ---- ...t-unavailable-realview.aarch64-latest.err} | 0 ...lt-unavailable-realview.aarch64-latest.xml | 23 --- ...le-versatilepb-aarch64.aarch64-latest.args | 32 ---- ...ble-versatilepb-aarch64.aarch64-latest.xml | 25 --- ...efault-unavailable-versatilepb-aarch64.xml | 1 - ...default-unavailable-versatilepb-armv7l.xml | 1 - ...unavailable-versatilepb.armv7l-latest.err} | 0 ...roller-default-unavailable-versatilepb.xml | 1 + ...available-virt-aarch64.aarch64-latest.err} | 0 ...oller-default-unavailable-virt-aarch64.xml | 1 + ...e-virt-loongarch64.loongarch64-latest.err} | 0 ...r-default-unavailable-virt-loongarch64.xml | 1 + ...available-virt-riscv64.riscv64-latest.err} | 0 ...oller-default-unavailable-virt-riscv64.xml | 1 + ...lt-versatilepb-aarch64.aarch64-latest.args | 32 ---- ...controller-default-versatilepb-aarch64.xml | 16 -- ...fault-versatilepb-armv7l.armv7l-latest.xml | 27 --- ...er-default-versatilepb.armv7l-latest.args} | 2 +- ...ler-default-versatilepb.armv7l-latest.xml} | 4 +- ...=> usb-controller-default-versatilepb.xml} | 1 - ...-default-virt-aarch64.aarch64-latest.args} | 26 ++- ...r-default-virt-aarch64.aarch64-latest.xml} | 24 ++- ...> usb-controller-default-virt-aarch64.xml} | 9 +- ...-virt-loongarch64.loongarch64-latest.args} | 26 ++- ...t-virt-loongarch64.loongarch64-latest.xml} | 21 +-- ...b-controller-default-virt-loongarch64.xml} | 9 +- ...-default-virt-riscv64.riscv64-latest.args} | 26 ++- ...r-default-virt-riscv64.riscv64-latest.xml} | 20 +-- ...> usb-controller-default-virt-riscv64.xml} | 8 +- ...troller-ich9-autoassign.x86_64-latest.args | 1 - ...ntroller-ich9-autoassign.x86_64-latest.xml | 4 +- .../usb-controller-ich9-autoassign.xml | 16 +- ...ntroller-ich9-companion.x86_64-latest.args | 1 - ...ontroller-ich9-companion.x86_64-latest.xml | 4 +- .../usb-controller-ich9-companion.xml | 4 +- ...ntroller-ich9-ehci-addr.x86_64-latest.args | 1 - ...ontroller-ich9-ehci-addr.x86_64-latest.xml | 4 +- .../usb-controller-ich9-ehci-addr.xml | 4 +- .../usb-controller-ich9-no-companion.xml | 6 +- ...er-nec-xhci-autoassign.x86_64-latest.args} | 0 ...ler-nec-xhci-autoassign.x86_64-latest.xml} | 0 ...=> usb-controller-nec-xhci-autoassign.xml} | 14 +- .../usb-controller-nec-xhci-limit.xml | 2 - .../usb-controller-nec-xhci.x86_64-latest.xml | 2 +- .../usb-controller-nec-xhci.xml | 7 - .../usb-controller-piix3.x86_64-latest.args | 1 - .../usb-controller-piix3.x86_64-latest.xml | 4 +- .../qemuxmlconfdata/usb-controller-piix3.xml | 4 +- tests/qemuxmlconftest.c | 129 +++++++++----- 212 files changed, 930 insertions(+), 1579 deletions(-) delete mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.abi-update.args delete mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.abi-update.xml delete mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.args delete mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/isapc-pci.x86_64-latest.err copy tests/qemuxmlconfdata/{usb-controller-default-isapc.xml => isapc-pci.xml} (64%) create mode 100644 tests/qemuxmlconfdata/microvm-pci.x86_64-latest.err copy tests/qemuxmlconfdata/{usb-controller-default-isapc.xml => microvm-pci.xml} (53%) rename tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.x86_64-latest.args => usb-controller-automatic-i440fx.x86_64-latest.args} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.x86_64-latest.xml => usb-controller-automatic-i440fx.x86_64-latest.xml} (100%) copy tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.xml => usb-controller-automatic-i440fx.xml} (83%) copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.args => usb-controller-automatic-isapc.x86_64-latest.args} (100%) copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.xml => usb-controller-automatic-isapc.x86_64-latest.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-isapc.xml => usb-controller-automatic-isapc.xml} (83%) copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.args => usb-controller-automatic-microvm.x86_64-latest.args} (84%) rename tests/qemuxmlconfdata/{usb-controller-default-unavailable-i440fx.x86_64-latest.xml => usb-controller-automatic-microvm.x86_64-latest.xml} (57%) copy tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.xml => usb-controller-automatic-microvm.xml} (71%) copy tests/qemuxmlconfdata/{usb-controller-default-pseries.ppc64-latest.abi-update.args => usb-controller-automatic-pseries.ppc64-latest.abi-update.args} (93%) rename tests/qemuxmlconfdata/{usb-controller-default-unavailable-pseries.ppc64-latest.xml => usb-controller-automatic-pseries.ppc64-latest.abi-update.xml} (77%) copy tests/qemuxmlconfdata/{usb-controller-default-pseries.ppc64-latest.args => usb-controller-automatic-pseries.ppc64-latest.args} (93%) copy tests/qemuxmlconfdata/{usb-controller-default-pseries.ppc64-latest.xml => usb-controller-automatic-pseries.ppc64-latest.xml} (80%) copy tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.xml => usb-controller-automatic-pseries.xml} (50%) copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.args => usb-controller-automatic-q35.x86_64-latest.args} (100%) copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.xml => usb-controller-automatic-q35.x86_64-latest.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-implicit-q35.xml => usb-controller-automatic-q35.xml} (83%) copy tests/qemuxmlconfdata/{aarch64-realview-minimal.aarch64-latest.abi-update.args => usb-controller-automatic-realview.aarch64-latest.args} (89%) rename tests/qemuxmlconfdata/{usb-controller-default-versatilepb-aarch64.aarch64-latest.xml => usb-controller-automatic-realview.aarch64-latest.xml} (93%) rename tests/qemuxmlconfdata/{aarch64-versatilepb-minimal.xml => usb-controller-automatic-realview.xml} (85%) copy tests/qemuxmlconfdata/{ppc-mac99-minimal.ppc-latest.abi-update.args => usb-controller-automatic-s390x.s390x-latest.args} (70%) copy tests/qemuxmlconfdata/{s390-usb-address.s390x-latest.xml => usb-controller-automatic-s390x.s390x-latest.xml} (59%) create mode 100644 tests/qemuxmlconfdata/usb-controller-automatic-s390x.xml copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-automatic-unavailable-pseries.ppc64-latest.abi-update.err} (100%) copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-automatic-unavailable-pseries.ppc64-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-automatic-unavailable-pseries.xml copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-automatic-unavailable-realview.aarch64-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-automatic-unavailable-realview.xml copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-automatic-unavailable-versatilepb.armv7l-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-automatic-unavailable-versatilepb.xml rename tests/qemuxmlconfdata/{usb-controller-default-versatilepb-armv7l.armv7l-latest.args => usb-controller-automatic-versatilepb.armv7l-latest.args} (94%) rename tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.xml => usb-controller-automatic-versatilepb.armv7l-latest.xml} (93%) copy tests/qemuxmlconfdata/{armv7l-versatilepb-minimal.xml => usb-controller-automatic-versatilepb.xml} (100%) copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.args => usb-controller-automatic-virt-aarch64.aarch64-latest.args} (52%) copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.xml => usb-controller-automatic-virt-aarch64.aarch64-latest.xml} (63%) create mode 100644 tests/qemuxmlconfdata/usb-controller-automatic-virt-aarch64.xml copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.args => usb-controller-automatic-virt-loongarch64.loongarch64-latest.args} (52%) copy tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.xml => usb-controller-automatic-virt-loongarch64.loongarch64-latest.xml} (63%) create mode 100644 tests/qemuxmlconfdata/usb-controller-automatic-virt-loongarch64.xml rename tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.args => usb-controller-automatic-virt-riscv64.riscv64-latest.args} (52%) rename tests/qemuxmlconfdata/{usb-controller-implicit-isapc.x86_64-latest.xml => usb-controller-automatic-virt-riscv64.riscv64-latest.xml} (67%) rename tests/qemuxmlconfdata/{usb-controller-implicit-i440fx.xml => usb-controller-automatic-virt-riscv64.xml} (53%) delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml delete mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.aarch64-latest.args delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.aarch64-latest.xml delete mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.xml delete mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.xml rename tests/qemuxmlconfdata/{usb-controller-default-fallback-versatilepb-armv7l.armv7l-latest.args => usb-controller-default-fallback-versatilepb.armv7l-latest.args} (100%) copy tests/qemuxmlconfdata/{armv7l-versatilepb-minimal.armv7l-latest.abi-update.xml => usb-controller-default-fallback-versatilepb.armv7l-latest.xml} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb.xml copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.args => usb-controller-default-fallback-virt-aarch64.aarch64-latest.args} (50%) rename tests/qemuxmlconfdata/{usb-controller-nec-xhci-unavailable.x86_64-latest.xml => usb-controller-default-fallback-virt-aarch64.aarch64-latest.xml} (50%) create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-virt-aarch64.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-microvm.x86_64-latest.err copy tests/qemuxmlconfdata/{usb-controller-default-isapc.xml => usb-controller-default-microvm.xml} (73%) copy tests/qemuxmlconfdata/{usb-controller-default-isapc.x86_64-latest.err => usb-controller-default-nousb.aarch64-latest.abi-update.err} (100%) delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.err delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml copy tests/qemuxmlconfdata/{ppc-mac99-minimal.ppc-latest.abi-update.args => usb-controller-default-s390x.s390x-latest.args} (70%) copy tests/qemuxmlconfdata/{s390-usb-address.s390x-latest.xml => usb-controller-default-s390x.s390x-latest.xml} (59%) create mode 100644 tests/qemuxmlconfdata/usb-controller-default-s390x.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml delete mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.args copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-default-unavailable-realview.aarch64-latest.err} (100%) delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.aarch64-latest.args delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.aarch64-latest.xml delete mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.xml delete mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.xml copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-default-unavailable-versatilepb.armv7l-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb.xml copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-default-unavailable-virt-aarch64.aarch64-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-virt-aarch64.xml copy tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-default-unavailable-virt-loongarch64.loongarch64-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-virt-loongarch64.xml rename tests/qemuxmlconfdata/{usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err => usb-controller-default-unavailable-virt-riscv64.riscv64-latest.err} (100%) create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-virt-riscv64.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.aarch64-latest.args delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.xml delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.armv7l-latest.xml copy tests/qemuxmlconfdata/{armv7l-versatilepb-minimal.armv7l-latest.abi-update.args => usb-controller-default-versatilepb.armv7l-latest.args} (94%) rename tests/qemuxmlconfdata/{usb-controller-default-fallback-versatilepb-armv7l.armv7l-latest.xml => usb-controller-default-versatilepb.armv7l-latest.xml} (93%) rename tests/qemuxmlconfdata/{usb-controller-default-versatilepb-armv7l.xml => usb-controller-default-versatilepb.xml} (87%) copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.args => usb-controller-default-virt-aarch64.aarch64-latest.args} (55%) copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.xml => usb-controller-default-virt-aarch64.aarch64-latest.xml} (63%) copy tests/qemuxmlconfdata/{usb-controller-default-isapc.xml => usb-controller-default-virt-aarch64.xml} (50%) copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.args => usb-controller-default-virt-loongarch64.loongarch64-latest.args} (55%) copy tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.xml => usb-controller-default-virt-loongarch64.loongarch64-latest.xml} (63%) copy tests/qemuxmlconfdata/{usb-controller-default-isapc.xml => usb-controller-default-virt-loongarch64.xml} (50%) rename tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.args => usb-controller-default-virt-riscv64.riscv64-latest.args} (55%) rename tests/qemuxmlconfdata/{usb-controller-implicit-q35.x86_64-latest.xml => usb-controller-default-virt-riscv64.riscv64-latest.xml} (65%) copy tests/qemuxmlconfdata/{usb-controller-default-isapc.xml => usb-controller-default-virt-riscv64.xml} (57%) rename tests/qemuxmlconfdata/{usb-controller-nex-xhci-autoassign.x86_64-latest.args => usb-controller-nec-xhci-autoassign.x86_64-latest.args} (100%) rename tests/qemuxmlconfdata/{usb-controller-nex-xhci-autoassign.x86_64-latest.xml => usb-controller-nec-xhci-autoassign.x86_64-latest.xml} (100%) rename tests/qemuxmlconfdata/{usb-controller-nex-xhci-autoassign.xml => usb-controller-nec-xhci-autoassign.xml} (64%) -- 2.51.0

5 61

[PATCH v2 00/27] CI/build-sys fixes to enable Rust more widely
by marcandre.lureau＠redhat.com 01 Oct '25

01 Oct '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series fixes a number of issues with the build system and CI and enable Rust for many of our jobs, getting us closer to enable Rust by default. emscripten is difficult to enable, help welcome. v2: - add a rust-to-clang-target-test.sh configure script - drop "RFC: configure: use the same machine as the host triple" - replace "tests: move mips to debian-legacy-test-cross" with "RFC: build-sys: deprecate mips host" - start tackling emscripten - fix mis-placed submodule update - other minor changes, commit message tweaks, bz links - add r-b tags Marc-André Lureau (27): build-sys: require -lrt when no shm_open() in std libs gitlab-ci: fix 'needs' property type must be array scripts/archive-source: speed up downloading subprojects scripts/archive-source: silence subprojects downloads scripts/archive-source: use a bash array configure: fix rust meson configuration configure: set the bindgen cross target tests/docker/common: print errors to stderr tests/docker: use fully qualified image name for emsdk tests/docker/common: print meson log on configure failure build-sys: cfi_debug and safe_stack are not compatible lcitool: update, switch to f41 lcitool/qemu: include libclang-rt for TSAN lcitool/alpine: workaround bindgen issue tests/lcitool: add missing rust-std dep tests/lcitool: update to debian13 tests/docker: add ENABLE_RUST environment tests/lcitool: enable rust & refresh configure: set the meson executable suffix/ext tests/freebsd: enable Rust meson: rust-bindgen limit allowlist-file to srcdir/include RFC: tests/docker: add rust to debian-legacy-test-cross WIP: gitlab-ci: enable rust for msys2-64bit WIP: cirrus/macos: enable Rust RFC: build-sys: deprecate mips host build-sys: pass -fvisibility=default for wasm bindgen WIP: enable rust for wasm/emscripten docs/about/build-platforms.rst | 2 - docs/about/deprecated.rst | 9 +-- configure | 27 +++++++- meson.build | 34 +++++++--- .gitlab-ci.d/buildtest-template.yml | 2 +- .gitlab-ci.d/buildtest.yml | 66 +++++++++---------- .gitlab-ci.d/cirrus.yml | 4 +- .gitlab-ci.d/crossbuilds.yml | 46 ++++++------- .gitlab-ci.d/static_checks.yml | 6 +- .gitlab-ci.d/windows.yml | 8 ++- rust/bql/meson.build | 1 + rust/chardev/meson.build | 1 + rust/hw/char/pl011/meson.build | 1 + rust/hw/core/meson.build | 1 + rust/migration/meson.build | 3 +- rust/qom/meson.build | 1 + rust/system/meson.build | 1 + rust/util/meson.build | 1 + scripts/archive-source.sh | 33 +++++++--- .../ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 5 +- .../ci/setup/ubuntu/ubuntu-2204-s390x.yaml | 5 +- scripts/rust-to-clang-target-test.sh | 43 ++++++++++++ scripts/rust-to-clang-target.sh | 62 +++++++++++++++++ tests/docker/common.rc | 11 +++- tests/docker/dockerfiles/alpine.docker | 6 +- tests/docker/dockerfiles/centos9.docker | 4 ++ .../dockerfiles/debian-amd64-cross.docker | 18 +++-- .../dockerfiles/debian-arm64-cross.docker | 18 +++-- .../dockerfiles/debian-armhf-cross.docker | 21 +++--- .../dockerfiles/debian-i686-cross.docker | 20 ++++-- .../debian-legacy-test-cross.docker | 9 ++- .../dockerfiles/debian-mips64el-cross.docker | 9 ++- .../dockerfiles/debian-mipsel-cross.docker | 9 ++- .../dockerfiles/debian-ppc64el-cross.docker | 18 +++-- .../dockerfiles/debian-riscv64-cross.docker | 10 ++- .../dockerfiles/debian-s390x-cross.docker | 18 +++-- tests/docker/dockerfiles/debian.docker | 18 +++-- .../dockerfiles/emsdk-wasm32-cross.docker | 29 +++++++- .../dockerfiles/fedora-rust-nightly.docker | 18 +++-- .../dockerfiles/fedora-win64-cross.docker | 15 +++-- tests/docker/dockerfiles/fedora.docker | 18 +++-- tests/docker/dockerfiles/opensuse-leap.docker | 7 +- tests/docker/dockerfiles/ubuntu2204.docker | 7 +- tests/docker/test-wasm | 12 ++++ tests/lcitool/libvirt-ci | 2 +- tests/lcitool/projects/qemu.yml | 3 +- tests/lcitool/refresh | 48 +++++++++----- tests/vm/freebsd | 4 +- 48 files changed, 531 insertions(+), 183 deletions(-) create mode 100755 scripts/rust-to-clang-target-test.sh create mode 100644 scripts/rust-to-clang-target.sh create mode 100755 tests/docker/test-wasm -- 2.51.0

9 51

[PATCH] virt-login-shell: check for NULL from virGetLastError()
by gerben＠altlinux.org 01 Oct '25

01 Oct '25

From: Denis Rastyogin <gerben(a)altlinux.org> virGetLastError() may return NULL in case of OOM. Without a check this could lead to a NULL pointer dereference when accessing its fields. The result of virGetLastError() is usually checked in other places, so add the missing check here as well. Found by Linux Verification Center (linuxtesting.org) with SVACE. Reported-by: Pavel Nekrasov <p.nekrasov(a)fobos-nt.ru> Signed-off-by: Denis Rastyogin <gerben(a)altlinux.org> --- tools/virt-login-shell-helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helper.c index cb59b5dec0..9282ca481e 100644 --- a/tools/virt-login-shell-helper.c +++ b/tools/virt-login-shell-helper.c @@ -282,6 +282,10 @@ main(int argc, char **argv) if (!virDomainIsActive(dom) && virDomainCreate(dom) < 0) { virErrorPtr last_error; last_error = virGetLastError(); + + if (!last_error) + goto cleanup; + if (last_error->code != VIR_ERR_OPERATION_INVALID) { virReportSystemError(last_error->code, _("Can't create %1$s container: %2$s"), -- 2.42.2

3 3