June 2025 - Devel - libvirt List Archives

[PATCH] qemu.conf: Improve docs for 'dynamic_ownership' option
by Peter Krempa 09 Jun '25

09 Jun '25

From: Peter Krempa <pkrempa(a)redhat.com> Add a note that the user/group can be overriden or relabelling disabled using per-vm/disk <seclabel> elements instead of disabling it globally. Add a note that read-only image labels are not restored. Closes: https://gitlab.com/libvirt/libvirt/-/issues/512 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu.conf.in | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 042bb75b50..221bfa8095 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -513,7 +513,17 @@ # Whether libvirt should dynamically change file ownership # to match the configured user/group above. Defaults to 1. -# Set to 0 to disable file ownership changes. +# +# Notes: +# - Per domain or per disk image user and group can be configured, or +# relabelling disabled using the <seclabel model='dac'> elements in XML: +# +# https://www.libvirt.org/formatdomain.html#security-label +# +# - The user/group of read-only images is not restored as with read-write +# images as they may be shared among more domains. +# +# Set to 0 to disable file ownership changes globally in the qemu driver. #dynamic_ownership = 1 # Whether libvirt should remember and restore the original -- 2.49.0

2 1

[PATCH] nodedev: add nodedev name to mdevctl unsupport msg
by Boris Fiuczynski 09 Jun '25

09 Jun '25

Let's add the nodedev name to improve the error message for the user. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- src/node_device/node_device_driver.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 2c9e749495..de103d1967 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -927,6 +927,7 @@ nodeDeviceGetMdevctlModifySupportCheck(void) static int virMdevctlModify(virNodeDeviceDef *def, + const char *def_name, bool defined, bool live) { @@ -942,8 +943,9 @@ virMdevctlModify(virNodeDeviceDef *def, if (nodeDeviceGetMdevctlModifySupportCheck() < 0) { VIR_WARN("Installed mdevctl version does not support modify with options jsonfile, defined and live"); - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Unable to modify mediated device: modify unsupported")); + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("Unable to modify mediated device '%1$s': modify unsupported"), + def_name); return -1; } @@ -952,8 +954,8 @@ virMdevctlModify(virNodeDeviceDef *def, if (status != 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to modify mediated device: %1$s"), - MDEVCTL_ERROR(errmsg)); + _("Unable to modify mediated device '%1$s': %2$s"), + def_name, MDEVCTL_ERROR(errmsg)); return -1; } @@ -1608,8 +1610,9 @@ nodeDeviceDefineXML(virConnect *conn, * nodeDeviceDefValidateUpdate() is not required as uuid and * parent are matching if def was found and changing the type in * the persistent config is allowed. */ - VIR_DEBUG("Update node device '%s' with mdevctl", def->name); - modify_failed = (virMdevctlModify(def, true, false) < 0); + virNodeDeviceDef *olddef = virNodeDeviceObjGetDef(persistent_obj); + VIR_DEBUG("Update node device '%s' with mdevctl", olddef->name); + modify_failed = (virMdevctlModify(def, olddef->name, true, false) < 0); virNodeDeviceObjEndAPI(&persistent_obj); if (modify_failed) return NULL; @@ -2357,6 +2360,7 @@ nodeDeviceUpdate(virNodeDevice *device, /* Update now. */ VIR_DEBUG("Update node device '%s' with mdevctl", def->name); if (virMdevctlModify(new_def, + def->name, (flags & VIR_NODE_DEVICE_UPDATE_AFFECT_CONFIG), (flags & VIR_NODE_DEVICE_UPDATE_AFFECT_LIVE)) < 0) { goto cleanup; -- 2.49.0

2 1

[PATCH] ci: refresh with 'lcitool manifest'
by Michal Privoznik 09 Jun '25

09 Jun '25

From: Michal Privoznik <mprivozn(a)redhat.com> - Replace Alpine 3.21 with 3.22 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1860029940 ci/buildenv/{alpine-321.sh => alpine-322.sh} | 0 .../{alpine-321.Dockerfile => alpine-322.Dockerfile} | 2 +- ci/gitlab/builds.yml | 8 ++++---- ci/gitlab/containers.yml | 4 ++-- ci/manifest.yml | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) rename ci/buildenv/{alpine-321.sh => alpine-322.sh} (100%) rename ci/containers/{alpine-321.Dockerfile => alpine-322.Dockerfile} (98%) diff --git a/ci/buildenv/alpine-321.sh b/ci/buildenv/alpine-322.sh similarity index 100% rename from ci/buildenv/alpine-321.sh rename to ci/buildenv/alpine-322.sh diff --git a/ci/containers/alpine-321.Dockerfile b/ci/containers/alpine-322.Dockerfile similarity index 98% rename from ci/containers/alpine-321.Dockerfile rename to ci/containers/alpine-322.Dockerfile index 2351b03653..03db9a3d22 100644 --- a/ci/containers/alpine-321.Dockerfile +++ b/ci/containers/alpine-322.Dockerfile @@ -4,7 +4,7 @@ # # https://gitlab.com/libvirt/libvirt-ci -FROM docker.io/library/alpine:3.21 +FROM docker.io/library/alpine:3.22 RUN apk update && \ apk upgrade && \ diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index 5fab2008d8..ae691862c2 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -33,15 +33,15 @@ x86_64-almalinux-9-clang: TARGET_BASE_IMAGE: docker.io/library/almalinux:9 -x86_64-alpine-321: +x86_64-alpine-322: extends: .native_build_job needs: - - job: x86_64-alpine-321-container + - job: x86_64-alpine-322-container optional: true allow_failure: false variables: - NAME: alpine-321 - TARGET_BASE_IMAGE: docker.io/library/alpine:3.21 + NAME: alpine-322 + TARGET_BASE_IMAGE: docker.io/library/alpine:3.22 x86_64-alpine-edge: diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml index 05809fbdeb..0650e4781c 100644 --- a/ci/gitlab/containers.yml +++ b/ci/gitlab/containers.yml @@ -14,11 +14,11 @@ x86_64-almalinux-9-container: NAME: almalinux-9 -x86_64-alpine-321-container: +x86_64-alpine-322-container: extends: .container_job allow_failure: false variables: - NAME: alpine-321 + NAME: alpine-322 x86_64-alpine-edge-container: diff --git a/ci/manifest.yml b/ci/manifest.yml index 14bfef25d2..21d570cb00 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -19,7 +19,7 @@ targets: RPM: skip CC: clang - alpine-321: x86_64 + alpine-322: x86_64 alpine-edge: jobs: -- 2.49.0

2 1

[PATCH v5 0/3] Fix virtio console port assignment issue
by Aaron M. Brown 09 Jun '25

09 Jun '25

Changelog: --- v5: - Added xml tests to tests/qemuxmlconfdata - Fixed virito -> virtio typo in commit message --- v4: - Update commit messages --- v3: - Added Reviewed-By - Included CI Results Link --- v2: - Split patch into two commits - Added fixes tag --- This libvirt patch series does the following: 1. fixes an issue with virtio console device port auto assignment on vioserial buses 2. updates console port reservation comment and changes the allowZero variable to allowPortZero for clarity 3. Adds tests for virtio console on the vioserial bus Currently in libvirt, a virtio console device cannot be auto assigned a port number greater than zero on a vioserial bus. This leads to port collision errors when adding more than 1 virtio console device on a single vioserial bus. After applying this patch, one can add multiple console ports under a single vioserial bus. Here is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1855918840 Aaron M. Brown (3): qemuxmlconftest: Add console-virtio-vioserial tests virDomainVirtioSerialAddrAssign: Fix virtio console port auto assignment on vioserial bus domain_addr.c: update console port reservation comment and allowZero var to allowPortZero for clarity src/conf/domain_addr.c | 27 +++++--- ...onsole-virtio-vioserial.x86_64-latest.args | 44 +++++++++++++ ...console-virtio-vioserial.x86_64-latest.xml | 63 +++++++++++++++++++ .../console-virtio-vioserial.xml | 48 ++++++++++++++ tests/qemuxmlconftest.c | 1 + 5 files changed, 173 insertions(+), 10 deletions(-) create mode 100644 tests/qemuxmlconfdata/console-virtio-vioserial.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/console-virtio-vioserial.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/console-virtio-vioserial.xml -- 2.39.5 (Apple Git-154)

3 7

[PATCH pushed] virDomainDriverAutoShutdown: Fix printf conversion specifier for 'waitShutdownSecs'
by Peter Krempa 09 Jun '25

09 Jun '25

From: Peter Krempa <pkrempa(a)redhat.com> The variable is declared as unsigned int but two places used '%d'. Reported-in: https://issues.redhat.com/browse/RHEL-95721 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Trivial. src/hypervisor/domain_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c index 35966a5a8d..62bbe176ae 100644 --- a/src/hypervisor/domain_driver.c +++ b/src/hypervisor/domain_driver.c @@ -880,9 +880,9 @@ virDomainDriverAutoShutdown(virDomainDriverAutoShutdownConfig *cfg) } timer = g_timer_new(); - virSystemdNotifyStatus("Waiting %d secs for VM shutdown completion", + virSystemdNotifyStatus("Waiting %u secs for VM shutdown completion", cfg->waitShutdownSecs); - VIR_INFO("Waiting %d secs for VM shutdown completion", cfg->waitShutdownSecs); + VIR_INFO("Waiting %u secs for VM shutdown completion", cfg->waitShutdownSecs); while (1) { bool anyRunning = false; for (i = 0; i < numDomains; i++) { -- 2.49.0

1 0

[PATCH v4 0/2] Fix virtio console port assignment issue
by Aaron M. Brown 05 Jun '25

05 Jun '25

Changelog: --- v4: - Update commit messages --- v3: - Added Reviewed-By - Included CI Results Link --- v2: - Split patch into two commits - Added fixes tag --- This libvirt patch does the following: 1. fixes an issue with virtio console device port assignment on vioserial buses 2. updates console port reservation comment and changes the allowZero variable to allowPortZero for clarity Currently in libvirt, a virtio console device cannot be assigned a port number greater than zero on a vioserial bus. This leads to port collision errors when adding more than 1 virtio console device on a single vioserial bus. After applying this patch, one can add multiple console ports under a single vioserial bus. Here is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1832324065 Aaron M. Brown (2): virDomainVirtioSerialAddrAssign: Fix virtio console port assignment on vioserial bus domain_addr.c: Update console port reservation comment and allowZero variable for clarity src/conf/domain_addr.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) -- 2.39.5 (Apple Git-154)

4 7

[PATCH 0/3] docs: Small tweaks to downloads page
by Andrea Bolognani 05 Jun '25

05 Jun '25

*** CLICK HERE TO BLURB *** Andrea Bolognani (3): docs: Unify clone instructions docs: Drop mention of read-only git mirrors docs: Add prompt to clone commands docs/downloads.rst | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.49.0

2 7

[PATCH 0/2] docs: Fix docs for VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES
by Peter Krempa 05 Jun '25

05 Jun '25

Remove note about needing a pre-cleared image and document need to enable discards to obtain a sparse image. Peter Krempa (2): Revert "docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES" docs: Note that zero detection on migration sparsifies image only when discard='unmap' is set docs/manpages/virsh.rst | 7 +++---- include/libvirt/libvirt-domain.h | 12 +++++------- 2 files changed, 8 insertions(+), 11 deletions(-) -- 2.49.0

2 3

[PATCH 0/7] virsh: Fix cleanup in 'event' command and introduce 'await' command
by Peter Krempa 05 Jun '25

05 Jun '25

'virsh await' is a helper/syntax-sugar command which allows you to wait until a domain reaches a certain state. Currently this series implements conditions named 'domain-inactive' and 'guest-agent-available'. Peter Krempa (7): virthread: Register auto cleanup function for virMutex virthread: Add infrastructure for static virCond definitions virsh: cmdEvent: Ensure that event callbacks are unregistered before returning vshCommandRun: Convert to directly return the exit code vsh: Add support for commands with more return values virsh: Introduce 'await' command for waiting until target domain state is reached virsh: await: Introduce 'guest-agent-available' condition docs/manpages/virsh.rst | 30 ++++ src/util/virthread.h | 7 + tools/virsh-domain-event.c | 321 ++++++++++++++++++++++++++++++++++++- tools/virsh.c | 4 +- tools/virt-admin.c | 4 +- tools/vsh.c | 46 ++++-- tools/vsh.h | 3 +- 7 files changed, 398 insertions(+), 17 deletions(-) -- 2.49.0

2 8

[PATCH] libxl_capabilities: Make some functions return void
by Michal Privoznik 05 Jun '25

05 Jun '25

From: Michal Privoznik <mprivozn(a)redhat.com> Inside of libxlMakeDomainCapabilities() there are some functions called and basically all of them never return anything but zero (indicating success). Yet, they are called in a fashion that suggests otherwise. Turn those functions into void and drop checks for their retvals. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libxl/libxl_capabilities.c | 43 +++++++++++++--------------------- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/src/libxl/libxl_capabilities.c b/src/libxl/libxl_capabilities.c index 6aca4075e7..48f7619cc4 100644 --- a/src/libxl/libxl_capabilities.c +++ b/src/libxl/libxl_capabilities.c @@ -512,7 +512,7 @@ libxlCapsInitGuests(libxl_ctx *ctx, virCaps *caps) return 0; } -static int +static void libxlMakeDomainOSCaps(const char *machine, virDomainCapsOS *os, virFirmware **firmwares, @@ -527,7 +527,7 @@ libxlMakeDomainOSCaps(const char *machine, capsLoader->readonly.report = true; if (STREQ(machine, "xenpv") || STREQ(machine, "xenpvh")) - return 0; + return; capsLoader->supported = VIR_TRISTATE_BOOL_YES; capsLoader->values.values = g_new0(char *, nfirmwares); @@ -542,11 +542,9 @@ libxlMakeDomainOSCaps(const char *machine, VIR_DOMAIN_LOADER_TYPE_PFLASH); VIR_DOMAIN_CAPS_ENUM_SET(capsLoader->readonly, VIR_TRISTATE_BOOL_YES); - - return 0; } -static int +static void libxlMakeDomainDeviceDiskCaps(virDomainCapsDeviceDisk *dev) { dev->supported = VIR_TRISTATE_BOOL_YES; @@ -562,11 +560,9 @@ libxlMakeDomainDeviceDiskCaps(virDomainCapsDeviceDisk *dev) VIR_DOMAIN_DISK_BUS_IDE, VIR_DOMAIN_DISK_BUS_SCSI, VIR_DOMAIN_DISK_BUS_XEN); - - return 0; } -static int +static void libxlMakeDomainDeviceGraphicsCaps(virDomainCapsDeviceGraphics *dev) { dev->supported = VIR_TRISTATE_BOOL_YES; @@ -576,11 +572,9 @@ libxlMakeDomainDeviceGraphicsCaps(virDomainCapsDeviceGraphics *dev) VIR_DOMAIN_GRAPHICS_TYPE_SDL, VIR_DOMAIN_GRAPHICS_TYPE_VNC, VIR_DOMAIN_GRAPHICS_TYPE_SPICE); - - return 0; } -static int +static void libxlMakeDomainDeviceVideoCaps(virDomainCapsDeviceVideo *dev) { dev->supported = VIR_TRISTATE_BOOL_YES; @@ -590,11 +584,9 @@ libxlMakeDomainDeviceVideoCaps(virDomainCapsDeviceVideo *dev) VIR_DOMAIN_VIDEO_TYPE_VGA, VIR_DOMAIN_VIDEO_TYPE_CIRRUS, VIR_DOMAIN_VIDEO_TYPE_XEN); - - return 0; } -static int +static void libxlMakeDomainDeviceHostdevCaps(virDomainCapsDeviceHostdev *dev) { dev->supported = VIR_TRISTATE_BOOL_YES; @@ -625,10 +617,9 @@ libxlMakeDomainDeviceHostdevCaps(virDomainCapsDeviceHostdev *dev) virDomainCapsEnumClear(&dev->pciBackend); VIR_DOMAIN_CAPS_ENUM_SET(dev->pciBackend, VIR_DEVICE_HOSTDEV_PCI_DRIVER_NAME_XEN); - return 0; } -static int +static void libxlMakeDomainDeviceConsoleCaps(virDomainCapsDeviceConsole *console) { console->supported = VIR_TRISTATE_BOOL_YES; @@ -643,8 +634,6 @@ libxlMakeDomainDeviceConsoleCaps(virDomainCapsDeviceConsole *console) VIR_DOMAIN_CHR_TYPE_UDP, VIR_DOMAIN_CHR_TYPE_UNIX, VIR_DOMAIN_CHR_TYPE_VC); - - return 0; } virCaps * @@ -698,15 +687,15 @@ libxlMakeDomainCapabilities(virDomainCaps *domCaps, else domCaps->maxvcpus = PV_MAX_VCPUS; - if (libxlMakeDomainOSCaps(domCaps->machine, os, firmwares, nfirmwares) < 0 || - libxlMakeDomainDeviceDiskCaps(disk) < 0 || - libxlMakeDomainDeviceGraphicsCaps(graphics) < 0 || - libxlMakeDomainDeviceVideoCaps(video) < 0 || - libxlMakeDomainDeviceConsoleCaps(console)) - return -1; - if (STRNEQ(domCaps->machine, "xenpvh") && - libxlMakeDomainDeviceHostdevCaps(hostdev) < 0) - return -1; + libxlMakeDomainOSCaps(domCaps->machine, os, firmwares, nfirmwares); + libxlMakeDomainDeviceDiskCaps(disk); + libxlMakeDomainDeviceGraphicsCaps(graphics); + libxlMakeDomainDeviceVideoCaps(video); + libxlMakeDomainDeviceConsoleCaps(console); + + if (STRNEQ(domCaps->machine, "xenpvh")) { + libxlMakeDomainDeviceHostdevCaps(hostdev); + } domCaps->features[VIR_DOMAIN_CAPS_FEATURE_IOTHREADS] = VIR_TRISTATE_BOOL_NO; domCaps->features[VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO] = VIR_TRISTATE_BOOL_NO; -- 2.49.0

2 1