Devel

Download

devel@lists.libvirt.org

June 2025

44 participants
92 discussions

[PATCH] esx: Avoid corner case where esxUtil_ParseDatastorePath could be called with NULL 'datastorePath'
by Peter Krempa 02 Jun '25

02 Jun '25

From: Peter Krempa <pkrempa(a)redhat.com> The generated code which parses the data from XML in esxVI_LookupDatastoreContentByDatastoreName can fill the 'folderPath' property with NULL if it were missing from the input XML. While this is not likely when talking to esx it is a possible outcome. Skipp NULL results. All other code paths already ensure that the function is not called with NULL. Closes: https://gitlab.com/libvirt/libvirt/-/issues/776 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/esx/esx_storage_backend_vmfs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/esx/esx_storage_backend_vmfs.c b/src/esx/esx_storage_backend_vmfs.c index 145aff0c9c..8e13201fe2 100644 --- a/src/esx/esx_storage_backend_vmfs.c +++ b/src/esx/esx_storage_backend_vmfs.c @@ -616,6 +616,9 @@ esxStoragePoolListVolumes(virStoragePoolPtr pool, char **const names, searchResults = searchResults->_next) { g_autofree char *directoryAndFileName = NULL; + if (!searchResults->folderPath) + continue; + if (esxUtil_ParseDatastorePath(searchResults->folderPath, NULL, NULL, &directoryAndFileName) < 0) { goto cleanup; @@ -759,6 +762,9 @@ esxStorageVolLookupByKey(virConnectPtr conn, const char *key) searchResults = searchResults->_next) { g_autofree char *directoryAndFileName = NULL; + if (searchResults->folderPath) + continue; + if (esxUtil_ParseDatastorePath(searchResults->folderPath, NULL, NULL, &directoryAndFileName) < 0) { goto cleanup; -- 2.49.0

2 1

Release of libvirt-11.4.0
by Jiri Denemark 02 Jun '25

02 Jun '25

The 11.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: ppc64 POWER11 processor support Support for the recently released IBM POWER11 processor was added. * Packaging changes * All helper programs are now detected from ``$PATH`` during runtime All of the code was now converted to dynamically look up helper programs in ``$PATH`` rather than doing the lookup at build time and then compiling in the result. Programs ``mount``, ``umount``, ``mkfs``, ``modprobe``, ``rmmod``, ``numad``, ``dmidecode``, ``ip``, ``tc``, ``mdevctl``, ``mm-ctl``, ``iscsiadm``, ``ovs-vsctl``, ``pkttyagent``, ``bhyveload``, ``bhyvectl``, ``bhyve``, ``ifconfig``, ``vzlist``, ``vzctl``, ``vzmigrate``, and the tools from the lvm suite (``vgchange``, ``lvcreate``, etc..) are now not needed during build and will still work properly if placed in ``$PATH``. This also ensures that libvirt works correctly on distros that are transitioning ``/sbin`` into ``/bin`` and upgraded installations have a different layout from fresh installations. * Improvements * virsh: Add option ``--no-pkttyagent`` That option suppresses registration of pkttyagent with polkitd. * bhyve: support NVRAM configuration for UEFI firmwares The bhyve driver now supports specifying NVRAM store file, such as:: <os firmware='efi'> <nvram/> </os> * qemu: Improve accuracy of FDC/floppy device support statement in capabilities XML The data is now based on the presence of the controller in qemu rather than just a denylist of machine types where floppies not work. * Bug fixes * qemu: Fix failure when reverting to internal snapshots A regression in ``libvirt-11.2`` and ``libvirt-11.3`` prevents reverting to an internal snapshot. Attempts to revert would produce the following error:: error: operation failed: load of internal snapshot 'foo1' job failed: Device 'libvirt-1-format' is writable but does not support snapshots The only workaround is to avoid the broken versions. * qemu: Fix virtqemud crash when resuming failed post-copy migration A regression introduced in ``libvirt-11.2.0`` caused virtqemud on the destination host to crash when trying to resume failed post-copy migration. * qemu: Treat the ``queues`` configuration of ``virtio-net`` as guest ABI The queue count itself isn't a device frontend property but libvirt uses it to calculate ``vectors`` option of the device which is a guest OS visible property, thus ``queues`` must not change during migration. The ABI stability check now handles this properly. Enjoy. Jirka

1 0