[PATCH 0/8] qemu: Follow-up to "schemas: domaincaps: Add missing schema for '<cpu0Id>'"
by Peter Krempa
As promised in the original patch fixing the schema this is the
test-case follow up.
As not entirely expected it's a bit more involved and also contains
fixes for other bugs.
Peter Krempa (8):
qemu: capabilities: Parse 'cpu0Id' from capability cache XML
domaincapstest: Use proper input file based on 'variant' in
'fillQemuCaps'
domaincapstest: Allow tests of all capability variants
qemucapabilitiesdata: Document '+amdsev' variant
qemucapabilitiestest: Add test data for 'qemu-9.2' on a SEV-enabled
AMD host
qemuxmlconftest: Propery discriminate output files for caps variants
qemuxmlconftest: Add 'latest' version of 'launch-security-sev*'
originally using 6.0.0
qemuxmlconftest: Add '+amdsev' versions of the rest of
'launch-security-sev*' cases
src/qemu/qemu_capabilities.c | 1 +
.../qemu_7.0.0-hvf.aarch64+hvf.xml | 43 +-
.../qemu_7.2.0-hvf.x86_64+hvf.xml | 952 +-
.../qemu_9.2.0-q35.x86_64+amdsev.xml | 852 +
.../qemu_9.2.0-tcg.x86_64+amdsev.xml | 1821 +
.../qemu_9.2.0.x86_64+amdsev.xml | 852 +
tests/domaincapstest.c | 21 +-
tests/qemucapabilitiesdata/README.rst | 4 +
.../caps_9.2.0_x86_64+amdsev.replies | 43857 ++++++++++++++++
.../caps_9.2.0_x86_64+amdsev.xml | 3132 ++
.../caps.x86_64+amdsev.xml | 29 +
...h64-virt-headless.aarch64-latest+hvf.args} | 0
...ch64-virt-headless.aarch64-latest+hvf.xml} | 0
...86_64-q35-headless.x86_64-latest+hvf.args} | 0
...x86_64-q35-headless.x86_64-latest+hvf.xml} | 0
...urity-sev-direct.x86_64-latest+amdsev.args | 38 +
...curity-sev-direct.x86_64-latest+amdsev.xml | 48 +
...ng-platform-info.x86_64-latest+amdsev.args | 35 +
...ing-platform-info.x86_64-latest+amdsev.xml | 43 +
...security-sev-snp.x86_64-latest+amdsev.args | 42 +
...-security-sev-snp.x86_64-latest+amdsev.xml | 73 +
...nch-security-sev.x86_64-latest+amdsev.args | 35 +
...unch-security-sev.x86_64-latest+amdsev.xml | 45 +
tests/qemuxmlconftest.c | 40 +-
tests/testutilsqemu.c | 6 +-
25 files changed, 51941 insertions(+), 28 deletions(-)
create mode 100644 tests/domaincapsdata/qemu_9.2.0-q35.x86_64+amdsev.xml
create mode 100644 tests/domaincapsdata/qemu_9.2.0-tcg.x86_64+amdsev.xml
create mode 100644 tests/domaincapsdata/qemu_9.2.0.x86_64+amdsev.xml
create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.replies
create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml
create mode 100644 tests/qemucaps2xmloutdata/caps.x86_64+amdsev.xml
rename tests/qemuxmlconfdata/{hvf-aarch64-virt-headless.aarch64-latest.args => hvf-aarch64-virt-headless.aarch64-latest+hvf.args} (100%)
rename tests/qemuxmlconfdata/{hvf-aarch64-virt-headless.aarch64-latest.xml => hvf-aarch64-virt-headless.aarch64-latest+hvf.xml} (100%)
rename tests/qemuxmlconfdata/{hvf-x86_64-q35-headless.x86_64-latest.args => hvf-x86_64-q35-headless.x86_64-latest+hvf.args} (100%)
rename tests/qemuxmlconfdata/{hvf-x86_64-q35-headless.x86_64-latest.xml => hvf-x86_64-q35-headless.x86_64-latest+hvf.xml} (100%)
create mode 100644 tests/qemuxmlconfdata/launch-security-sev-direct.x86_64-latest+amdsev.args
create mode 100644 tests/qemuxmlconfdata/launch-security-sev-direct.x86_64-latest+amdsev.xml
create mode 100644 tests/qemuxmlconfdata/launch-security-sev-missing-platform-info.x86_64-latest+amdsev.args
create mode 100644 tests/qemuxmlconfdata/launch-security-sev-missing-platform-info.x86_64-latest+amdsev.xml
create mode 100644 tests/qemuxmlconfdata/launch-security-sev-snp.x86_64-latest+amdsev.args
create mode 100644 tests/qemuxmlconfdata/launch-security-sev-snp.x86_64-latest+amdsev.xml
create mode 100644 tests/qemuxmlconfdata/launch-security-sev.x86_64-latest+amdsev.args
create mode 100644 tests/qemuxmlconfdata/launch-security-sev.x86_64-latest+amdsev.xml
--
2.48.1
2 months
[PATCH] docs/api.rst: revert erroneously change of Once -> OnDevice
by Cleber Rosa
Commit af1b89d1d for some reason changed a perfectly fine statement to
one that I could not understand. Let's revert it.
Signed-off-by: Cleber Rosa <crosa(a)redhat.com>
---
docs/api.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/api.rst b/docs/api.rst
index cdba642967..243303de68 100644
--- a/docs/api.rst
+++ b/docs/api.rst
@@ -26,7 +26,7 @@ name will default to a preselected hypervisor, but it's probably not a
wise thing to do in most cases. See the `connection URI <uri.html>`__
page for a full descriptions of the values allowed.
-OnDevice the application obtains a
+Once the application obtains a
`virConnectPtr <html/libvirt-libvirt-host.html#virConnectPtr>`__
connection to the hypervisor it can then use it to manage the
hypervisor's available domains and related virtualization resources,
--
2.48.1
2 months
[PATCH] schemas: domaincaps: Add missing schema for '<cpu0Id>'
by Peter Krempa
Fixes: 0236e6154c46603bc443eda2f05c8ce511c55b08
Resolves: https://issues.redhat.com/browse/RHEL-81890
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
I'll also attempt to add tests for this once I'll be able to get to a
capability dump from a sev-es enabled box.
src/conf/schemas/domaincaps.rng | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/conf/schemas/domaincaps.rng b/src/conf/schemas/domaincaps.rng
index 3559d2ae05..595dbcd634 100644
--- a/src/conf/schemas/domaincaps.rng
+++ b/src/conf/schemas/domaincaps.rng
@@ -438,6 +438,11 @@
<data type="unsignedInt"/>
</element>
</optional>
+ <optional>
+ <element name="cpu0Id">
+ <data type="string"/>
+ </element>
+ </optional>
</element>
</define>
--
2.48.1
2 months
[PATCH] qemuPrepareNVRAMFile: Fix NVRAM image conversion check
by Peter Krempa
In case when user provides custom paths (those not covered by the JSON
firmware descriptor files or the default locations) for the
loader and nvram template no auto-detection will be performed and user's
config will be taken at face value. Historically when 'templateFormat'
didn't exist we assumed that the 'format' field covers both.
Thus if 'templateFormat' is VIR_STORAGE_FILE_NONE we need to skip the
check forbidding image format conversion for 'file' backed to avoid
breaking legacy configs with manual/non-detected format assuming that
user picked the correct format.
Add a comment to the declaration of 'nvramTemplateFormat' noting the
above for future reference.
Resolves: https://issues.redhat.com/browse/RHEL-81731
Fixes: 2aa644a2fc8
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/conf/domain_conf.h | 7 +++++++
src/qemu/qemu_process.c | 5 ++++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index d4fa79cb84..1fcc3fdb98 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2362,6 +2362,13 @@ struct _virDomainLoaderDef {
virStorageSource *nvram;
bool newStyleNVRAM;
char *nvramTemplate; /* user override of path to master nvram */
+ /* Historically it was assumed that the format of the template and the
+ * actual nvram image are identical, which is no longer true.
+ *
+ * Note: if 'nvramTemplate' comes from the user and is not overriden by
+ * auto-detection nvramTemplateFormat may be VIR_STORAGE_FILE_NONE. Code
+ * shall assume that the template format matches if it isn't provided.
+ */
virStorageFileFormat nvramTemplateFormat;
};
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 0d9b8bcb93..7b7b5c17e3 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4709,7 +4709,10 @@ qemuPrepareNVRAMFile(virQEMUDriver *driver,
return -1;
}
- if (loader->nvram->format != loader->nvramTemplateFormat) {
+ /* If 'nvramTemplateFormat' is empty it means that it's a user-provided
+ * template which we couldn't verify. Assume the user knows what they're doing */
+ if (loader->nvramTemplateFormat != VIR_STORAGE_FILE_NONE &&
+ loader->nvram->format != loader->nvramTemplateFormat) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("conversion of the nvram template to another target format is not supported"));
return -1;
--
2.48.1
2 months, 1 week
Release of libvirt-11.1.0
by Jiri Denemark
The 11.1.0 release of both libvirt and libvirt-python is tagged and
signed tarballs are available at
https://download.libvirt.org/
https://download.libvirt.org/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback. Your work is greatly
appreciated.
* Packaging changes
* De-modularize the 'fs' storage file backend
The storage file backend for local files uses only code which we compile
into the internal libraries anyways so there's no point in having it
as a loadable module. The ``storage-file/libvirt_storage_file_fs.so`` module
no longer exists and its functionality is embedded directly.
* Removed features
* vbox: removed support for version 6.1 APIs
Libvirt no longer supports use of VirtualBox 6.1 since this version reached
its end of life on 2024/01.
* New features
* nodedev: Support ccwgroup based qeth devices
CCW group devices are devices that use multiple subchannels on the
mainframe's channel subsystem. A qeth group device maps to subchannels and
their corresponding device numbers and device bus-IDs. The ``ccwgroup``
device nodes are placed besides the subchannel nodes under computer and list
the group members within a new ``ccwgroup`` capability. A new capability
``ccwgroup_member`` is added into capability ``ccw`` to represent a device
membership to a ccwgroup. Filters are added to find ccwgroups as well as
ccwgroup members.
* ch: Support handling events from cloud-hypervisor
The ch driver now supports handling events from the cloud-hypervisor.
Events include VM lifecyle operations such as shutdown, pause, resume,
etc. Libvirt will now read these events and take actions such as
updating domain state, etc.
* Introduce virtio-mem ``<memory/>`` model for s390 guests
The virtio-mem model of ``<memory/>`` device can now be used with s390
guests.
* Support using passt as the backend for interface type='vhostuser'
The combination of vhostuser transport with passt as the backend
provides high performance, fully featured networking without the
need for libvirt or QEMU to have any elevated privileges or
capabilities. Configuration and features are identical to the
configuration for type='user' with the passt backend.
* Improvements
* qemu: I/O error messages can be queried via ``virDomainGetMessages()``
The qemu hypervisor driver now preserves the last I/O error message along
with the timestamp when it was recorded and preserves it to be queried via
``virDomainGetMessages()``.
* Bug fixes
* tools: ssh-proxy: Check if domain is running before connecting to it
If domain is not running but has a static CID configured for its VSOCK then
the ssh-proxy parsed it anyways. This may have resulted in mistakenly
connecting to a different domain. Domain status is checked before parsing
its CID.
* apparmor: Allow SGX if configured
If domain has ``<memory model='sgx-epc'\>`` configured then libvirt now
adds corresponding devices into a per-domain profile so that AppArmor does
not deny QEMU access to them.
* qemu: Fix crash when starting a domain on a host with unknown host CPU
On hosts where we cannot detect a host CPU model (mostly aarch64 hosts)
starting a domain with a custom CPU model caused a crash of virtqemud.
The bug was introduced in libvirt-10.9.0
Enjoy.
Jirka
2 months, 1 week
