February 2025 - Devel - libvirt List Archives

[RFC PATCH v2 0/6] RFC: Add Arm CCA support for getting capability information and running Realm VM
by Akio Kakuno 28 Feb '25

28 Feb '25

Hi, all. This patch adds Arm CCA support to qemu driver for aarch64 system. CCA is an abbreviation for Arm Confidential Compute Architecture feature, it enhances the virtualization capabilities of the platform by separating the management of resources from access to those resources. We are not yet at the stage where we can merge this patch as host linux/qemu suppor is no yet merged, but I would like to receive reviews and comments on the overall direction. [summary] At this stage, all you can do is getting the CCA capability with the virsh domcapabilities command and start the CCA VM with the virsh create command. capability info uses qemu QMP to query qemu options. The option that exists now is for selecting a hash algorithm. qemu QMP sections currently only contains a single member, but is wrapped in sections for expansion. [Capability example] Execution results of 'virsh domcapability" on qemu <domaincapabilities> ... <features> ... </sgx> <cca supported='yes'> <enum name='measurement-algo'> <value>sha256</value> <value>sha512</value> </enum> </cca> <hyperv supported='yes'> ... </features> </domaincapabilities> [XML example] <domain> ... <launchsecurity type='cca'> <measurement-algo>sha256</measurement-algo> </launchsecurity> ... </domain> [limitations/tests] To obtain capability info, it is necessary to support the qemu QMP command, which qemu does not yet support. We added a QMP command to retrieve CCA info for test (See "[software version]" below). Also, I think we should check whether CPUFW supports CCA or not in qemu_firmware.c, but it is not yet implemented. We have confirmed that the added tests (qemucapabilitiestest, domaincapstest and qemuxmlconftest) and the CCA VM startup test (starting the CCA VM from the virsh create command) passed. The "personalization-value" and "measurement-log" parameters that exist in the current LinaroQEMU cca/v3 branch will not be specified as CCA VM startup parameters with the virsh create command. [software version] I followed the steps in Linaro's blog below. https://linaro.atlassian.net/wiki/spaces/QEMU/pages/29051027459/Building+an… The Qemu used was enhanced with CCA QMP command and found at: https://github.com/Kazuhiro-Abe-fj/linaro_qemu/tree/cca-qmp which is based on Linaro QEMU (cca/v3) https://git.codelinaro.org/linaro/dcap/qemu/-/tree/cca/v3?ref_type=heads Changes in v2: Split the patch into different features. Fixed two string memory leaks. String storage has been changed from pointer movement to memory copying, preventing double freeing. Added a test case to qemuconftest. Fixed an issue where communication with QMP did not work properly. Fixed an issue where <cca support="yes"> was output to the cache file when using virsh with a qemu binary that does not support QMP. RFC v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/V4S5… Signed-off-by: Akio Kakuno fj3333bs(a)fujitsu.com Akio Kakuno (6): src: Add ARM CCA support in qemu driver to launch VM src: Add ARM CCA support in domain capabilities command src: Add ARM CCA support in domain schema qemucapabilitiestest: Adds Arm CCA support domaincapstest: Adds Arm CCA support qemuxmlconftest: Adds Arm CCA support docs/formatdomain.rst | 28 + docs/formatdomaincaps.rst | 27 +- src/conf/domain_capabilities.c | 48 + src/conf/domain_capabilities.h | 12 + src/conf/domain_conf.c | 16 + src/conf/domain_conf.h | 7 + src/conf/domain_validate.c | 1 + src/conf/schemas/domaincaps.rng | 14 + src/conf/schemas/domaincommon.rng | 14 + src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 145 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_cgroup.c | 2 + src/qemu/qemu_command.c | 32 + src/qemu/qemu_driver.c | 2 + src/qemu/qemu_firmware.c | 1 + src/qemu/qemu_monitor.c | 10 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 98 + src/qemu/qemu_monitor_json.h | 4 + src/qemu/qemu_namespace.c | 2 + src/qemu/qemu_process.c | 4 + src/qemu/qemu_validate.c | 4 + src/security/security_dac.c | 2 + .../qemu_9.1.0-virt.aarch64.xml | 243 + tests/domaincapsdata/qemu_9.1.0.aarch64.xml | 243 + .../caps_9.1.0_aarch64.replies | 36222 ++++++++++++++++ .../caps_9.1.0_aarch64.xml | 540 + .../launch-security-cca.aarch64-latest.args | 30 + .../launch-security-cca.aarch64-latest.xml | 24 + tests/qemuxmlconfdata/launch-security-cca.xml | 16 + tests/qemuxmlconftest.c | 2 + 33 files changed, 37802 insertions(+), 1 deletion(-) create mode 100644 tests/domaincapsdata/qemu_9.1.0-virt.aarch64.xml create mode 100644 tests/domaincapsdata/qemu_9.1.0.aarch64.xml create mode 100644 tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_9.1.0_aarch64.xml create mode 100644 tests/qemuxmlconfdata/launch-security-cca.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/launch-security-cca.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-cca.xml -- 2.34.1

1 0

Re: [PATCH 2/2] tests: Add capabilities for QEMU 10.0 (unreleased) on aarch64
by Matt Ochs 28 Feb '25

28 Feb '25

Thanks for updating this Andrea! Tested-by: Matthew R. Ochs <mochs(a)nvidia.com>

1 0

[PATCH] NEWS: Document crasher fix in crash in qemuDomainCheckCPU
by Jiri Denemark 27 Feb '25

27 Feb '25

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ee4eac183e..cf16d894f6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -85,6 +85,13 @@ v11.1.0 (unreleased) adds corresponding devices into a per-domain profile so that AppArmor does not deny QEMU access to them. + * qemu: Fix crash when starting a domain on a host with unknown host CPU + + On hosts where we cannot detect a host CPU model (mostly aarch64 hosts) + starting a domain with a custom CPU model caused a crash of virtqemud. + + The bug was introduced in libvirt-10.9.0 + v11.0.0 (2025-01-15) ==================== -- 2.48.1

2 2

[PATCH 0/2] tests: Add capabilities for QEMU 10.0 on aarch64
by Andrea Bolognani 27 Feb '25

27 Feb '25

Andrea Bolognani (2): tests: Use collie instead of borzoi for aarch64 tests tests: Add capabilities for QEMU 10.0 (unreleased) on aarch64 .../qemu_10.0.0-virt.aarch64.xml | 238 + tests/domaincapsdata/qemu_10.0.0.aarch64.xml | 238 + .../caps_10.0.0_aarch64.replies | 37374 ++++++++++++++++ .../caps_10.0.0_aarch64.xml | 552 + ...arch64-cpu-passthrough.aarch64-latest.args | 5 +- .../aarch64-kvm-32-on-64.aarch64-latest.args | 5 +- .../aarch64-noacpi-acpi.aarch64-latest.err | 2 +- tests/qemuxmlconfdata/aarch64-noacpi-acpi.xml | 2 +- ...usb-minimal.aarch64-latest.abi-update.args | 3 +- ...ousb-minimal.aarch64-latest.abi-update.xml | 2 +- .../aarch64-nousb-minimal.aarch64-latest.args | 3 +- .../aarch64-nousb-minimal.aarch64-latest.xml | 2 +- .../qemuxmlconfdata/aarch64-nousb-minimal.xml | 2 +- .../aarch64-virt-graphics.aarch64-latest.args | 5 +- ...h64-virt-headless-mmio.aarch64-latest.args | 5 +- .../aarch64-virt-headless.aarch64-latest.args | 5 +- .../aarch64-virt-virtio.aarch64-latest.args | 5 +- ...o-pci-manual-addresses.aarch64-latest.args | 5 +- .../arm-vexpressa9-basic.aarch64-latest.args | 1 - .../arm-vexpressa9-basic.aarch64-latest.xml | 3 - .../arm-vexpressa9-nodevs.aarch64-latest.args | 1 - .../arm-vexpressa9-nodevs.aarch64-latest.xml | 3 - .../arm-vexpressa9-virtio.aarch64-latest.args | 6 +- .../arm-vexpressa9-virtio.aarch64-latest.xml | 3 - .../disk-arm-virtio-sd.aarch64-latest.args | 1 - .../disk-arm-virtio-sd.aarch64-latest.xml | 3 - ...mware-auto-efi-aarch64.aarch64-latest.args | 5 +- ...-loader-raw.aarch64-latest.abi-update.args | 5 +- ...-efi-format-loader-raw.aarch64-latest.args | 5 +- ...i-aarch64-legacy-paths.aarch64-latest.args | 5 +- ...anual-efi-acpi-aarch64.aarch64-latest.args | 5 +- ...ual-efi-noacpi-aarch64.aarch64-latest.args | 5 +- .../pvpanic-pci-aarch64.aarch64-latest.args | 5 +- ...pci-no-address-aarch64.aarch64-latest.args | 5 +- ...default-fallback-nousb.aarch64-latest.args | 3 +- ...-default-fallback-nousb.aarch64-latest.xml | 2 +- ...ntroller-default-nousb.aarch64-latest.args | 3 +- ...ontroller-default-nousb.aarch64-latest.xml | 2 +- .../usb-controller-default-nousb.xml | 2 +- ...ault-unavailable-nousb.aarch64-latest.args | 3 +- ...fault-unavailable-nousb.aarch64-latest.xml | 2 +- .../virtio-iommu-aarch64.aarch64-latest.args | 5 +- tests/qemuxmlconftest.c | 2 +- 43 files changed, 38456 insertions(+), 82 deletions(-) create mode 100644 tests/domaincapsdata/qemu_10.0.0-virt.aarch64.xml create mode 100644 tests/domaincapsdata/qemu_10.0.0.aarch64.xml create mode 100644 tests/qemucapabilitiesdata/caps_10.0.0_aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml -- 2.48.1

1 3

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 27 Feb '25

27 Feb '25

There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7984f358f3..ee4eac183e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -72,6 +72,19 @@ v11.1.0 (unreleased) * **Bug fixes** + * tools: ssh-proxy: Check if domain is running before connecting to it + + If domain is not running but has a static CID configured for its VSOCK then + the ssh-proxy parsed it anyways. This may have resulted in mistakenly + connecting to a different domain. Domain status is checked before parsing + its CID. + + * apparmor: Allow SGX if configured + + If domain has ``<memory model='sgx-epc'\>`` configured then libvirt now + adds corresponding devices into a per-domain profile so that AppArmor does + not deny QEMU access to them. + v11.0.0 (2025-01-15) ==================== -- 2.45.3

2 1

[libvirt PATCH] qemu: snapshot: error out early when reverting snapshot for VM with non-file disk
by Pavel Hrdina 27 Feb '25

27 Feb '25

Before this patch the code would start the revert process by destroying the VM and preparing to revert where it would fail with following error: error: unsupported configuration: source for disk 'sdb' is not a regular file; refusing to generate external snapshot name and leaving user with offline VM even if it was running. Make the check before we start the revert process to not destroy VMs. Resolves: https://issues.redhat.com/browse/RHEL-30971 Resolves: https://issues.redhat.com/browse/RHEL-79928 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_snapshot.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index f7d6272907..c5f70f5b10 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2205,6 +2205,8 @@ qemuSnapshotRevertValidate(virDomainObj *vm, virDomainSnapshotDef *snapdef, unsigned int flags) { + size_t i; + if (!vm->persistent && snapdef->state != VIR_DOMAIN_SNAPSHOT_RUNNING && snapdef->state != VIR_DOMAIN_SNAPSHOT_PAUSED && @@ -2232,6 +2234,17 @@ qemuSnapshotRevertValidate(virDomainObj *vm, } } + for (i = 0; i < snap->def->dom->ndisks; i++) { + virDomainDiskDef *disk = snap->def->dom->disks[i]; + + if (disk->src->type != VIR_STORAGE_TYPE_FILE) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("source disk for '%1$s' is not a regural file, reverting to snapshot is not supported"), + disk->dst); + return -1; + } + } + return 0; } -- 2.48.1

2 3

Entering freeze for libvirt-11.1.0
by Jiri Denemark 27 Feb '25

27 Feb '25

I have just tagged v11.1.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH v3 0/1] add RAPL feature in libvirt
by Anthony Harivel 27 Feb '25

27 Feb '25

Hi, Since Fedora 41, RAPL feature in QEMU is available. The tested version with this patch is: qemu-9.1.2-2.fc41. Incorporating this feature into libvirt would significantly streamline the process of testing, adopting, and further developing it, thereby enhancing overall productivity and user experience. Thank you for your consideration. Anthony Anthony Harivel (1): qemu: Add support for RAPL MSRs feature docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c | 18 ++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10 ++++++++++ src/qemu/qemu_command.c | 12 ++++++++++++ tests/qemuxmlconfdata/kvm-features-off.xml | 1 + .../kvm-features.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/kvm-features.xml | 1 + 8 files changed, 47 insertions(+), 1 deletion(-) -- 2.48.1

2 5

[RFC 0/4] meson: Enable -Wundef
by Andrea Bolognani 27 Feb '25

27 Feb '25

A few days ago I have posted a patch[1] that addresses an issue introduced when a meson check was dropped but some uses of the corresponding WITH_ macro were not removed at the same time. That got me thinking about what we can do to prevent such scenarios from happening again in the future. I have come up with something that I think would be effective, but since applying the approach throughout the entire codebase would require a non-trivial amount of work, I figured I'd ask for feedback before embarking on it. The idea is that there are two types of macros we can use for conditional compilation: external ones, coming from the OS or other libraries, and internal ones, which are the result of meson tests. The external ones (e.g. SIOCSIFFLAGS, __APPLE__) are usually only defined if they apply, so it is correct to check for their presence with #ifdef. Using #if will also work, as undefined macros evaluate to zero, but it's not good practice to use them that way. If -Wundef has been passed to the compiler, those incorrect uses will be reported (only on platforms where they are not defined, of course). The internal ones (e.g. WITH_QEMU, WITH_STRUCT_IFREQ) are similar, but in this case we control their definition. This means that using means that the feature is not available on the machine we're building on, but it could also mean that we've removed the meson check and forgot to update all users of the macro. In this case, -Wundef would work 100% reliably to detect the issue: if the meson check doesn't exist, neither will the macro, regardless of what platform we're building on. So the approach I'm suggesting is to use a syntax-check rule to ensure that internal macros are only ever checked with #if instead of Of course this requires a full sweep to fix all cases in which we're not already doing things according to the proposal. Should be fairly easy, if annoying. A couple of examples are included here for demonstration purposes. The bigger impact is going to be on the build system. Right now we generally only define WITH_ macros if the check passed, but that will have to change and the result is going to be quite a bit of additional meson code I'm afraid. Thoughts? [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/SKJ… Andrea Bolognani (4): configmake: Check for WIN32 correctly meson: Always define WITH_*_DECL macros syntax-check: Ensure WITH_ macros are used correctly meson: Enable -Wundef build-aux/syntax-check.mk | 5 +++++ configmake.h.in | 2 +- meson.build | 3 +++ tests/virmockstathelpers.c | 28 ++++++++++++++-------------- 4 files changed, 23 insertions(+), 15 deletions(-) -- 2.43.2

4 8

[PATCH 00/10] qemu: Refactor typed parameter handling in qemuDomainGetGuestInfo
by Peter Krempa 26 Feb '25

26 Feb '25

Use virTypedParam list to construct the returned data. Note that this applies on top of two patch(sets) that were ACK'd upstream: [PATCH v2 0/4] Add support for getting load averages from guest agent [PATCH] qemu: Report disk bus as reported by agent in virDomainGetGuestInfo You can fetch the whole thing via: git fetch https://gitlab.com/pipo.sk/libvirt.git agent-data-refactor Peter Krempa (10): qemuDomainGetGuestInfo: Prepare for refactor to virTypedParamList qemuDomainGetGuestInfo: Convert load code to virTypedParamList virDomainInterfaceFormatParams: Convert interface code to virTypedParamList qemuAgentDiskInfoFormatParams: Convert interface code to virTypedParamList qemuAgentFSInfoFormatParams: Convert interface code to virTypedParamList qemuAgentGetTimezone: Convert to virTypedParamList qemuAgentGetOSInfo: Convert to virTypedParamList qemuAgentGetUsers: Convert to virTypedParamList qemuDomainGetGuestInfo: Convert hostname code to virTypedParamList qemuDomainGetGuestInfo: Remove temporary infrastructure src/qemu/qemu_agent.c | 52 ++------- src/qemu/qemu_agent.h | 12 +- src/qemu/qemu_driver.c | 249 ++++++++++++----------------------------- tests/qemuagenttest.c | 148 +++++++++++------------- 4 files changed, 152 insertions(+), 309 deletions(-) -- 2.48.1

2 11