May 2024 - Devel - libvirt List Archives

[PATCH v2] qemu_hotplug: Properly assign USB address to hotplugged usb-net device
by Rayhan Faizel 14 May '24

14 May '24

Previously, the network device hotplug logic would try to ensure only CCW or PCI addresses. With recent support for the usb-net model, this patch will ensure USB addresses for usb-net network devices. [Changes in v2] - Additional information in commit message - Relevant gitlab issue link (mostly already resolved but hotplugging is mentioned in one of the comments) Resolves: https://gitlab.com/libvirt/libvirt/-/issues/14 Signed-off-by: Rayhan Faizel <rayhan.faizel(a)gmail.com> --- src/qemu/qemu_hotplug.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 774962b0df..3b39941780 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1159,8 +1159,11 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver, goto cleanup; } - if (qemuDomainIsS390CCW(vm->def) && - net->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { + if (net->model == VIR_DOMAIN_NET_MODEL_USB_NET) { + if (virDomainUSBAddressEnsure(priv->usbaddrs, &net->info) < 0) + goto cleanup; + } else if (qemuDomainIsS390CCW(vm->def) && + net->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { net->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW; if (!(ccwaddrs = virDomainCCWAddressSetCreateFromDomain(vm->def))) goto cleanup; -- 2.34.1

2 2

[PATCH 0/2] ci: Finish dropping AlmaLinux 8
by Michal Privoznik 14 May '24

14 May '24

I've switched our CI jobs from AlmaLinux 8 to AlmaLinux 9, but apparently forgot about two. Michal Prívozník (2): gitlab-ci: Switch potfile job to AlmaLinux 9 gitlab-ci: Switch coverity job to AlmaLinux 9 .gitlab-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.43.2

2 3

[PATCH v2 00/10] Big CI update (and some bug fixes)
by Michal Privoznik 14 May '24

14 May '24

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/MMEN… diff to v1: - Juggled some patches around, namely: squashed Fedora and AlmaLinux drop & reintroduction patches, reordered some for easier review. - Switched website job to AlmaLinux 9 - Enhanced commit message on the last commit to explain seemingly unrelated changes. Example of green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1281843566 Michal Prívozník (10): domaincapsmock: Drop link time dependency on virQEMUCapsGet() qemuxml2argvmock: Drop link time dependency on qemuFDPassDirectNew() testutilsqemu: Don't leak struct testQemuArgs::vdpafds security: Fix return types of .probe callbacks meson: Disable -fsanitize=function ci: Switch from AlmaLinux 8 to AlmaLinux 9 ci: Switch from Fedora 38 to Fedora 40 ci: Drop Ubuntu 20.04 meson: Bump glib version to 2.58.0 ci: Introduce Ubuntu 24.04 .gitlab-ci.yml | 6 +- .../{almalinux-8.sh => almalinux-9.sh} | 8 +- ci/buildenv/centos-stream-9.sh | 1 + ci/buildenv/debian-12-cross-aarch64.sh | 1 + ci/buildenv/debian-12-cross-armv6l.sh | 1 + ci/buildenv/debian-12-cross-armv7l.sh | 1 + ci/buildenv/debian-12-cross-i686.sh | 1 + ci/buildenv/debian-12-cross-mips64el.sh | 1 + ci/buildenv/debian-12-cross-mipsel.sh | 1 + ci/buildenv/debian-12-cross-ppc64le.sh | 1 + ci/buildenv/debian-12-cross-s390x.sh | 1 + ci/buildenv/debian-12.sh | 1 + ci/buildenv/debian-sid-cross-aarch64.sh | 1 + ci/buildenv/debian-sid-cross-armv6l.sh | 1 + ci/buildenv/debian-sid-cross-armv7l.sh | 1 + ci/buildenv/debian-sid-cross-i686.sh | 1 + ci/buildenv/debian-sid-cross-mips64el.sh | 1 + ci/buildenv/debian-sid-cross-ppc64le.sh | 1 + ci/buildenv/debian-sid-cross-s390x.sh | 1 + ci/buildenv/debian-sid.sh | 1 + ci/buildenv/fedora-39.sh | 1 + ...-mingw32.sh => fedora-40-cross-mingw32.sh} | 1 + ...-mingw64.sh => fedora-40-cross-mingw64.sh} | 1 + ci/buildenv/{fedora-38.sh => fedora-40.sh} | 1 + ci/buildenv/fedora-rawhide-cross-mingw32.sh | 1 + ci/buildenv/fedora-rawhide-cross-mingw64.sh | 1 + ci/buildenv/fedora-rawhide.sh | 1 + .../{ubuntu-2004.sh => ubuntu-2404.sh} | 8 +- ...ux-8.Dockerfile => almalinux-9.Dockerfile} | 10 +- ci/containers/centos-stream-9.Dockerfile | 1 + .../debian-12-cross-aarch64.Dockerfile | 1 + .../debian-12-cross-armv6l.Dockerfile | 1 + .../debian-12-cross-armv7l.Dockerfile | 1 + ci/containers/debian-12-cross-i686.Dockerfile | 1 + .../debian-12-cross-mips64el.Dockerfile | 1 + .../debian-12-cross-mipsel.Dockerfile | 1 + .../debian-12-cross-ppc64le.Dockerfile | 1 + .../debian-12-cross-s390x.Dockerfile | 1 + ci/containers/debian-12.Dockerfile | 1 + .../debian-sid-cross-aarch64.Dockerfile | 1 + .../debian-sid-cross-armv6l.Dockerfile | 1 + .../debian-sid-cross-armv7l.Dockerfile | 1 + .../debian-sid-cross-i686.Dockerfile | 1 + .../debian-sid-cross-mips64el.Dockerfile | 1 + .../debian-sid-cross-ppc64le.Dockerfile | 1 + .../debian-sid-cross-s390x.Dockerfile | 1 + ci/containers/debian-sid.Dockerfile | 1 + ci/containers/fedora-39.Dockerfile | 1 + ...ile => fedora-40-cross-mingw32.Dockerfile} | 3 +- ...ile => fedora-40-cross-mingw64.Dockerfile} | 3 +- ...ora-38.Dockerfile => fedora-40.Dockerfile} | 3 +- .../fedora-rawhide-cross-mingw32.Dockerfile | 1 + .../fedora-rawhide-cross-mingw64.Dockerfile | 1 + ci/containers/fedora-rawhide.Dockerfile | 1 + ...2004.Dockerfile => ubuntu-2404.Dockerfile} | 11 +- ci/gitlab/builds.yml | 113 ++++++++-------- ci/gitlab/containers.yml | 54 ++++---- ci/integration.yml | 24 ---- ci/lcitool/projects/libvirt.yml | 1 + ci/manifest.yml | 40 +++--- meson.build | 15 ++- src/libvirt_private.syms | 1 - src/security/security_apparmor.c | 2 +- src/security/security_selinux.c | 2 +- src/util/glibcompat.c | 125 ------------------ src/util/glibcompat.h | 10 -- tests/domaincapsmock.c | 13 +- tests/qemuxml2argvmock.c | 8 +- tests/testutilsqemu.c | 1 + 69 files changed, 203 insertions(+), 305 deletions(-) rename ci/buildenv/{almalinux-8.sh => almalinux-9.sh} (93%) rename ci/buildenv/{fedora-38-cross-mingw32.sh => fedora-40-cross-mingw32.sh} (98%) rename ci/buildenv/{fedora-38-cross-mingw64.sh => fedora-40-cross-mingw64.sh} (98%) rename ci/buildenv/{fedora-38.sh => fedora-40.sh} (99%) rename ci/buildenv/{ubuntu-2004.sh => ubuntu-2404.sh} (94%) rename ci/containers/{almalinux-8.Dockerfile => almalinux-9.Dockerfile} (91%) rename ci/containers/{fedora-38-cross-mingw32.Dockerfile => fedora-40-cross-mingw32.Dockerfile} (97%) rename ci/containers/{fedora-38-cross-mingw64.Dockerfile => fedora-40-cross-mingw64.Dockerfile} (97%) rename ci/containers/{fedora-38.Dockerfile => fedora-40.Dockerfile} (97%) rename ci/containers/{ubuntu-2004.Dockerfile => ubuntu-2404.Dockerfile} (93%) -- 2.43.2

2 11

[PATCH] docs: mention migrate-setmaxdowntime's impact on snapshot-create
by Abhiram Tilak 13 May '24

13 May '24

The migrate-setmaxdowntime command sets the max allowed downtime during live-migration, but since `snapshot-create` performs qmp migration, it also affects the downtime during internal/external snapshot creation. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/593 Signed-off-by: Abhiram Tilak <atp.exp(a)gmail.com> --- This issue was a minor change, yet it has remained without any updates for some time. docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index fa038e4547..18bdae53c9 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -3717,7 +3717,8 @@ migrate-setmaxdowntime Set maximum tolerable downtime for a domain which is being live-migrated to another host. The *downtime* is a number of milliseconds the guest is allowed -to be down at the end of live migration. +to be down at the end of live migration. This is also used to set the max +downtime for creating a snapshot using ``snapshot-create``. migrate-setspeed -- 2.44.0

3 2

[PATCH] "docs: formatsnapshot: add docs for snapshotDeleteInProgress"
by Abhiram Tilak 13 May '24

13 May '24

Adds documentation for the <snapshotDeleteInProgress/> element to the libvirt snapshot format XML reference. The <snapshotDeleteInProgress/> element, introduced at commit 565bcb5d79, ensures the consistency of qcow2 images during snapshot deletion operations by marking disks in snapshot metadata as invalid until deletion is successfully completed. The commit was merged but the related documentation was missing. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/609 Signed-off-by: Abhiram Tilak <atp.exp(a)gmail.com> --- docs/formatsnapshot.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/formatsnapshot.rst b/docs/formatsnapshot.rst index 570a988442..e3d0d47e00 100644 --- a/docs/formatsnapshot.rst +++ b/docs/formatsnapshot.rst @@ -170,6 +170,13 @@ The top-level ``domainsnapshot`` element may contain the following elements: sub-element can be used with same semantics as the identically named subelement of the domain definition disk's driver. + ``snapshotDeleteInProgress`` + + If a the snapshot is marked for deletion, the disk is invalidated. The + sub-element ``snapshotDeleteInProgress`` marks the disk in the snapshot + as invalid until the snapshot delete is completed successfully. + :since:`Since 9.0` + ``creationTime`` A readonly representation of the time this snapshot was created. The time is -- 2.44.0

3 2

[PATCH] vmx: Do not require DVS Port ID
by Martin Kletzander 13 May '24

13 May '24

It can be safely removed from the VMX, VMWare will still boot the machine and once another ethernet is added it is updated in the VMX to zero. So do not require it and default to zero too since this part of the XML is done as best effort and it is mentioned even in our documentation. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/vmx/vmx.c | 2 +- tests/vmx2xmldata/ethernet-vds-no-portid.vmx | 10 ++++++++ tests/vmx2xmldata/ethernet-vds-no-portid.xml | 24 ++++++++++++++++++++ 3 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 tests/vmx2xmldata/ethernet-vds-no-portid.vmx create mode 100644 tests/vmx2xmldata/ethernet-vds-no-portid.xml diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index f4182bc5184c..d90b41d2ad14 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2901,7 +2901,7 @@ virVMXParseEthernet(virConf *conf, int controller, virDomainNetDef **def) portId_name, &(*def)->data.vds.port_id, 0, - false) < 0 || + true) < 0 || virVMXGetConfigLong(conf, connectionId_name, &(*def)->data.vds.connection_id, diff --git a/tests/vmx2xmldata/ethernet-vds-no-portid.vmx b/tests/vmx2xmldata/ethernet-vds-no-portid.vmx new file mode 100644 index 000000000000..7761accb3abc --- /dev/null +++ b/tests/vmx2xmldata/ethernet-vds-no-portid.vmx @@ -0,0 +1,10 @@ +config.version = "8" +virtualHW.version = "4" +ethernet0.present = "true" +ethernet0.virtualDev = "e1000e" +ethernet0.addressType = "vpx" +ethernet0.generatedAddress = "00:50:56:87:65:43" +ethernet0.dvs.switchId = "50 34 26 b2 94 e9 3b 16-1d 68 87 bf ff 4a 54 40" +ethernet0.dvs.portgroupId = "dvportgroup-1285" +ethernet0.dvs.connectionId = "408217997" +displayName = "test" diff --git a/tests/vmx2xmldata/ethernet-vds-no-portid.xml b/tests/vmx2xmldata/ethernet-vds-no-portid.xml new file mode 100644 index 000000000000..60fd9c99feb9 --- /dev/null +++ b/tests/vmx2xmldata/ethernet-vds-no-portid.xml @@ -0,0 +1,24 @@ +<domain type='vmware'> + <name>test</name> + <uuid>00000000-0000-0000-0000-000000000000</uuid> + <memory unit='KiB'>32768</memory> + <currentMemory unit='KiB'>32768</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686'>hvm</type> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <interface type='vds'> + <mac address='00:50:56:87:65:43' type='generated'/> + <source switchid='503426b2-94e9-3b16-1d68-87bfff4a5440' portid='0' portgroupid='dvportgroup-1285' connectionid='408217997'/> + <model type='e1000e'/> + </interface> + <video> + <model type='vmvga' vram='4096' primary='yes'/> + </video> + </devices> +</domain> -- 2.45.0

2 1

[PATCH] qemu_hotplug: Properly assign USB address to hotplugged usb-net device
by Rayhan Faizel 13 May '24

13 May '24

Signed-off-by: Rayhan Faizel <rayhan.faizel(a)gmail.com> --- src/qemu/qemu_hotplug.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 774962b0df..3b39941780 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1159,8 +1159,11 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver, goto cleanup; } - if (qemuDomainIsS390CCW(vm->def) && - net->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { + if (net->model == VIR_DOMAIN_NET_MODEL_USB_NET) { + if (virDomainUSBAddressEnsure(priv->usbaddrs, &net->info) < 0) + goto cleanup; + } else if (qemuDomainIsS390CCW(vm->def) && + net->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) { net->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW; if (!(ccwaddrs = virDomainCCWAddressSetCreateFromDomain(vm->def))) goto cleanup; -- 2.34.1

2 1

[PATCH] NEWS: Announce virtio sound model support
by Rayhan Faizel 13 May '24

13 May '24

Signed-off-by: Rayhan Faizel <rayhan.faizel(a)gmail.com> --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d72c15bf10..a0e82fcc02 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,6 +22,12 @@ v10.4.0 (unreleased) It is now possible to set on/off ``ras`` feature in the domain XML for virt (Arm) machine type as ``<ras state='on'/>``. + * qemu: Support for ``virtio`` sound model + + Sound devices can now be configured to use the virtio model with + ``<sound model='virtio'/>``. This model is available from QEMU 8.2.0 + onwards. + * **Improvements** * **Bug fixes** -- 2.34.1

2 1

[libvirt PATCH] qemu_capabilities: Remove unused struct
by Ján Tomko 13 May '24

13 May '24

From: "Dr. David Alan Gilbert" <dave(a)treblig.org> 'virQEMUCapsSearchData' has been unused since commit bc33b8c63911 ("qemu: capabilities: Drop the virQEMUCapsCacheLookupByArch function") Remove it. Signed-off-by: Dr. David Alan Gilbert <dave(a)treblig.org> Reviewed-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed. src/qemu/qemu_capabilities.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 45525db803..28c20a9555 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -801,12 +801,6 @@ struct _virQEMUCaps { virQEMUCapsAccel tcg; }; -struct virQEMUCapsSearchData { - virArch arch; - const char *binaryFilter; -}; - - static virClass *virQEMUCapsClass; static void virQEMUCapsDispose(void *obj); -- 2.45.0

1 0

[PATCH v3 0/3] Introduce SSH proxy
by Michal Privoznik 10 May '24

10 May '24

v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EXJP… diff to v2: - New naming scheme: user@qemu:system/VM and user@qemu:session/VM for choosing explicit connection URI for fetching VM. Old user@qemu/VM is kept for convenience. Michal Prívozník (3): tools: Introduce SSH proxy docs: Document SSH proxy NEWS: Document SSH proxy feature NEWS.rst | 5 + docs/docs.rst | 3 + docs/meson.build | 1 + docs/nss.rst | 7 + docs/ssh-proxy.rst | 85 ++++++ libvirt.spec.in | 33 +++ meson.build | 16 +- meson_options.txt | 2 + po/POTFILES | 1 + tools/meson.build | 2 + tools/ssh-proxy/30-libvirt-ssh-proxy.conf.in | 6 + tools/ssh-proxy/meson.build | 25 ++ tools/ssh-proxy/ssh-proxy.c | 296 +++++++++++++++++++ 13 files changed, 481 insertions(+), 1 deletion(-) create mode 100644 docs/ssh-proxy.rst create mode 100644 tools/ssh-proxy/30-libvirt-ssh-proxy.conf.in create mode 100644 tools/ssh-proxy/meson.build create mode 100644 tools/ssh-proxy/ssh-proxy.c -- 2.43.2

2 6