May 2024 - Devel - libvirt List Archives

[libvirt PATCH] qemu_capabilities: Remove unused struct
by Ján Tomko 13 May '24

13 May '24

From: "Dr. David Alan Gilbert" <dave(a)treblig.org> 'virQEMUCapsSearchData' has been unused since commit bc33b8c63911 ("qemu: capabilities: Drop the virQEMUCapsCacheLookupByArch function") Remove it. Signed-off-by: Dr. David Alan Gilbert <dave(a)treblig.org> Reviewed-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed. src/qemu/qemu_capabilities.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 45525db803..28c20a9555 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -801,12 +801,6 @@ struct _virQEMUCaps { virQEMUCapsAccel tcg; }; -struct virQEMUCapsSearchData { - virArch arch; - const char *binaryFilter; -}; - - static virClass *virQEMUCapsClass; static void virQEMUCapsDispose(void *obj); -- 2.45.0

1 0

[PATCH v3 0/3] Introduce SSH proxy
by Michal Privoznik 10 May '24

10 May '24

v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EXJP… diff to v2: - New naming scheme: user@qemu:system/VM and user@qemu:session/VM for choosing explicit connection URI for fetching VM. Old user@qemu/VM is kept for convenience. Michal Prívozník (3): tools: Introduce SSH proxy docs: Document SSH proxy NEWS: Document SSH proxy feature NEWS.rst | 5 + docs/docs.rst | 3 + docs/meson.build | 1 + docs/nss.rst | 7 + docs/ssh-proxy.rst | 85 ++++++ libvirt.spec.in | 33 +++ meson.build | 16 +- meson_options.txt | 2 + po/POTFILES | 1 + tools/meson.build | 2 + tools/ssh-proxy/30-libvirt-ssh-proxy.conf.in | 6 + tools/ssh-proxy/meson.build | 25 ++ tools/ssh-proxy/ssh-proxy.c | 296 +++++++++++++++++++ 13 files changed, 481 insertions(+), 1 deletion(-) create mode 100644 docs/ssh-proxy.rst create mode 100644 tools/ssh-proxy/30-libvirt-ssh-proxy.conf.in create mode 100644 tools/ssh-proxy/meson.build create mode 100644 tools/ssh-proxy/ssh-proxy.c -- 2.43.2

2 6

Test mail
by Peter Krempa 10 May '24

10 May '24

Testing messages posted via web.

1 0

[PATCH] docs: Add nanoseconds units for vcpu.delay doc
by Assaf Admi 10 May '24

10 May '24

Submitted https://gitlab.com/libvirt/libvirt/-/merge_requests/352: Add nanoseconds units for vcpu.delay doc, as it's based on /proc/<pid>/task/<tid>/schedstat, according to https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_driver.c#L12…. schedstat is in nanoseconds units, according to https://docs.kernel.org/scheduler/sched-stats.html#proc-pid-schedstat.

2 1

[PATCH] network: Register dnsmasq with resolved only when really requested
by Jiri Denemark 09 May '24

09 May '24

An incorrect check for domainRegister caused the DNS server for a virtual domain to be registered with systemd-resolved even if register='no' attribute was present. Only omitting the attribute completely would disable the registration. Reported-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/network/bridge_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index d89700c6ee..e5f9ecf9e8 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2016,7 +2016,9 @@ networkStartNetworkVirtual(virNetworkDriverState *driver, dnsmasqStarted = true; - if (def->domain && def->domainRegister && dnsServer) { + if (def->domain && + def->domainRegister == VIR_TRISTATE_BOOL_YES && + dnsServer) { unsigned int link; int rc; -- 2.45.0

2 1

[PATCH] qemuxmlconftest: Test 'page_per_vq' config option for 'vhostuser' backed disk
by Peter Krempa 09 May '24

09 May '24

Add a missing option for the test to prove that we parse/format this option. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Added to see whether the claim in https://gitlab.com/libvirt/libvirt/-/issues/627 is true as I was fairly certain that virtio options are parsed commonly and thus this should 'Just work'. tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.args | 2 +- tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.xml | 2 +- tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.xml | 2 +- tests/qemuxmlconfdata/disk-vhostuser-numa.xml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.args b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.args index 7522be4582..2f52151245 100644 --- a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.args +++ b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.args @@ -32,7 +32,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -chardev socket,id=chr-vu-virtio-disk0,path=/tmp/vhost1.sock \ -device vhost-user-blk-pci,bus=pci.0,addr=0x2,chardev=chr-vu-virtio-disk0,id=virtio-disk0,bootindex=1 \ -chardev socket,id=chr-vu-virtio-disk1,path=/tmp/vhost1.sock,reconnect=10 \ --device vhost-user-blk-pci,iommu_platform=on,ats=on,packed=on,bus=pci.0,addr=0x3,chardev=chr-vu-virtio-disk1,id=virtio-disk1 \ +-device vhost-user-blk-pci,iommu_platform=on,ats=on,packed=on,page-per-vq=on,bus=pci.0,addr=0x3,chardev=chr-vu-virtio-disk1,id=virtio-disk1 \ -audiodev '{"id":"audio1","driver":"none"}' \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x4 \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ diff --git a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.xml b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.xml index f1825f3a8d..d020923bc7 100644 --- a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.xml +++ b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-4.2.0.xml @@ -27,7 +27,7 @@ <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </disk> <disk type='vhostuser' device='disk' snapshot='no'> - <driver name='qemu' type='raw' iommu='on' ats='on' packed='on'/> + <driver name='qemu' type='raw' iommu='on' ats='on' packed='on' page_per_vq='on'/> <source type='unix' path='/tmp/vhost1.sock'> <reconnect enabled='yes' timeout='10'/> </source> diff --git a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.args b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.args index cbe9f9ef48..48bb792206 100644 --- a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.args +++ b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.args @@ -31,7 +31,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -chardev socket,id=chr-vu-virtio-disk0,path=/tmp/vhost1.sock \ -device '{"driver":"vhost-user-blk-pci","bus":"pci.0","addr":"0x2","chardev":"chr-vu-virtio-disk0","id":"virtio-disk0","bootindex":1}' \ -chardev socket,id=chr-vu-virtio-disk1,path=/tmp/vhost1.sock,reconnect=10 \ --device '{"driver":"vhost-user-blk-pci","iommu_platform":true,"ats":true,"packed":true,"bus":"pci.0","addr":"0x3","chardev":"chr-vu-virtio-disk1","id":"virtio-disk1"}' \ +-device '{"driver":"vhost-user-blk-pci","iommu_platform":true,"ats":true,"packed":true,"page-per-vq":true,"bus":"pci.0","addr":"0x3","chardev":"chr-vu-virtio-disk1","id":"virtio-disk1"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ -device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","addr":"0x4"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ diff --git a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.xml b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.xml index 0a2e40f496..9b62de174a 100644 --- a/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/disk-vhostuser-numa.x86_64-latest.xml @@ -27,7 +27,7 @@ <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </disk> <disk type='vhostuser' device='disk' snapshot='no'> - <driver name='qemu' type='raw' iommu='on' ats='on' packed='on'/> + <driver name='qemu' type='raw' iommu='on' ats='on' packed='on' page_per_vq='on'/> <source type='unix' path='/tmp/vhost1.sock'> <reconnect enabled='yes' timeout='10'/> </source> diff --git a/tests/qemuxmlconfdata/disk-vhostuser-numa.xml b/tests/qemuxmlconfdata/disk-vhostuser-numa.xml index 49efbae0a2..2b72bac4a3 100644 --- a/tests/qemuxmlconfdata/disk-vhostuser-numa.xml +++ b/tests/qemuxmlconfdata/disk-vhostuser-numa.xml @@ -22,7 +22,7 @@ <boot order='1'/> </disk> <disk type='vhostuser' device='disk'> - <driver name='qemu' type='raw' iommu='on' ats='on' packed='on'/> + <driver name='qemu' type='raw' iommu='on' ats='on' packed='on' page_per_vq='on'/> <source type='unix' path='/tmp/vhost1.sock'> <reconnect enabled='yes' timeout='10'/> </source> -- 2.44.0

2 1

[PATCH v2] docs: ensure HTML/images are built before running reference tests
by Daniel P. Berrangé 09 May '24

09 May '24

The 'check-html-references' test will process the built HTML files, so they must exist before it is run, along with any images that they point to. If using the older 'configure_file' command, no changes are needed since that always gets executed at 'meson setup' time, rather than at 'meson compile' time. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/images/meson.build | 3 ++- docs/logos/meson.build | 3 ++- docs/meson.build | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) This is the only remaining unpushed patch from my previous v1 series, now I figured out how to make it compatible with old meson (see last sentence in the commit message) diff --git a/docs/images/meson.build b/docs/images/meson.build index b9ab30fc91..f3e3dd50da 100644 --- a/docs/images/meson.build +++ b/docs/images/meson.build @@ -18,7 +18,8 @@ foreach file : docs_image_files # This hack enables us to view the web pages # from within the uninstalled build tree if meson.version().version_compare('>=0.64.0') - fs.copyfile(file) + imgfile = fs.copyfile(file) + install_web_deps += imgfile else configure_file(input: file, output: file, copy: true) endif diff --git a/docs/logos/meson.build b/docs/logos/meson.build index c3f4c9f522..2d9d0fcbb0 100644 --- a/docs/logos/meson.build +++ b/docs/logos/meson.build @@ -26,7 +26,8 @@ foreach file : docs_logo_files # This hack enables us to view the web pages # from within the uninstalled build tree if meson.version().version_compare('>=0.64.0') - fs.copyfile(file) + logofile = fs.copyfile(file) + install_web_deps += logofile else configure_file(input: file, output: file, copy: true) endif diff --git a/docs/meson.build b/docs/meson.build index 87d728213c..2dfe98ef62 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -360,6 +360,7 @@ if tests_enabled[0] '--webroot', meson.project_build_root() / 'docs' ], + depends: install_web_deps, env: runutf8, suite: 'script' ) -- 2.43.0

2 1

[PATCH v2 0/3] Introduce SSH proxy
by Michal Privoznik 08 May '24

08 May '24

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QYFH… diff to v1: - rebased onto current master - Worked in Dan's review Michal Prívozník (3): tools: Introduce SSH proxy docs: Document SSH proxy NEWS: Document SSH proxy feature NEWS.rst | 5 + docs/docs.rst | 3 + docs/meson.build | 1 + docs/nss.rst | 7 + docs/ssh-proxy.rst | 68 ++++++ libvirt.spec.in | 33 +++ meson.build | 16 +- meson_options.txt | 2 + po/POTFILES | 1 + tools/meson.build | 2 + tools/ssh-proxy/30-libvirt-ssh-proxy.conf.in | 6 + tools/ssh-proxy/meson.build | 25 ++ tools/ssh-proxy/ssh-proxy.c | 239 +++++++++++++++++++ 13 files changed, 407 insertions(+), 1 deletion(-) create mode 100644 docs/ssh-proxy.rst create mode 100644 tools/ssh-proxy/30-libvirt-ssh-proxy.conf.in create mode 100644 tools/ssh-proxy/meson.build create mode 100644 tools/ssh-proxy/ssh-proxy.c -- 2.43.2

2 4

[PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead
by Thomas Huth 08 May '24

08 May '24

The old "-runas" option has the disadvantage that it is not visible in the QAPI schema, so it is not available via the normal introspection mechanisms. We've recently introduced the "-run-with" option for exactly this purpose, which is meant to handle the options that affect the runtime behavior. Thus let's introduce a "user=..." parameter here now and deprecate the old "-runas" option. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- v2: Add missing part in qemu-options.hx as suggested by Philippe docs/about/deprecated.rst | 6 ++++++ system/vl.c | 15 +++++++++++++++ qemu-options.hx | 15 +++++++++++---- 3 files changed, 32 insertions(+), 4 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 3310df3274..fe69e2d44c 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -61,6 +61,12 @@ configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is marked deprecated since 9.0, users have to ensure that all the topology members described with -smp are supported by the target machine. +``-runas`` (since 9.1) +---------------------- + +Use ``-run-with user=..`` instead. + + User-mode emulator command line arguments ----------------------------------------- diff --git a/system/vl.c b/system/vl.c index 7756eac81e..b031427440 100644 --- a/system/vl.c +++ b/system/vl.c @@ -773,6 +773,10 @@ static QemuOptsList qemu_run_with_opts = { .name = "chroot", .type = QEMU_OPT_STRING, }, + { + .name = "user", + .type = QEMU_OPT_STRING, + }, { /* end of list */ } }, }; @@ -3586,6 +3590,7 @@ void qemu_init(int argc, char **argv) break; #if defined(CONFIG_POSIX) case QEMU_OPTION_runas: + warn_report("-runas is deprecated, use '-run-with user=...' instead"); if (!os_set_runas(optarg)) { error_report("User \"%s\" doesn't exist" " (and is not <uid>:<gid>)", @@ -3612,6 +3617,16 @@ void qemu_init(int argc, char **argv) if (str) { os_set_chroot(str); } + str = qemu_opt_get(opts, "user"); + if (str) { + if (!os_set_runas(str)) { + error_report("User \"%s\" doesn't exist" + " (and is not <uid>:<gid>)", + optarg); + exit(1); + } + } + break; } #endif /* CONFIG_POSIX */ diff --git a/qemu-options.hx b/qemu-options.hx index cf61f6b863..3031479a15 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4824,7 +4824,8 @@ DEF("runas", HAS_ARG, QEMU_OPTION_runas, \ SRST ``-runas user`` Immediately before starting guest execution, drop root privileges, - switching to the specified user. + switching to the specified user. This option is deprecated, use + ``-run-with user=...`` instead. ERST DEF("prom-env", HAS_ARG, QEMU_OPTION_prom_env, @@ -4990,13 +4991,15 @@ DEF("qtest-log", HAS_ARG, QEMU_OPTION_qtest_log, "", QEMU_ARCH_ALL) #ifdef CONFIG_POSIX DEF("run-with", HAS_ARG, QEMU_OPTION_run_with, - "-run-with [async-teardown=on|off][,chroot=dir]\n" + "-run-with [async-teardown=on|off][,chroot=dir][user=username|uid:gid]\n" " Set miscellaneous QEMU process lifecycle options:\n" " async-teardown=on enables asynchronous teardown (Linux only)\n" - " chroot=dir chroot to dir just before starting the VM\n", + " chroot=dir chroot to dir just before starting the VM\n" + " user=username switch to the specified user before starting the VM\n" + " user=uid:gid dito, but use specified user-ID and group-ID instead\n", QEMU_ARCH_ALL) SRST -``-run-with [async-teardown=on|off][,chroot=dir]`` +``-run-with [async-teardown=on|off][,chroot=dir][user=username|uid:gid]`` Set QEMU process lifecycle options. ``async-teardown=on`` enables asynchronous teardown. A new process called @@ -5013,6 +5016,10 @@ SRST ``chroot=dir`` can be used for doing a chroot to the specified directory immediately before starting the guest execution. This is especially useful in combination with -runas. + + ``user=username`` or ``user=uid:gid`` can be used to drop root privileges + by switching to the specified user (via username) or user and group + (via uid:gid) immediately before starting guest execution. ERST #endif -- 2.45.0

4 4

[PATCH 0/2] tests: fix very subtle bugs in 'read-big-pipe'
by Daniel P. Berrangé 08 May '24

08 May '24

Daniel P. Berrangé (2): tests: fix hang in virshtest 'read-big-pipe' case tests: fix two off-by-1 errors in read-big-pipe test tests/virshtest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.43.0

2 4