September 2023 - Devel - libvirt List Archives

[PATCH] manpage: virsh: Note that 'virsh undefine --remove-all-storage' doesn't remove backing images
by Peter Krempa 07 Sep '23

07 Sep '23

Removing a backing image could break other image chains as it's theoretically possible to share backing chains. As --storage/--remove-all-storage is fully implemented in virsh as a helper option, which enumerates and deletes VM's volumes. We do not plan to make it any more complicated. Document that backing chains are not removed. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/virsh.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 91e1d5de37..4ae3bb4d93 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4614,12 +4614,13 @@ undefined; if not all of the requested volumes could be deleted, the error message indicates what still remains behind. If a volume path is not found in the domain definition, it's treated as if the volume was successfully deleted. Only volumes managed by libvirt in storage pools can be removed this -way. +way. Note that this also removes only the top level image of a backing chain, +any backing stores of the image are kept as they may be shared. (See ``domblklist`` for list of target names associated to a domain). Example: --storage vda,/path/to/storage.img The *--remove-all-storage* flag specifies that all of the domain's storage -volumes should be deleted. +volumes should be deleted as if they were specified via *--storage*. The *--delete-storage-volume-snapshots* (previously *--delete-snapshots*) flag specifies that any snapshots associated with -- 2.41.0

2 1

[PATCH] virsh-snapshot: Avoid passing NULL to qsort() in virshSnapshotListCollect()
by Michal Privoznik 07 Sep '23

07 Sep '23

If a domain has no snapshots and 'virsh snapshot-list' is called, this gets all the way down to virshSnapshotListCollect() which then collects all snapshots (none), and passes them to qsort() which doesn't like being called with NULL: extern void qsort (void *__base, size_t __nmemb, size_t __size, __compar_fn_t __compar) __nonnull ((1, 4)); Resolves: https://gitlab.com/libvirt/libvirt/-/issues/533 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-snapshot.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index d7889a38e4..ecb935b2b4 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1310,9 +1310,11 @@ virshSnapshotListCollect(vshControl *ctl, virDomainPtr dom, } } } - if (!(orig_flags & VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL)) + if (!(orig_flags & VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL) && + snaplist->snaps) { qsort(snaplist->snaps, snaplist->nsnaps, sizeof(*snaplist->snaps), virshSnapSorter); + } snaplist->nsnaps -= deleted; ret = g_steal_pointer(&snaplist); -- 2.41.0

2 1

[PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK
by Dmitry Frolov 07 Sep '23

07 Sep '23

Reviewing the sources, I found, that in function lxcContainerMountAllFS() pointers vmDef->fss[i]->src and vmDef->fss[i]->src->path are checked for NULL after dereferencing in VIR_DEBUG() macro. Fixes: 57487085dc ("lxc: don't try to reference NULL when mounting filesystems") --- src/lxc/lxc_container.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 21220661f7..58a6695458 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1467,13 +1467,15 @@ static int lxcContainerMountAllFS(virDomainDef *vmDef, if (STREQ(vmDef->fss[i]->dst, "/")) continue; + if (!(vmDef->fss[i]->src && vmDef->fss[i]->src->path)) + return -1; + VIR_DEBUG("Mounting '%s' -> '%s'", vmDef->fss[i]->src->path, vmDef->fss[i]->dst); if (lxcContainerResolveSymlinks(vmDef->fss[i], false) < 0) return -1; - if (!(vmDef->fss[i]->src && vmDef->fss[i]->src->path && - STRPREFIX(vmDef->fss[i]->src->path, vmDef->fss[i]->dst)) && + if (!STRPREFIX(vmDef->fss[i]->src->path, vmDef->fss[i]->dst) && lxcContainerUnmountSubtree(vmDef->fss[i]->dst, false) < 0) return -1; -- 2.34.1

4 4

[PATCH Libvirt v3 00/10] Support dirty page rate upper limit
by ~hyman 07 Sep '23

07 Sep '23

Hi, This is the latest version for the series, please review. Thanks, Yong v3: - rebase on master and fix conflicts - refactor the comments and update the version tag v2: The patch set introduce a new API virDomainSetVcpuDirtyLimit to allow upper Apps to set upper limits of dirty page rate for virtual CPUs, the corresponding virsh API as follows: limit-dirty-page-rate <domain> <rate> [--vcpu <number>] \ [--config] [--live] [--current] We put the dirty limit persistent info with the "vcpus" element in domain XML and extend dirtylimit statistics for domGetStats: <domain> ... <vcpu current='2'>3</vcpu> <vcpus> <vcpu id='0' hotpluggable='no' dirty_limit='10' order='1'.../> <vcpu id='1' hotpluggable='yes' dirty_limit='10' order='2'.../> </vcpus> ... </domain> If --vcpu option is not passed in the virsh command, set all virtual CPUs; if rate is set to zero, cancel the upper limit. Examples: To set the dirty page rate upper limit 10 MB/s for all virtual CPUs in c81_node1, use: # virsh limit-dirty-page-rate c81_node1 --rate 10 --live Set dirty page rate limit 10(MB/s) for all virtual CPUs successfully # virsh dumpxml c81_node1 | grep dirty_limit <vcpu id='0' enabled='yes' hotpluggable='no' order='1' dirty_limit='10'/> <vcpu id='1' enabled='yes' hotpluggable='no' order='2' dirty_limit='10'/> <vcpu id='2' enabled='yes' hotpluggable='no' order='3' dirty_limit='10'/> <vcpu id='3' enabled='no' hotpluggable='yes' dirty_limit='10'/> <vcpu id='4' enabled='no' hotpluggable='yes' dirty_limit='10'/> ...... Query the dirty limit info dynamically: # virsh domstats c81_node1 --dirtylimit Domain: 'c81_node1' dirtylimit.vcpu.0.limit=10 dirtylimit.vcpu.0.current=0 dirtylimit.vcpu.1.limit=10 dirtylimit.vcpu.1.current=0 dirtylimit.vcpu.2.limit=10 dirtylimit.vcpu.2.current=0 dirtylimit.vcpu.3.limit=10 dirtylimit.vcpu.3.current=0 dirtylimit.vcpu.4.limit=10 dirtylimit.vcpu.4.current=0 ...... To cancel the upper limit, use: # virsh limit-dirty-page-rate c81_node1 --rate 0 --live Cancel dirty page rate limit for all virtual CPUs successfully # virsh dumpxml c81_node1 | grep dirty_limit # virsh domstats c81_node1 --dirtylimit Domain: 'c81_node1' The dirty limit uses the QEMU dirty-limit feature introduced since 7.1.0, this feature allows CPU to be throttled as needed to keep their dirty page rate within the limit. It could, in some scenes, be used to provide quality-of-service in the aspect of the memory workload for virtual CPUs and QEMU itself use the feature to implement the dirty-limit throttle algorithm and apply it on the live migration, which improve responsiveness of large guests during live migration and can result in more stable read performance. The other application scenarios remain unexplored, before that, Libvirt could provide the basic API. Hyman Huang(黄勇) (10): qemu_capabilities: Introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability conf: Introduce XML for dirty limit configuration libvirt: Add virDomainSetVcpuDirtyLimit API qemu_driver: Implement qemuDomainSetVcpuDirtyLimit domain_validate: Export virDomainDefHasDirtyLimitStartupVcpus symbol qemu_process: Setup dirty limit after launching VM virsh: Introduce limit-dirty-page-rate api qemu_monitor: Implement qemuMonitorQueryVcpuDirtyLimit qemu_driver: Extend dirtlimit statistics for domGetStats virsh: Introduce command 'virsh domstats --dirtylimit' docs/formatdomain.rst | 7 +- docs/manpages/virsh.rst | 38 +++- include/libvirt/libvirt-domain.h | 5 + src/conf/domain_conf.c | 26 +++ src/conf/domain_conf.h | 8 + src/conf/domain_validate.c | 33 ++++ src/conf/domain_validate.h | 2 + src/conf/schemas/domaincommon.rng | 5 + src/driver-hypervisor.h | 7 + src/libvirt-domain.c | 68 +++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 181 ++++++++++++++++++ src/qemu/qemu_monitor.c | 25 +++ src/qemu/qemu_monitor.h | 22 +++ src/qemu/qemu_monitor_json.c | 107 +++++++++++ src/qemu/qemu_monitor_json.h | 9 + src/qemu/qemu_process.c | 44 +++++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 18 +- src/remote_protocol-structs | 7 + .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + tools/virsh-domain-monitor.c | 7 + tools/virsh-domain.c | 109 +++++++++++ 34 files changed, 739 insertions(+), 4 deletions(-) -- 2.38.5

4 17

[libvirt PATCH v2] ch: Fix cloud-hypervisor version processing
by Praveen K Paladugu 06 Sep '23

06 Sep '23

Refactor the version processing logic in ch driver to support versions from non-release cloud-hypervisor binaries. This version also supports versions with branch prefixes in them. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> --- src/ch/ch_conf.c | 39 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index a8565d9537..a0849bfbd6 100644 --- a/src/ch/ch_conf.c +++ b/src/ch/ch_conf.c @@ -172,6 +172,33 @@ virCHDriverConfigDispose(void *obj) #define MIN_VERSION ((15 * 1000000) + (0 * 1000) + (0)) +/** + * chPreProcessVersionString - crop branch, commit info and return just the version + */ +static char * +chPreProcessVersionString(char *version) +{ + g_autofree char *new_version = version; + char *tmp_version; + + if ((tmp_version = strrchr(version, '/')) != NULL) { + new_version = tmp_version + 1; + } + + if (new_version[0] == 'v') { + new_version = new_version + 1; + } + // Duplicate the string in both cases. This would allow the calling method + // free the returned string in a consistent manner. + if ((tmp_version = strchr(new_version, '-')) != NULL) { + new_version = g_strndup(new_version, tmp_version - new_version); + } else{ + new_version = g_strdup(new_version); + } + + return g_steal_pointer(&new_version); + +} int chExtractVersion(virCHDriver *driver) { @@ -193,19 +220,25 @@ chExtractVersion(virCHDriver *driver) tmp = help; - /* expected format: cloud-hypervisor v<major>.<minor>.<micro> */ - if ((tmp = STRSKIP(tmp, "cloud-hypervisor v")) == NULL) { + /* Below are some example version formats and expected outputs: + * cloud-hypervisor v32.0.0 (expected: 32.0.0) + * cloud-hypervisor v33.0-104-ge0e3779e-dirty (expected: 33.0) + * cloud-hypervisor testing/v32.0.131-1-ga5d6db5c-dirty (expected: 32.0.131) + */ + if ((tmp = STRSKIP(tmp, "cloud-hypervisor ")) == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unexpected output of cloud-hypervisor binary")); return -1; } + tmp = chPreProcessVersionString(tmp); + VIR_DEBUG("Cloud-Hypervisor version detected: %s", tmp); + if (virStringParseVersion(&version, tmp, true) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unable to parse cloud-hypervisor version: %1$s"), tmp); return -1; } - if (version < MIN_VERSION) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Cloud-Hypervisor version is too old (v15.0 is the minimum supported version)")); -- 2.41.0

3 2

[libvirt PATCH 0/2] Add cpu model for EPYC Genoa
by Tim Wiederhake 06 Sep '23

06 Sep '23

Plus one drive-by improvement to sync_qemu_features_i386.py. Tim Wiederhake (2): cpu_map: Ignore all vmx-* features in sync_qemu_features_i386.py cpu_map: Add cpu model EPYC Genoa src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/sync_qemu_features_i386.py | 90 +------------- src/cpu_map/x86_EPYC-Genoa.xml | 115 ++++++++++++++++++ .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + 7 files changed, 121 insertions(+), 89 deletions(-) create mode 100644 src/cpu_map/x86_EPYC-Genoa.xml -- 2.39.2

2 3

[libvirt PATCH] rpm: Drop obsolete Obsoletes
by Andrea Bolognani 06 Sep '23

06 Sep '23

All platforms we target come with at least libvirt 6.0.0, so none of the Obsoletes referring to earlier versions are useful at this point. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 7 ------- 1 file changed, 7 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b471afebb1..3e68961fb9 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -250,9 +250,6 @@ Requires: libvirt-daemon-driver-lxc = %{version}-%{release} %if %{with_qemu} Requires: libvirt-daemon-driver-qemu = %{version}-%{release} %endif -# We had UML driver, but we've removed it. -Obsoletes: libvirt-daemon-driver-uml <= 5.0.0 -Obsoletes: libvirt-daemon-uml <= 5.0.0 %if %{with_vbox} Requires: libvirt-daemon-driver-vbox = %{version}-%{release} %endif @@ -608,9 +605,6 @@ Requires: util-linux # From QEMU RPMs Requires: /usr/bin/qemu-img %endif -%if !%{with_storage_rbd} -Obsoletes: libvirt-daemon-driver-storage-rbd < 5.2.0 -%endif Obsoletes: libvirt-daemon-driver-storage-sheepdog < 8.8.0 %description daemon-driver-storage-core @@ -812,7 +806,6 @@ VirtualBox Summary: Libxl driver plugin for the libvirtd daemon Requires: libvirt-daemon-common = %{version}-%{release} Requires: libvirt-libs = %{version}-%{release} -Obsoletes: libvirt-daemon-driver-xen < 4.3.0 %description daemon-driver-libxl The Libxl driver plugin for the libvirtd daemon, providing -- 2.41.0

2 6

virDomainGetJobStats not populating VIR_DOMAIN_JOB_DISK_BPS
by João Vilaça 06 Sep '23

06 Sep '23

Hello, I'm using https://gitlab.com/libvirt/libvirt-go-module and executing 'GetJobStats' to get information about the progress of a VM with a disk migration in KubeVirt. Everything works correctly and the migration is successful, with the disk correctly copied. Across multiple executions of 'GetJobStats' while copying the disk, I get the information about data: *DataTotal:151592960 DataProcessedSet:true DataProcessed:163080901 DataRemainingSet:true DataRemaining:266240* about disk total values: *DiskTotal:21037056 DiskProcessedSet:true DiskProcessed:13631488 DiskRemainingSet:true DiskRemaining:7405568* but '*DiskBpsSet:false *' and '*DiskBps:0 *' are always false and 0. Even when I run 'virsh domjobinfo', I get Data and File absolute values, but not the throughput. Is QEMU not reporting this data? Can this be a bug? -- kind regards, João Vilaça

2 1

[PATCH 00/51] Finish conversion of all test cases in qemuxml2argvtest to real capabilities
by Peter Krempa 06 Sep '23

06 Sep '23

This series converts all outstanding test cases to use real capabilities. In the process few cases of pointless tests or features which are supported by every version of qemu were identified and addressed. To simplify the bulk of the conversion I've opted to simply set the most common capabilities in DO_TEST and DO_TEST_NOCAPS in addition to what the test asked for. This is done in a handful of patches and allows then a bulk conversion of many tests with no changes in the output files. I've payed special attention to CPU tests were I've ensured that they are semantically testing what they were before. Peter Krempa (51): qemu: Always assume support for QEMU_CAPS_PIIX_DISABLE_S* and QEMU_CAPS_ICH9_DISABLE_S* qemu: capabilities: Retire QEMU_CAPS_ICH9_DISABLE_S* and QEMU_CAPS_ICH9_DISABLE_S* capabilities qemu: capabilities: Preserve location of the default machine type when stripping aliases for tests qemuxml2argvtest: Clean up host CPU if overriden qemuxml2argvtest: testAddCPUModels: Remove non-x86_64 fake cpu models qemuxml2argvtest: Drop 'monitor-json' case qemu: Always assume support for QEMU_CAPS_CPU_CACHE qemu: capabilities: Retire QEMU_CAPS_CPU_CACHE qemu: Always assume support for QEMU_CAPS_DEVICE_VFIO_PCI qemu_capabilities: Retire QEMU_CAPS_DEVICE_VFIO_PCI qemuxml2argvtest: Add missing versioned test cases for 'cpu-host-model' qemuxml2argvtest: Remove old chardev tests qemuxml2argvtest: Simplify invocation of GIC tests qemuxml2argvtest: Remove duplicated test invocations qemuxml2argvtest: Remove fake-caps invocations of tests which also real caps version qemuxml2argvtest: Use proper version in negative 'virtio-options-memballoon-freepage-reporting' case qemuxml2argvtest: Use real caps for 'cpu-host-model-fallback' test case qemuxml2argvtest: Use real caps for 'cpu-host-model-nofallback' test case qemuxml2argvtest: Remove FLAG_SKIP_LEGACY_CPUS qemuxml2argvtest: Enable JSON syntax for -device, -object, and -netdev for all fake-caps tests virQEMUCapsAddCPUDefinitions: Fill in cpu type in data and node it's used only in tests qemuxml2argvtest: Modernize negative testing for hugepages qemuxml2argvtest: Modernize 'numatune' tests testutilsqemu: Always populate default ram id, default cpu, ACPI support for fake machines qemuxml2argvtest: Enable 'seccomp' sandbox in all fake caps tests qemuxml2argvtest: Consolidate tests for usb controllers qemuxml2argvtest: Add tests for auto-added USB controllers qemuxml2argvtest: Improve default usb controller testing qemuxml2argvtest: Consolidate testing of 'xhci' controllers qemuxml2argvtest: Assume QEMU_CAPS_PIIX3_USB_UHCI for all fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_DEVICE_PCIE_ROOT_PORT for fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_CPU_MIGRATABLE and QEMU_CAPS_SMP_DIES for fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_USB_HOST_HOSTDEVICE and QEMU_CAPS_DEVICE_QEMU_XHCI for fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_QXL_VRAM64, QEMU_CAPS_(QXL|VGA)_VGAMEM for fake-caps tests qemuxml2argvtest: Properly modernize 'clock-hpet-off' test case qemuxml2argvtest: Modernize migration/restore tests qemuxml2argvtest: Consolidate and modernize CPU topology testing qemuxml2argvtest: Modernize test cases using 'host-model' CPU qemuxml2argvtest: Modernize 'cpu-Haswell' test cases qemuxml2argvtest: Modernize 'cpu-minimum' cases qemuxml2argvtest: Modernize 'cpu-strict' case qemuxml2argvtest: Modernize 'cpu-(no)fallback' test qemuxml2argvtest: Modernize 'cpu-exact' cases qemuxml2argvtest: Modernize rest of the test cases testutilsqemu: Drop fake machine capability data for 'x86_64' qemustatusxml2xmltest: Remove capabilities infrastructure testutilsqemu: Drop infrastructure for fake-caps testing testutilsqemu: Unexport 'testQemuCapsInit' qemu: capabilities: Unexport 'virQEMUCapsAddMachine' qemuxml2argvtest: Remove cpu model faking for fake-caps tests qemu: capabilities: Remove 'virQEMUCapsAddCPUDefinitions' src/qemu/qemu_capabilities.c | 81 +- src/qemu/qemu_capabilities.h | 17 +- src/qemu/qemu_capspriv.h | 14 - src/qemu/qemu_command.c | 46 +- src/qemu/qemu_domain.c | 11 +- src/qemu/qemu_validate.c | 43 +- .../caps_4.2.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0_ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0_s390x.xml | 1 - .../caps_4.2.0_x86_64.xml | 6 - .../caps_5.0.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0_ppc64.xml | 1 - .../caps_5.0.0_riscv64.xml | 1 - .../caps_5.0.0_x86_64.xml | 6 - .../caps_5.1.0_x86_64.xml | 6 - .../caps_5.2.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0_ppc64.xml | 1 - .../caps_5.2.0_riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0_s390x.xml | 1 - .../caps_5.2.0_x86_64.xml | 6 - .../caps_6.0.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0_s390x.xml | 1 - .../caps_6.0.0_x86_64.xml | 6 - .../caps_6.1.0_x86_64.xml | 6 - .../caps_6.2.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 3 - .../caps_6.2.0_x86_64.xml | 6 - .../caps_7.0.0_aarch64+hvf.xml | 1 - .../caps_7.0.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 3 - .../caps_7.0.0_x86_64.xml | 6 - .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 3 - .../caps_7.1.0_x86_64.xml | 6 - tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 3 - .../caps_7.2.0_x86_64+hvf.xml | 6 - .../caps_7.2.0_x86_64.xml | 6 - .../caps_8.0.0_riscv64.xml | 1 - .../caps_8.0.0_x86_64.xml | 6 - .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 - .../caps_8.1.0_x86_64.xml | 6 - tests/qemustatusxml2xmltest.c | 17 +- ...fx-ide-address-conflict.x86_64-latest.err} | 0 ...err => 440fx-wrong-root.x86_64-latest.err} | 0 ...ch64-gic-default-both.aarch64-latest.args} | 0 ...arch64-gic-default-v2.aarch64-latest.args} | 0 ...arch64-gic-default-v3.aarch64-latest.args} | 0 ...s => aarch64-gic-host.aarch64-latest.args} | 0 ...aarch64-gic-none-both.aarch64-latest.args} | 0 ... aarch64-gic-none-tcg.aarch64-latest.args} | 0 ...> aarch64-gic-none-v2.aarch64-latest.args} | 0 ...> aarch64-gic-none-v3.aarch64-latest.args} | 0 ...rgs => aarch64-gic-v2.aarch64-latest.args} | 0 ...rgs => aarch64-gic-v3.aarch64-latest.args} | 0 ...off.args => acpi-table.x86_64-latest.args} | 14 +- tests/qemuxml2argvdata/autoindex.args | 63 - .../autoindex.x86_64-latest.args | 65 + .../balloon-device-auto.x86_64-latest.args | 36 + ...loon-device-deflate-off.x86_64-latest.args | 36 + .../balloon-device-deflate.x86_64-latest.args | 36 + .../balloon-device-period.x86_64-latest.args | 36 + .../balloon-device.x86_64-latest.args | 36 + tests/qemuxml2argvdata/blkiotune-device.args | 34 - .../blkiotune-device.x86_64-latest.args | 36 + tests/qemuxml2argvdata/blkiotune.args | 34 - .../blkiotune.x86_64-latest.args | 36 + ...gs => channel-guestfwd.x86_64-latest.args} | 16 +- ...gs => channel-spicevmc.x86_64-latest.args} | 20 +- .../qemuxml2argvdata/channel-virtio-auto.args | 49 - .../channel-virtio-auto.x86_64-latest.args | 51 + .../channel-virtio-autoadd.args | 48 - .../channel-virtio-autoadd.x86_64-latest.args | 50 + .../channel-virtio-autoassign.args | 48 - ...annel-virtio-autoassign.x86_64-latest.args | 50 + .../channel-virtio-default.args | 41 - .../channel-virtio-default.x86_64-latest.args | 43 + .../channel-virtio-state.x86_64-latest.args | 43 + ...=> channel-virtio-unix.x86_64-latest.args} | 24 +- tests/qemuxml2argvdata/channel-virtio.args | 37 - ...args => channel-virtio.x86_64-latest.args} | 22 +- ...econnect-generated-path.x86_64-latest.err} | 0 ...connect-invalid-timeout.x86_64-latest.err} | 0 tests/qemuxml2argvdata/chardev-reconnect.args | 44 - .../chardev-reconnect.x86_64-latest.args | 46 + ....args => clock-catchup.x86_64-latest.args} | 14 +- ...e.args => clock-france.x86_64-latest.args} | 14 +- ....args => clock-hpet-off.x86_64-7.2.0.args} | 14 +- .../clock-hpet-off.x86_64-latest.args | 37 + ...altime-basis-localtime.x86_64-latest.args} | 14 +- ...rgs => clock-localtime.x86_64-latest.args} | 14 +- ...clock-timer-hyperv-rtc.x86_64-latest.args} | 11 +- ...-off.args => clock-utc.x86_64-latest.args} | 13 +- ...args => clock-variable.x86_64-latest.args} | 14 +- .../qemuxml2argvdata/console-compat-auto.args | 36 - .../console-compat-chardev.args | 36 - tests/qemuxml2argvdata/console-compat.args | 35 - ...=> console-virtio-many.x86_64-latest.args} | 24 +- ...args => console-virtio.x86_64-latest.args} | 18 +- tests/qemuxml2argvdata/controller-order.args | 52 - .../controller-order.x86_64-latest.args | 55 + ...s => cpu-Haswell-noTSX.x86_64-latest.args} | 11 +- ...ll.args => cpu-Haswell.x86_64-latest.args} | 11 +- ...2.args => cpu-Haswell2.x86_64-latest.args} | 11 +- ...3.args => cpu-Haswell3.x86_64-latest.args} | 11 +- .../cpu-cache-disable.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-cache-disable2.xml | 20 - .../cpu-cache-disable3.x86_64-latest.args | 33 + ...=> cpu-cache-emulate-l2.x86_64-latest.err} | 0 ...> cpu-cache-emulate-l3.x86_64-latest.args} | 13 +- ...pu-cache-passthrough-l3.x86_64-latest.err} | 0 .../cpu-cache-passthrough.args | 32 - ... cpu-cache-passthrough.x86_64-latest.args} | 13 +- .../cpu-cache-passthrough2.args | 32 - .../cpu-cache-passthrough2.xml | 20 - ... cpu-cache-passthrough3.x86_64-latest.err} | 0 .../cpu-check-default-none.args | 32 - .../cpu-check-default-none.x86_64-latest.args | 33 + ...pu-check-default-none2.x86_64-latest.args} | 11 +- .../cpu-check-default-partial.args | 32 - ...u-check-default-partial.x86_64-latest.args | 33 + ...check-default-partial2.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-check-full.args | 1 - .../cpu-check-full.x86_64-latest.args | 1 + ...args => cpu-check-none.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-check-partial.args | 1 - .../cpu-check-partial.x86_64-latest.args | 1 + ...ct1.args => cpu-exact1.x86_64-latest.args} | 11 +- ... cpu-exact2-nofallback.x86_64-latest.args} | 11 +- ...ct2.args => cpu-exact2.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-fallback.args | 32 - ...er.args => cpu-fallback.x86_64-5.2.0.args} | 9 +- .../cpu-fallback.x86_64-8.0.0.args | 33 + tests/qemuxml2argvdata/cpu-fallback.xml | 15 +- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 32 - .../cpu-host-kvmclock.x86_64-latest.args | 33 + ... => cpu-host-model-cmt.x86_64-latest.args} | 11 +- ...cpu-host-model-fallback.x86_64-4.2.0.args} | 7 +- ...cpu-host-model-fallback.x86_64-5.0.0.args} | 7 +- .../cpu-host-model-fallback.x86_64-5.1.0.args | 33 + .../cpu-host-model-fallback.x86_64-5.2.0.args | 34 + .../cpu-host-model-fallback.x86_64-6.0.0.args | 34 + .../cpu-host-model-fallback.x86_64-6.1.0.args | 34 + .../cpu-host-model-fallback.x86_64-6.2.0.args | 34 + .../cpu-host-model-fallback.x86_64-7.0.0.args | 34 + .../cpu-host-model-fallback.x86_64-7.1.0.args | 34 + .../cpu-host-model-fallback.x86_64-7.2.0.args | 34 + .../cpu-host-model-fallback.x86_64-8.0.0.args | 33 + ...cpu-host-model-fallback.x86_64-latest.args | 33 + .../cpu-host-model-nofallback.err | 1 - ...pu-host-model-nofallback.x86_64-4.2.0.args | 33 + ...pu-host-model-nofallback.x86_64-5.0.0.args | 33 + ...pu-host-model-nofallback.x86_64-5.1.0.args | 33 + ...pu-host-model-nofallback.x86_64-5.2.0.args | 34 + ...pu-host-model-nofallback.x86_64-6.0.0.args | 34 + ...pu-host-model-nofallback.x86_64-6.1.0.args | 34 + ...pu-host-model-nofallback.x86_64-6.2.0.args | 34 + ...pu-host-model-nofallback.x86_64-7.0.0.args | 34 + ...pu-host-model-nofallback.x86_64-7.1.0.args | 34 + ...pu-host-model-nofallback.x86_64-7.2.0.args | 34 + ...pu-host-model-nofallback.x86_64-8.0.0.args | 33 + ...u-host-model-nofallback.x86_64-latest.args | 33 + .../cpu-host-model-vendor.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-host-model.args | 40 - .../cpu-host-model.x86_64-6.2.0.args | 39 + .../cpu-host-model.x86_64-7.0.0.args | 39 + .../cpu-host-model.x86_64-7.1.0.args | 39 + .../cpu-host-model.x86_64-7.2.0.args | 39 + .../cpu-host-model.x86_64-8.0.0.args | 38 + ...t-passthrough-features.x86_64-latest.args} | 14 +- .../cpu-host-passthrough.args | 32 - .../cpu-host-passthrough.x86_64-latest.args | 33 + ...k.args => cpu-kvmclock.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-minimum1.args | 32 - .../cpu-minimum1.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-minimum2.args | 32 - .../cpu-minimum2.x86_64-latest.args | 33 + ...pu-no-removed-features.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-nofallback.err | 1 - .../cpu-nofallback.x86_64-5.2.0.err | 1 + .../cpu-nofallback.x86_64-8.0.0.args | 33 + tests/qemuxml2argvdata/cpu-nofallback.xml | 15 +- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 33 - .../cpu-numa-disjoint.x86_64-latest.args | 36 + .../cpu-numa-memshared.x86_64-latest.args | 36 + .../cpu-numa-no-memory-element.args | 33 - ...numa-no-memory-element.x86_64-latest.args} | 17 +- tests/qemuxml2argvdata/cpu-numa1.args | 33 - .../cpu-numa1.x86_64-latest.args | 36 + tests/qemuxml2argvdata/cpu-numa2.args | 33 - .../cpu-numa2.x86_64-latest.args | 36 + ...-numa3.err => cpu-numa3.x86_64-latest.err} | 0 .../cpu-phys-bits-emulate.args | 32 - ... cpu-phys-bits-emulate.x86_64-latest.args} | 13 +- .../cpu-phys-bits-emulate2.args | 32 - .../cpu-phys-bits-emulate2.x86_64-latest.args | 33 + .../cpu-phys-bits-passthrough.args | 32 - ...-phys-bits-passthrough.x86_64-latest.args} | 13 +- ...-phys-bits-passthrough2.x86_64-latest.err} | 0 ...u-qemu-host-passthrough.x86_64-latest.err} | 0 tests/qemuxml2argvdata/cpu-strict1.args | 32 - .../cpu-strict1.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-strict1.xml | 12 +- tests/qemuxml2argvdata/cpu-topology1.args | 31 - ....args => cpu-topology1.x86_64-latest.args} | 17 +- tests/qemuxml2argvdata/cpu-topology1.xml | 4 +- tests/qemuxml2argvdata/cpu-topology2.args | 32 - .../cpu-topology2.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-topology2.xml | 5 +- tests/qemuxml2argvdata/cpu-topology3.args | 31 - .../cpu-topology3.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-topology3.xml | 2 +- .../cpu-topology4.x86_64-latest.args | 33 + .../{monitor-json.xml => cpu-topology4.xml} | 18 +- ...s => cpu-tsc-frequency.x86_64-latest.args} | 11 +- ... default-kvm-host-arch.x86_64-latest.args} | 12 +- ...default-qemu-host-arch.x86_64-latest.args} | 12 +- .../graphics-egl-headless.args | 33 - ...raphics-sdl-fullscreen.x86_64-latest.args} | 14 +- ...l.args => graphics-sdl.x86_64-latest.args} | 14 +- ...isplay-missing-graphics.x86_64-latest.err} | 0 ... hostdev-mdev-duplicate.x86_64-latest.err} | 0 ...-invalid-target-address.x86_64-latest.err} | 0 ...ostdev-mdev-precreated.x86_64-latest.args} | 12 +- ...dev-src-address-invalid.x86_64-latest.err} | 0 .../hostdev-pci-address-unassigned.args | 34 - ...-pci-address-unassigned.x86_64-latest.args | 36 + ...> hostdev-pci-duplicate.x86_64-latest.err} | 0 .../hostdev-pci-multifunction.args | 38 - ...stdev-pci-multifunction.x86_64-latest.args | 40 + ... hostdev-scsi-duplicate.x86_64-latest.err} | 0 ...ev-scsi-vhost-scsi-pci.x86_64-latest.args} | 22 +- ...> hostdev-usb-duplicate.x86_64-latest.err} | 0 ...stdev-vfio-multidomain.x86_64-latest.args} | 17 +- ...ev-vfio-zpci-wrong-arch.x86_64-latest.err} | 0 tests/qemuxml2argvdata/hostdev-vfio.args | 35 - ...n.args => hostdev-vfio.x86_64-latest.args} | 16 +- ...e.args => hotplug-base.x86_64-latest.args} | 13 +- ...s-default-1G-nodeset-2M.x86_64-latest.err} | 0 ...pages-memaccess-invalid.x86_64-latest.err} | 0 ... => hugepages-memaccess3.x86_64-5.1.0.err} | 0 .../qemuxml2argvdata/input-usbmouse-addr.args | 35 - .../input-usbmouse-addr.x86_64-latest.args | 37 + .../input-usbmouse.x86_64-latest.args | 36 + tests/qemuxml2argvdata/input-usbtablet.args | 34 - .../input-usbtablet.x86_64-latest.args | 36 + ....args => kvm-pit-delay.x86_64-latest.args} | 14 +- ...rgs => kvm-pit-discard.x86_64-latest.args} | 14 +- ...clock.args => kvmclock.x86_64-latest.args} | 9 +- tests/qemuxml2argvdata/machine-aliases1.args | 34 - .../machine-aliases1.x86_64-latest.args | 36 + ...gs => machine-aliases2.x86_64-latest.args} | 15 +- .../machine-core-off.x86_64-latest.args | 35 + tests/qemuxml2argvdata/machine-core-on.args | 33 - ...rgs => machine-core-on.x86_64-latest.args} | 13 +- ...dparm-s390-char-invalid.x86_64-latest.err} | 0 ...adparm-s390-len-invalid.x86_64-latest.err} | 0 .../qemuxml2argvdata/machine-vmport-opt.args | 34 - .../machine-vmport-opt.x86_64-latest.args | 36 + ...rr => memory-align-fail.x86_64-latest.err} | 0 .../memory-hotplug-dimm.x86_64-latest.args | 41 + ...plug-invalid-targetnode.x86_64-latest.err} | 0 ...> memory-hotplug-nonuma.x86_64-latest.err} | 0 tests/qemuxml2argvdata/memory-hotplug.args | 35 - ...args => memory-hotplug.x86_64-latest.args} | 22 +- tests/qemuxml2argvdata/memtune-unlimited.args | 34 - .../memtune-unlimited.x86_64-latest.args | 36 + tests/qemuxml2argvdata/memtune.args | 34 - .../memtune.x86_64-latest.args | 36 + ...migrate-numa-unaligned.x86_64-latest.args} | 17 +- ...igrate.args => migrate.x86_64-latest.args} | 12 +- ...rr => minimal-no-memory.x86_64-latest.err} | 0 tests/qemuxml2argvdata/minimal.args | 34 - .../minimal.x86_64-latest.args | 36 + tests/qemuxml2argvdata/misc-acpi.args | 32 - ...late.args => misc-acpi.x86_64-latest.args} | 13 +- ...rgs => misc-disable-s3.x86_64-latest.args} | 12 +- ... misc-disable-suspends.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/misc-enable-s4.err | 1 - ...args => misc-enable-s4.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/misc-uuid.args | 32 - ...auto.args => misc-uuid.x86_64-latest.args} | 13 +- tests/qemuxml2argvdata/monitor-json.args | 34 - .../multifunction-pci-device.args | 43 - ...ultifunction-pci-device.x86_64-latest.args | 45 + ...s.args => nosharepages.x86_64-latest.args} | 12 +- .../numad-auto-memory-vcpu-cpuset.args | 34 - ...auto-memory-vcpu-cpuset.x86_64-latest.args | 36 + ...o-memory-vcpu-no-cpuset-and-placement.args | 34 - ...no-cpuset-and-placement.x86_64-latest.args | 36 + ...tic-numatune-no-nodeset.x86_64-latest.err} | 0 .../numad-auto-vcpu-static-numatune.args | 34 - ...to-vcpu-static-numatune.x86_64-latest.args | 36 + .../numad-static-memory-auto-vcpu.args | 34 - ...static-memory-auto-vcpu.x86_64-latest.args | 36 + tests/qemuxml2argvdata/numad.args | 34 - .../qemuxml2argvdata/numad.x86_64-latest.args | 36 + .../numatune-auto-nodeset-invalid.args | 34 - ...ne-auto-nodeset-invalid.x86_64-latest.args | 36 + ...> numatune-auto-prefer.x86_64-latest.args} | 14 +- ... => numatune-distances.x86_64-latest.args} | 28 +- ...ne-memnode-invalid-mode.x86_64-latest.err} | 0 ...tune-memnode-no-memory.x86_64-latest.args} | 15 +- ... numatune-memnode-nocpu.x86_64-latest.err} | 0 tests/qemuxml2argvdata/numatune-memnode.args | 37 - ...ne-memnodes-problematic.x86_64-latest.err} | 0 ...-memory-invalid-nodeset.x86_64-latest.err} | 0 tests/qemuxml2argvdata/numatune-memory.args | 34 - tests/qemuxml2argvdata/numatune-memory.xml | 31 - ...nodeset-exceed-hostnode.x86_64-latest.err} | 0 .../parallel-parport-chardev.args | 36 - .../parallel-tcp-chardev.args | 36 - tests/qemuxml2argvdata/pci-autoadd-addr.args | 41 - .../pci-autoadd-addr.x86_64-latest.args | 44 + tests/qemuxml2argvdata/pci-autoadd-idx.args | 42 - .../pci-autoadd-idx.x86_64-latest.args | 45 + ...s => pci-autofill-addr.x86_64-latest.args} | 16 +- ...-bridge-duplicate-index.x86_64-latest.err} | 0 ... pci-bridge-many-disks.x86_64-latest.args} | 224 ++-- ...-negative-index-invalid.x86_64-latest.err} | 0 tests/qemuxml2argvdata/pci-bridge.args | 101 -- .../pci-bridge.x86_64-latest.args | 104 ++ ....err => pci-bus-invalid.x86_64-latest.err} | 0 ...r => pci-domain-invalid.x86_64-latest.err} | 0 ...ci-expander-bus-bad-bus.x86_64-latest.err} | 0 ...xpander-bus-bad-machine.x86_64-latest.err} | 0 ...i-expander-bus-bad-node.x86_64-latest.err} | 0 tests/qemuxml2argvdata/pci-expander-bus.args | 98 -- .../pci-expander-bus.x86_64-latest.args | 101 ++ ...=> pci-function-invalid.x86_64-latest.err} | 0 ...-many.args => pci-many.x86_64-latest.args} | 71 +- .../pci-rom-disabled-invalid.args | 1 - ...ci-rom-disabled-invalid.x86_64-latest.args | 1 + ...gs => pci-rom-disabled.x86_64-latest.args} | 12 +- .../pci-rom.x86_64-latest.args | 42 + ...err => pci-root-address.x86_64-latest.err} | 0 ... pci-root-nonzero-index.x86_64-latest.err} | 0 .../pci-serial-dev-chardev.args | 36 - ...err => pci-slot-invalid.x86_64-latest.err} | 0 ...ie-expander-bus-bad-bus.x86_64-latest.err} | 0 ...xpander-bus-bad-machine.x86_64-latest.err} | 0 tests/qemuxml2argvdata/pcie-expander-bus.args | 135 -- .../pcie-expander-bus.x86_64-latest.args | 140 ++ ...oot-port-model-generic.x86_64-latest.args} | 14 +- ...oot-port-model-ioh3420.x86_64-latest.args} | 14 +- ...pcie-root-port-too-many.x86_64-latest.err} | 0 ...args => pcie-root-port.x86_64-latest.args} | 17 +- ...root.args => pcie-root.x86_64-latest.args} | 11 +- .../pcie-switch-downstream-port.args | 45 - ...-switch-downstream-port.x86_64-latest.args | 48 + .../pcie-switch-upstream-port.args | 39 - ...ie-switch-upstream-port.x86_64-latest.args | 43 + ....args => pcihole64-q35.x86_64-latest.args} | 15 +- ...le64.args => pcihole64.x86_64-latest.args} | 12 +- ...rgs => pmu-feature-off.x86_64-latest.args} | 8 +- ...re.args => pmu-feature.x86_64-latest.args} | 8 +- ...eatures-invalid-machine.x86_64-latest.err} | 0 ...-serial-invalid-machine.x86_64-latest.err} | 0 ...=> q35-dmi-bad-address1.x86_64-latest.err} | 0 ...=> q35-dmi-bad-address2.x86_64-latest.err} | 0 .../q35-pci-force-address.args | 38 - .../q35-pci-force-address.x86_64-latest.args | 40 + .../q35-pm-disable-fallback.args | 37 - .../q35-pm-disable-fallback.xml | 18 - tests/qemuxml2argvdata/q35-pm-disable.args | 37 - tests/qemuxml2argvdata/q35-pm-disable.xml | 18 - tests/qemuxml2argvdata/q35-usb2-multi.args | 49 - .../q35-usb2-multi.x86_64-latest.args | 51 + tests/qemuxml2argvdata/q35-usb2-reorder.args | 49 - .../q35-usb2-reorder.x86_64-latest.args | 51 + .../q35-usb2.x86_64-latest.args | 43 + ...t.err => q35-wrong-root.x86_64-latest.err} | 0 tests/qemuxml2argvdata/q35.args | 39 - .../{q35-usb2.args => q35.x86_64-latest.args} | 23 +- tests/qemuxml2argvdata/q35.xml | 4 + ...nv.args => qemu-ns-alt.x86_64-latest.args} | 15 +- .../qemu-ns-commandline-ns0.args | 34 - ...qemu-ns-commandline-ns0.x86_64-latest.args | 36 + .../qemu-ns-commandline-ns1.args | 34 - ...qemu-ns-commandline-ns1.x86_64-latest.args | 36 + .../qemuxml2argvdata/qemu-ns-commandline.args | 34 - .../qemu-ns-commandline.x86_64-latest.args | 36 + .../qemu-ns-domain-commandline-ns0.args | 34 - ...-domain-commandline-ns0.x86_64-latest.args | 36 + .../qemu-ns-domain-commandline.args | 34 - ...u-ns-domain-commandline.x86_64-latest.args | 36 + .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 34 - .../qemu-ns-domain-ns0.x86_64-latest.args | 36 + ...args => qemu-ns-no-env.x86_64-latest.args} | 15 +- ...eboot-timeout-disabled.x86_64-latest.args} | 10 +- ...reboot-timeout-enabled.x86_64-latest.args} | 10 +- ....args => restore-v2-fd.x86_64-latest.args} | 14 +- ...-v2.args => restore-v2.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 34 - .../seclabel-dac-none.x86_64-latest.args | 36 + ...label-device-duplicates.x86_64-latest.err} | 0 ...-device-relabel-invalid.x86_64-latest.err} | 0 .../seclabel-dynamic-baselabel.args | 34 - ...label-dynamic-baselabel.x86_64-latest.args | 36 + .../seclabel-dynamic-labelskip.args | 34 - ...label-dynamic-labelskip.x86_64-latest.args | 36 + ...label-dynamic-override.x86_64-latest.args} | 16 +- .../seclabel-dynamic-relabel.args | 34 - ...eclabel-dynamic-relabel.x86_64-latest.args | 36 + tests/qemuxml2argvdata/seclabel-dynamic.args | 34 - .../seclabel-dynamic.x86_64-latest.args | 36 + ...rr => seclabel-multiple.x86_64-latest.err} | 0 tests/qemuxml2argvdata/seclabel-none.args | 34 - .../seclabel-none.x86_64-latest.args | 36 + .../seclabel-static-labelskip.args | 34 - ...clabel-static-labelskip.x86_64-latest.args | 36 + .../seclabel-static-relabel.args | 34 - ...seclabel-static-relabel.x86_64-latest.args | 36 + tests/qemuxml2argvdata/seclabel-static.args | 34 - .../seclabel-static.x86_64-latest.args | 36 + .../serial-dev-chardev-iobase.args | 36 - .../qemuxml2argvdata/serial-dev-chardev.args | 36 - .../qemuxml2argvdata/serial-file-chardev.args | 37 - tests/qemuxml2argvdata/serial-file-log.args | 37 - .../qemuxml2argvdata/serial-many-chardev.args | 39 - .../qemuxml2argvdata/serial-pty-chardev.args | 36 - tests/qemuxml2argvdata/serial-spiceport.args | 38 - .../qemuxml2argvdata/serial-tcp-chardev.args | 36 - .../serial-tcp-telnet-chardev.args | 36 - .../serial-tcp-tlsx509-chardev-verify.args | 39 - .../serial-tcp-tlsx509-chardev.args | 39 - .../serial-tcp-tlsx509-secret-chardev.args | 40 - .../qemuxml2argvdata/serial-udp-chardev.args | 38 - tests/qemuxml2argvdata/serial-vc-chardev.args | 36 - .../smartcard-controller.x86_64-latest.args | 35 + ...t-certificates-database.x86_64-latest.args | 35 + .../smartcard-host-certificates.args | 33 - ...tcard-host-certificates.x86_64-latest.args | 35 + tests/qemuxml2argvdata/smartcard-host.args | 33 - .../smartcard-host.x86_64-latest.args | 35 + ...d-passthrough-spicevmc.x86_64-latest.args} | 18 +- ...rtcard-passthrough-tcp.x86_64-latest.args} | 16 +- ...date.err => smbios-date.x86_64-latest.err} | 0 ...rr => smbios-uuid-match.x86_64-latest.err} | 0 ...{smbios.args => smbios.x86_64-latest.args} | 14 +- tests/qemuxml2argvdata/smp-dies.args | 33 - tests/qemuxml2argvdata/smp.args | 33 - ... tpm-no-backend-invalid.x86_64-latest.err} | 0 ....err => usb-bus-missing.x86_64-latest.err} | 0 ...troller-default-i440fx.x86_64-latest.args} | 14 +- ....xml => usb-controller-default-i440fx.xml} | 0 ...controller-default-isapc.x86_64-latest.err | 1 + .../usb-controller-default-isapc.xml | 16 + ...controller-default-q35.x86_64-latest.args} | 10 +- ...ult-unavailable-i440fx.x86_64-latest.args} | 12 +- ...-controller-default-unavailable-i440fx.xml | 1 + ...default-unavailable-q35.x86_64-latest.err} | 0 ...sb-controller-explicit-unavailable-q35.xml | 1 - ...troller-ich9-autoassign.x86_64-latest.args | 41 + ...xml => usb-controller-ich9-autoassign.xml} | 0 ...ntroller-ich9-companion.x86_64-latest.args | 36 + ....xml => usb-controller-ich9-companion.xml} | 0 ...ntroller-ich9-ehci-addr.x86_64-latest.args | 44 + ....xml => usb-controller-ich9-ehci-addr.xml} | 0 ...oller-ich9-no-companion.x86_64-latest.err} | 0 ...l => usb-controller-ich9-no-companion.xml} | 0 ...roller-implicit-i440fx.x86_64-latest.args} | 13 +- ...xml => usb-controller-implicit-i440fx.xml} | 1 - ...troller-implicit-isapc.x86_64-latest.args} | 8 +- .../usb-controller-implicit-isapc.xml | 15 + ...controller-implicit-q35.x86_64-latest.args | 36 + .../usb-controller-implicit-q35.xml | 15 + ...ntroller-nec-xhci-limit.x86_64-latest.err} | 0 ....xml => usb-controller-nec-xhci-limit.xml} | 0 ...er-nec-xhci-unavailable.x86_64-latest.err} | 0 .../usb-controller-nec-xhci-unavailable.xml | 1 + ...sb-controller-nec-xhci.x86_64-latest.args} | 10 +- ...it-q35.xml => usb-controller-nec-xhci.xml} | 0 ...ler-nex-xhci-autoassign.x86_64-latest.args | 37 + ...=> usb-controller-nex-xhci-autoassign.xml} | 0 ...> usb-controller-piix3.x86_64-latest.args} | 15 +- ...ontroller.xml => usb-controller-piix3.xml} | 0 ...troller-qemu-xhci-limit.x86_64-latest.err} | 0 .../usb-controller-qemu-xhci-unavailable.err | 1 - .../usb-controller-qemu-xhci-unavailable.xml | 1 - .../usb-controller-qemu-xhci.args | 30 - ...b-controller-qemu-xhci.x86_64-latest.args} | 15 +- .../qemuxml2argvdata/usb-controller-xhci.args | 30 - tests/qemuxml2argvdata/usb-controller.args | 31 - .../usb-hub-autoadd-deluxe.args | 50 - .../usb-hub-autoadd-deluxe.x86_64-latest.args | 52 + tests/qemuxml2argvdata/usb-hub-autoadd.args | 36 - .../usb-hub-autoadd.x86_64-latest.args | 38 + ...err => usb-hub-conflict.x86_64-latest.err} | 0 ... => usb-hub-nonexistent.x86_64-latest.err} | 0 tests/qemuxml2argvdata/usb-hub.args | 32 - .../usb-hub.x86_64-latest.args | 34 + .../qemuxml2argvdata/usb-ich9-autoassign.args | 39 - .../qemuxml2argvdata/usb-ich9-companion.args | 34 - .../qemuxml2argvdata/usb-ich9-ehci-addr.args | 42 - .../qemuxml2argvdata/usb-long-port-path.args | 35 - .../usb-long-port-path.x86_64-latest.args | 37 + ...hub.err => usb-none-hub.x86_64-latest.err} | 0 ...r.err => usb-none-other.x86_64-latest.err} | 0 ...r => usb-none-usbtablet.x86_64-latest.err} | 0 tests/qemuxml2argvdata/usb-none.args | 30 - .../usb-none.x86_64-latest.args | 32 + .../qemuxml2argvdata/usb-port-autoassign.args | 36 - .../usb-port-autoassign.x86_64-latest.args | 38 + tests/qemuxml2argvdata/usb-port-missing.args | 34 - .../usb-port-missing.x86_64-latest.args | 36 + ... usb-ports-out-of-range.x86_64-latest.err} | 0 tests/qemuxml2argvdata/usb-ports.args | 36 - .../usb-ports.x86_64-latest.args | 38 + tests/qemuxml2argvdata/usb-redir-boot.args | 39 - .../usb-redir-boot.x86_64-latest.args | 41 + .../usb-redir-filter-version.args | 36 - ...sb-redir-filter-version.x86_64-latest.args | 38 + tests/qemuxml2argvdata/usb-redir-filter.args | 39 - .../usb-redir-filter.x86_64-latest.args | 41 + tests/qemuxml2argvdata/usb-redir.args | 39 - .../usb-redir.x86_64-latest.args | 41 + ...-long-port-path-invalid.x86_64-latest.err} | 0 .../qemuxml2argvdata/usb-xhci-autoassign.args | 35 - tests/qemuxml2argvdata/usb1-usb2.args | 43 - .../usb1-usb2.x86_64-latest.args | 45 + ...=> vhost_queues-invalid.x86_64-latest.err} | 0 .../virtio-input-passthrough.args | 32 - ...irtio-input-passthrough.x86_64-latest.args | 34 + tests/qemuxml2argvdata/virtio-input.args | 34 - .../virtio-input.x86_64-latest.args | 36 + ...lloon-freepage-reporting.x86_64-5.0.0.err} | 0 .../qemuxml2argvdata/virtio-rng-default.args | 33 - .../virtio-rng-default.x86_64-latest.args | 35 + ...=> virtio-rng-egd-crash.x86_64-latest.err} | 0 ...args => virtio-rng-egd.x86_64-latest.args} | 16 +- .../qemuxml2argvdata/virtio-rng-multiple.args | 36 - .../virtio-rng-multiple.x86_64-latest.args | 38 + tests/qemuxml2argvdata/virtio-rng-random.args | 33 - .../virtio-rng-random.x86_64-latest.args | 35 + tests/qemuxml2argvdata/vmcoreinfo.args | 35 - .../vmcoreinfo.x86_64-latest.args | 37 + tests/qemuxml2argvtest.c | 1189 ++++++----------- .../default-kvm-host-arch.x86_64-latest.xml | 2 +- .../default-qemu-host-arch.x86_64-latest.xml | 2 +- .../qemuxml2xmloutdata/q35.x86_64-latest.xml | 4 + ...ntroller-default-i440fx.x86_64-latest.xml} | 0 ...ault-unavailable-i440fx.x86_64-latest.xml} | 22 +- ...ntroller-ich9-ehci-addr.x86_64-latest.xml} | 0 ...troller-implicit-i440fx.x86_64-latest.xml} | 12 +- ...ntroller-implicit-isapc.x86_64-latest.xml} | 18 +- ...-controller-implicit-q35.x86_64-latest.xml | 43 + ...usb-controller-nec-xhci.x86_64-latest.xml} | 0 ...=> usb-controller-piix3.x86_64-latest.xml} | 0 tests/qemuxml2xmltest.c | 14 +- tests/testutilsqemu.c | 159 +-- tests/testutilsqemu.h | 6 +- 550 files changed, 6870 insertions(+), 7188 deletions(-) rename tests/qemuxml2argvdata/{440fx-ide-address-conflict.err => 440fx-ide-address-conflict.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{440fx-wrong-root.err => 440fx-wrong-root.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-default-both.args => aarch64-gic-default-both.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-default-v2.args => aarch64-gic-default-v2.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-default-v3.args => aarch64-gic-default-v3.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-host.args => aarch64-gic-host.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-both.args => aarch64-gic-none-both.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-tcg.args => aarch64-gic-none-tcg.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-v2.args => aarch64-gic-none-v2.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-v3.args => aarch64-gic-none-v3.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-v2.args => aarch64-gic-v2.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-v3.args => aarch64-gic-v3.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{machine-core-off.args => acpi-table.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/autoindex.args create mode 100644 tests/qemuxml2argvdata/autoindex.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-deflate-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-deflate.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-period.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/blkiotune-device.args create mode 100644 tests/qemuxml2argvdata/blkiotune-device.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/blkiotune.args create mode 100644 tests/qemuxml2argvdata/blkiotune.x86_64-latest.args rename tests/qemuxml2argvdata/{channel-guestfwd.args => channel-guestfwd.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{channel-spicevmc.args => channel-spicevmc.x86_64-latest.args} (55%) delete mode 100644 tests/qemuxml2argvdata/channel-virtio-auto.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-auto.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/channel-virtio-autoadd.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-autoadd.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/channel-virtio-autoassign.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-autoassign.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/channel-virtio-default.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-default.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-state.x86_64-latest.args rename tests/qemuxml2argvdata/{channel-virtio-unix.args => channel-virtio-unix.x86_64-latest.args} (50%) delete mode 100644 tests/qemuxml2argvdata/channel-virtio.args rename tests/qemuxml2argvdata/{channel-virtio-state.args => channel-virtio.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{chardev-reconnect-generated-path.err => chardev-reconnect-generated-path.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{chardev-reconnect-invalid-timeout.err => chardev-reconnect-invalid-timeout.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/chardev-reconnect.args create mode 100644 tests/qemuxml2argvdata/chardev-reconnect.x86_64-latest.args rename tests/qemuxml2argvdata/{clock-catchup.args => clock-catchup.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{clock-localtime.args => clock-france.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{clock-hpet-off.args => clock-hpet-off.x86_64-7.2.0.args} (60%) create mode 100644 tests/qemuxml2argvdata/clock-hpet-off.x86_64-latest.args rename tests/qemuxml2argvdata/{clock-localtime-basis-localtime.args => clock-localtime-basis-localtime.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{clock-france.args => clock-localtime.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{clock-timer-hyperv-rtc.args => clock-timer-hyperv-rtc.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{balloon-device-deflate-off.args => clock-utc.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{clock-variable.args => clock-variable.x86_64-latest.args} (61%) delete mode 100644 tests/qemuxml2argvdata/console-compat-auto.args delete mode 100644 tests/qemuxml2argvdata/console-compat-chardev.args delete mode 100644 tests/qemuxml2argvdata/console-compat.args rename tests/qemuxml2argvdata/{console-virtio-many.args => console-virtio-many.x86_64-latest.args} (52%) rename tests/qemuxml2argvdata/{console-virtio.args => console-virtio.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2argvdata/controller-order.args create mode 100644 tests/qemuxml2argvdata/controller-order.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-Haswell-noTSX.args => cpu-Haswell-noTSX.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{cpu-Haswell.args => cpu-Haswell.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{cpu-Haswell2.args => cpu-Haswell2.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{cpu-Haswell3.args => cpu-Haswell3.x86_64-latest.args} (60%) create mode 100644 tests/qemuxml2argvdata/cpu-cache-disable.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-cache-disable2.xml create mode 100644 tests/qemuxml2argvdata/cpu-cache-disable3.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-cache-emulate-l2.err => cpu-cache-emulate-l2.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{cpu-cache-disable.args => cpu-cache-emulate-l3.x86_64-latest.args} (56%) rename tests/qemuxml2argvdata/{cpu-cache-passthrough-l3.err => cpu-cache-passthrough-l3.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-cache-passthrough.args rename tests/qemuxml2argvdata/{cpu-cache-disable2.args => cpu-cache-passthrough.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2argvdata/cpu-cache-passthrough2.args delete mode 100644 tests/qemuxml2argvdata/cpu-cache-passthrough2.xml rename tests/qemuxml2argvdata/{cpu-cache-passthrough3.err => cpu-cache-passthrough3.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-check-default-none.args create mode 100644 tests/qemuxml2argvdata/cpu-check-default-none.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-check-default-none2.args => cpu-check-default-none2.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-check-default-partial.args create mode 100644 tests/qemuxml2argvdata/cpu-check-default-partial.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-check-default-partial2.args => cpu-check-default-partial2.x86_64-latest.args} (60%) delete mode 120000 tests/qemuxml2argvdata/cpu-check-full.args create mode 120000 tests/qemuxml2argvdata/cpu-check-full.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-check-none.args => cpu-check-none.x86_64-latest.args} (60%) delete mode 120000 tests/qemuxml2argvdata/cpu-check-partial.args create mode 120000 tests/qemuxml2argvdata/cpu-check-partial.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-exact1.args => cpu-exact1.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{cpu-exact2-nofallback.args => cpu-exact2-nofallback.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{cpu-exact2.args => cpu-exact2.x86_64-latest.args} (63%) delete mode 100644 tests/qemuxml2argvdata/cpu-fallback.args rename tests/qemuxml2argvdata/{usb-piix3-controller.args => cpu-fallback.x86_64-5.2.0.args} (73%) create mode 100644 tests/qemuxml2argvdata/cpu-fallback.x86_64-8.0.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-kvmclock.args create mode 100644 tests/qemuxml2argvdata/cpu-host-kvmclock.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-host-model-cmt.args => cpu-host-model-cmt.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.args => cpu-host-model-fallback.x86_64-4.2.0.args} (63%) rename tests/qemuxml2argvdata/{cpu-host-model-vendor.args => cpu-host-model-fallback.x86_64-5.0.0.args} (63%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.err create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-4.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-vendor.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-8.0.0.args rename tests/qemuxml2argvdata/{machine-aliases2.args => cpu-host-passthrough-features.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-host-passthrough.args create mode 100644 tests/qemuxml2argvdata/cpu-host-passthrough.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-kvmclock.args => cpu-kvmclock.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-minimum1.args create mode 100644 tests/qemuxml2argvdata/cpu-minimum1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-minimum2.args create mode 100644 tests/qemuxml2argvdata/cpu-minimum2.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-no-removed-features.args => cpu-no-removed-features.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-nofallback.err create mode 100644 tests/qemuxml2argvdata/cpu-nofallback.x86_64-5.2.0.err create mode 100644 tests/qemuxml2argvdata/cpu-nofallback.x86_64-8.0.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-numa-disjoint.args create mode 100644 tests/qemuxml2argvdata/cpu-numa-disjoint.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-numa-memshared.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-numa-no-memory-element.args rename tests/qemuxml2argvdata/{cpu-numa-memshared.args => cpu-numa-no-memory-element.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2argvdata/cpu-numa1.args create mode 100644 tests/qemuxml2argvdata/cpu-numa1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-numa2.args create mode 100644 tests/qemuxml2argvdata/cpu-numa2.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-numa3.err => cpu-numa3.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.args rename tests/qemuxml2argvdata/{cpu-cache-disable3.args => cpu-phys-bits-emulate.x86_64-latest.args} (57%) delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.args rename tests/qemuxml2argvdata/{cpu-cache-emulate-l3.args => cpu-phys-bits-passthrough.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{cpu-phys-bits-passthrough2.err => cpu-phys-bits-passthrough2.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{cpu-qemu-host-passthrough.err => cpu-qemu-host-passthrough.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-strict1.args create mode 100644 tests/qemuxml2argvdata/cpu-strict1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-topology1.args rename tests/qemuxml2argvdata/{balloon-device.args => cpu-topology1.x86_64-latest.args} (55%) delete mode 100644 tests/qemuxml2argvdata/cpu-topology2.args create mode 100644 tests/qemuxml2argvdata/cpu-topology2.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-topology3.args create mode 100644 tests/qemuxml2argvdata/cpu-topology3.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-topology4.x86_64-latest.args rename tests/qemuxml2argvdata/{monitor-json.xml => cpu-topology4.xml} (51%) rename tests/qemuxml2argvdata/{cpu-tsc-frequency.args => cpu-tsc-frequency.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{default-kvm-host-arch.args => default-kvm-host-arch.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{default-qemu-host-arch.args => default-qemu-host-arch.x86_64-latest.args} (59%) delete mode 100644 tests/qemuxml2argvdata/graphics-egl-headless.args rename tests/qemuxml2argvdata/{graphics-sdl-fullscreen.args => graphics-sdl-fullscreen.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{graphics-sdl.args => graphics-sdl.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{hostdev-mdev-display-missing-graphics.err => hostdev-mdev-display-missing-graphics.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-mdev-duplicate.err => hostdev-mdev-duplicate.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-mdev-invalid-target-address.err => hostdev-mdev-invalid-target-address.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-mdev-precreated.args => hostdev-mdev-precreated.x86_64-latest.args} (55%) rename tests/qemuxml2argvdata/{hostdev-mdev-src-address-invalid.err => hostdev-mdev-src-address-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.x86_64-latest.args rename tests/qemuxml2argvdata/{hostdev-pci-duplicate.err => hostdev-pci-duplicate.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.x86_64-latest.args rename tests/qemuxml2argvdata/{hostdev-scsi-duplicate.err => hostdev-scsi-duplicate.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-rom.args => hostdev-scsi-vhost-scsi-pci.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{hostdev-usb-duplicate.err => hostdev-usb-duplicate.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-scsi-vhost-scsi-pci.args => hostdev-vfio-multidomain.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-wrong-arch.err => hostdev-vfio-zpci-wrong-arch.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/hostdev-vfio.args rename tests/qemuxml2argvdata/{hostdev-vfio-multidomain.args => hostdev-vfio.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{hotplug-base.args => hotplug-base.x86_64-latest.args} (55%) rename tests/qemuxml2argvdata/{hugepages-default-1G-nodeset-2M.err => hugepages-default-1G-nodeset-2M.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hugepages-memaccess-invalid.err => hugepages-memaccess-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hugepages-memaccess3.err => hugepages-memaccess3.x86_64-5.1.0.err} (100%) delete mode 100644 tests/qemuxml2argvdata/input-usbmouse-addr.args create mode 100644 tests/qemuxml2argvdata/input-usbmouse-addr.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/input-usbmouse.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/input-usbtablet.args create mode 100644 tests/qemuxml2argvdata/input-usbtablet.x86_64-latest.args rename tests/qemuxml2argvdata/{kvm-pit-delay.args => kvm-pit-delay.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{kvm-pit-discard.args => kvm-pit-discard.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{kvmclock.args => kvmclock.x86_64-latest.args} (64%) delete mode 100644 tests/qemuxml2argvdata/machine-aliases1.args create mode 100644 tests/qemuxml2argvdata/machine-aliases1.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-host-passthrough-features.args => machine-aliases2.x86_64-latest.args} (61%) create mode 100644 tests/qemuxml2argvdata/machine-core-off.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/machine-core-on.args rename tests/qemuxml2argvdata/{balloon-device-period.args => machine-core-on.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{machine-loadparm-s390-char-invalid.err => machine-loadparm-s390-char-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{machine-loadparm-s390-len-invalid.err => machine-loadparm-s390-len-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/machine-vmport-opt.args create mode 100644 tests/qemuxml2argvdata/machine-vmport-opt.x86_64-latest.args rename tests/qemuxml2argvdata/{memory-align-fail.err => memory-align-fail.x86_64-latest.err} (100%) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-dimm.x86_64-latest.args rename tests/qemuxml2argvdata/{memory-hotplug-invalid-targetnode.err => memory-hotplug-invalid-targetnode.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{memory-hotplug-nonuma.err => memory-hotplug-nonuma.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/memory-hotplug.args rename tests/qemuxml2argvdata/{memory-hotplug-dimm.args => memory-hotplug.x86_64-latest.args} (58%) delete mode 100644 tests/qemuxml2argvdata/memtune-unlimited.args create mode 100644 tests/qemuxml2argvdata/memtune-unlimited.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/memtune.args create mode 100644 tests/qemuxml2argvdata/memtune.x86_64-latest.args rename tests/qemuxml2argvdata/{migrate-numa-unaligned.args => migrate-numa-unaligned.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{migrate.args => migrate.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{minimal-no-memory.err => minimal-no-memory.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/minimal.args create mode 100644 tests/qemuxml2argvdata/minimal.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/misc-acpi.args rename tests/qemuxml2argvdata/{balloon-device-deflate.args => misc-acpi.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{misc-disable-s3.args => misc-disable-s3.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{misc-disable-suspends.args => misc-disable-suspends.x86_64-latest.args} (65%) delete mode 100644 tests/qemuxml2argvdata/misc-enable-s4.err rename tests/qemuxml2argvdata/{misc-enable-s4.args => misc-enable-s4.x86_64-latest.args} (65%) delete mode 100644 tests/qemuxml2argvdata/misc-uuid.args rename tests/qemuxml2argvdata/{balloon-device-auto.args => misc-uuid.x86_64-latest.args} (64%) delete mode 100644 tests/qemuxml2argvdata/monitor-json.args delete mode 100644 tests/qemuxml2argvdata/multifunction-pci-device.args create mode 100644 tests/qemuxml2argvdata/multifunction-pci-device.x86_64-latest.args rename tests/qemuxml2argvdata/{nosharepages.args => nosharepages.x86_64-latest.args} (64%) delete mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-cpuset.args create mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-cpuset.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-no-cpuset-and-placement.args create mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-no-cpuset-and-placement.x86_64-latest.args rename tests/qemuxml2argvdata/{numad-auto-vcpu-static-numatune-no-nodeset.err => numad-auto-vcpu-static-numatune-no-nodeset.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/numad-auto-vcpu-static-numatune.args create mode 100644 tests/qemuxml2argvdata/numad-auto-vcpu-static-numatune.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numad-static-memory-auto-vcpu.args create mode 100644 tests/qemuxml2argvdata/numad-static-memory-auto-vcpu.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numad.args create mode 100644 tests/qemuxml2argvdata/numad.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numatune-auto-nodeset-invalid.args create mode 100644 tests/qemuxml2argvdata/numatune-auto-nodeset-invalid.x86_64-latest.args rename tests/qemuxml2argvdata/{numatune-auto-prefer.args => numatune-auto-prefer.x86_64-latest.args} (56%) rename tests/qemuxml2argvdata/{numatune-distances.args => numatune-distances.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{numatune-memnode-invalid-mode.err => numatune-memnode-invalid-mode.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{numatune-memnode-no-memory.args => numatune-memnode-no-memory.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{numatune-memnode-nocpu.err => numatune-memnode-nocpu.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/numatune-memnode.args rename tests/qemuxml2argvdata/{numatune-memnodes-problematic.err => numatune-memnodes-problematic.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{numatune-memory-invalid-nodeset.err => numatune-memory-invalid-nodeset.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/numatune-memory.args delete mode 100644 tests/qemuxml2argvdata/numatune-memory.xml rename tests/qemuxml2argvdata/{numatune-static-nodeset-exceed-hostnode.err => numatune-static-nodeset-exceed-hostnode.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/parallel-parport-chardev.args delete mode 100644 tests/qemuxml2argvdata/parallel-tcp-chardev.args delete mode 100644 tests/qemuxml2argvdata/pci-autoadd-addr.args create mode 100644 tests/qemuxml2argvdata/pci-autoadd-addr.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/pci-autoadd-idx.args create mode 100644 tests/qemuxml2argvdata/pci-autoadd-idx.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-autofill-addr.args => pci-autofill-addr.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{pci-bridge-duplicate-index.err => pci-bridge-duplicate-index.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-bridge-many-disks.args => pci-bridge-many-disks.x86_64-latest.args} (68%) rename tests/qemuxml2argvdata/{pci-bridge-negative-index-invalid.err => pci-bridge-negative-index-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pci-bridge.args create mode 100644 tests/qemuxml2argvdata/pci-bridge.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-bus-invalid.err => pci-bus-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-domain-invalid.err => pci-domain-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-expander-bus-bad-bus.err => pci-expander-bus-bad-bus.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-expander-bus-bad-machine.err => pci-expander-bus-bad-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-expander-bus-bad-node.err => pci-expander-bus-bad-node.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pci-expander-bus.args create mode 100644 tests/qemuxml2argvdata/pci-expander-bus.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-function-invalid.err => pci-function-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-many.args => pci-many.x86_64-latest.args} (67%) delete mode 120000 tests/qemuxml2argvdata/pci-rom-disabled-invalid.args create mode 120000 tests/qemuxml2argvdata/pci-rom-disabled-invalid.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-rom-disabled.args => pci-rom-disabled.x86_64-latest.args} (58%) create mode 100644 tests/qemuxml2argvdata/pci-rom.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-root-address.err => pci-root-address.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-root-nonzero-index.err => pci-root-nonzero-index.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pci-serial-dev-chardev.args rename tests/qemuxml2argvdata/{pci-slot-invalid.err => pci-slot-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pcie-expander-bus-bad-bus.err => pcie-expander-bus-bad-bus.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pcie-expander-bus-bad-machine.err => pcie-expander-bus-bad-machine.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pcie-expander-bus.args create mode 100644 tests/qemuxml2argvdata/pcie-expander-bus.x86_64-latest.args rename tests/qemuxml2argvdata/{pcie-root-port-model-ioh3420.args => pcie-root-port-model-generic.x86_64-latest.args} (51%) rename tests/qemuxml2argvdata/{pcie-root-port-model-generic.args => pcie-root-port-model-ioh3420.x86_64-latest.args} (55%) rename tests/qemuxml2argvdata/{pcie-root-port-too-many.err => pcie-root-port-too-many.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pcie-root-port.args => pcie-root-port.x86_64-latest.args} (53%) rename tests/qemuxml2argvdata/{pcie-root.args => pcie-root.x86_64-latest.args} (55%) delete mode 100644 tests/qemuxml2argvdata/pcie-switch-downstream-port.args create mode 100644 tests/qemuxml2argvdata/pcie-switch-downstream-port.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/pcie-switch-upstream-port.args create mode 100644 tests/qemuxml2argvdata/pcie-switch-upstream-port.x86_64-latest.args rename tests/qemuxml2argvdata/{pcihole64-q35.args => pcihole64-q35.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{pcihole64.args => pcihole64.x86_64-latest.args} (59%) rename tests/qemuxml2argvdata/{pmu-feature-off.args => pmu-feature-off.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{pmu-feature.args => pmu-feature.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{pseries-features-invalid-machine.err => pseries-features-invalid-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pseries-serial-invalid-machine.err => pseries-serial-invalid-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{q35-dmi-bad-address1.err => q35-dmi-bad-address1.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{q35-dmi-bad-address2.err => q35-dmi-bad-address2.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/q35-pci-force-address.args create mode 100644 tests/qemuxml2argvdata/q35-pci-force-address.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable-fallback.args delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable-fallback.xml delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable.args delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable.xml delete mode 100644 tests/qemuxml2argvdata/q35-usb2-multi.args create mode 100644 tests/qemuxml2argvdata/q35-usb2-multi.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/q35-usb2-reorder.args create mode 100644 tests/qemuxml2argvdata/q35-usb2-reorder.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/q35-usb2.x86_64-latest.args rename tests/qemuxml2argvdata/{q35-wrong-root.err => q35-wrong-root.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/q35.args rename tests/qemuxml2argvdata/{q35-usb2.args => q35.x86_64-latest.args} (51%) rename tests/qemuxml2argvdata/{qemu-ns-no-env.args => qemu-ns-alt.x86_64-latest.args} (61%) delete mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns0.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns0.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns1.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline-ns0.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline-ns0.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-ns0.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-ns0.x86_64-latest.args rename tests/qemuxml2argvdata/{qemu-ns-alt.args => qemu-ns-no-env.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{reboot-timeout-disabled.args => reboot-timeout-disabled.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{reboot-timeout-enabled.args => reboot-timeout-enabled.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{restore-v2-fd.args => restore-v2-fd.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{restore-v2.args => restore-v2.x86_64-latest.args} (65%) delete mode 100644 tests/qemuxml2argvdata/seclabel-dac-none.args create mode 100644 tests/qemuxml2argvdata/seclabel-dac-none.x86_64-latest.args rename tests/qemuxml2argvdata/{seclabel-device-duplicates.err => seclabel-device-duplicates.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{seclabel-device-relabel-invalid.err => seclabel-device-relabel-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-baselabel.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-baselabel.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-labelskip.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-labelskip.x86_64-latest.args rename tests/qemuxml2argvdata/{seclabel-dynamic-override.args => seclabel-dynamic-override.x86_64-latest.args} (63%) delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-relabel.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-relabel.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic.x86_64-latest.args rename tests/qemuxml2argvdata/{seclabel-multiple.err => seclabel-multiple.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/seclabel-none.args create mode 100644 tests/qemuxml2argvdata/seclabel-none.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-static-labelskip.args create mode 100644 tests/qemuxml2argvdata/seclabel-static-labelskip.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-static-relabel.args create mode 100644 tests/qemuxml2argvdata/seclabel-static-relabel.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-static.args create mode 100644 tests/qemuxml2argvdata/seclabel-static.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/serial-dev-chardev-iobase.args delete mode 100644 tests/qemuxml2argvdata/serial-dev-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-file-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-file-log.args delete mode 100644 tests/qemuxml2argvdata/serial-many-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-pty-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-spiceport.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-telnet-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-udp-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-vc-chardev.args create mode 100644 tests/qemuxml2argvdata/smartcard-controller.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates-database.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates.args create mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/smartcard-host.args create mode 100644 tests/qemuxml2argvdata/smartcard-host.x86_64-latest.args rename tests/qemuxml2argvdata/{smartcard-passthrough-spicevmc.args => smartcard-passthrough-spicevmc.x86_64-latest.args} (52%) rename tests/qemuxml2argvdata/{smartcard-passthrough-tcp.args => smartcard-passthrough-tcp.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{smbios-date.err => smbios-date.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{smbios-uuid-match.err => smbios-uuid-match.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{smbios.args => smbios.x86_64-latest.args} (70%) delete mode 100644 tests/qemuxml2argvdata/smp-dies.args delete mode 100644 tests/qemuxml2argvdata/smp.args rename tests/qemuxml2argvdata/{tpm-no-backend-invalid.err => tpm-no-backend-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-bus-missing.err => usb-bus-missing.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{clock-utc.args => usb-controller-default-i440fx.x86_64-latest.args} (59%) rename tests/qemuxml2argvdata/{usb-controller.xml => usb-controller-default-i440fx.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-default-isapc.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/usb-controller-default-isapc.xml rename tests/qemuxml2argvdata/{usb-controller-default-q35.args => usb-controller-default-q35.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{smartcard-controller.args => usb-controller-default-unavailable-i440fx.x86_64-latest.args} (63%) create mode 120000 tests/qemuxml2argvdata/usb-controller-default-unavailable-i440fx.xml rename tests/qemuxml2argvdata/{usb-controller-default-unavailable-q35.err => usb-controller-default-unavailable-q35.x86_64-latest.err} (100%) delete mode 120000 tests/qemuxml2argvdata/usb-controller-explicit-unavailable-q35.xml create mode 100644 tests/qemuxml2argvdata/usb-controller-ich9-autoassign.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ich9-autoassign.xml => usb-controller-ich9-autoassign.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-ich9-companion.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ich9-companion.xml => usb-controller-ich9-companion.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-ich9-ehci-addr.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ich9-ehci-addr.xml => usb-controller-ich9-ehci-addr.xml} (100%) rename tests/qemuxml2argvdata/{usb-ich9-no-companion.err => usb-controller-ich9-no-companion.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-ich9-no-companion.xml => usb-controller-ich9-no-companion.xml} (100%) rename tests/qemuxml2argvdata/{smartcard-host-certificates-database.args => usb-controller-implicit-i440fx.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{usb-controller-xhci.xml => usb-controller-implicit-i440fx.xml} (86%) rename tests/qemuxml2argvdata/{acpi-table.args => usb-controller-implicit-isapc.x86_64-latest.args} (67%) create mode 100644 tests/qemuxml2argvdata/usb-controller-implicit-isapc.xml create mode 100644 tests/qemuxml2argvdata/usb-controller-implicit-q35.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/usb-controller-implicit-q35.xml rename tests/qemuxml2argvdata/{usb-controller-xhci-limit.err => usb-controller-nec-xhci-limit.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-controller-xhci-limit.xml => usb-controller-nec-xhci-limit.xml} (100%) rename tests/qemuxml2argvdata/{usb-controller-explicit-unavailable-q35.err => usb-controller-nec-xhci-unavailable.x86_64-latest.err} (100%) create mode 120000 tests/qemuxml2argvdata/usb-controller-nec-xhci-unavailable.xml rename tests/qemuxml2argvdata/{usb-controller-explicit-q35.args => usb-controller-nec-xhci.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{usb-controller-explicit-q35.xml => usb-controller-nec-xhci.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-nex-xhci-autoassign.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-xhci-autoassign.xml => usb-controller-nex-xhci-autoassign.xml} (100%) rename tests/qemuxml2argvdata/{input-usbmouse.args => usb-controller-piix3.x86_64-latest.args} (59%) rename tests/qemuxml2argvdata/{usb-piix3-controller.xml => usb-controller-piix3.xml} (100%) rename tests/qemuxml2argvdata/{usb-controller-qemu-xhci-limit.err => usb-controller-qemu-xhci-limit.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-controller-qemu-xhci-unavailable.err delete mode 120000 tests/qemuxml2argvdata/usb-controller-qemu-xhci-unavailable.xml delete mode 100644 tests/qemuxml2argvdata/usb-controller-qemu-xhci.args rename tests/qemuxml2argvdata/{serial-unix-chardev.args => usb-controller-qemu-xhci.x86_64-latest.args} (63%) delete mode 100644 tests/qemuxml2argvdata/usb-controller-xhci.args delete mode 100644 tests/qemuxml2argvdata/usb-controller.args delete mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.args create mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd.args create mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-hub-conflict.err => usb-hub-conflict.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-hub-nonexistent.err => usb-hub-nonexistent.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-hub.args create mode 100644 tests/qemuxml2argvdata/usb-hub.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-ich9-autoassign.args delete mode 100644 tests/qemuxml2argvdata/usb-ich9-companion.args delete mode 100644 tests/qemuxml2argvdata/usb-ich9-ehci-addr.args delete mode 100644 tests/qemuxml2argvdata/usb-long-port-path.args create mode 100644 tests/qemuxml2argvdata/usb-long-port-path.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-none-hub.err => usb-none-hub.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-none-other.err => usb-none-other.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-none-usbtablet.err => usb-none-usbtablet.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-none.args create mode 100644 tests/qemuxml2argvdata/usb-none.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-port-autoassign.args create mode 100644 tests/qemuxml2argvdata/usb-port-autoassign.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-port-missing.args create mode 100644 tests/qemuxml2argvdata/usb-port-missing.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ports-out-of-range.err => usb-ports-out-of-range.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-ports.args create mode 100644 tests/qemuxml2argvdata/usb-ports.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-boot.args create mode 100644 tests/qemuxml2argvdata/usb-redir-boot.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-filter-version.args create mode 100644 tests/qemuxml2argvdata/usb-redir-filter-version.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-filter.args create mode 100644 tests/qemuxml2argvdata/usb-redir-filter.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir.args create mode 100644 tests/qemuxml2argvdata/usb-redir.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-too-long-port-path-invalid.err => usb-too-long-port-path-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-xhci-autoassign.args delete mode 100644 tests/qemuxml2argvdata/usb1-usb2.args create mode 100644 tests/qemuxml2argvdata/usb1-usb2.x86_64-latest.args rename tests/qemuxml2argvdata/{vhost_queues-invalid.err => vhost_queues-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/virtio-input-passthrough.args create mode 100644 tests/qemuxml2argvdata/virtio-input-passthrough.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/virtio-input.args create mode 100644 tests/qemuxml2argvdata/virtio-input.x86_64-latest.args rename tests/qemuxml2argvdata/{virtio-options-memballoon-freepage-reporting.err => virtio-options-memballoon-freepage-reporting.x86_64-5.0.0.err} (100%) delete mode 100644 tests/qemuxml2argvdata/virtio-rng-default.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-default.x86_64-latest.args rename tests/qemuxml2argvdata/{virtio-rng-egd-crash.err => virtio-rng-egd-crash.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{virtio-rng-egd.args => virtio-rng-egd.x86_64-latest.args} (54%) delete mode 100644 tests/qemuxml2argvdata/virtio-rng-multiple.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-multiple.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/virtio-rng-random.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-random.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/vmcoreinfo.args create mode 100644 tests/qemuxml2argvdata/vmcoreinfo.x86_64-latest.args rename tests/qemuxml2xmloutdata/{usb-controller.x86_64-latest.xml => usb-controller-default-i440fx.x86_64-latest.xml} (100%) rename tests/{qemuxml2argvdata/smp.xml => qemuxml2xmloutdata/usb-controller-default-unavailable-i440fx.x86_64-latest.xml} (57%) rename tests/qemuxml2xmloutdata/{usb-ich9-ehci-addr.x86_64-latest.xml => usb-controller-ich9-ehci-addr.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{smp.x86_64-latest.xml => usb-controller-implicit-i440fx.x86_64-latest.xml} (65%) rename tests/{qemuxml2argvdata/smp-dies.xml => qemuxml2xmloutdata/usb-controller-implicit-isapc.x86_64-latest.xml} (50%) create mode 100644 tests/qemuxml2xmloutdata/usb-controller-implicit-q35.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{usb-controller-explicit-q35.x86_64-latest.xml => usb-controller-nec-xhci.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{usb-piix3-controller.x86_64-latest.xml => usb-controller-piix3.x86_64-latest.xml} (100%) -- 2.41.0

3 58

[libvirt PATCH] rpm: Install client-qemu with main package
by Andrea Bolognani 06 Sep '23

06 Sep '23

The libvirt package is a sort of catch-all that brings in all daemon drivers as well as the client package, so it makes sense for it do drag in the QEMU-specific clients as well. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index b471afebb1..051cf886d6 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -249,6 +249,7 @@ Requires: libvirt-daemon-driver-lxc = %{version}-%{release} %endif %if %{with_qemu} Requires: libvirt-daemon-driver-qemu = %{version}-%{release} +Requires: libvirt-client-qemu = %{version}-%{release} %endif # We had UML driver, but we've removed it. Obsoletes: libvirt-daemon-driver-uml <= 5.0.0 -- 2.41.0

2 1

[PATCH] storage_util: Drop getDeviceType()
by Michal Privoznik 05 Sep '23

05 Sep '23

The sole purpose of getDeviceType() is to parse a file that contains one integer (and a newline character). Well, we already have a function for that: virFileReadValueInt(). Use the latter and drop the former. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/storage/storage_util.c | 75 ++++++++------------------------------ 1 file changed, 15 insertions(+), 60 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index bf8de2475d..7243308a02 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -3847,62 +3847,6 @@ getBlockDevice(uint32_t host, } -/* Function to check if the type file in the given sysfs_path is a - * Direct-Access device (i.e. type 0). Return -1 on failure, type of - * the device otherwise. - */ -static int -getDeviceType(uint32_t host, - uint32_t bus, - uint32_t target, - uint32_t lun, - int *type) -{ - char typestr[3]; - char *gottype, *p; - FILE *typefile; - g_autofree char *type_path = NULL; - - type_path = g_strdup_printf("/sys/bus/scsi/devices/%u:%u:%u:%u/type", host, - bus, target, lun); - - typefile = fopen(type_path, "r"); - if (typefile == NULL) { - virReportSystemError(errno, - _("Could not find typefile '%1$s'"), - type_path); - /* there was no type file; that doesn't seem right */ - return -1; - } - - gottype = fgets(typestr, 3, typefile); - VIR_FORCE_FCLOSE(typefile); - - if (gottype == NULL) { - virReportSystemError(errno, - _("Could not read typefile '%1$s'"), - type_path); - /* we couldn't read the type file; have to give up */ - return -1; - } - - /* we don't actually care about p, but if you pass NULL and the last - * character is not \0, virStrToLong_i complains - */ - if (virStrToLong_i(typestr, &p, 10, type) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Device type '%1$s' is not an integer"), - typestr); - /* Hm, type wasn't an integer; seems strange */ - return -1; - } - - VIR_DEBUG("Device type is %d", *type); - - return 0; -} - - /* * Process a Logical Unit entry from the scsi host device directory * @@ -3921,18 +3865,29 @@ processLU(virStoragePoolObj *pool, { int retval = -1; int device_type; + int rc; g_autofree char *block_device = NULL; VIR_DEBUG("Processing LU %u:%u:%u:%u", host, bus, target, lun); - if (getDeviceType(host, bus, target, lun, &device_type) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to determine if %1$u:%2$u:%3$u:%4$u is a Direct-Access LUN"), - host, bus, target, lun); + if ((rc = virFileReadValueInt(&device_type, + "/sys/bus/scsi/devices/%u:%u:%u:%u/type", + host, bus, target, lun)) < 0) { + + /* Report an error if file doesn't exist. Appropriate + * error was reported otherwise. */ + if (rc == -2) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to determine if %1$u:%2$u:%3$u:%4$u is a Direct-Access LUN"), + host, bus, target, lun); + } + return -1; } + VIR_DEBUG("Device type is %d", device_type); + /* We don't create volumes for devices other than disk and cdrom * devices, but finding a device that isn't one of those types * isn't an error, either. */ -- 2.41.0

2 1

[PATCH 0/3] ch: Couple of format directive fixes
by Michal Privoznik 05 Sep '23

05 Sep '23

*** BLURB HERE *** Michal Prívozník (3): ch: Use uint for @maxvcpus in virCHDomainRefreshThreadInfo() ch: Use int for @niothreads in virCHMonitorGetIOThreads() ch: Use proper format directive for @i in virCHProcessSetupIOThreads() src/ch/ch_domain.c | 4 ++-- src/ch/ch_monitor.c | 4 ++-- src/ch/ch_process.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) -- 2.41.0

2 4

[PATCH] fix virCgroupGetMemoryStat arguments order
by Dmitry Frolov 05 Sep '23

05 Sep '23

Reviewing the sources, I noticed that, argumets order in virCgroupGetMemoryStat() function call does not correspond to the function declaration: -instead of *activeAnon, &meminfo->inactive_anon is passed; -instead of *inactiveAnon, &meminfo->active_anon is passed; -instead of *activeFile, &meminfo->inactive_file is passed; -instead of *inactiveFile, &meminfo->active_file is passed. Fixes: e634c7cd0d ("lxc: Use virCgroupGetMemoryStat") Signed-off-by: Dmitry Frolov <frolov(a)swemel.ru> --- src/lxc/lxc_cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c index 1b516bba73..bc39b16928 100644 --- a/src/lxc/lxc_cgroup.c +++ b/src/lxc/lxc_cgroup.c @@ -130,10 +130,10 @@ static int virLXCCgroupGetMemStat(virCgroup *cgroup, { return virCgroupGetMemoryStat(cgroup, &meminfo->cached, - &meminfo->inactive_anon, &meminfo->active_anon, - &meminfo->inactive_file, + &meminfo->inactive_anon, &meminfo->active_file, + &meminfo->inactive_file, &meminfo->unevictable); } -- 2.34.1

2 1

[PATCH Libvirt v2 00/10] Support dirty page rate upper limit
by ~hyman 05 Sep '23

05 Sep '23

Hi, This is the latest version for the series, comparing with version 1, there are some key modifications has made inspired and suggested by Peter, see as follows: 1. Introduce XML for dirty limit persistent configuration 2. Merge the cancel API into the set API 3. Extend the domstats/virDomainListGetStats API for dirty limit information query 4. Introduce the virDomainModificationImpact flags to control the behavior of the API 5. Enrich the comments and docs about the feature and API The patch set introduce the new API virDomainSetVcpuDirtyLimit to allow upper Apps to set upper limits of dirty page rate for virtual CPUs, the corresponding virsh API as follows: # limit-dirty-page-rate <domain> <rate> [--vcpu <number>] \ [--config] [--live] [--current] We put the dirty limit persistent info with the "vcpus" element in domain XML and extend dirtylimit statistics for domGetStats: <domain> ... <vcpu current='2'>3</vcpu> <vcpus> <vcpu id='0' hotpluggable='no' dirty_limit='10' order='1'.../> <vcpu id='1' hotpluggable='yes' dirty_limit='10' order='2'.../> </vcpus> ... If --vcpu option is not passed in the virsh command, set all virtual CPUs; if rate is set to zero, cancel the upper limit. Examples: To set the dirty page rate upper limit 10 MB/s for all virtual CPUs in c81_node1, use: [root@srv2 my_libvirt]# virsh limit-dirty-page-rate c81_node1 --rate 10 --live Set dirty page rate limit 10(MB/s) for all virtual CPUs successfully [root@srv2 my_libvirt]# virsh dumpxml c81_node1 | grep dirty_limit <vcpu id='0' enabled='yes' hotpluggable='no' order='1' dirty_limit='10'/> <vcpu id='1' enabled='yes' hotpluggable='no' order='2' dirty_limit='10'/> <vcpu id='2' enabled='yes' hotpluggable='no' order='3' dirty_limit='10'/> <vcpu id='3' enabled='no' hotpluggable='yes' dirty_limit='10'/> <vcpu id='4' enabled='no' hotpluggable='yes' dirty_limit='10'/> ...... Query the dirty limit info dynamically: [root@srv2 my_libvirt]# virsh domstats c81_node1 --dirtylimit Domain: 'c81_node1' dirtylimit.vcpu.0.limit=10 dirtylimit.vcpu.0.current=0 dirtylimit.vcpu.1.limit=10 dirtylimit.vcpu.1.current=0 dirtylimit.vcpu.2.limit=10 dirtylimit.vcpu.2.current=0 dirtylimit.vcpu.3.limit=10 dirtylimit.vcpu.3.current=0 dirtylimit.vcpu.4.limit=10 dirtylimit.vcpu.4.current=0 ...... To cancel the upper limit, use: [root@srv2 my_libvirt]# virsh limit-dirty-page-rate c81_node1 \ --rate 0 --live Cancel dirty page rate limit for all virtual CPUs successfully [root@srv2 my_libvirt]# virsh dumpxml c81_node1 | grep dirty_limit [root@srv2 my_libvirt]# virsh domstats c81_node1 --dirtylimit Domain: 'c81_node1' The dirty limit uses the QEMU dirty-limit feature introduced since 7.1.0, this feature allows CPU to be throttled as needed to keep their dirty page rate within the limit. It could, in some scenes, be used to provide quality-of-service in the aspect of the memory workload for virtual CPUs and QEMU itself use the feature to implement the dirty-limit throttle algorithm and apply it on the live migration, which improve responsiveness of large guests during live migration and can result in more stable read performance. The other application scenarios remain unexplored, before that, Libvirt could provide the basic API. Please review, thanks Yong Hyman Huang(黄勇) (10): qemu_capabilities: Introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability conf: Introduce XML for dirty limit configuration libvirt: Add virDomainSetVcpuDirtyLimit API qemu_driver: Implement qemuDomainSetVcpuDirtyLimit domain_validate: Export virDomainDefHasDirtyLimitStartupVcpus symbol qemu_process: Setup dirty limit after launching VM virsh: Introduce limit-dirty-page-rate api qemu_monitor: Implement qemuMonitorQueryVcpuDirtyLimit qemu_driver: Extend dirtlimit statistics for domGetStats virsh: Introduce command 'virsh domstats --dirtylimit' docs/formatdomain.rst | 7 +- docs/manpages/virsh.rst | 33 +++- include/libvirt/libvirt-domain.h | 5 + src/conf/domain_conf.c | 26 +++ src/conf/domain_conf.h | 8 + src/conf/domain_validate.c | 33 ++++ src/conf/domain_validate.h | 2 + src/conf/schemas/domaincommon.rng | 5 + src/driver-hypervisor.h | 7 + src/libvirt-domain.c | 68 +++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 5 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 181 ++++++++++++++++++ src/qemu/qemu_monitor.c | 25 +++ src/qemu/qemu_monitor.h | 22 +++ src/qemu/qemu_monitor_json.c | 107 +++++++++++ src/qemu/qemu_monitor_json.h | 9 + src/qemu/qemu_process.c | 44 +++++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 +- src/remote_protocol-structs | 7 + .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + tools/virsh-domain-monitor.c | 7 + tools/virsh-domain.c | 109 +++++++++++ 34 files changed, 737 insertions(+), 4 deletions(-) -- 2.38.5

3 15

[PATCH 0/8] Finish effort to decrease maximum stack frame to 2048
by Peter Krempa 05 Sep '23

05 Sep '23

Few outstanding patches of code compiled only on FreeBSD Pipeline: https://gitlab.com/pipo.sk/libvirt/-/pipelines/986470469 Peter Krempa (8): bhyve: Don't stack-allocate huge error buffers virHostValidateBhyve: Declare one variable per line virHostValidateBhyve: Heap allocate massive 'struct kld_file_stat' nss: aiforaf: Format one argument/variable per line nss: aiforaf: Remove unused 'ret' variable nss: aiforaf: Drop unused buffer 'port' nss: aiforaf: Decrease stack size by scoping off large buffers. build: Decrease maximum stack frame size to 2048 meson.build | 2 +- src/bhyve/bhyve_process.c | 4 +- tools/nss/libvirt_nss.c | 105 ++++++++++++++++++------------- tools/virt-host-validate-bhyve.c | 20 +++--- 4 files changed, 74 insertions(+), 57 deletions(-) -- 2.41.0

4 24

Pure Python binding?
by Philipp Hahn 05 Sep '23

05 Sep '23

Hello, "pip install libvirt-python" does not work in several cases as that requires the low-level C library, compilers, tools, and Python header files to be installed. This prevents the use of "libvirt" in scenarios, where "root" privileges are not available to install these dependencies, e.g. running "libvirt" inside a JupyterHub notebook for gathering statistics. This also breaks the adoption on Windows, see <https://gitlab.com/libvirt/libvirt-python/-/issues/7> and <https://gitlab.com/libvirt/libvirt-python/-/issues/6> Looking at <https://libvirt.org/bindings.html> and <https://gitlab.com/libvirt> I only see "bindings" for the low-level C library. Does someone know of a "pure Python binding" for talking to a remote "libvirtd", either via "+ssh" or "+tls"? Or is there another "trick" to talk to libvirtd? And no, parsing the output of subprocess.run("ssh ... virsh ...") is not an option ;-) Philipp -- Philipp Hahn Open Source Software Engineer Univention GmbH Mary-Somerville-Str. 1 28359 Bremen Germany | Deutschland Phone: +49 (0)421 22232-0 | E-Mail: info(a)univention.de https://www.univention.de | https://www.univention.com Managing Directors: Peter H. Ganten, Stefan Gohmann Local court: Amtsgericht Bremen HRB 20755 | Ust-ID: DE220051310

2 1

[PATCH] conf: Generate MAC address instead of keeping all zeroes
by Martin Kletzander 04 Sep '23

04 Sep '23

When we parse <mac address="00:00:00:00:00:00"/> we keep that in memory and pass it down to the hypervisor. However, that MAC address is not strictly valid as it is not marked as locally administered (bit 0x02) but it is not even globally unique. It is also used for loopback device on Linux, for example. And QEMU sees such MAC address just as "not specified" and generates a new one that libvirt does not even know about. So to make the overall experience better we now generate it if the supplied one is all clear. Resolves: https://issues.redhat.com/browse/RHEL-974 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/domain_conf.c | 2 +- src/util/virmacaddr.c | 5 +++++ src/util/virmacaddr.h | 1 + .../network-interface-mac-clear.xml | 21 +++++++++++++++++++ .../network-interface-mac-clear.xml | 21 +++++++++++++++++++ tests/genericxml2xmltest.c | 4 +++- 6 files changed, 52 insertions(+), 2 deletions(-) create mode 100644 tests/genericxml2xmlindata/network-interface-mac-clear.xml create mode 100644 tests/genericxml2xmloutdata/network-interface-mac-clear.xml diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index bb4f1fdb948d..652bd09b21b8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9675,7 +9675,7 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, return NULL; } - if (!macaddr) { + if (!macaddr || virMacAddrIsAllClear(&def->mac)) { virDomainNetGenerateMAC(xmlopt, &def->mac); def->mac_generated = true; } diff --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c index 073f298b5b66..e06bb200fc68 100644 --- a/src/util/virmacaddr.c +++ b/src/util/virmacaddr.c @@ -246,6 +246,11 @@ virMacAddrIsBroadcastRaw(const unsigned char s[VIR_MAC_BUFLEN]) return memcmp(virMacAddrBroadcastAddrRaw, s, sizeof(*s)) == 0; } +bool virMacAddrIsAllClear(const virMacAddr *addr) +{ + return !virMacAddrCmpRaw(addr, (const unsigned char[VIR_MAC_BUFLEN]){0}); +} + void virMacAddrFree(virMacAddr *addr) { diff --git a/src/util/virmacaddr.h b/src/util/virmacaddr.h index f32b58805a61..7b9eb7443bd1 100644 --- a/src/util/virmacaddr.h +++ b/src/util/virmacaddr.h @@ -58,6 +58,7 @@ int virMacAddrParseHex(const char* str, bool virMacAddrIsUnicast(const virMacAddr *addr); bool virMacAddrIsMulticast(const virMacAddr *addr); bool virMacAddrIsBroadcastRaw(const unsigned char s[VIR_MAC_BUFLEN]); +bool virMacAddrIsAllClear(const virMacAddr *addr); void virMacAddrFree(virMacAddr *addr); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virMacAddr, virMacAddrFree); diff --git a/tests/genericxml2xmlindata/network-interface-mac-clear.xml b/tests/genericxml2xmlindata/network-interface-mac-clear.xml new file mode 100644 index 000000000000..41beda8a79bb --- /dev/null +++ b/tests/genericxml2xmlindata/network-interface-mac-clear.xml @@ -0,0 +1,21 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <interface type='bridge'> + <mac address='00:00:00:00:00:00'/> + <source bridge='br0'/> + </interface> + </devices> +</domain> diff --git a/tests/genericxml2xmloutdata/network-interface-mac-clear.xml b/tests/genericxml2xmloutdata/network-interface-mac-clear.xml new file mode 100644 index 000000000000..a7935fa9f4de --- /dev/null +++ b/tests/genericxml2xmloutdata/network-interface-mac-clear.xml @@ -0,0 +1,21 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='x86_64' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <interface type='bridge'> + <mac address='52:54:00:00:00:00'/> + <source bridge='br0'/> + </interface> + </devices> +</domain> diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 3501eadf5597..bf160b7e0bef 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -187,6 +187,7 @@ mymain(void) DO_TEST("cpu-cache-disable"); DO_TEST("network-interface-mac-check"); + DO_TEST_DIFFERENT("network-interface-mac-clear"); DO_TEST_DIFFERENT("chardev-tcp"); DO_TEST_FAIL_ACTIVE("chardev-tcp-missing-host"); @@ -255,4 +256,5 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIR_TEST_MAIN(mymain) +VIR_TEST_MAIN_PRELOAD(mymain, + VIR_TEST_MOCK("virrandom")) -- 2.42.0

2 2

[PATCH (pushed)] build: Fix logic bug determining whether running with optimization
by Peter Krempa 04 Sep '23

04 Sep '23

The conversion from ternary to a 'if' clause was wrong and thus didn't properly increase the stack size where needed but only where not actually needed. Fixes: b68faa99d9f16c2f504b23737040d25d072ee85d Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index e0ee4f2f21..3bf15d93a4 100644 --- a/meson.build +++ b/meson.build @@ -255,7 +255,7 @@ if cc.get_id() == 'clang' and get_option('optimization') == '0' endif # sanitizer instrumentation may enlarge stack frames -if get_option('b_sanitize') == 'none' +if get_option('b_sanitize') != 'none' stack_frame_size = 32768 endif -- 2.41.0

1 0

[PATCH (pushed)] build: Fix assignment into 'stack_frame_size' when sanitizer is enabled
by Peter Krempa 04 Sep '23

04 Sep '23

Instead of an assignment into the 'stack_frame_size' variable when sanitizers are enabled I've accidentally compared the value against the requested size. Fix the typo. Fixes: b68faa99d9f16c2f504b23737040d25d072ee85d Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d29761bc71..e0ee4f2f21 100644 --- a/meson.build +++ b/meson.build @@ -256,7 +256,7 @@ endif # sanitizer instrumentation may enlarge stack frames if get_option('b_sanitize') == 'none' - stack_frame_size == 32768 + stack_frame_size = 32768 endif # array_bounds=2 check triggers false positive on some GCC -- 2.41.0

1 0

[PATCH 0/2] build: Fix build with clang without optimization
by Peter Krempa 04 Sep '23

04 Sep '23

Add a note for users how optimization is supposed to be controled with meson and fix the build by using 4k stack flame on clang without optimization. Peter Krempa (2): docs: compiling: Add a note about use of CFLAGS for optimization build: Work around clang's stack size calculation without optimization docs/compiling.rst | 5 +++++ meson.build | 11 ++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) -- 2.41.0

2 4

[PATCH] Revert "build: Decrease maximum stack frame size to 2048"
by Peter Krempa 04 Sep '23

04 Sep '23

Build fails with this patch with 'clang' when optimizations are disabled in long functions which have many helper variables declared in nested blocks such as for-loops. As there is no clean solution for now, let's keep the stack frame size at 4k. This reverts commit 42bc76cdb8486ef502200f3bce9e3faebdd78103. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6b6f7ccb7c..dd7a4e8d34 100644 --- a/meson.build +++ b/meson.build @@ -248,7 +248,7 @@ alloc_max = run_command( ) # sanitizer instrumentation may enlarge stack frames -stack_frame_size = get_option('b_sanitize') == 'none' ? 2048 : 32768 +stack_frame_size = get_option('b_sanitize') == 'none' ? 4096 : 32768 # array_bounds=2 check triggers false positive on some GCC # versions when using sanitizers. Seen on Fedora 34 with -- 2.41.0

2 1

[PATCH 0/2] syntax-check: Introduce a rule for one line error messages
by Michal Privoznik 04 Sep '23

04 Sep '23

This is a follow up of: https://listman.redhat.com/archives/libvir-list/2023-August/241416.html And while the regular expression in patch 2/2 is very trivial it mostly works. But I'm open for suggestions. Michal Prívozník (2): tools: Reformat --help output of virsh and virt-admin syntax-check: Introduce a rule for one line error messages build-aux/syntax-check.mk | 8 ++++++++ tools/virsh.c | 6 ++++-- tools/virt-admin.c | 6 ++++-- 3 files changed, 16 insertions(+), 4 deletions(-) -- 2.41.0

2 5

[PATCH] docs, passt: Clarify some niche passt usage
by Martin Kletzander 04 Sep '23

04 Sep '23

Change example logfile path and clarify how complicated all things passt are. I chose not to create the non-existing directory because it could open a whole new can of worms. Also explain missing `dev` attribute of `<portForward/>` Resolves: https://issues.redhat.com/browse/RHEL-1833 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- docs/formatdomain.rst | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 68f54ab3ed62..bc469e5f9f94 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4902,14 +4902,23 @@ When the passt backend is used, the ``<backend>`` attribute ``logFile`` can be used to tell the passt process for this interface where to write its message log, and the ``<source>`` attribute ``dev`` can tell it to use a particular host interface to derive the routes -given to the guest for forwarding traffic upstream. +given to the guest for forwarding traffic upstream. Due to the design +decisions of passt, if using SELinux, the log file is recommended to +reside in the runtime directory of a user under which the passt +process will run, most probably ``/run/user/$UID`` where ``$UID`` is +the UID of the user, e.g. ``qemu``. Beware that libvirt does not +create this directory if it does not already exist to avoid possible, +however unlikely, issues, especially since this logfile attribute is +meant mostly for debugging. Additionally, when passt is used, multiple ``<portForward>`` elements can be added to forward incoming network traffic for the host to this guest interface. Each ``<portForward>`` must have a ``proto`` -attribute (set to ``tcp`` or ``udp``) and optional original -``address`` (if not specified, then all incoming sessions to any host -IP for the given proto/port(s) will be forwarded to the guest). +attribute (set to ``tcp`` or ``udp``), optional original ``address`` +(if not specified, then all incoming sessions to any host IP for the +given proto/port(s) will be forwarded to the guest), and an optional +``dev`` attribute to limit the forwarded traffic to a specific host +interface. The decision of which ports to forward is described with zero or more ``<range>`` subelements of ``<portForward>`` (if there is no @@ -4934,7 +4943,7 @@ ports **with the exception of some subset**. <devices> ... <interface type='user'> - <backend type='passt' logFile='/tmp/passt.log'/> + <backend type='passt' logFile='/run/user/$UID/passt-domain.log'/> <mac address="00:11:22:33:44:55"/> <source dev='eth0'/> <ip family='ipv4' address='172.17.2.4' prefix='24'/> @@ -4946,7 +4955,7 @@ ports **with the exception of some subset**. <range start='5000' end='5020' to='6000'/> <range start='5010' end='5015' exclude='yes'/> </portForward> - <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'> + <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10' dev='eth0'> <range start='80'/> <range start='443' to='344'/> </portForward> -- 2.41.0

2 1

[PATCH] conf, schema: Switch iothread/poll values to unsignedLong
by Martin Kletzander 04 Sep '23

04 Sep '23

They represent nanoseconds, and we accept such values already. Not that anyone would use such values in the wild, but even one person testing QEMU could put in a bigger value and will be bothered with validation errors after every `virsh edit`. Also add a test for it. Resolves: https://issues.redhat.com/browse/RHEL-1717 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/schemas/domaincommon.rng | 6 +++--- tests/genericxml2xmlindata/iothreadids.xml | 23 ++++++++++++++++++++++ tests/genericxml2xmltest.c | 2 ++ 3 files changed, 28 insertions(+), 3 deletions(-) create mode 100644 tests/genericxml2xmlindata/iothreadids.xml diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng index de3bd1c35c55..2f9ba31c0aec 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -876,17 +876,17 @@ <element name="poll"> <optional> <attribute name="max"> - <ref name="unsignedInt"/> + <ref name="unsignedLong"/> </attribute> </optional> <optional> <attribute name="grow"> - <ref name="unsignedInt"/> + <ref name="unsignedLong"/> </attribute> </optional> <optional> <attribute name="shrink"> - <ref name="unsignedInt"/> + <ref name="unsignedLong"/> </attribute> </optional> </element> diff --git a/tests/genericxml2xmlindata/iothreadids.xml b/tests/genericxml2xmlindata/iothreadids.xml new file mode 100644 index 000000000000..671a4672958d --- /dev/null +++ b/tests/genericxml2xmlindata/iothreadids.xml @@ -0,0 +1,23 @@ +<domain type='kvm'> + <name>foo</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <iothreads>1</iothreads> + <iothreadids> + <iothread id='8' thread_pool_min='2147483647' thread_pool_max='2147483647'> + <poll max='9223372036854775807' grow='456' shrink='789'/> + </iothread> + </iothreadids> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + </devices> +</domain> diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 3501eadf5597..ce8073e85a30 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -249,6 +249,8 @@ mymain(void) DO_TEST("cpu-phys-bits-emulate"); DO_TEST("cpu-phys-bits-passthrough"); + DO_TEST("iothreadids"); + virObjectUnref(caps); virObjectUnref(xmlopt); -- 2.41.0

2 2

[libvirt PATCH 00/33] ci: Unify the GitLab CI jobs with local executions && adopt lcitool container executions
by Erik Skultety 01 Sep '23

01 Sep '23

Technically a v2 of: https://listman.redhat.com/archives/libvir-list/2023-February/237552.html However, the approach here is slightly different and what that series said about migration to lcitool container executions as a replacement for ci/Makefile is actually done here. One of the core problems of the above pointed out in review was that more Shell logic was introduced including CLI parsing, conditional executions, etc. which we fought hard to get rid of in the past. I reworked the Shell functions quite a bit and dropped whatever extra Shell logic the original series added. Obviously we can't get rid of Shell completely because of .gitlab-ci.yml and so I merely extracted the recipes into functions which are then sourced as ci/build.sh and executed. Now, that on its own would hide the actual commands being run in the GitLab job log, so before any command is actually executed, it is formatted with a color sequence so we don't miss that information as that would be a regression to the status quo. Lastly, this series then takes the effort inside the ci/build.sh script and basically mirrors whatever GitLab would do to run a job inside a local container which is executed by lcitool (yes, we already have that capability). Please give this a try and I'm already looking forward to comments as I'd like to expand this effort to local VM executions running the TCK integration tests, so this series is quite important in that regard. Erik Skultety (33): ci: build.sh: Add variables from .gitlab-ci.yml ci: build.sh: Add GIT_ROOT env helper variable ci: build.sh: Don't mention that MESON_ARGS are available via CLI ci: build.sh: Add a wrapper function over meson's setup ci: build.sh: Add a wrapper function executing 'shell' commands ci: build.sh: Add a wrapper function over the 'build' job ci: build.sh: Add a helper function to create the dist tarball ci: build.sh: Add a wrapper function over the 'test' job ci: build.sh: Add a wrapper function over the 'codestyle' job ci: build.sh: Add a wrapper function over the 'potfile' job ci: build.sh: Add a wrapper function over the 'rpmbuild' job ci: build.sh: Add a wrapper function over the 'website' job ci: build.sh: Drop changing working directory to CI_CONT_DIR ci: build.sh: Drop direct invocation of meson/ninja commands ci: build.sh: Drop MESON_ARGS definition from global level gitlab-ci.yml: Add 'after_script' stage to prep for artifact collection .gitlab-ci.yml: Convert the native build job to the build.sh usage .gitlab-ci.yml: Convert the cross build job to the build.sh usage .gitlab-ci.yml: Convert the website build job to the build.sh usage .gitlab-ci.yml: Convert the codestyle job to the build.sh usage .gitlab-ci.yml: Convert the potfile job to the build.sh usage ci: helper: Drop _lcitool_get_targets method ci: helper: Don't make ':' literal a static part of the image tag ci: helper: Add --lcitool-path CLI option ci: helper: Add a job argparse subparser ci: helper: Add a required_deps higher order helper/decorator ci: helper: Add Python code hangling git clones ci: helper: Add a helper to create a local repo clone Pythonic way ci: helper: Rework _lcitool_run method logic ci: helper: Add an action to run the container workload via lcitool ci: helper: Drop original actions ci: helper: Drop the --meson-args/--ninja-args CLI options ci: helper: Drop the _make_run method .gitlab-ci.yml | 47 +++++++------ ci/build.sh | 105 +++++++++++++++++++++++++---- ci/helper | 176 ++++++++++++++++++++++++++++--------------------- 3 files changed, 218 insertions(+), 110 deletions(-) -- 2.41.0

2 83