January 2023 - Devel - libvirt List Archives

[PATCH V2 0/2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef
by Jiang Jiacheng 24 Jan '23

24 Jan '23

Define and use g_autoptr() for virNWFilterDef and virNWFilterRuleDef, and remove unnecessary label/variable. Those patches are followup with: https://gitlab.com/libvirt/libvirt/-/commit/a9027d447be789cd11c0aa18ceb83ed… diff to v1: * drop two changes that may cause memory leaks in 'nwfilterDefineXMLFlags' and 'virNWFilterObjListLoadConfig' Jiang Jiacheng (2): conf: define g_autoptr for virNWFilterDef and virNWFilterRuleDef src/tests: use g_autoptr for virNWFilterDef and virNWFilterRuleDef src/conf/nwfilter_conf.c | 44 +++++++++++++++---------------------- src/conf/nwfilter_conf.h | 2 ++ tests/nwfilterxml2xmltest.c | 22 +++++++------------ 3 files changed, 28 insertions(+), 40 deletions(-) -- 2.33.0

3 5

[PATCH 0/5] Credential asking cleanup follow-up
by Peter Krempa 23 Jan '23

23 Jan '23

Few things noticed during review and during fixing of the original patches after review. Peter Krempa (5): util: authconfig: Don't check return value of 'g_key_file_new()' virNetSSHSessionAuthAddPasswordAuth: Don't access unlocked 'sess' virnetsshsession: Don't check return value of 'virNetSSHSessionAuthMethodNew' virNetLibsshSessionAuthAddPasswordAuth: Don't access unlocked 'sess' virnetlibsshsession: Don't check return value of 'virNetLibsshSessionAuthMethodNew' src/rpc/virnetlibsshsession.c | 50 ++++++++--------------------------- src/rpc/virnetsshsession.c | 41 +++++++--------------------- src/util/virauthconfig.c | 8 ++---- 3 files changed, 23 insertions(+), 76 deletions(-) -- 2.38.1

2 6

[PATCH 0/2] vbox: Two simple fixes
by Michal Privoznik 23 Jan '23

23 Jan '23

I've notice these while working on adding support for 7.0 API. Michal Prívozník (2): vbox: Fix memleak in _virtualboxCreateMachine() vbox: Fix starting domains src/vbox/vbox_common.c | 13 ++++++------- src/vbox/vbox_tmpl.c | 1 + 2 files changed, 7 insertions(+), 7 deletions(-) -- 2.39.1

3 9

[PATCH v2 0/3] qemu: Provide virDomainGetCPUStats() implementation for session connection
by Michal Privoznik 23 Jan '23

23 Jan '23

v2 of: https://listman.redhat.com/archives/libvir-list/2023-January/237113.html diff to v1: - Make virProcessGetStatInfo() return an error, per Martin's review Michal Prívozník (3): src: Don't use virReportSystemError() on virProcessGetStatInfo() failure virprocess: Make virProcessGetStatInfo() fail if unable to parse data qemu: Provide virDomainGetCPUStats() implementation for session connection src/ch/ch_driver.c | 4 +-- src/qemu/qemu_driver.c | 67 +++++++++++++++++++++++++++++++++++------- src/util/virprocess.c | 28 +++++------------- 3 files changed, 65 insertions(+), 34 deletions(-) -- 2.38.2

3 9

[PATCH 0/2] qemu_interface: Fix managed='no' case when creating an ethernet interface
by Michal Privoznik 23 Jan '23

23 Jan '23

*** BLURB HERE *** Michal Prívozník (2): virnetdevtap: Clarify virNetDevTapCreate() behavior wrt VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING qemu_interface: Fix managed='no' case when creating an ethernet interface src/qemu/qemu_interface.c | 5 +++-- src/util/virnetdevtap.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.39.1

2 3

KubeVirt with libvirt 9.0.0: Requested operation is not valid: The tap0 interface already exists
by Vasily Ulyanov 23 Jan '23

23 Jan '23

Hi All, I am now trying to run our downstream KubeVirt build with a recent libvirt 9.0.0 and I see a problem that libvirt refuses to start a VM if it is configured to use a pre-created tap device: virError(Code=55, Domain=0, Message='Requested operation is not valid: The tap0 interface already exists') After looking at the git history I found the bellow commit [1] which explicitly forbids such a usecase. This basically breaks KubeVirt since libvirt there runs unprivileged and can only use the existing tap's. I haven't yet look deeper into the original issue linked to the commit. Just wanted to raise this here first. Perhaps someone can provide feedback on that. What about some alternative approach instead? Or maybe it was discussed already... BTW, I tested with the reverted commit and it was successful. [1] https://gitlab.com/libvirt/libvirt/-/commit/a2ae3d299cf9c5ada8aa42ec4271748… -- Vasily Ulyanov <vulyanov(a)suse.de> Software Engineer, SUSE Labs Core

3 3

[libvirt PATCH] conf: clarify some external TPM error messages
by Ján Tomko 23 Jan '23

23 Jan '23

Two of the messages referred to 'backend type' when dealing with the source type and one mentioned the 'client' attribute from an earlier iteration of the patches, even though the attribute was later changed to 'connect'. https://bugzilla.redhat.com/show_bug.cgi?id=2063723 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_validate.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 45965fa0fa..733399e6da 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10545,7 +10545,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, case VIR_DOMAIN_TPM_TYPE_EXTERNAL: if (!(type = virXPathString("string(./backend/source/@type)", ctxt))) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("missing external TPM backend type")); + _("missing external TPM backend source type")); goto error; } @@ -10555,7 +10555,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, def->data.external.source->type = virDomainChrTypeFromString(type); if (def->data.external.source->type < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unknown backend type '%s' for external TPM"), + _("unknown backend source type '%s' for external TPM"), type); goto error; } diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 39d924d4ed..1c13929281 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2757,7 +2757,7 @@ virDomainTPMDevValidate(const virDomainTPMDef *tpm) } if (tpm->data.external.source->data.nix.listen) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("only 'client' mode is supported for external TPM device")); + _("only 'connect' mode is supported for external TPM device")); return -1; } if (tpm->data.external.source->data.nix.path == NULL) { -- 2.39.0

2 1

[PATCH] docs: fix passt example
by Laine Stump 20 Jan '23

20 Jan '23

Somehow I neglected to fully update the example for the interface passt backend when the design changed during development. This fixes the example to reflect what is in the code. Signed-off-by: Laine Stump <laine(a)redhat.com> --- docs/formatdomain.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index f76c7c3d81..9c6843e082 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4858,18 +4858,18 @@ ports **with the exception of some subset**. <backend type='passt' logFile='/var/log/passt.log'/> <mac address="00:11:22:33:44:55"/> <source dev='eth0'/> - <ip family='ipv4' address='172.17.2.0' prefix='24'/> - <ip family='ipv6' address='2001:db8:ac10:fd01::' prefix='64'/> - <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10' start='2022'> - <port start='22'/> + <ip family='ipv4' address='172.17.2.4' prefix='24'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::20'/> + <portForward proto='tcp'> + <range start='2022' to='22'/> </portForward> - <portForward proto='udp' address='1.2.3.4' start='5000' end='5020'> - <port start='6000' end='6020'/> + <portForward proto='udp' address='1.2.3.4'> + <range start='5000' end='5020' to='6000'/> + <range start='5010' end='5015' exclude='yes'/> </portForward> - <portForward exclude='yes' proto='tcp' address='1.2.3.4' start='5010' end='5015'/> - <portForward proto='tcp' start='80'/> - <portForward proto='tcp' start='443'> - <port start='344'/> + <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'>> + <range start='80'/> + <range start='443' to='344'/> </portForward> </interface> </devices> -- 2.38.1

2 1

[PATCH 0/3] migration: add qemu multifd migration options
by Jiang Jiacheng 19 Jan '23

19 Jan '23

Add qemu multifd migration options to set multifd-compression multifd-zlib-level and multifd-zstd-level. Jiang Jiacheng (3): Add public API for parallel compression method qemu: Add qemu parallel migration parameters virsh: Add options for multifd migration compression docs/manpages/virsh.rst | 11 +++++++-- include/libvirt/libvirt-domain.h | 30 ++++++++++++++++++++++++ src/qemu/qemu_migration.h | 3 +++ src/qemu/qemu_migration_params.c | 29 +++++++++++++++++++++++- src/qemu/qemu_migration_params.h | 3 +++ tools/virsh-domain.c | 39 ++++++++++++++++++++++++++++++++ 6 files changed, 112 insertions(+), 3 deletions(-) -- 2.33.0

3 10

[libvirt PATCH 0/2] ci: address more failing CI jobs
by Daniel P. Berrangé 19 Jan '23

19 Jan '23

Daniel P. Berrangé (2): ci: treat centos-stream9 as non-gating job ci: remove non-existant 'containers: false' key usage ci/gitlab/builds.yml | 64 ++++++++++++++++++++-------------------- ci/gitlab/containers.yml | 32 ++++++++++---------- ci/manifest.yml | 31 +++++++++---------- 3 files changed, 64 insertions(+), 63 deletions(-) -- 2.39.0

2 3