June 2022 - Devel - libvirt List Archives

[PATCH 0/3] qemu: add an API for "query-stats" QMP command
by Amneesh Singh 30 Jun '22

30 Jun '22

QEMU is gaining introspectable statistics which can be queried via the "query-stats" QMP command. This patchset aims to add an API for the same. The returned JSON for "query-stats" is an array of objects containing their own respective array of statistics. Patch 1 adds the API which returns the deserialized JSON in the form of a GPtrArray of GHashTables. Patch 2 adds the "query-stats" to QEMU capabilities. Patch 3 uses the API to query the halt poll success time and the halt poll failure time. Relevant QEMU patches can be found here: https://lore.kernel.org/all/20220523150509.349412-1-pbonzini@redhat.com/ This patchset is part of the 2022 GSOC contributor project. All reviews and comments are appreciated :). Amneesh Singh (3): qemu_monitor: add qemuMonitorQueryStats qemu_capabilities: add "query-stats" QMP command to the QEMU capabilities qemu_driver: use qemuMonitorQueryStats to extract halt poll time src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 48 +++++++++++-- src/qemu/qemu_monitor.c | 46 +++++++++++++ src/qemu/qemu_monitor.h | 36 ++++++++++ src/qemu/qemu_monitor_json.c | 128 +++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 6 ++ 7 files changed, 263 insertions(+), 4 deletions(-) -- 2.36.1

3 11

[libvirt PATCH 0/4] qemu_migration: Apply max-postcopy-bandwidth on post-copy resume
by Jiri Denemark 30 Jun '22

30 Jun '22

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/333 Jiri Denemark (4): qemu: Pass migration flags to qemuMigrationParamsApply qemu_migration_params: Replace qemuMigrationParamTypes array qemu_migration: Pass migParams to qemuMigrationSrcResume qemu_migration: Apply max-postcopy-bandwidth on post-copy resume src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_migration.c | 26 ++++-- src/qemu/qemu_migration_params.c | 131 ++++++++++++++++++--------- src/qemu/qemu_migration_params.h | 3 +- src/qemu/qemu_migration_paramspriv.h | 3 +- tests/qemumigparamstest.c | 2 +- tests/qemumigrationcookiexmltest.c | 2 +- 7 files changed, 116 insertions(+), 57 deletions(-) -- 2.35.1

2 5

[PATCH 0/2] virnettlscontext: Don't set DH parameters ourselves
by Michal Privoznik 30 Jun '22

30 Jun '22

Suggested by Dan here: https://listman.redhat.com/archives/libvir-list/2022-January/226681.html Since we can bump min gnutls version we don't have to care about pre-3.6.0 release he mentions in the e-mail. Michal Prívozník (2): meson: Require gnutls-3.6.0 or newer virnettlscontext: Don't set DH parameters ourselves meson.build | 2 +- src/rpc/virnettlscontext.c | 41 -------------------------------------- tests/virrandommock.c | 36 --------------------------------- 3 files changed, 1 insertion(+), 78 deletions(-) -- 2.35.1

2 3

[PATCH for 8.5.0] API: Remove internal impl detail from VIR_DOMAIN_IOTHREAD_THREAD_POOL_{MIN, MAX} description
by Michal Privoznik 30 Jun '22

30 Jun '22

When introducing VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX typed parameters, I've made a shortcut. Since at the monitor level these two are set in two separate calls and minimum has to be always smaller than maximum (or equal to it), it may happen that one of the values we want to set violates this restriction. So I've put a little note in the public API description warning users about this. However, the proper solution is to have a logic that checks the current values and based on that set either minimum or maximum value first. But until we get there, remove that note from the public API before it gets released. Related: https://gitlab.com/libvirt/libvirt/-/issues/339 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- include/libvirt/libvirt-domain.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 05344aaa95..7430a08619 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2513,9 +2513,7 @@ int virDomainDelIOThread(virDomainPtr domain, * * Sets the lower bound for thread pool size. A value of -1 disables this bound * leaving hypervisor use its default value, though this value is not accepted - * for running domains. Due to internal implementation it's recommended to set - * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX - * separately. Accepted type is VIR_TYPED_PARAM_INT. + * for running domains. Accepted type is VIR_TYPED_PARAM_INT. * * Since: 8.5.0 */ @@ -2527,9 +2525,7 @@ int virDomainDelIOThread(virDomainPtr domain, * Sets the upper bound for thread pool size. A value of -1 disables this bound * leaving hypervisor use its default value, though this value is not accepted * for running domains. Since the upper band has to be equal to or greater than - * lower bound value of 0 is not accepted. Due to internal implementation it's - * recommended to set VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and - * VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX separately. Accepted type is + * lower bound value of 0 is not accepted. Accepted type is * VIR_TYPED_PARAM_INT. * * Since: 8.5.0 -- 2.35.1

2 1

[PATCH v3 00/15] qemu: Allow setting EventLoopBaseProperties
by Michal Privoznik 30 Jun '22

30 Jun '22

v3 of: https://listman.redhat.com/archives/libvir-list/2022-June/232288.html diff to v2: - More validation checks (e.g. max != 0, min <= max), - Disallow -1 for virDomainSetIOThreadParams on a live VM, - Extended docs, - Reworded some commit messages. Michal Prívozník (15): virml: Introduce VIR_XML_PROP_NONNEGATIVE flag virDomainDefParseIOThreads: Use g_autoptr() for @iothrid virDomainIOThreadIDDefArrayInit: Decrease scope of @iothrid conf: Move iothread formatter into a separate function conf: Introduce allocator for virDomainIOThreadIDDef conf: Introduce thread_pool_min and thread_pool_max attributes to IOThread qemu: Introduce QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX qemu_validate: Check if QEMU's capable of setting iothread pool size qemu: Generate command line for IOThread pool size include: Introduce typed params for virDomainSetIOThreadParams wrt pool size qemu: Wire up new virDomainSetIOThreadParams parameters virsh: Wire up new virDomainSetIOThreadParams parameters conf: Introduce <defaultiothread/> qemu_validate: Check if QEMU's capable of setting <defaultiothread/> pool size qemu: Generate command line for <defaultiothread/> pool size docs/formatdomain.rst | 17 +- docs/manpages/virsh.rst | 13 +- include/libvirt/libvirt-domain.h | 28 +++ src/conf/domain_conf.c | 162 +++++++++++++++--- src/conf/domain_conf.h | 11 ++ src/conf/domain_validate.c | 45 +++++ src/conf/schemas/domaincommon.rng | 25 +++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 26 ++- src/qemu/qemu_driver.c | 140 ++++++++++++++- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 2 + src/qemu/qemu_validate.c | 36 ++++ src/util/virxml.c | 7 + src/util/virxml.h | 3 + .../caps_7.1.0.x86_64.xml | 1 + ...othreads-ids-pool-sizes.x86_64-latest.args | 45 +++++ .../iothreads-ids-pool-sizes.xml | 62 +++++++ tests/qemuxml2argvtest.c | 1 + ...iothreads-ids-pool-sizes.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 24 ++- 24 files changed, 621 insertions(+), 38 deletions(-) create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml create mode 120000 tests/qemuxml2xmloutdata/iothreads-ids-pool-sizes.x86_64-latest.xml -- 2.35.1

4 22

[PATCH] NEWS: Mention 3 user-visible regressions fixed in this release
by Peter Krempa 30 Jun '22

30 Jun '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7597abcf7e..2e29c57ffc 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -61,6 +61,24 @@ v8.5.0 (unreleased) an ``<interface/>`` might have resulted in closing of a random FD and thus sudden disconnect of a client or other random failures. + * qemu: Fix hotplug of network interfaces + + A logic bug introduced in a recent refactor was fixed. The bug caused a + problem when hot-adding a network interface, which failed with the + following error:: + + error: internal error: unable to execute QEMU command 'netdev_add': File descriptor named '(null)' has not been found + + * Fix ``startupPolicy`` validation for ``block`` disks + + Setting of ``startupPolicy`` for a block disk would result in an error due + to a logic bug in a recent refactor. + + * qemu: Fix crash when overriding device properties via ``<qemu:override>`` element + + Adding an override for a device property would result in a crash of the qemu + driver. + v8.4.0 (2022-06-01) =================== -- 2.36.1

2 1

Entering freeze for libvirt-8.5.0
by Jiri Denemark 29 Jun '22

29 Jun '22

I have just tagged v8.5.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH v2] conf: virDomainMemoryDefValidate: Improve error message
by Liu Yiding 29 Jun '22

29 Jun '22

An explicit limit would be more user friendly. Add the limit to error message. Before this commit: ``` error: requested size must be smaller than or equal to @size ``` Now: ``` error: requested size must be smaller than or equal to @size (8388608KiB) ``` Signed-off-by: Liu Yiding <liuyd.fnst(a)fujitsu.com> --- src/conf/domain_validate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 33b6f47159..28b0481d4e 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2194,8 +2194,9 @@ virDomainMemoryDefValidate(const virDomainMemoryDef *mem, case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: if (mem->requestedsize > mem->size) { - virReportError(VIR_ERR_XML_DETAIL, "%s", - _("requested size must be smaller than or equal to @size")); + virReportError(VIR_ERR_XML_DETAIL, + _("requested size must be smaller than or equal to @size (%lluKiB)"), + mem->size); return -1; } -- 2.34.1

3 2

[PATCH 0/4] virnetdevbandwidthtest: Test QoS for OVS
by Michal Privoznik 28 Jun '22

28 Jun '22

Cleanup virnetdevbandwidthtest and introduce new test cases. However, Martin suggested (after glancing over the last patch) that arguments could be stored in a file (just like qemuxml2argvtest does). I'm not against that, but QEMU cmd line args change more often than those of tc/ovs-vsctl. But if desired I can do the change (either as a follow up or in v2). Michal Prívozník (4): virnetdevbandwidthtest: Drop unnecessary brackets virnetdevbandwidthtest: Drop unused testMinimalStruct virnetdevbandwidthtest: Reformat TC cmd line virnetdevbandwidthtest: Test QoS for OVS tests/virnetdevbandwidthtest.c | 171 +++++++++++++++++++++------------ 1 file changed, 109 insertions(+), 62 deletions(-) -- 2.35.1

2 5

Qemu guest-reset option on device_add
by Simon Fairweather 28 Jun '22

28 Jun '22

Hi Is there any plans to add support for guest_reset directive for QEMU? device_add usb-host,vendorid=0x05ac,productid=0x12a8,guest_reset=True,id=iphone Are you able to point me in the direction of where code would need to be executed and I can look to see if I can create a PR? Regards Simon

2 1