April 2022 - Devel - libvirt List Archives

[libvirt RFCv4 00/20] multifd save restore prototype
by Claudio Fontana 30 Apr '22

30 Apr '22

This is the multifd save prototype in semi-functional state, with both save and restore minimally functional. There are still quite a few rough edges. KNOWN ISSUES: 1) this applies only to virsh save and virsh restore for now (no managed save etc). 2) the .pl scripts to generate the headers for the new APIs do not reliably work for me, for the Restore case. I get: src/remote/remote_daemon_dispatch_stubs.h:10080:9: error: too few arguments to function ‘virDomainRestoreParametersFlags’ if (virDomainRestoreParametersFlags(params, nparams, args->flags) < 0) To work around this I had to fixup the header manually to add the conn parameter like this: ...(conn, params, nparams, args->flags) < 0) 3) error handling is not good yet, especially during resume, errors may leave behind a qemu process and such. May need some help find all of these cases... ... changes from v3: * reordered series to have all helper-related change at the start * solved all reported issues from ninja test, including documentation * fixed most broken migration capabilities code (still imperfect likely) * added G_GNUC_UNUSED as needed * after multifd restore, added what I think were the missing operations: qemuProcessRefreshState(), qemuProcessStartCPUs() - most importantly, virDomainObjSave() The domain now starts running after restore without further encouragement * removed the sleep(10) from the multifd-helper changes from v2: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) Thanks for your thoughts, Claudio *** BLURB HERE *** Claudio Fontana (20): iohelper: introduce new struct to carry copy operation parameters iohelper: refactor copy operation as a separate function iohelper: move runIO function to a separate module runio: add arguments to extend use beyond just stdin and stdout multifd-helper: new helper for parallel save/restore libvirt: introduce virDomainSaveParametersFlags public API libvirt: introduce virDomainRestoreParametersFlags public API remote: Add RPC support for the virDomainSaveParametersFlags API remote: Add RPC support for the virDomainRestoreParametersFlags API qemu: add a stub for virDomainSaveParametersFlags API qemu: add a stub for virDomainRestoreParametersFlags API qemu: saveimage: introduce virQEMUSaveFd qemu: wire up saveimage code with the multifd helper qemu: capabilities: add multifd to the probed migration capabilities qemu: implement qemuMigrationSrcToFilesMultiFd qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression docs/manpages/virsh.rst | 34 +- include/libvirt/libvirt-domain.h | 49 ++ po/POTFILES.in | 2 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 99 ++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 6 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_driver.c | 239 +++++++-- src/qemu/qemu_migration.c | 155 ++++-- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 ++- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 496 ++++++++++++++---- src/qemu/qemu_saveimage.h | 49 +- src/qemu/qemu_snapshot.c | 6 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 29 +- src/remote_protocol-structs | 17 + src/util/iohelper.c | 150 +----- src/util/meson.build | 15 + src/util/multifd-helper.c | 250 +++++++++ src/util/runio.c | 214 ++++++++ src/util/runio.h | 38 ++ src/util/virthread.c | 5 + src/util/virthread.h | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 + .../caps_5.2.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../caps_6.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 + .../caps_6.0.0.x86_64.xml | 2 + .../caps_6.1.0.x86_64.xml | 2 + .../caps_6.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 + .../caps_6.2.0.x86_64.xml | 2 + .../caps_7.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 + .../caps_7.0.0.x86_64.xml | 2 + tools/virsh-domain.c | 96 +++- 62 files changed, 1713 insertions(+), 427 deletions(-) create mode 100644 src/util/multifd-helper.c create mode 100644 src/util/runio.c create mode 100644 src/util/runio.h -- 2.34.1

2 40

[PATCH v2 2/5] hw/nvme: do not auto-generate eui64
by Klaus Jensen 30 Apr '22

30 Apr '22

From: Klaus Jensen <k.jensen(a)samsung.com> We cannot provide auto-generated unique or persistent namespace identifiers (EUI64, NGUID, UUID) easily. Since 6.1, namespaces have been assigned a generated EUI64 of the form "52:54:00:<namespace counter>". This is will be unique within a QEMU instance, but not globally. Revert that this is assigned automatically and immediately deprecate the compatibility parameter. Users can opt-in to this with the `eui64-default=on` device parameter or set it explicitly with `eui64=UINT64`. Cc: libvir-list(a)redhat.com Signed-off-by: Klaus Jensen <k.jensen(a)samsung.com> --- docs/about/deprecated.rst | 7 +++++++ hw/core/machine.c | 4 +++- hw/nvme/ns.c | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 896e5a97abbd..c65faa5ab4ad 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -356,6 +356,13 @@ contains native support for this feature and thus use of the option ROM approach is obsolete. The native SeaBIOS support can be activated by using ``-machine graphics=off``. +``-device nvme-ns,eui64-default=on|off`` (since 7.1) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +In QEMU versions 6.1, 6.2 and 7.0, the ``nvme-ns`` generates an EUI-64 +identifer that is not globally unique. If an EUI-64 identifer is required, the +user must set it explicitly using the ``nvme-ns`` device parameter ``eui64``. + Block device options '''''''''''''''''''' diff --git a/hw/core/machine.c b/hw/core/machine.c index cb9bbc844d24..1e2108d95f11 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -37,7 +37,9 @@ #include "hw/virtio/virtio.h" #include "hw/virtio/virtio-pci.h" -GlobalProperty hw_compat_7_0[] = {}; +GlobalProperty hw_compat_7_0[] = { + { "nvme-ns", "eui64-default", "on"}, +}; const size_t hw_compat_7_0_len = G_N_ELEMENTS(hw_compat_7_0); GlobalProperty hw_compat_6_2[] = { diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c index af6504fad2d8..06a04131f192 100644 --- a/hw/nvme/ns.c +++ b/hw/nvme/ns.c @@ -641,7 +641,7 @@ static Property nvme_ns_props[] = { DEFINE_PROP_SIZE("zoned.zrwas", NvmeNamespace, params.zrwas, 0), DEFINE_PROP_SIZE("zoned.zrwafg", NvmeNamespace, params.zrwafg, -1), DEFINE_PROP_BOOL("eui64-default", NvmeNamespace, params.eui64_default, - true), + false), DEFINE_PROP_END_OF_LIST(), }; -- 2.35.1

2 1

Entering freeze for libvirt-8.3.0
by Jiri Denemark 29 Apr '22

29 Apr '22

I have just tagged v8.3.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

Re: [RFC 00/18] vfio: Adopt iommufd
by Alex Williamson 29 Apr '22

29 Apr '22

[Cc +libvirt folks] On Thu, 14 Apr 2022 03:46:52 -0700 Yi Liu <yi.l.liu(a)intel.com> wrote: > With the introduction of iommufd[1], the linux kernel provides a generic > interface for userspace drivers to propagate their DMA mappings to kernel > for assigned devices. This series does the porting of the VFIO devices > onto the /dev/iommu uapi and let it coexist with the legacy implementation. > Other devices like vpda, vfio mdev and etc. are not considered yet. > > For vfio devices, the new interface is tied with device fd and iommufd > as the iommufd solution is device-centric. This is different from legacy > vfio which is group-centric. To support both interfaces in QEMU, this > series introduces the iommu backend concept in the form of different > container classes. The existing vfio container is named legacy container > (equivalent with legacy iommu backend in this series), while the new > iommufd based container is named as iommufd container (may also be mentioned > as iommufd backend in this series). The two backend types have their own > way to setup secure context and dma management interface. Below diagram > shows how it looks like with both BEs. > > VFIO AddressSpace/Memory > +-------+ +----------+ +-----+ +-----+ > | pci | | platform | | ap | | ccw | > +---+---+ +----+-----+ +--+--+ +--+--+ +----------------------+ > | | | | | AddressSpace | > | | | | +------------+---------+ > +---V-----------V-----------V--------V----+ / > | VFIOAddressSpace | <------------+ > | | | MemoryListener > | VFIOContainer list | > +-------+----------------------------+----+ > | | > | | > +-------V------+ +--------V----------+ > | iommufd | | vfio legacy | > | container | | container | > +-------+------+ +--------+----------+ > | | > | /dev/iommu | /dev/vfio/vfio > | /dev/vfio/devices/vfioX | /dev/vfio/$group_id > Userspace | | > ===========+============================+================================ > Kernel | device fd | > +---------------+ | group/container fd > | (BIND_IOMMUFD | | (SET_CONTAINER/SET_IOMMU) > | ATTACH_IOAS) | | device fd > | | | > | +-------V------------V-----------------+ > iommufd | | vfio | > (map/unmap | +---------+--------------------+-------+ > ioas_copy) | | | map/unmap > | | | > +------V------+ +-----V------+ +------V--------+ > | iommfd core | | device | | vfio iommu | > +-------------+ +------------+ +---------------+ > > [Secure Context setup] > - iommufd BE: uses device fd and iommufd to setup secure context > (bind_iommufd, attach_ioas) > - vfio legacy BE: uses group fd and container fd to setup secure context > (set_container, set_iommu) > [Device access] > - iommufd BE: device fd is opened through /dev/vfio/devices/vfioX > - vfio legacy BE: device fd is retrieved from group fd ioctl > [DMA Mapping flow] > - VFIOAddressSpace receives MemoryRegion add/del via MemoryListener > - VFIO populates DMA map/unmap via the container BEs > *) iommufd BE: uses iommufd > *) vfio legacy BE: uses container fd > > This series qomifies the VFIOContainer object which acts as a base class > for a container. This base class is derived into the legacy VFIO container > and the new iommufd based container. The base class implements generic code > such as code related to memory_listener and address space management whereas > the derived class implements callbacks that depend on the kernel user space > being used. > > The selection of the backend is made on a device basis using the new > iommufd option (on/off/auto). By default the iommufd backend is selected > if supported by the host and by QEMU (iommufd KConfig). This option is > currently available only for the vfio-pci device. For other types of > devices, it does not yet exist and the legacy BE is chosen by default. I've discussed this a bit with Eric, but let me propose a different command line interface. Libvirt generally likes to pass file descriptors to QEMU rather than grant it access to those files directly. This was problematic with vfio-pci because libvirt can't easily know when QEMU will want to grab another /dev/vfio/vfio container. Therefore we abandoned this approach and instead libvirt grants file permissions. However, with iommufd there's no reason that QEMU ever needs more than a single instance of /dev/iommufd and we're using per device vfio file descriptors, so it seems like a good time to revisit this. The interface I was considering would be to add an iommufd object to QEMU, so we might have a: -device iommufd[,fd=#][,id=foo] For non-libivrt usage this would have the ability to open /dev/iommufd itself if an fd is not provided. This object could be shared with other iommufd users in the VM and maybe we'd allow multiple instances for more esoteric use cases. [NB, maybe this should be a -object rather than -device since the iommufd is not a guest visible device?] The vfio-pci device might then become: -device vfio-pci[,host=DDDD:BB:DD.f][,sysfsdev=/sys/path/to/device][,fd=#][,iommufd=foo] So essentially we can specify the device via host, sysfsdev, or passing an fd to the vfio device file. When an iommufd object is specified, "foo" in the example above, each of those options would use the vfio-device access mechanism, essentially the same as iommufd=on in your example. With the fd passing option, an iommufd object would be required and necessarily use device level access. In your example, the iommufd=auto seems especially troublesome for libvirt because QEMU is going to have different locked memory requirements based on whether we're using type1 or iommufd, where the latter resolves the duplicate accounting issues. libvirt needs to know deterministically which backed is being used, which this proposal seems to provide, while at the same time bringing us more in line with fd passing. Thoughts? Thanks, Alex

5 15

[libvirt RFC v3 00/19] multifd save restore prototype
by Claudio Fontana 29 Apr '22

29 Apr '22

This is the multifd save prototype in its first semi-functional state, now with both save and restore minimally functional. Still as mentioned before, likely there are quite a few rough edges, let me know what you think about this possible option. changes from v2 are many, mainly: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) KNOWN ISSUES: 1) this applies only to virsh save and virsh restore for now (no managed save etc). 2) the .pl scripts to generate the headers for the new APIs do not reliably work for me, for the Restore case. I get: src/remote/remote_daemon_dispatch_stubs.h:10080:9: error: too few arguments to function ‘virDomainRestoreParametersFlags’ if (virDomainRestoreParametersFlags(params, nparams, args->flags) < 0) To work around this I had to fixup the header manually to look like: ...(conn, params, nparams, args->flags) < 0) Thanks for your thoughts, Claudio Claudio Fontana (19): iohelper: introduce new struct to carry copy operation parameters iohelper: refactor copy operation as a separate function libvirt: introduce virDomainSaveParametersFlags public API libvirt: introduce virDomainRestoreParametersFlags public API remote: Add RPC support for the virDomainSaveParametersFlags API remote: Add RPC support for the virDomainRestoreParametersFlags API qemu: add a stub for virDomainSaveParametersFlags API qemu: add a stub for virDomainRestoreParametersFlags API qemu: saveimage: introduce virQEMUSaveFd iohelper: move runIO function to a separate module runio: add arguments to extend use beyond just stdin and stdout multifd-helper: new helper for parallel save/restore qemu: wire up saveimage code with the multifd helper qemu: implement qemuMigrationSrcToFilesMultiFd qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression docs/manpages/virsh.rst | 34 ++- include/libvirt/libvirt-domain.h | 13 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 99 +++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 6 + src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_driver.c | 233 +++++++++++---- src/qemu/qemu_migration.c | 155 ++++++---- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 +++-- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 480 ++++++++++++++++++++++++------- src/qemu/qemu_saveimage.h | 49 +++- src/qemu/qemu_snapshot.c | 6 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 29 +- src/remote_protocol-structs | 17 ++ src/util/iohelper.c | 150 +--------- src/util/meson.build | 15 + src/util/multifd-helper.c | 250 ++++++++++++++++ src/util/runio.c | 214 ++++++++++++++ src/util/runio.h | 38 +++ src/util/virthread.c | 5 + src/util/virthread.h | 1 + tools/virsh-domain.c | 96 +++++-- 29 files changed, 1599 insertions(+), 426 deletions(-) create mode 100644 src/util/multifd-helper.c create mode 100644 src/util/runio.c create mode 100644 src/util/runio.h -- 2.34.1

3 34

[PATCH] build-aux: remove duplicated syntax check filter for 'select'
by Daniel P. Berrangé 28 Apr '22

28 Apr '22

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- build-aux/syntax-check.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 66ebc3e066..6664763faf 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1621,9 +1621,6 @@ exclude_file_name_regexp--sc_prohibit_newline_at_end_of_diagnostic = \ exclude_file_name_regexp--sc_prohibit_nonreentrant = \ ^((po|tests|examples)/|docs/.*(py|js|html\.in|.rst)|run.in$$|tools/wireshark/util/genxdrstub\.pl|tools/virt-login-shell\.c$$) -exclude_file_name_regexp--sc_prohibit_select = \ - ^build-aux/syntax-check\.mk$$ - exclude_file_name_regexp--sc_prohibit_canonicalize_file_name = \ ^(build-aux/syntax-check\.mk|tests/virfilemock\.c)$$ -- 2.35.1

2 1

[libvirt RFC] add API for parallel Saves (not for committing)
by Claudio Fontana 28 Apr '22

28 Apr '22

RFC, starting point for discussion. Sketch API changes to allow parallel Saves, and open up and implementation for QEMU to leverage multifd migration to files, with optional multifd compression. This allows to improve save times for huge VMs. The idea is to issue commands like: virsh save domain /path/savevm --parallel --parallel-connections 2 and have libvirt start a multifd migration to: /path/savevm : main migration connection /path/savevm.1 : multifd channel 1 /path/savevm.2 : multifd channel 2 Signed-off-by: Claudio Fontana <cfontana(a)suse.de> --- include/libvirt/libvirt-domain.h | 5 +++++ src/driver-hypervisor.h | 7 +++++++ src/libvirt_public.syms | 5 +++++ src/qemu/qemu_driver.c | 1 + tools/virsh-domain.c | 8 ++++++++ 5 files changed, 26 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 2d5718301e..a7b9c4132d 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1270,6 +1270,7 @@ typedef enum { VIR_DOMAIN_SAVE_RUNNING = 1 << 1, /* Favor running over paused */ VIR_DOMAIN_SAVE_PAUSED = 1 << 2, /* Favor paused over running */ VIR_DOMAIN_SAVE_RESET_NVRAM = 1 << 3, /* Re-initialize NVRAM from template */ + VIR_DOMAIN_SAVE_PARALLEL = 1 << 4, /* Parallel Save/Restore to multiple files */ } virDomainSaveRestoreFlags; int virDomainSave (virDomainPtr domain, @@ -1278,6 +1279,10 @@ int virDomainSaveFlags (virDomainPtr domain, const char *to, const char *dxml, unsigned int flags); +int virDomainSaveParametersFlags (virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + unsigned int flags); int virDomainRestore (virConnectPtr conn, const char *from); int virDomainRestoreFlags (virConnectPtr conn, diff --git a/src/driver-hypervisor.h b/src/driver-hypervisor.h index 4423eb0885..a4e1d21e76 100644 --- a/src/driver-hypervisor.h +++ b/src/driver-hypervisor.h @@ -240,6 +240,12 @@ typedef int const char *dxml, unsigned int flags); +typedef int +(*virDrvDomainSaveParametersFlags)(virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + unsigned int flags); + typedef int (*virDrvDomainRestore)(virConnectPtr conn, const char *from); @@ -1489,6 +1495,7 @@ struct _virHypervisorDriver { virDrvDomainGetControlInfo domainGetControlInfo; virDrvDomainSave domainSave; virDrvDomainSaveFlags domainSaveFlags; + virDrvDomainSaveParametersFlags domainSaveParametersFlags; virDrvDomainRestore domainRestore; virDrvDomainRestoreFlags domainRestoreFlags; virDrvDomainSaveImageGetXMLDesc domainSaveImageGetXMLDesc; diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index f93692c427..eb3a7afb75 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -916,4 +916,9 @@ LIBVIRT_8.0.0 { virDomainSetLaunchSecurityState; } LIBVIRT_7.8.0; +LIBVIRT_8.3.0 { + global: + virDomainSaveParametersFlags; +} LIBVIRT_8.0.0; + # .... define new API here using predicted next version number .... diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 77012eb527..249105356c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20826,6 +20826,7 @@ static virHypervisorDriver qemuHypervisorDriver = { .domainGetControlInfo = qemuDomainGetControlInfo, /* 0.9.3 */ .domainSave = qemuDomainSave, /* 0.2.0 */ .domainSaveFlags = qemuDomainSaveFlags, /* 0.9.4 */ + .domainSaveParametersFlags = qemuDomainSaveParametersFlags, /* 8.3.0 */ .domainRestore = qemuDomainRestore, /* 0.2.0 */ .domainRestoreFlags = qemuDomainRestoreFlags, /* 0.9.4 */ .domainSaveImageGetXMLDesc = qemuDomainSaveImageGetXMLDesc, /* 0.9.4 */ diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d5fd8be7c3..ccded6d265 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4164,6 +4164,14 @@ static const vshCmdOptDef opts_save[] = { .type = VSH_OT_BOOL, .help = N_("avoid file system cache when saving") }, + {.name = "parallel", + .type = VSH_OT_BOOL, + .help = N_("enable parallel save to files") + }, + {.name = "parallel-connections", + .type = VSH_OT_INT, + .help = N_("number of connections/files for parallel save") + }, {.name = "xml", .type = VSH_OT_STRING, .completer = virshCompletePathLocalExisting, -- 2.34.1

4 12

[PATCH] NEWS: Mention bump of minimum qemu version to qemu-3.1
by Peter Krempa 27 Apr '22

27 Apr '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7ad8b9ec0b..c9b0ad42ed 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,11 @@ v8.3.0 (unreleased) * **Removed features** + * qemu: Remove support for QEMU < 3.1 + + In accordance with our platform support policy, the oldest supported QEMU + version is now bumped from 2.11 to 3.1. + * **New features** * qemu: Introduce support for virtio-iommu -- 2.35.1

2 1

[PATCH] cpu: Remove pointless check
by Martin Kletzander 27 Apr '22

27 Apr '22

These two pointers can never be NULL since they are initialised to a reference of a struct. This became apparent when commit 210a19539447 added a VIR_DEBUG which used both pointers because due to the concise condition the compiler saw that if the "and" part of the condition did short-circuit (and it assumed that can happen) the second variable would not be initialised, but it is used in the debugging message, so the build failed with: In file included from ../src/cpu/cpu_x86.c:27: ../src/cpu/cpu_x86.c: In function ‘virCPUx86DataIsIdentical’: ../src/util/virlog.h:79:5: error: ‘bdata’ may be used uninitialized in this function [-Werror=maybe-uninitialized] Fix this by just assigning the helper pointers and remove the condition altogether. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed under the build-breaker rule, but feel free to review/object. src/cpu/cpu_x86.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 7e9d1cea47d1..a5eac7601cad 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -3314,10 +3314,8 @@ virCPUx86DataIsIdentical(const virCPUData *a, return VIR_CPU_COMPARE_INCOMPATIBLE; } - if (!((adata = &a->data.x86) && (bdata = &b->data.x86))) { - VIR_DEBUG("missing x86 data: a:%p b:%p", adata, bdata); - return VIR_CPU_COMPARE_ERROR; - } + adata = &a->data.x86; + bdata = &b->data.x86; if (adata->len != bdata->len) { VIR_DEBUG("unequal length a:%zu b:%zu", adata->len, bdata->len); -- 2.35.1

2 2

[libvirt PATCH] util: fix double destroy / missing unref of GSource
by Daniel P. Berrangé 27 Apr '22

27 Apr '22

A leak of the GSource was introduced in commit 87a43a907f0ad4897a28ad7c216bc70f37270b93 Author: Michal Prívozník <mprivozn(a)redhat.com> Date: Fri Jan 28 18:42:45 2022 +0100 lib: Use g_clear_pointer() more As it mistakenly replaced the g_vir_source_unref call with a second call to g_source_destroy. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/vireventglib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vireventglib.c b/src/util/vireventglib.c index fc04d8f712..3cc42597fd 100644 --- a/src/util/vireventglib.c +++ b/src/util/vireventglib.c @@ -227,7 +227,7 @@ virEventGLibHandleUpdate(int watch, goto cleanup; VIR_DEBUG("Removed old handle source=%p", data->source); - g_source_destroy(data->source); + vir_g_source_unref(data->source, NULL); g_clear_pointer(&data->source, g_source_destroy); data->events = 0; } -- 2.35.1

2 1

[PATCH] qemu: do not use domain virt type to get default version
by Liang Yan 27 Apr '22

27 Apr '22

We do not need VIR_DOMAIN_VIRT_QEMU to get qemu default version. With the 'os_type' and 'arch'in capabilities, we could identify 'emulator' which is enough to get the version. Actually VIR_DOMAIN_VIRT_QEMU is not the only domain virt type for qemu driver, there are VIR_DOMAIN_VIRT_KVM and VIR_DOMAIN_VIRT_HVF. If TCG is disabled in qemu, it will cause the error that could not find suitable emulater when access version. Signed-off-by: Liang Yan <lyan(a)digtalocean.com> --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b91db851bb..9a0b7ebeb4 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1857,7 +1857,7 @@ int virQEMUCapsGetDefaultVersion(virCaps *caps, hostarch = virArchFromHost(); if (!(capsdata = virCapabilitiesDomainDataLookup(caps, - VIR_DOMAIN_OSTYPE_HVM, hostarch, VIR_DOMAIN_VIRT_QEMU, + VIR_DOMAIN_OSTYPE_HVM, hostarch, VIR_DOMAIN_VIRT_NONE, NULL, NULL))) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Cannot find suitable emulator for %s"), -- 2.34.1

1 0

[PULL 0/3] Misc next patches
by Daniel P. Berrangé 27 Apr '22

27 Apr '22

The following changes since commit a1755db71e34df016ffc10aa0727360aae2c6036: Merge tag 'pull-block-2022-04-25' of https://gitlab.com/hreitz/qemu into staging (2022-04-25 13:35:41 -0700) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/misc-next-pull-request for you to fetch changes up to 5cf434b5af386fadc3418df71d3738676cbb0549: github: fix config mistake preventing repo lockdown commenting (2022-04-26 16:12:26 +0100) ---------------------------------------------------------------- Misc patch queue * Removes depecated --enable-fips QEMU system emulator option * Fixes array bounds check in keycode conversion for ESCC device ---------------------------------------------------------------- Daniel P. Berrangé (3): softmmu: remove deprecated --enable-fips option hw/char: fix qcode array bounds check in ESCC impl github: fix config mistake preventing repo lockdown commenting .github/workflows/lockdown.yml | 6 +++--- docs/about/deprecated.rst | 12 ------------ docs/about/removed-features.rst | 11 +++++++++++ hw/char/escc.c | 2 +- include/qemu/osdep.h | 3 --- os-posix.c | 8 -------- qemu-options.hx | 10 ---------- ui/vnc.c | 7 ------- util/osdep.c | 28 ---------------------------- 9 files changed, 15 insertions(+), 72 deletions(-) -- 2.35.1

2 4

[PATCH] include: Move version information
by Andrea Bolognani 27 Apr '22

27 Apr '22

It belongs to the comment for VIR_DOMAIN_AFFECT_CONFIG, not to the unrelated one immediately after it. Fixes: 807cdbf75976f88e8a23b26951f263029cc9e5f4 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. include/libvirt/libvirt-domain.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 6fed42c47a..9386f5189c 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -323,8 +323,8 @@ typedef virDomainControlInfo *virDomainControlInfoPtr; typedef enum { VIR_DOMAIN_AFFECT_CURRENT = 0, /* Affect current domain state. (Since: v0.9.2) */ VIR_DOMAIN_AFFECT_LIVE = 1 << 0, /* Affect running domain state. (Since: v0.9.2) */ - VIR_DOMAIN_AFFECT_CONFIG = 1 << 1, /* Affect persistent domain state. */ - /* 1 << 2 is reserved for virTypedParameterFlags (Since: v0.9.2) */ + VIR_DOMAIN_AFFECT_CONFIG = 1 << 1, /* Affect persistent domain state. (Since: v0.9.2) */ + /* 1 << 2 is reserved for virTypedParameterFlags */ } virDomainModificationImpact; /** -- 2.35.1

1 0

[PATCH v2 0/8] Introduce network backed NVRAM
by Rohit Kumar 26 Apr '22

26 Apr '22

Libvirt domain XML currently allows only local filepaths that can be used to specify a NVRAM disk. Since, VMs can migrate across hypervisor hosts, it should be possible to allocate NVRAM disks on network storage for uninterrupted access. This series extends the NVRAM element to support hosting over network-backed disks, for high availability. It achieves this by embedding virStorageSource pointer for nvram into _virDomainLoaderDef. It introduces a 'type' attribute for NVRAM element to specify 'file' vs 'network' backed NVRAM. Changes v1->v2: - Split the patch into smaller patches - Added unit test - Updated the doc - Addressed Peter's comment on v1 (https://listman.redhat.com/archives/libvir-list/2022-March/229684.html) Rohit Kumar (8): Make NVRAM a virStorageSource type. Add support to parse/format virStorageSource type NVRAM Validate remote store NVRAM Cleanup diskSourceNetwork and diskSourceFile schema Update XML schema to support network backed NVRAM Update NVRAM documentation Add unit test for network backed NVRAM Add unit test to support new 'file' type NVRAM docs/formatdomain.rst | 43 +++++++-- src/conf/domain_conf.c | 88 ++++++++++++++++--- src/conf/domain_conf.h | 2 +- src/conf/schemas/domaincommon.rng | 80 +++++++++++------ src/qemu/qemu_cgroup.c | 3 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_domain.c | 14 +-- src/qemu/qemu_driver.c | 5 +- src/qemu/qemu_firmware.c | 23 +++-- src/qemu/qemu_namespace.c | 5 +- src/qemu/qemu_process.c | 5 +- src/qemu/qemu_validate.c | 22 +++++ src/security/security_dac.c | 6 +- src/security/security_selinux.c | 6 +- src/security/virt-aa-helper.c | 5 +- src/vbox/vbox_common.c | 2 +- .../bios-nvram-file.x86_64-latest.args | 37 ++++++++ tests/qemuxml2argvdata/bios-nvram-file.xml | 23 +++++ .../bios-nvram-network.x86_64-latest.args | 37 ++++++++ tests/qemuxml2argvdata/bios-nvram-network.xml | 25 ++++++ tests/qemuxml2argvtest.c | 2 + 21 files changed, 360 insertions(+), 75 deletions(-) create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.xml create mode 100644 tests/qemuxml2argvdata/bios-nvram-network.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/bios-nvram-network.xml -- 2.25.1

3 34

[libvirt PATCH] ci: print test suite logs on failure for Cirrus jobs
by Daniel P. Berrangé 26 Apr '22

26 Apr '22

We don't have access to the 'testlog.txt' file, so we need meson to print the failures for any broken tests directly. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- The CI pipeline for macOS started failing a few days ago. It was not triggered by any commit, as the pipeline immediately preceeding the first failure used the same commit hash on master. The logs show glib2 being updated from 2.72.0 to 2.72.1 With this patch applied I can see the test logs https://gitlab.com/berrange/libvirt/-/jobs/2376891003 and all the failing tests are hitting: (process:50961): GLib-WARNING **: 01:56:14.162: poll(2) failed due to: Bad file descriptor. so something todo with the QEMU monitor/event loop AFAIK, but not sure what. ci/cirrus/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml index 867d5f297b..f03ad58143 100644 --- a/ci/cirrus/build.yml +++ b/ci/cirrus/build.yml @@ -26,4 +26,4 @@ build_task: - meson setup build - meson dist -C build --no-tests - meson compile -C build - - meson test -C build --no-suite syntax-check + - meson test -C build --no-suite syntax-check --print-errorlogs -- 2.35.1

2 2

[PATCH] include: Remove more comments between enum values
by Andrea Bolognani 26 Apr '22

26 Apr '22

apibuild.py mistakes these as being a continuation of the previous comment. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial-ish and necessary to unblock Victor's work. include/libvirt/libvirt-domain-snapshot.h | 2 -- include/libvirt/libvirt-domain.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/include/libvirt/libvirt-domain-snapshot.h b/include/libvirt/libvirt-domain-snapshot.h index 35eeb21e27..9181cc1f38 100644 --- a/include/libvirt/libvirt-domain-snapshot.h +++ b/include/libvirt/libvirt-domain-snapshot.h @@ -123,8 +123,6 @@ typedef enum { not just children, when listing a snapshot */ - /* For historical reasons, groups do not use contiguous bits. */ - VIR_DOMAIN_SNAPSHOT_LIST_LEAVES = (1 << 2), /* Filter by snapshots with no children */ VIR_DOMAIN_SNAPSHOT_LIST_NO_LEAVES = (1 << 3), /* Filter by snapshots diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 3dfcd14b9c..f8f1ff2ce2 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2148,8 +2148,6 @@ typedef enum { VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA = (1 << 4), /* If last use of domain, then also remove any checkpoint metadata */ - - /* Future undefine control flags should come here. */ } virDomainUndefineFlagsValues; -- 2.35.1

1 0

[PATCH] include: Fix docstring indentation
by Andrea Bolognani 26 Apr '22

26 Apr '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial include/libvirt/libvirt-domain.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 0fa4509b73..3dfcd14b9c 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2793,15 +2793,15 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); # define VIR_PERF_PARAM_TASK_CLOCK "task_clock" /** -* VIR_PERF_PARAM_PAGE_FAULTS: -* -* Macro for typed parameter name that represents page_faults -* perf event which can be used to measure the count of page -* faults by applications running on the platform. It corresponds -* to the "perf.page_faults" field in the *Stats APIs. -* -* Since: v3.2.0 -*/ + * VIR_PERF_PARAM_PAGE_FAULTS: + * + * Macro for typed parameter name that represents page_faults + * perf event which can be used to measure the count of page + * faults by applications running on the platform. It corresponds + * to the "perf.page_faults" field in the *Stats APIs. + * + * Since: v3.2.0 + */ # define VIR_PERF_PARAM_PAGE_FAULTS "page_faults" /** -- 2.35.1

1 0

[PATCH][RESEND] processMonitorEOFEvent:fix delet Domain object about the new VM in processMonitorEOFEvent()
by Yi Wang 26 Apr '22

26 Apr '22

From: 王鹏钧10288409 <10288409@zte.intra@LIN-184C297BAE7.zte.com.cn> Virsh shutdown is executed firstly, virsh destroy is executed later, and VM is recreated again. In this process, due to will delet Domain object about the new VM in processMonitorEOFEvent(), which virDomainObjListRemove is called to remove objlist, the new VM cannot be found through virsh list command and qemu process is still running. Therefore, add virDomainObjListFindByName function checks to avoid delet Domain object about the new VM in objlist. This process chart of problem is as follows shutdown | destroy | create ============================+==================+=================== qemuMonitorIO | | qemuProcessHandleMonitorEOF | | | virDomainDestroy | | qemuProcessStop | | | qemuDomainCreateXML | | qemuProcessInit processMonitorEOFEvent | | qemuDomainRemoveInactive | | | | qemuProcessLaunch Signed-off-by: Wang PengJun <wang.pengjun1(a)zte.com.cn> Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> --- src/qemu/qemu_driver.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ee0963c30d..a504f89724 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4024,6 +4024,7 @@ processMonitorEOFEvent(virQEMUDriver *driver, const char *auditReason = "shutdown"; unsigned int stopFlags = 0; virObjectEvent *event = NULL; + virDomainObj *obj; if (qemuProcessBeginStopJob(driver, vm, VIR_JOB_DESTROY, true) < 0) return; @@ -4055,7 +4056,12 @@ processMonitorEOFEvent(virQEMUDriver *driver, virObjectEventStateQueue(driver->domainEventState, event); endjob: - qemuDomainRemoveInactive(driver, vm); + virObjectUnlock(vm); + obj = virDomainObjListFindByName(driver->domains, vm->def->name); + if (vm == obj) + qemuDomainRemoveInactive(driver, vm); + virDomainObjEndAPI(&obj); + virObjectLock(vm); qemuDomainObjEndJob(vm); } -- 2.27.0

1 0

[PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64
by Peter Krempa 26 Apr '22

26 Apr '22

Few minor changes in qemu since the last update: - PIIX4_PM gained 'x-not-migrate-acpi-index' property - 'cocoa' display and corresponding props (not present in this build) Changes in build: - dbus display driver re-enabled - gtk display support re-disabled - xen support re-disabled Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_7.0.0.x86_64.replies | 583 ++++++++---------- .../caps_7.0.0.x86_64.xml | 10 +- 2 files changed, 257 insertions(+), 336 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies index d1f453dcca..620442704a 100644 --- a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 92, - "minor": 2, - "major": 6 + "micro": 0, + "minor": 0, + "major": 7 }, - "package": "v7.0.0-rc2" + "package": "v7.0.0" }, "id": "libvirt-2" } @@ -5119,10 +5119,6 @@ "name": "135", "tag": "type", "variants": [ - { - "case": "gtk", - "type": "358" - }, { "case": "curses", "type": "360" @@ -5131,6 +5127,10 @@ "case": "egl-headless", "type": "361" }, + { + "case": "dbus", + "type": "362" + }, { "case": "default", "type": "0" @@ -10498,6 +10498,10 @@ "case": "qemu-vdagent", "type": "518" }, + { + "case": "dbus", + "type": "519" + }, { "case": "vc", "type": "520" @@ -11756,9 +11760,6 @@ { "name": "none" }, - { - "name": "gtk" - }, { "name": "sdl" }, @@ -11770,17 +11771,20 @@ }, { "name": "spice-app" + }, + { + "name": "dbus" } ], "meta-type": "enum", "values": [ "default", "none", - "gtk", "sdl", "egl-headless", "curses", - "spice-app" + "spice-app", + "dbus" ] }, { @@ -16067,6 +16071,9 @@ { "name": "qemu-vdagent" }, + { + "name": "dbus" + }, { "name": "vc" }, @@ -16097,6 +16104,7 @@ "spicevmc", "spiceport", "qemu-vdagent", + "dbus", "vc", "ringbuf", "memory" @@ -16202,6 +16210,16 @@ ], "meta-type": "object" }, + { + "name": "519", + "members": [ + { + "name": "data", + "type": "618" + } + ], + "meta-type": "object" + }, { "name": "520", "members": [ @@ -18460,6 +18478,26 @@ ], "meta-type": "object" }, + { + "name": "618", + "members": [ + { + "name": "logfile", + "default": null, + "type": "str" + }, + { + "name": "logappend", + "default": null, + "type": "bool" + }, + { + "name": "name", + "type": "str" + } + ], + "meta-type": "object" + }, { "name": "619", "members": [ @@ -20363,10 +20401,6 @@ "name": "acpi-erst", "parent": "pci-device" }, - { - "name": "virtio-crypto-device", - "parent": "virtio-device" - }, { "name": "isa-applesmc", "parent": "isa-device" @@ -20379,49 +20413,53 @@ "name": "vhost-user-input-pci", "parent": "vhost-user-input-pci-base-type" }, + { + "name": "usb-redir", + "parent": "usb-device" + }, { "name": "floppy-bus", "parent": "bus" }, { - "name": "Denverton-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "virtio-crypto-device", + "parent": "virtio-device" }, { "name": "chardev-testdev", "parent": "chardev" }, { - "name": "usb-wacom-tablet", - "parent": "usb-device" + "name": "Denverton-x86_64-cpu", + "parent": "x86_64-cpu" }, { - "name": "Icelake-Server-v1-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "pci-ipmi-bt", + "parent": "pci-device" }, { "name": "chardev-stdio", "parent": "chardev-fd" }, { - "name": "pci-ipmi-bt", - "parent": "pci-device" + "name": "usb-wacom-tablet", + "parent": "usb-device" }, { "name": "filter-buffer", "parent": "netfilter" }, { - "name": "secondary-vga", - "parent": "pci-vga" + "name": "Icelake-Server-v1-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "ich9-usb-uhci6", "parent": "pci-uhci-usb" }, { - "name": "usb-redir", - "parent": "usb-device" + "name": "secondary-vga", + "parent": "pci-vga" }, { "name": "kvm-pit", @@ -20451,14 +20489,14 @@ "name": "sev-guest", "parent": "confidential-guest-support" }, - { - "name": "core2duo-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "ich9-usb-uhci5", "parent": "pci-uhci-usb" }, + { + "name": "core2duo-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "pcm3680_pci", "parent": "pci-device" @@ -20619,10 +20657,6 @@ "name": "pxb-host", "parent": "pci-host-bridge" }, - { - "name": "virtio-scsi-pci", - "parent": "virtio-scsi-pci-base" - }, { "name": "virtio-input-host-pci", "parent": "virtio-input-host-pci-base-type" @@ -20744,8 +20778,8 @@ "parent": "virtio-device" }, { - "name": "xenfv-4.2-machine", - "parent": "generic-pc-machine" + "name": "virtio-scsi-pci", + "parent": "virtio-scsi-pci-base" }, { "name": "ipmi-bmc-extern", @@ -20855,10 +20889,6 @@ "name": "pr-manager-helper", "parent": "pr-manager" }, - { - "name": "virtio-scsi-device", - "parent": "virtio-scsi-common" - }, { "name": "pc-i440fx-2.10-machine", "parent": "generic-pc-machine" @@ -20872,20 +20902,16 @@ "parent": "pci-device" }, { - "name": "xen-pci-passthrough", - "parent": "pci-device" - }, - { - "name": "Haswell-IBRS-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "virtio-scsi-device", + "parent": "virtio-scsi-common" }, { "name": "pxb-pcie", "parent": "pci-device" }, { - "name": "cpu-cluster", - "parent": "device" + "name": "Haswell-IBRS-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "vhost-user-i2c-pci", @@ -20896,7 +20922,7 @@ "parent": "object" }, { - "name": "xen-backend", + "name": "cpu-cluster", "parent": "device" }, { @@ -20904,16 +20930,16 @@ "parent": "sys-bus-device" }, { - "name": "Haswell-v3-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "i82557a", + "parent": "pci-device" }, { "name": "vhost-user-scsi-pci-non-transitional", "parent": "vhost-user-scsi-pci-base" }, { - "name": "i82557a", - "parent": "pci-device" + "name": "vmmouse", + "parent": "isa-device" }, { "name": "chardev-udp", @@ -20932,8 +20958,8 @@ "parent": "virtio-scsi-pci-base" }, { - "name": "vmmouse", - "parent": "isa-device" + "name": "Haswell-v3-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "migration", @@ -20976,8 +21002,8 @@ "parent": "x86_64-cpu" }, { - "name": "vhost-vsock-device", - "parent": "vhost-vsock-common" + "name": "chardev-dbus", + "parent": "chardev-socket" }, { "name": "Broadwell-v2-x86_64-cpu", @@ -20995,10 +21021,6 @@ "name": "EPYC-IBPB-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "Skylake-Server-v5-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "ib700", "parent": "isa-device" @@ -21008,7 +21030,7 @@ "parent": "x86-iommu" }, { - "name": "Nehalem-v2-x86_64-cpu", + "name": "Skylake-Server-v5-x86_64-cpu", "parent": "x86_64-cpu" }, { @@ -21016,16 +21038,16 @@ "parent": "virtio-9p-pci-base" }, { - "name": "igd-passthrough-i440FX", - "parent": "i440FX" + "name": "Nehalem-v2-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "memory-backend-file", "parent": "memory-backend" }, { - "name": "xen-disk", - "parent": "xen-block" + "name": "vhost-vsock-device", + "parent": "vhost-vsock-common" }, { "name": "isa-pcspk", @@ -21036,25 +21058,21 @@ "parent": "vhost-scsi-common" }, { - "name": "usb-tablet", - "parent": "usb-hid" + "name": "sd-card", + "parent": "device" }, { "name": "sysbus-ahci", "parent": "sys-bus-device" }, { - "name": "sd-card", - "parent": "device" + "name": "usb-tablet", + "parent": "usb-hid" }, { "name": "pc-q35-4.0.1-machine", "parent": "generic-pc-machine" }, - { - "name": "IvyBridge-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "virtio-blk-pci-non-transitional", "parent": "virtio-blk-pci-base" @@ -21064,13 +21082,17 @@ "parent": "device" }, { - "name": "ne2k_pci", - "parent": "pci-device" + "name": "IvyBridge-v2-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "isabus-bridge", "parent": "sys-bus-device" }, + { + "name": "ne2k_pci", + "parent": "pci-device" + }, { "name": "usb-bus", "parent": "bus" @@ -21087,18 +21109,10 @@ "name": "tcg-accel", "parent": "accel" }, - { - "name": "i82551", - "parent": "pci-device" - }, { "name": "virtio-balloon-pci", "parent": "virtio-balloon-pci-base" }, - { - "name": "Cascadelake-Server-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "virtio-gpu-device", "parent": "virtio-gpu-base" @@ -21107,6 +21121,10 @@ "name": "e1000", "parent": "e1000-base" }, + { + "name": "Cascadelake-Server-v2-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "athlon-v1-x86_64-cpu", "parent": "x86_64-cpu" @@ -21124,8 +21142,8 @@ "parent": "generic-pc-machine" }, { - "name": "xen-apic", - "parent": "apic-common" + "name": "i82551", + "parent": "pci-device" }, { "name": "EPYC-v1-x86_64-cpu", @@ -21159,14 +21177,14 @@ "name": "pc-q35-6.0-machine", "parent": "generic-pc-machine" }, - { - "name": "mioe3680_pci", - "parent": "pci-device" - }, { "name": "vhost-user-backend", "parent": "object" }, + { + "name": "mioe3680_pci", + "parent": "pci-device" + }, { "name": "vmxnet3", "parent": "pci-device" @@ -21204,24 +21222,24 @@ "parent": "smbus-device" }, { - "name": "virtio-serial-device", - "parent": "virtio-device" + "name": "dbus-display", + "parent": "object" }, { - "name": "virtio-serial-pci", - "parent": "virtio-serial-pci-base" + "name": "vhost-user-gpu-pci", + "parent": "vhost-user-gpu-pci-base-type" }, { - "name": "Denverton-v2-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "virtio-serial-pci", + "parent": "virtio-serial-pci-base" }, { - "name": "xen-bridge", - "parent": "sys-bus-device" + "name": "virtio-serial-device", + "parent": "virtio-device" }, { - "name": "vhost-user-gpu-pci", - "parent": "vhost-user-gpu-pci-base-type" + "name": "Denverton-v2-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "iothread", @@ -21243,14 +21261,14 @@ "name": "ati-vga", "parent": "pci-device" }, - { - "name": "pentium3-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "kvm-i8259", "parent": "pic-common" }, + { + "name": "pentium3-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "isa-serial", "parent": "isa-device" @@ -21311,18 +21329,10 @@ "name": "Opteron_G3-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "xen-cdrom", - "parent": "xen-block" - }, { "name": "Cooperlake-v2-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "EPYC-v3-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "isa-ide", "parent": "isa-device" @@ -21332,13 +21342,17 @@ "parent": "x86_64-cpu" }, { - "name": "sgx-epc", - "parent": "device" + "name": "EPYC-v3-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "scsi-cd", "parent": "scsi-disk-base" }, + { + "name": "sgx-epc", + "parent": "device" + }, { "name": "gpex-root", "parent": "pci-device" @@ -21407,17 +21421,13 @@ "name": "VGA", "parent": "pci-vga" }, - { - "name": "i440FX", - "parent": "pci-device" - }, { "name": "qio-channel-buffer", "parent": "qio-channel" }, { - "name": "xen-bus", - "parent": "bus" + "name": "i440FX", + "parent": "pci-device" }, { "name": "Penryn-v1-x86_64-cpu", @@ -21436,16 +21446,16 @@ "parent": "virtio-device" }, { - "name": "Icelake-Server-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "pc-i440fx-3.1-machine", + "parent": "generic-pc-machine" }, { "name": "pci-serial-4x", "parent": "pci-device" }, { - "name": "pc-i440fx-3.1-machine", - "parent": "generic-pc-machine" + "name": "Icelake-Server-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "sga", @@ -21516,11 +21526,11 @@ "parent": "usb-device" }, { - "name": "IvyBridge-x86_64-cpu", + "name": "SandyBridge-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "SandyBridge-v1-x86_64-cpu", + "name": "IvyBridge-x86_64-cpu", "parent": "x86_64-cpu" }, { @@ -21583,10 +21593,6 @@ "name": "ccid-bus", "parent": "bus" }, - { - "name": "xen-pvdevice", - "parent": "pci-device" - }, { "name": "ide-hd", "parent": "ide-device" @@ -21619,14 +21625,14 @@ "name": "pc-i440fx-4.1-machine", "parent": "generic-pc-machine" }, - { - "name": "e1000-82544gc", - "parent": "e1000-base" - }, { "name": "chardev-spiceport", "parent": "chardev-spice" }, + { + "name": "e1000-82544gc", + "parent": "e1000-base" + }, { "name": "tls-creds-x509", "parent": "tls-creds" @@ -21659,10 +21665,6 @@ "name": "isa-cirrus-vga", "parent": "isa-device" }, - { - "name": "pvrdma", - "parent": "pci-device" - }, { "name": "qemu64-x86_64-cpu", "parent": "x86_64-cpu" @@ -21671,6 +21673,10 @@ "name": "Skylake-Server-v2-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "chardev-braille", + "parent": "chardev" + }, { "name": "pc-q35-4.1-machine", "parent": "generic-pc-machine" @@ -21703,14 +21709,14 @@ "name": "pc-testdev", "parent": "isa-device" }, - { - "name": "qio-channel-websock", - "parent": "qio-channel" - }, { "name": "megasas", "parent": "megasas-base" }, + { + "name": "qio-channel-websock", + "parent": "qio-channel" + }, { "name": "virtio-iommu-pci", "parent": "virtio-iommu-pci-base-type" @@ -21719,21 +21725,17 @@ "name": "pc-i440fx-6.1-machine", "parent": "generic-pc-machine" }, - { - "name": "vmcoreinfo", - "parent": "device" - }, { "name": "Icelake-Client-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "tpci200", - "parent": "pci-device" + "name": "vmcoreinfo", + "parent": "device" }, { - "name": "chardev-braille", - "parent": "chardev" + "name": "tpci200", + "parent": "pci-device" }, { "name": "rocker", @@ -21767,10 +21769,6 @@ "name": "qemu-console", "parent": "object" }, - { - "name": "chardev-socket", - "parent": "chardev" - }, { "name": "clock", "parent": "object" @@ -21808,20 +21806,20 @@ "parent": "device" }, { - "name": "Skylake-Server-IBRS-x86_64-cpu", + "name": "Cascadelake-Server-noTSX-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "virtio-pmem", - "parent": "virtio-device" + "name": "chardev-socket", + "parent": "chardev" }, { "name": "nvme-bus", "parent": "bus" }, { - "name": "xen-sysbus", - "parent": "bus" + "name": "virtconsole", + "parent": "virtserialport" }, { "name": "virtio-net-pci-non-transitional", @@ -21839,14 +21837,14 @@ "name": "scsi-hd", "parent": "scsi-disk-base" }, - { - "name": "Cascadelake-Server-noTSX-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "usb-kbd", "parent": "usb-hid" }, + { + "name": "lsi53c810", + "parent": "lsi53c895a" + }, { "name": "isa-fdc", "parent": "isa-device" @@ -21872,24 +21870,24 @@ "parent": "object" }, { - "name": "Westmere-v2-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "ccid-card-emulated", + "parent": "ccid-card" }, { "name": "pc-q35-2.9-machine", "parent": "generic-pc-machine" }, { - "name": "Skylake-Client-v1-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "virtio-pmem", + "parent": "virtio-device" }, { "name": "tpm-tis", "parent": "isa-device" }, { - "name": "virtconsole", - "parent": "virtserialport" + "name": "Skylake-Server-IBRS-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "hyperv-testdev", @@ -21912,8 +21910,8 @@ "parent": "generic-pc-machine" }, { - "name": "ccid-card-emulated", - "parent": "ccid-card" + "name": "Westmere-v2-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "pc-q35-5.1-machine", @@ -21928,8 +21926,8 @@ "parent": "virtio-input-hid-device" }, { - "name": "lsi53c810", - "parent": "lsi53c895a" + "name": "Skylake-Client-v1-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "ioh3420", @@ -22031,10 +22029,6 @@ "name": "phenom-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "virtio-net-pci-transitional", - "parent": "virtio-net-pci-base" - }, { "name": "vhost-vsock-pci", "parent": "vhost-vsock-pci-base" @@ -22044,8 +22038,8 @@ "parent": "device" }, { - "name": "vhost-user-blk-pci-transitional", - "parent": "vhost-user-blk-pci-base" + "name": "virtio-net-pci-transitional", + "parent": "virtio-net-pci-base" }, { "name": "irq", @@ -22072,8 +22066,8 @@ "parent": "x86_64-cpu" }, { - "name": "xenfv-3.1-machine", - "parent": "generic-pc-machine" + "name": "vhost-user-blk-pci-transitional", + "parent": "vhost-user-blk-pci-base" }, { "name": "coreduo-x86_64-cpu", @@ -22159,21 +22153,17 @@ "name": "Skylake-Server-v4-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "kvmvapic", - "parent": "sys-bus-device" - }, { "name": "Nehalem-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "nvme-ns", - "parent": "device" + "name": "kvmvapic", + "parent": "sys-bus-device" }, { - "name": "authz-simple", - "parent": "authz" + "name": "nvme-ns", + "parent": "device" }, { "name": "Icelake-Server-v6-x86_64-cpu", @@ -22192,8 +22182,8 @@ "parent": "vhost-user-blk-pci-base" }, { - "name": "xen-accel", - "parent": "accel" + "name": "authz-simple", + "parent": "authz" }, { "name": "fw_cfg_io", @@ -22311,18 +22301,10 @@ "name": "qemu32-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "xen-sysdev", - "parent": "sys-bus-device" - }, { "name": "Haswell-noTSX-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "chardev-null", - "parent": "chardev" - }, { "name": "pci-serial", "parent": "pci-device" @@ -22351,10 +22333,6 @@ "name": "Opteron_G4-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "qio-channel-rdma", - "parent": "qio-channel" - }, { "name": "ne2k_isa", "parent": "isa-device" @@ -22375,14 +22353,14 @@ "name": "vhost-user-gpu", "parent": "virtio-gpu-base" }, - { - "name": "pentium-v1-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "hda-duplex", "parent": "hda-audio" }, + { + "name": "pentium-v1-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "amd-iommu-iommu-memory-region", "parent": "iommu-memory-region" @@ -22396,17 +22374,13 @@ "parent": "pci-device" }, { - "name": "Cooperlake-v1-x86_64-cpu", + "name": "Nehalem-IBRS-x86_64-cpu", "parent": "x86_64-cpu" }, { "name": "Cascadelake-Server-v3-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "vhost-user-rng-pci", - "parent": "vhost-user-rng-pci-base" - }, { "name": "cfi.pflash01", "parent": "sys-bus-device" @@ -22416,8 +22390,12 @@ "parent": "virtio-device" }, { - "name": "isa-parallel", - "parent": "isa-device" + "name": "chardev-null", + "parent": "chardev" + }, + { + "name": "Cooperlake-v1-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "Skylake-Server-x86_64-cpu", @@ -22428,16 +22406,16 @@ "parent": "generic-pc-machine" }, { - "name": "Nehalem-IBRS-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "isa-parallel", + "parent": "isa-device" }, { "name": "pentium2-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { - "name": "xen-platform", - "parent": "pci-device" + "name": "vhost-user-rng-pci", + "parent": "vhost-user-rng-pci-base" }, { "name": "isa-vga", @@ -22476,20 +22454,20 @@ "parent": "rng-backend" }, { - "name": "Cascadelake-Server-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "qxl-vga", + "parent": "pci-qxl" }, { "name": "i82558b", "parent": "pci-device" }, { - "name": "ivshmem-doorbell", - "parent": "ivshmem-common" + "name": "Cascadelake-Server-x86_64-cpu", + "parent": "x86_64-cpu" }, { - "name": "qxl-vga", - "parent": "pci-qxl" + "name": "ivshmem-doorbell", + "parent": "ivshmem-common" }, { "name": "PIIX3-xen", @@ -22672,8 +22650,8 @@ "parent": "x86_64-cpu" }, { - "name": "kvm64-v1-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "pcie-root-port", + "parent": "pcie-root-port-base" }, { "name": "IDE", @@ -22684,8 +22662,8 @@ "parent": "x86_64-cpu" }, { - "name": "pcie-root-port", - "parent": "pcie-root-port-base" + "name": "kvm64-v1-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "mptsas1068", @@ -22696,17 +22674,13 @@ "parent": "scsi-disk-base" }, { - "name": "xenpv-machine", - "parent": "machine" + "name": "chardev-spicevmc", + "parent": "chardev-spice" }, { "name": "Snowridge-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "chardev-spicevmc", - "parent": "chardev-spice" - }, { "name": "q35-pcihost", "parent": "pcie-host-bridge" @@ -22771,6 +22745,10 @@ "name": "vhost-user-blk", "parent": "virtio-device" }, + { + "name": "SandyBridge-v2-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "nvme-subsys", "parent": "device" @@ -22779,10 +22757,6 @@ "name": "Haswell-noTSX-IBRS-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "SandyBridge-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "pc-q35-5.2-machine", "parent": "generic-pc-machine" @@ -24538,6 +24512,11 @@ "name": "smm-compat", "type": "bool" }, + { + "default-value": false, + "name": "x-not-migrate-acpi-index", + "type": "bool" + }, { "default-value": 2, "name": "s4_val", @@ -29178,13 +29157,6 @@ "deprecated": false, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": false, - "name": "xenpv", - "numa-mem-supported": false, - "cpu-max": 1, - "deprecated": false - }, { "hotpluggable-cpus": true, "name": "pc-i440fx-6.2", @@ -29283,16 +29255,6 @@ "deprecated": false, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": true, - "name": "xenfv-3.1", - "numa-mem-supported": true, - "default-cpu-type": "qemu64-x86_64-cpu", - "cpu-max": 128, - "deprecated": false, - "default-ram-id": "pc.ram", - "alias": "xenfv" - }, { "hotpluggable-cpus": true, "name": "pc-q35-2.4", @@ -29582,15 +29544,6 @@ "deprecated": false, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": true, - "name": "xenfv-4.2", - "numa-mem-supported": true, - "default-cpu-type": "qemu64-x86_64-cpu", - "cpu-max": 128, - "deprecated": false, - "default-ram-id": "pc.ram" - }, { "hotpluggable-cpus": false, "name": "microvm", @@ -32035,41 +31988,6 @@ ], "option": "machine" }, - { - "parameters": [ - { - "name": "timeout", - "help": "Request timeout in seconds (default 0 = no timeout)", - "type": "number" - }, - { - "name": "initiator-name", - "help": "Initiator iqn name to use when connecting", - "type": "string" - }, - { - "name": "header-digest", - "help": "HeaderDigest setting. {CRC32C|CRC32C-NONE|NONE-CRC32C|NONE}", - "type": "string" - }, - { - "name": "password-secret", - "help": "ID of the secret providing password for CHAP authentication to target", - "type": "string" - }, - { - "name": "password", - "help": "password for CHAP authentication to target", - "type": "string" - }, - { - "name": "user", - "help": "username for CHAP authentication to target", - "type": "string" - } - ], - "option": "iscsi" - }, { "parameters": [ { @@ -32203,6 +32121,41 @@ ], "option": "spice" }, + { + "parameters": [ + { + "name": "timeout", + "help": "Request timeout in seconds (default 0 = no timeout)", + "type": "number" + }, + { + "name": "initiator-name", + "help": "Initiator iqn name to use when connecting", + "type": "string" + }, + { + "name": "header-digest", + "help": "HeaderDigest setting. {CRC32C|CRC32C-NONE|NONE-CRC32C|NONE}", + "type": "string" + }, + { + "name": "password-secret", + "help": "ID of the secret providing password for CHAP authentication to target", + "type": "string" + }, + { + "name": "password", + "help": "password for CHAP authentication to target", + "type": "string" + }, + { + "name": "user", + "help": "username for CHAP authentication to target", + "type": "string" + } + ], + "option": "iscsi" + }, { "parameters": [ ], @@ -37593,13 +37546,6 @@ "deprecated": false, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": false, - "name": "xenpv", - "numa-mem-supported": false, - "cpu-max": 1, - "deprecated": false - }, { "hotpluggable-cpus": true, "name": "pc-i440fx-6.2", @@ -37698,16 +37644,6 @@ "deprecated": false, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": true, - "name": "xenfv-3.1", - "numa-mem-supported": true, - "default-cpu-type": "qemu64-x86_64-cpu", - "cpu-max": 128, - "deprecated": false, - "default-ram-id": "pc.ram", - "alias": "xenfv" - }, { "hotpluggable-cpus": true, "name": "pc-q35-2.4", @@ -37997,15 +37933,6 @@ "deprecated": false, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": true, - "name": "xenfv-4.2", - "numa-mem-supported": true, - "default-cpu-type": "qemu64-x86_64-cpu", - "cpu-max": 128, - "deprecated": false, - "default-ram-id": "pc.ram" - }, { "hotpluggable-cpus": false, "name": "microvm", diff --git a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml index 87f9b4068d..8074c97ecd 100644 --- a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml @@ -242,10 +242,10 @@ <flag name='virtio-iommu-pci'/> <flag name='virtio-iommu.boot-bypass'/> <flag name='virtio-net.rss'/> - <version>6002092</version> + <version>7000000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100243</microcodeVersion> - <package>v7.0.0-rc2</package> + <package>v7.0.0</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -1617,7 +1617,6 @@ <machine type='kvm' name='pc-q35-5.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-2.12' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-2.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> - <machine type='kvm' name='xenpv' maxCpus='1'/> <machine type='kvm' name='pc-i440fx-6.2' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-4.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-2.5' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> @@ -1628,7 +1627,6 @@ <machine type='kvm' name='pc-i440fx-2.2' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-2.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-6.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> - <machine type='kvm' name='xenfv-3.1' alias='xenfv' hotplugCpus='yes' maxCpus='128' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-2.4' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-2.10' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='x-remote' maxCpus='1'/> @@ -1660,7 +1658,6 @@ <machine type='kvm' name='pc-q35-3.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-6.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-q35-4.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> - <machine type='kvm' name='xenfv-4.2' hotplugCpus='yes' maxCpus='128' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='microvm' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='microvm.ram'/> <machine type='kvm' name='pc-i440fx-2.3' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='kvm' name='pc-i440fx-4.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> @@ -3723,7 +3720,6 @@ <machine type='tcg' name='pc-q35-5.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-2.12' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-2.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> - <machine type='tcg' name='xenpv' maxCpus='1'/> <machine type='tcg' name='pc-i440fx-6.2' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-4.2' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-2.5' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> @@ -3734,7 +3730,6 @@ <machine type='tcg' name='pc-i440fx-2.2' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-2.7' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-6.1' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> - <machine type='tcg' name='xenfv-3.1' alias='xenfv' hotplugCpus='yes' maxCpus='128' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-2.4' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-2.10' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='x-remote' maxCpus='1'/> @@ -3766,7 +3761,6 @@ <machine type='tcg' name='pc-q35-3.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-6.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-q35-4.0' hotplugCpus='yes' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> - <machine type='tcg' name='xenfv-4.2' hotplugCpus='yes' maxCpus='128' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='microvm' maxCpus='288' defaultCPU='qemu64-x86_64-cpu' defaultRAMid='microvm.ram'/> <machine type='tcg' name='pc-i440fx-2.3' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> <machine type='tcg' name='pc-i440fx-4.0' hotplugCpus='yes' maxCpus='255' defaultCPU='qemu64-x86_64-cpu' numaMemSupported='yes' defaultRAMid='pc.ram'/> -- 2.35.1

5 13

[PATCH 0/7] qemu: Fix broken qemu caps cache invalidation
by Peter Krempa 25 Apr '22

25 Apr '22

Bugs in the code meant to invalidate the qemu capabilities cache resulted in us always re-probing capabilities on startup of libvirtd/virtqemud. This got extremely annoying with the modern deployments using --timeout. Apart from issues in inserting the detected features, it also turns out that AMD boxes report data which changes based on which CPU the instruction happened to execute, so we need to mask that out. Peter Krempa (7): virCPUx86DataIsIdentical: Add debug output virCPUx86DataGetHost: Fix construction of the returned data virHostCPUGetCPUID: Add comment on how KVM_GET_SUPPORTED_CPUID works util: virhostcpu: Extract filtering of the returned data from virHostCPUGetCPUID virHostCPUGetCPUID: Fix possible allocation of huge amount of memory virHostCPUGetCPUID: Limit the buffer size ranges virHostCPUGetCPUIDFilterVolatile: Filter out topology data on AMD src/cpu/cpu_x86.c | 31 ++++++++++--- src/util/virhostcpu.c | 104 ++++++++++++++++++++++++++++++++++++------ 2 files changed, 116 insertions(+), 19 deletions(-) -- 2.35.1

3 9

[PATCH 0/2] tests: Turn testQemuPrepareHostBackendChardevOne() into proper mock
by Michal Privoznik 25 Apr '22

25 Apr '22

*** BLURB HERE *** Michal Prívozník (2): qemu_processpriv: Fix #error message tests: Turn testQemuPrepareHostBackendChardevOne() into proper mock src/qemu/qemu_process.c | 13 +---- src/qemu/qemu_processpriv.h | 20 ++++++- tests/qemuhotplugmock.c | 11 ---- tests/qemuhotplugtest.c | 1 + tests/qemumonitorjsontest.c | 7 ++- tests/qemuxml2argvmock.c | 94 +++++++++++++++++++++++++++++++ tests/qemuxml2argvtest.c | 10 ++-- tests/testutilsqemu.c | 107 +----------------------------------- tests/testutilsqemu.h | 4 -- 9 files changed, 127 insertions(+), 140 deletions(-) -- 2.35.1

3 5

[PATCH 0/2] virsh: Fix bug in XML generator of cmdBlockcopy
by Peter Krempa 25 Apr '22

25 Apr '22

Peter Krempa (2): virsh: cmdBlockcopy: Add '--print-xml' flag virsh: cmdBlockcopy: Fix generator of block copy disk XML docs/manpages/virsh.rst | 4 +++- tools/virsh-domain.c | 24 +++++++++++++++++------- 2 files changed, 20 insertions(+), 8 deletions(-) -- 2.35.1

2 3

[libvirt RFC] qemu_saveimage: only use wrapper when using --bypass-cache
by Claudio Fontana 25 Apr '22

25 Apr '22

align the "save" with the "restore" code, by only using the wrapper when using --bypass-cache. This avoids a copy, resulting in better performance. Signed-off-by: Claudio Fontana <cfontana(a)suse.de> --- src/qemu/qemu_saveimage.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index 4fd4c5cfcd..5ea1b2fbcc 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -289,8 +289,10 @@ qemuSaveImageCreate(virQEMUDriver *driver, if (qemuSecuritySetImageFDLabel(driver->securityManager, vm->def, fd) < 0) goto cleanup; - if (!(wrapperFd = virFileWrapperFdNew(&fd, path, wrapperFlags))) - goto cleanup; + if ((flags & VIR_DOMAIN_SAVE_BYPASS_CACHE)) { + if (!(wrapperFd = virFileWrapperFdNew(&fd, path, wrapperFlags))) + goto cleanup; + } if (virQEMUSaveDataWrite(data, fd, path) < 0) goto cleanup; -- 2.34.1

3 15

[PATCH 00/11] qemu: Fix crash when attempting to use authentication for HTTP backed disks
by Peter Krempa 23 Apr '22

23 Apr '22

The crash is fixed by properly instantiating the auth object. Also this series cleans up some problems noticed along the way. Peter Krempa (11): conf: schema: Fix alignment in 'diskSourceNetworkProtocolHTTPS' schema definition qemuDomainValidateStorageSource: Reorganize encryption config validation qemuDomainValidateStorageSource: Add validation of 'encryption' support qemuBlockStorageSourceGetRBDProps: Simplify handling of encryption format virDomainDiskDefValidateSourceChainOne: Reject authentication for protocols which don't support it qemuDomainStorageSourceHasAuth: Don't decide based on protocol qemu: domain: Inline qemuDomainDiskHasEncryptionSecret qemu: domain: Inline qemuDomainStorageSourceHasAuth conf: schemas: Split out definition for 'ftp' protocol conf: schema: Allow authentication for FTP(S) and HTTP(S) disks tests: qemuxml2*: Add testing of authenticated http/ftp disks src/conf/domain_validate.c | 34 ++++++ src/conf/schemas/domaincommon.rng | 35 +++++- src/qemu/qemu_block.c | 10 +- src/qemu/qemu_domain.c | 103 ++++++------------ src/qemu/qemu_domain.h | 3 - .../disk-cdrom-network.x86_64-4.1.0.args | 6 +- .../disk-cdrom-network.x86_64-latest.args | 6 +- tests/qemuxml2argvdata/disk-cdrom-network.xml | 6 + .../disk-encryption-wrong.x86_64-latest.err | 1 + .../disk-encryption-wrong.xml | 37 +++++++ ...-network-rbd-encryption.x86_64-latest.args | 2 +- .../disk-network-rbd-encryption.xml | 2 +- tests/qemuxml2argvtest.c | 1 + .../disk-cdrom-network.x86_64-latest.xml | 72 ++++++++++++ ...k-network-rbd-encryption.x86_64-latest.xml | 2 +- tests/qemuxml2xmltest.c | 1 + 16 files changed, 233 insertions(+), 88 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-encryption-wrong.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/disk-encryption-wrong.xml create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-network.x86_64-latest.xml -- 2.35.1

2 13

[libvirt RFC v2 00/11] multifd save prototype
by Claudio Fontana 23 Apr '22

23 Apr '22

This is the multifd save prototype in its first semi-functional state, (save direction only), with surely a lot of rough edges as I am not very familiar with the libvirt code base yet or its rules. It seems to work for me, but take a look if this is something realistic to pursue further, whether this could be acceptable for libvirt. Claudio Fontana (11): libvirt: introduce virDomainSaveParametersFlags public API remote: Add RPC support for the virDomainSaveParametersFlags API qemu: add a stub for virDomainSaveParametersFlags API qemu: initial implementation for the virDomainSaveParametersFlags API iohelper: move runIO function to a separate module runio: add arguments to extend use beyond just stdin and stdout multifd-helper: new helper for parallel saves qemu: wire up saveimage code with the multifd helper qemu: implement qemuMigrationSrcToFilesMultiFd tools: add parallel parameter to virsh save command qemu: add migration parameter multifd-compression docs/manpages/virsh.rst | 23 ++- include/libvirt/libvirt-domain.h | 9 + src/driver-hypervisor.h | 7 + src/libvirt-domain.c | 51 ++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 5 + src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 66 +++++++- src/qemu/qemu_migration.c | 135 ++++++++++----- src/qemu/qemu_migration.h | 7 + src/qemu/qemu_migration_params.c | 71 +++++--- src/qemu/qemu_migration_params.h | 15 ++ src/qemu/qemu_saveimage.c | 281 ++++++++++++++++++++++++++----- src/qemu/qemu_saveimage.h | 9 + src/qemu/qemu_snapshot.c | 2 +- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 +- src/remote_protocol-structs | 9 + src/util/iohelper.c | 180 +------------------- src/util/meson.build | 15 ++ src/util/multifd-helper.c | 205 ++++++++++++++++++++++ src/util/runio.c | 214 +++++++++++++++++++++++ src/util/runio.h | 38 +++++ src/util/virthread.c | 5 + src/util/virthread.h | 1 + tools/virsh-domain.c | 49 +++++- 27 files changed, 1108 insertions(+), 312 deletions(-) create mode 100644 src/util/multifd-helper.c create mode 100644 src/util/runio.c create mode 100644 src/util/runio.h -- 2.34.1

1 11