April 2022 - Devel - libvirt List Archives

[PATCH] NEWS: Mention 'manual' snapshots and FD passing for 'virsh qemu-monitor-command'
by Peter Krempa 01 Apr '22

01 Apr '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 754687ac4d..900e2702dd 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v8.2.0 (unreleased) * **New features** + * qemu: Introduce ``manual`` disk snapshot mode + + This new mode allows users to synchronize libvirt snapshots with snapshots + which need to be done outside of libvirt e.g. when 'vhost-user-blk' is used + to back the disk. + * **Improvements** * qemu: ``VIR_MIGRATE_PARAM_TLS_DESTINATION`` now works with non-shared storage migration @@ -32,6 +38,11 @@ v8.2.0 (unreleased) specify the overrides instead of relying on the argv passthrough of the ``-set`` qemu commandline option which no longer works with new qemu. + * qemu: Allow passing file descriptors to ``virsh qemu-monitor-command`` + + Passing FDs allows users wanting to experiment with qemu driven by libvirt + use commands like ``add-fd`` properly. + * **Bug fixes** * Both build and tests should now pass on Alpine Linux or any other -- 2.35.1

2 1

[libvirt PATCH 0/3] tests: Update capabilities for QEMU 7.0.0
by Andrea Bolognani 01 Apr '22

01 Apr '22

Heavily snipped to accomodate mailing list size limits, get the full version with $ git fetch https://gitlab.com/abologna/libvirt.git caps-7.0.0 I'm going to push these as a straightforward capabilities update later today, once the 8.3.0 development cycle opens, unless somebody shouts about it. They are a prerequisite for my virtio-iommu patches[1], for which I'll send out a respin after merging these. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/506156899 [1] https://listman.redhat.com/archives/libvir-list/2022-March/229397.html Andrea Bolognani (3): tests: Update capabilities for QEMU 7.0.0 on x86_64 tests: Update capabilities for QEMU 7.0.0 on ppc64 tests: Add capabilities for QEMU 7.0.0 on aarch64 .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + ....ppc64.xml => qemu_7.0.0-virt.aarch64.xml} | 75 +- ...7.0.0.ppc64.xml => qemu_7.0.0.aarch64.xml} | 65 +- tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 2 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + ...c64.replies => caps_7.0.0.aarch64.replies} | 15654 +++++++--------- .../caps_7.0.0.aarch64.xml | 552 + .../caps_7.0.0.ppc64.replies | 2400 ++- .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 27 +- .../caps_7.0.0.x86_64.replies | 2211 ++- .../caps_7.0.0.x86_64.xml | 90 +- ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 6 +- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 6 +- .../aarch64-tpm.aarch64-latest.args | 2 +- .../aarch64-virt-graphics.aarch64-latest.args | 36 +- .../aarch64-virt-headless.aarch64-latest.args | 28 +- .../cpu-host-model.x86_64-latest.args | 2 +- ...ult-video-type-aarch64.aarch64-latest.args | 6 +- ...default-video-type-ppc64.ppc64-latest.args | 1 + .../disk-arm-virtio-sd.aarch64-latest.args | 2 +- ...e-expander-bus-aarch64.aarch64-latest.args | 2 +- ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 1 + ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 1 + ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 1 + ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 1 + ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 1 + ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 1 + .../ppc64-pseries-graphics.ppc64-latest.args | 1 + .../ppc64-pseries-headless.ppc64-latest.args | 1 + .../ppc64-tpmproxy-single.ppc64-latest.args | 1 + .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 1 + .../tpm-emulator-spapr.ppc64-latest.args | 1 + 32 files changed, 10525 insertions(+), 10655 deletions(-) copy tests/domaincapsdata/{qemu_7.0.0.ppc64.xml => qemu_7.0.0-virt.aarch64.xml} (58%) copy tests/domaincapsdata/{qemu_7.0.0.ppc64.xml => qemu_7.0.0.aarch64.xml} (60%) copy tests/qemucapabilitiesdata/{caps_7.0.0.ppc64.replies => caps_7.0.0.aarch64.replies} (77%) create mode 100644 tests/qemucapabilitiesdata/caps_7.0.0.aarch64.xml -- 2.35.1

1 3

[PATCH] virsh: Provide completer for virtualization types
by natto1784 01 Apr '22

01 Apr '22

Related: https://gitlab.com/libvirt/libvirt/-/issues/9 Signed-off-by: natto1784 <natto(a)weirdnatto.in> --- .gitignore | 4 ++++ tools/virsh-completer-host.c | 12 ++++++++++++ tools/virsh-completer-host.h | 5 +++++ tools/virsh-host.c | 3 +++ 4 files changed, 24 insertions(+) diff --git a/.gitignore b/.gitignore index 4695391..62012f4 100644 --- a/.gitignore +++ b/.gitignore @@ -23,4 +23,8 @@ tags # clangd related ignores .clangd +.cache/clangd compile_commands.json + +# ccls cache +.ccls-cache diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c index 40cb687..e481a73 100644 --- a/tools/virsh-completer-host.c +++ b/tools/virsh-completer-host.c @@ -27,6 +27,7 @@ #include "virxml.h" #include "virutil.h" #include "virsh-host.h" +#include "conf/domain_conf.h" static char * virshPagesizeNodeToString(xmlNodePtr node) @@ -180,3 +181,14 @@ virshNodeSuspendTargetCompleter(vshControl *ctl G_GNUC_UNUSED, return virshEnumComplete(VIR_NODE_SUSPEND_TARGET_LAST, virshNodeSuspendTargetTypeToString); } + +char ** +virshVirtTypeCompleter(vshControl *ctl G_GNUC_UNUSED, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + virCheckFlags(0, NULL); + + return virshEnumComplete(VIR_DOMAIN_VIRT_LAST, + virDomainVirtTypeToString); +} diff --git a/tools/virsh-completer-host.h b/tools/virsh-completer-host.h index e71ccff..372ac14 100644 --- a/tools/virsh-completer-host.h +++ b/tools/virsh-completer-host.h @@ -41,3 +41,8 @@ char ** virshNodeSuspendTargetCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** +virshVirtTypeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 2e3cbc3..b28f29f 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -77,6 +77,7 @@ static const vshCmdInfo info_domcapabilities[] = { static const vshCmdOptDef opts_domcapabilities[] = { {.name = "virttype", .type = VSH_OT_STRING, + .completer = virshVirtTypeCompleter, .help = N_("virtualization type (/domain/@type)"), }, {.name = "emulatorbin", @@ -1577,6 +1578,7 @@ static const vshCmdOptDef opts_hypervisor_cpu_compare[] = { VIRSH_COMMON_OPT_FILE(N_("file containing an XML CPU description")), {.name = "virttype", .type = VSH_OT_STRING, + .completer = virshVirtTypeCompleter, .help = N_("virtualization type (/domain/@type)"), }, {.name = "emulator", @@ -1686,6 +1688,7 @@ static const vshCmdOptDef opts_hypervisor_cpu_baseline[] = { VIRSH_COMMON_OPT_FILE(N_("file containing XML CPU descriptions")), {.name = "virttype", .type = VSH_OT_STRING, + .completer = virshVirtTypeCompleter, .help = N_("virtualization type (/domain/@type)"), }, {.name = "emulator", -- 2.35.1

3 5

[PATCH] checkpoint: Fix a typo of comments
by Han Han 01 Apr '22

01 Apr '22

Signed-off-by: Han Han <hhan(a)redhat.com> --- src/libvirt-domain-checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain-checkpoint.c b/src/libvirt-domain-checkpoint.c index e6ad4f4f5d..58ee26857d 100644 --- a/src/libvirt-domain-checkpoint.c +++ b/src/libvirt-domain-checkpoint.c @@ -248,7 +248,7 @@ virDomainCheckpointGetXMLDesc(virDomainCheckpointPtr checkpoint, * @checkpoints: pointer to variable to store the array containing checkpoint * object, or NULL if the list is not required (just returns * number of checkpoints) - * @flags: bitwise-OR of supported virDomainCheckpoinListFlags + * @flags: bitwise-OR of supported virDomainCheckpointListFlags * * Collect the list of domain checkpoints for the given domain and allocate * an array to store those objects. -- 2.35.1

2 1