[PATCH 0/4] docs cleanups
by Peter Krempa
Cleanups based on review of series converting a bunch of docs to rST
format.
Peter Krempa (4):
docs: securityprocess: Don't claim that we have maint branches
docs: formatsnapshot: Move paragraphs describing 'disk' element
together
docs: formatsnapshot: Remove explicit listing of supported snapshot
formats
docs: formatsnapshot: Remove empty 'seclabel' definition
docs/formatsnapshot.rst | 24 +++++++++++-------------
docs/securityprocess.rst | 6 ++----
2 files changed, 13 insertions(+), 17 deletions(-)
--
2.35.1
2 years, 9 months
[libvirt PATCH 0/2] nwfilter cleanups for legacy platforms
by Daniel P. Berrangé
We have a couple of compatibility hacks to cope with changes
in iptables userspace and kernel. These were very long ago
so not relevant to our current build platforms. Removing
them makes the code clearer.
The tests have churn because we were never properly testing
this aspect in the past
Daniel P. Berrangé (2):
nwfilter: drop support for legacy iptables match syntax
nwfilter: drop support for legacy iptables conntrack direction
src/nwfilter/nwfilter_ebiptables_driver.c | 128 +-
.../ah-ipv6-linux.args | 54 +-
tests/nwfilterxml2firewalldata/ah-linux.args | 54 +-
.../all-ipv6-linux.args | 54 +-
tests/nwfilterxml2firewalldata/all-linux.args | 54 +-
.../comment-linux.args | 90 +-
.../conntrack-linux.args | 18 +-
.../esp-ipv6-linux.args | 54 +-
tests/nwfilterxml2firewalldata/esp-linux.args | 54 +-
.../example-1-linux.args | 54 +-
.../example-2-linux.args | 28 +-
.../hex-data-linux.args | 36 +-
.../icmp-direction-linux.args | 12 +-
.../icmp-direction2-linux.args | 12 +-
.../icmp-direction3-linux.args | 18 +-
.../nwfilterxml2firewalldata/icmp-linux.args | 12 +-
.../icmpv6-linux.args | 16 +-
.../nwfilterxml2firewalldata/igmp-linux.args | 54 +-
.../nwfilterxml2firewalldata/ipset-linux.args | 72 +-
.../nwfilterxml2firewalldata/iter1-linux.args | 54 +-
.../nwfilterxml2firewalldata/iter2-linux.args | 1026 +++++++++++------
.../nwfilterxml2firewalldata/iter3-linux.args | 90 +-
.../sctp-ipv6-linux.args | 54 +-
.../nwfilterxml2firewalldata/sctp-linux.args | 54 +-
.../target-linux.args | 36 +-
.../target2-linux.args | 18 +-
.../tcp-ipv6-linux.args | 54 +-
tests/nwfilterxml2firewalldata/tcp-linux.args | 18 +-
.../udp-ipv6-linux.args | 54 +-
tests/nwfilterxml2firewalldata/udp-linux.args | 54 +-
.../udplite-ipv6-linux.args | 54 +-
.../udplite-linux.args | 54 +-
32 files changed, 1570 insertions(+), 924 deletions(-)
--
2.35.1
2 years, 9 months
[libvirt PATCH v2 0/6] Add support for 'blob' to virtio video device
by Jonathon Jongsma
Add support to libvirt for the 'blob' option for virtio video devices in qemu.
Also do a little preparatory refactoring of the video device xml parsing code.
Changes in v2:
- Added some basic documentation
- add a qemu capability
- Make sure that the /dev/udmabuf device is accessible to qemu (cgroups, etc)
Jonathon Jongsma (6):
conf: Refactor video model parsing
conf: switch to virXMLProp* functions
conf: use enum variable for video type
conf: add support for 'blob' in virtio video device
qemu: Add capability for virtio-gpu.blob
qemu: Implement 'blob' support for virtio gpu
docs/formatdomain.rst | 6 +
docs/schemas/domaincommon.rng | 5 +
src/conf/domain_conf.c | 133 +++++++++---------
src/conf/domain_conf.h | 3 +-
src/conf/domain_validate.c | 13 +-
src/libxl/libxl_conf.c | 10 ++
src/libxl/libxl_domain.c | 11 ++
src/qemu/qemu_capabilities.c | 4 +
src/qemu/qemu_capabilities.h | 3 +
src/qemu/qemu_cgroup.c | 28 ++--
src/qemu/qemu_command.c | 3 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_monitor_json.c | 16 ++-
src/qemu/qemu_namespace.c | 22 +++
src/qemu/qemu_process.c | 7 +
src/qemu/qemu_validate.c | 9 ++
.../caps_6.1.0.x86_64.xml | 1 +
.../caps_6.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 +
.../caps_6.2.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 +
.../caps_7.0.0.x86_64.xml | 1 +
.../video-virtio-blob-absent.args | 34 +++++
.../video-virtio-blob-absent.xml | 33 +++++
.../video-virtio-blob-off.args | 34 +++++
.../video-virtio-blob-off.xml | 33 +++++
.../video-virtio-blob-on.args | 34 +++++
.../qemuxml2argvdata/video-virtio-blob-on.xml | 33 +++++
.../video-virtio-vga-blob-on.args | 34 +++++
.../video-virtio-vga-blob-on.xml | 33 +++++
tests/qemuxml2argvtest.c | 12 ++
.../video-virtio-blob-absent.xml | 41 ++++++
.../video-virtio-blob-off.xml | 41 ++++++
.../video-virtio-blob-on.xml | 41 ++++++
.../video-virtio-vga-blob-on.xml | 41 ++++++
tests/qemuxml2xmltest.c | 12 ++
36 files changed, 652 insertions(+), 84 deletions(-)
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-absent.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-vga-blob-on.xml
--
2.35.1
2 years, 9 months
[PATCH 00/17] docs: Convert some pages to rST and clean up (part 1)
by Peter Krempa
Peter Krempa (17):
docs: Remove 'virshcmdref' page
docs: Drop 'devguide' page
docs: formatsnapshot: Convert to 'rst'
docs: Convert 'goals' to rST
docs: Convert 'strategy' to rST
docs: Convert 'contribute' page to rST
docs: Convert 'bugs' page to rST
docs: Convert 'errors' page to rST
docs: Convert 'support' page to rST
docs: Convert 'securityprocess' page to rST
docs: securityprocess: Don't claim that we have maint branches
docs: Convert 'governance' page to rST
docs: page.xsl: Update anchor to the 'Code of conduct' paragraph
docs: Convert 'drivers' page to rST
docs: Convert 'formatsecret' page to rST
docs: formatsecret: Drop few unneeded empty lines
docs: meson: Restore alphabetical order
docs/bugs.html.in | 161 -----------
docs/bugs.rst | 125 ++++++++
docs/contribute.html.in | 143 ---------
docs/contribute.rst | 105 +++++++
docs/devguide.html.in | 42 ---
docs/drivers.html.in | 44 ---
docs/drivers.rst | 31 ++
docs/errors.html.in | 84 ------
docs/errors.rst | 109 +++++++
docs/formatsecret.html.in | 414 ---------------------------
docs/formatsecret.rst | 332 +++++++++++++++++++++
docs/formatsnapshot.html.in | 352 -----------------------
docs/formatsnapshot.rst | 297 +++++++++++++++++++
docs/formatstorageencryption.html.in | 2 +-
docs/goals.html.in | 64 -----
docs/goals.rst | 56 ++++
docs/governance.html.in | 298 -------------------
docs/governance.rst | 232 +++++++++++++++
docs/meson.build | 32 +--
docs/page.xsl | 2 +-
docs/securityprocess.html.in | 119 --------
docs/securityprocess.rst | 91 ++++++
docs/strategy.html.in | 133 ---------
docs/strategy.rst | 105 +++++++
docs/support.html.in | 258 -----------------
docs/support.rst | 207 ++++++++++++++
docs/virshcmdref.html.in | 75 -----
27 files changed, 1707 insertions(+), 2206 deletions(-)
delete mode 100644 docs/bugs.html.in
create mode 100644 docs/bugs.rst
delete mode 100644 docs/contribute.html.in
create mode 100644 docs/contribute.rst
delete mode 100644 docs/devguide.html.in
delete mode 100644 docs/drivers.html.in
create mode 100644 docs/drivers.rst
delete mode 100644 docs/errors.html.in
create mode 100644 docs/errors.rst
delete mode 100644 docs/formatsecret.html.in
create mode 100644 docs/formatsecret.rst
delete mode 100644 docs/formatsnapshot.html.in
create mode 100644 docs/formatsnapshot.rst
delete mode 100644 docs/goals.html.in
create mode 100644 docs/goals.rst
delete mode 100644 docs/governance.html.in
create mode 100644 docs/governance.rst
delete mode 100644 docs/securityprocess.html.in
create mode 100644 docs/securityprocess.rst
delete mode 100644 docs/strategy.html.in
create mode 100644 docs/strategy.rst
delete mode 100644 docs/support.html.in
create mode 100644 docs/support.rst
delete mode 100644 docs/virshcmdref.html.in
--
2.35.1
2 years, 9 months
[PATCH 0/2] libvirt-qemu: Two simple fixes
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (2):
libvirt-qemu: Don't allow NULL cmd in
virDomainQemuMonitorCommandWithFiles()
libvirt-qemu: Fix capitalization of QEMU
src/libvirt-qemu.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
--
2.34.1
2 years, 9 months
[libvirt PATCH] spec: Move virkey* manual pages from -daemon to -client
by Andrea Bolognani
The documentation included in these manual pages is mostly useful
to users of the 'send-key' virsh command, and the virsh manual
page refers to them, so it makes more sense to install them along
with virsh instead of libvirtd.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0e6cd13bb2..6855b3a760 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1733,7 +1733,6 @@ exit 0
%{_mandir}/man8/virtlogd.8*
%{_mandir}/man8/virtlockd.8*
%{_mandir}/man8/virtproxyd.8*
-%{_mandir}/man7/virkey*.7*
%{_bindir}/virt-host-validate
%{_bindir}/virt-admin
@@ -2010,6 +2009,7 @@ exit 0
%{_mandir}/man1/virt-xml-validate.1*
%{_mandir}/man1/virt-pki-query-dn.1*
%{_mandir}/man1/virt-pki-validate.1*
+%{_mandir}/man7/virkey*.7*
%{_bindir}/virsh
%{_bindir}/virt-xml-validate
%{_bindir}/virt-pki-query-dn
--
2.34.1
2 years, 9 months
[PATCH] qemu: domainjob: Allow free if cb is not set in qemuDomainObjClearJob
by Kristina Hanicova
We should allow resetting and freeing qemuDomainJobObj even if
'cb' attribute is not set. This is theoretical for now, but the
attribute must not be always set in the future, so early return
would create memory leaks. It is sufficient to check if 'cb'
exists before dereferencing it in qemuDomainObjClearJob() and
also qemuDomainObjResetAsyncJob() as the latter is called from
the former.
This commit partially reverts af16e754cd4efc3ca1.
Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com>
---
src/qemu/qemu_domainjob.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index 3e73eba4ed..587c166d94 100644
--- a/src/qemu/qemu_domainjob.c
+++ b/src/qemu/qemu_domainjob.c
@@ -239,8 +239,10 @@ qemuDomainObjResetAsyncJob(qemuDomainJobObj *job)
job->abortJob = false;
VIR_FREE(job->error);
g_clear_pointer(&job->current, virDomainJobDataFree);
- job->cb->resetJobPrivate(job->privateData);
job->apiFlags = 0;
+
+ if (job->cb)
+ job->cb->resetJobPrivate(job->privateData);
}
int
@@ -270,16 +272,15 @@ qemuDomainObjRestoreJob(virDomainObj *obj,
void
qemuDomainObjClearJob(qemuDomainJobObj *job)
{
- if (!job->cb)
- return;
-
qemuDomainObjResetJob(job);
qemuDomainObjResetAsyncJob(job);
- g_clear_pointer(&job->privateData, job->cb->freeJobPrivate);
g_clear_pointer(&job->current, virDomainJobDataFree);
g_clear_pointer(&job->completed, virDomainJobDataFree);
virCondDestroy(&job->cond);
virCondDestroy(&job->asyncCond);
+
+ if (job->cb)
+ g_clear_pointer(&job->privateData, job->cb->freeJobPrivate);
}
bool
--
2.35.1
2 years, 9 months
[PULL v4 21/47] hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated
by Michael S. Tsirkin
From: Thomas Huth <thuth(a)redhat.com>
The list of machine types grows larger and larger each release ... and
it is unlikely that many people still use the very old ones for live
migration. QEMU v1.7 has been released more than 8 years ago, so most
people should have updated their machines to a newer version in those
8 years at least once. Thus let's mark the very old 1.x machine types
as deprecated now.
Signed-off-by: Thomas Huth <thuth(a)redhat.com>
Message-Id: <20220117191639.278497-1-thuth(a)redhat.com>
Reviewed-by: Michael S. Tsirkin <mst(a)redhat.com>
Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com>
---
hw/i386/pc_piix.c | 1 +
docs/about/deprecated.rst | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 8d33cf689d..b72c03d0a6 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -757,6 +757,7 @@ static void pc_i440fx_1_7_machine_options(MachineClass *m)
m->hw_version = "1.7.0";
m->default_machine_opts = NULL;
m->option_rom_has_mr = true;
+ m->deprecation_reason = "old and unattended - use a newer version instead";
compat_props_add(m->compat_props, pc_compat_1_7, pc_compat_1_7_len);
pcmc->smbios_defaults = false;
pcmc->gigabyte_align = false;
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 85773db631..cf02ef6821 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -324,6 +324,14 @@ machine is hardly emulated at all (e.g. neither the LCD nor the USB part had
been implemented), so there is not much value added by this board. Use the
``ref405ep`` machine instead.
+``pc-i440fx-1.4`` up to ``pc-i440fx-1.7`` (since 7.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+These old machine types are quite neglected nowadays and thus might have
+various pitfalls with regards to live migration. Use a newer machine type
+instead.
+
+
Backend options
---------------
--
MST
2 years, 9 months
[libvirt PATCH] Drop YouCompleteMe and color_coded integration
by Andrea Bolognani
I introduced support for these vim plugins several years ago
but have since moved away from them. These days developers
are likely better served by lsp-based tooling, which doesn't
require additional per-project configuration.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.color_coded.in | 38 ---------------------------------
.ycm_extra_conf.py.in | 43 --------------------------------------
build-aux/syntax-check.mk | 1 -
docs/developer-tooling.rst | 13 ------------
docs/hacking.rst | 1 -
docs/meson.build | 1 -
meson.build | 19 -----------------
7 files changed, 116 deletions(-)
delete mode 100644 .color_coded.in
delete mode 100644 .ycm_extra_conf.py.in
delete mode 100644 docs/developer-tooling.rst
diff --git a/.color_coded.in b/.color_coded.in
deleted file mode 100644
index f39c6860ab..0000000000
--- a/.color_coded.in
+++ /dev/null
@@ -1,38 +0,0 @@
--I@abs_top_builddir@
--I@abs_top_srcdir@
--I@abs_top_builddir@/include
--I@abs_top_srcdir@/include
--I@abs_top_builddir@/src
--I@abs_top_srcdir@/src
--I@abs_top_builddir@/src/access
--I@abs_top_srcdir@/src/access
--I@abs_top_builddir@/src/admin
--I@abs_top_srcdir@/src/admin
--I@abs_top_builddir@/src/bhyve
--I@abs_top_srcdir@/src/bhyve
--I@abs_top_builddir@/src/conf
--I@abs_top_srcdir@/src/conf
--I@abs_top_builddir@/src/libxl
--I@abs_top_srcdir@/src/libxl
--I@abs_top_builddir@/src/locking
--I@abs_top_srcdir@/src/locking
--I@abs_top_builddir@/src/logging
--I@abs_top_srcdir@/src/logging
--I@abs_top_builddir@/src/lxc
--I@abs_top_srcdir@/src/lxc
--I@abs_top_builddir@/src/qemu
--I@abs_top_srcdir@/src/qemu
--I@abs_top_builddir@/src/remote
--I@abs_top_srcdir@/src/remote
--I@abs_top_builddir@/src/rpc
--I@abs_top_srcdir@/src/rpc
--I@abs_top_builddir@/src/secret
--I@abs_top_srcdir@/src/secret
--I@abs_top_builddir@/src/security
--I@abs_top_srcdir@/src/security
--I@abs_top_builddir@/src/util
--I@abs_top_srcdir@/src/util
--I@abs_top_builddir@/src/vmx
--I@abs_top_srcdir@/src/vmx
--I@abs_top_builddir@/src/xenconfig
--I@abs_top_srcdir@/src/xenconfig
diff --git a/.ycm_extra_conf.py.in b/.ycm_extra_conf.py.in
deleted file mode 100644
index 2e24334079..0000000000
--- a/.ycm_extra_conf.py.in
+++ /dev/null
@@ -1,43 +0,0 @@
-flags = [
- '-I@abs_top_builddir@',
- '-I@abs_top_srcdir@',
- '-I@abs_top_builddir@/include',
- '-I@abs_top_srcdir@/include',
- '-I@abs_top_builddir@/src',
- '-I@abs_top_srcdir@/src',
- '-I@abs_top_builddir@/src/access',
- '-I@abs_top_srcdir@/src/access',
- '-I@abs_top_builddir@/src/admin',
- '-I@abs_top_srcdir@/src/admin',
- '-I@abs_top_builddir@/src/bhyve',
- '-I@abs_top_srcdir@/src/bhyve',
- '-I@abs_top_builddir@/src/conf',
- '-I@abs_top_srcdir@/src/conf',
- '-I@abs_top_builddir@/src/libxl',
- '-I@abs_top_srcdir@/src/libxl',
- '-I@abs_top_builddir@/src/locking',
- '-I@abs_top_srcdir@/src/locking',
- '-I@abs_top_builddir@/src/logging',
- '-I@abs_top_srcdir@/src/logging',
- '-I@abs_top_builddir@/src/lxc',
- '-I@abs_top_srcdir@/src/lxc',
- '-I@abs_top_builddir@/src/qemu',
- '-I@abs_top_srcdir@/src/qemu',
- '-I@abs_top_builddir@/src/remote',
- '-I@abs_top_srcdir@/src/remote',
- '-I@abs_top_builddir@/src/rpc',
- '-I@abs_top_srcdir@/src/rpc',
- '-I@abs_top_builddir@/src/secret',
- '-I@abs_top_srcdir@/src/secret',
- '-I@abs_top_builddir@/src/security',
- '-I@abs_top_srcdir@/src/security',
- '-I@abs_top_builddir@/src/util',
- '-I@abs_top_srcdir@/src/util',
- '-I@abs_top_builddir@/src/vmx',
- '-I@abs_top_srcdir@/src/vmx',
- '-I@abs_top_builddir@/src/xenconfig',
- '-I@abs_top_srcdir@/src/xenconfig',
-]
-
-def FlagsForFile(filename, **kwargs):
- return { 'flags': flags, 'do_cache': True }
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index a8c9153b20..fac1338589 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -921,7 +921,6 @@ http_sites += www.javvin.com
# 404 links
http_sites += publib.boulder.ibm.com
http_sites += kerneltrap.org
-http_sites += valloric.github.io
http_sites += www.microsoft.com
http_sites += xenbits.xen.org
http_sites += lovezutto.googlepages.com
diff --git a/docs/developer-tooling.rst b/docs/developer-tooling.rst
deleted file mode 100644
index c8980e3e4f..0000000000
--- a/docs/developer-tooling.rst
+++ /dev/null
@@ -1,13 +0,0 @@
-=================
-Developer tooling
-=================
-
-libvirt includes support for some useful development tools right
-in its source repository, meaning users will be able to take
-advantage of them without little or no configuration. Examples
-include:
-
-- `color_coded <https://github.com/jeaye/color_coded>`__, a vim
- plugin for libclang-powered semantic syntax highlighting;
-- `YouCompleteMe <http://valloric.github.io/YouCompleteMe/>`__, a
- vim plugin for libclang-powered semantic code completion.
diff --git a/docs/hacking.rst b/docs/hacking.rst
index cd009c4c73..1be9daab80 100644
--- a/docs/hacking.rst
+++ b/docs/hacking.rst
@@ -72,7 +72,6 @@ This page only covers the very basics, so it's recommended that
you also take a look at the following documents:
- `Programming languages <programming-languages.html>`__
-- `Developer tooling <developer-tooling.html>`__
- `Advanced test suite usage <advanced-tests.html>`__
- `Adoption of GLib APIs <glib-adoption.html>`__
- `Committer guidelines <committer-guidelines.html>`__
diff --git a/docs/meson.build b/docs/meson.build
index 7e070d68ad..690715a12e 100644
--- a/docs/meson.build
+++ b/docs/meson.build
@@ -95,7 +95,6 @@ docs_rst_files = [
'committer-guidelines',
'compiling',
'daemons',
- 'developer-tooling',
'drvqemu',
'drvch',
'formatbackup',
diff --git a/meson.build b/meson.build
index 519a928c9a..987d8a393f 100644
--- a/meson.build
+++ b/meson.build
@@ -2215,25 +2215,6 @@ configure_file(
run_command('chmod', 'a+x', meson.current_build_dir() / 'run', check: true)
-# generate developer tooling files
-tooling_files = [
- '.color_coded.in',
- '.ycm_extra_conf.py.in',
-]
-
-tooling_conf = configuration_data()
-tooling_conf.set('abs_top_builddir', meson.build_root())
-tooling_conf.set('abs_top_srcdir', meson.source_root())
-
-foreach file : tooling_files
- configure_file(
- input: file,
- output: '@BASENAME@',
- configuration: tooling_conf,
- )
-endforeach
-
-
# print configuration summary
driver_summary = {
--
2.35.1
2 years, 9 months
