March 2022 - Devel - libvirt List Archives

[PATCH 0/4] Introduce memory allocation threads
by Michal Privoznik 24 Mar '22

24 Mar '22

*** BLURB HERE *** Michal Prívozník (4): conf: Introduce memory allocation threads qemu_capabilities: Detect memory-backend-*.prealloc-threads property qemu_validate: Validate prealloc threads against qemuCpas qemu_command: Generate prealloc-threads property docs/formatdomain.rst | 6 ++++-- docs/schemas/domaincommon.rng | 19 +++++++++++++------ src/conf/domain_conf.c | 15 ++++++++++++++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 ++++- src/qemu/qemu_validate.c | 7 +++++++ .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../memfd-memory-numa.x86_64-latest.args | 4 ++-- tests/qemuxml2argvdata/memfd-memory-numa.xml | 2 +- 30 files changed, 69 insertions(+), 13 deletions(-) -- 2.34.1

4 15

[PATCH v2 0/3] qemu: don't pause VM when creating internal snapshot
by Nikolay Shirokovskiy 24 Mar '22

24 Mar '22

Diff to v1 [1]: - fix mistake of dropping hunk that starts CPUs if snapshot was not successful. We still need it if halt upon snapshot is requested. The is series is mostly about the first patch. The others patch are minor cleanups. [1] v1 version https://listman.redhat.com/archives/libvir-list/2022-March/229437.html Maxim Nestratov (1): qemu: don't pause vm when creating internal snapshot Nikolay Shirokovskiy (2): qemu: remove excessive check in qemuSnapshotCreateActiveInternal qemu: remove unnecessary gotos in qemuSnapshotCreateActiveInternal src/qemu/qemu_snapshot.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) -- 2.35.1

1 3

[PATCH 0/3] qemu: don't pause vm when creating internal snapshot
by Nikolay Shirokovskiy 24 Mar '22

24 Mar '22

The is series is mostly about the first patch. The others patch are minor cleanups. Maxim Nestratov (1): qemu: don't pause vm when creating internal snapshot Nikolay Shirokovskiy (2): qemu: remove excessive check in qemuSnapshotCreateActiveInternal qemu: remove unnecessary goto in qemuSnapshotCreateActiveInternal src/qemu/qemu_snapshot.c | 65 +++++++++++----------------------------- 1 file changed, 18 insertions(+), 47 deletions(-) -- 2.35.1

1 4

[RFC 0/1] virxml: Accept 'default' for virTristate* properties
by Andrea Bolognani 24 Mar '22

24 Mar '22

Sending this as an RFC because it's incomplete. After virXMLPropTristate*() had been introduced, existing code was gradually converted to use the new helpers; however, if you look for example at 593140dabd66 you'll see that the original implementation considered encountering 'default' to be an error, and the change I'm proposing would relax such a check. So we need to go through the callers one by one, adapting them as necessary (in this case, we would pass VIR_XML_PROP_NONZERO in addition to existing flags) to ensure that the original semantic is preserved. Any better ideas? Andrea Bolognani (1): virxml: Accept 'default' for virTristate* properties src/util/virxml.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.35.1

4 10

[libvirt PATCH 0/3] Enable copy/paste for vnc displays
by Jonathon Jongsma 24 Mar '22

24 Mar '22

This patch series enables support for the qemu-vdagent character device which enables copy/paste support between guest and client when using vnc graphics. The guest must be configured with something like the following: <channel type='qemu-vdagent'> <source clipboard='on' mouse='on'/> <target type='virtio' name='com.redhat.spice.0'/> </channel> Copy/paste sync requires a vnc client that has support for copy/paste commands. Currently virt-viewer does not work, but the version of tigervnc provided by fedora (executable name 'vncviewer') does work. More details about this device on Gerd's blog: https://www.kraxel.org/blog/2021/05/qemu-cut-paste/ OPEN QUESTIONS: - I'm not fully convinced that the `<source>` element is the right place for the new `clipboard` / `mouse` configuration options, but I'm not sure that adding a new xml element to the `<channel>` is the right approach either. Suggestions welcome. - There may be an expectation that vnc clipboard is enabled using the <graphics type='vnc'><clipboard copypaste='yes'/></graphics> similar to what spice offers. In fact, it seems that this is the approach Marc-Andre took when adding copy/paste support in his dbus display patch series. But even for spice, this <clipboard> configuration element is not enough to enable the copy/paste feature. It also requires a 'spicevmc' character device to be added to the domain. Jonathon Jongsma (3): qemu: add capability for qemu-vdagent chardev conf: add qemu-vdagent channel qemu: add support for qemu-vdagent channel docs/formatdomain.rst | 17 ++++++ src/conf/domain_conf.c | 49 ++++++++++++++++- src/conf/domain_conf.h | 7 +++ src/conf/domain_validate.c | 1 + src/conf/schemas/domaincommon.rng | 11 ++++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++ src/qemu/qemu_monitor_json.c | 10 ++++ src/qemu/qemu_process.c | 1 + src/qemu/qemu_validate.c | 1 + src/security/security_dac.c | 2 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../channel-qemu-vdagent.x86_64-latest.args | 41 ++++++++++++++ .../qemuxml2argvdata/channel-qemu-vdagent.xml | 34 ++++++++++++ tests/qemuxml2argvtest.c | 1 + .../channel-qemu-vdagent.x86_64-latest.xml | 55 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/testutilsqemu.c | 1 + 22 files changed, 250 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent.xml create mode 100644 tests/qemuxml2xmloutdata/channel-qemu-vdagent.x86_64-latest.xml -- 2.35.1

3 10

[libvirt PATCH] ci: integration: Rename all Avocado standard stream log files to *.log
by Erik Skultety 23 Mar '22

23 Mar '22

By default, stdout/stderr Avocado test log files do not have any file extension which confuses GitLab's web UI to mangle the MIME type for these and so the browser will never offer the option to open such file from in a text editor rather than dowloading it. Since GitLab sets a proper MIME for .txt and .log file extensions, rename all Avocado log files without an extension to *.log . This pairs nicely with the coredumpctl info file which we already name as 'coredumpctl.txt' because of this. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Here are 2 artifact web UI views on a failed job which you can try yourself in your browser: Before this patch: https://gitlab.com/eskultety/libvirt/-/jobs/2232852413/artifacts/browse/log… After this patch: https://gitlab.com/eskultety/libvirt/-/jobs/2234111527/artifacts/browse/log… ci/integration.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/integration.yml b/ci/integration.yml index 519494cfd5..2808e829ef 100644 --- a/ci/integration.yml +++ b/ci/integration.yml @@ -36,6 +36,9 @@ - sudo coredumpctl info --no-pager > logs/coredumpctl.txt - sudo mv /var/log/libvirt logs/libvirt - sudo chown -R $(whoami):$(whoami) logs + # rename all Avocado stderr/stdout logs to *.log so that GitLab's web UI doesn't mangle the MIME type + - find logs/avocado/ -type f ! -name "*.log" -exec + sh -c 'DIR=$(dirname {}); NAME=$(basename {}); mv $DIR/$NAME{,.log}' \; variables: SCRATCH_DIR: "/tmp/scratch" artifacts: -- 2.34.1

3 5

[libvirt PATCH] keycodemapdb: Update git submodule
by Andrea Bolognani 23 Mar '22

23 Mar '22

This brings in all the fixes made since April 2020. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/keycodemapdb b/src/keycodemapdb index 27acf0ef82..57ba70da53 160000 --- a/src/keycodemapdb +++ b/src/keycodemapdb @@ -1 +1 @@ -Subproject commit 27acf0ef828bf719b2053ba398b195829413dbdd +Subproject commit 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae -- 2.35.1

2 1

[libvirt PATCH 0/2] [CI] Fix running integration pipeline in forks + collect daemon stack trace
by Erik Skultety 22 Mar '22

22 Mar '22

Even if users set the LIBVIRT_CI_INTEGRATION variable to 1 to enable the integration test suite with their own private runner, the pipeline will be stuck because we expect the runner to have the 'redhat-vm-host' tag. We need to define the job tag dynamically instead, so that the users can set the variable for their libvirt fork to match one of their runner's tags. A recent crash in libvirt showed us that we also need to collect stack traces as well, so this series also takes care of setting up systemd to be able to collect them on failed jobs. Both fixes are demoed with pipeline [1]. Note that for the pipeline I reverted 17fe6a090ba389cdd228c3e176788d9b2d45525f just to demonstrate the stack trace collection on a crash. [1] https://gitlab.com/eskultety/libvirt/-/pipelines/497404762 Erik Skultety (2): ci: Define the integration job tag dynamically via a variable ci: integration: Collect stack traces with coredumpctl ci/integration.yml | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) -- 2.34.1

3 5

[PATCH] gitpublish: Drop "libvirt" from prefix
by Andrea Bolognani 22 Mar '22

22 Mar '22

We're now using GitLab MRs for all subprojects, which makes having "libvirt" in the prefix no longer necessary and a pointless deviation from git-format-patch's default, which some people still use. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitpublish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitpublish b/.gitpublish index d37bf4174a..2c9a6e909e 100644 --- a/.gitpublish +++ b/.gitpublish @@ -1,4 +1,4 @@ [gitpublishprofile "default"] base = master to = libvir-list(a)redhat.com -prefix = libvirt PATCH +prefix = PATCH -- 2.35.1

3 3

[PATCH] docs: Update obsolete reference to formatdomain.html.in
by Andrea Bolognani 22 Mar '22

22 Mar '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/api_extension.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/api_extension.rst b/docs/api_extension.rst index d70c244fd4..152e64487e 100644 --- a/docs/api_extension.rst +++ b/docs/api_extension.rst @@ -73,7 +73,7 @@ The first task is to define the public API. If the new API involves an XML extension, you have to enhance the RelaxNG schema and document the new elements or attributes: -``src/conf/schemas/domaincommon.rng docs/formatdomain.html.in`` +``src/conf/schemas/domaincommon.rng docs/formatdomain.rst`` If the API extension involves a new function, you have to add a declaration in the public header, and arrange to export the function -- 2.35.1

1 0