August 2021 - Devel - libvirt List Archives

[PATCH 0/2] docs/about: some documentation clean-up
by Yanan Wang 23 Aug '21

23 Aug '21

These two patches (one of which has been reviewed) originally come from [1]. Here resend them separately as a short doc clean-up series. [1] https://lore.kernel.org/qemu-devel/20210819031027.41104-1-wangyanan55@huawe… Yanan Wang (2): docs/about: Remove the duplicated doc docs/about: Unify the subject format docs/about/deprecated.rst | 56 ++++++++++++++++----------------- docs/about/removed-features.rst | 41 +++++++++--------------- 2 files changed, 42 insertions(+), 55 deletions(-) -- 2.19.1

3 4

[libvirt PATCH 0/9] tests: cputest: use g_auto more (glib chronicles)
by Ján Tomko 20 Aug '21

20 Aug '21

Also improve the compilation times (unoptimized optimization routines take too long when there are too many branches in a function, which is the case of cputest's main) and switch qemuxml2* to use the same approach. Ján Tomko (9): qemu: monitor: define cleanup function for qemuMonitorCPUModelInfo tests: use g_auto in cpuTestMakeQEMUCaps tests: cputest: use g_auto for virQEMUCaps tests: cputest: use g_auto for virCPUData tests: cputest: use g_auto for virCPUDef tests: cputest: use g_autofree tests: cputest: remove unnecessary labels tests: cputests: introduce and use virTestRunLog tests: qemuxml2*test: switch to virRunTestLog src/qemu/qemu_monitor.h | 1 + tests/cputest.c | 239 +++++++++++----------------------- tests/qemustatusxml2xmltest.c | 3 +- tests/qemuxml2argvtest.c | 10 +- tests/qemuxml2xmltest.c | 9 +- tests/testutils.c | 30 +++++ tests/testutils.h | 4 + tests/testutilsqemu.h | 1 - 8 files changed, 114 insertions(+), 183 deletions(-) -- 2.31.1

2 10

[libvirt PATCH 0/5] virnetdevopenvswitch: fix overindented label (glib chronicles)
by Ján Tomko 20 Aug '21

20 Aug '21

By removing it, of course. Patch 1/5 also has the potential to fix the build on FreeBSD, but it failed with an internal server error for me. Ján Tomko (5): build: only build virnetdevopenvswitchtest on Linux tests: virnetdevopenvswitch: use g_auto tests: virnetdevbandwidthtest: use g_auto tests: introduce testVirNetDevBandwidthParse tests: virnetdev*: remove unnecessary labels tests/meson.build | 6 ++- tests/virnetdevbandwidthtest.c | 56 ++++++++++++------------- tests/virnetdevopenvswitchtest.c | 70 ++++++++++++++------------------ 3 files changed, 61 insertions(+), 71 deletions(-) -- 2.31.1

2 6

[PATCH 0/6] nwfilter define: add support for validation against schema
by Kristina Hanicova 20 Aug '21

20 Aug '21

Kristina Hanicova (6): api: add public virNWFilterDefineXMLFlags() and remote protocol nwfilter: add nwfilterDefineXMLFlags() api: add virNWFilterDefineFlags nwfilter_conf: add validation against schema in define nwfilter_driver: allow VIR_NWFILTER_DEFINE_VALIDATE flag virsh: add support for '--validate' option in define nwfilter docs/manpages/virsh.rst | 5 +++- include/libvirt/libvirt-nwfilter.h | 7 +++++ src/conf/nwfilter_conf.c | 13 +++++---- src/conf/nwfilter_conf.h | 3 ++- src/driver-nwfilter.h | 6 +++++ src/libvirt-nwfilter.c | 43 ++++++++++++++++++++++++++++++ src/libvirt_public.syms | 5 ++++ src/nwfilter/nwfilter_driver.c | 21 ++++++++++++--- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 18 ++++++++++++- src/remote_protocol-structs | 8 ++++++ tools/virsh-nwfilter.c | 13 ++++++++- 12 files changed, 130 insertions(+), 13 deletions(-) -- 2.31.1

2 10

[PATCH 0/4] interface define: add support for validation against schema
by Kristina Hanicova 20 Aug '21

20 Aug '21

Kristina Hanicova (4): api: add virInterfaceDefineFlags conf: add validation and propagate flags into virInterfaceDefParse() src: allow validation flag in interface define virsh: add support for '--validate' option in define interface docs/manpages/virsh.rst | 5 +++-- include/libvirt/libvirt-interface.h | 4 ++++ src/conf/interface_conf.c | 14 ++++++++------ src/conf/interface_conf.h | 3 ++- src/conf/virinterfaceobj.c | 2 +- src/interface/interface_backend_netcf.c | 6 +++--- src/libvirt-interface.c | 2 +- src/test/test_driver.c | 4 ++-- tests/interfacexml2xmltest.c | 2 +- tools/virsh-interface.c | 10 +++++++++- 10 files changed, 34 insertions(+), 18 deletions(-) -- 2.31.1

2 6

[PATCH 0/4] secret define: add support for validation against schema
by Kristina Hanicova 20 Aug '21

20 Aug '21

Kristina Hanicova (4): api: add virSecretDefineFlags secret_conf: add validation against schema in define secret_driver: allow VIR_SECRET_DEFINE_VALIDATE flag virsh: add support for '--validate' option in define secret docs/manpages/virsh.rst | 4 +++- include/libvirt/libvirt-secret.h | 5 +++++ src/conf/secret_conf.c | 13 ++++++++----- src/conf/secret_conf.h | 2 +- src/libvirt-secret.c | 2 +- src/secret/secret_driver.c | 4 ++-- tools/virsh-secret.c | 10 +++++++++- 7 files changed, 29 insertions(+), 11 deletions(-) -- 2.31.1

2 5

[PATCH v2 00/12] Implement detach device related APIs for test driver
by Luke Yue 20 Aug '21

20 Aug '21

v2: - Extract DetachXXXDeviceConfig functions from drivers and use them - Add a trial implementation of detach memballoon and TPM, if they are fine, more device support will be added to test driver in the future - Add expectError to testCompareOutputLit for some "fail on purpose" tests - Refine tests Luke Yue (12): conf: Introduce virDomainInputDefRemove and fix memory leak domain_driver: extract DetachXXXDeviceConfig related functions and use them test_driver: Implement virDomainDetachDeviceFlags test_driver: Implement virDomainDetachDeviceAlias test_driver: Implement virDomainDetachDevice conf: Add tpm helpers for future use test_driver: add TPM support for testDomainDetachDeviceLiveAndConfig conf: Add a memballoon helper for future use test_driver: add memballoon support for testDomainDetachDeviceLiveAndConfig examples: xml: test: add xml for testing devices related APIs virshtest: add expectError parameter to testCompareOutputLit tests: Test detach-device and detach-device-alias for test driver examples/xml/test/testdevcontroller.xml | 1 + examples/xml/test/testdevdiskcdrom.xml | 5 + examples/xml/test/testdevfs.xml | 6 + examples/xml/test/testdevhostdev.xml | 5 + examples/xml/test/testdevif.xml | 6 + examples/xml/test/testdevinput.xml | 1 + examples/xml/test/testdevlease.xml | 5 + examples/xml/test/testdevmem.xml | 6 + examples/xml/test/testdevmemballoon.xml | 3 + examples/xml/test/testdevrng.xml | 4 + examples/xml/test/testdevshmem.xml | 4 + examples/xml/test/testdevsound.xml | 3 + examples/xml/test/testdevtpm.xml | 5 + examples/xml/test/testdevvsock.xml | 3 + examples/xml/test/testdevwatchdog.xml | 1 + examples/xml/test/testdomfc5.xml | 54 +++++ examples/xml/test/testnodeinline.xml | 54 +++++ src/conf/domain_conf.c | 103 ++++++++ src/conf/domain_conf.h | 12 + src/hypervisor/domain_driver.c | 303 ++++++++++++++++++++++++ src/hypervisor/domain_driver.h | 47 ++++ src/libvirt_private.syms | 20 ++ src/libxl/libxl_driver.c | 41 +--- src/lxc/lxc_driver.c | 37 +-- src/qemu/qemu_driver.c | 124 ++-------- src/test/test_driver.c | 239 +++++++++++++++++++ tests/virshtest.c | 131 ++++++++-- 27 files changed, 1033 insertions(+), 190 deletions(-) create mode 100644 examples/xml/test/testdevcontroller.xml create mode 100644 examples/xml/test/testdevdiskcdrom.xml create mode 100644 examples/xml/test/testdevfs.xml create mode 100644 examples/xml/test/testdevhostdev.xml create mode 100644 examples/xml/test/testdevif.xml create mode 100644 examples/xml/test/testdevinput.xml create mode 100644 examples/xml/test/testdevlease.xml create mode 100644 examples/xml/test/testdevmem.xml create mode 100644 examples/xml/test/testdevmemballoon.xml create mode 100644 examples/xml/test/testdevrng.xml create mode 100644 examples/xml/test/testdevshmem.xml create mode 100644 examples/xml/test/testdevsound.xml create mode 100644 examples/xml/test/testdevtpm.xml create mode 100644 examples/xml/test/testdevvsock.xml create mode 100644 examples/xml/test/testdevwatchdog.xml -- 2.33.0

1 12

[libvirt PATCH 0/2] tests: use g_auto more (glib chronicles)
by Ján Tomko 20 Aug '21

20 Aug '21

Convert two more functions to use automatic cleanup. Ján Tomko (2): tests: use g_auto in testQemuGetCaps tests: use g_auto in qemuTestParseCapabilitiesArch tests/qemucaps2xmltest.c | 16 ++++++---------- tests/testutilsqemu.c | 10 +++------- 2 files changed, 9 insertions(+), 17 deletions(-) -- 2.31.1

3 4

[PATCH 0/2] qemu: block: Use correct format name when formatting overlay of qcow2+luks
by Peter Krempa 20 Aug '21

20 Aug '21

see 1/2 Peter Krempa (2): qemu: block: Use correct format name when formatting overlay of qcow2+luks qemublocktest: Add test for creating a qcow2 on top of an luks-encrypted qcow2 src/qemu/qemu_block.c | 3 ++- tests/qemublocktest.c | 1 + .../imagecreate/qcow2-backing-qcow2luks.json | 15 +++++++++++++++ .../imagecreate/qcow2-backing-qcow2luks.xml | 1 + 4 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-backing-qcow2luks.json create mode 120000 tests/qemublocktestdata/imagecreate/qcow2-backing-qcow2luks.xml -- 2.31.1

2 3

[PATCH] virsocket: Don't preserve errno in virSocketRecvFD()
by Michal Privoznik 20 Aug '21

20 Aug '21

When setting O_CLOEXEC flag on received FD fails the FD is closed using VIR_FORCE_CLOSE(). But the call is wrapped in errno save which is not necessary because VIR_FORCE_CLOSE() preservers errno value. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virsocket.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/virsocket.c b/src/util/virsocket.c index b971da16e3..a6f185114d 100644 --- a/src/util/virsocket.c +++ b/src/util/virsocket.c @@ -477,9 +477,7 @@ virSocketRecvFD(int sock, int fdflags) /* set close-on-exec flag */ if (!MSG_CMSG_CLOEXEC && (fdflags & O_CLOEXEC)) { if (virSetCloseExec(fd) < 0) { - int saved_errno = errno; VIR_FORCE_CLOSE(fd); - errno = saved_errno; return -1; } } -- 2.31.1

2 1