[libvirt PATCH v4 0/5] add support for Fibre Channel VMID
by Pavel Hrdina
changes in v4:
- documentation fixes
- allow only printable characters to be used in appid
- properly check inode in qemuSetupCgroupAppid
changes in v3:
- rename the XML attribute to appid as technically what user
provides is not VMID, that is created by kernel
changes in v2:
- refactor of resource parsing and formatting code
- use <fibrechannel vmid=''/> element
- use stat() directly
- report only single system error
Pavel Hrdina (5):
vircgroup: introduce virCgroupGetInode function
conf: refactor virDomainResourceDefParse
conf: refactor virDomainResourceDefFormat
conf: introduce support for Fibre Channel VMID
qemu: implement support for Fibre Channel VMID
docs/formatdomain.rst | 21 ++++++++++
docs/schemas/domaincommon.rng | 22 ++++++++--
src/conf/domain_conf.c | 42 +++++++++++--------
src/conf/domain_conf.h | 1 +
src/conf/domain_validate.c | 34 +++++++++++++++
src/libvirt_private.syms | 1 +
src/qemu/qemu_cgroup.c | 30 +++++++++++++
src/util/vircgroup.c | 31 ++++++++++++++
src/util/vircgroup.h | 2 +
.../fibrechannel-appid.xml | 21 ++++++++++
tests/genericxml2xmltest.c | 2 +
11 files changed, 186 insertions(+), 21 deletions(-)
create mode 100644 tests/genericxml2xmlindata/fibrechannel-appid.xml
--
2.31.1
3 years, 6 months
[libvirt PATCH v3 0/5] add support for Fibre Channel VMID
by Pavel Hrdina
changes in v3:
- rename the XML attribute to appid as technically what user
provides is not VMID, that is created by kernel
changes in v2:
- refactor of resource parsing and formatting code
- use <fibrechannel vmid=''/> element
- use stat() directly
- report only single system error
Pavel Hrdina (5):
vircgroup: introduce virCgroupGetInode function
conf: refactor virDomainResourceDefParse
conf: refactor virDomainResourceDefFormat
conf: introduce support for Fibre Channel VMID
qemu: implement support for Fibre Channel VMID
docs/formatdomain.rst | 21 ++++++++++
docs/schemas/domaincommon.rng | 21 ++++++++--
src/conf/domain_conf.c | 42 +++++++++++--------
src/conf/domain_conf.h | 1 +
src/conf/domain_validate.c | 19 +++++++++
src/libvirt_private.syms | 1 +
src/qemu/qemu_cgroup.c | 27 ++++++++++++
src/util/vircgroup.c | 31 ++++++++++++++
src/util/vircgroup.h | 2 +
.../fibrechannel-appid.xml | 21 ++++++++++
tests/genericxml2xmltest.c | 2 +
11 files changed, 167 insertions(+), 21 deletions(-)
create mode 100644 tests/genericxml2xmlindata/fibrechannel-appid.xml
--
2.31.1
3 years, 6 months
[PATCH] security: fix use-after-free in virSecuritySELinuxReserveLabel
by Zhenyu Ye
commit 2e668a61d5ae4("Fix error handling when adding MCS labels") uses
the 'pctx' in virReportError after it has been freed. Fix it.
Fixes: 2e668a61d5ae4cbd6f79e096d0c394f186e132bd
Signed-off-by: eillon <yezhenyu2(a)huawei.com>
---
src/security/security_selinux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index 9ff35a7be5..0e5ea0366d 100644
--- a/src/security/security_selinux.c
+++ b/src/security/security_selinux.c
@@ -967,7 +967,6 @@ virSecuritySELinuxReserveLabel(virSecurityManager *mgr,
}
ctx = context_new(pctx);
- freecon(pctx);
if (!ctx)
goto error;
@@ -985,11 +984,13 @@ virSecuritySELinuxReserveLabel(virSecurityManager *mgr,
goto error;
}
+ freecon(pctx);
context_free(ctx);
return 0;
error:
+ freecon(pctx);
context_free(ctx);
return -1;
}
--
2.27.0
3 years, 6 months
[PATCH 00/22] qemu: Capability probing from 'query-command-line-options' (part 1?)
by Peter Krempa
Hi,
this series started as an exploration in how we use
'query-command-line-options' and the way to possibly step away from
using it. The main problem is that query-command-line-options is using
old-style command line parsing infra in qemu and thus doesn't scale.
In an effor to help qemu developers identify what we still need to query
using the command I set to clean up the parsing.
This series consists of:
- removal of unneeded tests (covered by other cases or pointless)
- adding of comments which simplify lookup of capability string from
enum value name
- grouping of the queries by name
- refactor of probing of stuff which can be probed differently
- removal of some other probes
- cleanups of the driver code
In general we've got the following cases:
- good ones:
- can be queried differently
- this patchset has converted (probably) all of them
- the "bad" ones:
- stuff we can't replace yet and we need to probe it, few examples
are:
- pressence of seccomp
- support of 'fd=' for chardevs
- various VNC and spice config options
- the possibly "ugly":
- these are options which are supported by all qemu versions and are
unlikely to be removed, but there's no different way to probe
them, we can always assume them
- those are the QEMU_CAPS_NAME* and QEMU_CAPS_MSG_TIMESTAMP at the
end, these patches are RFC as it may be considered a backwards
step just to assume it's supported
Note that the removal of probing of -drive throttling caps can be
replaced in case something gets deprecated via probing the 'throttling'
object. This was added recently though. Since it's unlikely that pieces
would be removed in the groups they were added removal of these caps is
classified in the 'good' part.
Peter Krempa (22):
qemuxml2argvtest: Remove negative tests for (aes|dea)keywrap (s390)
property
virQEMUCapsCommandLine: Group by commandline argument name
alphabetically
virQEMUCapsQMPSchemaQueries: Group by queried object name
scripts: group-qemu-caps: Add capability name as comment to capability
string
qemu: capabilities: Note that basing probing on
'query-command-line-options' should be avoided
qemu: capabilities: Probe 'reconnect', 'logfile' and 'append' from
'chardev-add'
qemu: capabilities: Rename QEMU_CAPS_CHARDEV_FD_PASS to
QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE
qemu: capabilities: Probe 'discard' and 'detect-zeroes' from
'blockdev-add'
qemu: capabilities: Probe QEMU_CAPS_SMP_DIES from the QMP schema
qemu: Always assume that qemu supports drive throttling
qemu: capabilties: Retire QEMU_CAPS_DRIVE_IOTUNE_* caps
qemuMonitorJSONSetBlockIoThrottle: Refactor cleanup
qemuMonitorJSONSetBlockIoThrottle: Switch to standard error reporting
qemuMonitorSetBlockIoThrottle: Remove booleans controlling used fields
qemu: capabilities: Add alternative detection of QEMU_CAPS_NUMA
qemuxml2argvtest: Remove 'debug-threads' case
qemuxml2argvtest: Remove 'minimal-msg-timestamp'
qemuxml2argvtest: Remove 'minimal-sandbox' case
qemu: command: Always assume support for '-name guest=' and '-name
debug-threads=on'
qemu: capabilities: Retire QEMU_CAPS_NAME*
qemu: command: Always assume support for '-msg timestamp=on'
qemu: capabilities: Retire QEMU_CAPS_MSG_TIMESTAMP
scripts/group-qemu-caps.py | 43 +-
src/qemu/qemu_capabilities.c | 888 +++++++++---------
src/qemu/qemu_capabilities.h | 14 +-
src/qemu/qemu_command.c | 17 +-
src/qemu/qemu_driver.c | 55 +-
src/qemu/qemu_hotplug.c | 6 +-
src/qemu/qemu_monitor.c | 10 +-
src/qemu/qemu_monitor.h | 5 +-
src/qemu/qemu_monitor_json.c | 119 +--
src/qemu/qemu_monitor_json.h | 5 +-
src/qemu/qemu_process.c | 9 +-
src/qemu/qemu_validate.c | 33 +-
.../caps_2.11.0.s390x.xml | 6 -
.../caps_2.11.0.x86_64.xml | 6 -
.../caps_2.12.0.aarch64.xml | 6 -
.../caps_2.12.0.ppc64.xml | 6 -
.../caps_2.12.0.s390x.xml | 6 -
.../caps_2.12.0.x86_64.xml | 6 -
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 6 -
.../caps_3.0.0.riscv32.xml | 6 -
.../caps_3.0.0.riscv64.xml | 6 -
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 6 -
.../caps_3.0.0.x86_64.xml | 6 -
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 6 -
.../caps_3.1.0.x86_64.xml | 6 -
.../caps_4.0.0.aarch64.xml | 6 -
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 6 -
.../caps_4.0.0.riscv32.xml | 6 -
.../caps_4.0.0.riscv64.xml | 6 -
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 6 -
.../caps_4.0.0.x86_64.xml | 6 -
.../caps_4.1.0.x86_64.xml | 6 -
.../caps_4.2.0.aarch64.xml | 6 -
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 6 -
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 6 -
.../caps_4.2.0.x86_64.xml | 6 -
.../caps_5.0.0.aarch64.xml | 6 -
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 6 -
.../caps_5.0.0.riscv64.xml | 6 -
.../caps_5.0.0.x86_64.xml | 6 -
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 6 -
.../caps_5.1.0.x86_64.xml | 6 -
.../caps_5.2.0.aarch64.xml | 6 -
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 6 -
.../caps_5.2.0.riscv64.xml | 6 -
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 6 -
.../caps_5.2.0.x86_64.xml | 6 -
.../caps_6.0.0.aarch64.xml | 6 -
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 6 -
.../caps_6.0.0.x86_64.xml | 6 -
.../caps_6.1.0.x86_64.xml | 6 -
tests/qemumonitorjsontest.c | 3 +-
.../aarch64-aavmf-virtio-mmio.args | 5 +-
tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 5 +-
.../aarch64-cpu-passthrough.args | 5 +-
tests/qemuxml2argvdata/aarch64-gic-host.args | 5 +-
.../aarch64-gic-none-tcg.args | 5 +-
tests/qemuxml2argvdata/aarch64-gic-v2.args | 5 +-
tests/qemuxml2argvdata/aarch64-gic-v3.args | 5 +-
.../aarch64-kvm-32-on-64.args | 5 +-
.../aarch64-noacpi-nouefi.args | 5 +-
.../qemuxml2argvdata/aarch64-noacpi-uefi.args | 5 +-
.../qemuxml2argvdata/aarch64-pci-serial.args | 5 +-
.../aarch64-traditional-pci.args | 5 +-
.../aarch64-usb-controller-nec-xhci.args | 5 +-
.../aarch64-usb-controller-qemu-xhci.args | 5 +-
.../aarch64-video-default.args | 5 +-
.../aarch64-video-virtio-gpu-pci.args | 5 +-
.../aarch64-virt-2.6-virtio-pci-default.args | 5 +-
.../aarch64-virt-default-nic.args | 5 +-
.../qemuxml2argvdata/aarch64-virt-virtio.args | 5 +-
.../aarch64-virtio-pci-default.args | 5 +-
.../aarch64-virtio-pci-manual-addresses.args | 5 +-
tests/qemuxml2argvdata/acpi-table.args | 5 +-
.../arm-vexpressa9-basic.args | 5 +-
.../arm-vexpressa9-nodevs.args | 5 +-
.../arm-vexpressa9-virtio.args | 5 +-
tests/qemuxml2argvdata/arm-virt-virtio.args | 5 +-
tests/qemuxml2argvdata/audio-alsa-best.args | 5 +-
.../qemuxml2argvdata/audio-alsa-minimal.args | 5 +-
.../audio-coreaudio-best.args | 5 +-
.../audio-coreaudio-minimal.args | 5 +-
.../audio-default-nographics.args | 5 +-
tests/qemuxml2argvdata/audio-default-sdl.args | 5 +-
.../qemuxml2argvdata/audio-default-spice.args | 5 +-
tests/qemuxml2argvdata/audio-default-vnc.args | 5 +-
tests/qemuxml2argvdata/audio-file-best.args | 5 +-
.../qemuxml2argvdata/audio-file-minimal.args | 5 +-
tests/qemuxml2argvdata/audio-none-best.args | 5 +-
.../qemuxml2argvdata/audio-none-minimal.args | 5 +-
tests/qemuxml2argvdata/audio-oss-best.args | 5 +-
tests/qemuxml2argvdata/audio-oss-minimal.args | 5 +-
.../audio-pulseaudio-best.args | 5 +-
.../audio-pulseaudio-minimal.args | 5 +-
tests/qemuxml2argvdata/audio-sdl-best.args | 5 +-
tests/qemuxml2argvdata/audio-sdl-minimal.args | 5 +-
tests/qemuxml2argvdata/audio-spice-best.args | 5 +-
.../qemuxml2argvdata/audio-spice-minimal.args | 5 +-
tests/qemuxml2argvdata/autoindex.args | 5 +-
.../qemuxml2argvdata/balloon-ccw-deflate.args | 5 +-
.../qemuxml2argvdata/balloon-device-auto.args | 5 +-
.../balloon-device-deflate-off.args | 5 +-
.../balloon-device-deflate.args | 5 +-
.../balloon-device-period.args | 5 +-
tests/qemuxml2argvdata/balloon-device.args | 5 +-
.../balloon-mmio-deflate.args | 5 +-
tests/qemuxml2argvdata/bios-nvram-secure.args | 5 +-
tests/qemuxml2argvdata/bios-nvram.args | 5 +-
tests/qemuxml2argvdata/bios.args | 5 +-
tests/qemuxml2argvdata/blkiotune-device.args | 5 +-
tests/qemuxml2argvdata/blkiotune.args | 5 +-
tests/qemuxml2argvdata/boot-cdrom.args | 5 +-
tests/qemuxml2argvdata/boot-complex.args | 5 +-
tests/qemuxml2argvdata/boot-floppy-q35.args | 5 +-
tests/qemuxml2argvdata/boot-floppy.args | 5 +-
.../boot-menu-disable-drive.args | 5 +-
tests/qemuxml2argvdata/boot-menu-disable.args | 5 +-
.../boot-menu-enable-with-timeout.args | 5 +-
tests/qemuxml2argvdata/boot-menu-enable.args | 5 +-
tests/qemuxml2argvdata/boot-multi.args | 5 +-
tests/qemuxml2argvdata/boot-network.args | 5 +-
tests/qemuxml2argvdata/boot-order.args | 5 +-
tests/qemuxml2argvdata/boot-strict.args | 5 +-
tests/qemuxml2argvdata/channel-guestfwd.args | 5 +-
tests/qemuxml2argvdata/channel-spicevmc.args | 5 +-
.../qemuxml2argvdata/channel-virtio-auto.args | 5 +-
.../channel-virtio-autoadd.args | 5 +-
.../channel-virtio-autoassign.args | 5 +-
.../channel-virtio-default.args | 5 +-
.../channel-virtio-state.args | 5 +-
.../qemuxml2argvdata/channel-virtio-unix.args | 5 +-
tests/qemuxml2argvdata/channel-virtio.args | 5 +-
tests/qemuxml2argvdata/chardev-reconnect.args | 5 +-
tests/qemuxml2argvdata/clock-catchup.args | 5 +-
tests/qemuxml2argvdata/clock-france.args | 5 +-
tests/qemuxml2argvdata/clock-hpet-off.args | 5 +-
.../clock-localtime-basis-localtime.args | 5 +-
tests/qemuxml2argvdata/clock-localtime.args | 5 +-
tests/qemuxml2argvdata/clock-realtime.args | 5 +-
.../clock-timer-hyperv-rtc.args | 5 +-
tests/qemuxml2argvdata/clock-utc.args | 5 +-
tests/qemuxml2argvdata/clock-variable.args | 5 +-
.../qemuxml2argvdata/console-compat-auto.args | 5 +-
.../console-compat-chardev.args | 5 +-
tests/qemuxml2argvdata/console-compat.args | 5 +-
.../qemuxml2argvdata/console-virtio-ccw.args | 5 +-
.../qemuxml2argvdata/console-virtio-many.args | 5 +-
tests/qemuxml2argvdata/console-virtio.args | 5 +-
tests/qemuxml2argvdata/controller-order.args | 5 +-
tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 5 +-
tests/qemuxml2argvdata/cpu-Haswell.args | 5 +-
tests/qemuxml2argvdata/cpu-Haswell2.args | 5 +-
tests/qemuxml2argvdata/cpu-Haswell3.args | 5 +-
tests/qemuxml2argvdata/cpu-cache-disable.args | 5 +-
.../qemuxml2argvdata/cpu-cache-disable2.args | 5 +-
.../qemuxml2argvdata/cpu-cache-disable3.args | 5 +-
.../cpu-cache-emulate-l3.args | 5 +-
.../cpu-cache-passthrough.args | 5 +-
.../cpu-cache-passthrough2.args | 5 +-
.../cpu-check-default-none.args | 5 +-
.../cpu-check-default-none2.args | 5 +-
.../cpu-check-default-partial.args | 5 +-
.../cpu-check-default-partial2.args | 5 +-
tests/qemuxml2argvdata/cpu-check-none.args | 5 +-
tests/qemuxml2argvdata/cpu-eoi-disabled.args | 5 +-
tests/qemuxml2argvdata/cpu-eoi-enabled.args | 5 +-
tests/qemuxml2argvdata/cpu-exact1.args | 5 +-
.../cpu-exact2-nofallback.args | 5 +-
tests/qemuxml2argvdata/cpu-exact2.args | 5 +-
tests/qemuxml2argvdata/cpu-fallback.args | 5 +-
tests/qemuxml2argvdata/cpu-host-kvmclock.args | 5 +-
.../qemuxml2argvdata/cpu-host-model-cmt.args | 5 +-
.../cpu-host-model-fallback.args | 5 +-
.../cpu-host-model-vendor.args | 5 +-
tests/qemuxml2argvdata/cpu-host-model.args | 5 +-
.../cpu-host-passthrough-features.args | 5 +-
.../cpu-host-passthrough.args | 5 +-
.../qemuxml2argvdata/cpu-hotplug-startup.args | 5 +-
tests/qemuxml2argvdata/cpu-kvmclock.args | 5 +-
tests/qemuxml2argvdata/cpu-minimum1.args | 5 +-
tests/qemuxml2argvdata/cpu-minimum2.args | 5 +-
.../cpu-no-removed-features.args | 5 +-
tests/qemuxml2argvdata/cpu-numa-disjoint.args | 5 +-
.../qemuxml2argvdata/cpu-numa-memshared.args | 5 +-
.../cpu-numa-no-memory-element.args | 5 +-
tests/qemuxml2argvdata/cpu-numa1.args | 5 +-
tests/qemuxml2argvdata/cpu-numa2.args | 5 +-
tests/qemuxml2argvdata/cpu-s390-features.args | 5 +-
tests/qemuxml2argvdata/cpu-s390-zEC12.args | 5 +-
tests/qemuxml2argvdata/cpu-strict1.args | 5 +-
tests/qemuxml2argvdata/cpu-topology1.args | 5 +-
tests/qemuxml2argvdata/cpu-topology2.args | 5 +-
tests/qemuxml2argvdata/cpu-topology3.args | 5 +-
tests/qemuxml2argvdata/cpu-tsc-frequency.args | 5 +-
tests/qemuxml2argvdata/cputune-numatune.args | 5 +-
.../qemuxml2argvdata/cputune-zero-shares.args | 5 +-
tests/qemuxml2argvdata/cputune.args | 5 +-
tests/qemuxml2argvdata/debug-threads.args | 29 -
tests/qemuxml2argvdata/debug-threads.xml | 34 -
.../default-kvm-host-arch.args | 5 +-
.../default-qemu-host-arch.args | 5 +-
tests/qemuxml2argvdata/disk-aio.args | 5 +-
tests/qemuxml2argvdata/disk-blockio.args | 5 +-
tests/qemuxml2argvdata/disk-boot-cdrom.args | 5 +-
tests/qemuxml2argvdata/disk-boot-disk.args | 5 +-
.../qemuxml2argvdata/disk-cdrom-network.args | 5 +-
tests/qemuxml2argvdata/disk-cdrom-tray.args | 5 +-
tests/qemuxml2argvdata/disk-cdrom.args | 5 +-
tests/qemuxml2argvdata/disk-copy_on_read.args | 5 +-
tests/qemuxml2argvdata/disk-error-policy.args | 5 +-
tests/qemuxml2argvdata/disk-floppy-tray.args | 5 +-
tests/qemuxml2argvdata/disk-floppy.args | 5 +-
tests/qemuxml2argvdata/disk-fmt-qcow.args | 5 +-
tests/qemuxml2argvdata/disk-geometry.args | 5 +-
tests/qemuxml2argvdata/disk-ide-split.args | 5 +-
tests/qemuxml2argvdata/disk-ide-wwn.args | 5 +-
tests/qemuxml2argvdata/disk-ioeventfd.args | 5 +-
tests/qemuxml2argvdata/disk-iscsi.args | 5 +-
.../disk-network-gluster.args | 5 +-
.../disk-network-iscsi-modern.args | 5 +-
.../qemuxml2argvdata/disk-network-iscsi.args | 5 +-
tests/qemuxml2argvdata/disk-network-nbd.args | 5 +-
.../disk-network-sheepdog.args | 5 +-
.../disk-network-source-auth.args | 5 +-
tests/qemuxml2argvdata/disk-network-vxhs.args | 5 +-
tests/qemuxml2argvdata/disk-no-boot.args | 5 +-
tests/qemuxml2argvdata/disk-order.args | 5 +-
.../qemuxml2argvdata/disk-readonly-disk.args | 5 +-
tests/qemuxml2argvdata/disk-sata-device.args | 5 +-
.../disk-scsi-disk-split.args | 5 +-
.../qemuxml2argvdata/disk-scsi-disk-vpd.args | 5 +-
.../qemuxml2argvdata/disk-scsi-disk-wwn.args | 5 +-
.../disk-scsi-lun-passthrough.args | 5 +-
tests/qemuxml2argvdata/disk-serial.args | 5 +-
tests/qemuxml2argvdata/disk-snapshot.args | 5 +-
.../disk-source-pool-mode.args | 5 +-
tests/qemuxml2argvdata/disk-source-pool.args | 5 +-
.../disk-usb-device-removable.args | 5 +-
tests/qemuxml2argvdata/disk-usb-device.args | 5 +-
.../disk-virtio-ccw-many.args | 5 +-
tests/qemuxml2argvdata/disk-virtio-ccw.args | 5 +-
.../qemuxml2argvdata/disk-virtio-queues.args | 5 +-
.../disk-virtio-s390-zpci.args | 5 +-
tests/qemuxml2argvdata/disk-virtio.args | 5 +-
.../encrypted-disk-usage.args | 5 +-
tests/qemuxml2argvdata/encrypted-disk.args | 5 +-
tests/qemuxml2argvdata/event_idx.args | 5 +-
.../fd-memory-no-numa-topology.args | 5 +-
.../fd-memory-numa-topology.args | 5 +-
.../fd-memory-numa-topology2.args | 5 +-
.../fd-memory-numa-topology3.args | 5 +-
tests/qemuxml2argvdata/floppy-drive-fat.args | 5 +-
tests/qemuxml2argvdata/fs9p-ccw.args | 5 +-
tests/qemuxml2argvdata/fs9p.args | 5 +-
.../graphics-egl-headless.args | 5 +-
.../graphics-sdl-fullscreen.args | 5 +-
tests/qemuxml2argvdata/graphics-sdl.args | 5 +-
.../graphics-spice-agent-file-xfer.args | 5 +-
.../graphics-spice-agentmouse.args | 5 +-
.../graphics-spice-auto-socket-cfg.args | 5 +-
.../graphics-spice-auto-socket.args | 5 +-
.../graphics-spice-compression.args | 5 +-
.../graphics-spice-egl-headless.args | 5 +-
.../graphics-spice-no-args.args | 5 +-
.../graphics-spice-qxl-vga.args | 5 +-
.../qemuxml2argvdata/graphics-spice-sasl.args | 5 +-
.../graphics-spice-socket.args | 5 +-
.../graphics-spice-timeout.args | 5 +-
.../graphics-spice-usb-redir.args | 5 +-
tests/qemuxml2argvdata/graphics-spice.args | 5 +-
.../graphics-vnc-auto-socket-cfg.args | 5 +-
.../graphics-vnc-auto-socket.args | 5 +-
.../graphics-vnc-egl-headless.args | 5 +-
.../graphics-vnc-no-listen-attr.args | 5 +-
tests/qemuxml2argvdata/graphics-vnc-none.args | 5 +-
.../qemuxml2argvdata/graphics-vnc-policy.args | 5 +-
.../graphics-vnc-remove-generated-socket.args | 5 +-
tests/qemuxml2argvdata/graphics-vnc-sasl.args | 5 +-
.../graphics-vnc-socket-new-cmdline.args | 5 +-
.../qemuxml2argvdata/graphics-vnc-socket.args | 5 +-
tests/qemuxml2argvdata/graphics-vnc-tls.args | 5 +-
.../graphics-vnc-websocket.args | 5 +-
tests/qemuxml2argvdata/graphics-vnc.args | 5 +-
.../hostdev-mdev-precreated.args | 5 +-
.../hostdev-pci-address-device.args | 5 +-
.../hostdev-pci-address-unassigned.args | 5 +-
.../qemuxml2argvdata/hostdev-pci-address.args | 5 +-
.../hostdev-pci-multifunction.args | 5 +-
.../hostdev-scsi-vhost-scsi-ccw.args | 5 +-
.../hostdev-scsi-vhost-scsi-pci.args | 5 +-
.../hostdev-scsi-vhost-scsi-pcie.args | 5 +-
.../hostdev-subsys-mdev-vfio-ccw.args | 5 +-
.../hostdev-usb-address-device-boot.args | 5 +-
.../hostdev-usb-address-device.args | 5 +-
.../qemuxml2argvdata/hostdev-usb-address.args | 5 +-
.../hostdev-vfio-multidomain.args | 5 +-
.../hostdev-vfio-zpci-autogenerate-fids.args | 5 +-
.../hostdev-vfio-zpci-autogenerate-uids.args | 5 +-
.../hostdev-vfio-zpci-autogenerate.args | 5 +-
.../hostdev-vfio-zpci-boundaries.args | 5 +-
.../hostdev-vfio-zpci-ccw-memballoon.args | 5 +-
.../hostdev-vfio-zpci-multidomain-many.args | 5 +-
tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 5 +-
tests/qemuxml2argvdata/hostdev-vfio.args | 5 +-
tests/qemuxml2argvdata/hotplug-base.args | 5 +-
.../hugepages-default-2M.args | 5 +-
.../hugepages-default-system-size.args | 5 +-
tests/qemuxml2argvdata/hugepages-default.args | 5 +-
.../qemuxml2argvdata/hugepages-memaccess.args | 5 +-
.../hugepages-memaccess2.args | 5 +-
tests/qemuxml2argvdata/hugepages-nodeset.args | 5 +-
.../hugepages-numa-default-2M.args | 5 +-
.../hugepages-numa-default-dimm.args | 5 +-
.../hugepages-numa-default.args | 5 +-
.../hugepages-numa-nodeset-part.args | 5 +-
.../hugepages-numa-nodeset.args | 5 +-
tests/qemuxml2argvdata/hugepages-shared.args | 5 +-
.../qemuxml2argvdata/input-usbmouse-addr.args | 5 +-
tests/qemuxml2argvdata/input-usbmouse.args | 5 +-
tests/qemuxml2argvdata/input-usbtablet.args | 5 +-
tests/qemuxml2argvdata/input-virtio-ccw.args | 5 +-
.../iothreads-disk-virtio-ccw.args | 5 +-
tests/qemuxml2argvdata/iothreads-disk.args | 5 +-
.../iothreads-ids-partial.args | 5 +-
tests/qemuxml2argvdata/iothreads-ids.args | 5 +-
tests/qemuxml2argvdata/iothreads.args | 5 +-
tests/qemuxml2argvdata/kvm-features-off.args | 5 +-
tests/qemuxml2argvdata/kvm-features.args | 5 +-
tests/qemuxml2argvdata/kvm-pit-delay.args | 5 +-
tests/qemuxml2argvdata/kvm-pit-discard.args | 5 +-
tests/qemuxml2argvdata/kvmclock.args | 5 +-
.../luks-disks-source-qcow2.args | 5 +-
tests/qemuxml2argvdata/luks-disks-source.args | 5 +-
tests/qemuxml2argvdata/luks-disks.args | 5 +-
.../mach-virt-console-virtio.args | 5 +-
.../mach-virt-serial-native.args | 5 +-
.../mach-virt-serial-pci.args | 5 +-
.../mach-virt-serial-usb.args | 5 +-
.../machine-aeskeywrap-off-cap.args | 5 +-
.../machine-aeskeywrap-off-cap.err | 1 -
.../machine-aeskeywrap-off-caps.args | 5 +-
.../machine-aeskeywrap-off-caps.err | 1 -
.../machine-aeskeywrap-on-cap.args | 5 +-
.../machine-aeskeywrap-on-cap.err | 1 -
.../machine-aeskeywrap-on-caps.args | 5 +-
.../machine-aeskeywrap-on-caps.err | 1 -
tests/qemuxml2argvdata/machine-aliases1.args | 5 +-
tests/qemuxml2argvdata/machine-aliases2.args | 5 +-
tests/qemuxml2argvdata/machine-core-off.args | 5 +-
tests/qemuxml2argvdata/machine-core-on.args | 5 +-
.../machine-deakeywrap-off-cap.args | 5 +-
.../machine-deakeywrap-off-cap.err | 1 -
.../machine-deakeywrap-off-caps.args | 5 +-
.../machine-deakeywrap-off-caps.err | 1 -
.../machine-deakeywrap-on-cap.args | 5 +-
.../machine-deakeywrap-on-cap.err | 1 -
.../machine-deakeywrap-on-caps.args | 5 +-
.../machine-deakeywrap-on-caps.err | 1 -
.../machine-keywrap-none-caps.args | 5 +-
.../machine-keywrap-none.args | 5 +-
...ine-loadparm-multiple-disks-nets-s390.args | 5 +-
.../machine-loadparm-net-s390.args | 5 +-
.../machine-loadparm-s390.args | 5 +-
tests/qemuxml2argvdata/machine-smm-opt.args | 5 +-
.../qemuxml2argvdata/machine-vmport-opt.args | 5 +-
tests/qemuxml2argvdata/master-key.args | 5 +-
.../memory-hotplug-dimm-addr.args | 5 +-
.../qemuxml2argvdata/memory-hotplug-dimm.args | 5 +-
...emory-hotplug-nvdimm-ppc64-abi-update.args | 5 +-
.../memory-hotplug-nvdimm-ppc64.args | 5 +-
...emory-hotplug-ppc64-nonuma-abi-update.args | 5 +-
.../memory-hotplug-ppc64-nonuma.args | 5 +-
tests/qemuxml2argvdata/memory-hotplug.args | 5 +-
tests/qemuxml2argvdata/memtune-unlimited.args | 5 +-
tests/qemuxml2argvdata/memtune.args | 5 +-
.../migrate-numa-unaligned.args | 5 +-
tests/qemuxml2argvdata/migrate.args | 5 +-
.../minimal-msg-timestamp.args | 30 -
.../minimal-msg-timestamp.xml | 32 -
tests/qemuxml2argvdata/minimal-sandbox.args | 30 -
tests/qemuxml2argvdata/minimal-sandbox.xml | 34 -
tests/qemuxml2argvdata/minimal.args | 5 +-
tests/qemuxml2argvdata/misc-acpi.args | 5 +-
tests/qemuxml2argvdata/misc-disable-s3.args | 5 +-
.../misc-disable-suspends.args | 5 +-
tests/qemuxml2argvdata/misc-enable-s4.args | 5 +-
tests/qemuxml2argvdata/misc-no-reboot.args | 5 +-
tests/qemuxml2argvdata/misc-uuid.args | 5 +-
tests/qemuxml2argvdata/monitor-json.args | 5 +-
.../multifunction-pci-device.args | 5 +-
tests/qemuxml2argvdata/name-escape.args | 3 +-
tests/qemuxml2argvdata/net-client.args | 5 +-
tests/qemuxml2argvdata/net-eth-hostip.args | 5 +-
tests/qemuxml2argvdata/net-eth-ifname.args | 5 +-
tests/qemuxml2argvdata/net-eth-names.args | 5 +-
.../net-eth-unmanaged-tap.args | 5 +-
tests/qemuxml2argvdata/net-eth.args | 5 +-
.../net-hostdev-bootorder.args | 5 +-
.../net-hostdev-multidomain.args | 5 +-
.../net-hostdev-vfio-multidomain.args | 5 +-
tests/qemuxml2argvdata/net-hostdev-vfio.args | 5 +-
tests/qemuxml2argvdata/net-hostdev.args | 5 +-
tests/qemuxml2argvdata/net-many-models.args | 5 +-
tests/qemuxml2argvdata/net-mcast.args | 5 +-
tests/qemuxml2argvdata/net-server.args | 5 +-
tests/qemuxml2argvdata/net-udp.args | 5 +-
tests/qemuxml2argvdata/net-user-addr.args | 5 +-
tests/qemuxml2argvdata/net-user.args | 5 +-
.../net-vhostuser-multiq.args | 5 +-
tests/qemuxml2argvdata/net-vhostuser.args | 5 +-
tests/qemuxml2argvdata/net-virtio-ccw.args | 5 +-
tests/qemuxml2argvdata/net-virtio-device.args | 5 +-
.../net-virtio-disable-offloads.args | 5 +-
tests/qemuxml2argvdata/net-virtio-netdev.args | 5 +-
.../net-virtio-rxtxqueuesize.args | 5 +-
.../net-virtio-teaming-hostdev.args | 5 +-
.../qemuxml2argvdata/net-virtio-teaming.args | 5 +-
tests/qemuxml2argvdata/net-virtio.args | 5 +-
tests/qemuxml2argvdata/nosharepages.args | 5 +-
.../numad-auto-memory-vcpu-cpuset.args | 5 +-
...o-memory-vcpu-no-cpuset-and-placement.args | 5 +-
.../numad-auto-vcpu-static-numatune.args | 5 +-
.../numad-static-memory-auto-vcpu.args | 5 +-
tests/qemuxml2argvdata/numad.args | 5 +-
.../numatune-auto-nodeset-invalid.args | 5 +-
.../numatune-auto-prefer.args | 5 +-
.../qemuxml2argvdata/numatune-distances.args | 5 +-
.../numatune-memnode-no-memory.args | 5 +-
tests/qemuxml2argvdata/numatune-memnode.args | 5 +-
tests/qemuxml2argvdata/numatune-memory.args | 5 +-
tests/qemuxml2argvdata/numatune-no-vcpu.args | 5 +-
.../qemuxml2argvdata/pages-dimm-discard.args | 5 +-
.../pages-discard-hugepages.args | 5 +-
tests/qemuxml2argvdata/pages-discard.args | 5 +-
tests/qemuxml2argvdata/panic-double.args | 5 +-
tests/qemuxml2argvdata/panic-no-address.args | 5 +-
tests/qemuxml2argvdata/panic.args | 5 +-
.../parallel-parport-chardev.args | 5 +-
.../parallel-tcp-chardev.args | 5 +-
tests/qemuxml2argvdata/pci-autoadd-addr.args | 5 +-
tests/qemuxml2argvdata/pci-autoadd-idx.args | 5 +-
tests/qemuxml2argvdata/pci-autofill-addr.args | 5 +-
.../pci-bridge-many-disks.args | 5 +-
tests/qemuxml2argvdata/pci-bridge.args | 5 +-
tests/qemuxml2argvdata/pci-expander-bus.args | 5 +-
tests/qemuxml2argvdata/pci-many.args | 5 +-
tests/qemuxml2argvdata/pci-rom-disabled.args | 5 +-
tests/qemuxml2argvdata/pci-rom.args | 5 +-
.../pci-serial-dev-chardev.args | 5 +-
tests/qemuxml2argvdata/pcie-expander-bus.args | 5 +-
.../pcie-root-port-model-generic.args | 5 +-
.../pcie-root-port-model-ioh3420.args | 5 +-
tests/qemuxml2argvdata/pcie-root-port.args | 5 +-
tests/qemuxml2argvdata/pcie-root.args | 5 +-
.../pcie-switch-downstream-port.args | 5 +-
.../pcie-switch-upstream-port.args | 5 +-
tests/qemuxml2argvdata/pcihole64-q35.args | 5 +-
tests/qemuxml2argvdata/pcihole64.args | 5 +-
tests/qemuxml2argvdata/pmu-feature-off.args | 5 +-
tests/qemuxml2argvdata/pmu-feature.args | 5 +-
tests/qemuxml2argvdata/ppc-dtb.args | 5 +-
.../ppc64-usb-controller-legacy.args | 5 +-
.../ppc64-usb-controller-qemu-xhci.args | 5 +-
.../ppc64-usb-controller.args | 5 +-
tests/qemuxml2argvdata/ppce500-serial.args | 5 +-
tests/qemuxml2argvdata/pseries-basic.args | 5 +-
.../pseries-console-virtio.args | 5 +-
.../pseries-cpu-compat-power9.args | 5 +-
.../qemuxml2argvdata/pseries-cpu-compat.args | 5 +-
tests/qemuxml2argvdata/pseries-cpu-exact.args | 5 +-
tests/qemuxml2argvdata/pseries-cpu-le.args | 5 +-
tests/qemuxml2argvdata/pseries-features.args | 5 +-
.../qemuxml2argvdata/pseries-hostdevs-1.args | 5 +-
.../qemuxml2argvdata/pseries-hostdevs-2.args | 5 +-
.../qemuxml2argvdata/pseries-hostdevs-3.args | 5 +-
.../pseries-machine-max-cpu-compat.args | 5 +-
.../pseries-many-buses-1.args | 5 +-
.../pseries-many-buses-2.args | 5 +-
.../pseries-many-devices.args | 5 +-
tests/qemuxml2argvdata/pseries-nvram.args | 5 +-
.../pseries-panic-missing.args | 5 +-
.../pseries-panic-no-address.args | 5 +-
.../pseries-phb-default-missing.args | 5 +-
.../pseries-phb-numa-node.args | 5 +-
.../qemuxml2argvdata/pseries-phb-simple.args | 5 +-
.../pseries-serial-native.args | 5 +-
.../qemuxml2argvdata/pseries-serial-pci.args | 5 +-
.../qemuxml2argvdata/pseries-serial-usb.args | 5 +-
.../qemuxml2argvdata/pseries-usb-default.args | 5 +-
tests/qemuxml2argvdata/pseries-usb-kbd.args | 5 +-
tests/qemuxml2argvdata/pseries-usb-multi.args | 5 +-
.../pseries-vio-user-assigned.args | 5 +-
tests/qemuxml2argvdata/pseries-vio.args | 5 +-
tests/qemuxml2argvdata/q35-acpi-nouefi.args | 5 +-
tests/qemuxml2argvdata/q35-acpi-uefi.args | 5 +-
.../q35-default-devices-only.args | 5 +-
tests/qemuxml2argvdata/q35-multifunction.args | 5 +-
tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 5 +-
.../q35-pci-force-address.args | 5 +-
tests/qemuxml2argvdata/q35-pcie-autoadd.args | 5 +-
tests/qemuxml2argvdata/q35-pcie.args | 5 +-
.../q35-pm-disable-fallback.args | 5 +-
tests/qemuxml2argvdata/q35-pm-disable.args | 5 +-
tests/qemuxml2argvdata/q35-usb2-multi.args | 5 +-
tests/qemuxml2argvdata/q35-usb2-reorder.args | 5 +-
tests/qemuxml2argvdata/q35-usb2.args | 5 +-
.../q35-virt-manager-basic.args | 5 +-
tests/qemuxml2argvdata/q35-virtio-pci.args | 5 +-
tests/qemuxml2argvdata/q35.args | 5 +-
tests/qemuxml2argvdata/qemu-ns-alt.args | 5 +-
.../qemu-ns-commandline-ns0.args | 6 +-
.../qemu-ns-commandline-ns1.args | 6 +-
.../qemuxml2argvdata/qemu-ns-commandline.args | 6 +-
.../qemu-ns-domain-commandline-ns0.args | 6 +-
.../qemu-ns-domain-commandline.args | 6 +-
.../qemuxml2argvdata/qemu-ns-domain-ns0.args | 6 +-
tests/qemuxml2argvdata/qemu-ns-no-env.args | 5 +-
.../reboot-timeout-disabled.args | 5 +-
.../reboot-timeout-enabled.args | 5 +-
tests/qemuxml2argvdata/restore-v2-fd.args | 5 +-
tests/qemuxml2argvdata/restore-v2.args | 5 +-
tests/qemuxml2argvdata/riscv64-virt-pci.args | 5 +-
tests/qemuxml2argvdata/riscv64-virt.args | 5 +-
.../qemuxml2argvdata/s390-panic-missing.args | 5 +-
.../s390-panic-no-address.args | 5 +-
tests/qemuxml2argvdata/s390-serial-2.args | 5 +-
.../qemuxml2argvdata/s390-serial-console.args | 5 +-
tests/qemuxml2argvdata/s390-serial.args | 5 +-
tests/qemuxml2argvdata/seclabel-dac-none.args | 5 +-
.../seclabel-dynamic-baselabel.args | 5 +-
.../seclabel-dynamic-labelskip.args | 5 +-
.../seclabel-dynamic-override.args | 5 +-
.../seclabel-dynamic-relabel.args | 5 +-
tests/qemuxml2argvdata/seclabel-dynamic.args | 5 +-
tests/qemuxml2argvdata/seclabel-none.args | 5 +-
.../seclabel-static-labelskip.args | 5 +-
.../seclabel-static-relabel.args | 5 +-
tests/qemuxml2argvdata/seclabel-static.args | 5 +-
.../serial-dev-chardev-iobase.args | 5 +-
.../qemuxml2argvdata/serial-dev-chardev.args | 5 +-
.../qemuxml2argvdata/serial-file-chardev.args | 5 +-
tests/qemuxml2argvdata/serial-file-log.args | 5 +-
.../qemuxml2argvdata/serial-many-chardev.args | 5 +-
.../qemuxml2argvdata/serial-pty-chardev.args | 5 +-
.../serial-spiceport-nospice.args | 5 +-
tests/qemuxml2argvdata/serial-spiceport.args | 5 +-
.../qemuxml2argvdata/serial-tcp-chardev.args | 5 +-
.../serial-tcp-telnet-chardev.args | 5 +-
.../serial-tcp-tlsx509-chardev-notls.args | 5 +-
.../serial-tcp-tlsx509-chardev-verify.args | 5 +-
.../serial-tcp-tlsx509-chardev.args | 5 +-
.../serial-tcp-tlsx509-secret-chardev.args | 5 +-
.../qemuxml2argvdata/serial-udp-chardev.args | 5 +-
.../qemuxml2argvdata/serial-unix-chardev.args | 5 +-
tests/qemuxml2argvdata/serial-vc-chardev.args | 5 +-
.../shmem-plain-doorbell.args | 5 +-
tests/qemuxml2argvdata/shmem.args | 5 +-
.../smartcard-controller.args | 5 +-
.../smartcard-host-certificates-database.args | 5 +-
.../smartcard-host-certificates.args | 5 +-
tests/qemuxml2argvdata/smartcard-host.args | 5 +-
.../smartcard-passthrough-spicevmc.args | 5 +-
.../smartcard-passthrough-tcp.args | 5 +-
tests/qemuxml2argvdata/smbios-type-fwcfg.args | 5 +-
tests/qemuxml2argvdata/smbios.args | 5 +-
tests/qemuxml2argvdata/smp-dies.args | 5 +-
tests/qemuxml2argvdata/smp.args | 5 +-
tests/qemuxml2argvdata/sound-device.args | 5 +-
tests/qemuxml2argvdata/sound.args | 5 +-
tests/qemuxml2argvdata/sparc-minimal.args | 5 +-
.../usb-controller-default-q35.args | 5 +-
.../usb-controller-explicit-q35.args | 5 +-
.../usb-controller-qemu-xhci.args | 5 +-
.../qemuxml2argvdata/usb-controller-xhci.args | 5 +-
tests/qemuxml2argvdata/usb-controller.args | 5 +-
.../usb-hub-autoadd-deluxe.args | 5 +-
tests/qemuxml2argvdata/usb-hub-autoadd.args | 5 +-
tests/qemuxml2argvdata/usb-hub.args | 5 +-
.../qemuxml2argvdata/usb-ich9-autoassign.args | 5 +-
.../qemuxml2argvdata/usb-ich9-companion.args | 5 +-
.../qemuxml2argvdata/usb-ich9-ehci-addr.args | 5 +-
.../qemuxml2argvdata/usb-long-port-path.args | 5 +-
tests/qemuxml2argvdata/usb-none.args | 5 +-
.../usb-piix3-controller.args | 5 +-
.../qemuxml2argvdata/usb-port-autoassign.args | 5 +-
tests/qemuxml2argvdata/usb-port-missing.args | 5 +-
tests/qemuxml2argvdata/usb-ports.args | 5 +-
tests/qemuxml2argvdata/usb-redir-boot.args | 5 +-
.../usb-redir-filter-version.args | 5 +-
tests/qemuxml2argvdata/usb-redir-filter.args | 5 +-
tests/qemuxml2argvdata/usb-redir.args | 5 +-
.../qemuxml2argvdata/usb-xhci-autoassign.args | 5 +-
tests/qemuxml2argvdata/usb1-usb2.args | 5 +-
tests/qemuxml2argvdata/user-aliases-usb.args | 5 +-
tests/qemuxml2argvdata/user-aliases.args | 5 +-
.../vcpu-placement-static.args | 5 +-
.../video-device-pciaddr-default.args | 5 +-
tests/qemuxml2argvdata/video-none-device.args | 5 +-
.../video-qxl-device-vgamem.args | 5 +-
tests/qemuxml2argvdata/video-qxl-device.args | 5 +-
tests/qemuxml2argvdata/video-qxl-heads.args | 5 +-
tests/qemuxml2argvdata/video-qxl-noheads.args | 5 +-
.../video-qxl-resolution.args | 5 +-
.../video-qxl-sec-device-vgamem.args | 5 +-
.../video-qxl-sec-device.args | 5 +-
.../video-vga-device-vgamem.args | 5 +-
tests/qemuxml2argvdata/video-vga-device.args | 5 +-
.../qemuxml2argvdata/video-vga-qxl-heads.args | 5 +-
.../video-virtio-gpu-ccw.args | 5 +-
.../video-virtio-gpu-device.args | 5 +-
.../video-virtio-gpu-sdl-gl.args | 5 +-
.../video-virtio-gpu-secondary.args | 5 +-
.../video-virtio-gpu-spice-gl.args | 5 +-
.../video-virtio-gpu-virgl.args | 5 +-
tests/qemuxml2argvdata/video-virtio-vga.args | 5 +-
.../virtio-input-passthrough.args | 5 +-
tests/qemuxml2argvdata/virtio-input.args | 5 +-
tests/qemuxml2argvdata/virtio-lun.args | 5 +-
tests/qemuxml2argvdata/virtio-rng-ccw.args | 5 +-
.../qemuxml2argvdata/virtio-rng-default.args | 5 +-
tests/qemuxml2argvdata/virtio-rng-egd.args | 5 +-
.../qemuxml2argvdata/virtio-rng-multiple.args | 5 +-
tests/qemuxml2argvdata/virtio-rng-random.args | 5 +-
tests/qemuxml2argvdata/vmcoreinfo.args | 5 +-
tests/qemuxml2argvdata/watchdog-device.args | 5 +-
tests/qemuxml2argvdata/watchdog-dump.args | 5 +-
.../qemuxml2argvdata/watchdog-injectnmi.args | 5 +-
tests/qemuxml2argvdata/watchdog.args | 5 +-
tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 5 +-
tests/qemuxml2argvtest.c | 34 +-
630 files changed, 2232 insertions(+), 2259 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/debug-threads.args
delete mode 100644 tests/qemuxml2argvdata/debug-threads.xml
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-off-cap.err
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-off-caps.err
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-on-cap.err
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-on-caps.err
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-off-cap.err
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-off-caps.err
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-on-cap.err
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-on-caps.err
delete mode 100644 tests/qemuxml2argvdata/minimal-msg-timestamp.args
delete mode 100644 tests/qemuxml2argvdata/minimal-msg-timestamp.xml
delete mode 100644 tests/qemuxml2argvdata/minimal-sandbox.args
delete mode 100644 tests/qemuxml2argvdata/minimal-sandbox.xml
--
2.31.1
3 years, 6 months
build broken!
by Ani Sinha
Hi :
getting this strange build error here. Googling did not help. Anyone has
any ideas as to what I am missing? I am on Ubuntu 20.04 LTS.
FAILED: src/libvirt-admin.so.0.7006.0
cc -o src/libvirt-admin.so.0.7006.0
src/libvirt-admin.so.0.7006.0.p/meson-generated_.._admin_admin_protocol.c.o
src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o
src/libvirt-admin.so.0.7006.0.p/datatypes.c.o -Wl,--as-needed
-Wl,--no-undefined -shared -fPIC -Wl,--start-group
-Wl,-soname,libvirt-admin.so.0
'-Wl,-rpath,$ORIGIN/:XXXXXXXXXXXXXXXXXXXXXXX'
-Wl,-rpath-link,/home/anisinha/workspace/libvirt/build/src
src/libvirt.so.0.7006.0
-Wl,--version-script=/home/anisinha/workspace/libvirt/build/src/admin/libvirt_admin.syms
-Wl,-z,nodelete /usr/lib/x86_64-linux-gnu/libcap-ng.so
/usr/lib/x86_64-linux-gnu/libgnutls.so -Wl,-z,relro -Wl,-z,now
-Wl,--no-copy-dt-needed-entries /usr/lib/x86_64-linux-gnu/libglib-2.0.so
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so
/usr/lib/x86_64-linux-gnu/libgio-2.0.so
/usr/lib/x86_64-linux-gnu/libxml2.so -Wl,--end-group
/usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in
function `callFull':
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:99:
undefined reference to `virNetClientProgramCall'
/usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in
function `remoteAdminConnectClose':
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:197:
undefined reference to `virNetClientSetCloseCallback'
/usr/bin/ld:
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:199:
undefined reference to `virNetClientClose'
/usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in
function `remoteAdminPrivNew':
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:225:
undefined reference to `virNetClientNewUNIX'
/usr/bin/ld:
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:228:
undefined reference to `virNetClientProgramNew'
/usr/bin/ld:
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:233:
undefined reference to `virNetClientAddProgram'
/usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in
function `remoteAdminConnectOpen':
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:159:
undefined reference to `virNetClientRegisterAsyncIO'
/usr/bin/ld:
/home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:166:
undefined reference to `virNetClientSetCloseCallback'
/usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in
function `virAdmConnectIsAlive':
/home/anisinha/workspace/libvirt/build/../src/admin/libvirt-admin.c:397:
undefined reference to `virNetClientIsOpen'
Thanks
ani
3 years, 6 months
Issue report: Snapshot-create-as block while the vm's process is killed out.
by 13520781732＠189.cn
Hello,
I have meet one issues while using snapshot-create-as with external file.
Centos 8,
Libivirt 7.0.0
Qemu: 5.2.0
While making one snapshot with memory and disk extaernal file, and killing the process of the vm qemu same time mostly, the snapshot-create-as command blocked.
So it will failed to start the vm again for "cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML)".
The log is as bellow:
2021-08-12 10:27:38.373+0000: 4344: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:27:38.573+0000: 4340: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:27:38.757+0000: 128211: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:27:39.397+0000: 4341: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:27:39.887+0000: 4309: error : virNetSocketReadWire:1817 : End of file while reading data: Input/output error
2021-08-12 10:27:53.735+0000: 4340: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:27:54.822+0000: 4344: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:27:55.230+0000: 4340: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected
2021-08-12 10:46:40.994+0000: 4344: warning : qemuDomainObjTaint:6187 : Domain id=95 name='vm_6_135' uuid=b2812e01-331a-4e65-912b-73be5ace2271 is tainted: high-privileges
2021-08-12 10:48:05.785+0000: 4309: error : virNetSocketReadWire:1817 : End of file while reading data: Input/output error
2021-08-12 10:49:50.440+0000: 1643666: error : qemuMonitorIO:583 : internal error: End of file from qemu monitor
2021-08-12 10:50:13.809+0000: 4341: warning : qemuDomainObjTaint:6187 : Domain id=96 name='vm_6_135' uuid=b2812e01-331a-4e65-912b-73be5ace2271 is tainted: high-privileges
2021-08-12 10:51:21.587+0000: 1646757: error : qemuMonitorIO:583 : internal error: End of file from qemu monitor
2021-08-12 10:52:28.421+0000: 4342: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 67s)
2021-08-12 10:52:28.421+0000: 4342: error : qemuDomainObjBeginJobInternal:975 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML)
2021-08-12 10:53:10.522+0000: 4342: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 109s)
2021-08-12 10:53:10.522+0000: 4342: error : qemuDomainObjBeginJobInternal:975 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML)
2021-08-12 10:53:17.821+0000: 128211: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 117s)
2021-08-12 10:53:17.821+0000: 128211: error : qemuDomainObjBeginJobInternal:975 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML)
... ...
2021-08-13 05:49:41.240+0000: 4342: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 68300s)
Gdb attach the proces of the libvirt, found there are two suspicious threads, stack as below:
gdb) bt
#0 0x00007f8f91a492fc in pthread_cond_wait@(a)GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1 0x00007f8f9574ed7a in virCondWait () from /lib64/libvirt.so.0
#2 0x00007f8f95784ef5 in virDomainObjWait () from /lib64/libvirt.so.0
#3 0x00007f8f422eb26d in qemuMigrationSrcWaitForCompletion () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#4 0x00007f8f422ee5d3 in qemuMigrationSrcToFile () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#5 0x00007f8f42331caa in qemuSaveImageCreate () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#6 0x00007f8f42336ac0 in qemuSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#7 0x00007f8f422b6ac1 in qemuDomainSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#8 0x00007f8f9591f604 in virDomainSnapshotCreateXML () from /lib64/libvirt.so.0
#9 0x0000562390841b81 in remoteDispatchDomainSnapshotCreateXMLHelper ()
#10 0x00007f8f9580e807 in virNetServerProgramDispatch () from /lib64/libvirt.so.0
#11 0x00007f8f95813b26 in virNetServerHandleJob () from /lib64/libvirt.so.0
#12 0x00007f8f9574f85f in virThreadPoolWorker () from /lib64/libvirt.so.0
#13 0x00007f8f9574eecb in virThreadHelper () from /lib64/libvirt.so.0
#14 0x00007f8f91a4314a in start_thread () from /lib64/libpthread.so.0
#15 0x00007f8f941f1f23 in clone () from /lib64/libc.so.6
(gdb) bt
#0 0x00007f8f91a492fc in pthread_cond_wait@(a)GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1 0x00007f8f9574ed7a in virCondWait () from /lib64/libvirt.so.0
#2 0x00007f8f95784ef5 in virDomainObjWait () from /lib64/libvirt.so.0
#3 0x00007f8f42257ac8 in qemuBlockStorageSourceCreateGeneric () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#4 0x00007f8f4225b88d in qemuBlockStorageSourceCreate () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#5 0x00007f8f423346ee in qemuSnapshotDiskPrepareOne () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#6 0x00007f8f423353f8 in qemuSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#7 0x00007f8f422b6ac1 in qemuDomainSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
#8 0x00007f8f9591f604 in virDomainSnapshotCreateXML () from /lib64/libvirt.so.0
#9 0x0000562390841b81 in remoteDispatchDomainSnapshotCreateXMLHelper ()
#10 0x00007f8f9580e807 in virNetServerProgramDispatch () from /lib64/libvirt.so.0
#11 0x00007f8f95813b26 in virNetServerHandleJob () from /lib64/libvirt.so.0
#12 0x00007f8f9574f85f in virThreadPoolWorker () from /lib64/libvirt.so.0
#13 0x00007f8f9574eecb in virThreadHelper () from /lib64/libvirt.so.0
#14 0x00007f8f91a4314a in start_thread () from /lib64/libpthread.so.0
#15 0x00007f8f941f1f23 in clone () from /lib64/libc.so.6
(gdb)
The call work flow one is:
qemuSnapshotCreateActiveExternal -> qemuSaveImageCreate -> qemuMigrationSrcToFile -> qemuMigrationSrcWaitForCompletion -> virDomainObjWait
The others is similar :
qemuSnapshotCreateXML －＞ ．．．
It may be resume after the restart libvirtd.service.
Is it correct that the stat change lock should be unlocked while the vm is terminal or shutdown and how to fix it?
Thanks!
13520781732(a)189.cn
3 years, 6 months
[PATCH] tests: qemu: Don't crash when capability file can't be parsed
by Peter Krempa
In case the test directory contains invalid XML (this doesn't happen
upstream, but can when developing, e.g. by forgetting git conflict
markers) the tests would crash as in case when 'testQemuInfoSetArgs'
fails we'd still invoke the test in qemuxml2argv and qemuxml2xml tests.
Add a 'break' statement to avoid invocation of the test and add a debug
message.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
tests/qemuxml2argvtest.c | 4 +++-
tests/qemuxml2xmltest.c | 1 +
tests/testutilsqemu.c | 4 +++-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index b552f5deed..3f43e76842 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -943,8 +943,10 @@ mymain(void)
}; \
info.qapiSchemaCache = qapiSchemaCache; \
if (testQemuInfoSetArgs(&info, capscache, capslatest, \
- __VA_ARGS__, ARG_END) < 0) \
+ __VA_ARGS__, ARG_END) < 0) { \
ret = -1; \
+ break; \
+ } \
testInfoSetPaths(&info, _suffix); \
if (virTestRun("QEMU XML-2-ARGV " _name _suffix, \
testCompareXMLToArgv, &info) < 0) \
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 9652d2a7ce..3b453f9746 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -157,6 +157,7 @@ mymain(void)
qemuTestCapsCacheInsert(driver.qemuCapsCache, info.qemuCaps) < 0) { \
VIR_TEST_DEBUG("Failed to generate test data for '%s'", _name); \
ret = -1; \
+ break; \
} \
\
if (when & WHEN_INACTIVE) { \
diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index 9a0666724a..f166eaf502 100644
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -785,8 +785,10 @@ testQemuInfoSetArgs(struct testQemuInfo *info,
}
if (!g_hash_table_lookup_extended(capscache, capsfile, NULL, (void **) &cachedcaps)) {
- if (!(qemuCaps = qemuTestParseCapabilitiesArch(info->arch, capsfile)))
+ if (!(qemuCaps = qemuTestParseCapabilitiesArch(info->arch, capsfile))) {
+ VIR_TEST_VERBOSE("failed to parse capabilities file '%s'", capsfile);
goto cleanup;
+ }
cachedcaps = qemuCaps;
--
2.31.1
3 years, 6 months
[libvirt PATCH] util: Fix memory leak when clearing Open vSwitch QoS
by Jiri Denemark
No need to overwrite vmid_ex_id with a pointer to another copy of the
same string when the original is still alive.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
src/util/virnetdevopenvswitch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
index 7a64a8dbe6..f6a8ed4a31 100644
--- a/src/util/virnetdevopenvswitch.c
+++ b/src/util/virnetdevopenvswitch.c
@@ -824,7 +824,6 @@ virNetDevOpenvswitchInterfaceClearQos(const char *ifname,
/* find queue */
virCommandFree(cmd);
cmd = virNetDevOpenvswitchCreateCmd();
- vmid_ex_id = g_strdup_printf("external-ids:vm-id=\"%s\"", vmuuidstr);
virCommandAddArgList(cmd, "--no-heading", "--columns=_uuid", "find", "queue", vmid_ex_id, NULL);
virCommandSetOutputBuffer(cmd, &queue_uuid);
if (virCommandRun(cmd, NULL) < 0) {
--
2.32.0
3 years, 6 months
[PATCH v2] libxl: remove conditionals from discard configuration
by Olaf Hering
LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0
Signed-off-by: Olaf Hering <olaf(a)aepfle.de>
---
src/libxl/libxl_conf.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 56cb9abd5d..9f0739e1fa 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -923,13 +923,12 @@ libxlMakeVnumaList(virDomainDef *def,
return ret;
}
-static int
-libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
+static void
+libxlDiskSetDiscard(libxl_device_disk *x_disk, virDomainDiskDiscard discard)
{
if (!x_disk->readwrite)
- return 0;
-#if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE)
- switch ((virDomainDiskDiscard)discard) {
+ return;
+ switch (discard) {
case VIR_DOMAIN_DISK_DISCARD_DEFAULT:
case VIR_DOMAIN_DISK_DISCARD_LAST:
break;
@@ -940,15 +939,6 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
libxl_defbool_set(&x_disk->discard_enable, false);
break;
}
- return 0;
-#else
- if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT)
- return 0;
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
- _("This version of libxenlight does not support "
- "disk 'discard' option passing"));
- return -1;
-#endif
}
static char *
@@ -1189,8 +1179,7 @@ libxlMakeDisk(virDomainDiskDef *l_disk, libxl_device_disk *x_disk)
x_disk->removable = 1;
x_disk->readwrite = !l_disk->src->readonly;
x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0;
- if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0)
- return -1;
+ libxlDiskSetDiscard(x_disk, l_disk->discard);
/* An empty CDROM must have the empty format, otherwise libxl fails. */
if (x_disk->is_cdrom && !x_disk->pdev_path)
x_disk->format = LIBXL_DISK_FORMAT_EMPTY;
3 years, 7 months
[PATCH v1] libxl: remove conditionals from discard configuration
by Olaf Hering
LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0
Signed-off-by: Olaf Hering <olaf(a)aepfle.de>
---
src/libxl/libxl_conf.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 3de2f9f57a..e275996cab 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -923,13 +923,12 @@ libxlMakeVnumaList(virDomainDef *def,
return ret;
}
-static int
-libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
+static void
+libxlDiskSetDiscard(libxl_device_disk *x_disk, virDomainDiskDiscard discard)
{
if (!x_disk->readwrite)
- return 0;
-#if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE)
- switch ((virDomainDiskDiscard)discard) {
+ return;
+ switch (discard) {
case VIR_DOMAIN_DISK_DISCARD_DEFAULT:
case VIR_DOMAIN_DISK_DISCARD_LAST:
break;
@@ -940,15 +939,6 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
libxl_defbool_set(&x_disk->discard_enable, false);
break;
}
- return 0;
-#else
- if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT)
- return 0;
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
- _("This version of libxenlight does not support "
- "disk 'discard' option passing"));
- return -1;
-#endif
}
static void
@@ -1209,8 +1199,7 @@ libxlMakeDisk(virDomainDiskDef *l_disk, libxl_device_disk *x_disk)
x_disk->removable = 1;
x_disk->readwrite = !l_disk->src->readonly;
x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0;
- if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0)
- return -1;
+ libxlDiskSetDiscard(x_disk, l_disk->discard);
libxlDiskSetScript(x_disk, src);
/* An empty CDROM must have the empty format, otherwise libxl fails. */
3 years, 7 months
