September 2020 - Devel - libvirt List Archives

[PATCH 3/9] Jailhouse driver: Implementation of ConnectGetType
by Prakhar Bansal 06 Sep '20

06 Sep '20

Signed-off-by:Prakhar Bansal<prakharbansal0910(a)gmail.com> --- src/jailhouse/jailhouse_driver.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/jailhouse/jailhouse_driver.c b/src/jailhouse/jailhouse_driver.c index ac9da4c85d..75bf41fc11 100644 --- a/src/jailhouse/jailhouse_driver.c +++ b/src/jailhouse/jailhouse_driver.c @@ -32,8 +32,10 @@ #include "viralloc.h" #include "virfile.h" #include "virlog.h" +#include "virutil.h" #include "vircommand.h" #include "virpidfile.h" +#include "access/viraccessapicheck.h" #define VIR_FROM_THIS VIR_FROM_JAILHOUSE @@ -241,16 +243,19 @@ jailhouseStateInitialize(bool privileged G_GNUC_UNUSED, static const char * jailhouseConnectGetType(virConnectPtr conn) { - UNUSED(conn); - return NULL; + if (virConnectGetTypeEnsureACL(conn) < 0) + return NULL; + return "JAILHOUSE"; } static char * jailhouseConnectGetHostname(virConnectPtr conn) { - UNUSED(conn); - return NULL; + if (virConnectGetHostnameEnsureACL(conn) < 0) + return NULL; + + return virGetHostname(); } static int @@ -263,7 +268,7 @@ jailhouseNodeGetInfo(virConnectPtr conn, virNodeInfoPtr info) static int jailhouseConnectListAllDomains(virConnectPtr conn, - virDomainPtr ** domain, unsigned int flags) + virDomainPtr **domain, unsigned int flags) { UNUSED(conn); UNUSED(domain); @@ -300,7 +305,6 @@ jailhouseDomainCreate(virDomainPtr domain) { UNUSED(domain); return -1; - } static int @@ -350,18 +354,18 @@ static virHypervisorDriver jailhouseHypervisorDriver = { .connectOpen = jailhouseConnectOpen, /* 6.3.0 */ .connectClose = jailhouseConnectClose, /* 6.3.0 */ .connectListAllDomains = jailhouseConnectListAllDomains, /* 6.3.0 */ - .domainLookupByID = jailhouseDomainLookupByID, /* 6.3.0 */ - .domainLookupByUUID = jailhouseDomainLookupByUUID, /* 6.3.0 */ - .domainLookupByName = jailhouseDomainLookupByName, /* 6.3.0 */ - .domainGetXMLDesc = jailhouseDomainGetXMLDesc, /* 6.3.0 */ - .domainCreate = jailhouseDomainCreate, /* 6.3.0 */ .connectGetType = jailhouseConnectGetType, /* 6.3.0 */ .connectGetHostname = jailhouseConnectGetHostname, /* 6.3.0 */ - .nodeGetInfo = jailhouseNodeGetInfo, /* 6.3.0 */ + .domainCreate = jailhouseDomainCreate, /* 6.3.0 */ .domainShutdown = jailhouseDomainShutdown, /* 6.3.0 */ .domainDestroy = jailhouseDomainDestroy, /* 6.3.0 */ .domainGetInfo = jailhouseDomainGetInfo, /* 6.3.0 */ .domainGetState = jailhouseDomainGetState, /* 6.3.0 */ + .domainLookupByID = jailhouseDomainLookupByID, /* 6.3.0 */ + .domainLookupByUUID = jailhouseDomainLookupByUUID, /* 6.3.0 */ + .domainLookupByName = jailhouseDomainLookupByName, /* 6.3.0 */ + .domainGetXMLDesc = jailhouseDomainGetXMLDesc, /* 6.3.0 */ + .nodeGetInfo = jailhouseNodeGetInfo, /* 6.3.0 */ }; -- 2.17.1

1 0

[GSoC] Final Project report
by Prathamesh Chavan 05 Sep '20

05 Sep '20

Since GSoC has come to an end, I would like to share with the libvirt-community the work which I was able to do during this time[1]. I would like to thanks the libvirt-community and my mentors for giving me this opportunity, and helping me through this amazing experience. Thanks, Prathamesh Chavan [1]: https://drive.google.com/drive/u/0/folders/19KMJhUUp1WdXGl7slk9hLqXSwK8aG4di

1 0

[PATCH] tools: avoid unused parameter warning when readline is disabled
by Daniel P. Berrangé 05 Sep '20

05 Sep '20

The vshReadlineHistoryAdd stub method does not use its parameter. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed to fix minimal build used by layered repo CI tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index ef2a3f62d7..0e8edcd78c 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2971,7 +2971,7 @@ vshReadline(vshControl *ctl G_GNUC_UNUSED, } void -vshReadlineHistoryAdd(const char *cmd) +vshReadlineHistoryAdd(const char *cmd G_GNUC_UNUSED) { /* empty */ } -- 2.26.2

2 2

[PATCH 0/3] Some random fixes
by Michal Privoznik 05 Sep '20

05 Sep '20

I've tried to run libvirt under valgrind and found two issues. Here are the fixes. Michal Prívozník (3): qemu_interface: Fix @cfg refcounting in qemuInterfacePrepareSlirp() lib: Prefer g_autoptr() declaration of virQEMUDriverConfigPtr qemu_namespace: Don't leak mknod items that are being skipped over src/qemu/qemu_conf.h | 6 +---- src/qemu/qemu_hostdev.c | 4 +-- src/qemu/qemu_interface.c | 11 +++------ src/qemu/qemu_migration.c | 8 ++---- src/qemu/qemu_migration_cookie.c | 4 +-- src/qemu/qemu_namespace.c | 42 +++++++++++++++++++++++--------- tests/domaincapstest.c | 4 +-- tests/qemuxml2xmltest.c | 2 +- 8 files changed, 42 insertions(+), 39 deletions(-) -- 2.26.2

3 7

[libvirt PATCH] cpu_map: Use g_auto* in cpuMapLoad
by Tim Wiederhake 04 Sep '20

04 Sep '20

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/cpu/cpu_map.c | 33 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 913e34a067..cbf90d1395 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -169,12 +169,11 @@ int cpuMapLoad(const char *arch, cpuMapLoadCallback modelCB, void *data) { - xmlDocPtr xml = NULL; - xmlXPathContextPtr ctxt = NULL; + g_autoptr(xmlDoc) xml = NULL; + g_autoptr(xmlXPathContext) ctxt = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - char *xpath = NULL; - int ret = -1; - char *mapfile; + g_autofree char *xpath = NULL; + g_autofree char *mapfile = NULL; if (!(mapfile = virFileFindResource("index.xml", abs_top_srcdir "/src/cpu_map", @@ -186,11 +185,11 @@ int cpuMapLoad(const char *arch, if (arch == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("undefined hardware architecture")); - goto cleanup; + return -1; } if (!(xml = virXMLParseFileCtxt(mapfile, &ctxt))) - goto cleanup; + return -1; virBufferAsprintf(&buf, "./arch[@name='%s']", arch); @@ -201,28 +200,20 @@ int cpuMapLoad(const char *arch, if ((ctxt->node = virXPathNode(xpath, ctxt)) == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, _("cannot find CPU map for %s architecture"), arch); - goto cleanup; + return -1; } if (loadData(mapfile, ctxt, "vendor", vendorCB, data) < 0) - goto cleanup; + return -1; if (loadData(mapfile, ctxt, "feature", featureCB, data) < 0) - goto cleanup; + return -1; if (loadData(mapfile, ctxt, "model", modelCB, data) < 0) - goto cleanup; + return -1; if (loadIncludes(ctxt, vendorCB, featureCB, modelCB, data) < 0) - goto cleanup; - - ret = 0; - - cleanup: - xmlXPathFreeContext(ctxt); - xmlFreeDoc(xml); - VIR_FREE(xpath); - VIR_FREE(mapfile); + return -1; - return ret; + return 0; } -- 2.26.2

2 1

[libvirt PATCH] Add FreeBSD 11.4 CI job on Cirrus
by Daniel P. Berrangé 04 Sep '20

04 Sep '20

The previous 11.3 image provided by Cirrus did not boot, but they have now provided a working 11.4 image Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NB, as expected this CI job fails due to the bug that Roman identified here: https://www.redhat.com/archives/libvir-list/2020-September/msg00151.html .gitlab-ci.yml | 9 +++++++++ ci/cirrus/libvirt-freebsd-11.vars | 9 +++++++++ 2 files changed, 18 insertions(+) create mode 100644 ci/cirrus/libvirt-freebsd-11.vars diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4a42eb479f..ee404bf50a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -383,6 +383,15 @@ x64-ubuntu-2004: variables: NAME: ubuntu-2004 +x64-freebsd-11-build: + <<: *cirrus_build_job_definition + variables: + NAME: freebsd-11 + CIRRUS_VM_INSTANCE_TYPE: freebsd_instance + CIRRUS_VM_IMAGE_SELECTOR: image_family + CIRRUS_VM_IMAGE_NAME: freebsd-11-4 + INSTALL_COMMAND: pkg install -y + x64-freebsd-12-build: <<: *cirrus_build_job_definition variables: diff --git a/ci/cirrus/libvirt-freebsd-11.vars b/ci/cirrus/libvirt-freebsd-11.vars new file mode 100644 index 0000000000..7c29c6f899 --- /dev/null +++ b/ci/cirrus/libvirt-freebsd-11.vars @@ -0,0 +1,9 @@ +PACKAGING_COMMAND='pkg' +CC='/usr/bin/clang' +CCACHE='/usr/local/bin/ccache' +MAKE='/usr/local/bin/gmake' +NINJA='/usr/local/bin/ninja' +PYTHON='/usr/local/bin/python3' +PIP='/usr/local/bin/pip-3.7' +PKGS='augeas autoconf automake avahi bash bash-completion ca_root_nss ccache chrony cppi curl cyrus-sasl dbus diskscrub dnsmasq fusefs-libs gdb gettext gettext-tools git glib gmake gnutls hal libpcap libpciaccess libssh libssh2 libtool libxml2 libxslt lsof ncurses ninja p5-App-cpanminus patch perl5 pkgconf polkit py37-docutils py37-flake8 py37-pip py37-setuptools py37-wheel python3 qemu-utils radvd readline screen sudo vim yajl' +PYPI_PKGS='meson==0.54.0' -- 2.26.2

2 1

[PATCH] util: re-add conditional for ifi_iqdrops field for macOS
by Daniel P. Berrangé 04 Sep '20

04 Sep '20

The conditional was removed in commit ebbf8ebe4fa6f9d43b40673f0f2dad6bf50e2085 Author: Ján Tomko <jtomko(a)redhat.com> Date: Tue Sep 1 22:56:37 2020 +0200 util: virnetdevtap: stats: fix txdrop on FreeBSD That commit was correct about this no longer being required for FreeBSD, but missed that the code is also built on macOS. Rather than testing for this field in meson though, we can simply use a platform conditional test in the code. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed to fix macOS CI build jobs src/util/virnetdevtap.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index cc6f254aa1..ab5959c646 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -974,12 +974,20 @@ virNetDevTapInterfaceStats(const char *ifname, stats->rx_bytes = ifd->ifi_obytes; stats->rx_packets = ifd->ifi_opackets; stats->rx_errs = ifd->ifi_oerrors; +# ifndef __APPLE__ stats->rx_drop = ifd->ifi_oqdrops; +# else + stats->rx_drop = 0; +# endif } else { stats->tx_bytes = ifd->ifi_obytes; stats->tx_packets = ifd->ifi_opackets; stats->tx_errs = ifd->ifi_oerrors; +# ifndef __APPLE__ stats->tx_drop = ifd->ifi_oqdrops; +# else + stats->tx_drop = 0; +# endif stats->rx_bytes = ifd->ifi_ibytes; stats->rx_packets = ifd->ifi_ipackets; stats->rx_errs = ifd->ifi_ierrors; -- 2.26.2

2 1

[PATCH] tests: add FreeBSD dependencies
by Roman Bogorodskiy 04 Sep '20

04 Sep '20

Add some FreeBSD-specific libraries (-lutil, -lkvm) to tests dependencies. Without that, FreeBSD 11.x, which uses the GNU ld, fails to link tests. Interestingly, newer FreeBSD versions that use LLVM ld tolerate this behaviour and builds successfully as is. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- tests/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/meson.build b/tests/meson.build index ad13e2de60..ea2458efbc 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -10,11 +10,13 @@ tests_dep = declare_dependency( dlopen_dep, glib_dep, gnutls_dep, + kvm_dep, libnl_dep, libxml_dep, rpc_dep, sasl_dep, selinux_dep, + util_dep, xdr_dep, yajl_dep, ], -- 2.27.0

3 8

[libvirt PATCH] ci: Disable verbose mode for cirrus-run
by Andrea Bolognani 04 Sep '20

04 Sep '20

It was temporarily enabled to help the upstream author validate some changes, but now that 0.3.0 is out we can safely disable it again. This reverts commit 9b5622d31f8c3036425721ab9c6b23067aa87034. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4a42eb479f..bd42c95602 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -104,7 +104,7 @@ stages: -e "s|[@]PYPI_PKGS@|$PYPI_PKGS|g" <ci/cirrus/build.yml >ci/cirrus/$NAME.yml - cat ci/cirrus/$NAME.yml - - cirrus-run -v --show-build-log always ci/cirrus/$NAME.yml + - cirrus-run --show-build-log always ci/cirrus/$NAME.yml only: variables: - $CIRRUS_GITHUB_REPO -- 2.26.2

2 2

[libvirt PATCH v2 0/3] Add support for vDPA network devices
by Jonathon Jongsma 04 Sep '20

04 Sep '20

vDPA network devices allow high-performance networking in a virtual machine by providing a wire-speed data path. These devices require a vendor-specific host driver but the data path follows the virtio specification. The support for vDPA devices was recently added to qemu. This allows libvirt to support these devices. It requires that the device is configured on the host with the appropriate vendor-specific driver. This will create a chardev on the host at e.g. /dev/vhost-vdpa-0. That chardev path can then be used to define a new interface with type='vdpa'. Changes in v2: - split patches - add qemu capability - disallow migration for vdpa devices Jonathon Jongsma (3): conf: Add support for vDPA network devices qemu: add vhost-vdpa capability qemu: add vdpa support docs/formatdomain.rst | 23 ++++++++++++ docs/schemas/domaincommon.rng | 15 ++++++++ src/conf/domain_conf.c | 32 ++++++++++++++++ src/conf/domain_conf.h | 4 ++ src/conf/netdev_bandwidth_conf.c | 1 + src/libxl/libxl_conf.c | 1 + src/libxl/xen_common.c | 1 + src/lxc/lxc_controller.c | 1 + src/lxc/lxc_driver.c | 3 ++ src/lxc/lxc_process.c | 1 + src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 3 ++ src/qemu/qemu_command.c | 29 ++++++++++++++- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_domain.c | 10 ++++- src/qemu/qemu_hotplug.c | 15 +++++--- src/qemu/qemu_interface.c | 25 +++++++++++++ src/qemu/qemu_interface.h | 2 + src/qemu/qemu_migration.c | 10 ++++- src/qemu/qemu_process.c | 1 + src/qemu/qemu_validate.c | 1 + src/vmx/vmx.c | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../net-vdpa.x86_64-latest.args | 37 +++++++++++++++++++ tests/qemuxml2argvdata/net-vdpa.xml | 28 ++++++++++++++ tests/qemuxml2argvmock.c | 11 +++++- tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/net-vdpa.xml | 33 +++++++++++++++++ tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 1 + 30 files changed, 288 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/net-vdpa.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-vdpa.xml create mode 100644 tests/qemuxml2xmloutdata/net-vdpa.xml -- 2.26.2

3 7