June 2020 - Devel - libvirt List Archives

[PATCH 00/13] Allow HMAT configuration
by Michal Privoznik 08 Jul '20

08 Jul '20

Heterogeneous Memory Attribute Table describes links between NUMA nodes (what's the bandwidth and/or latency between two nodes and/or their side caches). This enables guests to fine tune their performance. Michal Prívozník (13): qemuxml2xmltest: Add "numatune-distance" test case conf: Move and rename virDomainParseScaledValue() numa_conf: Drop CPU from name of two functions qemu_command: Rename qemuBuildNumaArgStr() qemuBuildMachineCommandLine: Drop needless check numa_conf: Make virDomainNumaSetNodeCpumask() return void Allow NUMA nodes without vCPUs conf: Parse and format HMAT conf: Validate NUMA HMAT configuration numa: expose HMAT APIs qemu: Introduce QEMU_CAPS_NUMA_HMAT capability qemu: Build HMAT command line news: Document HMAT addition NEWS.rst | 5 + docs/formatdomain.html.in | 90 +++ docs/schemas/cputypes.rng | 118 +++- src/conf/cpu_conf.c | 2 +- src/conf/domain_conf.c | 140 +--- src/conf/numa_conf.c | 664 ++++++++++++++++-- src/conf/numa_conf.h | 72 +- src/libvirt_private.syms | 13 + src/libxl/xen_xl.c | 14 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 226 +++++- src/qemu/qemu_validate.c | 22 +- src/util/virxml.c | 72 ++ src/util/virxml.h | 8 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../numatune-hmat.x86_64-latest.args | 53 ++ tests/qemuxml2argvdata/numatune-hmat.xml | 52 ++ tests/qemuxml2argvdata/numatune-no-vcpu.args | 33 + tests/qemuxml2argvdata/numatune-no-vcpu.xml | 42 ++ tests/qemuxml2argvtest.c | 2 + .../qemuxml2xmloutdata/numatune-distances.xml | 96 +++ tests/qemuxml2xmloutdata/numatune-hmat.xml | 1 + tests/qemuxml2xmloutdata/numatune-no-vcpu.xml | 1 + tests/qemuxml2xmltest.c | 3 + 29 files changed, 1536 insertions(+), 201 deletions(-) create mode 100644 tests/qemuxml2argvdata/numatune-hmat.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numatune-hmat.xml create mode 100644 tests/qemuxml2argvdata/numatune-no-vcpu.args create mode 100644 tests/qemuxml2argvdata/numatune-no-vcpu.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-distances.xml create mode 120000 tests/qemuxml2xmloutdata/numatune-hmat.xml create mode 120000 tests/qemuxml2xmloutdata/numatune-no-vcpu.xml -- 2.26.2

3 31

Entering freeze for libvirt-6.5.0
by Daniel Veillard 01 Jul '20

01 Jul '20

With the end of the month coming next week, it is better to enter freeze today and try to release before the July 4th long week-end in the US. I have just pushed the signed tarball and source rpm to the usual place https://libvirt.org/sources/ Seems to work fine in my very minimal tests, I hope people can do a bit of testing especially on other OSes and distro. If all goes fine I will push rc2 on Tuesday with hopefully a release of 6.5.0 on Thursday. Please give it some testing, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 3

[libvirt PATCH v3 0/1] cirrus: Add templates and refresh script
by Andrea Bolognani 01 Jul '20

01 Jul '20

This makes the Cirrus CI configurations as maintainable as the Dockerfiles, by shifting the responsability of keeping the list of dependencies and other details up to date to lcitool. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/161289292 For the refresh script to work, your copy of lcitool needs to include these patches: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/30 Changes from [v2]: * 'lcitool dockerfile --variables' has been replaced with 'lcitool variables'. Changes from [v1]: * reduce duplication by only storing variables in the git repository and instantiating the template at runtime. [v2] https://www.redhat.com/archives/libvir-list/2020-June/msg01318.html [v1] https://www.redhat.com/archives/libvir-list/2020-June/msg01305.html Andrea Bolognani (1): cirrus: Generate jobs dynamically .gitlab-ci.yml | 36 ++++++++++++++- ci/cirrus/build.yml | 26 +++++++++++ ci/cirrus/freebsd-12.yml.j2 | 73 ------------------------------- ci/cirrus/libvirt-freebsd-12.vars | 7 +++ ci/cirrus/libvirt-macos-1015.vars | 7 +++ ci/cirrus/macos-1015.yml.j2 | 38 ---------------- ci/cirrus/refresh | 22 ++++++++++ 7 files changed, 97 insertions(+), 112 deletions(-) create mode 100644 ci/cirrus/build.yml delete mode 100644 ci/cirrus/freebsd-12.yml.j2 create mode 100644 ci/cirrus/libvirt-freebsd-12.vars create mode 100644 ci/cirrus/libvirt-macos-1015.vars delete mode 100644 ci/cirrus/macos-1015.yml.j2 create mode 100755 ci/cirrus/refresh -- 2.25.4

2 2

[PATCH 1/1] migration.html.in: fix 'Offline migration' description
by Daniel Henrique Barboza 01 Jul '20

01 Jul '20

'transfers inactive the definition of a domain' seems odd. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/migration.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migration.html.in b/docs/migration.html.in index 355f0e89af..e95ee9de6f 100644 --- a/docs/migration.html.in +++ b/docs/migration.html.in @@ -141,7 +141,7 @@ <h2><a id="offline">Offline migration</a></h2> <p> - Offline migration transfers inactive the definition of a domain + Offline migration transfers the inactive definition of a domain (which may or may not be active). After successful completion, the domain remains in its current state on the source host and is defined but inactive on the destination host. It's a bit more clever than -- 2.26.2

2 1

[PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present
by Daniel Henrique Barboza 01 Jul '20

01 Jul '20

Commit 076591009ad1 ("conf: fix zPCI address auto-generation on s390") is doing a check for virZPCIDeviceAddressIsIncomplete() prior to checking if the device has a ZPCI address at all. This results in errors like these when starting Libvirt: error : virDomainDeviceInfoFormat:7527 : internal error: Missing uid or fid attribute of zPCI address Fix it by moving virZPCIDeviceAddressIsIncomplete() after the check done by virZPCIDeviceAddressIsPresent(). Fixes: 076591009ad11ec108521b52a4945d0f895fa160 CC: Bjoern Walk <bwalk(a)linux.ibm.com> CC: Boris Fiuczynski <fiuczy(a)linux.ibm.com> CC: Shalini Chellathurai Saroja <shalini(a)linux.ibm.com> CC: Andrea Bolognani <abologna(a)redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/conf/domain_conf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 31ba78b950..33f177b16f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7522,11 +7522,11 @@ virDomainDeviceInfoFormat(virBufferPtr buf, virTristateSwitchTypeToString(info->addr.pci.multi)); } - if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci)) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Missing uid or fid attribute of zPCI address")); - } if (virZPCIDeviceAddressIsPresent(&info->addr.pci.zpci)) { + if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci)) + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Missing uid or fid attribute of zPCI address")); + virBufferAsprintf(&childBuf, "<zpci uid='0x%.4x' fid='0x%.8x'/>\n", info->addr.pci.zpci.uid.value, -- 2.26.2

3 8

[libvirt PATCH v2 0/1] cirrus: Add templates and refresh script
by Andrea Bolognani 30 Jun '20

30 Jun '20

This makes the Cirrus CI configurations as maintainable as the Dockerfiles, by shifting the responsability of keeping the list of dependencies and other details up to date to lcitool. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/161289292 For the refresh script to work, your copy of lcitool needs to include these patches: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/30 Changes from [v1]: * reduce duplication by only storing variables in the git repository and instantiating the template at runtime. [v1] https://www.redhat.com/archives/libvir-list/2020-June/msg01305.html Andrea Bolognani (1): cirrus: Generate jobs dynamically .gitlab-ci.yml | 36 ++++++++++++++- ci/cirrus/build.yml | 26 +++++++++++ ci/cirrus/freebsd-12.yml.j2 | 73 ------------------------------- ci/cirrus/libvirt-freebsd-12.vars | 7 +++ ci/cirrus/libvirt-macos-1015.vars | 7 +++ ci/cirrus/macos-1015.yml.j2 | 38 ---------------- ci/cirrus/refresh | 22 ++++++++++ 7 files changed, 97 insertions(+), 112 deletions(-) create mode 100644 ci/cirrus/build.yml delete mode 100644 ci/cirrus/freebsd-12.yml.j2 create mode 100644 ci/cirrus/libvirt-freebsd-12.vars create mode 100644 ci/cirrus/libvirt-macos-1015.vars delete mode 100644 ci/cirrus/macos-1015.yml.j2 create mode 100755 ci/cirrus/refresh -- 2.25.4

2 3

[libvirt PATCH] tools: fix misleading comments about command names
by Daniel P. Berrangé 30 Jun '20

30 Jun '20

The srv-XXX commands were renamed to server-XXX, with the old name being a undocumented back compat alias only. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- tools/virt-admin.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 6ff9729f66..fef0332a0d 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -315,9 +315,9 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd) } -/* --------------- - * Command srv-list - * --------------- +/* ------------------- + * Command server-list + * ------------------- */ static const vshCmdInfo info_srv_list[] = { @@ -380,9 +380,9 @@ cmdSrvList(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED) } -/* --------------------------- - * Command srv-threadpool-info - * --------------------------- +/* ------------------------------ + * Command server-threadpool-info + * ------------------------------ */ static const vshCmdInfo info_srv_threadpool_info[] = { @@ -441,9 +441,9 @@ cmdSrvThreadpoolInfo(vshControl *ctl, const vshCmd *cmd) return ret; } -/* -------------------------- - * Command srv-threadpool-set - * -------------------------- +/* ----------------------------- + * Command server-threadpool-set + * ----------------------------- */ static const vshCmdInfo info_srv_threadpool_set[] = { @@ -550,9 +550,9 @@ cmdSrvThreadpoolSet(vshControl *ctl, const vshCmd *cmd) goto cleanup; } -/* ------------------------ - * Command srv-clients-list - * ------------------------ +/* --------------------------- + * Command server-clients-list + * --------------------------- */ static const vshCmdInfo info_srv_clients_list[] = { @@ -793,9 +793,9 @@ cmdClientDisconnect(vshControl *ctl, const vshCmd *cmd) return ret; } -/* ------------------------ - * Command srv-clients-info - * ------------------------ +/* --------------------------- + * Command server-clients-info + * --------------------------- */ static const vshCmdInfo info_srv_clients_info[] = { @@ -852,9 +852,9 @@ cmdSrvClientsInfo(vshControl *ctl, const vshCmd *cmd) return ret; } -/* ----------------------- - * Command srv-clients-set - * ----------------------- +/* -------------------------- + * Command server-clients-set + * -------------------------- */ static const vshCmdInfo info_srv_clients_set[] = { @@ -957,9 +957,9 @@ cmdSrvClientsSet(vshControl *ctl, const vshCmd *cmd) goto cleanup; } -/* ------------------------ - * Command srv-update-tls - * ------------------------ +/* -------------------------- + * Command server-update-tls + * -------------------------- */ static const vshCmdInfo info_srv_update_tls_file[] = { {.name = "help", -- 2.26.2

2 1

[libvirt PATCH 0/3] cirrus: Add templates and refresh script
by Andrea Bolognani 29 Jun '20

29 Jun '20

This makes the Cirrus CI configurations as maintainable as the Dockerfiles, by shifting the responsability of keeping the list of dependencies and other details up to date to lcitool. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/161179474 The important job is the macOS one. For the refresh script to work, your copy of lcitool needs to include these patches: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/30 https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/31 Andrea Bolognani (3): cirrus: Tweak configurations cirrus: Add templates and refresh script cirrus: Refresh configurations ci/cirrus/freebsd-12.yml.j2 | 62 ++++-------------------------- ci/cirrus/macos-1015.yml.j2 | 29 +++++--------- ci/cirrus/refresh | 32 +++++++++++++++ ci/cirrus/templates/freebsd-12.yml | 25 ++++++++++++ ci/cirrus/templates/macos-1015.yml | 27 +++++++++++++ 5 files changed, 100 insertions(+), 75 deletions(-) create mode 100755 ci/cirrus/refresh create mode 100644 ci/cirrus/templates/freebsd-12.yml create mode 100644 ci/cirrus/templates/macos-1015.yml -- 2.25.4

3 9

[PATCH] virConnectGetAllDomainStats: Document two vcpu stats
by Michal Privoznik 29 Jun '20

29 Jun '20

When introducing vcpu.<num>.wait (v1.3.2-rc1~301) and vcpu.<num>.halted (v2.4.0-rc1~36) the documentation was not written. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt-domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 60b5e65fc3..52ce3ef798 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11493,6 +11493,11 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * from virVcpuState enum. * "vcpu.<num>.time" - virtual cpu time spent by virtual CPU <num> * as unsigned long long. + * "vcpu.<num>.wait" - time the vCPU <num> wants to run, but the host + * scheduler has something else running ahead of it. + * "vcpu.<num>.halted" - virtual CPU <num> is halted, may indicate the + * processor is idle or even disabled, depending + * on the architecture) * * VIR_DOMAIN_STATS_INTERFACE: * Return network interface statistics (from domain point of view). -- 2.26.2

2 1

[PATCH v2 for 6.5.0] domain_conf: Remove zPCI validation from formatter
by Michal Privoznik 29 Jun '20

29 Jun '20

In 076591009ad a validation code was added to virDomainDeviceInfoFormat() which reports an error if zPCI address entered in was incomplete. But, there are two problems with this approach. The first problem is the placement of the code - it doesn't belong into XML formatter rather than XML validator. The second one is that at the point of formatting XML the post parse callback has run and thus filled in required info. Therefore this check can never do something useful and instead of moving it into validator, it's removed completely. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- This is v2 of: https://www.redhat.com/archives/libvir-list/2020-June/msg01279.html diff to v1: - Instead of moving the check to validator remove it completely (per discussion in v1) src/conf/domain_conf.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 33f177b16f..0c883cd834 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7523,10 +7523,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf, } if (virZPCIDeviceAddressIsPresent(&info->addr.pci.zpci)) { - if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci)) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Missing uid or fid attribute of zPCI address")); - virBufferAsprintf(&childBuf, "<zpci uid='0x%.4x' fid='0x%.8x'/>\n", info->addr.pci.zpci.uid.value, -- 2.26.2

2 1