March 2020 - Devel - libvirt List Archives

[PATCH 0/2] Two trivial syntax-check fixes
by Michal Privoznik 27 Mar '20

27 Mar '20

While reviewing patches [1] I've found two problems with syntax-check which are trivial to fix. These are the patches I've pushed. 1: https://www.redhat.com/archives/libvir-list/2020-March/msg01124.html Michal Prívozník (2): syntax-check: Disallow plain fork() in src/libvirt.c syntax-check.mk: Drop needless _src2 variable build-aux/syntax-check.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.24.1

2 4

[PATCH 0/4] Introduce shared daemon startup code
by Rafael Fonseca 27 Mar '20

27 Mar '20

Libvirt ships several daemons (libvirtd, virtlogd, virtlockd) that all have similar code around general daemon startup. Right now the code is duplicated for each daemon, but it could be shared, like in a new file src/util/virdaemon.c. Rafael Fonseca (4): util: introduce shared daemon startup code locking: use shared daemon startup code logging: use shared daemon startup code remote: use shared daemon startup code src/libvirt_private.syms | 6 + src/locking/lock_daemon.c | 251 ++++------------------------------- src/logging/log_daemon.c | 239 ++++----------------------------- src/remote/remote_daemon.c | 263 +++---------------------------------- src/util/Makefile.inc.am | 2 + src/util/virdaemon.c | 255 +++++++++++++++++++++++++++++++++++ src/util/virdaemon.h | 74 +++++++++++ 7 files changed, 410 insertions(+), 680 deletions(-) create mode 100644 src/util/virdaemon.c create mode 100644 src/util/virdaemon.h -- 2.25.1

2 6

[libvirt PATCH] scripts: avoid error in DCO check on empty branches
by Daniel P. Berrangé 27 Mar '20

27 Mar '20

If the DCO check is run on an empty branch (ie one which has no commits different from master), it throws an error due to trying to interpret the empty string as a git commit SHA. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/require-dco.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/require-dco.py b/scripts/require-dco.py index 9fe13823a9..ae94393319 100755 --- a/scripts/require-dco.py +++ b/scripts/require-dco.py @@ -46,7 +46,10 @@ print("\nChecking for 'Signed-off-by: NAME <EMAIL>' on all commits since %s...\n log = subprocess.check_output(["git", "log", "--format=%H %s", ancestor + "..."], universal_newlines=True) -commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")] +if log == "": + commits = [] +else: + commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")] for sha, subject in commits: -- 2.24.1

2 1

[libvirt PATCH] gitlab: don't run the DCO check on git master
by Daniel P. Berrangé 27 Mar '20

27 Mar '20

The "only: branches" does not in fact exclude "master", so it must be excluded explicitly. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix since the DCO check fails on master .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d8b316d618..1e3675ace0 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -228,3 +228,4 @@ dco: - branches except: - /^v.*-maint$/ + - master -- 2.24.1

1 0

[PATCH 1/1] qemu_domain.c: remove unneeded size check in NVDIMM alignment
by Daniel Henrique Barboza 27 Mar '20

27 Mar '20

Commit 5540acb9a2b added a minimum size verification for the target size of ppc64 NVDIMMs but forgot to remove a MAX() size check that was being used in earlier reviews of that commit. The size verification makes this check unneeded since we're making sure that guestArea will always be at least equal to ppc64AlignSize. Fixes: 5540acb9a2bd33fb97a7446a610b602c9e8629a3 Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/qemu/qemu_domain.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2c9fb47d17..2c52778515 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -12639,8 +12639,6 @@ qemuDomainNVDimmAlignSizePseries(virDomainDefPtr def, } guestArea = (guestArea/ppc64AlignSize) * ppc64AlignSize; - guestArea = MAX(guestArea, ppc64AlignSize); - mem->size = guestArea + mem->labelsize; return 0; -- 2.25.1

2 1

[PATCH 0/2] Accept http cookies with quoted value
by Peter Krempa 27 Mar '20

27 Mar '20

The validator didn't accept the quoted version of the cookie value. Add a test and fix the issue. Peter Krempa (2): qemuxml2xmltest: Wire up 'disk-network-http' case virStorageSourceNetCookieValidate: Accept quoted cookie value docs/schemas/domaincommon.rng | 2 +- src/util/virstoragefile.c | 19 ++++- .../disk-network-http.x86_64-latest.args | 4 +- tests/qemuxml2argvdata/disk-network-http.xml | 4 +- .../disk-network-http.x86_64-latest.xml | 71 +++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 6 files changed, 96 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml -- 2.24.1

2 3

[PATCHv2 1/1] qemu_agent.c: Use g_autofree in qemu_agent.c
by Seeteena Thoufeek 27 Mar '20

27 Mar '20

This is the only instance of g_autofree change applicable for qemu_agent.c Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/qemu/qemu_agent.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 95a7d9b..d7fcc86 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -332,9 +332,8 @@ static int qemuAgentIOProcessData(qemuAgentPtr agent, size_t i = 0; #if DEBUG_IO # if DEBUG_RAW_IO - char *str1 = qemuAgentEscapeNonPrintable(data); + g_autofree char *str1 = qemuAgentEscapeNonPrintable(data); VIR_ERROR(_("[%s]"), str1); - VIR_FREE(str1); # else VIR_DEBUG("Data %zu bytes [%s]", len, data); # endif @@ -377,12 +376,10 @@ qemuAgentIOProcess(qemuAgentPtr agent) #if DEBUG_IO # if DEBUG_RAW_IO - char *str1 = qemuAgentEscapeNonPrintable(msg ? msg->txBuffer : ""); - char *str2 = qemuAgentEscapeNonPrintable(agent->buffer); + g_autofree char *str1 = qemuAgentEscapeNonPrintable(msg ? msg->txBuffer : ""); + g_autofree char *str2 = qemuAgentEscapeNonPrintable(agent->buffer); VIR_ERROR(_("Process %zu %p %p [[[%s]]][[[%s]]]"), agent->bufferOffset, agent->msg, msg, str1, str2); - VIR_FREE(str1); - VIR_FREE(str2); # else VIR_DEBUG("Process %zu", agent->bufferOffset); # endif @@ -1083,7 +1080,7 @@ qemuAgentCommandFull(qemuAgentPtr agent, { int ret = -1; qemuAgentMessage msg; - char *cmdstr = NULL; + g_autofree char *cmdstr = NULL; int await_event = agent->await_event; *reply = NULL; @@ -1133,7 +1130,6 @@ qemuAgentCommandFull(qemuAgentPtr agent, ret = qemuAgentCheckError(cmd, *reply, report_unsupported); cleanup: - VIR_FREE(cmdstr); VIR_FREE(msg.txBuffer); agent->await_event = QEMU_AGENT_EVENT_NONE; -- 1.8.3.1

2 2

[PATCH 0/5] Introduce getHost support for ARM cpus
by Zhenyu Zheng 27 Mar '20

27 Mar '20

Introduce getHost support for ARM cpus. First add some common ARM server models to cpu_map, then add some helper methods to parse and load them. The 'lscpu' command from 'util-linux' provides very good data for cpu information, we can parse them directly. Signed-of-by: Zhenyu Zheng <zhengzhenyulixi(a)gmail.com> Zhenyu Zheng (5): cpu_map: Introduce arm CPU models cpu: Introduce virCPUarmData to virCPUData cpu: Introduce arm related structs cpu: Add helper functions to parse vendor and model for ARM cpu: Introduce getHost supoort for ARM src/cpu/cpu.h | 2 + src/cpu/cpu_arm.c | 412 +++++++++++++++++++++++++++++- src/cpu/cpu_arm_data.h | 32 +++ src/cpu_map/Makefile.inc.am | 7 + src/cpu_map/arm_Falkor.xml | 15 ++ src/cpu_map/arm_Kunpeng-920.xml | 23 ++ src/cpu_map/arm_ThunderX299xx.xml | 15 ++ src/cpu_map/arm_cortex-a53.xml | 15 ++ src/cpu_map/arm_cortex-a57.xml | 14 + src/cpu_map/arm_cortex-a72.xml | 14 + src/cpu_map/arm_vendors.xml | 14 + src/cpu_map/index.xml | 16 ++ 12 files changed, 577 insertions(+), 2 deletions(-) create mode 100644 src/cpu/cpu_arm_data.h create mode 100644 src/cpu_map/arm_Falkor.xml create mode 100644 src/cpu_map/arm_Kunpeng-920.xml create mode 100644 src/cpu_map/arm_ThunderX299xx.xml create mode 100644 src/cpu_map/arm_cortex-a53.xml create mode 100644 src/cpu_map/arm_cortex-a57.xml create mode 100644 src/cpu_map/arm_cortex-a72.xml create mode 100644 src/cpu_map/arm_vendors.xml -- 2.26.0.windows.1

1 1

[PATCH 0/5] Introduce getHost support for ARM cpus
by Zhenyu Zheng 27 Mar '20

27 Mar '20

Introduce getHost support for ARM cpus. First add some common ARM server models to cpu_map, then add some helper methods to parse and load them. The 'lscpu' command from 'util-linux' provides very good data for cpu information, we can parse them directly. Zhenyu Zheng (5): cpu_map: Introduce arm CPU models cpu: Introduce virCPUarmData to virCPUData cpu: Introduce arm related structs cpu: Add helper functions to parse vendor and model for ARM cpu: Introduce getHost supoort for ARM src/cpu/cpu.h | 2 + src/cpu/cpu_arm.c | 412 +++++++++++++++++++++++++++++- src/cpu/cpu_arm_data.h | 32 +++ src/cpu_map/Makefile.inc.am | 7 + src/cpu_map/arm_Falkor.xml | 15 ++ src/cpu_map/arm_Kunpeng-920.xml | 23 ++ src/cpu_map/arm_ThunderX299xx.xml | 15 ++ src/cpu_map/arm_cortex-a53.xml | 15 ++ src/cpu_map/arm_cortex-a57.xml | 14 + src/cpu_map/arm_cortex-a72.xml | 14 + src/cpu_map/arm_vendors.xml | 14 + src/cpu_map/index.xml | 16 ++ 12 files changed, 577 insertions(+), 2 deletions(-) create mode 100644 src/cpu/cpu_arm_data.h create mode 100644 src/cpu_map/arm_Falkor.xml create mode 100644 src/cpu_map/arm_Kunpeng-920.xml create mode 100644 src/cpu_map/arm_ThunderX299xx.xml create mode 100644 src/cpu_map/arm_cortex-a53.xml create mode 100644 src/cpu_map/arm_cortex-a57.xml create mode 100644 src/cpu_map/arm_cortex-a72.xml create mode 100644 src/cpu_map/arm_vendors.xml -- 2.26.0.windows.1

1 1

[PATCH 0/5] Introduce getHost support for ARM cpus
by KevinZ 27 Mar '20

27 Mar '20

Introduce getHost support for ARM cpus. First add some common ARM server models to cpu_map, then add some helper methods to parse and load them. The 'lscpu' command from 'util-linux' provides very good data for cpu information, we can parse them directly. Zhenyu Zheng (5):   cpu_map: Introduce arm CPU models   cpu: Introduce virCPUarmData to virCPUData   cpu: Introduce arm related structs   cpu: Add helper functions to parse vendor and model for ARM   cpu: Introduce getHost supoort for ARM  src/cpu/cpu.h                     |   2 +  src/cpu/cpu_arm.c                 | 412 +++++++++++++++++++++++++++++-  src/cpu/cpu_arm_data.h            |  32 +++  src/cpu_map/Makefile.inc.am       |   7 +  src/cpu_map/arm_Falkor.xml        |  15 ++  src/cpu_map/arm_Kunpeng-920.xml   |  23 ++  src/cpu_map/arm_ThunderX299xx.xml |  15 ++  src/cpu_map/arm_cortex-a53.xml    |  15 ++  src/cpu_map/arm_cortex-a57.xml    |  14 +  src/cpu_map/arm_cortex-a72.xml    |  14 +  src/cpu_map/arm_vendors.xml       |  14 +  src/cpu_map/index.xml             |  16 ++  12 files changed, 577 insertions(+), 2 deletions(-)  create mode 100644 src/cpu/cpu_arm_data.h  create mode 100644 src/cpu_map/arm_Falkor.xml  create mode 100644 src/cpu_map/arm_Kunpeng-920.xml  create mode 100644 src/cpu_map/arm_ThunderX299xx.xml  create mode 100644 src/cpu_map/arm_cortex-a53.xml  create mode 100644 src/cpu_map/arm_cortex-a57.xml  create mode 100644 src/cpu_map/arm_cortex-a72.xml  create mode 100644 src/cpu_map/arm_vendors.xml -- 2.26.0.windows.1

1 0