February 2020 - Devel - libvirt List Archives

Re: [PATCH] Add missing files for OpenRC
by Michal Prívozník 22 Feb '20

22 Feb '20

On 2/22/20 4:04 PM, Ryan Moeller wrote: > On Sat, Feb 22, 2020 at 9:24 AM Michal Prívozník <mprivozn(a)redhat.com> wrote: >> >> However, I have done fixes locally. How do you feel about me squashing >> this in and then pushing? >> > > That sounds terrific! Thank you :) > Alright then. Squashed in, and pushed. Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com> Congratulations on your first libvirt contribution! Michal

1 0

[PATCH] Add missing files for OpenRC
by Ryan Moeller 22 Feb '20

22 Feb '20

Signed-off-by: Ryan Moeller <ryan(a)iXsystems.com> --- src/locking/Makefile.inc.am | 7 +++++++ src/locking/virtlockd.init.in | 14 ++++++++++++++ src/logging/Makefile.inc.am | 10 ++++++++++ src/logging/virtlogd.init.in | 14 ++++++++++++++ 4 files changed, 45 insertions(+) create mode 100644 src/locking/virtlockd.init.in create mode 100644 src/logging/virtlogd.init.in diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index e663d7146b..243e3ae767 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -79,6 +79,13 @@ VIRTLOCKD_UNIT_FILES_IN = \ SYSTEMD_UNIT_FILES += $(notdir $(VIRTLOCKD_UNIT_FILES_IN:%.in=%)) SYSTEMD_UNIT_FILES_IN += $(VIRTLOCKD_UNIT_FILES_IN) +OPENRC_INIT_FILES += \ + virtlockd.init \ + $(NULL) +OPENRC_INIT_FILES_IN += \ + virtlockd.init.in \ + $(NULL) + noinst_LTLIBRARIES += libvirt_driver_lock.la libvirt_la_BUILT_LIBADD += libvirt_driver_lock.la diff --git a/src/locking/virtlockd.init.in b/src/locking/virtlockd.init.in new file mode 100644 index 0000000000..45eaed7971 --- /dev/null +++ b/src/locking/virtlockd.init.in @@ -0,0 +1,14 @@ +#!/sbin/openrc-run + +name=virtlogd + +command=@sbindir@/virtlockd +pidfile="@runstatedir@/virtlockd.pid" +command_args="--daemon --pid-file=${pidfile}" +PATH="${PATH}:@sbindir@:@bindir@" +supervisor=supervise-daemon + +depend() { + provide virtlockd + keyword -shutdown +} diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index c4fa49106e..083d8773cb 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -55,6 +55,13 @@ VIRTLOGD_UNIT_FILES_IN = \ SYSTEMD_UNIT_FILES += $(notdir $(VIRTLOGD_UNIT_FILES_IN:%.in=%)) SYSTEMD_UNIT_FILES_IN += $(VIRTLOGD_UNIT_FILES_IN) +OPENRC_INIT_FILES += \ + virtlogd.init \ + $(NULL) +OPENRC_INIT_FILES_IN += \ + virtlogd.init.in \ + $(NULL) + noinst_LTLIBRARIES += libvirt_driver_log.la libvirt_la_BUILT_LIBADD += libvirt_driver_log.la @@ -126,6 +133,9 @@ logging/log_daemon_dispatch_stubs.h: $(LOG_PROTOCOL) \ virLogManagerProtocol VIR_LOG_MANAGER_PROTOCOL \ $(LOG_PROTOCOL) > logging/log_daemon_dispatch_stubs.h +virtlogd.init: logging/virtlogd.init.in $(top_builddir)/config.status + $(AM_V_GEN)$(SED) $(COMMON_UNIT_VARS) $< > $@-t && mv $@-t $@ + virtlogd.service: logging/virtlogd.service.in $(top_builddir)/config.status $(AM_V_GEN)sed $(COMMON_UNIT_VARS) $< > $@-t && mv $@-t $@ diff --git a/src/logging/virtlogd.init.in b/src/logging/virtlogd.init.in new file mode 100644 index 0000000000..61e41f7689 --- /dev/null +++ b/src/logging/virtlogd.init.in @@ -0,0 +1,14 @@ +#!/sbin/openrc-run + +name=virtlogd + +command=@sbindir@/virtlogd +pidfile="@runstatedir@/virtlogd.pid" +command_args="--daemon --pid-file=${pidfile}" +PATH="${PATH}:@sbindir@:@bindir@" +supervisor=supervise-daemon + +depend() { + provide virtlogd + keyword -shutdown +} -- 2.24.1

2 1

[jenkins-ci PATCH] guests: Update vault
by Andrea Bolognani 21 Feb '20

21 Feb '20

Add secrets for libvirt-centos-8, libvirt-opensuse-151, libvirt-ubuntu-1604 and libvirt-ubuntu-1804 Jenkins builders. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the unreviewable vault update rule. guests/vars/vault.yml | 100 +++++++++++++++++++++++++----------------- 1 file changed, 59 insertions(+), 41 deletions(-) diff --git a/guests/vars/vault.yml b/guests/vars/vault.yml index b6e591d..f1ee165 100644 --- a/guests/vars/vault.yml +++ b/guests/vars/vault.yml @@ -1,42 +1,60 @@ $ANSIBLE_VAULT;1.1;AES256 -65623833636335376266323136336664373431636637626132386363623335383730353431353066 -3037623836326161356332663335383132336432376132330a346664316165636132653830373939 -61653035306563323135303962343336383161336238623130653865303933626165303239616338 -3965636431663438310a343661323736343030323665346463316332333239323465313366333461 -38633833333230316435663131336161303638366462663236376364313631313463366635396332 -63366636653533653663343234633961633234323431656361373038616638316338363930363761 -31376237636262336435386339303139363966343337303564373530396630303062343431616161 -34353034393061396635323236663438316137396661626337353439353363353866346630323433 -39623764313535623331313232623464356439363037363436346232386333633834306630346632 -39343934343238626333323762353863316465303930653130656261643538393438333038666532 -38366464666362643236376335393032353138393833376362666233323930383963356531303535 -66326266623038373238366338306439306239633836346162303261646638353933643965376236 -66376630363035633663376339363132323836636436663565376537326235333531323632613333 -62333932633235336161333331373266326231626331383837343433633133623762633034363932 -30653433346634646232363966383433393131656364336532653135373862633562343230616466 -32633434323963363138666533623930666566393831643133353731646335343466306237376634 -34336133333131373134653438333766326432613636643938353966643336643663363763646230 -63636165663734643930323932643066663737383961346530653166313439663363363332373638 -63643364373137366261626366366435373034333065396236383737323265333435316166303336 -37333432336530616137663931643430303261653433366639633137656261616134326337346566 -37623036393766636631333766613134363135383434343737306339393061383737373832303033 -34393834373365336239323431646363636134653738393634613134363863663765666565303535 -30316331333437373264636265633364656163306533346339343262646465343465373365643962 -38323430613065666331313538353165326336393865346663633764333032363461343961353634 -61313330323639386264323233396465376333306466313562303332376162613739323833343864 -36326430386134323163363134646537386665626666663630663166323336623732373765353939 -64386233663831613736336230363136303539663962623935356436393834383734356164356666 -31366164663836626464333763323230336663633965326364653730393536633036313333336439 -38376638303336333731633037313839306335343364656133666331663862373232306337653638 -30653465366236356463656162336339656337393664666437623264396432303933663232356430 -62373236633936626666343866623936323934666331316632366664323166366362303530643737 -65346463333432613237353034616635366534666133656432383639363632316363343533363333 -33306533393764343963343663653164313033366162383232386636303063623964343337323137 -32316534313938343132653332373938383062646461366562313030623065613930396538613536 -61396230313534626139316165643938643365326133366664363361656631363438633036393733 -64313639623436373666643464626432316566336330646535616132613864316135363039363064 -61353135366530653166636365346237653033616431646635393461306339636662356532323732 -33616630396536636234303230653433386432393130636538313665643338373138393930386539 -64383334326435633666323762353462646264316265666535346134353862656164306331336363 -32303264303038656633613539343438366166343830643337373563636565336331326635613530 -66616235656161346230653031623331333830616164663333613137656636386635 +37333237623832363064323432326164363235616266636532363061616365363934333134376661 +3265306535343462616137356632383537626537366436630a636464303935636664383466663837 +61643362333631383263343461383130663764646433323465353434323935346637343639386334 +3163393931663364390a656436383233383633323964306233306131653164326264643231616339 +62613737663432343630613539306362356664363236396238386532323035393966663038656362 +33623764373139393936633236343033623064343531373239663562376330366139633935613832 +30623862663266383433323937353730313965333835346636326633663838363735373331353434 +37386230653138346333316232316164353938663538623833323839633732663333633031623935 +32393765646439643939623263326538366664393433316165643465333335653736396564656661 +31653834623265326464333333316533636236613766656132363936356335316638383865353266 +65616537306538393661306334336530353639343363313935383134356434346137613234663031 +39363364656561656134643734613737666664386164363663316635313431303337343262326161 +31323937643034653465613734383031623262386336346165383133366534653265346333323564 +61303763363563346537666364373832663466333535633435356562636338323361643666653663 +39336433323234306338393461383233313536373938313633396639656532646235383230636131 +61306462646131623963316165643830613731356639376435363537366236316634306430643338 +61656238373566383436643930303133643532363535346530363461643233313030343635393730 +38613538363166653562633738313962623330653532396431623630336438386435383365623230 +65393962333835363933623833393863343836393865623030346361653234646666616131623738 +30646330353731636238333235663838393762356432353634653036313732366262336230653637 +63303535643363633331326636363063653135386666646264303434396562353138653661633032 +61336237646531376339643765323135373738373161643034386163366538326236323335616230 +63613364323430356237663039393037313237326364346134623830613962613937356235383131 +30383432613432303636393032326534643264663962306539303065623261306538303961653033 +30393734643237623931323738343130626537636366383562646164386137663565323238363364 +35313239313333396461646234643330316266303939306639616631653962386530353331366338 +36613537353464613732393166336532666230643761336263653465353534373866303165373237 +30333633613938343266356334313230343166626638316433353636373835666237303438323065 +66326338326562383537616563313462643534373362653933656164666339346564343331653862 +36393134336233376265616135393063613832393064323265663561623361323637623963616539 +65666630316262376464373038303935346437623138663832623765653165366330323037363934 +61353534646466386535623063343234393865636462343930396366346535363362613130623432 +32623832306430383931393335373664653830386262623337646564633966316464316239366332 +31386132323137396436643764613938313262623661363766363632353561663336393231366632 +35383633356139313031666237313530666264633539343930306534646138396135356464616237 +30326139303338656133386234333034336561323237613131303965383031326262646665393031 +31343236643865373636353437613230386538376133643634363965326334376661643335376136 +35646666333363333161366237653635373565623737653961616232376135363732366662356434 +62373465373931636637346463633038656637393034393835643364303137643738633132313239 +31663065336566373466386636666164396264666634636539616539326539373638616438313737 +37373731643736393431303033613264346364313062333062313930636561633162636466616634 +33313035393264643039373563626466613764653262323064666530326264303633626337333936 +63643465653664373434643530386161653030613734656663613136643161316432366561396439 +66616565366539343966386338356438316263613732306335333734333966383432626565343463 +30343334646463646334383963383465313665353930386435323038313033393639373832353236 +66656537663762663138353363386539373732346238613362333035613431383461646166336332 +62626637663664363931653664303965633139663463396561336364373339623333343966393439 +65353034326166613036336134383062393664313765353062396261376336313631373163656130 +32343038663837393561363264313631656334613236383963333235353864643264383735636537 +37613330616136313632363035653863363936623163663831393935333439373237663432613165 +36653834643739656465343966343731323461616435373562393130663932666339633632656639 +35313835326438623866303362373734363831613661363535656531626165386463613932333363 +37636663623136356334393334623733636563383336326333303738303935613766366633376231 +62373961383463393465623035303439386262623036666632316237363566653161313164343863 +31326532656635633735326165333365646566663365646164636463613261326133363432636238 +32303962656563306134343564383462666563656531326136316662366633636364626463623135 +66323338643735336366326534383161326335616365646533646132613063303037663234353065 +38366234316435393262343535306333363835303139306630643532616536313965383663383961 +633836366539336630316533376133353239 -- 2.24.1

1 0

Libvirt got accepted to GSoC 2020
by Michal Privoznik 21 Feb '20

21 Feb '20

I'd like to share great news. Libvirt got accepted again to this year's Google Summer of Code [1]. We can expect to see e-mails, irc discussions with potential candidates. If you have any idea for a project please add it to our Ideas page [2], even if you don't feel like mentoring it. I will find mentors later. Likewise, if you want to mentor a project then add your name there. Student application doesn't start until March 16 and is due March 31. Michal 1: https://summerofcode.withgoogle.com/organizations/6335698124144640/ 2: https://wiki.libvirt.org/page/Google_Summer_of_Code_Ideas

1 0

[ruby PATCH] Fix cpumap allocation for virDomainGetVcpus and use return value
by Charlie Smurthwaite 21 Feb '20

21 Feb '20

This patch fixes a bug in which only enough memory for one cpumap is allocated for virDomainGetVcpus instead of one per virtual CPU. This Fixes an overflow. Additionally, it uses the return value of virDomainGetVcpus to determine how many cpuinfo structs were actually populated rather than assuming they all are. Finally, it uses the logical CPU number from the cpuinfo struct in the retrurn data instead of assuming CPU numbers are sequential. This should handle cases where arbitrary CPUs are offline. Signed-off-by: Charlie Smurthwaite <charlie(a)atechmedia.com> --- ext/libvirt/domain.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ext/libvirt/domain.c b/ext/libvirt/domain.c index d665907..c6de1bf 100644 --- a/ext/libvirt/domain.c +++ b/ext/libvirt/domain.c @@ -803,7 +803,7 @@ static VALUE libvirt_domain_vcpus(VALUE d) cpumaplen = VIR_CPU_MAPLEN(maxcpus); - cpumap = alloca(sizeof(unsigned char) * cpumaplen); + cpumap = alloca(sizeof(unsigned char) * cpumaplen * dominfo.nrVirtCpu); r = virDomainGetVcpus(ruby_libvirt_domain_get(d), cpuinfo, dominfo.nrVirtCpu, cpumap, cpumaplen); @@ -832,15 +832,16 @@ static VALUE libvirt_domain_vcpus(VALUE d) result = rb_ary_new(); - for (i = 0; i < dominfo.nrVirtCpu; i++) { + for (i = 0; i < r; i++) { vcpuinfo = rb_class_new_instance(0, NULL, c_domain_vcpuinfo); - rb_iv_set(vcpuinfo, "@number", UINT2NUM(i)); if (cpuinfo != NULL) { + rb_iv_set(vcpuinfo, "@number", INT2NUM(cpuinfo[i].number)); rb_iv_set(vcpuinfo, "@state", INT2NUM(cpuinfo[i].state)); rb_iv_set(vcpuinfo, "@cpu_time", ULL2NUM(cpuinfo[i].cpuTime)); rb_iv_set(vcpuinfo, "@cpu", INT2NUM(cpuinfo[i].cpu)); } else { + rb_iv_set(vcpuinfo, "@number", Qnil); rb_iv_set(vcpuinfo, "@state", Qnil); rb_iv_set(vcpuinfo, "@cpu_time", Qnil); rb_iv_set(vcpuinfo, "@cpu", Qnil); -- 2.25.0

2 1

[PATCH 0/3] Couple of memleak fixes
by Michal Privoznik 21 Feb '20

21 Feb '20

*** BLURB HERE *** Michal Prívozník (3): virDomainFSDefFree: Unref private data virDomainNetDefClear: Free @persistent name qemuTestParseCapabilitiesArch: Free @binary src/conf/domain_conf.c | 2 ++ tests/testutilsqemu.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.24.1

2 6

[libvirt PATCH] docs: Expand documentation for the tickpolicy timer attribute
by Andrea Bolognani 21 Feb '20

21 Feb '20

The current documentation is fairly terse and not easy to decode for someone who's not intimately familiar with the inner workings of timer devices. Expand on it by providing a somewhat verbose description of what behavior each policy will result in, as seen from both the guest OS and host point of view. This is lifted directly from QEMU commit commit 2a7d957596786404c4ed16b089273de95a9580ad Author: Andrea Bolognani <abologna(a)redhat.com> Date: Tue Feb 11 19:37:44 2020 +0100 qapi: Expand documentation for LostTickPolicy v4.2.0-1442-g2a7d957596 The original text also matched word for word the documentation found in QEMU. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/formatdomain.html.in | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f4af65f13f..4fef2a0a97 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2487,26 +2487,36 @@ <p> The <code>tickpolicy</code> attribute determines what happens when QEMU misses a deadline for injecting a - tick to the guest: + tick to the guest. This can happen, for example, because the + guest was paused. </p> <dl> <dt><code>delay</code></dt> - <dd>Continue to deliver ticks at the normal rate. - The guest time will be delayed due to the late - tick</dd> + <dd>Continue to deliver ticks at the normal rate. The guest OS + will not notice anything is amiss, as from its point of view + time will have continued to flow normally. The time in the + guest should now be behind the time in the host by exactly + the amount of time during which ticks have been missed.</dd> <dt><code>catchup</code></dt> - <dd>Deliver ticks at a higher rate to catch up - with the missed tick. The guest time should - not be delayed once catchup is complete.</dd> + <dd>Deliver ticks at a higher rate to catch up with the missed + ticks. The guest OS will not notice anything is amiss, as + from its point of view time will have continued to flow + normally. Once the timer has managed to catch up with all + the missing ticks, the time in the guest and in the host + should match.</dd> <dt><code>merge</code></dt> <dd>Merge the missed tick(s) into one tick and inject. The guest time may be delayed, depending on how the OS reacts to the merging of ticks</dd> <dt><code>discard</code></dt> - <dd>Throw away the missed tick(s) and continue - with future injection normally. The guest time - may be delayed, unless the OS has explicit - handling of lost ticks</dd> + <dd>Throw away the missed ticks and continue with future + injection normally. The guest OS will see the timer jump + ahead by a potentially quite significant amount all at once, + as if the intervening chunk of time had simply not existed; + needless to say, such a sudden jump can easily confuse a + guest OS which is not specifically prepared to deal with it. + Assuming the guest OS can deal correctly with the time jump, + the time in the guest and in the host should now match.</dd> </dl> <p>If the policy is "catchup", there can be further details in the <code>catchup</code> sub-element.</p> -- 2.24.1

2 1

[PATCH v1 0/3] qemumonitorjson tests for cpu compare and baseline
by Collin Walling 21 Feb '20

21 Feb '20

These patches implement tests for the libvirt qemu_monitor_json API for the hypervisor-cpu-compare and -baseline commands. The input and output data is mocked with arbitrary values. A prerequisite patch is included to load the capabilities schema for a specific architecture. Originally, only the x86 capabilities were loaded for the qemu_monitor_json tests. By accepting a string denoting which architecture's QEMU capabilities we'd like to load, we can now test the comparison and baseline code that is currently only supported on s390. Collin Walling (3): qemumonitorjsontest: load schema based on specified arch qemumonitorjsontest: add tests for cpu comparison qemumonitorjsontest: add test for cpu baseline tests/qemublocktest.c | 2 +- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 131 +++++++++++++++++++++++++++++++++++++++++++- tests/testutilsqemuschema.c | 8 +-- tests/testutilsqemuschema.h | 4 +- 5 files changed, 137 insertions(+), 10 deletions(-) -- 2.7.4

2 4

[libvirt PATCH] m4: libxl: properly fail when libxl is required
by Ján Tomko 20 Feb '20

20 Feb '20

We specify "true" as the fail-action for LIBVIRT_CHECK_PKG. This was used when we had a fallback to non-pkg-config detection, then removed in commit 5bdcef13d13560512c7d6d8c9e8822e456889e0c later re-introduced in commit dc3d2c9f8c7678a950abedd227b1587ca62335c4 and then left in when removing the old detection again in commit 18981877d2e20390a79d068861a24e716f8ee422 Remove it to properly error out when libxl was requested but not detected. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 18981877d2e20390a79d068861a24e716f8ee422 --- m4/virt-driver-libxl.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4 index 2f3565f1d5..a958cb26fa 100644 --- a/m4/virt-driver-libxl.m4 +++ b/m4/virt-driver-libxl.m4 @@ -30,7 +30,7 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [ dnl search for libxl, aka libxenlight old_with_libxl="$with_libxl" - LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0], [true]) + LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0]) if test "x$with_libxl" = "xyes" ; then LIBXL_FIRMWARE_DIR=$($PKG_CONFIG --variable xenfirmwaredir xenlight) LIBXL_EXECBIN_DIR=$($PKG_CONFIG --variable libexec_bin xenlight) -- 2.24.1

2 1

[PATCH 0/3] Couple of almost trivial patches
by Michal Privoznik 20 Feb '20

20 Feb '20

These stem out from my review of Marc-André's patches: https://www.redhat.com/archives/libvir-list/2020-January/msg00648.html Michal Prívozník (3): virpidfile: Set correct retval in virPidFileReadPath() qemu: Don't explicitly remove pidfile after virPidFileForceCleanupPath() qemu_migration: Rearrange some checks in qemuMigrationSrcIsAllowed() src/qemu/qemu_migration.c | 66 +++++++++++++++++----------------- src/qemu/qemu_process.c | 9 +---- src/qemu/qemu_vhost_user_gpu.c | 10 +----- src/util/virpidfile.c | 2 +- 4 files changed, 36 insertions(+), 51 deletions(-) -- 2.24.1

2 4