November 2020 - Devel - libvirt List Archives

[PATCH v1 00/10] more simple g_autoptr() cleanups
by Daniel Henrique Barboza 14 Nov '20

14 Nov '20

I intended to clean up the virDomainDefFree() calls that I kept seeing in qemu_driver.c, ended up doing a bit more than that. Daniel Henrique Barboza (10): qemu_driver.c: use g_autoptr() with virDomainDef pointers qemu_driver.c: use g_autoptr() with qemuMigrationParams pointers qemu_driver.c: use g_autoptr() with virDomainDeviceDefPtr qemu_driver.c: remove unneeded 'cleanup' labels qemu_snapshot.c: remove uneeded 'cleanup' label in qemuSnapshotDelete() qemu_domain.c: use g_autoptr() with virDomainDef pointers qemu_domain.c: remove unneeded cleanup labels qemu_domain.c: modernize qemuDomainFixupCPUs() qemu_domain.c: modernize qemuDomainWriteMasterKeyFile() qemu_domain.c: modernize qemuMonitorGetCpuHalted() src/qemu/qemu_domain.c | 100 ++++++------------ src/qemu/qemu_driver.c | 219 +++++++++++++++------------------------ src/qemu/qemu_snapshot.c | 3 +- 3 files changed, 119 insertions(+), 203 deletions(-) -- 2.26.2

3 14

[PATCH] virnetdevopenvswitch: Fix ATTRIBUTE_NONNULL() tag for virNetDevOpenvswitchGetVhostuserIfname()
by Michal Privoznik 14 Nov '20

14 Nov '20

After e4c29e2904 the function has one argument more and the argument that can't be NULL moved from second to third position. Reported-by: John Ferlan <jferlan(a)redhat.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed as trivial. src/util/virnetdevopenvswitch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevopenvswitch.h b/src/util/virnetdevopenvswitch.h index 5cd1d22ae3..8409aa92ac 100644 --- a/src/util/virnetdevopenvswitch.h +++ b/src/util/virnetdevopenvswitch.h @@ -63,7 +63,7 @@ int virNetDevOpenvswitchInterfaceGetMaster(const char *ifname, char **master) int virNetDevOpenvswitchGetVhostuserIfname(const char *path, bool server, char **ifname) - ATTRIBUTE_NONNULL(2) G_GNUC_WARN_UNUSED_RESULT G_GNUC_NO_INLINE; + ATTRIBUTE_NONNULL(3) G_GNUC_WARN_UNUSED_RESULT G_GNUC_NO_INLINE; int virNetDevOpenvswitchUpdateVlan(const char *ifname, const virNetDevVlan *virtVlan) -- 2.26.2

1 0

[libvirt PATCH] kbase: Shorten "less verbose QEMU logging" example
by Andrea Bolognani 14 Nov '20

14 Nov '20

Rationale for the changes: * util.dbus produces very little logging, so it doesn't really make sense to filter it out; * util.udev doesn't exist; * access can be filtered out entirely, as nothing very interesting is produced by the only other component in the same package (access.accessdriverpolkit). Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/kbase/debuglogs.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst index 7945cf8bed..fed998efd8 100644 --- a/docs/kbase/debuglogs.rst +++ b/docs/kbase/debuglogs.rst @@ -178,13 +178,12 @@ Less verbose logging for QEMU VMs Some subsystems are very noisy and usually not the culprit of the problems. They can be silenced individually for a less verbose log while still logging -everything else. Usual suspects are the JSON code, udev, authentication and such. +everything else. Usual suspects are the JSON code, RPC, authentication and such. A permissive filter is good for development use cases. :: - 3:remote 4:event 3:util.json 3:util.object 3:util.dbus 3:util.udev 3:node_device 3:rpc 3:access.accessmanager 3:util.netlink 1:* - + 3:remote 4:event 3:util.json 3:util.object 3:util.netlink 3:node_device 3:rpc 3:access 1:* Minimalistic QEMU QMP monitor logging ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- 2.26.2

3 3

[PATCH 0/2] virnetdevopenvswitch: Get names for dpdkvhostuserclient too
by Michal Privoznik 14 Nov '20

14 Nov '20

The first patch fixes the actual problem, the second is just a cleanup I've came up with whilst looking at the code. Michal Prívozník (2): virnetdevopenvswitch: Get names for dpdkvhostuserclient too virnetdevopenvswitch: Simplify OVS_VSCTL cmd creation src/qemu/qemu_command.c | 1 + src/qemu/qemu_hotplug.c | 1 + src/util/virnetdevopenvswitch.c | 92 +++++++++++++++++++-------------- src/util/virnetdevopenvswitch.h | 1 + tests/qemuxml2argvmock.c | 1 + 5 files changed, 56 insertions(+), 40 deletions(-) -- 2.26.2

3 5

[libvirt PATCH] docs: compiling.html: pass -d to xz to decompress
by Daniel P. Berrangé 14 Nov '20

14 Nov '20

From: Jonathan Watt <jwatt(a)jwatt.org> tar on macOS recognizes XZ compression automatically, but that is not the case for GNU tar (1.32 at least). On Fedora 33 the current instructions result in the following error: $ xz -c libvirt-6.9.0.tar.xz | tar xvf - tar: Archive is compressed. Use -J option tar: Error is not recoverable: exiting now Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Jonathan Watt <jwatt(a)jwatt.org> --- Pushed as a trivial patch from gitlab docs/compiling.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/compiling.html.in b/docs/compiling.html.in index c898d16313..c2c9d9f0ed 100644 --- a/docs/compiling.html.in +++ b/docs/compiling.html.in @@ -14,7 +14,7 @@ </p> <pre> -$ xz -c libvirt-x.x.x.tar.xz | tar xvf - +$ xz -dc libvirt-x.x.x.tar.xz | tar xvf - $ cd libvirt-x.x.x $ meson build</pre> -- 2.28.0

1 0

[PATCH 0/6] qemu: Enable client TLS certificate validation by default for chardev, migration, and backup servers
by Peter Krempa 14 Nov '20

14 Nov '20

See patches 6 for a explanation. Peter Krempa (6): qemu: conf: Allow individual control of default value for *_tls_x509_verify qemu: conf: Clarify default of "vnc_tls_x509_verify" qemu: conf: Enable 'chardev_tls_x509_verify' by default qemu: conf: Enable 'migrate_tls_x509_verify' by default qemu: conf: Enable 'backup_tls_x509_verify' by default NEWS: Mention change of default for TLS certificate verification NEWS.rst | 11 +++++++++++ src/qemu/qemu.conf | 18 ++++++++++++++---- src/qemu/qemu_conf.c | 22 ++++++++++++++-------- src/qemu/qemu_conf.h | 1 + 4 files changed, 40 insertions(+), 12 deletions(-) -- 2.28.0

5 14

Re: [PATCH] Added attach-disk parameters for network disk support
by Peter Krempa 14 Nov '20

14 Nov '20

On Thu, Nov 12, 2020 at 15:15:27 -0600, Ryan Gahagan wrote: > Hey Peter, Hi Ryan, firstly I'd like to ask you to keep the conversation on-list. (use reply-all all the time). This ensures that the response is public and also other people can jump in and respont. At the very least it can be used for future reference. I'll be re-adding the mailing list in this response. Also please avoid top-posting in techincal lists. It's always best to respond inline at the proper context that is being discussed. > Sorry about all the issues with our commit, we're new to this and trying to > make our first contribution to this repo. We had a couple questions over > your feedback and wanted to run them by you before making another request. Sure thing, you can always ask on the mailing list even without patches. > In the original code, the --source parameter is marked as required but okay > to be empty. If the string is empty, then we think the parameter read in by > vshCommandOptStringReq would be NULL, in which case no <source> tag would > be generated at all. If this is the case, then why is --source required in > the first place? We see that --source-name is mutually exclusive witha That's a quirk of it being a positional argument (VSH_OT_DATA). A positional argument is mandatory. > --source, but is it also okay to be empty? For example, in the issue > <https://gitlab.com/libvirt/libvirt/-/issues/16> this patch was based on, > there's an example XML which has a <source> with neither a file nor a name. > Is this example incorrect, or is it fine to have neither and only have a > protocol? That is correct for example with the NBD protocol where a missing name actually means the default unnamed export. The thing is that we can't really change --source to be something else than VSH_OT_DATA since it would change the semantics of the virsh command. You probably will need to use it also for the 'name' attribute and switch the name according to the presence of the 'protocol' attribute/option. > When it comes to making these mutually exclusive, we also were confused on > what flags to give them. Would it be proper behavior to give them both no > flags or only the VSH_OFLAG_EMPTY_OK flag and then check that one is > defined in the cmdAttachDisk method (using VSH_EXCLUSIVE_OPTIONS_VAR) and > error there instead? Those are two separate things. If it makes sense for a flag to be specified but empty and it impacts behaviour then you need to use VSH_OFLAG_EMPTY_OK. Any non-positional arguments (those which need --) can be made optional. On the other hand that does not say anything about how they can or can't be combined with other options and thus you need to declare that in the code. > If the user provides an empty source without any protocol, but provides > --source-host-* parameters, what should be generated instead? Would this This should be an error. --source-host must require the use of --source-protocol > cause an error, would it generate an in-line <host> tag, or would it > generate a completely empty <source> tag followed by the host information? The protocol option flag should be mandatory if you want to use the host/socket. > > -Ryan Gahagan > > On Thu, Nov 12, 2020 at 2:57 AM Peter Krempa <pkrempa(a)redhat.com> wrote: > > > On Wed, Nov 11, 2020 at 17:00:51 -0600, Ryan Gahagan wrote: > > > Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 > > > Added in support for the following parameters in attach-disk: > > > --source-name > > > --source-protocol > > > --source-host-name > > > --source-host-socket > > > --source-host-transport Please trim parts of the message that are no longer relevant. [...]

1 0

[PATCH] viridentitytest: Run more frequently
by Michal Privoznik 14 Nov '20

14 Nov '20

The viridentitytest tests our viridentity module which is compiled on all platforms and OSes. There is no need to have SELinux secdriver as individual test cases are skipped if SELinux is missing. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Successfully build here: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/213586713 While technically this is a v2 of: https://www.redhat.com/archives/libvir-list/2020-November/msg00308.html it's implementing completely different approach and thus I did not mark it as v2. tests/meson.build | 2 +- tests/viridentitytest.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 8decdfa20c..9f0051303d 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -312,6 +312,7 @@ tests += [ { 'name': 'virfirewalltest' }, { 'name': 'virhostcputest', 'link_whole': [ test_file_wrapper_lib ] }, { 'name': 'virhostdevtest' }, + { 'name': 'viridentitytest' }, { 'name': 'viriscsitest' }, { 'name': 'virkeycodetest' }, { 'name': 'virkmodtest' }, @@ -480,7 +481,6 @@ if conf.has('WITH_SECDRIVER_SELINUX') if conf.has('WITH_LIBATTR') tests += [ { 'name': 'securityselinuxtest' }, - { 'name': 'viridentitytest' }, ] if conf.has('WITH_QEMU') diff --git a/tests/viridentitytest.c b/tests/viridentitytest.c index fd01eeaa80..afb9fdaec4 100644 --- a/tests/viridentitytest.c +++ b/tests/viridentitytest.c @@ -88,8 +88,7 @@ static int testIdentityGetSystem(const void *data) #if !WITH_SELINUX if (context) { VIR_DEBUG("libvirt not compiled with SELinux, skipping this test"); - ret = EXIT_AM_SKIP; - return -1; + return EXIT_AM_SKIP; } #endif -- 2.26.2

3 2

[PATCH 0/9] docs: kbase style change and cleanups
by Peter Krempa 14 Nov '20

14 Nov '20

Some patches are taken from an older series where we've discussed that the kbase page should look more like 'docs.html' as more articles appear, this series delivers that: https://www.redhat.com/archives/libvir-list/2020-August/msg00172.html ... and a few other changes. Final output: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/830387801/artifacts/website/docs… Peter Krempa (9): docs: Fix title of 'docs' page docs: xslt: Use 'Link' rather than 'Permalink' in header links docs: css: Add a gray box around table of contents of RST based docs docs: kbase: Move index page to docs/kbase docs: kbase: Remove extra container from index page docs: kbase: Split articles into sections docs: xsl: Unify stylability of main container element docs: css: Modify appearance of the kbase directory page docs: kbase: Reorder some articles in the 'Usage' section docs/docs.html.in | 5 ++-- docs/index.html.in | 4 +-- docs/kbase.rst | 53 --------------------------------- docs/kbase/index.rst | 57 +++++++++++++++++++++++++++++++++++ docs/kbase/meson.build | 1 + docs/libvirt.css | 67 +++++++++++++++++++++++++++--------------- docs/meson.build | 1 - docs/page.xsl | 27 ++++++++++------- scripts/hvsupport.py | 2 +- 9 files changed, 124 insertions(+), 93 deletions(-) delete mode 100644 docs/kbase.rst create mode 100644 docs/kbase/index.rst -- 2.26.2

2 11

[PATCH 0/3] kbase: Port 'debuglogs' from wiki and convert directory to rst
by Peter Krempa 14 Nov '20

14 Nov '20

This patchset: 1) converts the 'kbase' directory page to RST 2) increases width of the container holding the kbase articles: before: https://libvirt.org/kbase.html after: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/663385238/artifacts/website/kbas… 3) ports 'debuglogs' wiki article to the kbase: original: https://wiki.libvirt.org/page/DebugLogs converted: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/663385238/artifacts/website/kbas… Note that this patchset requires Pavel's meson rewrite. Peter Krempa (3): docs: kbase: Convert 'kbase' article registry to RST docs: kbase: Make kbase article directory wider docs: kbase: Port 'debuglogs' document from libvirt's wiki docs/kbase.html.in | 54 -------------- docs/kbase.rst | 46 ++++++++++++ docs/kbase/debuglogs.rst | 148 +++++++++++++++++++++++++++++++++++++++ docs/kbase/meson.build | 1 + docs/libvirt.css | 8 +++ docs/meson.build | 2 +- 6 files changed, 204 insertions(+), 55 deletions(-) delete mode 100644 docs/kbase.html.in create mode 100644 docs/kbase.rst create mode 100644 docs/kbase/debuglogs.rst -- 2.26.2

6 13