September 2019 - Devel - libvirt List Archives

[libvirt] [PATCH] news: rewording wrt NSS, virt-login-shell & split daemons
by Daniel P. Berrangé 03 Sep '19

03 Sep '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index bd112d56dc..f376e991cb 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -65,13 +65,13 @@ </change> <change> <summary> - Split libvirtd into separate daemons + Experimental split of libvirtd into separate daemons </summary> <description> The big monolithic libvirtd daemon can now be replaced by smaller - per-driver daemons. Distributions can chose if they want the former - or the latter. The libvirtd is still kept around for backwards - compatibility. + per-driver daemons. The new split daemons are considered experimental + at this time and distributions are encouraged to continue using the + traditional libvirtd by default. </description> </change> </section> @@ -136,13 +136,22 @@ </change> <change> <summary> - Stop linking virt-login-shell and NSS plugins with libvirt.so + Stop linking NSS plugins with libvirt.so </summary> <description> - In order to allow libvirt to abort on out of memory, we need to stop - linking libvirt.so to virt-login-shell or the NSS plugins where we - don't want to abort. This change also resulted in smaller binaries - and libraries. + This reduces the amount of code and 3rd party libraries are that + loaded into all processes. + </description> + </change> + <change> + <summary> + Split the setuid virt-login-shell binary into two pieces + </summary> + <description> + The setuid virt-login-shell binary is now a tiny shim that + sanitizes the process execution environment variables and + arguments, before launching the trusted virt-login-shell-helper + binary. </description> </change> <change> -- 2.21.0

2 1

[libvirt] [PATCH] virsh: Fix help for net-port-delete
by Jonathon Jongsma 03 Sep '19

03 Sep '19

Apparently a copy/paste error. The net-port-delete help string was in fact from net-port-dumpxml. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1747826 Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- tools/virsh-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index af08441842..be16f7970e 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -1593,10 +1593,10 @@ cmdNetworkPortDumpXML(vshControl *ctl, const vshCmd *cmd) */ static const vshCmdInfo info_network_port_delete[] = { {.name = "help", - .data = N_("network port information in XML") + .data = N_("delete the specified network port") }, {.name = "desc", - .data = N_("Output the network port information as an XML dump to stdout.") + .data = N_("Delete the specified network port.") }, {.name = NULL} }; -- 2.21.0

2 1

[libvirt] [PATCH python] spec: Build python2 package in fedora < 31
by Nir Soffer 03 Sep '19

03 Sep '19

Since commit ee0cfbe65c5d (spec: Unconditionally build python2 on Fedora) python2-libvirt is not built on any Fedora version. Fix the spec to drop python2-libvirt on Fedora 31. Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- libvirt-python.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 64a30b5..8506840 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -13,7 +13,7 @@ %endif %define _with_python2 1 -%if 0%{?fedora} || 0%{?rhel} > 7 +%if 0%{?fedora} > 30 || 0%{?rhel} > 7 %define _with_python2 0 %endif -- 2.20.1

2 1

[libvirt] [PATCH] news: document new libxml version requirement
by Daniel P. Berrangé 03 Sep '19

03 Sep '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 92d566c2fe..434aeab933 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,15 @@ KVM device assignment from libvirt too. </description> </change> + <change> + <summary> + libxml: min required libxml is now 2.9.1 + </summary> + <description> + Support for building with libxml versions older than 2.9.1 + has been dropped. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.21.0

2 3

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-check » libvirt-fedora-rawhide #1056
by Cole Robinson 03 Sep '19

03 Sep '19

On 9/3/19 9:31 AM, ci(a)centos.org wrote: > See <https://ci.centos.org/job/virt-manager-check/systems=libvirt-fedora-rawhide…> > > ------------------------------------------ > Started by upstream project "virt-manager-check" build number 1056 > originally caused by: > Started by upstream project "virt-manager-build" build number 1060 > originally caused by: > Started by upstream project "libvirt-python-build" build number 685 > originally caused by: > Started by upstream project "libvirt-build" build number 799 > originally caused by: > Started by an SCM change > Running as SYSTEM > [EnvInject] - Loading node environment variables. > Building remotely on libvirt-fedora-rawhide (libvirt) in workspace <https://ci.centos.org/job/virt-manager-check/systems=libvirt-fedora-rawhide…> > [virt-manager] $ /bin/sh -xe /tmp/jenkins12079261823599550029.sh > + /usr/bin/python3 ./setup.py test > running test > Traceback (most recent call last): > File "/home/jenkins/build/libvirt/lib64/python3.7/site-packages/libvirt.py", line 24, in <module> > import cygvirtmod as libvirtmod > ModuleNotFoundError: No module named 'cygvirtmod' > > During handling of the above exception, another exception occurred: > > Traceback (most recent call last): > File "./setup.py", line 661, in <module> > distutils.core.setup( > File "/usr/lib64/python3.8/distutils/core.py", line 148, in setup > dist.run_commands() > File "/usr/lib64/python3.8/distutils/dist.py", line 966, in run_commands > self.run_command(cmd) > File "/usr/lib64/python3.8/distutils/dist.py", line 985, in run_command > cmd_obj.run() > File "./setup.py", line 528, in run > TestBaseCommand.run(self) > File "./setup.py", line 448, in run > import tests as testsmodule > File "<https://ci.centos.org/job/virt-manager-check/systems=libvirt-fedora-rawhide…",> line 16, in <module> > from virtinst import buildconfig > File "<https://ci.centos.org/job/virt-manager-check/systems=libvirt-fedora-rawhide…",> line 42, in <module> > _set_libvirt_error_handler() > File "<https://ci.centos.org/job/virt-manager-check/systems=libvirt-fedora-rawhide…",> line 32, in _set_libvirt_error_handler > import libvirt > File "/home/jenkins/build/libvirt/lib64/python3.7/site-packages/libvirt.py", line 28, in <module> > raise lib_e > File "/home/jenkins/build/libvirt/lib64/python3.7/site-packages/libvirt.py", line 20, in <module> > import libvirtmod > ModuleNotFoundError: No module named 'libvirtmod' > Build step 'Execute shell' marked build as failure > Anyone know what's going on here? I don't think this is virt-manager's fault. The console output from the latest libvirt-python build: https://ci.centos.org/job/libvirt-python-build/685/systems=libvirt-fedora-r… Shows libvirt.py and libvirtmod.py being put into /home/jenkins/build/libvirt/lib64/python3.8/site-packages , but the above traceback indicates there's a libvirt.py in /home/jenkins/build/libvirt/lib64/python3.7/site-packages (3.8 vs 3.7). Maybe there's stale libvirt.py in the rawhide image? - Cole - Cole

3 2

[libvirt] [PULL 0/2] Audio 20190828 patches
by Gerd Hoffmann 03 Sep '19

03 Sep '19

The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20190828-pull-request for you to fetch changes up to 4b3b7793e18e1e3edb90bbc21112e875f9ff826d: audio: omitting audiodev= parameter is only deprecated (2019-08-28 11:57:45 +0200) ---------------------------------------------------------------- audio: two little fixes. ---------------------------------------------------------------- Kővágó, Zoltán (2): audio: fix invalid malloc size in audio_create_pdos audio: omitting audiodev= parameter is only deprecated audio/audio.c | 10 +++++----- qemu-deprecated.texi | 7 +++++++ 2 files changed, 12 insertions(+), 5 deletions(-) -- 2.18.1

2 3

[libvirt] [jenkins-ci PATCH v2] libvirt-ocaml: add a simple check job
by Pino Toscano 03 Sep '19

03 Sep '19

Run 'make check-manifest' as build step, so we ensure that the MANIFEST file is up-to-date, and thus dist will (hopefully) work. Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- Changes from v1: - run 'make check-manifest' as separate job guests/playbooks/build/projects/libvirt-ocaml.yml | 4 ++++ jenkins/projects/libvirt-ocaml.yaml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml b/guests/playbooks/build/projects/libvirt-ocaml.yml index 7a2e216..58f017b 100644 --- a/guests/playbooks/build/projects/libvirt-ocaml.yml +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml @@ -25,3 +25,7 @@ ./configure --prefix=$VIRT_PREFIX $MAKE $MAKE opt +- include: '{{ playbook_base }}/jobs/generic-check-job.yml' + vars: + command: | + $MAKE check-manifest diff --git a/jenkins/projects/libvirt-ocaml.yaml b/jenkins/projects/libvirt-ocaml.yaml index 8eb03e3..0c819cc 100644 --- a/jenkins/projects/libvirt-ocaml.yaml +++ b/jenkins/projects/libvirt-ocaml.yaml @@ -21,3 +21,7 @@ ./configure --prefix=$VIRT_PREFIX $MAKE $MAKE opt + - generic-check-job: + parent_jobs: 'libvirt-ocaml-build' + command: | + $MAKE check-manifest -- 2.21.0

2 1

[libvirt] [PATCH] news: Update for 5.7.0 release
by Michal Privoznik 03 Sep '19

03 Sep '19

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 133 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 133 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 0c79765fd0..f95af0f0e9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -50,6 +50,30 @@ for Hyper-V guests. </description> </change> + <change> + <summary> + lib: Add virDomainGetGuestInfo() + </summary> + <description> + This API is intended to aggregate several guest agent information + queries and is inspired by stats API + <code>virDomainListGetStats()</code>. It is anticipated that this + information will be provided by a guest agent + running within the domain. It's exposed as <code>virsh + guestinfo</code>. + </description> + </change> + <change> + <summary> + Split libvirtd into separate daemons + </summary> + <description> + The big monolithic libvirtd daemon can now be replaced by smaller + per-driver daemons. Distributions can chose if they want the former + or the latter. The libvirtd is still kept around for backwards + compatibility. + </description> + </change> </section> <section title="Removed features"> <change> @@ -75,8 +99,117 @@ <code>--bandwidth</code> parameter. </description> </change> + <change> + <summary> + libxl: Implement domain metadata getter/setter + </summary> + <description> + The libxl driver now supports <code>virDomainGetMetadata()</code> and + <code>virDomainSetMetadata()</code> APIs. + </description> + </change> + <change> + <summary> + test driver: Expand API coverage + </summary> + <description> + Additional APIs have been implemented in the test driver. + </description> + </change> + <change> + <summary> + Report RNG device in domain capabilities XML + </summary> + <description> + Libvirt now reports if RNG device is supported by underlying + hypervisor in domain capabilities XML. + </description> + </change> + <change> + <summary> + Stop linking virt-login-shell and NSS plugins with libvirt.so + </summary> + <description> + In order to allow libvirt abort on out of memory, we need to stop + link libvirt.so to virt-login-shell or the NSS plugins where we don't + want to abort. This change also resulted in smaller binaries and + libraries. + </description> + </change> + <change> + <summary> + qemu: Allow migration with disk cache on + </summary> + <description> + When QEMU supports flushing caches at the end of migration, we can + safely allow migration even if <code>disk/driver/@cache</code> is not + <code>none</code> nor <code>directsync</code>. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + Various security label remembering fixes + </summary> + <description> + In the previous release libvirt introduced remembering of original + owners and SELinux labels on files. However, the feature did not work + properly with snapshots, on migrations or on network filesystems. + This is now fixed. + </description> + </change> + <change> + <summary> + Allow greater PCI domain numbers + </summary> + <description> + Libvirt used to require PCI domain number to be not greater than + 0xFFFF. The code was changed to allow 32 bits long numbers. + </description> + </change> + <change> + <summary> + Various D-Bus fixes + </summary> + <description> + When D-Bus is not available, Libvirt was reporting random errors. + These are now gone. + </description> + </change> + <change> + <summary> + Prefer read only opening of PCI config files + </summary> + <description> + When enumerating PCI bus, Libvirt opens config files under + <code>sysfs</code> mount and parses them to learn various aspects of + the device (e.g. its capabilities). Only in a very limited number of + cases it is actually writing into the file. However, it used to open + the file also for writing even if it was only reading from it. + </description> + </change> + <change> + <summary> + Fix AppArmor profile + </summary> + <description> + Since the <code>5.6.0</code> release, Libvirt uses + <code>procfs</code> to learn the list of opened file descriptors when + spawning a command. However, our AppArmor profile was not allowing + such access. + </description> + </change> + <change> + <summary> + Don't block storage driver when starting or building a pool + </summary> + <description> + Starting or building a storage pool can take a long time to finish. + During this time the storage driver was blocked and thus no other API + involving the storage driver could run. This is now fixed. + </description> + </change> </section> </release> <release version="v5.6.0" date="2019-08-05"> -- 2.21.0

3 3

[libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step
by Pino Toscano 03 Sep '19

03 Sep '19

This ensures that the MANIFEST file is up-to-date, and thus dist will (hopefully) work. Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- guests/playbooks/build/projects/libvirt-ocaml.yml | 1 + jenkins/projects/libvirt-ocaml.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml b/guests/playbooks/build/projects/libvirt-ocaml.yml index 7a2e216..d293738 100644 --- a/guests/playbooks/build/projects/libvirt-ocaml.yml +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml @@ -25,3 +25,4 @@ ./configure --prefix=$VIRT_PREFIX $MAKE $MAKE opt + $MAKE check-manifest diff --git a/jenkins/projects/libvirt-ocaml.yaml b/jenkins/projects/libvirt-ocaml.yaml index 8eb03e3..158dee1 100644 --- a/jenkins/projects/libvirt-ocaml.yaml +++ b/jenkins/projects/libvirt-ocaml.yaml @@ -21,3 +21,4 @@ ./configure --prefix=$VIRT_PREFIX $MAKE $MAKE opt + $MAKE check-manifest -- 2.21.0

2 3

[libvirt] [dockerfiles PATCH v2 0/3] Update libosinfo (& friends) dockerfiles
by Fabiano Fidêncio 03 Sep '19

03 Sep '19

As osinfo-db-tools has recently switched to using meson instead of autotools, let's update the libosinfo-dockerfiles accordingly. Together with this change, let's also drop the "cross" Dockerfiles, as those were never working due to some gobject dependency not being multi architecture friendly on Debian. https://gitlab.com/fidencio/libvirt-dockerfiles/tree/wip/osinfo_db_tools_me… Fabiano Fidêncio (3): refresh: Remove "cross" Dockerfiles refresh: Remove Dockerfiles from OSes not supported by osinfo-db-tools refresh: Update Dockerfiles due to new osinfo-db-tools build system buildenv-libosinfo-centos-7.zip | Bin 458 -> 0 bytes buildenv-libosinfo-debian-10-cross-aarch64.zip | Bin 683 -> 0 bytes buildenv-libosinfo-debian-10-cross-armv6l.zip | Bin 682 -> 0 bytes buildenv-libosinfo-debian-10-cross-armv7l.zip | Bin 686 -> 0 bytes buildenv-libosinfo-debian-10-cross-i686.zip | Bin 682 -> 0 bytes buildenv-libosinfo-debian-10-cross-mips.zip | Bin 678 -> 0 bytes buildenv-libosinfo-debian-10-cross-mips64el.zip | Bin 689 -> 0 bytes buildenv-libosinfo-debian-10-cross-mipsel.zip | Bin 681 -> 0 bytes buildenv-libosinfo-debian-10-cross-ppc64le.zip | Bin 687 -> 0 bytes buildenv-libosinfo-debian-10-cross-s390x.zip | Bin 680 -> 0 bytes buildenv-libosinfo-debian-10.zip | Bin 555 -> 559 bytes buildenv-libosinfo-debian-9-cross-aarch64.zip | Bin 682 -> 0 bytes buildenv-libosinfo-debian-9-cross-armv6l.zip | Bin 681 -> 0 bytes buildenv-libosinfo-debian-9-cross-armv7l.zip | Bin 685 -> 0 bytes buildenv-libosinfo-debian-9-cross-mips.zip | Bin 678 -> 0 bytes buildenv-libosinfo-debian-9-cross-mips64el.zip | Bin 689 -> 0 bytes buildenv-libosinfo-debian-9-cross-mipsel.zip | Bin 680 -> 0 bytes buildenv-libosinfo-debian-9-cross-ppc64le.zip | Bin 687 -> 0 bytes buildenv-libosinfo-debian-9-cross-s390x.zip | Bin 680 -> 0 bytes buildenv-libosinfo-debian-9.zip | Bin 554 -> 0 bytes buildenv-libosinfo-debian-sid-cross-aarch64.zip | Bin 683 -> 0 bytes buildenv-libosinfo-debian-sid-cross-armv6l.zip | Bin 682 -> 0 bytes buildenv-libosinfo-debian-sid-cross-armv7l.zip | Bin 686 -> 0 bytes buildenv-libosinfo-debian-sid-cross-i686.zip | Bin 683 -> 0 bytes buildenv-libosinfo-debian-sid-cross-mips.zip | Bin 678 -> 0 bytes ...denv-libosinfo-debian-sid-cross-mips64el.zip | Bin 689 -> 0 bytes buildenv-libosinfo-debian-sid-cross-mipsel.zip | Bin 681 -> 0 bytes buildenv-libosinfo-debian-sid-cross-ppc64le.zip | Bin 687 -> 0 bytes buildenv-libosinfo-debian-sid-cross-s390x.zip | Bin 680 -> 0 bytes buildenv-libosinfo-debian-sid.zip | Bin 555 -> 559 bytes buildenv-libosinfo-fedora-29.zip | Bin 488 -> 492 bytes buildenv-libosinfo-fedora-30.zip | Bin 551 -> 555 bytes buildenv-libosinfo-fedora-rawhide.zip | Bin 507 -> 512 bytes buildenv-libosinfo-ubuntu-16.zip | Bin 558 -> 0 bytes buildenv-libosinfo-ubuntu-18.zip | Bin 558 -> 0 bytes 35 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 buildenv-libosinfo-centos-7.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-aarch64.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-armv6l.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-armv7l.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-i686.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-mips.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-mips64el.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-mipsel.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-ppc64le.zip delete mode 100644 buildenv-libosinfo-debian-10-cross-s390x.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-aarch64.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-armv6l.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-armv7l.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-mips.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-mips64el.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-mipsel.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-ppc64le.zip delete mode 100644 buildenv-libosinfo-debian-9-cross-s390x.zip delete mode 100644 buildenv-libosinfo-debian-9.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-aarch64.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-armv6l.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-armv7l.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-i686.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-mips.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-mips64el.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-mipsel.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-ppc64le.zip delete mode 100644 buildenv-libosinfo-debian-sid-cross-s390x.zip delete mode 100644 buildenv-libosinfo-ubuntu-16.zip delete mode 100644 buildenv-libosinfo-ubuntu-18.zip -- 2.21.0

2 6