December 2019 - Devel - libvirt List Archives

[libvirt] [jenkins-ci PATCH] lcitool: Only install EPEL on CentOS
by Andrea Bolognani 12 Dec '19

12 Dec '19

This fixes a bug introduced by commit 0a7993d3ed30 which caused our machinery to try to install the epel-release on all targets, including the likes of Debian and even FreeBSD. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the build breaker rule. guests/playbooks/update/tasks/base.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index 8128975..f721e39 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -21,6 +21,8 @@ package: name: epel-release state: latest + when: + - os_name == 'CentOS' - name: Create OpenVZ key template: -- 2.23.0

1 0

[libvirt] [PATCH 0/8] Don't hold both monitor and agent jobs at the same time
by Jonathon Jongsma 12 Dec '19

12 Dec '19

We have to assume that the guest agent may be malicious, so we don't want to allow any agent queries to block any other libvirt API. By holding a monitor job and an agent job while we're querying the agent, any other threads will be blocked from using the monitor while the agent is unresponsive. Because libvirt waits forever for an agent response, this makes us vulnerable to a denial of service from a malicious (or simply buggy) guest agent. This series of patches attempts to remove any cases where we were holding both jobs at the same time, removes a convenience function which allows us to grab both jobs at once, and updates documentation regarding this issue. Jonathon Jongsma (8): qemu: don't take agent and monitor job for shutdown qemu: don't hold a monitor and agent job for reboot qemu: don't hold both jobs for suspend qemu: don't hold monitor and agent job when setting time qemu: don't hold monitor job for fsinfo qemu: don't hold monitor job for GetGuestInfo() qemu: remove use of qemuDomainObjBeginJobWithAgent() qemu: remove qemuDomainObjBegin/EndJobWithAgent() src/qemu/THREADS.txt | 58 +----- src/qemu/qemu_domain.c | 56 +----- src/qemu/qemu_domain.h | 7 - src/qemu/qemu_driver.c | 405 +++++++++++++++++++++++++---------------- 4 files changed, 258 insertions(+), 268 deletions(-) -- 2.21.0

3 15

[libvirt] [RFC PATCH 0/9] add virtiofs support (virtio-fs epopee)
by Ján Tomko 12 Dec '19

12 Dec '19

https://bugzilla.redhat.com/show_bug.cgi?id=1694166 A work in progress, but I'm sending it now to get the XML bikesh^Wdiscussion out of the way. TODO: * documentation (due to the requirement of shared memory and therefore a <numa> topology specification, this probably deserves a separate article on https://libvirt.org/kbase.html ) * validation - refuse unsupported combinations and block migration * remove a few hardcoded values * figure out the binary path from qemu interop config * leave queue-size and cache-size on their default values or expose them in XML * use FD passing for vhost-user-fs device as well * clean up the code Tested with: commit 320000e72ec0613e164ce9608d865396fb2da278 Author: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Wed Oct 30 14:17:18 2019 +0100 Merge tag 'iommu-fixes-v5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu and commit d3d2efbb0e37494708dde359a9d0f492f84833e8 Author: Dr. David Alan Gilbert <dgilbert(a)redhat.com> CommitDate: 2019-10-24 11:50:55 +0100 virtio-fs: Allow mapping of meta data version table from https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev git fetch https://gitlab.com/virtio-fs/qemu.git virtio-fs-dev (not yet merged upstream) Ján Tomko (9): qemu: address: take fsdriver type into account qemu: cmdline: take fsdriver into account qemu: add QEMU_CAPS_VHOST_USER_FS wip: tests: add xml2xml tests for virtio-fs wip: add XML -> ARGV tests for virtio-fs conf: qemu: add virtio-fs fsdriver type qemu: pass private data to qemuBuildFilesystemCommandLine wip: start virtiofsd wip: build vhost-user-fs device command line docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 67 +++++- src/qemu/qemu_domain.c | 4 + src/qemu/qemu_domain_address.c | 35 +++- src/qemu/qemu_extdevice.c | 191 ++++++++++++++++++ ...vhost-user-fs-fd-memory.x86_64-latest.args | 38 ++++ .../vhost-user-fs-fd-memory.xml | 38 ++++ ...vhost-user-fs-hugepages.x86_64-latest.args | 42 ++++ .../vhost-user-fs-hugepages.xml | 67 ++++++ tests/qemuxml2argvtest.c | 9 + .../vhost-user-fs-fd-memory.x86_64-latest.xml | 1 + .../vhost-user-fs-hugepages.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 3 + 17 files changed, 493 insertions(+), 14 deletions(-) create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-fd-memory.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-hugepages.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-hugepages.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-user-fs-fd-memory.x86_64-latest.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-user-fs-hugepages.x86_64-latest.xml -- 2.21.0

5 19

[libvirt] [jenkins-ci PATCH 0/2] lcitool: Refactor Dockerfile generation
by Andrea Bolognani 12 Dec '19

12 Dec '19

Andrea Bolognani (2): lcitool: Perform system update after enabling repos lcitool: Refactor Dockerfile generation guests/lcitool | 66 +++++++++++++++++++++++++------------------------- 1 file changed, 33 insertions(+), 33 deletions(-) -- 2.23.0

2 6

[libvirt] [PATCH v2 0/3] misc fixes for qemu domain validation/post-parse
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Daniel P. Berrangé (3): tests: add a domain ID to live status XML doc qemu: check os type / virt type / arch in validate callback qemu: honour parseOpaque instead of refetching caps src/qemu/qemu_domain.c | 54 ++++++++++--------- .../qemustatusxml2xmldata/vcpus-multi-in.xml | 2 +- tests/qemuxml2argvtest.c | 9 ++-- 3 files changed, 35 insertions(+), 30 deletions(-) -- 2.23.0

2 5

[libvirt] [PATCHv2 0/8] Remove VIR_STRNDUP
by Ján Tomko 12 Dec '19

12 Dec '19

Ján Tomko (8): Remove VIR_STRDUP usage that sneaked in in the meantime vsh: remove vshErrorOOM Remove VIR_STRNDUP usage with checked pointers Remove all the uses that use subtraction in their length argument Remove the rest of VIR_STRNDUP tests: delete tests for VIR_STR(N)DUP util: remove VIR_STRDUP and VIR_STRNDUP docs: hacking: document removal of VIR_STR(N)DUP docs/hacking.html.in | 10 +- src/bhyve/bhyve_parse_command.c | 6 +- src/conf/backup_conf.c | 4 +- src/conf/nwfilter_conf.c | 4 +- src/conf/nwfilter_params.c | 6 +- src/interface/interface_backend_udev.c | 8 +- src/libvirt_private.syms | 2 - src/libxl/xen_common.c | 29 +++--- src/libxl/xen_xl.c | 6 +- src/libxl/xen_xm.c | 9 +- src/lxc/lxc_driver.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_monitor_json.c | 14 +-- src/rpc/virnetlibsshsession.c | 7 +- src/util/vircgroupv1.c | 5 +- src/util/vircommand.c | 1 - src/util/virconf.c | 24 ++--- src/util/viriscsi.c | 3 +- src/util/virjson.c | 11 +- src/util/virkeyfile.c | 9 +- src/util/virsocketaddr.c | 5 +- src/util/virstoragefile.c | 6 +- src/util/virstring.c | 52 +--------- src/util/virstring.h | 69 ------------- src/util/virsysinfo.c | 3 +- src/vmware/vmware_conf.c | 6 +- tests/virstringtest.c | 136 ------------------------- tools/vsh.c | 16 +-- 28 files changed, 63 insertions(+), 394 deletions(-) -- 2.21.0

2 9

[libvirt] [jenkins-ci PATCH] lcitool: Fix invalid escape sequence
by Andrea Bolognani 12 Dec '19

12 Dec '19

Spotted by flake8. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/lcitool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index e87a805..d4dc1c8 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -723,7 +723,7 @@ class Application: {package_manager} install --no-install-recommends -y {pkgs} && \\ {package_manager} autoremove -y && \\ {package_manager} autoclean -y && \\ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\\1,' /etc/locale.gen && \\ + sed -Ei 's,^# (en_US\\.UTF-8 .*)$,\\1,' /etc/locale.gen && \\ dpkg-reconfigure locales """).format(**varmap)) if args.cross_arch: -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Fix locale handling
by Andrea Bolognani 12 Dec '19

12 Dec '19

Commit 3ce973f2fb38 introduced a new glibc-langpack-en mapping in order to make en_US.UTF-8 available on CentOS 8, but as it turns out we already had a mapping for that and we just needed to tweak it a bit. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 9 ++------- guests/vars/projects/base.yml | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 68664a0..d32ecf3 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -189,11 +189,6 @@ mappings: rpm: glibc-devel cross-policy-deb: foreign - glibc-langpack-en: - rpm: glibc-langpack-en - CentOS7: - OpenSUSE: - glibc-static: deb: libc6-dev rpm: glibc-static @@ -451,9 +446,9 @@ mappings: cross-policy-deb: foreign locales: - CentOS7: glibc-common deb: locales - Fedora: glibc-langpack-en + rpm: glibc-langpack-en + CentOS7: glibc-common FreeBSD: OpenSUSE: glibc-locale diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 9ebf249..29c10b4 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -14,7 +14,6 @@ packages: - gettext - git - glibc - - glibc-langpack-en - libtool - libtoolize - locales -- 2.23.0

2 2

[libvirt] [dockerfiles PATCH] Refresh after recent changes
by Andrea Bolognani 12 Dec '19

12 Dec '19

This makes the en_US.UTF-8 locale available on CentOS 8 and uses better named tags for CentOS images. The corresponding libvirt-jenkins-ci commit is 2c996a745a68. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. Text diff below. buildenv-libosinfo-centos-7.zip | Bin 572 -> 570 bytes buildenv-libosinfo-centos-8.zip | Bin 578 -> 586 bytes buildenv-libvirt-centos-7.zip | Bin 761 -> 758 bytes buildenv-libvirt-centos-8.zip | Bin 781 -> 791 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index b91f3aa..ac09cf5 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -1,4 +1,4 @@ -FROM centos:centos7 +FROM centos:7 RUN yum update -y && \ yum install -y epel-release && \ diff --git a/buildenv-libosinfo-centos-8.zip b/buildenv-libosinfo-centos-8.zip index e739059..6ac848e 100644 --- a/buildenv-libosinfo-centos-8.zip +++ b/buildenv-libosinfo-centos-8.zip @@ -1,4 +1,4 @@ -FROM centos:centos8 +FROM centos:8 RUN dnf update -y && \ dnf install 'dnf-command(config-manager)' -y && \ @@ -19,6 +19,7 @@ RUN dnf update -y && \ git \ glib2-devel \ glibc-devel \ + glibc-langpack-en \ gobject-introspection-devel \ gtk-doc \ hwdata \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index 4e9c3db..bc3041f 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -1,4 +1,4 @@ -FROM centos:centos7 +FROM centos:7 RUN yum update -y && \ yum install -y epel-release && \ diff --git a/buildenv-libvirt-centos-8.zip b/buildenv-libvirt-centos-8.zip index 5410201..bb014ea 100644 --- a/buildenv-libvirt-centos-8.zip +++ b/buildenv-libvirt-centos-8.zip @@ -1,4 +1,4 @@ -FROM centos:centos8 +FROM centos:8 RUN dnf update -y && \ dnf install 'dnf-command(config-manager)' -y && \ @@ -27,6 +27,7 @@ RUN dnf update -y && \ git \ glib2-devel \ glibc-devel \ + glibc-langpack-en \ glusterfs-api-devel \ gnutls-devel \ iproute \ -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Use more natural tags for CentOS base images
by Andrea Bolognani 12 Dec '19

12 Dec '19

Both the 'X' and 'centosX' tags are available on the registry, and they point to the same image; the former looks more natural though, so let's use that one. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/host_vars/libvirt-centos-7/docker.yml | 2 +- guests/host_vars/libvirt-centos-8/docker.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/docker.yml b/guests/host_vars/libvirt-centos-7/docker.yml index 59f7f12..5c2e299 100644 --- a/guests/host_vars/libvirt-centos-7/docker.yml +++ b/guests/host_vars/libvirt-centos-7/docker.yml @@ -1,2 +1,2 @@ --- -docker_base: centos:centos7 +docker_base: centos:7 diff --git a/guests/host_vars/libvirt-centos-8/docker.yml b/guests/host_vars/libvirt-centos-8/docker.yml index 10c2a50..aae78a2 100644 --- a/guests/host_vars/libvirt-centos-8/docker.yml +++ b/guests/host_vars/libvirt-centos-8/docker.yml @@ -1,2 +1,2 @@ --- -docker_base: centos:centos8 +docker_base: centos:8 -- 2.23.0

2 1